From patchwork Wed Nov 16 08:38:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Shixin X-Patchwork-Id: 20756 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp12027wru; Tue, 15 Nov 2022 23:56:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf79qJEH41YP414FoKrU93+YSp6XuBEiqGu1iDQSbnUVDKG2lDBTmCiowCNVXpq/Syt+Y8RX X-Received: by 2002:aa7:de88:0:b0:458:b42e:46e6 with SMTP id j8-20020aa7de88000000b00458b42e46e6mr18342012edv.375.1668585379744; Tue, 15 Nov 2022 23:56:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668585379; cv=none; d=google.com; s=arc-20160816; b=UemvZgtPpsZZ3t/t4rNCQnP0cyGXm4Lvsnz3Iz4t2HokS5pjy9RE5qhdaBH3X8xZK6 ojMzLlJi1TFaxkLTTVoW2bvOy+n/0LIW/jW3ZCT/m2rqytbavZL8T114sVoFyAX/BVG4 OHN63U9j5jVNFIKtKZYxsErfAh0sIWl6TyTkUwrws4Jj1chPvd6l28tbbLl+z15hzTv1 QmJlpWjRwoWCAkpkCO45izY2mtO981o7He9HLSlbofkrWxziU+jYl3Ytqhmoh/MW4tM6 4X7KVGDC2gqR2NhTN+806i93DcfHHIaVC8AO1ifFZyNyZCNc8qaamdH2vyb6Dm/J7ULf hIDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=XcfLpoJTAW+zw7Z9uCMFG3xHDpVv6NMfvOMGwjNGisQ=; b=GEfVBKZN9125uvSPCkQ+OvMvPsKAcUTqUBhiNJjT1baymyQsAsGbH+Z/tG3hFc5/72 qSKEBTkKy0aLTwM1wZZhZ2i+HVOp0ifx671ef3w6h/6lHfIQe3RTY0I2kYAiC1Hjy76T 4iBIkQ0/S+6IlAFGqftrxMD2iqlVWu49fHrYu03Wy99+q/GqJDGA3wSo8o9SWqzSX/3H 58MoLaC1I0D2mo3pA6zovNDNaylImocf4M/uPmeLUTGhc7/NWVklnB+DvtrHnopZGDAQ Kjs3U5ca1cYItOLoXyDNPU2orG9coF3K3aL/AXk4q1xlRLJmV8ZoKUrmRRC6FAII8Yqv uunw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i8-20020a0564020f0800b0045cfa0b1f46si7395721eda.11.2022.11.15.23.55.56; Tue, 15 Nov 2022 23:56:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232714AbiKPHvH (ORCPT + 99 others); Wed, 16 Nov 2022 02:51:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231811AbiKPHvD (ORCPT ); Wed, 16 Nov 2022 02:51:03 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8658D13D21 for ; Tue, 15 Nov 2022 23:51:02 -0800 (PST) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NBw9s0CdyzqSPG; Wed, 16 Nov 2022 15:47:13 +0800 (CST) Received: from dggpemm100009.china.huawei.com (7.185.36.113) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 16 Nov 2022 15:51:00 +0800 Received: from huawei.com (10.175.113.32) by dggpemm100009.china.huawei.com (7.185.36.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 16 Nov 2022 15:51:00 +0800 From: Liu Shixin To: Catalin Marinas , Will Deacon , Denys Vlasenko , Kefeng Wang , Anshuman Khandual , David Hildenbrand , Rafael Aquini , Pasha Tatashin CC: , , Liu Shixin Subject: [PATCH 1/2] arm64/mm: fix incorrect file_map_count for non-leaf pmd/pud Date: Wed, 16 Nov 2022 16:38:10 +0800 Message-ID: <20221116083811.464678-2-liushixin2@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221116083811.464678-1-liushixin2@huawei.com> References: <20221116083811.464678-1-liushixin2@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.113.32] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm100009.china.huawei.com (7.185.36.113) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749638582885689564?= X-GMAIL-MSGID: =?utf-8?q?1749638582885689564?= The page table check trigger BUG_ON() unexpectedly when collapse hugepage: ------------[ cut here ]------------ kernel BUG at mm/page_table_check.c:82! Internal error: Oops - BUG: 00000000f2000800 [#1] SMP Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: CPU: 6 PID: 68 Comm: khugepaged Not tainted 6.1.0-rc3+ #750 Hardware name: linux,dummy-virt (DT) pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : page_table_check_clear.isra.0+0x258/0x3f0 lr : page_table_check_clear.isra.0+0x240/0x3f0 [...] Call trace: page_table_check_clear.isra.0+0x258/0x3f0 __page_table_check_pmd_clear+0xbc/0x108 pmdp_collapse_flush+0xb0/0x160 collapse_huge_page+0xa08/0x1080 hpage_collapse_scan_pmd+0xf30/0x1590 khugepaged_scan_mm_slot.constprop.0+0x52c/0xac8 khugepaged+0x338/0x518 kthread+0x278/0x2f8 ret_from_fork+0x10/0x20 [...] Since pmd_user_accessible_page() doesn't check if a pmd is leaf, it decrease file_map_count for a non-leaf pmd comes from collapse_huge_page(). and so trigger BUG_ON() unexpectedly. Fix this problem by using pmd_leaf() insteal of pmd_present() in pmd_user_accessible_page(). Moreover, use pud_leaf() for pud_user_accessible_page() too. Fixes: 42b2547137f5 ("arm64/mm: enable ARCH_SUPPORTS_PAGE_TABLE_CHECK") Reported-by: Denys Vlasenko Signed-off-by: Liu Shixin Reviewed-by: David Hildenbrand Acked-by: Pasha Tatashin --- arch/arm64/include/asm/pgtable.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index 71a1af42f0e8..edf6625ce965 100644 --- a/arch/arm64/include/asm/pgtable.h +++ b/arch/arm64/include/asm/pgtable.h @@ -863,12 +863,12 @@ static inline bool pte_user_accessible_page(pte_t pte) static inline bool pmd_user_accessible_page(pmd_t pmd) { - return pmd_present(pmd) && (pmd_user(pmd) || pmd_user_exec(pmd)); + return pmd_leaf(pmd) && (pmd_user(pmd) || pmd_user_exec(pmd)); } static inline bool pud_user_accessible_page(pud_t pud) { - return pud_present(pud) && pud_user(pud); + return pud_leaf(pud) && pud_user(pud); } #endif From patchwork Wed Nov 16 08:38:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Shixin X-Patchwork-Id: 20758 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp12160wru; Tue, 15 Nov 2022 23:56:49 -0800 (PST) X-Google-Smtp-Source: AA0mqf5YDHWLWWL1IQaDQsm91fGjRHswjRYQgMpyVvO5U9i1soTk1RljZedmTWPHrbkzxT+Xe7l0 X-Received: by 2002:a17:90b:3a8d:b0:210:5de0:f3e3 with SMTP id om13-20020a17090b3a8d00b002105de0f3e3mr2477159pjb.61.1668585409028; Tue, 15 Nov 2022 23:56:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668585409; cv=none; d=google.com; s=arc-20160816; b=PHrtZY4tnCjy9Erav/rp8FdCihx6rwrQKNXJWLSrMEUacTUkD84xoVWOLzVV2RWZjT KAnolaTBhW/HqNDZuWIIkjuilOgpcH9b+3ikCeek7xVesTDx6gKcIvIQAGgzrAyvhmm8 vm7gCn0F96mdSYUJFEAVywCk36Q4GunYJ9Rfugq6gfIuPZGRjM2x2QsvJ4Oz9Fa/MqEy H3wru6VtkQAJncdHsyqOTt7aPNL3lXzMs35jGe1vRgXBYcbfCs5jWxJLlnLdf6RfjZWl BOWlDPJ4Pk6XRxOqxt+r/63oyEwjoViRaM8UcGWiXKw9DByX/n8go0sP/RNJ4dHKGwSJ 74LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=hh+GG7klkx4TeJ32mrCN5Rnn5BNFEGZKTmT7eD7ZjsM=; b=bl0KUVNtAeevCLfRDyui0Zv6S4vQhbv6yF84jCsjmd/DcEWwfhKXTZ8NqvxmGJQtD9 JJal7/ud4DDWEKLkNaelgPiUo81/MGFMomTmuJ4HgyzyiXv7Vhi5EJTlAFWI6Alp9YNE 1tVo1yRaTq0DR4+EZjwJp/DitCr5zkDKVEZX5ZHyUcEtXBH7M7sTh1i1zzB+UUnYdmKZ PYvUUBIpVsPWRZWda0Uex23ergiz1ISnUFbinwBtfz8nBNajNdPFXUcm3vDYNZp8Ux1A Ebykdq3MdRptvw7vocAM52PMnFJbOIFfv28BnbNmA3J4BkqqKhW0z0xJKhsMiybDpWVN lSYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n2-20020a638f02000000b004622caf9ac6si13907544pgd.781.2022.11.15.23.56.35; Tue, 15 Nov 2022 23:56:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232324AbiKPHvO (ORCPT + 99 others); Wed, 16 Nov 2022 02:51:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232527AbiKPHvE (ORCPT ); Wed, 16 Nov 2022 02:51:04 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02D2013D3A for ; Tue, 15 Nov 2022 23:51:03 -0800 (PST) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NBwFs6TCXzRpMy; Wed, 16 Nov 2022 15:50:41 +0800 (CST) Received: from dggpemm100009.china.huawei.com (7.185.36.113) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 16 Nov 2022 15:51:01 +0800 Received: from huawei.com (10.175.113.32) by dggpemm100009.china.huawei.com (7.185.36.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 16 Nov 2022 15:51:00 +0800 From: Liu Shixin To: Catalin Marinas , Will Deacon , Denys Vlasenko , Kefeng Wang , Anshuman Khandual , David Hildenbrand , Rafael Aquini , Pasha Tatashin CC: , , Liu Shixin Subject: [PATCH 2/2] arm64/mm: fix incorrect file_map_count for invalid pmd/pud Date: Wed, 16 Nov 2022 16:38:11 +0800 Message-ID: <20221116083811.464678-3-liushixin2@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221116083811.464678-1-liushixin2@huawei.com> References: <20221116083811.464678-1-liushixin2@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.113.32] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm100009.china.huawei.com (7.185.36.113) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749638613600387369?= X-GMAIL-MSGID: =?utf-8?q?1749638613600387369?= The page table check trigger BUG_ON() unexpectedly when split hugepage: ------------[ cut here ]------------ kernel BUG at mm/page_table_check.c:119! Internal error: Oops - BUG: 00000000f2000800 [#1] SMP Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: CPU: 7 PID: 210 Comm: transhuge-stres Not tainted 6.1.0-rc3+ #748 Hardware name: linux,dummy-virt (DT) pstate: 20000005 (nzCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : page_table_check_set.isra.0+0x398/0x468 lr : page_table_check_set.isra.0+0x1c0/0x468 [...] Call trace: page_table_check_set.isra.0+0x398/0x468 __page_table_check_pte_set+0x160/0x1c0 __split_huge_pmd_locked+0x900/0x1648 __split_huge_pmd+0x28c/0x3b8 unmap_page_range+0x428/0x858 unmap_single_vma+0xf4/0x1c8 zap_page_range+0x2b0/0x410 madvise_vma_behavior+0xc44/0xe78 do_madvise+0x280/0x698 __arm64_sys_madvise+0x90/0xe8 invoke_syscall.constprop.0+0xdc/0x1d8 do_el0_svc+0xf4/0x3f8 el0_svc+0x58/0x120 el0t_64_sync_handler+0xb8/0xc0 el0t_64_sync+0x19c/0x1a0 [...] On arm64, pmd_present() will return true even if the pmd is invalid. So in pmdp_invalidate() the file_map_count will not only decrease once but also increase once. Then in set_pte_at(), the file_map_count increase again, and so trigger BUG_ON() unexpectedly. Fix this problem by adding pmd_valid() in pmd_user_accessible_page(). Moreover, add pud_valid() for pud_user_accessible_page() too. Fixes: 42b2547137f5 ("arm64/mm: enable ARCH_SUPPORTS_PAGE_TABLE_CHECK") Reported-by: Denys Vlasenko Signed-off-by: Liu Shixin Acked-by: Pasha Tatashin --- arch/arm64/include/asm/pgtable.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index edf6625ce965..56e178de75e7 100644 --- a/arch/arm64/include/asm/pgtable.h +++ b/arch/arm64/include/asm/pgtable.h @@ -863,12 +863,12 @@ static inline bool pte_user_accessible_page(pte_t pte) static inline bool pmd_user_accessible_page(pmd_t pmd) { - return pmd_leaf(pmd) && (pmd_user(pmd) || pmd_user_exec(pmd)); + return pmd_leaf(pmd) && (pmd_user(pmd) || pmd_user_exec(pmd)) && pmd_valid(pmd); } static inline bool pud_user_accessible_page(pud_t pud) { - return pud_leaf(pud) && pud_user(pud); + return pud_leaf(pud) && pud_user(pud) && pud_valid(pud); } #endif