From patchwork Wed Nov 16 06:57:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 20741 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:ee07:0:0:0:0:0 with SMTP id y7csp5966wrn; Tue, 15 Nov 2022 23:03:26 -0800 (PST) X-Google-Smtp-Source: AA0mqf6x2ASuR5iLF3zzFYuQBvE5CaYqH3g0BEVxbasfdqYGtD7A+SoLyNdP8Ngvzdd8i8fX4fcQ X-Received: by 2002:a17:902:cf4c:b0:185:4703:9f5f with SMTP id e12-20020a170902cf4c00b0018547039f5fmr7848454plg.156.1668582205750; Tue, 15 Nov 2022 23:03:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668582205; cv=none; d=google.com; s=arc-20160816; b=Sbv9TbkLDyGss0PssEIgrCg09xyAuh+QFheNMnDzWlQ5ofv2NHdYQvL1/SPY9OlhVJ sW4ej68CimbRWSnsXPbirHNnTItgykxgwYFdQDOeJGDPY8f38iNAEhVMyeI0PCaoZOfH ZmUnHDYc8IXlMYFZSnoERXdeIbODBceH+MFAJXuLvwI/aI7xvoVFRGs7cZb5t61aoUzO eYRAiuj/mawIuN12jj2clQujugbE+Iu7QwaiPWgnUTVigqmFRzU4qUBeooBUGaaVjfqN sYRwHJjPNjYUGgA3T8nYLrBQJWB4ewMe0o3Djh8fatiPvq2L3L/JXwj46E4orwyl3QDd 5sXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=v6GLnZPPmodPUTZbnN5eKMie3uHVUYNmyDThmi0SjYw=; b=RZ4Opq7VPmPF/f7l2EGzlCfqGdNm9YNAM5+/Jlhs8Mka3ETKN89BCM8vH+Zf7f97Gm jU1DM+erw7EH37bL9JIQbbJbU6hqn2Al11g6wvsUK8p30DV8f7/LtoNod6A/LSBm9Yqu zVHnW8KRM1o+GDfqWMWYUbINvyAVtyyZbdCmSqvdeZpxZJ20at15pKnBhawtUkBIbng9 dmVCpbU09s8J9irw5GX0m+PQ6wxvezHJ8OdyyIj/KsV3VkpTJwLnUaijKzAZIoIKgnx5 UhAUsBwXEedSx1S1P9qQht9zeqjBeXOAr9uQ0MLyHGNf0zOjDTuWxN+rTU23vmnGz0ca D0IQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k5-20020a63ff05000000b0046b03475683si13816549pgi.831.2022.11.15.23.03.05; Tue, 15 Nov 2022 23:03:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231502AbiKPHAh (ORCPT + 99 others); Wed, 16 Nov 2022 02:00:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231547AbiKPHAg (ORCPT ); Wed, 16 Nov 2022 02:00:36 -0500 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1BF917E3F; Tue, 15 Nov 2022 23:00:31 -0800 (PST) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NBv4K1RdpzJnlG; Wed, 16 Nov 2022 14:57:21 +0800 (CST) Received: from huawei.com (10.67.175.83) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 16 Nov 2022 15:00:29 +0800 From: ruanjinjie To: , , , , CC: Subject: [PATCH v2] dmaengine: ste_dma40: use devm_request_irq to avoid missing free_irq() in error path Date: Wed, 16 Nov 2022 14:57:17 +0800 Message-ID: <20221116065717.3069712-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.67.175.83] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749635254719788166?= X-GMAIL-MSGID: =?utf-8?q?1749635254719788166?= free_irq() is missing in some cases of error in d40_probe(), use devm_request_irq to fix that. Fixes: d7b7ecce4bcb ("ste_dma40: Rename a jump label in d40_probe()") Signed-off-by: ruanjinjie Reviewed-by: Linus Walleij --- v2: - use devm_request_irq instead of adding free_irq() to fix the problem. --- drivers/dma/ste_dma40.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index f093e08c23b1..3214d2cb027e 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -3598,7 +3598,7 @@ static int __init d40_probe(struct platform_device *pdev) base->irq = platform_get_irq(pdev, 0); - ret = request_irq(base->irq, d40_handle_interrupt, 0, D40_NAME, base); + ret = devm_request_irq(&pdev->dev, base->irq, d40_handle_interrupt, 0, D40_NAME, base); if (ret) { d40_err(&pdev->dev, "No IRQ defined\n"); goto destroy_cache;