From patchwork Tue Feb 13 11:20:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 200389 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp470785dyb; Tue, 13 Feb 2024 03:28:51 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUCAjyzJILa53+o7Gu3JVH+/eCreZo34Z0YSGwa9YwrwMdxSBtWyh+X8rM9OJV4Etx9uQE4YgJ/8ZwdfRxsI7cDW+NazA== X-Google-Smtp-Source: AGHT+IGOOr3gTsAIRj0v3eiRMlFRtGKIMrVkxtR0ZeapYcOasGOgudVl1NJ/u+0ZqjuWe+ZriRFP X-Received: by 2002:a17:902:eaca:b0:1da:2128:eb31 with SMTP id p10-20020a170902eaca00b001da2128eb31mr7176921pld.65.1707823731748; Tue, 13 Feb 2024 03:28:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707823731; cv=pass; d=google.com; s=arc-20160816; b=EJFA2gOhAdY6ILU+Ry/yeuJgPI2IJgDvuNNRobcQqYCQuMpnYtEleyyB4BIH3TAqcd tPnq/4S6vvt1c2anx4D7/YMrWLMtPVFDX0PX07saYgIY8HM1ZAACrBRjHceOkIabDBti RxxQp/4cCYGH/mUs69dmbGMUcp80Dfzq05PWbXK/yVx6iNB/ku7Z8rLoHO7UQH9dQZnu wqWyvAlN9M5aKKBRw9YLW6NY1SU2oDVQdkxWA+khKAr4p3wz8WQo792Fo8iNPjWSdj7E Ub8yU/EpMCNoeRf8ikRhw0AbwjBAs7IWoLsRS/Fjhz0lyGXARx+1GwhcYH3VgVhwUQDf OSPQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=TXIepoLr6xh9qgVTJivliuOFkSATfVwRu/J3Qc9prjQ=; fh=xEWiNTJ23u+cNY6r9J/dG5eZtHswowtTrDcdFl3rLZM=; b=hPdPKN7MxV4MKP/mDjqapEOJ8GHVotAiMhzV0Vstqf1FaK6bc+HXCWLE2e6Lwa8zL9 XOA/uHqgiMMm3m2SFZO7MTIRZQ6JuEfMHjgdX1/6XWWUv/zbZgbQuNFRUFcnnxx4+D/i 4F1mfxzDg8wWWFRP4Yw+nfy4vQjHSGwZmL5nU2nyA4o8b3qfOYP4lk/Kjt82DdxrSwYi xQR5mhEC3Z9+i3VgGxHzupre1ExZkvcZnQwmub+DmJLdjnW/DoFlUvjB6yT8NmW8QOvr +bZVxI8ppgmr0m+9o3Cj9bBCOXMXBKUHI0D2f/2WlehlaqDWvwLiiEcRfUK8Qc8RHNSU TUGg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Qmrk2F4r; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-63418-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63418-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCWis/5VDgAGFvT/DkHDTBFnfqO+11WWQvrsv4vhPUwG1zSqayxkLyxEDZeIHwIlu469ZfvrDWafAPaT78Zm7i6APeh1xA== Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id y2-20020a17090264c200b001d7297b8542si1855951pli.34.2024.02.13.03.28.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 03:28:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-63418-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Qmrk2F4r; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-63418-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63418-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 34B35B23012 for ; Tue, 13 Feb 2024 11:21:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5FDB8381A0; Tue, 13 Feb 2024 11:21:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qmrk2F4r" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3E0E3716F; Tue, 13 Feb 2024 11:21:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707823261; cv=none; b=SnSJaBMHsxHr9KH+jpvTIwgj06BA7WWiOTKZcSKQIzQ/lSemJWd3X5/LkBH53D5KHO2lXS+ap330Nb9jgkaH55qYoEEkYNucCSVtHXUKfFQP7OXTU1sBelTYs/GF7ZiNATOL8qq1pQRq4Nraz+FR9im5PRw4jocdS+sRJLyZR9E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707823261; c=relaxed/simple; bh=2Ywh4OzY0chZDpnSXV5NPQrPw3P/Ggi/eWmN3vNLbvs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AFKM6fSTXUrfqx7ZFxI+yL/aNP4LiJ6rGRJYDxhUPGwU9cfwmdYSGz+2lbw4FutSohqx1GYQ5obPfU8I4tNyjQ7o839wvG4HOkQ9d9C3RfozwKTCnBI+u95/nQWjB5vQlyJXCDH5DDovfmTjiXqxy9C30U8LkE11r0LmZKTv6Rg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Qmrk2F4r; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60626C433C7; Tue, 13 Feb 2024 11:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707823261; bh=2Ywh4OzY0chZDpnSXV5NPQrPw3P/Ggi/eWmN3vNLbvs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Qmrk2F4rCd2WSIl36Y6lDgYxriYXibf5WUnr64oOngjSxBCVQrpuAlmOY3mQif9++ NsCxVVnhF4vSJmkHAVA9o8MNQjg0B5PCM8nzkP2YZ4VZl4tCbr1tOxdP/5ePHyT4cT 57G8frJcO2TbDcDVtXCPEkjEtYedPNgGW6yO3quk+V0kOe4lSUld4pJmsfl4lly70Z QNlW89CUBsbx5rm3otlRRKbuSRlUOHTu2eS/2Kne+GxrzyJsgfLKDSkldRG/qBxIAi bu9rIvDS9Z5CP0ScTfomqKn68xmrM2uek4Ju5sAPrHIsv0L1rXgGwIGbeZw/eRFxUt yYg4SM0R8q6SQ== From: "Jiri Slaby (SUSE)" To: bp@alien8.de Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Yazen Ghannam , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter , linux-edac@vger.kernel.org Subject: [PATCH 1/7] EDAC/amd64: Remove amd64_pvt::ext_nbcfg Date: Tue, 13 Feb 2024 12:20:45 +0100 Message-ID: <20240213112051.27715-2-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240213112051.27715-1-jirislaby@kernel.org> References: <20240213112051.27715-1-jirislaby@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790782977655535922 X-GMAIL-MSGID: 1790782977655535922 Commit cfe40fdb4a46 (amd64_edac: add driver header) added amd64_pvt struct with ext_nbcfg in it. But noone used that member since then. Therefore, remove it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Yazen Ghannam Cc: Borislav Petkov Cc: Tony Luck Cc: James Morse Cc: Mauro Carvalho Chehab Cc: Robert Richter Cc: linux-edac@vger.kernel.org Reviewed-by: Yazen Ghannam --- drivers/edac/amd64_edac.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/edac/amd64_edac.h b/drivers/edac/amd64_edac.h index 1665f7932bac..b879b12971e7 100644 --- a/drivers/edac/amd64_edac.h +++ b/drivers/edac/amd64_edac.h @@ -345,7 +345,6 @@ struct amd64_pvt { u32 dchr1; /* DRAM Configuration High DCT1 reg */ u32 nbcap; /* North Bridge Capabilities */ u32 nbcfg; /* F10 North Bridge Configuration */ - u32 ext_nbcfg; /* Extended F10 North Bridge Configuration */ u32 dhar; /* DRAM Hoist reg */ u32 dbam0; /* DRAM Base Address Mapping reg for DCT0 */ u32 dbam1; /* DRAM Base Address Mapping reg for DCT1 */ From patchwork Tue Feb 13 11:20:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 200381 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp468065dyb; Tue, 13 Feb 2024 03:21:59 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXewUfSrOI5TltscSIWnnNjD+Qc2Jzao40d+aCoqKpLewDrzBPyYT5BQZ8Mq2JSUnU1oG/6Nokwrarj0KX2YvCqoGMAWQ== X-Google-Smtp-Source: AGHT+IHbRRn4ByK8iF8L0Ejhi9RHYtkaYTCt3fQCQ53OJYCsMJYUdJ4Oqr2QwiLy8NkDRVTYlMZE X-Received: by 2002:a05:6122:181e:b0:4c0:7753:231 with SMTP id ay30-20020a056122181e00b004c077530231mr6304888vkb.13.1707823319400; Tue, 13 Feb 2024 03:21:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707823319; cv=pass; d=google.com; s=arc-20160816; b=FdgkucKXnBUxn+pcR4O05V5/n2RuehzVQMx+p2llG2eGFlMMLFYe6P+Ww36ZTQDRLj LgEXn1LeEcSkQ235Jz5Fj7oSKI5Cp0/7RPcZiIc4ORPaaqcQZZvEdIxUbmAosWem4QzS TmDt9R0Vr2xRMXtfx2rL+BBRzKNT7NEXBag6r/XO6CYnhJpS34P9huAHpIoMjCesH/7A RPWF/4FpyJd2rLb/GypuuPMm0ooGzwKIZexwenvt1pKgLx19Hl0J5CQVSpeceJe4Lx5+ XwzuhLecSIvh01z0hUIPGT68lCeDK8lzBf3Op2NmbUvj5uLckC2DG+AYpgNVq9+OO56W 5WIA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=6HpWGQjY40E/bzBGDk5EafmdTAcragUWE4L/7by75Qw=; fh=Hpe8x3F7jDm0rJNKydpUywJHdkrkiZnnEju96pOs/9I=; b=zAzbYXkprZybpFnsb1cabenXNQZlp+5zyTVM0+CuZAW6hjH3Uo+EPrQuRYJLepAj7+ gmV0Zob9wSW5AHtkMxES8F63MNb1ZUIOLn80qDVfsOESnusMCRkKpAWcUTzNwt708CUT 4Bk4gsAVT37S7Ct1sCoUcEym7QVnZJZ4zh0LVd9C/AGtnUNTVoxhCnTsIDvFk5aJ9JN3 T53qZG2mDiqONMbWBrf6w3qBA6Xhx47f38CVqSe1TgI9TBL3Y7lUJG15U+scNTO0ixcO 86zchaBSRmPh/BVNCALIH0un+isLsWsgk/3A+f3ck9fG/sD5DObqhBJ3ndfxtypGqIam 2RhA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=u1nKU+9s; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-63419-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63419-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCXnCuFpRHCV1Df93kKtiJaGIH9ftIsrrMv/pX7ateExD/vTTm53PmxHfCMImhlZGedrAXtutCtGhk89+vy/SnEGLa95QQ== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 10-20020a056214202a00b0068c7a7ed57csi2574466qvf.540.2024.02.13.03.21.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 03:21:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-63419-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=u1nKU+9s; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-63419-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63419-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 13CC91C22A4B for ; Tue, 13 Feb 2024 11:21:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B676439FE1; Tue, 13 Feb 2024 11:21:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="u1nKU+9s" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D6DE3838B; Tue, 13 Feb 2024 11:21:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707823265; cv=none; b=tNZzLFEU80tsxfkJj6+pMx7LA3SqLpLZsrwQI3ayiIOSjmpGWmgpVFcTsu/T7cHLin5f3QkdEGZjRt4bZD7qXNBmlB143lmdzFyrwvxV8FZMz+7wdVKgGw/JxCkzjC+bwpqPCv4QhgR+QNg1d/1AOpbj14lJci1UzVSJkpJr9/Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707823265; c=relaxed/simple; bh=iSGTy1weM6BB1E4whQVWIFf+UuG8A2NUShVr01qyUoU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iW3p8/4P1XhjZCSNICBv7E2L+Yi4ZiGDexWLWh3GYkYyyzvBtD2tqDSo7BiyVaLQDf7rCOL3/FE4MZLZeZM/PTUZNRTf7236mjOlPFhvZtV2MzC/gzd0r5A3i2J681uK72Y2pqUw6lwC4wco8N28PG/vaU0Tfjlf70FvlxLfRSc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=u1nKU+9s; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA149C433B1; Tue, 13 Feb 2024 11:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707823263; bh=iSGTy1weM6BB1E4whQVWIFf+UuG8A2NUShVr01qyUoU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u1nKU+9sfquXXqkd6qyBkxjqnS0AFPguGvx53BQw02NAU5I1tvz2rW3d556C6cgFw AU508gCgj2+AtwMbOOCE0vH/JA2enqcK8wKQvxQKnRA0NmW4/H6s+K/3XYV8kCt4X4 QnyLN+P0JeTN9aIcPLIVMylj7lBJj5ErR1b7ESy10sB7sABhoAnEscJ81FKfBUnSY8 Jf/nzgAuJFteIOVjviatJdFz1sFnO5Hsu6wqvRtPveopFwOm606da6k2qSbbYvanYx snqKquOrmW58aMT6H9jXkjO/Zf3lv7fY09AVSh5Tbpg0DRuwtjv6jmpJ1V/zNg16/g hBbq7yqgs2yvg== From: "Jiri Slaby (SUSE)" To: bp@alien8.de Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Douglas Thompson , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter , linux-edac@vger.kernel.org Subject: [PATCH 2/7] EDAC/device: Remove edac_dev_sysfs_block_attribute::{block,value} Date: Tue, 13 Feb 2024 12:20:46 +0100 Message-ID: <20240213112051.27715-3-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240213112051.27715-1-jirislaby@kernel.org> References: <20240213112051.27715-1-jirislaby@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790782544980021080 X-GMAIL-MSGID: 1790782544980021080 It's unused. And it never was since its addition in fd309a9d8e63e (drivers/edac: fix leaf sysfs attribute). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Douglas Thompson Cc: Borislav Petkov Cc: Tony Luck Cc: James Morse Cc: Mauro Carvalho Chehab Cc: Robert Richter Cc: linux-edac@vger.kernel.org --- drivers/edac/edac_device.c | 2 -- drivers/edac/edac_device.h | 6 ------ 2 files changed, 8 deletions(-) diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c index 0689e1510721..0e18729111d4 100644 --- a/drivers/edac/edac_device.c +++ b/drivers/edac/edac_device.c @@ -162,8 +162,6 @@ edac_device_alloc_ctl_info(unsigned pvt_sz, char *dev_name, unsigned nr_instance attrib->show = attrib_spec[attr].show; attrib->store = attrib_spec[attr].store; - attrib->block = blk; /* up link */ - edac_dbg(4, "alloc-attrib=%p attrib_name='%s' attrib-spec=%p spec-name=%s\n", attrib, attrib->attr.name, &attrib_spec[attr], diff --git a/drivers/edac/edac_device.h b/drivers/edac/edac_device.h index 7db22a4c83ef..c4704b5b1e9f 100644 --- a/drivers/edac/edac_device.h +++ b/drivers/edac/edac_device.h @@ -99,18 +99,12 @@ struct edac_dev_sysfs_attribute { * can have an array of the following. The show and store functions * will be filled in with the show/store function in the * low level driver. - * - * The 'value' field will be the actual value field used for - * counting */ struct edac_dev_sysfs_block_attribute { struct attribute attr; ssize_t (*show)(struct kobject *, struct attribute *, char *); ssize_t (*store)(struct kobject *, struct attribute *, const char *, size_t); - struct edac_device_block *block; - - unsigned int value; }; /* device block control structure */ From patchwork Tue Feb 13 11:20:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 200382 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp468243dyb; Tue, 13 Feb 2024 03:22:28 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWIwlyImcPZOuy6LkyqKb23BzqZW8v+wEo97pTZ3e3sjl2EFLcVVXBMywGi5M7BEzgLRQwdm5Az5qEMzOv6tiHcYb6USA== X-Google-Smtp-Source: AGHT+IGUJoga+h9eqY0FC1NT5Dheu6gmA4SmoNkozU2oubb3+f59QrtNJ5So4Dre2bDqjVg3O+0+ X-Received: by 2002:a05:6402:33c8:b0:55f:8031:501c with SMTP id a8-20020a05640233c800b0055f8031501cmr7375118edc.30.1707823348679; Tue, 13 Feb 2024 03:22:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707823348; cv=pass; d=google.com; s=arc-20160816; b=UIqwxWQN0pdPSVS+DpCXJZV4ZQFflJDbsnecBPNx1+q0O+Ug3M4734boRRKj7I4AZz 5cOl13LdP5UpBPMqaXk9nkKzjoSaH/TLyY+jXohlrvxcrma1f66ngYqdzGMw+uBt9Nac XfaVdjlT7rvy/ErE+dkMA3UM1LBzWChF6ctXI6LQyifMI4IVMD67+0EFbwY6/gDG648J KulycuWyu9ERy8356bf/kTtvzhUqaZuP1+m46101bj4JzP8Gi31UhYqmuqZdUx6n8wDL oU6LmlpkBLOGFuRXEzZr5G1UL7/6HDt7waM7lXbY2v0mrc2OExFBSql25Eg5QJufbIWu 7v7A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=efKaPOQN0Y+Nc1PCL8PNTKe/appDOzLe6Bxumrjm4sY=; fh=XWzWLxyHcelqpmEpr9W5uIySLqDIKodB3W6PzZf2uDQ=; b=n85lfJ14qd22tYTdoYxdKZWWOAQwVcc136j3NkrCokRll8T5vXlfxa7qUEC8ASJ7Tj 7XTeb8v2iUa8HIOnwwsGS0N8d+WVVWpO4zgWLalgny7gxSAnOl/zx3BD6e6gLydRK0Z0 VZiUi0gtgFKztE6mLvbkvQIfVUBzdZzWTooKXjsGxRRN044MQeiYynIHMeEiL7aL97kY qoKr4kY5ZfwOxTuuagZGVUB8L5gaoUAA9tyTbeIsUIdZlaCBMZkGhTwvTCaXrSaSPWCe Js2M7cGJo9EnTSfxaZ7Pt7FRPvJP43fMVGBNR0Bh+tjIeHrFDlxs1Q5+2Dnfoaruaftf Y2+A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="gINsw+/o"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-63420-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63420-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCV+AxyTGUwdNdYnTsOIsPvzQNFNQX19OCPu8useBgD0LIvb7zprwHwIbGfT2WN4iRMGjyA5xOGliipcwV4VuknywZ1ZzQ== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id f22-20020a50a6d6000000b0055fbc52463bsi3698849edc.601.2024.02.13.03.22.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 03:22:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-63420-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="gINsw+/o"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-63420-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63420-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4118D1F26F00 for ; Tue, 13 Feb 2024 11:22:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 145393B79E; Tue, 13 Feb 2024 11:21:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gINsw+/o" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87BB038DDA; Tue, 13 Feb 2024 11:21:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707823266; cv=none; b=ZQscZPzLNq2oBZh7VYnbg3w/Yht7Nms6KmQ1iWjUCF/I2srKqaI+/8yLDj43gqJzAsl5j9axaSRhTxQpO8KWvLpgtEPnVXn4xNZ124Zk4gKBDWGpcki5jw8B6Ws7bM+nTXcEuUPllmdUSmFEYB29dyxsq6yCOflG9/mPO/3t4XI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707823266; c=relaxed/simple; bh=AJUvsaAkLNAUPAonfLONk+9L24hzUQDc/XjcjTFJY20=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r1MuamCcXdOxZmKYM+Lyh8Q3Sg/l04t/NrFhveaMwugPMA8vsvrDqzvKDdMwAw6b5+eLE8/mVRxlOFtjky2qqTsn2WxWMtvh+7JQH19V1eclpQ3rB+WtB+6aVDU2p1rReR2/wW4OTvuKBgEgAGbae9RiWFi8i0WusNngx86TBj8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gINsw+/o; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EB56C433A6; Tue, 13 Feb 2024 11:21:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707823266; bh=AJUvsaAkLNAUPAonfLONk+9L24hzUQDc/XjcjTFJY20=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gINsw+/oQJgINmHlycAYC0R3r8NXr5g9zkuO0zwnXp81idnMQ6otWGVm7Q/+FCgHt G61Jbclb/g4gHqOCnRe9AXbhNSEhCReCkmBpGbQlZIIIRsIR+MayCmuj+Vc0MxCYQt lWPKqsT0g9hWOk0HU2NapD7qTUdQgS4PVs0g9GIhvIoPVuAsk5OyWO8FXieT8bc982 7Kbp9CZhXD0CJhzuXT+s7/JBBoQw/dov5BDIb7nMJqX8LpepsnzvIcAmaShMFm1NrT 6tq6bPw4kOVN2ufsalsUHAvGj5nQagWvdzzo7RcFtN2+8XCv4rDqZPC5l/MkuRcNM2 EZe0QHRpWL1yA== From: "Jiri Slaby (SUSE)" To: bp@alien8.de Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter , linux-edac@vger.kernel.org Subject: [PATCH 3/7] EDAC/device: Remove edac_dev_sysfs_block_attribute::store() Date: Tue, 13 Feb 2024 12:20:47 +0100 Message-ID: <20240213112051.27715-4-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240213112051.27715-1-jirislaby@kernel.org> References: <20240213112051.27715-1-jirislaby@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790782575471763528 X-GMAIL-MSGID: 1790782575471763528 Noone uses this store hook (both BLOCK_ATTR() pass NULL). It actually never was since its addition in fd309a9d8e63e (drivers/edac: fix leaf sysfs attribute), so drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Borislav Petkov Cc: Tony Luck Cc: James Morse Cc: Mauro Carvalho Chehab Cc: Robert Richter Cc: linux-edac@vger.kernel.org --- drivers/edac/edac_device.c | 1 - drivers/edac/edac_device.h | 9 +++------ drivers/edac/edac_device_sysfs.c | 22 +++------------------- 3 files changed, 6 insertions(+), 26 deletions(-) diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c index 0e18729111d4..8c2aa5bcf1b7 100644 --- a/drivers/edac/edac_device.c +++ b/drivers/edac/edac_device.c @@ -160,7 +160,6 @@ edac_device_alloc_ctl_info(unsigned pvt_sz, char *dev_name, unsigned nr_instance */ attrib->attr = attrib_spec[attr].attr; attrib->show = attrib_spec[attr].show; - attrib->store = attrib_spec[attr].store; edac_dbg(4, "alloc-attrib=%p attrib_name='%s' attrib-spec=%p spec-name=%s\n", attrib, attrib->attr.name, diff --git a/drivers/edac/edac_device.h b/drivers/edac/edac_device.h index c4704b5b1e9f..a39752432c90 100644 --- a/drivers/edac/edac_device.h +++ b/drivers/edac/edac_device.h @@ -95,16 +95,13 @@ struct edac_dev_sysfs_attribute { * * used in leaf 'block' nodes for adding controls/attributes * - * each block in each instance of the containing control structure - * can have an array of the following. The show and store functions - * will be filled in with the show/store function in the - * low level driver. + * each block in each instance of the containing control structure can + * have an array of the following. The show function will be filled in + * with the show function in the low level driver. */ struct edac_dev_sysfs_block_attribute { struct attribute attr; ssize_t (*show)(struct kobject *, struct attribute *, char *); - ssize_t (*store)(struct kobject *, struct attribute *, - const char *, size_t); }; /* device block control structure */ diff --git a/drivers/edac/edac_device_sysfs.c b/drivers/edac/edac_device_sysfs.c index 237a542e045a..fcebc4ffea26 100644 --- a/drivers/edac/edac_device_sysfs.c +++ b/drivers/edac/edac_device_sysfs.c @@ -457,35 +457,19 @@ static ssize_t edac_dev_block_show(struct kobject *kobj, return -EIO; } -/* Function to 'store' fields into the edac_dev 'block' structure */ -static ssize_t edac_dev_block_store(struct kobject *kobj, - struct attribute *attr, - const char *buffer, size_t count) -{ - struct edac_dev_sysfs_block_attribute *block_attr; - - block_attr = to_block_attr(attr); - - if (block_attr->store) - return block_attr->store(kobj, attr, buffer, count); - return -EIO; -} - /* edac_dev file operations for a 'block' */ static const struct sysfs_ops device_block_ops = { .show = edac_dev_block_show, - .store = edac_dev_block_store }; -#define BLOCK_ATTR(_name,_mode,_show,_store) \ +#define BLOCK_ATTR(_name,_mode,_show) \ static struct edac_dev_sysfs_block_attribute attr_block_##_name = { \ .attr = {.name = __stringify(_name), .mode = _mode }, \ .show = _show, \ - .store = _store, \ }; -BLOCK_ATTR(ce_count, S_IRUGO, block_ce_count_show, NULL); -BLOCK_ATTR(ue_count, S_IRUGO, block_ue_count_show, NULL); +BLOCK_ATTR(ce_count, S_IRUGO, block_ce_count_show); +BLOCK_ATTR(ue_count, S_IRUGO, block_ue_count_show); /* list of edac_dev 'block' attributes */ static struct attribute *device_block_attrs[] = { From patchwork Tue Feb 13 11:20:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 200383 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp468303dyb; Tue, 13 Feb 2024 03:22:37 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWLumlHhRISQvH6CbBdOdM8KX3CMxLZG3cRwcQGt5DTjbmVyv3maqq16fS1aLXIihAdtY6NTsO9W59RnqAfhrzmRME2cQ== X-Google-Smtp-Source: AGHT+IHWMBlaXcKgElq8FfsFWu/HMBLTHSIuCSCC6yUP4HHCVsc4Gcc5lcdRZg/cGF3HuV11+3Cl X-Received: by 2002:aa7:d9c9:0:b0:562:5db:8257 with SMTP id v9-20020aa7d9c9000000b0056205db8257mr710694eds.31.1707823357143; Tue, 13 Feb 2024 03:22:37 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707823357; cv=pass; d=google.com; s=arc-20160816; b=CZsIRzqlQ1wZiSBpE7Y+Au2irMHgJWAXiR42Q12ghuvECdoT5OvsTZwV4oXHGO1BWW ajSrqFgTicItt5/7vc/vB+1K+aTnQh2GjHrfsETM5/lwB6vtvFal99r8mR03gt+G2V0j cmnqo4nz4RNzLk3vfA373K0R5r2jcto1hUgFSqKL0tE8Nz5yy8/TY+/6wOWdv4u4F+wb dZR3x9rpjBhOQBspWxqmhB5cRO2Mm2MLmlH39ilcNhqHx/BTfoLnw+cN9ATlBJdH9yrs 4xrpmf6gSoBfgzTaSsa75bt7C+AAVDkepxkGmASr2Po22/sOE5FWkEMTRzjnYA8UP7R5 La+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=RrwqInaPBn0SJLAQvIiFGfoaIDQVUDyx49hB7vfUKGc=; fh=brfoL91C7Lx6scHuRkSY5F3O3Dh2yEy0E71vanBGbKg=; b=iC6Aa1D4pu2sTqb5UuT51P+u9MITK70VHpdl4i2xeHZla7qWXreee19pV2i8R4n2Fe YzRzy9TiJx5F1FlcY1+SNONBJXtsoh+BdfvKyTVZ2x//ozDU15zneTB9xQ0yMVjtxXAp 1YT1NOS/Ltzk7HvojrJk0G0V8mb05xyikeEEgb1OTIV6FfpKznekkgy1eqKH31mDQNrR m6ewoUTXbs9iB5ZCNBmBNKyqmnkuaMtxFruml1Glw3saFjTyHEKEWtF0HGKAdTcYP0GB ZdaGCPFzTbitV5gzjv+JTJ3wa957l3okelX1NpFEF9v5SizFO3btInCS67MHygnuQOSA zcbA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="p8iiNON/"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-63421-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63421-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCWlb1LyWDiEWA9P2tZgxzW6JP2Gn65n5682g9TsY1t/FN3NUZOH8sHj95qUp/CeztEES26mJaD6OKhrQfHiu1z/jUirVg== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id da20-20020a056402177400b005606ba1169csi3810994edb.314.2024.02.13.03.22.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 03:22:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-63421-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="p8iiNON/"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-63421-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63421-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id BEF4D1F22466 for ; Tue, 13 Feb 2024 11:22:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5D1033FE22; Tue, 13 Feb 2024 11:21:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p8iiNON/" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A8B63D0CF; Tue, 13 Feb 2024 11:21:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707823271; cv=none; b=uO0ieIpvjUeVlRztqVuSPIAhd/0XQ+l0NfLPHeMN6kYyHnwcHB0VdeWbpkxwMz2HKcsbeyQVyV1RnAZP8GRvuLKtSXG3bT3apcfSETLPLDGTeOv1eRrz4NP78xUVEvLfAxX18nFLo7t+0/rSocsgxk5qW4OzGEkVxHl9EH4yHJQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707823271; c=relaxed/simple; bh=apWDkq5UWa2/rq4RKT0gRUNLpFJ/ic8YN3fzb53M4BQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XRtua3p6RWov8Yo8O3Y7kqyyis4ZhRrtQiRfnY2EKg36O8yvd3LYMJtpkS+kPGgcUs7q1ZW1MWmrojmASHdkuaDxdtY/YrImMdDf1wanubAG7aAlPK2Q1StSOw54tZcp8x3dCcunqyf8A93moaKL2kijEN/rMuzV6edQG9/ZqTo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p8iiNON/; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CBECC43394; Tue, 13 Feb 2024 11:21:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707823270; bh=apWDkq5UWa2/rq4RKT0gRUNLpFJ/ic8YN3fzb53M4BQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p8iiNON/PKYoaHOEgU0RAZy1iXMcgF4jia66l7NOm67Zz1NBwkdb34ScYMuomOWfZ EBxxmQWN1MyzdbKHuioyP4ZPrGvxBxIifT6H2Rj4egqx6QblDvEugDN+Vaj+oAU1DE j/uecMiSxK/VuVvABh++9pL5motJWETIXyq4ssD63snz7Sz26gOHWLmSljQqwgGbZm aDghLzUfVw4b1djxA8Ngp6nAgpr1veS1PAW3y/Xulhka6dGt6Gbfjoaee8pI3ldTmc 4V8BXiBL3mLdAG3t3u6zXt3xnk6AUbPueMjrF5KumxT1wczgabKUDcBJHsKia7p8A9 PiemlODuTaRkA== From: "Jiri Slaby (SUSE)" To: bp@alien8.de Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Dinh Nguyen , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter , Jan Luebbe , Andre Przywara , Johannes Thumshirn , Ralf Baechle , Manivannan Sadhasivam , Bjorn Andersson , Konrad Dybcio , Palmer Dabbelt , Paul Walmsley , Khuong Dinh , Shubhrajyoti Datta , Sai Krishna Potthuri , Michal Simek , linux-edac@vger.kernel.org Subject: [PATCH 4/7] EDAC: Remove dynamic attributes from edac_device_alloc_ctl_info() Date: Tue, 13 Feb 2024 12:20:48 +0100 Message-ID: <20240213112051.27715-5-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240213112051.27715-1-jirislaby@kernel.org> References: <20240213112051.27715-1-jirislaby@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790782584386517756 X-GMAIL-MSGID: 1790782584386517756 Dynamic attributes are not passed from any caller of edac_device_alloc_ctl_info(). Drop this unused/untested functionality completely. Signed-off-by: Jiri Slaby (SUSE) Cc: Dinh Nguyen Cc: Borislav Petkov Cc: Tony Luck Cc: James Morse Cc: Mauro Carvalho Chehab Cc: Robert Richter Cc: Jan Luebbe Cc: Andre Przywara Cc: Johannes Thumshirn Cc: Ralf Baechle Cc: Manivannan Sadhasivam Cc: Bjorn Andersson Cc: Konrad Dybcio Cc: Palmer Dabbelt Cc: Paul Walmsley Cc: Khuong Dinh Cc: Shubhrajyoti Datta Cc: Sai Krishna Potthuri Cc: Michal Simek Cc: linux-edac@vger.kernel.org --- drivers/edac/altera_edac.c | 8 ++---- drivers/edac/amd8111_edac.c | 3 +- drivers/edac/armada_xp_edac.c | 2 +- drivers/edac/cpc925_edac.c | 2 +- drivers/edac/edac_device.c | 50 ++------------------------------- drivers/edac/edac_device.h | 4 --- drivers/edac/highbank_l2_edac.c | 2 +- drivers/edac/mpc85xx_edac.c | 2 +- drivers/edac/octeon_edac-l2c.c | 2 +- drivers/edac/octeon_edac-pc.c | 2 +- drivers/edac/qcom_edac.c | 1 - drivers/edac/sifive_edac.c | 3 +- drivers/edac/thunderx_edac.c | 6 ++-- drivers/edac/xgene_edac.c | 10 +++---- drivers/edac/zynqmp_edac.c | 2 +- 15 files changed, 20 insertions(+), 79 deletions(-) diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index ae17ce4d9722..fe89f5c4837f 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -737,8 +737,7 @@ static int altr_edac_device_probe(struct platform_device *pdev) } dci = edac_device_alloc_ctl_info(sizeof(*drvdata), ecc_name, - 1, ecc_name, 1, 0, NULL, 0, - dev_instance++); + 1, ecc_name, 1, 0, dev_instance++); if (!dci) { edac_printk(KERN_ERR, EDAC_DEVICE, @@ -1514,7 +1513,7 @@ static int altr_portb_setup(struct altr_edac_device_dev *device) /* Create the PortB EDAC device */ edac_idx = edac_device_alloc_index(); dci = edac_device_alloc_ctl_info(sizeof(*altdev), ecc_name, 1, - ecc_name, 1, 0, NULL, 0, edac_idx); + ecc_name, 1, 0, edac_idx); if (!dci) { edac_printk(KERN_ERR, EDAC_DEVICE, "%s: Unable to allocate PortB EDAC device\n", @@ -1921,8 +1920,7 @@ static int altr_edac_a10_device_add(struct altr_arria10_edac *edac, edac_idx = edac_device_alloc_index(); dci = edac_device_alloc_ctl_info(sizeof(*altdev), ecc_name, - 1, ecc_name, 1, 0, NULL, 0, - edac_idx); + 1, ecc_name, 1, 0, edac_idx); if (!dci) { edac_printk(KERN_ERR, EDAC_DEVICE, diff --git a/drivers/edac/amd8111_edac.c b/drivers/edac/amd8111_edac.c index ca718f63fcbc..a6d3013d5823 100644 --- a/drivers/edac/amd8111_edac.c +++ b/drivers/edac/amd8111_edac.c @@ -366,8 +366,7 @@ static int amd8111_dev_probe(struct pci_dev *dev, dev_info->edac_idx = edac_device_alloc_index(); dev_info->edac_dev = edac_device_alloc_ctl_info(0, dev_info->ctl_name, 1, - NULL, 0, 0, - NULL, 0, dev_info->edac_idx); + NULL, 0, 0, dev_info->edac_idx); if (!dev_info->edac_dev) { ret = -ENOMEM; goto err_dev_put; diff --git a/drivers/edac/armada_xp_edac.c b/drivers/edac/armada_xp_edac.c index 25517c99b3ea..589bc81f1249 100644 --- a/drivers/edac/armada_xp_edac.c +++ b/drivers/edac/armada_xp_edac.c @@ -523,7 +523,7 @@ static int aurora_l2_probe(struct platform_device *pdev) dev_warn(&pdev->dev, "data ECC is not enabled\n"); dci = edac_device_alloc_ctl_info(sizeof(*drvdata), - "cpu", 1, "L", 1, 2, NULL, 0, 0); + "cpu", 1, "L", 1, 2, 0); if (!dci) return -ENOMEM; diff --git a/drivers/edac/cpc925_edac.c b/drivers/edac/cpc925_edac.c index 5075dc7526e3..eb702bc3aa29 100644 --- a/drivers/edac/cpc925_edac.c +++ b/drivers/edac/cpc925_edac.c @@ -797,7 +797,7 @@ static void cpc925_add_edac_devices(void __iomem *vbase) dev_info->edac_idx = edac_device_alloc_index(); dev_info->edac_dev = edac_device_alloc_ctl_info(0, dev_info->ctl_name, - 1, NULL, 0, 0, NULL, 0, dev_info->edac_idx); + 1, NULL, 0, 0, dev_info->edac_idx); if (!dev_info->edac_dev) { cpc925_printk(KERN_ERR, "No memory for edac device\n"); goto err1; diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c index 8c2aa5bcf1b7..621dc2a5d034 100644 --- a/drivers/edac/edac_device.c +++ b/drivers/edac/edac_device.c @@ -56,14 +56,12 @@ static void edac_device_dump_device(struct edac_device_ctl_info *edac_dev) struct edac_device_ctl_info * edac_device_alloc_ctl_info(unsigned pvt_sz, char *dev_name, unsigned nr_instances, char *blk_name, unsigned nr_blocks, unsigned off_val, - struct edac_dev_sysfs_block_attribute *attrib_spec, - unsigned nr_attrib, int device_index) + int device_index) { - struct edac_dev_sysfs_block_attribute *dev_attrib, *attrib_p, *attrib; struct edac_device_block *dev_blk, *blk_p, *blk; struct edac_device_instance *dev_inst, *inst; struct edac_device_ctl_info *dev_ctl; - unsigned instance, block, attr; + unsigned instance, block; void *pvt; int err; @@ -85,15 +83,6 @@ edac_device_alloc_ctl_info(unsigned pvt_sz, char *dev_name, unsigned nr_instance dev_ctl->blocks = dev_blk; - if (nr_attrib) { - dev_attrib = kcalloc(nr_attrib, sizeof(struct edac_dev_sysfs_block_attribute), - GFP_KERNEL); - if (!dev_attrib) - goto free; - - dev_ctl->attribs = dev_attrib; - } - if (pvt_sz) { pvt = kzalloc(pvt_sz, GFP_KERNEL); if (!pvt) @@ -132,41 +121,6 @@ edac_device_alloc_ctl_info(unsigned pvt_sz, char *dev_name, unsigned nr_instance edac_dbg(4, "instance=%d inst_p=%p block=#%d block_p=%p name='%s'\n", instance, inst, block, blk, blk->name); - - /* if there are NO attributes OR no attribute pointer - * then continue on to next block iteration - */ - if ((nr_attrib == 0) || (attrib_spec == NULL)) - continue; - - /* setup the attribute array for this block */ - blk->nr_attribs = nr_attrib; - attrib_p = &dev_attrib[block*nr_instances*nr_attrib]; - blk->block_attributes = attrib_p; - - edac_dbg(4, "THIS BLOCK_ATTRIB=%p\n", - blk->block_attributes); - - /* Initialize every user specified attribute in this - * block with the data the caller passed in - * Each block gets its own copy of pointers, - * and its unique 'value' - */ - for (attr = 0; attr < nr_attrib; attr++) { - attrib = &attrib_p[attr]; - - /* populate the unique per attrib - * with the code pointers and info - */ - attrib->attr = attrib_spec[attr].attr; - attrib->show = attrib_spec[attr].show; - - edac_dbg(4, "alloc-attrib=%p attrib_name='%s' attrib-spec=%p spec-name=%s\n", - attrib, attrib->attr.name, - &attrib_spec[attr], - attrib_spec[attr].attr.name - ); - } } } diff --git a/drivers/edac/edac_device.h b/drivers/edac/edac_device.h index a39752432c90..55be019c12ca 100644 --- a/drivers/edac/edac_device.h +++ b/drivers/edac/edac_device.h @@ -208,7 +208,6 @@ struct edac_device_ctl_info { u32 nr_instances; struct edac_device_instance *instances; struct edac_device_block *blocks; - struct edac_dev_sysfs_block_attribute *attribs; /* Event counters for the this whole EDAC Device */ struct edac_device_counter counters; @@ -236,8 +235,6 @@ extern struct edac_device_ctl_info *edac_device_alloc_ctl_info( char *edac_device_name, unsigned nr_instances, char *edac_block_name, unsigned nr_blocks, unsigned offset_value, - struct edac_dev_sysfs_block_attribute *block_attributes, - unsigned nr_attribs, int device_index); /* The offset value can be: @@ -347,7 +344,6 @@ static inline void __edac_device_free_ctl_info(struct edac_device_ctl_info *ci) { if (ci) { kfree(ci->pvt_info); - kfree(ci->attribs); kfree(ci->blocks); kfree(ci->instances); kfree(ci); diff --git a/drivers/edac/highbank_l2_edac.c b/drivers/edac/highbank_l2_edac.c index 5646c049a934..282ca6535f8f 100644 --- a/drivers/edac/highbank_l2_edac.c +++ b/drivers/edac/highbank_l2_edac.c @@ -54,7 +54,7 @@ static int highbank_l2_err_probe(struct platform_device *pdev) int res = 0; dci = edac_device_alloc_ctl_info(sizeof(*drvdata), "cpu", - 1, "L", 1, 2, NULL, 0, 0); + 1, "L", 1, 2, 0); if (!dci) return -ENOMEM; diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c index c1bc53f4e184..e8945d4adbad 100644 --- a/drivers/edac/mpc85xx_edac.c +++ b/drivers/edac/mpc85xx_edac.c @@ -496,7 +496,7 @@ static int mpc85xx_l2_err_probe(struct platform_device *op) return -ENOMEM; edac_dev = edac_device_alloc_ctl_info(sizeof(*pdata), - "cpu", 1, "L", 1, 2, NULL, 0, + "cpu", 1, "L", 1, 2, edac_dev_idx); if (!edac_dev) { devres_release_group(&op->dev, mpc85xx_l2_err_probe); diff --git a/drivers/edac/octeon_edac-l2c.c b/drivers/edac/octeon_edac-l2c.c index 4015eb9af6fe..919095d10528 100644 --- a/drivers/edac/octeon_edac-l2c.c +++ b/drivers/edac/octeon_edac-l2c.c @@ -138,7 +138,7 @@ static int octeon_l2c_probe(struct platform_device *pdev) /* 'Tags' are block 0, 'Data' is block 1*/ l2c = edac_device_alloc_ctl_info(0, "l2c", num_tads, "l2c", 2, 0, - NULL, 0, edac_device_alloc_index()); + edac_device_alloc_index()); if (!l2c) return -ENOMEM; diff --git a/drivers/edac/octeon_edac-pc.c b/drivers/edac/octeon_edac-pc.c index ea8a8e337b1e..b8404cc7b65f 100644 --- a/drivers/edac/octeon_edac-pc.c +++ b/drivers/edac/octeon_edac-pc.c @@ -92,7 +92,7 @@ static int co_cache_error_probe(struct platform_device *pdev) platform_set_drvdata(pdev, p); p->ed = edac_device_alloc_ctl_info(0, "cpu", num_possible_cpus(), - "cache", 2, 0, NULL, 0, + "cache", 2, 0, edac_device_alloc_index()); if (!p->ed) goto err; diff --git a/drivers/edac/qcom_edac.c b/drivers/edac/qcom_edac.c index 5539917c01dd..d3cd4cc54ace 100644 --- a/drivers/edac/qcom_edac.c +++ b/drivers/edac/qcom_edac.c @@ -349,7 +349,6 @@ static int qcom_llcc_edac_probe(struct platform_device *pdev) /* Allocate edac control info */ edev_ctl = edac_device_alloc_ctl_info(0, "qcom-llcc", 1, "bank", llcc_driv_data->num_banks, 1, - NULL, 0, edac_device_alloc_index()); if (!edev_ctl) diff --git a/drivers/edac/sifive_edac.c b/drivers/edac/sifive_edac.c index b844e2626fd5..a2b193dc6604 100644 --- a/drivers/edac/sifive_edac.c +++ b/drivers/edac/sifive_edac.c @@ -52,8 +52,7 @@ static int ecc_register(struct platform_device *pdev) platform_set_drvdata(pdev, p); p->dci = edac_device_alloc_ctl_info(0, "sifive_ecc", 1, "sifive_ecc", - 1, 1, NULL, 0, - edac_device_alloc_index()); + 1, 1, edac_device_alloc_index()); if (!p->dci) return -ENOMEM; diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c index 90d46e5c4ff0..fab9891e569a 100644 --- a/drivers/edac/thunderx_edac.c +++ b/drivers/edac/thunderx_edac.c @@ -1365,8 +1365,7 @@ static int thunderx_ocx_probe(struct pci_dev *pdev, idx = edac_device_alloc_index(); snprintf(name, sizeof(name), "OCX%d", idx); edac_dev = edac_device_alloc_ctl_info(sizeof(struct thunderx_ocx), - name, 1, "CCPI", 1, - 0, NULL, 0, idx); + name, 1, "CCPI", 1, 0, idx); if (!edac_dev) { dev_err(&pdev->dev, "Cannot allocate EDAC device\n"); return -ENOMEM; @@ -2004,8 +2003,7 @@ static int thunderx_l2c_probe(struct pci_dev *pdev, snprintf(name, sizeof(name), fmt, idx); edac_dev = edac_device_alloc_ctl_info(sizeof(struct thunderx_l2c), - name, 1, "L2C", 1, 0, - NULL, 0, idx); + name, 1, "L2C", 1, 0, idx); if (!edac_dev) { dev_err(&pdev->dev, "Cannot allocate EDAC device\n"); return -ENOMEM; diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c index 1b50f8160013..fd87f1b2c145 100644 --- a/drivers/edac/xgene_edac.c +++ b/drivers/edac/xgene_edac.c @@ -913,8 +913,8 @@ static int xgene_edac_pmd_add(struct xgene_edac *edac, struct device_node *np, snprintf(edac_name, sizeof(edac_name), "l2c%d", pmd); edac_dev = edac_device_alloc_ctl_info(sizeof(*ctx), - edac_name, 1, "l2c", 1, 2, NULL, - 0, edac_device_alloc_index()); + edac_name, 1, "l2c", 1, 2, + edac_device_alloc_index()); if (!edac_dev) { rc = -ENOMEM; goto err_group; @@ -1208,8 +1208,7 @@ static int xgene_edac_l3_add(struct xgene_edac *edac, struct device_node *np, edac_idx = edac_device_alloc_index(); edac_dev = edac_device_alloc_ctl_info(sizeof(*ctx), - "l3c", 1, "l3c", 1, 0, NULL, 0, - edac_idx); + "l3c", 1, "l3c", 1, 0, edac_idx); if (!edac_dev) { rc = -ENOMEM; goto err_release_group; @@ -1748,8 +1747,7 @@ static int xgene_edac_soc_add(struct xgene_edac *edac, struct device_node *np, edac_idx = edac_device_alloc_index(); edac_dev = edac_device_alloc_ctl_info(sizeof(*ctx), - "SOC", 1, "SOC", 1, 2, NULL, 0, - edac_idx); + "SOC", 1, "SOC", 1, 2, edac_idx); if (!edac_dev) { rc = -ENOMEM; goto err_release_group; diff --git a/drivers/edac/zynqmp_edac.c b/drivers/edac/zynqmp_edac.c index 2d9a5cfd8931..c9dc78d8c824 100644 --- a/drivers/edac/zynqmp_edac.c +++ b/drivers/edac/zynqmp_edac.c @@ -381,7 +381,7 @@ static int edac_probe(struct platform_device *pdev) } dci = edac_device_alloc_ctl_info(sizeof(*priv), ZYNQMP_OCM_EDAC_STRING, - 1, ZYNQMP_OCM_EDAC_STRING, 1, 0, NULL, 0, + 1, ZYNQMP_OCM_EDAC_STRING, 1, 0, edac_device_alloc_index()); if (!dci) return -ENOMEM; From patchwork Tue Feb 13 11:20:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 200384 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp468404dyb; Tue, 13 Feb 2024 03:22:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IHdvraJXvn7JE2ZCkoGV2yL+KeMUEaqyv8V7TAk5PIcDSkwUGoXGW62Xs0gbmVHOEyNXuOx X-Received: by 2002:a17:902:d501:b0:1da:2c01:fef5 with SMTP id b1-20020a170902d50100b001da2c01fef5mr6828838plg.56.1707823373374; Tue, 13 Feb 2024 03:22:53 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707823373; cv=pass; d=google.com; s=arc-20160816; b=H1jimLVTYdwGqv3bS8GslRsJF5eguX863JLSXqQt/HMzwQVB8yzIlsJxR6VBRwmK3R R6/5kalePyILeuXslsN6AgeScMipPUFeJ6IGTUI6uaOmrgIbPLIHJkNgY/O5+H3KYcKz s5GHkPZMShcSW5xQdZfATPeKql8aCa4DnKvfQfYAesD0CBiqm4BaYsGOtGkaKoaaYeew zkFIS0UZd+p3+9bRkXfGoOKPHu9lpJuvEAT6gkrPL5rAu8IGYbsJtcuuLkWg1i42I7Nh 660GOfH7eCpszDv6Hw+WlJLV2LEQHHFYpjyvbsDNZaoCsh7cP8Fa1D3IMzfIy3GQahtt 1YKQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=WgOxccSLn/d4M1zShgaA/yzvC/EGD7f9RjSfrmWmxAQ=; fh=NuQz/ycyyHVQw55rpUQLQxfWURV0YyfiP8de/mqZWco=; b=FSYKQ9SiPIRSOdzR9K0Fa7JJpwU0V4QeX0LoOlXoLuHJskEHxtOvpMATl/EnvGi9ea +X+nLgLw5pSc7jtkUupgi2AX5OhH3iW8TuRXbzp9raqh9kwJPYVgfDmEGHiNk/5+Kdfs 12wIZuVy2A4rN3Uyv3HdvB24N85Nwda6e8fnXdsB13VasGIKh+IViNgAdOLQa9g6/T12 V87msaewwuCp15kAC1o0kYuAjRfn3T180Xv1QwHjFyCjQ0mlZegKhtJS91Re+TzluEPY 02HyEJCvi2kZnGg8CVi6nzaSM7oAtv/u6lM5TdcSJQCc4xyAf1/F4OUsIpXLcxqktw6M 7YCQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gjs7tBKu; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-63422-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63422-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCXrdbmjRQ6Zrxk2VgKwoWsM8+rB/ti9iu2WYuPujwGb3540m9M6cKOmy/Zp15CioYr1L/ah3S6TPkNmYjeKvJzm2Y0fKA== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id z5-20020a170902d54500b001d720fa139esi1907892plf.17.2024.02.13.03.22.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 03:22:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-63422-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gjs7tBKu; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-63422-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63422-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3686828206A for ; Tue, 13 Feb 2024 11:22:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 145F63FB38; Tue, 13 Feb 2024 11:21:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gjs7tBKu" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89C3B3D396; Tue, 13 Feb 2024 11:21:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707823273; cv=none; b=pGro2MuPC7BXCXr7lpTdTyflJKR6WrIxZgZYoh40hq8bHyodo8SNz83id9vyuPQWlMsCK/WqQGKmm/F7fptp3281DkoQavyPXwsWzpIUeKdQEfQRJW3HOMF3knNlGDJyNP5Rbx52oUFDRDZXiAE/WUUaXhPRKASlknNJCA1UIzA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707823273; c=relaxed/simple; bh=yVDWfsoh7FqeJLjlF1skb90Df8JXvSB4mHHDi6A6xM8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lb4tgSJ4iDhsm7IJ18JVaNmo9TADT/LGYz4kB1x828ifDmzsIMB+gETFl0GqlDnoa/GMcZzw9puOZmzYlxnWKL+vqwGdSMWkxj7mh/m2FgTUIiqOtYbcRW4j+c0r552TfQ+ZFrbjGYFjbDSKjdqd9eiyjTTj7CbZyDKmHPIfUYw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gjs7tBKu; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FA9DC433B2; Tue, 13 Feb 2024 11:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707823273; bh=yVDWfsoh7FqeJLjlF1skb90Df8JXvSB4mHHDi6A6xM8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gjs7tBKuDgfum3MxGR5V2wxKJK1HqZ5TJ4mTsreDWpzs7YMfOVhnRb8fbYn88zVIV PEM67j4uV03Og1q1VJWDdHdWsC54pINnR94Y96VRF/4oQIHzLOn68jqGaCvKIHaDzJ CtzuQn8iYJ+IV0Rou2jE7eFdkgP/WoCrBsoSRojjacOjf7dzlncKrUCCcrhE1WDznS cfPK4Df3PJafoJnKyNP8KQLClxSdj2og7hXzYuMWOWcglPH++pNIEuNLyj1yCJrsWg fFI/7Dh7yxNwVF3xf1ahVe5zQ1bX9tjtC1RDxk/qTBJkLu25nkSbru8CR8dkCE9lS1 Uewfb6NAkZNsQ== From: "Jiri Slaby (SUSE)" To: bp@alien8.de Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter , linux-edac@vger.kernel.org Subject: [PATCH 5/7] EDAC: Remove edac_pci_ctl_info::edac_subsys Date: Tue, 13 Feb 2024 12:20:49 +0100 Message-ID: <20240213112051.27715-6-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240213112051.27715-1-jirislaby@kernel.org> References: <20240213112051.27715-1-jirislaby@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790782601796196314 X-GMAIL-MSGID: 1790782601796196314 It was never used since its addition in commit 91b99041c1d5 (drivers/edac: updated PCI monitoring). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Borislav Petkov Cc: Tony Luck Cc: James Morse Cc: Mauro Carvalho Chehab Cc: Robert Richter Cc: linux-edac@vger.kernel.org --- drivers/edac/edac_pci.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/edac/edac_pci.h b/drivers/edac/edac_pci.h index 5175f5724cfa..4159a3ef0dbf 100644 --- a/drivers/edac/edac_pci.h +++ b/drivers/edac/edac_pci.h @@ -48,8 +48,6 @@ struct edac_pci_ctl_info { int pci_idx; - struct bus_type *edac_subsys; /* pointer to subsystem */ - /* the internal state of this controller instance */ int op_state; /* work struct for this instance */ From patchwork Tue Feb 13 11:20:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 200385 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp468472dyb; Tue, 13 Feb 2024 03:23:05 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXxuGiSwR+SyqG17skoflaURXP021FLodwZADsB362vt0qv8EC/MbO+0iUugkdQ2pf9cfFeO1EcCWmHf0Ef9CAbWTEWHA== X-Google-Smtp-Source: AGHT+IFCyqhzVne1lMOMk3dyO2eiYsTokLjdUL48DTHMWjO3Ol28LjuNptbXGsTn51mVvamtAahJ X-Received: by 2002:a05:6a21:3183:b0:19e:a3b9:1e0f with SMTP id za3-20020a056a21318300b0019ea3b91e0fmr2772204pzb.11.1707823385443; Tue, 13 Feb 2024 03:23:05 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707823385; cv=pass; d=google.com; s=arc-20160816; b=Oyss1QhqXV8z7VUJXZL5l7YSnX5Jy0lzfyrSuLl/eNFfIqS9IQ24LXkSnHQbDNHEUR nDSYh4cs1i8GvcIEinb9yXvcMrJTT3fOdGnH4akvCtFuhni1PSzb5rRtOwdTcuSf4OWl kOAzfTYd/9VI2v3CkP6Sm5E5g5nvCfd5IXHlP3O/R652k8OIw5y5W4mDo8poqcNiktIl gpjlTl3348UubJM4aTAez+QhiO9/ZLknQIQIXrDS62dc4FMmALNh+7rsH/XGoR5o6s4p D43gaxOoc7BMGeefZWETqP3yk3u8ZRtJ83mxejn+jwnQIOTn0fX3aXFzjyjSJir4slJK fNVw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=H5z4QrrTGrkJqjtny1SQQjz8f8wNKUaKklgPzHw1Xzg=; fh=d9q24ZVYNNYxuHTC1CrJXoPxX8+7JLGqf7PjNonkJQs=; b=VrAgTgQnszhHeAe88V4c2cZ7EO8M3q/Oh7rRb5TA0urbknGE6Of6UdeGDoR9SlRtpD uesGQRItpThTFp2tqudlVFwgBf6GhNaqwe9svED7fz4jh6ADtLZbHPOfbN58bEGxx+G9 /ZGBNACUXZdYhRNLFlJGLCfvYcQ4XwJbTNEIoZh/irjCjBnC3ru09F14syEt65fWrilq FtY4KvTHlhNrFBgrCYH695L6CDH2OydGBQz6MuoS4elzapFfXX2FSMqjByIuq18AgG6H UmeF8ECUv/TUd7Cw9sQ+ch+pnwHPxYYFR+1GjZacXEA7LmHLH63mLmMYzqo1Ibt99WdY OghA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Y2PzkbqT; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-63423-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63423-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCXCffVnh7YVez8631bCUUD6QsvP0q+pSpHTdkEnU4eNDuirsO5+I0oQQ34yGn5s5qflYorima4Ve39a7GcknW39qWyNEg== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id ff16-20020a056a002f5000b006e0595f4e68si6556677pfb.301.2024.02.13.03.23.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 03:23:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-63423-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Y2PzkbqT; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-63423-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63423-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6B0CA2837B5 for ; Tue, 13 Feb 2024 11:22:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6810C42070; Tue, 13 Feb 2024 11:21:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y2PzkbqT" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2B0241A8D; Tue, 13 Feb 2024 11:21:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707823275; cv=none; b=ghrILomsBCtAzwp478HgwupW1rviUJRtXtHYW053+H+yl9gySQ8rgZUHS1ne9BpKKCbYVNrvHqC5MInZjvEK1x9M9h7KPEEJMOx7BDhK+OjxmNQKp6heWqCDEKhP+zSPRtjm59WNJ9+lwiyaX7LCzNcbpo/mlSVyhN5sfVplAGo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707823275; c=relaxed/simple; bh=aIolLqLqC/bcDMHyNhQznYMvDY5tSLws2Dm32ULRu6I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UVNaot8kyjfzDUGAVyX3XRxeYxuTeMSfHFqL/PZnD/uZuSKo9/UNj46ZeX1fIVe7NvT6cef/X4A2T29O2l582cV7gkJy6xNfnGEFJk2fXycPeHMAcEKiSOJ1/IfK7cuZYNFHcB2kD8BD2PbFLqVFwCbOdhhpYVv3O6jKOQ/NqpE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y2PzkbqT; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A6C6C43330; Tue, 13 Feb 2024 11:21:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707823275; bh=aIolLqLqC/bcDMHyNhQznYMvDY5tSLws2Dm32ULRu6I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y2PzkbqTLskgujKP0PKcKdywI/RCRDveMxFtuISmptb634zEmqNFJ8ouOuMVCTndN x0mXPvlw+RtzkSzm5OWagRFZPlqFd2YZipn6VbFzmfWFEzv5gZ0dM7QJF17rks3BWs DzGnC2bE3D4R13fwZ2CQqrmRNJwrCNCsp0NlIMlaIZ5dtp+vLl8XSniAMAO94Stdcu U/IWDJecQvUdpPKSGPB7IeYaAWTcuISEjoFjVMotzHcAwiAv3Hzhthw5SImQo/X4gI CQZx6tYQgkmH+GIduJJ/c4btxEPxvhg+Kf1hZFmTQg9b/LbuGotV5xkaFeXkveeD76 9gd6L39Hg4K8Q== From: "Jiri Slaby (SUSE)" To: bp@alien8.de Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter , linux-edac@vger.kernel.org Subject: [PATCH 6/7] EDAC: Remove edac_pci_ctl_info::complete Date: Tue, 13 Feb 2024 12:20:50 +0100 Message-ID: <20240213112051.27715-7-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240213112051.27715-1-jirislaby@kernel.org> References: <20240213112051.27715-1-jirislaby@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790782614276229193 X-GMAIL-MSGID: 1790782614276229193 edac_pci_ctl_info::complete is not used since commit 458e5ff13e1b (edac: core: remove completion-wait for complete with rcu_barrier). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Borislav Petkov Cc: Tony Luck Cc: James Morse Cc: Mauro Carvalho Chehab Cc: Robert Richter Cc: linux-edac@vger.kernel.org --- drivers/edac/edac_pci.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/edac/edac_pci.h b/drivers/edac/edac_pci.h index 4159a3ef0dbf..3f47cd9b2b03 100644 --- a/drivers/edac/edac_pci.h +++ b/drivers/edac/edac_pci.h @@ -22,7 +22,6 @@ #ifndef _EDAC_PCI_H_ #define _EDAC_PCI_H_ -#include #include #include #include @@ -70,8 +69,6 @@ struct edac_pci_ctl_info { unsigned long start_time; /* edac_pci load start time (jiffies) */ - struct completion complete; - /* sysfs top name under 'edac' directory * and instance name: * cpu/cpu0/... From patchwork Tue Feb 13 11:20:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 200386 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp468513dyb; Tue, 13 Feb 2024 03:23:12 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUnEaN+Q0+dJShkhi78IB4KzozuJ5XVZFgEp44z24yyK382hj+6ulGG3F+sVgykrhvgT3Bbly/sTG8hbkmT/vSmrD6nfA== X-Google-Smtp-Source: AGHT+IFp/nU5KtTKFBMTEtVHFLhHCm5ZB8hNbXn/mRGpdBQD/1erbp0IXoi6TSrt8xMzryc5CLci X-Received: by 2002:aa7:d5c2:0:b0:55f:ec52:73c4 with SMTP id d2-20020aa7d5c2000000b0055fec5273c4mr6979512eds.34.1707823392304; Tue, 13 Feb 2024 03:23:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707823392; cv=pass; d=google.com; s=arc-20160816; b=BhUo2iHyldikV2QowC2RpM5Osnp3SY8C2eKNMFvn/9cnSj7F44mrR/F8WPEHrAlr4l Fdq8Ep+SBfSERKr5QbC02iWmr7ZPNVQzp0fcotaJccK8jur8mGg4bLRUXpgwqCf613a+ 88M6YgculWVq+yeK0KfuTCfZE0ERgs2FogudRZ2w+jhoBaHopVdaf8N0PhrPtnFQuCcv gGPrOUiXvR331Id1z4KLk4sstgDtRErFm7su9FKwlcoE/tCxJot4oE1mpBPH/VNpvOZ+ cAT+P/LE9XL2l/QmOGq3zWMES9MxqmuD/vFU1hB3FdLYADq2uJuOYjMjssY4nfPVeuTE r1fg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=btfgNwk5agoTI1hp8GeTxYgzgYMjecFHpfiG/KWYY00=; fh=FYXihPbXEWtqJ7hvitkV0AQsDhHIBoU+ggCdDcQ2vYI=; b=RS/gr9kD9EEd8/73in2vXAeE8RDjsr+QIi612Hypnu3nVOfjkcPvdvnZHbuKxTIA6x cm/kmHQAUjR22K2LqBpUxUlFLM0FTlA4OjzEBCx89BCNZuWWXwTHikM/SE2wTKFNWd58 GJ53D5IJzf1OZluwcZVaZ+Zl3c/7UYzCUnFbk+LG6GoGSOv/UyQp7fQLue6mQqdLlT36 VnBZ3IZkzz9aiwYtnsLCyOuPVlaO4T9eXf4NQGECEr7X2HIkUJ6BT18xzcaza7u4mnXO YcRKSoEHGPy6xBJsZgaXwfeX8BiSrq857T3nuTst/z7NJBW+ZXtSq3Oc76eJF/VLg1ZQ 1b3Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=P+eoeyo8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-63424-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63424-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCXCc+DTzVZ30MX+yAGToPqtjIcHlursoehKEOeAhPlhsRQ9C4V3fkHpZ2CpJK2f74FME+yjpev4oRDkJRPxSeBuT6JWMg== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id x3-20020aa7d6c3000000b00560fd0b13fdsi3628794edr.424.2024.02.13.03.23.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 03:23:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-63424-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=P+eoeyo8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-63424-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63424-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E231A1F21139 for ; Tue, 13 Feb 2024 11:23:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 62DC04DA0A; Tue, 13 Feb 2024 11:21:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P+eoeyo8" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE46A4207F; Tue, 13 Feb 2024 11:21:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707823277; cv=none; b=khCTZW20Jx/2Wv76gZBGp/bSnwlciV4P4IjggELIm958+9KyXpGq2MM9ltjWSe2J3FQIl/QErpzP3yrEcvmCa3DVULAQcJvTESQfPl2RGl/lSUQnaIidjn2nuXhA+sBrFSX5vXMwKSZop3GOKVU7BARuc9t0678pHr6ZOQ9oN1Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707823277; c=relaxed/simple; bh=7rlQVPPK7OWucwtWFQVrtA/YfOz50z1TLi70ClXddQA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZAZx+N8ZByHEF877C9+p9j0WMkBM26SrUbnh1RgRDPXenyDXxWP7MGaGYrV7lE/7T+C5QKbUcr/eJtC96RneV4TvUwRvPyLVBbVKwI6un5vPxo8/+Qos8DzyOoS+8nQG0ToC8bIEmPtx03d4+UhILjLGZN73bZFl96QFgkYAsLE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P+eoeyo8; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7090C433F1; Tue, 13 Feb 2024 11:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707823277; bh=7rlQVPPK7OWucwtWFQVrtA/YfOz50z1TLi70ClXddQA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P+eoeyo8+EWkWQ8iVcrW/PdgpU6Ow3aBa+JsUCKn0gcW5uNeJcysOzrcwj/qPBcn8 4YpLbDsrtiRPGHm9ajOlVLtl3K2W2gQ3zQsPPqhK6X8DCDt99GXc7pObMpMo1KfAi0 5Ptglt8ppj9ZvePTpK5EddOq5P3D3HNnWyqe5U+MPWIkAmmDXgwFlJ2+bd9kEfWMGU eEO8Hlms9K/ODkjyPfT07pmWtQG67c3BtyPXJdoev4JWEG1VwdnEyyfxdfWpBFydoX Jyu3LZtcl1Osc33O8UM8njyihlYAClFsCaxweBOgNVdW1N2jn8mWB/GzjiChUKJI38 LdPvpGysTzU/w== From: "Jiri Slaby (SUSE)" To: bp@alien8.de Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter , linux-edac@vger.kernel.org Subject: [PATCH 7/7] EDAC: Remove edac_device_ctl_info::removal_complete Date: Tue, 13 Feb 2024 12:20:51 +0100 Message-ID: <20240213112051.27715-8-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240213112051.27715-1-jirislaby@kernel.org> References: <20240213112051.27715-1-jirislaby@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790782621441624399 X-GMAIL-MSGID: 1790782621441624399 edac_device_ctl_info::removal_complete is not used since commit 458e5ff13e1b (edac: core: remove completion-wait for complete with rcu_barrier). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Borislav Petkov Cc: Tony Luck Cc: James Morse Cc: Mauro Carvalho Chehab Cc: Robert Richter Cc: linux-edac@vger.kernel.org --- drivers/edac/edac_device.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/edac/edac_device.h b/drivers/edac/edac_device.h index 55be019c12ca..034711d71ebf 100644 --- a/drivers/edac/edac_device.h +++ b/drivers/edac/edac_device.h @@ -22,7 +22,6 @@ #ifndef _EDAC_DEVICE_H_ #define _EDAC_DEVICE_H_ -#include #include #include #include @@ -191,8 +190,6 @@ struct edac_device_ctl_info { unsigned long start_time; /* edac_device load start time (jiffies) */ - struct completion removal_complete; - /* sysfs top name under 'edac' directory * and instance name: * cpu/cpu0/...