From patchwork Tue Feb 13 10:44:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 200364 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp451673dyb; Tue, 13 Feb 2024 02:45:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IHSWTaT4Ob7OvxioWzjX7iFLs/ob1il66OE7/8TSxrs/XNd1RIemF7Gn013EiTUJ87apYEX X-Received: by 2002:a05:6214:2266:b0:68c:d91a:bca with SMTP id gs6-20020a056214226600b0068cd91a0bcamr10888194qvb.39.1707821137576; Tue, 13 Feb 2024 02:45:37 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707821137; cv=pass; d=google.com; s=arc-20160816; b=BumXgjbhIPdmL9IVHoLWSoYhF1VbUtdPGolBghgmbLyKOTnP7S6WJKR9+O/Rz+Bij8 VUSYqV1GLP9X/U1UudvnLuqSmjFVxSC82NpHzahlCmStjZBZM8bigo8Bi5kebBy6fTZQ 59fkIrRFaRmo8KlTM2qFDpqX3LDoRXFOSYIkeUhRk89Pns3F+zZg0ZWS1Mobgk0v4TAW eBzNOYHwqT7O1LWDYBT9QIf5FTCngVcHjxLTizLjNZfrwEotyJeXFoiYElRw0P9pBfim V4KB/iJ98n9epyOJx2wNwowGTi+RUXRZjuZXJ+W6wMFi4ijtDbdzAzWDMhht45dlVzOy e1Kg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:errors-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :subject:to:from:date:dkim-signature:dkim-signature:dkim-signature :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=H1CyOubF4A08XsSL3wNGiXhyaG8X4jmzN6lGRI9GD+s=; fh=PCT/JBXpOojDRKebo/Z3C5gO6rQq8CiT5nay47zMvQY=; b=E7bN+7yzmGX/NTa0te96NeUZ7WoE1W1G6UFQ/f9x85h2PmMGmmlqjiFIOHmGyPVy8S MKqE6DG8Scf+EVDWeWLa0TpEXEm+Pq9PiYXViPrvj1pm+8taa8VohMl2OSOnTXWpNwpW s+glxRUmQnSE8PV6iv5SZC5E+MFl+KDTzdCGUdhQ+fPBkTzPjjZl1zy8p+F+qHKxCfzz lDszPfSlHYQcABIoT6VR9YVW7yUYq+KVDawgEdHd1EYaVTi00e595SknFKP6LStiD3EZ rVU/A6gdYwobESf8mCQnol3aBt4bAnI+uoJwBOZLEMcjju4UyIow+zCloBADX+Pxwg7K A5Nw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=jZ+r8s5k; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=jZ+r8s5k; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de X-Forwarded-Encrypted: i=2; AJvYcCUpTKUdrsFXXRaF9oz4pufw3LK7xqJtq5TvlXtd7EIS4kyEjl/VjRNgZuyMkE1ckNRNKCX0mWyNznxZ3T92yxuzlafFwA== Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id h9-20020a0562140da900b0068d14e840basi2620383qvh.101.2024.02.13.02.45.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 02:45:37 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=jZ+r8s5k; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=jZ+r8s5k; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4DDCA3858286 for ; Tue, 13 Feb 2024 10:45:37 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id B528B3858C3A for ; Tue, 13 Feb 2024 10:44:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B528B3858C3A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B528B3858C3A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707821100; cv=none; b=bKvMNy+tV3tTmfzPSfjn+Ru7MAjkquIa5S+NhZCiinIgJjW1ndMnhgehxj4FvPZxtNmXxUEEUHkKBQRXqOupFyyruA3PkSO5HCpVo8z7jN4q6RK7mJYx60AKbrlAyPiVTtt/gIvW11nyz+J4FwRv9ff517mtWqbbeFdqLsuOYLQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707821100; c=relaxed/simple; bh=3zb6Fm4mEVaxJnDyYntnYTeA64UbxsaGUdLuqDV9Xi0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=wrvqwsnG4hYIaZJrsOyFBKTTuJ7faR/vWcvJTtK785auef17HgPBg/aBwKYT1jrs3MbP8PZJdFgulrPYgUZvtY++IF4XV0iE7reG0Ho8bauXpdXn9YDDBUbaRXt0OzO4ANbNHN6kDhrcp0NmKp35aJdf4+Yc63iBFSwpIi3AViM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AFCF91FC81 for ; Tue, 13 Feb 2024 10:44:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707821097; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=H1CyOubF4A08XsSL3wNGiXhyaG8X4jmzN6lGRI9GD+s=; b=jZ+r8s5kXAVHQSmxZfEQi7auVMdemAXb4FY+H1Zd58tE1Yv4yYMzQGGc3Hl481OCYeYxVO FVaD54fYEsPoJmPygm4iQ5vmmHaTs71S2ntNv5yhLBc6Tr7cdlsMteVrNf+3CIszHh+eG1 iOXDm/7pzVjeqrQvPz7HFMMp3+EF3zE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707821097; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=H1CyOubF4A08XsSL3wNGiXhyaG8X4jmzN6lGRI9GD+s=; b=w0EY5pSabe5NGUZCq2DXu5emUFCPaReRAw2Mx/n3PGrdCFL/8To/G5j7/w6TC1uAMQEDgc k4QuRjlaPiKCWnBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707821097; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=H1CyOubF4A08XsSL3wNGiXhyaG8X4jmzN6lGRI9GD+s=; b=jZ+r8s5kXAVHQSmxZfEQi7auVMdemAXb4FY+H1Zd58tE1Yv4yYMzQGGc3Hl481OCYeYxVO FVaD54fYEsPoJmPygm4iQ5vmmHaTs71S2ntNv5yhLBc6Tr7cdlsMteVrNf+3CIszHh+eG1 iOXDm/7pzVjeqrQvPz7HFMMp3+EF3zE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707821097; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=H1CyOubF4A08XsSL3wNGiXhyaG8X4jmzN6lGRI9GD+s=; b=w0EY5pSabe5NGUZCq2DXu5emUFCPaReRAw2Mx/n3PGrdCFL/8To/G5j7/w6TC1uAMQEDgc k4QuRjlaPiKCWnBw== Date: Tue, 13 Feb 2024 11:44:57 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/113898 - ICE with sanity checking for VN ref adjustment MIME-Version: 1.0 Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-0.60 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MISSING_MID(2.50)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%] X-Spam-Level: X-Spam-Score: -0.60 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Message-Id: <20240213104537.4DDCA3858286@sourceware.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790780257028838221 X-GMAIL-MSGID: 1790780257028838221 The following fixes a missing add to the accumulated offset when adjusting an ARRAY_REF op for value-ranges applied to by get_ref_base_and_extent. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/113898 * tree-ssa-sccvn.cc (copy_reference_ops_from_ref): Add missing accumulated off adjustment. * gcc.dg/torture/pr113898.c: New testcase. --- gcc/testsuite/gcc.dg/torture/pr113898.c | 16 ++++++++++++++++ gcc/tree-ssa-sccvn.cc | 1 + 2 files changed, 17 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/torture/pr113898.c diff --git a/gcc/testsuite/gcc.dg/torture/pr113898.c b/gcc/testsuite/gcc.dg/torture/pr113898.c new file mode 100644 index 00000000000..6832a345271 --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr113898.c @@ -0,0 +1,16 @@ +/* { dg-do compile } */ + +int a, d; +unsigned **b; +long c, f; +long e[2][1]; +void g() { + int h = 0; + for (; h < 2; h++) { + e[h][d + **b + a] = c; + if (f) + for (;;) + ; + } +} +void main() {} diff --git a/gcc/tree-ssa-sccvn.cc b/gcc/tree-ssa-sccvn.cc index 2823573b656..5a49390a79c 100644 --- a/gcc/tree-ssa-sccvn.cc +++ b/gcc/tree-ssa-sccvn.cc @@ -1126,6 +1126,7 @@ copy_reference_ops_from_ref (tree ref, vec *result) op.op0 = wide_int_to_tree (TREE_TYPE (op.op0), wi::to_poly_wide (op.op1) + idx); op.off = idx * elsz; + off += op.off; } else {