From patchwork Tue Feb 13 08:39:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 200275 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp402661dyb; Tue, 13 Feb 2024 00:42:32 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWRcFCcuUPbnyH2jSkGcLH0VYLIDxFEwzWgZ96pjXHyV+mXpAWV2fXVZCeM72PalBbkysxTRr7OUYjtG29XgqBRxBUp9Q== X-Google-Smtp-Source: AGHT+IE2iHmBEgTeKTJMY0FQyWR8co2UHc5u/1VIDSZZRNzeJRnHOhpNw3BAxGGjN1t7ab7rPsK7 X-Received: by 2002:a05:6808:219c:b0:3c0:38fc:ca77 with SMTP id be28-20020a056808219c00b003c038fcca77mr5276354oib.58.1707813752431; Tue, 13 Feb 2024 00:42:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707813752; cv=pass; d=google.com; s=arc-20160816; b=SqUQcJVA2G3Q/Q46H8hTaH2ZIkGA1fWiz/DyEBvdEX3Uvvg/X5ce37liB2SeZaeKT/ ckR813JTlFeK6DH/UwF1iBG3VDC/IxcURrVeXC4YCEg4A9QPa1M485jX/lSJBfzoUgtH kWulCS7EEoXa9w+Y9y2bevAm0Hz00SXjl+fO0AqoBsPS4PIhQqr8DIpYJGy97AuT81nn 3jKhJTJYBrGxUqhpji0YNO8f6Df3rBZn8UXw60lSppTdSfKygDWmTwQivk3vOTIQIqy6 ai2cBYs3h3kHim+Bq1hJG47BjTYjFI9vZXPiLxEpeVcBDS3EDqG+65ohWV5/MwNc/Ej0 jmkA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:precedence:robot-unsubscribe:robot-id :message-id:mime-version:list-unsubscribe:list-subscribe:list-id :precedence:references:in-reply-to:cc:subject:to:reply-to:sender :from:dkim-signature:dkim-signature:date; bh=/ormm+PHwLi/CeFwP1A2naAwgJmnQBsAxeCyqCbJneM=; fh=LrqQWt6h2dY8bFESzLNstMUKbyxEZ0eTOw56G6PLrLw=; b=u4Xk9cq0LjHkDliuQvLqT8X6yBlaoc+7Kf9Vb0b7E9XpbP2VkgFSZJ2k6KQuGqtQmR OB3ghydTUmwkpvRUMNByyWRpo+gVm/T+G4UH6AAgUKPbO34Ma5ZDw4t3YlkrEv9txcNi gYab2mO0pQJzQRoVOqIDmYSzjasFuKZ5p6XMWgCzhiPO9VQnIMooWfu03Tomg0c5NKzY volfuk0uDvWTde7Grnw7CaH+BW1hCZ06r3eHc0jCU/vB7F/sl0erLW9pb9SGvhkZLjux 4Xm1mnNlOHWCLQGPlyy0P+zSxkPq6SDIZ1DOUKdpR0jHWAatKmQFy8n8NI6iWcMfej0y ublQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=FqR3nORj; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=AQiCdoC+; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-63133-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63133-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de X-Forwarded-Encrypted: i=2; AJvYcCXmx5AoC11KBnpj6JwILnbHupkEJVwpJnBEdh8hOcU4dRaPjOwcWIFUlhLdGibK0DKgAHxHlMDyHYfzxyGPJYrSSuOydA== Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id m189-20020a633fc6000000b005d8e3490d49si1592595pga.407.2024.02.13.00.42.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 00:42:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-63133-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=FqR3nORj; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=AQiCdoC+; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-63133-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63133-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id EC0D3B22E5F for ; Tue, 13 Feb 2024 08:40:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4DFB420DE7; Tue, 13 Feb 2024 08:40:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="FqR3nORj"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="AQiCdoC+" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0848118AED; Tue, 13 Feb 2024 08:39:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707813599; cv=none; b=a5Kot4nBSZ236qLHd2olGt2dK9nL0u9IqijClLlCgZlgAzB87ta8cJP7we6lylyWRHJusr73P0smYht7pfQSaGBMZmhkrdUHbEMAS06rtfj02pSF2d0xqUiJSx5Hrswnz/PPC3MNtxkn+rNHtnjMaqLwUElh6kXqEYZI6pBNdN0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707813599; c=relaxed/simple; bh=FUVFlKXHErfQHwVS12HqcrL/BlrR/XNwXJub9R1UUnU=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=G7v+x5ePbIRzfpmjiH/NMnjre8W212Ezmb0GrFQeTiO0qVDgKCKIcWDxwjKHn/fV4K2F8Vc3NlnetDz3taVy/xJaBXK6XKjSciWXCxDcL+UIFMuJ4BBAhPL9dHfJTfGnBm8GSbVZ5Cy8PXXlGrCdg/BxLK4z0gMzvB5TiLpb/KU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=FqR3nORj; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=AQiCdoC+; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Date: Tue, 13 Feb 2024 08:39:48 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1707813589; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/ormm+PHwLi/CeFwP1A2naAwgJmnQBsAxeCyqCbJneM=; b=FqR3nORjlwLo57t5FFCrDcJZrZ4kYwEPfnB3zBdljb27/X2S0xX2X5N9SihSn1NQc9+p9m 12UEu3gOC/PC2sb6lV3CuXbn8mqNt8AMMAPV3WNrfbZEI8XcwJ9zIhvPidWnUoUFqjOGuQ +8U7Cm4V92KF+hRjVZgBSudaUg2Duvu0F5iiDiuXePDzd/mFQB9Jyhfid2cYIrHswjx/rD hAfHK/1MqrD+uuYJ3rcd0ls5zadun6mlaxl0VtpKH1LYRHZQEibyq/5ZfSkL7rT7K12TVb +ttOU/0+i2PePC6ldcfzwpvzrfj42b+AE8+Tjxg7IyrIGuVci29LO/ONtE/VTg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1707813589; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/ormm+PHwLi/CeFwP1A2naAwgJmnQBsAxeCyqCbJneM=; b=AQiCdoC+rhHsjRbWwMJIAPgzekYzRRp3O89tm1Qz4JWgVsOPYnTU2xrjeKYHUV6+j9Tvbq 10p9R4wWT1wFTHBg== From: "tip-bot2 for Doug Berger" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: irq/urgent] irqchip/irq-brcmstb-l2: Add write memory barrier before exit Cc: Doug Berger , Florian Fainelli , Thomas Gleixner , Marc Zyngier , stable@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20240210012449.3009125-1-florian.fainelli@broadcom.com> References: <20240210012449.3009125-1-florian.fainelli@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <170781358867.398.2362878690950793714.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790772513557342794 X-GMAIL-MSGID: 1790772513557342794 The following commit has been merged into the irq/urgent branch of tip: Commit-ID: b0344d6854d25a8b3b901c778b1728885dd99007 Gitweb: https://git.kernel.org/tip/b0344d6854d25a8b3b901c778b1728885dd99007 Author: Doug Berger AuthorDate: Fri, 09 Feb 2024 17:24:49 -08:00 Committer: Thomas Gleixner CommitterDate: Tue, 13 Feb 2024 09:33:31 +01:00 irqchip/irq-brcmstb-l2: Add write memory barrier before exit It was observed on Broadcom devices that use GIC v3 architecture L1 interrupt controllers as the parent of brcmstb-l2 interrupt controllers that the deactivation of the parent interrupt could happen before the brcmstb-l2 deasserted its output. This would lead the GIC to reactivate the interrupt only to find that no L2 interrupt was pending. The result was a spurious interrupt invoking handle_bad_irq() with its associated messaging. While this did not create a functional problem it is a waste of cycles. The hazard exists because the memory mapped bus writes to the brcmstb-l2 registers are buffered and the GIC v3 architecture uses a very efficient system register write to deactivate the interrupt. Add a write memory barrier prior to invoking chained_irq_exit() to introduce a dsb(st) on those systems to ensure the system register write cannot be executed until the memory mapped writes are visible to the system. [ florian: Added Fixes tag ] Fixes: 7f646e92766e ("irqchip: brcmstb-l2: Add Broadcom Set Top Box Level-2 interrupt controller") Signed-off-by: Doug Berger Signed-off-by: Florian Fainelli Signed-off-by: Thomas Gleixner Acked-by: Florian Fainelli Acked-by: Marc Zyngier Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20240210012449.3009125-1-florian.fainelli@broadcom.com --- drivers/irqchip/irq-brcmstb-l2.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c index 5559c94..2b0b317 100644 --- a/drivers/irqchip/irq-brcmstb-l2.c +++ b/drivers/irqchip/irq-brcmstb-l2.c @@ -2,7 +2,7 @@ /* * Generic Broadcom Set Top Box Level 2 Interrupt controller driver * - * Copyright (C) 2014-2017 Broadcom + * Copyright (C) 2014-2024 Broadcom */ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt @@ -112,6 +112,9 @@ static void brcmstb_l2_intc_irq_handle(struct irq_desc *desc) generic_handle_domain_irq(b->domain, irq); } while (status); out: + /* Don't ack parent before all device writes are done */ + wmb(); + chained_irq_exit(chip, desc); }