From patchwork Mon Feb 12 16:50:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 199928 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp41635dyb; Mon, 12 Feb 2024 08:56:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IHWREE5f2fPGyx0LbBJ0aLMHPB9BzC+7a6lsAwr4gVGEbqTsEzXWGm1Y70Z4TCxOOU4adI+ X-Received: by 2002:a05:620a:4e1:b0:785:6462:449b with SMTP id b1-20020a05620a04e100b007856462449bmr105532qkh.22.1707757019704; Mon, 12 Feb 2024 08:56:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707757019; cv=pass; d=google.com; s=arc-20160816; b=VvkhjLYeks2LqrRKqgfbwiocjQaxekAf4zhs51rsiZroscMWjqo9Ax5D8KQ68edDWu g52oOUceR7NW5g//j6HDTBeo/UymhW+Xh8YurNQiA29anCR3x7mJtrjZ+KpIGqjGVdDS AlGhkhHZwVvrxksea4rvRdzWMOO7BoAODt5AKdrjVLLEY58M4dnYL0saQq87athpxZ8O 2pnVHSZU2MNiVfttngecbPmsTubRKjF+UYkWfgsrlCRyLHzEaflYUyguATinpgqIiy1I HSD8aoq2exlAvPFzYeHknS/sNP3ZmwINbOjmhE3svQCiO/yKq3qYkFsgwfC3KpdaPfKv N4CQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=E7nAIga4wb5mEBrkyImnxY/nKiVBgB6q85p9JLL3ndE=; fh=2XwTCDbDUk4JTVFhtQmNLS+JwkbiQlcIeyH3+frAC28=; b=R2yoCVSljHIVFqPjSs9SfIoQPb693H+w7BQl7TLzPm/lQPRUSfj7JCWfWPGVGe/5dL vuPVM2Kj8ZxWVY3KrdPFQf6TlUiZDwjlMQFisy372pxInD0Gn4PZvZyeWft2ojBe+m65 XddAx8k/mATmnhy/8Ftc6EMF9RU2Zuer59tmbajOPzReuk3e9aTMoiDUXeWmmT5Y/k8K Co4+gyAI/4TCpwGbQZ2BNw657swbo7sIjKUjo019jeqF8wi86/ssbe+nkNYfXocPl3Qi AvJiEMcq4opHHK1/jXGBtEvdCCLPk/QqlDFspEPdL0E7qptkEsrrD4/ufDqrMvFj34Df J0bA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FtHnJJuT; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62020-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62020-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCWjbaWBAs4aFAFze2+PsdZla058TuTe+F1VV+9Jevgf3OnNNNZoRGpw8LKqll1VO+DEmfQbHwL/Pd0SvxQaUaMn8SsRZw== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id t14-20020a05620a450e00b007859d7c0317si6903928qkp.293.2024.02.12.08.56.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 08:56:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62020-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FtHnJJuT; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62020-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62020-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7DEC91C21C37 for ; Mon, 12 Feb 2024 16:56:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 678CE47F7A; Mon, 12 Feb 2024 16:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FtHnJJuT" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 962643D994; Mon, 12 Feb 2024 16:53:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; cv=none; b=s0QQyxJZBMdrKe/6oHrcAE44P1PtvQGvrjI9JXLRohjJ8luZcVQHWPLyAd4dz2OH6XEdIvgg62NRSk3/tH6qGqlUzoX1Gp3Dc8Ckr9Ocm0paxnb6A4GpE4KupFV1xC7/2pJ5nl+2xl9R2EFP3kydGuVkydOAH9B7M2G6T3wjs5I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; c=relaxed/simple; bh=4qs5BSHr83bqWVSdSZwruslTHmTwWZz3mLyV0R3YqS4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ci9Zw5mN4h6B7Cj7CfxJbXqFgQhsnVspYY/dTyF3x4Ojf745PIVv73pa8/R7mPeun48QredL1Ea3xDxA5mQ6lKZ4IzS3taRUb7SM2DjDfvtC/JuJQoHtwf6I/60P1PnD/QqZYLtRv6Fa6szBAjIbYUBfXfarMOuggY94okhEnnY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FtHnJJuT; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4E4AC43330; Mon, 12 Feb 2024 16:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707756818; bh=4qs5BSHr83bqWVSdSZwruslTHmTwWZz3mLyV0R3YqS4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FtHnJJuTAEBUQdcH64Rcdc2knJufwOvhkGG4rT7AC3Ei9LhDfY7uf35++xo5GuKrR aPPdEhziCF/OeeVakVxvmCY2xgg3PKckELu+98kDGlpVbCV2WyzeDpvDBnZ5Gf65Wo AAhqQU/ABmeN2Lk95pRS2JvVks7kvEmIQW9I8XFOAOjeMOTJkGGIFWoF3Mijxcmiei eWMyjHpQiEJOvdf2hzw2gEhbvswEGGYBKRGNpvXaQmJJV7eFtq8WiL3EGHit1hGwt3 Wzsh2jDC01dd6u0TpvF/PowRDBD9t0y4J/Fku8nG8kCTmeYyyuRXu6MFdEPmeCEdkQ 44f29ol0P1W7Q== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rZZZ2-000000007Mz-1MLQ; Mon, 12 Feb 2024 17:53:52 +0100 From: Johan Hovold To: Bjorn Andersson , Bjorn Helgaas Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 01/10] dt-bindings: PCI: qcom: Allow 'required-opps' Date: Mon, 12 Feb 2024 17:50:34 +0100 Message-ID: <20240212165043.26961-2-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240212165043.26961-1-johan+linaro@kernel.org> References: <20240212165043.26961-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790713025021228189 X-GMAIL-MSGID: 1790713025021228189 Some Qualcomm SoCs require a minimum performance level for the power domain so add 'required-opps' to the binding. Signed-off-by: Johan Hovold Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index a93ab3b54066..5eda4e72f681 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -123,6 +123,9 @@ properties: description: GPIO controlled connection to PERST# signal maxItems: 1 + required-opps: + maxItems: 1 + wake-gpios: description: GPIO controlled connection to WAKE# signal maxItems: 1 From patchwork Mon Feb 12 16:50:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 199931 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp41746dyb; Mon, 12 Feb 2024 08:57:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IHspPQ255ZACZP6Up1lkLimWSfb++mRGRt3ff46S3cHTzNqtyn6cH1JIQ98PwuPcD9tdqJo X-Received: by 2002:a17:906:a8f:b0:a3c:d7c7:1418 with SMTP id y15-20020a1709060a8f00b00a3cd7c71418mr858519ejf.60.1707757033441; Mon, 12 Feb 2024 08:57:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707757033; cv=pass; d=google.com; s=arc-20160816; b=YuhfxWf2P5IkeOVZ8RVR1dH0opxxIdasjuifPinH+nVyynuE3XnUFmveL5bfMvfRtf 5eVsglhixjrcER6HNZCjjvXZ+g+l2yblVWVg1LXb5oZL55IBAj4v/QuPgo2Eh/p611wq PCfIRAuI8+9k2Z256j3Y6djC6JcTtJ2JwCT2zWt99PHFYCTLDmOY9J0cmIml0nQH1tBO OBSoIO+Zo4BmWyttUMqtfSs7dvpEl03uxZeOyOJrJtWNu7RbFf+0RTF7OmMRyKcZz8ft 20K99azr4LC4KcXtBZnl3604n/WgVu5jYCit/1bGOrbpLmXQV9EIPsqkbH66bjRkbJ0R YrCw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=+9fmcHUnnx7RJfLXlK4i4FtnyB8WVN0PbtBv+z7yf5U=; fh=m3U9ee+KbD3+r5BwQzftmGGTGRG+agkyyRUBSBOo5Dg=; b=JMoyaIfo/zXXJEx66Y3xOfyZTMSN/JzgT0vlCal2HJkqnUWSBCYiWFyYqhRsIPYHtt YIsm2sfgjDTBxpXJuNJsQVHcesJZjLFxlcyjI2iQKFU+/Oge5x6kuHc4De+dN5KmZenH eNckzvYs/Nc17+VfeMi2ibYcHzeY/xu40TVllQnrdcIGg4wadrfYEDR3sUvx8Sz15dbU j+YWtSrgXf4Bp5NAsRDx7ix3V096nsyNPmVf2RXt6lJeTFq+qKD13CFbrJnjp3WIs5HN TTgWh/ummGc7ITDih6upCyumXjgBgEzSLPJlQzeXYY8czED6slYnKG574ctnq5cIoBDT 0gQg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kfDDJcXj; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62022-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62022-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCUUkjdRtWqqENvvK71RKjnjcrh3BlYKMgcxQ6hmHKCAyuOCPCJmCXliLz5o8NPrVjraw89Mr196dK4BfH7D6H3tOWCiAQ== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id l18-20020a170906415200b00a3c2bfce551si365307ejk.34.2024.02.12.08.57.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 08:57:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62022-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kfDDJcXj; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62022-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62022-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 78CB71F23D39 for ; Mon, 12 Feb 2024 16:57:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 67963481A8; Mon, 12 Feb 2024 16:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kfDDJcXj" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 962923D995; Mon, 12 Feb 2024 16:53:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; cv=none; b=ETnWtbnvXWydbMfBcePVQpIfXxjYE3RNj/lW7k2y5EwjfdvcLrVILiEawGMOTEhw/pvlEhYoiO5FFhR3sFK3snzqe84k8+MYNL84m5i/Bqk6m5v9i+4Cffw0aJeJeYcz2eVZgCb07e7Pcl0Eoa9Jn0c5vWoHQKNQpNFY80Aw68E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; c=relaxed/simple; bh=b9sQBFDZU3VO1UBig2yVSwe4gu61tiUJKbyEVJ58Ty4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iat/uY6ci7hO9LXPxhWZ4JY/sVYjnUnogYtEUWWjZ+GtfK8tcpgq1PvHaKry/vea8WKusy3W0vAAFFAjKvwPcyzX8Cst2v/SpmbgIyfxR8ncZ1JHrcHiACBCkvCDhNXxtV/kB0y0TiGppW3HzqVhlOLrfkwLffA5nCYKNLEeCWY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kfDDJcXj; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B72C2C43601; Mon, 12 Feb 2024 16:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707756818; bh=b9sQBFDZU3VO1UBig2yVSwe4gu61tiUJKbyEVJ58Ty4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kfDDJcXjc5rf9yM9juPLHJ15hJN5VnNveC0WNajBfuKrI7feA2TRUaNz5XDEwiaEi tXwZ87lDx9N4tHJWeEsy6HVRs9cJRkVz51BTFPS7IFeOt+rS0LZADGwHUSMgnkqHzx AIMc3MuvLGG2/fM6da9rri9R2G3y9yfoho2pxwlrwtJLJpeGs6KtaQs8P0r0KAnCVY 3vq/bT6r36QKxz10qDkHqcPQZEefqDbmY9nERSu0d6F+ZanBOQsBzpl8tbW4qWsVu3 lvlZH3dCBLwHVt5P0Bkz+p+v+1UAM1etCW9v7a/Du8hAQF7G6JAZDTLlO/Wc0WBnmE cUPH5vTax9gjA== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rZZZ2-000000007N1-1kg7; Mon, 12 Feb 2024 17:53:52 +0100 From: Johan Hovold To: Bjorn Andersson , Bjorn Helgaas Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 02/10] dt-bindings: PCI: qcom: Do not require 'msi-map-mask' Date: Mon, 12 Feb 2024 17:50:35 +0100 Message-ID: <20240212165043.26961-3-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240212165043.26961-1-johan+linaro@kernel.org> References: <20240212165043.26961-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790713038754391221 X-GMAIL-MSGID: 1790713038754391221 Whether the 'msi-map-mask' property is needed or not depends on how the MSI interrupts are mapped and it should therefore not be described as required. Note that the current schema fails to detect omissions of the mask property if the internal MSI controller properties are also present. Signed-off-by: Johan Hovold Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index 5eda4e72f681..b28517047db2 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -146,7 +146,6 @@ anyOf: - "#interrupt-cells" - required: - msi-map - - msi-map-mask allOf: - $ref: /schemas/pci/pci-bus.yaml# From patchwork Mon Feb 12 16:50:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 199923 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp40945dyb; Mon, 12 Feb 2024 08:55:37 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUj5QqvXhxD6+Zxa/g3/HEGU0OGUO8gNE8XP/qWSi3uBBn/5mMFGieGNke7dCy/HHyjM1gE/DnAx/broeuBU4CSfPjTXQ== X-Google-Smtp-Source: AGHT+IF+RnufHH7DZxhm8M6weZCA6cYJeS3mhHLs7ZqCMviWl0gHJXaCu02rto8DL/V9MA+8jmNQ X-Received: by 2002:a17:906:ceca:b0:a3b:f3e4:e91b with SMTP id si10-20020a170906ceca00b00a3bf3e4e91bmr6092000ejb.42.1707756937513; Mon, 12 Feb 2024 08:55:37 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707756937; cv=pass; d=google.com; s=arc-20160816; b=ky8gxzs3y9vHN6CPN1IbKSeMwm3t0zkfQr5Ut8Dpwj5ovAAWk25JxheStVp9seRKNB 989KY850DQRN3Cop1r/jzTluSwVobi3VU93jTifDZIcPBlNVRKSnsGvMBgTcP0UUxVv6 eGR3Dov6m1Q0loVgm9/3EWJPxzeCe37RclxkEk/ax0fo+lUzI9ItOzsn5ukO2tXShAl8 V+Q71oDCXP1jFf6Jh5F5Lw1SExDtXDONlMRP5ZHOTeCrbG3EjHDZ+Zn1RApChwxPruK0 QqaFUAtr3qsGaQ7HoY7bjZbFLG+UAdqs97YxYSehN/ONdo65spWUVmYS5SZxA7Zjcb9C eHNQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=MHTAZKFgzV3VEwEFkpwI1WBDKkVs+UmrkwnbvwrXwOo=; fh=8X4FJoZCca2wu8aJ7S/tDtBx1ic/Gq2DZ0zjs2HH3P0=; b=rHWlxMETjBAqlgNHbz6RIM72X0bfeELFnt5IjzoUNxwu+QJC5zO4A9WYiOM7BTZ7Xh oKi+WT3Zs43w4vI8/Aa5TPxbvfHt2WoTKgJ1mUNgmI/z+UB3McscRUhDsOXyylBNBDnQ TZ5OgzQOrO+54l44M7pcXCJjVUgdcT3E81GNC93TSq2tn4kTWR0U9ikE78YQWqXCykEQ rkZldDJ9WLgydjyjJO60f8Kk1WPeFp/8lHpxcwCIJV6QLAP6Ao/RsZKAY9q3JAzfkDSx NvmetfuLEP4TVKAfsxyAECZHjb//RFlZBeaWdexfnHxCItc/4Nte9ZHJfasBx9AzVwJD C5tw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kFI5Baa4; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62013-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62013-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCVVZ1pFQV//i5kR77bVcDLtIhh+Z0ItaT3t2HMx22+OEIAVeQMNGTGL5ruGOa+iJPyXYidmZOlL6wYuE2Q6MFqE1ND0aA== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id x2-20020a1709064a8200b00a3caa41bd8asi358185eju.82.2024.02.12.08.55.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 08:55:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62013-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kFI5Baa4; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62013-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62013-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 226191F2423D for ; Mon, 12 Feb 2024 16:55:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 245E940C15; Mon, 12 Feb 2024 16:53:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kFI5Baa4" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28A9D3D39F; Mon, 12 Feb 2024 16:53:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; cv=none; b=fwuHpYyKazjftVYW7clq+JHfnHLgYmX9PCkBS5mUBelOC3WXOEIspVnKWvjhaABxS3jfOInEsaJVhKNQe5neNFt6v8M4SFmt7gqRFO0qU8kJNXNZWSedoW/c1qlR3dA8Q1u0nqCq7p7S6HThah/UcFKDNoUanJVbgs9urPyJ0FM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; c=relaxed/simple; bh=vk+Lt5I2JfW5rauqD9RI4ZcRRxFOCwrY7DdoHCOyR8M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xzp80FPJMtFQdEYdxQwtCYENiHSKJc584kJRqHMCtdd1dzEHHbC3pUex7Nx2StQgilZVitn2TWWnqi69puR8pwD3ABlEDzXf3Raw9kslT2GE0zZlu3uUeHlhoncsPmsgpurhwEMB9QmfCxYDQuV7vN4Vymjt5CIOxOSsT0JqIfI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kFI5Baa4; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACA0DC433B1; Mon, 12 Feb 2024 16:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707756818; bh=vk+Lt5I2JfW5rauqD9RI4ZcRRxFOCwrY7DdoHCOyR8M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kFI5Baa47zDEkpiFIS+is9qV7PpYX7LBgeSj8eFnmELiHBK4oOOFLZe6uIRYPyBcl 57uA+HZ3iEbEEJ1Ns03MItwhGmiU3ySRcTsjiUKSLwAYmaQpABdds7j4kyW8IQVgkj bSdOta3yIMNyykDASx8gYDSHf88hIQ2HcBPufi5lJ5iIh2e7iQF30W7GB+0zmYbzfp W7Vqbg0oqM2yxNvVXsgiysSEt3Us24ynKTYcnhKGhtDG8J0vc030TWkvNBVsMoZpOh 40fUWUb/1Tf2VNcO+OEZzLqVW1F7Z2JO3A+fB3zewCFIeIrvgJfHMZET3tk7kd0aLb SnTK1bjvPJ9Qw== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rZZZ2-000000007N3-282y; Mon, 12 Feb 2024 17:53:52 +0100 From: Johan Hovold To: Bjorn Andersson , Bjorn Helgaas Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 03/10] arm64: dts: qcom: sc8280xp: add missing PCIe minimum OPP Date: Mon, 12 Feb 2024 17:50:36 +0100 Message-ID: <20240212165043.26961-4-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240212165043.26961-1-johan+linaro@kernel.org> References: <20240212165043.26961-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790712938732110814 X-GMAIL-MSGID: 1790712938732110814 Add the missing PCIe CX performance level votes to avoid relying on other drivers (e.g. USB or UFS) to maintain the nominal performance level required for Gen3 speeds. Fixes: 813e83157001 ("arm64: dts: qcom: sc8280xp/sa8540p: add PCIe2-4 nodes") Cc: stable@vger.kernel.org # 6.2 Signed-off-by: Johan Hovold --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index ae41b3051819..36382b1bd965 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -1780,6 +1780,7 @@ pcie4: pcie@1c00000 { reset-names = "pci"; power-domains = <&gcc PCIE_4_GDSC>; + required-opps = <&rpmhpd_opp_nom>; phys = <&pcie4_phy>; phy-names = "pciephy"; @@ -1878,6 +1879,7 @@ pcie3b: pcie@1c08000 { reset-names = "pci"; power-domains = <&gcc PCIE_3B_GDSC>; + required-opps = <&rpmhpd_opp_nom>; phys = <&pcie3b_phy>; phy-names = "pciephy"; @@ -1976,6 +1978,7 @@ pcie3a: pcie@1c10000 { reset-names = "pci"; power-domains = <&gcc PCIE_3A_GDSC>; + required-opps = <&rpmhpd_opp_nom>; phys = <&pcie3a_phy>; phy-names = "pciephy"; @@ -2077,6 +2080,7 @@ pcie2b: pcie@1c18000 { reset-names = "pci"; power-domains = <&gcc PCIE_2B_GDSC>; + required-opps = <&rpmhpd_opp_nom>; phys = <&pcie2b_phy>; phy-names = "pciephy"; @@ -2175,6 +2179,7 @@ pcie2a: pcie@1c20000 { reset-names = "pci"; power-domains = <&gcc PCIE_2A_GDSC>; + required-opps = <&rpmhpd_opp_nom>; phys = <&pcie2a_phy>; phy-names = "pciephy"; From patchwork Mon Feb 12 16:50:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 199922 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp40925dyb; Mon, 12 Feb 2024 08:55:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGETKNqtglOmlSiG1FDLnkUcv2YX0bzq9CXRkaRcJmL2NiXL5aDD9Bf53p3+FFiEb/rremU X-Received: by 2002:a17:907:1002:b0:a3b:d939:ee95 with SMTP id ox2-20020a170907100200b00a3bd939ee95mr5701403ejb.35.1707756935926; Mon, 12 Feb 2024 08:55:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707756935; cv=pass; d=google.com; s=arc-20160816; b=q1U9dCsuEWPW2K+DgfUT/v4J/xrcXv7vbbQESPHF1L4VLMBqbpF6eY507+zGKyKXBJ qskw/ObvER3wymmiVHMielWTAzNKCH17C9VWHfAPrJtpPejdImUIILPkrZXqJYxPAlwn e3XIDusO2OhX+PcEtPNgA+HcdrkXpqP+pZtW5XZInAYyw0eRw8oDXvWL7HirKiLZsnOf mnN6/Ocmh90IFBFmMMaJfo5IQkKqkUSpBa8n8Za8GIOGUCdSbxkZCrVCNiXUheIMlrIZ UbgpvITW6octnU94ebVIkOjNlic3ADfLyWIA7G4B+piiduglh3MwDHwgJj2MG8JjrOpE +qFA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=5Y9xYGH4UaX8P0Crg1QmewG6HHwwTlPSP4taCXlWraM=; fh=fXIcScT2GejxAc64ipCLcsxl5QYLD/9OD8/Hf5R+DnU=; b=QTHvaIALyI57gK7xPqUGyJ0W/RzYdI9Y7KL5tltX2zvNVNx3n4NP0H56MEuzVeQpCg Kxl4ZaAz9pkExhrIr3B3SIAHxABEV4enwMZ2Yw9oxcFLnhXNukMKK+Iye1KoOJav5uLu D02zmoRJUxQzKxqa9X4SNCAZ3pVi1Jh/c4Hk3Un6uLHUVYHru/VyTeFYfmEqj7IFmygF 0Fhmh/Bf+2i66KhSWWx3DpDfGVw1TGAL7Qawy/mmsv4LDDJN7BeYz9XqeYPv9r3u19Kb JuVOLpEM/SrBmC1mg6QwpJCs7euuN+HmsZ8nOwYNOzqRLXCesUxauDrzbfQwp/bP7W8S ECxg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DHZlh1Vz; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62015-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62015-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCUzyNTOypNmcVDzGgOOm4s6ceXRjrEOUYbyhsN3zpvVnyuahlJ4cvASvG/A8UosfRFRud6Ii4AphIfTWEtpY9PzFJco8g== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id gf20-20020a170906e21400b00a3c8bfd61b4si341112ejb.912.2024.02.12.08.55.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 08:55:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62015-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DHZlh1Vz; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62015-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62015-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8911A1F2420F for ; Mon, 12 Feb 2024 16:55:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2213740C04; Mon, 12 Feb 2024 16:53:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DHZlh1Vz" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28B103D3A8; Mon, 12 Feb 2024 16:53:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; cv=none; b=DSPDbv/osGyaFEtXwpl8mm5Do7eKkksxaEnBbx8MY7tcR4QTkIDfi/Ubu/PRkUr2/nBAsP/bwpgDHwp+tHKLBobsoQ6aU7KbOULwtt12s2MpuZxiPCATRLLODPvkoUIYfT/6A0k30UFDtYkJYNXEgTd45PVUocTjjiDYveRv4MM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; c=relaxed/simple; bh=52V8VIBZ6Aa9byRanT+AhHOKtM3PttwSwaL5Jh235Ts=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IQVsSAFQo+ur65RE7ayKQAv5tS5/P4OeQAOTjtJ0Eszh2bknkLAN1sGkO6L8qxMv+Fus7S5OdoxwyXw/Lc5zvDKYsZkhSADpnBVe4shr4wYezMGYf3yZo20fMx6zbtRpIl0kryADaIvLWpHUfao3Sm86vByXRwfBj0sqdtkmyUs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DHZlh1Vz; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F34EC433F1; Mon, 12 Feb 2024 16:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707756818; bh=52V8VIBZ6Aa9byRanT+AhHOKtM3PttwSwaL5Jh235Ts=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DHZlh1VzVUm+VRt1myKtgo3wHiiHaxhk32t7JnMbWdCainbIcl+pQsRJnMuI4rSiU OAZh0osLEpPBdP4csdJyFjT4niZARt5zCXz4l+q1tIftgTFGKWyJtNjTW7/Kxz0CIk I2/Cz5aB7KQcawEUxbePuzGOe2lvXMpasBQNGaQUh+IFDTPzIXIbtJcUIxIPRcNZqm RzLANQTh45BhFaw/H/jb8WclJionZ9njZI9BEt1535qFQA8qm6FeqSYOPmvLFDxTHZ uqNHthowf632JN0sLPmY1j7wcxEIa79XKBJ26fRK7As0ed5vlhQ4xtbFEVEfrCoxWb nrbivMPGoCqww== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rZZZ2-000000007N5-2R4q; Mon, 12 Feb 2024 17:53:52 +0100 From: Johan Hovold To: Bjorn Andersson , Bjorn Helgaas Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 04/10] arm64: dts: qcom: sc8280xp-crd: limit pcie4 link speed Date: Mon, 12 Feb 2024 17:50:37 +0100 Message-ID: <20240212165043.26961-5-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240212165043.26961-1-johan+linaro@kernel.org> References: <20240212165043.26961-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790712936807236984 X-GMAIL-MSGID: 1790712936807236984 Limit the WiFi PCIe link speed to Gen2 speed (500 GB/s), which is the speed that Windows uses. Signed-off-by: Johan Hovold --- arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts index f34c572253f5..8c1fccf8847a 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts @@ -563,6 +563,8 @@ &pcie3a_phy { }; &pcie4 { + max-link-speed = <2>; + perst-gpios = <&tlmm 141 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 139 GPIO_ACTIVE_LOW>; From patchwork Mon Feb 12 16:50:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 199927 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp41631dyb; Mon, 12 Feb 2024 08:56:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IEoz1OdkK21etJWVGYAvcNdCn4jkpGGX+rziUzlz+VMpv4ugVP4/hBLpC0NjfjIskmS/lQy X-Received: by 2002:a05:6214:da5:b0:686:a20c:faf with SMTP id h5-20020a0562140da500b00686a20c0fafmr11064944qvh.12.1707757019212; Mon, 12 Feb 2024 08:56:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707757019; cv=pass; d=google.com; s=arc-20160816; b=iqyExc6nyXG4GDcVPUXBwA7nXCUqr4EPkdGMECZg/Cg6xcQRFtnpaiyLFBGzNOin7J oPSw+47pjremVIMaVCz9KB7tyy2C0B5nNyelWTRttzIBJiuXezVCVCOjhh932nAYTyxQ Ji2uDtgQybmLKvRLYDPuhBVNoIjXtbLoWGpRL4BOwhqUznCZ6NaWu60jMufOZa835Md8 wIiNPY3RNC/1FiBGO/E4oz2D3y8jLlJKY7ybwRslZM5PItw6jHG+mjG6XgLk3WiTEogH NacKPY1083gmcswbrev/oT/H2DA+xQNmO0ZcwDIWk60TCUR5mu5Ep/ESsN1SfoiBIMn8 EIag== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=MPDtfEXW1QDBrfOFRWRcKVkcf7xxh8cTTvDDU5lhrXk=; fh=SNmn9zk789gtKyJbU7zBCeGIorNFaeG7BmrYNNpmMYA=; b=B3tYjVYIbCi9z4cOADtCZTs6WaBOUxRvKGTkDeFn7Q24A61Rw9Omfy7flanVkVC+w/ F6XtFe+TQ3PtwMZtQEZkloPihHKXpLM2RW/YaOXach9CUkEzANFhJWF8aEfTX/cjHruu +CmUfjTE71Ns44wVCs/lBYmzF7PiH6F1nSJkJtSU0/V6uZ8zX7c4trFC0+N4V+d+Go+X 26BON9Mx4rHZ6Vxgwn/7nxqYn+aMpwhC3ktUntI32mPQEz/DQ+I+dLB4HwoMhd8JF+bt L0ytk1Ik6I1AgUbv0o48pgVaZqrHNLqk/WoXjrFnNi1o3hyeZFDiJwLjVDo9Nuri43XQ xIsw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QazmYjNS; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62019-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62019-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCXsioVnWSnvq19lk0e1VMIKN4JyiJ3nm3sYiwebAN4sC0abEBax0GbTix/OGrUoKChD1ieNn5hrQOESuLqtXV98Ge4jEw== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id g8-20020a0562140ac800b0068d039d4f08si851696qvi.132.2024.02.12.08.56.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 08:56:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62019-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QazmYjNS; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62019-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62019-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 070341C21C47 for ; Mon, 12 Feb 2024 16:56:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 59E2347F72; Mon, 12 Feb 2024 16:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QazmYjNS" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DFF33D565; Mon, 12 Feb 2024 16:53:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; cv=none; b=T3bscHW8rqqFPhxNmbfhbad/8/0avyLV4Dumv2AZ16xD4O+oZkRbeND1N3hNZtxKTUfzPjchfHtIhQpIbBi8ZQs/WYkdrurD6Jhu5/EMFofJCp80QxbvwvFjAIzkfnoF2p3DMU2Ffaiy3T/TQiFyw98a43HnUHcmV3jC09pXsGk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; c=relaxed/simple; bh=mFlQy5tvAhpclwFJjCDguvWh8qyMMwHvkbQ54iBIAmw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=L2KuGIf8VnS+3eu1CLT1yd6fP4Z/4wB/y8HSbEhLvZKz0vkXKyjVOjeG8GX0BR8Sw+XpmmGqgGSw6TXkO8uLqRChIqUP7d1aJT5ms5GHKRxTMCYMGY9sda5A4iAfBbCUc2XpIC/61802pIq3Fc6/hNSwtRvzkNahgtObwchmKas= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QazmYjNS; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1915C43394; Mon, 12 Feb 2024 16:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707756818; bh=mFlQy5tvAhpclwFJjCDguvWh8qyMMwHvkbQ54iBIAmw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QazmYjNSyuroI/MJ8mMKecXHVW5sxOkWkFowEUaf8GAOZB+a9A050hSJnzs2a11eI IJbeObTk2s8AqG8fQC3tBleFxU2HldiJzT/XbYZU+n4mmc/iNiO+lA6u6bRyNLLwxF pPQFzowW2rK+LM/PWFyNHWzeBkQbjU5jumldM+TxJXnSo1/vMqJDIsPsFOnquPneLE CFiuelrBWXjfaTdPXAaKo/HOenF46p0KRRBe7wPmd4jlYKhtvJ3OKfaMIdg9NZPwUC unUw2Gd+4A4yutjXN+LT13lpw+tk+i8zIbgbpAZwlly0EqTb3izU7gbV7NkRMUcR0y b9TR7sW40xLYQ== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rZZZ2-000000007N7-2kAz; Mon, 12 Feb 2024 17:53:52 +0100 From: Johan Hovold To: Bjorn Andersson , Bjorn Helgaas Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 05/10] arm64: dts: qcom: sc8280xp-x13s: limit pcie4 link speed Date: Mon, 12 Feb 2024 17:50:38 +0100 Message-ID: <20240212165043.26961-6-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240212165043.26961-1-johan+linaro@kernel.org> References: <20240212165043.26961-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790713024343009364 X-GMAIL-MSGID: 1790713024343009364 Limit the WiFi PCIe link speed to Gen2 speed (500 GB/s), which is the speed that the boot firmware has brought up the link at (and that Windows uses). This is specifically needed to avoid a large amount of link errors when restarting the link during boot (but which are currently not reported). This may potentially also help with intermittent failures to download the ath11k firmware during boot which can be seen when there is a longer delay between restarting the link and loading the WiFi driver (e.g. when using full disk encryption). Fixes: 123b30a75623 ("arm64: dts: qcom: sc8280xp-x13s: enable WiFi controller") Cc: stable@vger.kernel.org # 6.2 Signed-off-by: Johan Hovold --- arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts index 511d53d9c5a1..ff4b896b1bbf 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts @@ -863,6 +863,8 @@ &pcie3a_phy { }; &pcie4 { + max-link-speed = <2>; + perst-gpios = <&tlmm 141 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 139 GPIO_ACTIVE_LOW>; From patchwork Mon Feb 12 16:50:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 199926 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp41625dyb; Mon, 12 Feb 2024 08:56:58 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXyzaZ7s9UoaxrG0LEjYIiIwdRrhdxCcshVJIHIV6ic+DAoBzqHNLDSZVRXzcujXfVxJ4SepMeIHd5QeBchdZlt+pg7Ug== X-Google-Smtp-Source: AGHT+IHY5nmHGmsPTZNd8GKO0AMKJqXINnVJqF3lIhr4c4TW+GzFuXQKRMuULSNSt7mv4pDt1vXV X-Received: by 2002:a05:620a:146e:b0:784:93d:c905 with SMTP id j14-20020a05620a146e00b00784093dc905mr8273274qkl.25.1707757018210; Mon, 12 Feb 2024 08:56:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707757018; cv=pass; d=google.com; s=arc-20160816; b=Kv6rxtBZCamVavg4INKtjPYureI2R1AODVgp1B6kbkLuoingjnGTNeaduoNVvzS6ep EfYIkrNFQuH23hsVcrWcrVXj0pbtWITchsXJd7DJof8u6Rdlh2YnkHpTA9TDcN4+Hi0S /yQMknmTfMln743uYIgZ5p8h1xnMzktTHgcz3P/Korsk+vipEGfQsCucdtvRWnt8ckod G705t00R7PS5XF9USgmaBBPYSdXyCYktn5gfdEzkiuftJW8qlAXmjNljLh2UTjFfGx1+ slVw4phwktHInJSdgIp7HqemPAWt6tqAsxQmpjL5PV/YhZSLc0YMY47kq0tveKVCY9ai 76iw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=k0kNP2LbxZt0uH/Mw5ytm4tN1ykHKbnq2ImCGrmiqNQ=; fh=q7BsE0vEN8TwGYGq+PA1aAQ86IjXdP6K5JzT7roDxjU=; b=YobPk0U2cAHr/lHMdCw2pZyesEa9M3AdjMt4GQzDi8qL8prpMeYxAEFKLuF7zMdouz 4IzT1i/mFMEE+PcBm+D06QG2HOpQ0zrf6QsOAz6Kp+llFGvxg1sL5h8Whxk28Kbi0FjQ kyxPhE2YXk32G4gf6ymrEyO6a1k9pnJauP5W8lRcVhV+bvLjjPU6ekVquABSccaEkYYz 2g+icmxIZR+uAK7BCXjDUSuVG8LVUHVhkjX4cyWWneoQg1I6qHq5o4XnH6FUeCmUGpyC 3cO/9B0pEZ3WzcoWVVi/TFOUZ6Cq9jK1uQRGjMK+PJxo1D796hae06iW3REmiaBxQ8T4 Rd2w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I3Qex5DE; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62017-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62017-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCWBUNA4zrR1da7oj+G9QHNSb0+1HZ1ZGM0CR1yz/Uwfsi3QisCU9whI/T9p+X7dtpxxzNxxo24fBAWsGLRwpH+vF4oDGg== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id t14-20020a05620a450e00b007859d7c0317si6903928qkp.293.2024.02.12.08.56.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 08:56:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62017-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I3Qex5DE; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62017-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62017-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 074A91C21F31 for ; Mon, 12 Feb 2024 16:56:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 59CF347F6B; Mon, 12 Feb 2024 16:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I3Qex5DE" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AED43D564; Mon, 12 Feb 2024 16:53:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; cv=none; b=lT+J3lXlhwXtyXCq6QzsbSAYNE1dRJzA7+0Q+cGS51eR+1hiVI9RmTmQF9npz/PCU507gQOnTOiS6mVldNMNe5Y4iOlyn/B6P40kWM1pPnmq2KA/pOs2n5LPdnuMMSBq1N7QQ07QxXr3uxlt10mnYA9XgVPrF+H8N0lY+MUCH8o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; c=relaxed/simple; bh=do7qssSaOOsYhWX62CD8zYvmH36b7lYP/5NxcIsaPjs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UlInEwubJ7IFzxoUjN4G1nmL/8/AuaxTeLx9Wf80EQxt58OToiII3D6sIJf4+ApD36N3w0GyrIXskI1wtiBC3tv82xiWpojMj7M7N8vkiAKXozklrkxFoYnGZld0JLqCHSJgynbAZh/h/prUFZoTQR4u9aGOQbGCiVFtDzaKzYk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=I3Qex5DE; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF12FC433B2; Mon, 12 Feb 2024 16:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707756818; bh=do7qssSaOOsYhWX62CD8zYvmH36b7lYP/5NxcIsaPjs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I3Qex5DEUTE0gyJzfX48bECZ6IBhE96hrd/5Q/RgbRDZYYPBP009ZSkMInwzN2DOm P6XanD8S/U6r/a8bOZ1iknkabkKPyLCRV7ZrfAtcwRWBlt/kxhnjStNqYrfovGHNch yVpvN/Ig+SjLgfCe37IhBTwMP8n+it1YSKvdltRT/1B8DOO9ldn5ZFkMpeal/B+tvz j550IwlH6yteAd5MAMPzD9EYFEEzK+soG6ModfzaGOD32MNADY7fsLxVjqvkX9yXiF 20UcLfoyOH63PzfYz5OSeRYw2NNlPnXCrYXYCj6e4iVFuivVhy33IpZJzxHYNwZ7J3 u4jgReaP0Xgtw== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rZZZ2-000000007N9-34RA; Mon, 12 Feb 2024 17:53:52 +0100 From: Johan Hovold To: Bjorn Andersson , Bjorn Helgaas Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 06/10] arm64: dts: qcom: sc8280xp: enable GICv3 ITS for PCIe Date: Mon, 12 Feb 2024 17:50:39 +0100 Message-ID: <20240212165043.26961-7-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240212165043.26961-1-johan+linaro@kernel.org> References: <20240212165043.26961-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790712941569344927 X-GMAIL-MSGID: 1790713023086509149 The DWC PCIe controller can be used with its internal MSI controller or with an external one such as the GICv3 Interrupt Translation Service (ITS). Add the msi-map properties needed to use the GIC ITS. This will also make Linux switch to the ITS implementation, which allows for assigning affinity to individual MSIs. Note that using the GIC ITS on SC8280XP will cause Advanced Error Reporting (AER) interrupts to be received on errors unlike when using the internal MSI controller. This will specifically lead to notifications about Correctable Errors being logged for the Wi-Fi controller the Lenovo ThinkPad X13s when the AER driver is enabled. Signed-off-by: Johan Hovold Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index 36382b1bd965..ee6026f4f12c 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -1737,6 +1737,8 @@ pcie4: pcie@1c00000 { linux,pci-domain = <6>; num-lanes = <1>; + msi-map = <0x0 &its 0xe0000 0x10000>; + interrupts = , , , @@ -1838,6 +1840,8 @@ pcie3b: pcie@1c08000 { linux,pci-domain = <5>; num-lanes = <2>; + msi-map = <0x0 &its 0xd0000 0x10000>; + interrupts = , , , @@ -1937,6 +1941,8 @@ pcie3a: pcie@1c10000 { linux,pci-domain = <4>; num-lanes = <4>; + msi-map = <0x0 &its 0xc0000 0x10000>; + interrupts = , , , @@ -2039,6 +2045,8 @@ pcie2b: pcie@1c18000 { linux,pci-domain = <3>; num-lanes = <2>; + msi-map = <0x0 &its 0xb0000 0x10000>; + interrupts = , , , @@ -2138,6 +2146,8 @@ pcie2a: pcie@1c20000 { linux,pci-domain = <2>; num-lanes = <4>; + msi-map = <0x0 &its 0xa0000 0x10000>; + interrupts = , , , @@ -4426,7 +4436,7 @@ intc: interrupt-controller@17a00000 { #size-cells = <2>; ranges; - msi-controller@17a40000 { + its: msi-controller@17a40000 { compatible = "arm,gic-v3-its"; reg = <0 0x17a40000 0 0x20000>; msi-controller; From patchwork Mon Feb 12 16:50:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 199924 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp40947dyb; Mon, 12 Feb 2024 08:55:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IEgutZ0cFMVS95Pg+Ps4ERI5jLmxLLANaTdcKGwl1ZmnsAcQVC30BaM0UjjiTMbD2w8VORE X-Received: by 2002:a05:6358:714:b0:178:6e53:ed4a with SMTP id e20-20020a056358071400b001786e53ed4amr7855571rwj.8.1707756937424; Mon, 12 Feb 2024 08:55:37 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707756937; cv=pass; d=google.com; s=arc-20160816; b=tN2ch9KTGykWhsRr6SSPV47wmXT4vsZ/wH7P6kPFb8CmDpw08iBUiNGu1aPnP74+TV QldZU7LMEINobagmNB2c/KKAdoBKc6GnQV0qsQEoxxSjPVagc01sULzNlFRUqgDSx3M+ ZuxnRNDH3Wr6qOjeNqQssk2RlFKkePVeeRhnQSUh+csON1HHxXNv87YAljudej3ZJhi3 23SY0CAQzk0QSFgrgfPbfG5QjN0HHDynWmqbx+32HZe2H6oyUYmyj9Ocv4sl6GwohfYX Vu/siO7MG1MQe2hOKRpAZJNCh4rRfuE2c16Y07akLJKNkvjCOCcBKCOaq0FPZ1hwJjnk uBjw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=HnDLTk9jlUAH8B2h1c9zk43d7sUvp0s1q6pQ4V4KWS0=; fh=/M0hLCqorSiVIgS7JpV345UEmIgYjvUz8V/xdn6AIoM=; b=TPVHlbg6KlT8Z+5ODWJbUD2aKwdZo9wPf+6+Ex3em7XHHig67sq+kKJEEVg9DQBA5Q CmV2yUsMJBWDpeg8ybEd8T/Xux/YzoPSwKUm3HRSKO+1g9QvqLiaL5gT55Hj/xdPzziU MMAQ9Y1qjG/vFPupRQtOnbB4IY83PXwjKkHbPJIcVLCelJNmjZc2M9MvvkMkQv7MK7hF Vftp5eDuDoZg6qE63IF3xosV5lg1Jrb8d+ONGkKpyNtuaYO93/ywHICtieWMHZvTO3qz BhiF0EcXAz8Ez27NPT/r/QiMpj2Rg9BprduioDaSGuHgNH8dL7NFxO6pQTU6acmbzNao DxhQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YkJ9Yqxe; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62014-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62014-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCVClVCQQ1HaaWa7zvUgLWCIxRAPG16GTcOnbXF9G8G6JDvDoE8FBDW1xrhBL9XWFz6kXkFpGFLcOC+GZLKCr1z83hxFew== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id p10-20020ac8740a000000b0042c71310957si751150qtq.175.2024.02.12.08.55.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 08:55:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62014-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YkJ9Yqxe; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62014-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62014-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 0CE871C22445 for ; Mon, 12 Feb 2024 16:55:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1C67C40C03; Mon, 12 Feb 2024 16:53:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YkJ9Yqxe" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28AC43D3A1; Mon, 12 Feb 2024 16:53:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; cv=none; b=P+CXdLnauS5sM1syTy4uBlQ60TQG0vk7Efie0VTYnf+TTELVNIfYx6q9/uxtp5RPZUjS9Z7z24oc3jfdJiI7zp+2iU/DEbW35/p2fWQmci3gg2rHgnLaeZFQ3DLV2KIHWyrjkeFo9UO1cUeg12k/rpWSJ8n6M1QSP5Qx5nGTP4k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; c=relaxed/simple; bh=nc4MqV6YaWXP4nv2pZ90dCQqT4i4GYj2D270C7X4X5g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JAHlXxCIcRPm2CBOXOoLvs2rcJBhu+ByzTTC1BMvLSmtRamZFaIGpQ189yB3KF2ajHOrKwHQ3j3hgjkAKiNaZ2IyLXrn9a6+5bX8e7j9kZUpoqTdqa2KHS1wwKwSuhmHvOaGmAgry2n84nIeNnaGK1nusT8MQS5PSnPaCD7Wb2w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YkJ9Yqxe; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5C7FC43399; Mon, 12 Feb 2024 16:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707756818; bh=nc4MqV6YaWXP4nv2pZ90dCQqT4i4GYj2D270C7X4X5g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YkJ9Yqxe2rkvBsFYQXHVLOHTbYd1bYXt3mmVLH0Uis9itgcKVJJd7cDhi/KtBLHpM yWikgU5w6EiQaofDMr54Sh5raJbarLkP+olgFIvp+wlW16eOaAIQoZTbcT9HwH6b1D xhG0gJDLZMh/6dRjgMaZxMg8Sy2GAMPFyUfyYO2uZzp8AuhoE36LzLbPBuwa6XM2+s Q6uZTdQycmOaVNteQQGhxC7UElnZgVst+TVsyH4zg1ZICmQDzcOJA+35/0q08cjzv8 rQJqRlbvyRZTn9BnLXfESp38OPFYGrxCA87WqZ+Sa7arrIhP/h/M32J6h6duojKDiQ mUQ1RiocdSKNA== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rZZZ2-000000007NB-3T1E; Mon, 12 Feb 2024 17:53:52 +0100 From: Johan Hovold To: Bjorn Andersson , Bjorn Helgaas Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [RFC 07/10] dt-bindings: PCI: qcom: Allow 'aspm-no-l0s' Date: Mon, 12 Feb 2024 17:50:40 +0100 Message-ID: <20240212165043.26961-8-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240212165043.26961-1-johan+linaro@kernel.org> References: <20240212165043.26961-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790712938678352060 X-GMAIL-MSGID: 1790712938678352060 Add 'aspm-no-l0s', which can be used to indicate that ASPM L0s is not supported, to the binding. Signed-off-by: Johan Hovold --- Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index b28517047db2..4d1060b52592 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -130,6 +130,8 @@ properties: description: GPIO controlled connection to WAKE# signal maxItems: 1 + aspm-no-l0s: true + required: - compatible - reg From patchwork Mon Feb 12 16:50:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 199925 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp41260dyb; Mon, 12 Feb 2024 08:56:12 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV/+HBNeMg4WSgvoBMzjlhvB3VCTlv4MTfg9VSmFONSubHfI0h80XbOsJASsnK695h3/0oWVQ4attdHr1Acu5zwFs++LQ== X-Google-Smtp-Source: AGHT+IFi5nglGuW0pUc/Vdjggo/N7LL+zA30wTykLEBFLg9HOvpt3cRtU+d81xmrEYjvOK9k4J2U X-Received: by 2002:a05:6a20:d39a:b0:19e:99be:c53e with SMTP id iq26-20020a056a20d39a00b0019e99bec53emr6022185pzb.48.1707756972054; Mon, 12 Feb 2024 08:56:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707756972; cv=pass; d=google.com; s=arc-20160816; b=wrRgxf0DpAWIcPvTlnhkD0OxrfTSzi1u1OvOe0YJV44oh/xuBtmLopFL12Jdb5e8gq 1BLI06opBGtSHIQcaZyhDM1uewHw+P7G26rTAUKVpxD1p+skn95P5ydcqiAi/FEN/kmI tvHyMx0MYcHlqfPDt/j279YPIM2HwnPgGMOZM1I4c2Uda0cU5rOgPDh5wXkwwtk4eHG2 nouJ2yu8lvTFPViAMz++57trX6cgRzg7eHbdnY1X85aoT7TcqipGnYc4Nw7QolmEb6aJ arRXxY8yvgefntLOLefqtAnvv6hG9buY2wJOIOpFqPZ71IWBFLTe/POVXISONL/WtJuJ rXJg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=U2UW47qceNmlc6LDcki5GA6JcjIPuB/699NdbnKKxmI=; fh=dYO/ONXUWnOZUKxL7WKm6+Y49UB5LFD61rar8T7xQR4=; b=ZAzFEFGg94rxpr/vhH1WVTUB6XwoMMnNCxsFGrl8HvhQgi33xSg2G6mQJCLzHC50AE kh9dgPn9JWQceLbfvdUQCpI7TDhx47/lfld8+IV0UcZEkHoBGYkl+GZHpr9Hz6ezG4Zq vq1gPuWLDEwpNfSqIApc8GUE28llKtsUNwtsTSw4PPf3ukzFeAqEvQAlYEg356iJ4bSJ OJS0ZbgWXRP1zdSUgixEPjMcwlg8bvxwusgz80SfWbONsUxfnpF3yVPF0my9Y0zBHS1Y g9X9dRjf1GJk8kIlE80ha2IoVw18HMZoe0f15vP3MeK1mKQHIvZ6XPsm1EPAJAMpuXl4 hdfg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iJeVWBXD; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62016-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62016-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCVnxmX2i/bMm+RDPioUu3z3+XMHpmX2BCggkRsSYao8z59CDiCiSuEY8m62nY5cPcKvb8z52H+mmTPdkz81Kl4LdMD02Q== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id bx35-20020a056a02052300b005d5c9f0d40csi525604pgb.302.2024.02.12.08.56.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 08:56:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62016-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iJeVWBXD; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62016-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62016-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3ADFF2850FD for ; Mon, 12 Feb 2024 16:55:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2441740C0C; Mon, 12 Feb 2024 16:53:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iJeVWBXD" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28AE93D3A5; Mon, 12 Feb 2024 16:53:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; cv=none; b=C8mddkwkVKSIEbSon21BfDqO9+WJR4S7DHmQd6NOunZoBzOtLxIX0VrTz4hLHTV+h9yyrcDS2kxe+61vF2hRRqKMBRuRAUwzUX4uvEE9Rd/vJRcdRiDcCapHci9iJkFcLX51saLDmPq4dvVnpTaf5zPTYE4LalMlo8SzRy8l7/Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; c=relaxed/simple; bh=FW7pWyR6CDbZpSvqQAnPnh3O0BgUJoHXgLMGGLsnOac=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P7sYFh9FF82DjIwARA6I6b7ruy7MAuULifm2rwrXOl/Y6b/pEW1Dsru9U9wKY04iIJmGF0KVotqY6Fc1I495PyCOc4b+i7e+D+SBkZaVFWkaTuujPYZ1pkHVwlyt9wWmYt6qV9KohznLk4sIScXkryXEd+VNuO+sbeRZDMDa2cI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iJeVWBXD; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3619C43390; Mon, 12 Feb 2024 16:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707756818; bh=FW7pWyR6CDbZpSvqQAnPnh3O0BgUJoHXgLMGGLsnOac=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iJeVWBXDa0zorvvqAbyrlHXWCaGRup8RZbadOxfQrtGqDt/6zQKGpjvLuZbVoZLjK MnZNItAjt20yVUEilA7r5PXQ3hS4M7BBFZc0egOrZ7d3mU+mXl+ENkQuvqMpTXva97 GDao5hw2Ns9PmMpJ2Nd7/LLTQApVIco45bkwmGctYJ6TECGYEAwf1yBz+CFYabZ5E7 reXZoLV+xf3V4ZGFJCmUPp2Mf1uV6YlNSqgmQUkkxRrNeBhYtKcbMjZLdHOWd9XDJF +GgCspH9nSSzWMJO3qP96ZWpp8fLhakLFmtwaIOemQ52rbrg7ycLHnQCGMoIPR+IzJ +aQBu6xTozjkQ== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rZZZ2-000000007ND-3qOe; Mon, 12 Feb 2024 17:53:52 +0100 From: Johan Hovold To: Bjorn Andersson , Bjorn Helgaas Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [RFC 08/10] PCI: qcom: Add support for disabling ASPM L0s in devicetree Date: Mon, 12 Feb 2024 17:50:41 +0100 Message-ID: <20240212165043.26961-9-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240212165043.26961-1-johan+linaro@kernel.org> References: <20240212165043.26961-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790712974896110305 X-GMAIL-MSGID: 1790712974896110305 A recent commit started enabling ASPM unconditionally when the hardware claims to support it. This triggers Correctable Errors for some PCIe devices on machines like the Lenovo ThinkPad X13s, which could indicate an incomplete driver ASPM implementation or that the hardware does in fact not support L0s. Add support for disabling ASPM L0s in the devicetree when it is not supported on a particular machine and controller. Note that only the 1.9.0 ops enable ASPM currently. Fixes: a9a023c05697 ("PCI: qcom: Add support for disabling ASPM L0s in devicetree") Signed-off-by: Johan Hovold --- drivers/pci/controller/dwc/pcie-qcom.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 2455decc574a..071741b81644 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -273,6 +273,25 @@ static int qcom_pcie_start_link(struct dw_pcie *pci) return 0; } +static void qcom_pcie_clear_aspm_l0s(struct dw_pcie *pci) +{ + u16 offset; + u32 val; + + if (!of_property_read_bool(pci->dev->of_node, "aspm-no-l0s")) + return; + + offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP); + + dw_pcie_dbi_ro_wr_en(pci); + + val = readl(pci->dbi_base + offset + PCI_EXP_LNKCAP); + val &= ~PCI_EXP_LNKCAP_ASPM_L0S; + writel(val, pci->dbi_base + offset + PCI_EXP_LNKCAP); + + dw_pcie_dbi_ro_wr_dis(pci); +} + static void qcom_pcie_clear_hpc(struct dw_pcie *pci) { u16 offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP); @@ -962,6 +981,7 @@ static int qcom_pcie_init_2_7_0(struct qcom_pcie *pcie) static int qcom_pcie_post_init_2_7_0(struct qcom_pcie *pcie) { + qcom_pcie_clear_aspm_l0s(pcie->pci); qcom_pcie_clear_hpc(pcie->pci); return 0; From patchwork Mon Feb 12 16:50:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 199929 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp41641dyb; Mon, 12 Feb 2024 08:57:00 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW3vi1hWZ5io4o0cWZh79GdnqgDX1b+hdwms7suNYSFVM7sC0lbsb0M7TDxOZl+5Ti4I/1v/SFIOyZ/dXCH/14azAPqwA== X-Google-Smtp-Source: AGHT+IHaDLK1bU2I4coy3PlXebCDn6XyZd40ny9fbkeF9j382Yv/KtM44uycK+YObrofWc4/MTIj X-Received: by 2002:a05:6214:f07:b0:68c:86ed:ea2 with SMTP id gw7-20020a0562140f0700b0068c86ed0ea2mr12699518qvb.5.1707757020199; Mon, 12 Feb 2024 08:57:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707757020; cv=pass; d=google.com; s=arc-20160816; b=gmgJjkAoH76VcuiF2P+Y0sHuMyNgUiRXVTAMq9scb3sa7itZ1M0ZAfH5jPp2o+60pZ lQRz1q7VR8uXVV07H+m5gRXR+zkcqjt1lOXHzXg8BmSwctZS2uQy//1ujmZQVm0pLNkB b3GQi0Ws9xbC261TttgdOoQJpm5PKMmpTGL/0CB2xapUIwNNGxXBQgA0wBqeKyl9HnA/ AEoFJy3dVvxz4Fk2vAd1DJMym51gDuTAiZZyBaUebsr750/2Js0J6DeK5cyPVLP6ZIUd 6QXKp482Wl1ZqWH9Zu2q2BvjhONaSMTafmf51+GVaTvtWn2uW+vNNaypRjmrFLnVOroj T8Qg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=elxqv+OgAlP1rLPFwnTEwh4As+j5EvKZeZITbSQFL9s=; fh=dXomMJmXc89NdY9FnMGTzDb0CkaD/9meNuhJAPQckVA=; b=v4tkUFKk0KKSGFC61P9idadP5FplyqW6hzfPWyvsK2hPCXC27SW2KWmO83gvtKJgj/ yRvTynuhxI/A/kNtdv/9803ifPNXctF5+DxHgrrMsF0cod5+1OVESSOhbDfwgmTcwpt0 jVruQYs66StGgtTXsBdqbCiSEZB31cxTVn4rvTu4fF8gKYrjAL4y4RaHIBzJaeTkZta/ hOL9caDPZkqk2vfDLBkJ5xny4s9uCCduFWYG4KYM9DOP/Zs+alXcerOTaXhTra0ALxv2 6B60kYXpq+tLKBJpqxEicftjZ1SqolX124d1AR5UP6pc6mHUaimdnA6UTmNrjVPLFGTv GJgA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p8rGL4pv; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62021-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62021-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCX0BD99u6iWpb8ZY9MtD1FA/KjOFqFKgbjj2WA7YNxVM/k1MljXUBXEXsO60ERye0lCTnB3/zHsMlYi5zIef/gqdqUtFw== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 1-20020a0562140cc100b0068c83271adcsi836309qvx.228.2024.02.12.08.57.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 08:57:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62021-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p8rGL4pv; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62021-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62021-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 01A4B1C203C0 for ; Mon, 12 Feb 2024 16:57:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6791D481A5; Mon, 12 Feb 2024 16:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p8rGL4pv" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9723D3D996; Mon, 12 Feb 2024 16:53:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; cv=none; b=XCdlHDIyKMnbFwFlelDuLCAimX83J3ZAQQGhQfpxZ6kRL+tXFVyEGHkvpBqnYuXQx2R36TTOAla5X1sWpczHRFpI33qeEpUoh5CTcMZ1Q8qg+Zb4OdoVj5GfljjQZScVThxJmAInzObXoAiksBWqVCJ1fqmVRrtONwForKhtrwo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; c=relaxed/simple; bh=nc3KMv6LaxhZJZMcRLz/F3lbKNxPeRWIM/UQNUFhBwo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=A/Qpxm+PCN0D7/CnolXMmdGdNhj8wbSx6ThI4qbRMJlhLkJ8RK7GrNu1U/Rl+ROahTucW3cNkSm5ZsTqw7G9Yob6eDw4U7aaQNXYK+lHQzxgrzcRJ1G/nWhhLzSIBEO5doqyTtijQt5e8V/GTj6QXkIRjt8gWQUQL7+2ci97Zkc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p8rGL4pv; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDBF1C32781; Mon, 12 Feb 2024 16:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707756818; bh=nc3KMv6LaxhZJZMcRLz/F3lbKNxPeRWIM/UQNUFhBwo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p8rGL4pvSvJ8SJXhzR6YZt4uxpFW2O6EKr/IfVHspDA6tIcbJiTJkUU3+xp0RmEVM YX/rEdOmlQbCoxEOpN3zcbnDtwF6NKzych7w9+JDth73pWQdZiEQV9n5wuyM8LTxHT HmKIhddBIRGWm16YTuw1GfFRvit6ch806/mWpcBk3lF5NjbhzwBc44So/YJy+pu09r hddkBd+sPF7dJR76fOMHh4PECQYNrGuYPqoj11F5EOAUqDDcJrcA+qIGO32P7zEBY+ G5MWve+W9ziqS6B391s1ScXfw1ivWxxichFfAi+uBdS2uQNLpfTd76uOxFzfiBZ2mW /dXCBhAp8neDg== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rZZZ2-000000007NF-4AyO; Mon, 12 Feb 2024 17:53:53 +0100 From: Johan Hovold To: Bjorn Andersson , Bjorn Helgaas Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [RFC 09/10] arm64: dts: qcom: sc8280xp-crd: disable ASPM L0s for NVMe Date: Mon, 12 Feb 2024 17:50:42 +0100 Message-ID: <20240212165043.26961-10-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240212165043.26961-1-johan+linaro@kernel.org> References: <20240212165043.26961-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790713025490113231 X-GMAIL-MSGID: 1790713025490113231 Enabling ASPM L0s on the CRD results in a large amount of Correctable Errors (Timeout) when accessing the NVMe controller so disable it for now. Fixes: 9f4f3dfad8cf ("PCI: qcom: Enable ASPM for platforms supporting 1.9.0 ops") Signed-off-by: Johan Hovold --- arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts index 8c1fccf8847a..a428ba624ce1 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts @@ -525,6 +525,8 @@ keyboard@68 { }; &pcie2a { + aspm-no-l0s; + perst-gpios = <&tlmm 143 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 145 GPIO_ACTIVE_LOW>; From patchwork Mon Feb 12 16:50:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 199930 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp41735dyb; Mon, 12 Feb 2024 08:57:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IH/crjBdE3GCgr3tjqVQo5ymedBwWpEbw01b0o1qjqDC0vMXZGXC6Y2aZo9EILfVa47Oqga X-Received: by 2002:a17:906:1999:b0:a38:882a:ad98 with SMTP id g25-20020a170906199900b00a38882aad98mr5813769ejd.24.1707757032482; Mon, 12 Feb 2024 08:57:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707757032; cv=pass; d=google.com; s=arc-20160816; b=SciuARlFYC0VJMzqvIcWHmcS8imSoPMGHO+J/y2iZgrdAksoEXV2O5f8I7L0luCQjt +IOKrQoplvlCBJBNo0HKqY+LO0aLSzux63J6qQoDOgwIP2iHZ2hC0Lvop78IAZolmeut Ks1owl/6nRfaUwQVTTUgyVbLcj322v94pkaeM2t9E1ltR8uNXXpnkWbEfPrApPoleZRL dSi9RJXzwOw7aweS62D8bYfk1StiEjPZLq0vEJl0boAWkgf+NmN+cZRMCbdxEqYzqBX5 iz6sPNajZfvoMTwTS4CBE3dp7PHGt2T0L68HD3HssjTK05F+I1ZSX9lD4cX0aqVTg7Zj aXzg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=fICqQT0oKpWDTH2rFNLLiC/qsEaa9pzRUwljG7ZhPT0=; fh=yzYcTcXhmg6x8e6hzfZymYiOySr5ULho66+z9Ro8r3o=; b=yhvd/zgI3vF9D+heiUsNpK/tue1eKjMScZ5TZafP2lqcIJ3c6xruPn2Za8xn3hIc8u aSoLoG5ryUFKLhabIxIQkuu32xjGceRHBlgmgV/PNWyyI1qtREnfCdY+NOZVn1KohEfp MXT9kgtF1fIngT+afW+eHF9A7kE1VAharccUemVP+Lg+3fnOfoejPg9nqMES/PjJBDz4 lThVyJPtrxfNDQ8Nq2gT7be8fSch9qw9zNEv076CN82zCeNtI6VsqsW3FJ2n5u8Vnlp1 UogfqwrkDJqPlTv5lawya3R2jccVoCxlVf82wfNIGqjlsdgVK2FQMcIVgrDVhDofr/DJ 8VUA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YitcKmDa; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62018-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62018-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCVgl2SxF+PrK6Vfla2yMztXImzmo1whpn+utYr9oRYYA/ghGWRg9FMzjR1RoZTBMcyznc8UhiE4OLpYmdb8LB77HCYsQA== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id s16-20020a170906c31000b00a3c8d9a1499si360118ejz.343.2024.02.12.08.57.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 08:57:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62018-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YitcKmDa; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62018-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62018-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 89F231F23D25 for ; Mon, 12 Feb 2024 16:56:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 59E0147F6C; Mon, 12 Feb 2024 16:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YitcKmDa" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C7283D560; Mon, 12 Feb 2024 16:53:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; cv=none; b=p221Uh9qeoY3HWNI4R6o+q7BsOKcGpmXPu44v1rKGi0AGr4XuUluu3QmDWICpJ+277kC5FMZyuS/j+rd+e40EBPBqxIuEUcmBXQvMYlbSI5Nkl0Ds/M9CcJb+vemB8dvWISiWOpM5X0Ov9wshAmBAJzfwXc3qN5L3k6MG7QbQt4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707756819; c=relaxed/simple; bh=BEJ/GlZcEcIeY41YB328X8vzZf6tkBr888FPIZPHjzg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nMU7u8L/wSd2joYBP1TvOqXH+fmh8KIUmxhKjpvptjqR8xu2h8rVTZCNjFojnZt2ZxPNFuO4VoGaeS1N54biuYL0mwM27zcMIFm0pAU65sdiSnKvf1Z/txvLOgmmsvcleku5UanzfdB3CbN+yA6V6isjUxUe6uqspmAEbkxZcDw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YitcKmDa; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB2C3C41630; Mon, 12 Feb 2024 16:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707756818; bh=BEJ/GlZcEcIeY41YB328X8vzZf6tkBr888FPIZPHjzg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YitcKmDaWTdTmxZSSRNlNxyqvhf9hP/VT58cE8Km+Vp1YXZurJTs2p+iEhJGUa5CH R237iE22Xgo+4OIFWNBI4AifareOBc9my3nmTQr7k/AKzNZFvvSyZ7sM0ZngjN69RR 1XTbDmYx5BNoftwz1S/2Y3OEYIwCTqN5SSUnWx2hizGlpmDyVBAKrwokQpEztin70P 4H1HMqBkXgM38f8szZaDPLhD0PfL1lFBfw3bHphT220ix3Sx2LOeDJsVnLaTbebZ9g dkai6btbr9tz1cByfR07ib6i0sy9U40sh7pGbHhayES3qrxjJBc5zSTsgpUkfgaUSi tqQCJBnKWjCXg== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rZZZ3-000000007NH-0J18; Mon, 12 Feb 2024 17:53:53 +0100 From: Johan Hovold To: Bjorn Andersson , Bjorn Helgaas Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 10/10] arm64: dts: qcom: sc8280xp-x13s: disable ASPM L0s for Wi-Fi Date: Mon, 12 Feb 2024 17:50:43 +0100 Message-ID: <20240212165043.26961-11-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240212165043.26961-1-johan+linaro@kernel.org> References: <20240212165043.26961-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790713038375461277 X-GMAIL-MSGID: 1790713038375461277 Enabling ASPM L0s on the Lenovo Thinkpad X13s results in Correctable Errors (BadTLP, Timeout) when accessing the Wi-Fi controller so disable it for now. Fixes: 9f4f3dfad8cf ("PCI: qcom: Enable ASPM for platforms supporting 1.9.0 ops") Signed-off-by: Johan Hovold --- arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts index ff4b896b1bbf..aed857feface 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts @@ -864,6 +864,7 @@ &pcie3a_phy { &pcie4 { max-link-speed = <2>; + aspm-no-l0s; perst-gpios = <&tlmm 141 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 139 GPIO_ACTIVE_LOW>;