From patchwork Mon Feb 12 11:25:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 199671 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp2375689dyd; Mon, 12 Feb 2024 03:51:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IFBDgrc7PnOl2OLKfKoozivCZY4jZE4n0rmqegaE6HNa7qcFCVX2NW5/CBEIceo7I+VeDXa X-Received: by 2002:aa7:9829:0:b0:6dd:9fc6:ee38 with SMTP id q9-20020aa79829000000b006dd9fc6ee38mr5354401pfl.27.1707738675832; Mon, 12 Feb 2024 03:51:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707738675; cv=pass; d=google.com; s=arc-20160816; b=yCo/s5ZOBMXsLwrvzP3T0O3OebF0RLdPNzQnhSKiuM7qQVaq0nfp/7E8ON6+1RLU1n 4Il1W8c88dbkPoQigxBg2dCb3/nuzXFSaoh7LBWvXvE78wSHZvYbNC4z+q+I2TSK8Y2q y3YNWhh+/SDVOB7Vs13iAxTHTqj/Nnw9zMDu24jeJeZAiusoL4gpyzmG0px3HZ/zu3k4 AwvF+N+X6IWpRabFI7OCiaE8qIL6BqtRq6R8btNGBdG1M650eZIhSYADQc6gWV7SyqBq 83od54HplNh22NnhwWevbH7qWrDvOSeLJ4Z/nmZPSHtIgsW8K54jqEJPaVKz5LSUHzf5 LL4w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=8Mv9JWHVriKK/NzyCV6xFcbaYUTIbst09j3GUUfOt14=; fh=ynHHfuMvYEVsL8uM7KEBZVtawa5wX+R4q6U/qq/WTog=; b=nxVOuCbuWZMAnLNfQY0y1Aoc54LLy2f5wskKltdaZHnSflqhKUh+4d0tNO7w3ebvWc s+6K9P9jdH/1a57ZHwTHwo9o3sR67YzS7FxcG+3XVNz+KncmNtUUnb2eS0XRYUSuChVs UPCGb7kupTFBujUPWaMo3aAvJJsYjNOtoA7io5WgoMccVmWKPk1TX14CrTky9aEU5sfp QTZanjsk6YZdHfr1vE0nnatsp1bCFkvYjNM49Nc7Q4VLW/RnWpoVQKLYTXBQrHSERk7n 9yok4G1DD7zWMtYuvC4eXtieqpHO+96KTDugxEQwnr89tGbag6wyd5Jz+F80qt5HUOHL 8Dxg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="s5jm+8v/"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-61423-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61423-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCVM9Q23cQ71Fu2I4cajhYzmq+eGqLmuWj/alMqpGBHDgtwd59TH7Ii1S2SgkIe3dXOClP8z+DRXZkFtkE2Yy81w3RWLog== Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id jc3-20020a056a006c8300b006e0dd734307si1583523pfb.157.2024.02.12.03.51.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 03:51:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-61423-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="s5jm+8v/"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-61423-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61423-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 93FABB26E25 for ; Mon, 12 Feb 2024 11:26:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 17B4D39AE7; Mon, 12 Feb 2024 11:25:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s5jm+8v/" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B5FD39877 for ; Mon, 12 Feb 2024 11:25:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707737150; cv=none; b=D33gxQVtCJ09sOZn9EmzpNERudr2l3i0bahokCLUBdhIpyfza/k6ebeKu/eN9JwJ+CVPHBzP5gUdu2+6W0KvDqqH3wDaVDXlt7jHisPfQwnoQKshaD9FtzjCQ72Bfo9RAYjl8oldsmAx+TL0ZQMq9+WmV5QdVJq/OTLz2OSh4MU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707737150; c=relaxed/simple; bh=4g4oiPC3x8fy5FEvIMXnSo4ptsk7ZrRn6IXmztKqK+M=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=UpQ0hzWU09QY4t3PHDhAorDa/xFSO+Cgf3QUqI9WCEU0puztR60PbCszXFVmvQfKbbtLtkzHDp9otrbEWRUpyK4IQ0Z7ZAo7WK+UwVXkQihH08E0T/YSHSvX+/ygwSG4XJ5i5hAXw0P+EYgnK/n2udIzetoHEYjNYM9euoLFE+Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s5jm+8v/; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F9C6C43390; Mon, 12 Feb 2024 11:25:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707737150; bh=4g4oiPC3x8fy5FEvIMXnSo4ptsk7ZrRn6IXmztKqK+M=; h=From:To:Cc:Subject:Date:From; b=s5jm+8v/vxlalLNU1FTKvXIXGnrN6mDsipv8Fy7iwa6mpjlK2hr9GV+kOZq7cVuMO 6Tx3EdMCDju2jOOMkegn2lu3LqOI5VUfWGkwJFWrbYygEnzK4bRD/aWSL9SBr2Epnw XRk+7gw3fY5zpVwaCAcz+8KHdIC96XKzvJnkq5Lxe4WdfGn+JCIKk8HR3ww/YGgv9T NaBhbPcAnvdEwbw8NuwMWWEoHUl9xe7fGV55r17DsYVWWVgBHWB3I8csIdMAYLVSjk MvRgYLg1ox+8NZKRjHFfjQAbnu7Q0c894kTvW3RaMDhdRFwIBNI7bUn175UQQ2uwhK sTvhtXX0O1rAA== From: Arnd Bergmann To: Roy Pledge , Li Yang , Arnd Bergmann Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] soc: fsl: dpio: fix kcalloc() argument order Date: Mon, 12 Feb 2024 12:25:27 +0100 Message-Id: <20240212112545.1244685-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790693789636332765 X-GMAIL-MSGID: 1790693789636332765 From: Arnd Bergmann A previous bugfix added a call to kcalloc(), which starting in gcc-14 causes a harmless warning about the argument order: drivers/soc/fsl/dpio/dpio-service.c: In function 'dpaa2_io_service_enqueue_multiple_desc_fq': drivers/soc/fsl/dpio/dpio-service.c:526:29: error: 'kcalloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Werror=calloc-transposed-args] 526 | ed = kcalloc(sizeof(struct qbman_eq_desc), 32, GFP_KERNEL); | ^~~~~~ drivers/soc/fsl/dpio/dpio-service.c:526:29: note: earlier argument should specify number of elements, later size of each element Since the two are only multiplied, the order does not change the behavior, so just fix it now to shut up the compiler warning. Fixes: 5c4a5999b245 ("soc: fsl: dpio: avoid stack usage warning") Signed-off-by: Arnd Bergmann --- drivers/soc/fsl/dpio/dpio-service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/fsl/dpio/dpio-service.c b/drivers/soc/fsl/dpio/dpio-service.c index 1d2b27e3ea63..b811446e0fa5 100644 --- a/drivers/soc/fsl/dpio/dpio-service.c +++ b/drivers/soc/fsl/dpio/dpio-service.c @@ -523,7 +523,7 @@ int dpaa2_io_service_enqueue_multiple_desc_fq(struct dpaa2_io *d, struct qbman_eq_desc *ed; int i, ret; - ed = kcalloc(sizeof(struct qbman_eq_desc), 32, GFP_KERNEL); + ed = kcalloc(32, sizeof(struct qbman_eq_desc), GFP_KERNEL); if (!ed) return -ENOMEM;