From patchwork Mon Feb 12 11:15:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 199657 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp2362160dyd; Mon, 12 Feb 2024 03:15:59 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV0g71ljtu2rNqDGKtCim09elmhj0ErmtzBVDyJTOY5Pg+zOEhxNErYJ2X1pquKbvRGfjCywlqQvyh3ylUEAi6voF+18g== X-Google-Smtp-Source: AGHT+IH/8U3Xby00hdfEmOcMffS8w+kK0JVVktlH+sRM7ddjTHqojlwX7v6TWI8tzIdxI7Eo2706 X-Received: by 2002:ae9:e408:0:b0:785:c2cd:6f92 with SMTP id q8-20020ae9e408000000b00785c2cd6f92mr7588875qkc.5.1707736559506; Mon, 12 Feb 2024 03:15:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707736559; cv=pass; d=google.com; s=arc-20160816; b=t/xtkthB8i4lTHb0blx/PZPA6Ztoc41BgS93pEcLr/PJ6NdWy4SX5b9tsd+mrM9e63 CH9RVShdhgZJ7Dtl2hWhZGQO4Xbe/OhWC4CLPxdmw1YgNMDLJ0IkRPdnEiu3/AOeOLOl ZEZsZ4nPA3z+agXrkqxJs+5VAVGbc7pxUkZSB9Gyk2pc7ktCL6yaavXeE6ors+mo5FWw mZkxmHGFkN9SblX8i9x018gyIUOVbrJ3vZosWUPk4JuhawM+JmgLvcnoP7zggX42FTgu muQ8+qYkh5tft5338CBFecd+sEfASNHz0bJAd+Z0569Tpz28bpJQeXMvnyS1Quv+1AfA SZEw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=zR/judp5gAhZFdRPfAte/DWeig26+O0X3CtWDeEZI3Q=; fh=pU55cJFLhwIomEjyd9S1RxhsxhLBRLg0QfBrBuD2gBY=; b=dyvN4mRUWOoVp+jD90GK77s0FgB9vYdK5n31a2Naav8y3bq0JxIyK12yZsgL8ad2r4 XHmSz6tGxzX4b4pOaaNfrR8XNLtfEmZ0ON/zAY0NF0bpx66ClbNup0dps8NRIh8lG3oe uzPLz49PGypEOb2o80MSRP7pDh4tYOukbcW1K5ZolJu1URScUudkjf6Q1KjKEii6XU+X 8ZdygQBFFV8o+1d/ao2nchZV894rZyzIxiL/Kn8TTErars2IiyFIqjPHHK8LpMVNn4qd xe8l4EGN3NiJoIlGKKK8ZXyIPH0gQ4hNsavqHDjlwRdeaS2zDFksScX99z/5R7qpj70p 2gCQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=StBktxvF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-61403-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61403-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCW/lsaxO/aSVJsAQ8AZW1ngjedfGuC+3d6b9140qD3PMClbgmJ3yaqe/fg5d0yLaRC33iVs0ltNu2RulnOctsD+AG4Ktg== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h9-20020a05620a21c900b007858e39c462si5501017qka.636.2024.02.12.03.15.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 03:15:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-61403-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=StBktxvF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-61403-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61403-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8A0021C2230C for ; Mon, 12 Feb 2024 11:15:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 038933984A; Mon, 12 Feb 2024 11:15:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="StBktxvF" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C0E617752; Mon, 12 Feb 2024 11:15:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707736532; cv=none; b=oFH9rdnlYuzdlIGgJ3v2gm2CHWItCYxp8EA3JjqBtEZPoGKmcrP0fMhSqZksf2ZSyTT2Am/siYUBSFGDQYpPaLF7N3jwLT5CTvbwoNqeuBbuzITIYOrMVYzXZh1DrACDt0JJY+HZSLIRKLW0NjUa8TlTcODRkJoDmSwjHysJ6BI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707736532; c=relaxed/simple; bh=uo1c3yTNaSxAlcCbr/1mBVju1rFds1wly6gCrD8iPyE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=eCvOkkGnwVe0cCIkQhwsrprcfCJLrUSm7HVlM7Rd0hmVBo/3AA9G/Pro1fjUGmqGZCFpQ9Opm36pYfyFgmXItEwdx0VzxzT3ELOMF13Xx0+3X0afQOxOOKfbTQyWXnMAXazlMZg+cZXilniCcKM57XiEsjSHV3WencRX06MosMA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=StBktxvF; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24DEAC433F1; Mon, 12 Feb 2024 11:15:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707736531; bh=uo1c3yTNaSxAlcCbr/1mBVju1rFds1wly6gCrD8iPyE=; h=From:To:Cc:Subject:Date:From; b=StBktxvFHyn67q2hEjeae6pKPu/BiLUdPx1sor2wf4iT9AHW+f1dWDwwGG6ziYOBU OTINq0ur4d+Q3EkYFewMb51bq8WbVox5pM4AqvsELv7tvovwUCH7MFTZ/uy3E84tNL ufjNT6NKW3LxBvJm5hrWrH5Byh8uj7uuiMGcNjopYeul0Jfve6LiUy+xzJfq7uhXq1 I470IHTIHB+57v96b+E/l2AuezAsjKy8XJ7BCt0brn9usAvZ6tuRb0oPtDwNsSA+Tv HP6jK9k0rMBLocFRMbGf4EzfpdylmJrtcvFwOwJr/Raw+MgBNddr5z2jP/QfR3YbpP bQr0EntlBrK7g== From: Arnd Bergmann To: Pavel Machek , Lee Jones , Anjelique Melendez Cc: Arnd Bergmann , Jean Delvare , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] leds: qcom-lpg: add QCOM_PBS dependency Date: Mon, 12 Feb 2024 12:15:02 +0100 Message-Id: <20240212111526.829122-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790691570430443542 X-GMAIL-MSGID: 1790691570430443542 From: Arnd Bergmann The lpg driver fails to link now when the pbs driver is in a loadable module: x86_64-linux-ld: drivers/leds/rgb/leds-qcom-lpg.o: in function `lpg_brightness_set': leds-qcom-lpg.c:(.text+0xe7f): undefined reference to `qcom_pbs_trigger_event' x86_64-linux-ld: drivers/leds/rgb/leds-qcom-lpg.o: in function `lpg_probe': leds-qcom-lpg.c:(.text+0x16a5): undefined reference to `get_pbs_client_device' Add a dependency to avoid the broken configuration. Apparently there is still a use for lpg with pbs disabled entirely for certain chips, so allow both but not LEDS_QCOM_LPG=y with QCOM_PBS=m. Fixes: 214110175679 ("leds: rgb: leds-qcom-lpg: Add support for PPG through single SDAM") Signed-off-by: Arnd Bergmann Reviewed-by: Jean Delvare --- drivers/leds/rgb/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig index e66bd21b9852..eaeafdd5eaae 100644 --- a/drivers/leds/rgb/Kconfig +++ b/drivers/leds/rgb/Kconfig @@ -41,6 +41,7 @@ config LEDS_QCOM_LPG tristate "LED support for Qualcomm LPG" depends on OF depends on PWM + depends on QCOM_PBS || !QCOM_PBS depends on SPMI help This option enables support for the Light Pulse Generator found in a