From patchwork Sun Feb 11 15:07:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniil Dulov X-Patchwork-Id: 199466 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp1967547dyd; Sun, 11 Feb 2024 07:07:55 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUpa1lqci+I6YMQXTBi9k+NVD5s14VeoPm9N28m4L31ynH0TXnBSGg1pnHV+xMAGem/xMjwWjCsMJ2EPVxGeDIPuivkww== X-Google-Smtp-Source: AGHT+IG9PelXZ7zbcemnFsXi9gZWr5f+xdrG0dQT3DJvgMQBacwQH1dXodMNdQOzWruVvNlsH5AS X-Received: by 2002:a17:906:7c51:b0:a38:2ba9:7f8c with SMTP id g17-20020a1709067c5100b00a382ba97f8cmr3305043ejp.21.1707664074916; Sun, 11 Feb 2024 07:07:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707664074; cv=pass; d=google.com; s=arc-20160816; b=sj6Qm3Qs34R+sr3p8h6zV4vJpGu2nZZXU8Ap2/U/od+3O1k0YnmBWzK+e35I1UzfrR jPTvRX4bEdSBCuFzFwdZPoL0bSTOfXmgW6U6w1HOcLwOXdPbn4lmc/+pWTu2kCgvtVt5 bPX2CAVBCiy0ICTJvhaYMb+tzkVsp+UDEOfgFYtGo5PjIEyHhbD1mxcctwW815Jk79uN XktlEzotdaM2Ng/vGnJjj78+lS1REW4eC4IkNfwNXip2r5AGJqQRN375f0haeUG2eiOi JbaNhDaFPoM06BM5+rPUYx/aPOh+qhtOGJPoA9vJwbjqAAxwtScXR+ATAHJXgrcwdObT ZIfQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=c3wRNMzm/sqGfafZGmgEhmR78vFgWdXnK1PlkFFUH2w=; fh=B4baL6TfBIHHg027VLmHak7nyHG4FMxBR1Qc1ySshXc=; b=w6KoG/lC2yv+SlgUVoN96VSFeByt99uxKCfg1rHw+DY3PVxf6J9YhQvBfJjaHxY9I4 xCUCLjHUmpJCY/yrugQcQquJ/1agbFsN1qGfnYbAQ4mc34EjSE3JPOwUlOLJgWtEUfcM McKmqcgCBBMwLdf6bclkAj0OoXeoH0J/axxLWIdeIiWI85S8H0KOuz0A89vceH1/DhAG LWKnWfDW34r1yIV0jp9epZl/esZJCOamDQtaT4pcJBP4AnYKdAqaZekNE4lQGHVQuIoO HmEwGLvSRSgYzk8I45kTyMx7k4X5ILSF1sjNokuhWElJDafdtOwvGZ5oadsC9RM85dot pp6w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=aladdin.ru dmarc=pass fromdomain=aladdin.ru); spf=pass (google.com: domain of linux-kernel+bounces-60814-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60814-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aladdin.ru X-Forwarded-Encrypted: i=2; AJvYcCV8HlUEL+3HoAER8fTfAQHiWPA5sdbZP3VKD+2vbXenIbs/x9Xwlosef2VoQT/g6e3I4JxHENK8TvIPd0TPXD4joH/OGA== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id p5-20020a1709061b4500b00a388c129cfdsi2819501ejg.74.2024.02.11.07.07.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Feb 2024 07:07:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-60814-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=aladdin.ru dmarc=pass fromdomain=aladdin.ru); spf=pass (google.com: domain of linux-kernel+bounces-60814-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-60814-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aladdin.ru Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8663E1F21423 for ; Sun, 11 Feb 2024 15:07:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7F0675B695; Sun, 11 Feb 2024 15:07:39 +0000 (UTC) Received: from mail-out.aladdin-rd.ru (mail-out.aladdin-rd.ru [91.199.251.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FB295A4C2; Sun, 11 Feb 2024 15:07:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.199.251.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707664057; cv=none; b=GSAjdmn7Vhjn72hGixJ/G4i/ofE7F4giw38UhF9cQZfn1nMA+III3jkZqYpjzvBC9axC1B2Wc1h7FOZ4amBn4YhvCUtC0jShA/XQKaio3zVMZBngj6FkFN2VkvNbpNzo3igclJZGha+6V4/PofVORFB/xlt4WRb+yRTUndLFa3I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707664057; c=relaxed/simple; bh=S+ZcsTEYVGxi18jHqo41yCn7PEXa3hnMJnf6e88HqS0=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=KlkLFSXgRkq5GMqdMA0qhslThIiLtZB9d51Cv3xA/O5L7ylP8GPDMfl3Nm1hD4xFZMeDcGgS6RQwaGuuMwRj0BJF/jyNAlIL6U8QsyW5ZB+y0E53aRJTU056dPuY391yw0imic33qX29Fx5e9dwlm+U4p/ImE6ud8H637jlJjjE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=aladdin.ru; spf=pass smtp.mailfrom=aladdin.ru; arc=none smtp.client-ip=91.199.251.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=aladdin.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aladdin.ru From: Daniil Dulov To: Mike Isely CC: Daniil Dulov , Mauro Carvalho Chehab , , , Subject: [PATCH] media: pvrusb2: remove redundant NULL check Date: Sun, 11 Feb 2024 07:07:25 -0800 Message-ID: <20240211150725.3769-1-d.dulov@aladdin.ru> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: EXCH-2016-01.aladdin.ru (192.168.1.101) To EXCH-2016-01.aladdin.ru (192.168.1.101) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790615565235257496 X-GMAIL-MSGID: 1790615565235257496 Pointer dip->stream cannot be NULL due to a shift, thus remove redundant NULL check. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: c74e0062684b ("V4L/DVB (5059): Pvrusb2: Be smarter about mode restoration") Signed-off-by: Daniil Dulov --- drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c index 9657c1883311..c872868becbd 100644 --- a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c +++ b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c @@ -1202,11 +1202,6 @@ static void pvr2_v4l2_dev_init(struct pvr2_v4l2_dev *dip, dip->minor_type = pvr2_v4l_type_video; nr_ptr = video_nr; caps |= V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_AUDIO; - if (!dip->stream) { - pr_err(KBUILD_MODNAME - ": Failed to set up pvrusb2 v4l video dev due to missing stream instance\n"); - return; - } break; case VFL_TYPE_VBI: dip->config = pvr2_config_vbi;