From patchwork Fri Feb 9 10:28:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 198809 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp756187dyd; Fri, 9 Feb 2024 02:28:53 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVlHGY6Cp0DU+zMRuJ5rZFDRdzr8l60MemWtYfIG1dq9qFmDSjpgkzAFFXJAPKljnHVAvaAq8hlMK5EA4EnJhoIzufkcw== X-Google-Smtp-Source: AGHT+IHMb+v2Fz/rG9DFiIbSyoqZ9cKpv789MfPI/zSbjV8oAB0LVaBWSBx6qsAldLBGKrATvYhW X-Received: by 2002:a05:622a:1483:b0:42b:f3ea:8974 with SMTP id t3-20020a05622a148300b0042bf3ea8974mr1297205qtx.36.1707474533013; Fri, 09 Feb 2024 02:28:53 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707474533; cv=pass; d=google.com; s=arc-20160816; b=ibHHiN6w6LN/J38vEA+8vxrskTXzDsjfmQCdAIPZhghc0fO5r5Jbxb177fM34pc0dK WJ+BJyWs8tOfSb8J/OoG2abZxAyCW/+zKwaDrAA3KcprHAwcBqv5Qw06Y8DquLOOdJ6Z +EakqA8jZnZQz55xUvxDKF2kRNEEdmGJJwsbHfAylSSpELvlJOdt/EA4oM94hUkz39NF zmmSN2AuSVxIaUj3iYBY8ipNMdFv1l0EJ851f1lUlznLjVlWCVG1i+PSGmVx5DI411p8 IRJ3himbzmeqckQBcinO18gE95Pp0HelTr83KXPMciZmxX/w1ImDxK0ATO5WGlbPvh3o 2W3A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:errors-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :subject:cc:to:from:date:dkim-signature:dkim-signature :dkim-signature:dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=JyJWnIWLy5BGJgZGhgSFyN7IMIYCJ8cwQum5on/2AK8=; fh=oPm/sMJpcYcY7R4f2yUfjQgzHDnWE40zxneVVsIS88w=; b=UgR6apXEkeu/neLaPjKjS/Ypelj93wWuynFwHWikR+tJhs2qeUw20OK3EUMRQBlWmZ Uvj4u/IfJ6UcW18bveg2RR3knUYi4UgJ+85Sqpt2wXZNmmC3WHaOZciST4/mhcomMpls QtPCeyp80Ym276Islxljdoq7SPHO1BmMRiX0AHsmKWcw2pNiYcws1SCtvMTRygrqy0sY 2OKV3CM/sm0R2zsqVt/HTfE0SxPBcGPd7wClerula1RZ3qEeSQxTyLxQoVou6/FdH8cz LRmdbq1Olb4A+D5dHqcDLhAgpDBQzGh4bKDf/xPWbe0pb7tXVrSNgIpzPGt16u5w7Fmx 923g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=neutral (body hash did not verify) header.i=@suse.de header.s=susede2_rsa header.b=Rs0i3I1e; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=neutral (body hash did not verify) header.i=@suse.de header.s=susede2_rsa header.b=Rs0i3I1e; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=suse.de X-Forwarded-Encrypted: i=2; AJvYcCWFf8OFTCZ/yej4gy+X/tPd85jqOvK8jwvqyGL50mURUrPITQMQW1rV+8YEzLv8b5ebSA1xDb9q0e04SDU09KQrnTuWNw== Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id t1-20020ac85881000000b0042c24d979c6si1562656qta.352.2024.02.09.02.28.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 02:28:52 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@suse.de header.s=susede2_rsa header.b=Rs0i3I1e; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=neutral (body hash did not verify) header.i=@suse.de header.s=susede2_rsa header.b=Rs0i3I1e; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B3FB23858404 for ; Fri, 9 Feb 2024 10:28:52 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id E128A3858C35 for ; Fri, 9 Feb 2024 10:28:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E128A3858C35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E128A3858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707474486; cv=none; b=oQCTdS6rOjG1bdf3Ht+GhIkJZ+Rioqy6D5U8ozcFkv/WslfcnlKtRh8oMFQc+U1YGkUHhX5R+fmUbk6i8Z1sOiuNn0a9M01FWZjuXeLWn6Pl+TfcM7OLuWsZxklpvrW+ntWTSNyJL6q6agU7bFes/NzT5c0NJrISozAceaMRvgc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707474486; c=relaxed/simple; bh=j2R6mPXUGAgGO7Aux76CnpMSzeyIv1AeCDRA0NKuWgI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=iMaZBOvHCHX5d4sHmxV+l3F/PUKVBl8eL9D+jHuY8iErNV+IGVdyxrOiuRbveKhGlzpCpmYDTR3KBt9DARlbGZo8q5lEbregTeqW0VBFsXVzqJ3uGzQVuik50PyvdQUmT/1Tnyk+2fCasjRis1oh156mzdcmdbHksjWRr5xHn5Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BA8BD1F7F9; Fri, 9 Feb 2024 10:28:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707474481; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=aptC2yO+ytCAt8xCgefkoIwA/CXvv5X4j34bK+N+YIc=; b=Rs0i3I1e4sTWMEg43uY6CUqSG4pU9w719WKh6y7YPhm4jggL3wu+6/OKSO2qY6uUYTmKQO Mq7P2F2RgwCRJOdO2Z26THozaIcE/QvSVB3QTwUzlLw9CrP0aq29NPmesuzQMoDVAN0kyz 5CWSgihnj+lvimH4MZE9LTLInURFmaM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707474481; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=aptC2yO+ytCAt8xCgefkoIwA/CXvv5X4j34bK+N+YIc=; b=4NzIWZyrBIxCdS0FdMkZIzvhiu4XQOeW7KRcibR309zghz96qBo9EJO9zAcoy1W+GMOYcw FAINphfjX4jwZ2BQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707474481; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=aptC2yO+ytCAt8xCgefkoIwA/CXvv5X4j34bK+N+YIc=; b=Rs0i3I1e4sTWMEg43uY6CUqSG4pU9w719WKh6y7YPhm4jggL3wu+6/OKSO2qY6uUYTmKQO Mq7P2F2RgwCRJOdO2Z26THozaIcE/QvSVB3QTwUzlLw9CrP0aq29NPmesuzQMoDVAN0kyz 5CWSgihnj+lvimH4MZE9LTLInURFmaM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707474481; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=aptC2yO+ytCAt8xCgefkoIwA/CXvv5X4j34bK+N+YIc=; b=4NzIWZyrBIxCdS0FdMkZIzvhiu4XQOeW7KRcibR309zghz96qBo9EJO9zAcoy1W+GMOYcw FAINphfjX4jwZ2BQ== Date: Fri, 9 Feb 2024 11:28:01 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: jeffreyalaw@gmail.com Subject: [PATCH 1/3][RFC] Add MEM_BASE MIME-Version: 1.0 Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-0.60 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; MISSING_MID(2.50)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[gmail.com]; BAYES_HAM(-3.00)[100.00%] X-Spam-Level: X-Spam-Score: -0.60 X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, DKIM_INVALID, DKIM_SIGNED, GIT_PATCH_0, KAM_DMARC_STATUS, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Message-Id: <20240209102852.B3FB23858404@sourceware.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790416816219007337 X-GMAIL-MSGID: 1790416816219007337 The following adds a 'base' member to the RTL memory attributes, recording the base value as base_alias_check expects and currently find_base_{value,term} compute. It is expected to either contain a SYMBOL_REF or a special ADDRESS, see base_alias_check for reference. With this patch nothing sets MEM_BASE but RTL alias analysis would prefer any recorded MEM_BASE over dynamically computing it. * rtl.h (mem_attrs::base): New member. (MEM_BASE): New. * emit-rtl.h (set_mem_base): Declare. * emit-rtl.cc (mem_attrs_eq_p): Handle MEM_BASE. (mem_attrs::mem_attrs): Initialize it. (set_mem_attributes_minus_bitpos): Preserve it. (set_mem_base): New function. * alias.cc (true_dependence_1): Prefer MEM_BASE over using find_base_term. (write_dependence_p): Likewise. (may_alias_p): Likewise. * print-rtl.cc (rtx_writer::print_rtx): Print MEM_BASE. --- gcc/alias.cc | 26 ++++++++++++++++++-------- gcc/emit-rtl.cc | 18 +++++++++++++++++- gcc/emit-rtl.h | 3 +++ gcc/print-rtl.cc | 6 ++++++ gcc/rtl.h | 7 +++++++ 5 files changed, 51 insertions(+), 9 deletions(-) diff --git a/gcc/alias.cc b/gcc/alias.cc index 808e2095d9b..48633aff699 100644 --- a/gcc/alias.cc +++ b/gcc/alias.cc @@ -2934,7 +2934,6 @@ true_dependence_1 (const_rtx mem, machine_mode mem_mode, rtx mem_addr, const_rtx x, rtx x_addr, bool mem_canonicalized) { rtx true_mem_addr; - rtx base; int ret; gcc_checking_assert (mem_canonicalized ? (mem_addr != NULL_RTX) @@ -2981,13 +2980,17 @@ true_dependence_1 (const_rtx mem, machine_mode mem_mode, rtx mem_addr, if (MEM_ADDR_SPACE (mem) != MEM_ADDR_SPACE (x)) return true; - base = find_base_term (x_addr); + rtx base = MEM_BASE (x); + if (!base) + base = find_base_term (x_addr); if (base && (GET_CODE (base) == LABEL_REF || (GET_CODE (base) == SYMBOL_REF && CONSTANT_POOL_ADDRESS_P (base)))) return false; - rtx mem_base = find_base_term (true_mem_addr); + rtx mem_base = MEM_BASE (mem); + if (!mem_base) + mem_base = find_base_term (true_mem_addr); if (! base_alias_check (x_addr, base, true_mem_addr, mem_base, GET_MODE (x), mem_mode)) return false; @@ -3045,7 +3048,6 @@ write_dependence_p (const_rtx mem, { rtx mem_addr; rtx true_mem_addr, true_x_addr; - rtx base; int ret; gcc_checking_assert (x_canonicalized @@ -3088,7 +3090,9 @@ write_dependence_p (const_rtx mem, if (MEM_ADDR_SPACE (mem) != MEM_ADDR_SPACE (x)) return true; - base = find_base_term (true_mem_addr); + rtx base = MEM_BASE (mem); + if (!base) + base = find_base_term (true_mem_addr); if (! writep && base && (GET_CODE (base) == LABEL_REF @@ -3096,7 +3100,9 @@ write_dependence_p (const_rtx mem, && CONSTANT_POOL_ADDRESS_P (base)))) return false; - rtx x_base = find_base_term (true_x_addr); + rtx x_base = MEM_BASE (x); + if (!x_base) + x_base = find_base_term (true_x_addr); if (! base_alias_check (true_x_addr, x_base, true_mem_addr, base, GET_MODE (x), GET_MODE (mem))) return false; @@ -3211,8 +3217,12 @@ may_alias_p (const_rtx mem, const_rtx x) if (MEM_ADDR_SPACE (mem) != MEM_ADDR_SPACE (x)) return true; - rtx x_base = find_base_term (x_addr); - rtx mem_base = find_base_term (mem_addr); + rtx x_base = MEM_BASE (x); + if (!x_base) + x_base = find_base_term (x_addr); + rtx mem_base = MEM_BASE (mem); + if (!mem_base) + mem_base = find_base_term (mem_addr); if (! base_alias_check (x_addr, x_base, mem_addr, mem_base, GET_MODE (x), GET_MODE (mem_addr))) return false; diff --git a/gcc/emit-rtl.cc b/gcc/emit-rtl.cc index 1856fa4884f..1cf238d9571 100644 --- a/gcc/emit-rtl.cc +++ b/gcc/emit-rtl.cc @@ -368,7 +368,10 @@ mem_attrs_eq_p (const class mem_attrs *p, const class mem_attrs *q) && p->addrspace == q->addrspace && (p->expr == q->expr || (p->expr != NULL_TREE && q->expr != NULL_TREE - && operand_equal_p (p->expr, q->expr, 0)))); + && operand_equal_p (p->expr, q->expr, 0))) + && (p->base == q->base + || (p->base != NULL_RTX && q->base != NULL_RTX + && rtx_equal_p (p->base, q->base)))); } /* Set MEM's memory attributes so that they are the same as ATTRS. */ @@ -1828,6 +1831,7 @@ operand_subword_force (rtx op, poly_uint64 offset, machine_mode mode) mem_attrs::mem_attrs () : expr (NULL_TREE), + base (NULL_RTX), offset (0), size (0), alias (0), @@ -1985,6 +1989,7 @@ set_mem_attributes_minus_bitpos (rtx ref, tree t, int objectp, /* ??? Can this ever happen? Calling this routine on a MEM that already carries memory attributes should probably be invalid. */ attrs.expr = refattrs->expr; + attrs.base = refattrs->base; attrs.offset_known_p = refattrs->offset_known_p; attrs.offset = refattrs->offset; attrs.size_known_p = refattrs->size_known_p; @@ -1997,6 +2002,7 @@ set_mem_attributes_minus_bitpos (rtx ref, tree t, int objectp, { defattrs = mode_mem_attrs[(int) GET_MODE (ref)]; gcc_assert (!defattrs->expr); + gcc_assert (!defattrs->base); gcc_assert (!defattrs->offset_known_p); /* Respect mode size. */ @@ -2264,6 +2270,16 @@ clear_mem_size (rtx mem) attrs.size_known_p = false; set_mem_attrs (mem, &attrs); } + +/* Set the BASE of MEM. */ + +void +set_mem_base (rtx mem, rtx base) +{ + mem_attrs attrs (*get_mem_attrs (mem)); + attrs.base = base; + set_mem_attrs (mem, &attrs); +} /* Return a memory reference like MEMREF, but with its mode changed to MODE and its address changed to ADDR. (VOIDmode means don't change the mode. diff --git a/gcc/emit-rtl.h b/gcc/emit-rtl.h index 34f44cb2990..d7c307c9da0 100644 --- a/gcc/emit-rtl.h +++ b/gcc/emit-rtl.h @@ -361,6 +361,9 @@ extern void set_mem_addr_space (rtx, addr_space_t); /* Set the expr for MEM to EXPR. */ extern void set_mem_expr (rtx, tree); +/* Set the base for MEM to BASE. */ +extern void set_mem_base (rtx, rtx); + /* Set the offset for MEM to OFFSET. */ extern void set_mem_offset (rtx, poly_int64); diff --git a/gcc/print-rtl.cc b/gcc/print-rtl.cc index ecb689f56a9..3d7ea8dd59e 100644 --- a/gcc/print-rtl.cc +++ b/gcc/print-rtl.cc @@ -974,6 +974,12 @@ rtx_writer::print_rtx (const_rtx in_rtx) if (!ADDR_SPACE_GENERIC_P (MEM_ADDR_SPACE (in_rtx))) fprintf (m_outfile, " AS%u", MEM_ADDR_SPACE (in_rtx)); + if (MEM_BASE (in_rtx)) + { + fputc (' ', m_outfile); + print_rtx (MEM_BASE (in_rtx)); + } + fputc (']', m_outfile); break; diff --git a/gcc/rtl.h b/gcc/rtl.h index 2370d608161..c84334cb945 100644 --- a/gcc/rtl.h +++ b/gcc/rtl.h @@ -159,6 +159,10 @@ public: (In other words, the MEM might access only part of the object.) */ tree expr; + /* A unique base this MEM accesses. This can be a SYMBOL_REF or + an ADDRESS RTX. */ + rtx base; + /* The offset of the memory reference from the start of EXPR. Only valid if OFFSET_KNOWN_P. */ poly_int64 offset; @@ -2643,6 +2647,9 @@ do { \ refer to part of a DECL. It may also be a COMPONENT_REF. */ #define MEM_EXPR(RTX) (get_mem_attrs (RTX)->expr) +/* For a MEM rtx, the ADDRESS or SYMBOL_REF it is based on. */ +#define MEM_BASE(RTX) (get_mem_attrs (RTX)->base) + /* For a MEM rtx, true if its MEM_OFFSET is known. */ #define MEM_OFFSET_KNOWN_P(RTX) (get_mem_attrs (RTX)->offset_known_p) From patchwork Fri Feb 9 10:28:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 198810 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp756283dyd; Fri, 9 Feb 2024 02:29:07 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU7SLlmhqJ/nN9EmHs+Vap3PpMflahZuGHO58LstvRp1ZaL6ylEteYLw+OuHsI7h8TCEN8b6auHwV4mgOqdG2gvj+oabA== X-Google-Smtp-Source: AGHT+IEWZkDiRlo0BsD5Ab0BTmFakDqzYvijCGVX48xik9PMqIbNMY2M8iRInbSjinTkylrChQyK X-Received: by 2002:ac8:57c2:0:b0:42c:3e82:6aa1 with SMTP id w2-20020ac857c2000000b0042c3e826aa1mr1426763qta.46.1707474546916; Fri, 09 Feb 2024 02:29:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707474546; cv=pass; d=google.com; s=arc-20160816; b=KDcWMSYlHe1wAtvwvt6v+UxjYchWZ1Yao7cvWLgG+BsB+Ouhm12lo83HixJeC0+8xE biAaWwyMCNu2zIBTAJSFWR2EEPL4lwhmQPbiLgiFFiwHeW35FW6hCpdRcFokQM9OdrKb DnoDsnLVUrhkZo2SFGSvO3yQo8BCh5W+7+mpyYD2nXGGXXdEUAqHpMhC+1mfkg8D0YKq B16PL9OSsiN3gghnR8yO+LnQXfwdxUlpQIwZ8jV1dBnjP+r6yw4uC1Rf1dtNgIyIFe2F aabtW6Oqafftv3r9la9rhBlgMn6j3InhroBgLeqMQkv9Hp9Rq8mZJhjSUWIr+Y1xM+Aw t2+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:errors-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :subject:cc:to:from:date:dkim-signature:dkim-signature :dkim-signature:dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=L3G4JdH214dJPsL7l5xBTE5RJKbw/fWjws/YmP6Co0g=; fh=7UMugt2oBO6VkFIJaTUl6f04uKD0s6L8IJnf/ZiHVyw=; b=k4qI9Ki44CqlKhqbmaYBCuysJ7SBlZ4oDN8vmhcfRs0mMq9zbIHEd8k0LS8eZXVSNP VGIKdz9GJzer/utmQBIwVLjelQgv6RlqdO+ff6s6GZuQKfmsygANnC0iMYR8hXhclmHs ld0GBt1TQ0SyFYv/TJ2lf7FSQcfd5JYUoaE93shWAjYvqllJJ0owDPng6QTRmZflS8oO hnThzI1EL24yLuCgJo03u/KcyTUx7oCSnYFhsYnFdRgjwsOvfRV6uKOv32xst4HaNscf InxiyyaUO4Ivt6qsqzB0THhiBrhkTw3wKJP1VXgSETz1usQBxTdQs6xzbr6K1pS5vZ/P lE3w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=zwCV1JAY; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QvreIRyU; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de X-Forwarded-Encrypted: i=2; AJvYcCUcHvxoFHaeMMGjClTNsxGxwHQ9lVhKdrng9oqGPjthxQDtyej/vyiR/kovbzFejsjP6G9ThFwbYLmMrntVnBPTv83VhQ== Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id n3-20020a05622a11c300b00429d470ea36si1547927qtk.592.2024.02.09.02.29.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 02:29:06 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=zwCV1JAY; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QvreIRyU; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9AD293858404 for ; Fri, 9 Feb 2024 10:29:06 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 1BCB03858417 for ; Fri, 9 Feb 2024 10:28:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1BCB03858417 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1BCB03858417 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707474498; cv=none; b=WQNGVs2paZXsU54upt6/P+pFGYPqeRsmEiaKJxBx/Pm0dqs306QzNIXSVQjCsqH9OXk/cOFtq5s77EALlNqIKCDEN0Y7GnWglNbKVsBhzHDcHTkjLv3J+x2hMxS0LWUXaQPiOXleSMgFsZNf0yluVjGLXMMmL8r2pp+CUBgfDwE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707474498; c=relaxed/simple; bh=uyQLz5PhoYbPhv417QmG7tjNY9PpUl0i3xGfz3iQHbE=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=D4CQFhXOYZ6PxuVuOU2VZAmtP5fvXpmVfyS4pYLPBOyaZ0ENZEYmi/BI2QkXuHVLgbpt2VPkPTFTF0MlzMO8VgILW3qedrYuu00dZHn2zdIa7k7NMLObgKeBNwqWdVTAIEQG4ZcEtSu6aHU9/jVDzcZHCZOXkDQRn+vPtfuq4Ow= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0549F21FB1; Fri, 9 Feb 2024 10:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707474496; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=L3G4JdH214dJPsL7l5xBTE5RJKbw/fWjws/YmP6Co0g=; b=zwCV1JAYf7Le7CfQ2x5gE486en3L9I/2rDCouvUhWRA1Jbgpn5Uvt1khYD+7NIiQ4crgf1 f5x+cXnMsYuuABRFOr5f2QLcbjE5Hatz6aTOHWdRbr//GcoCfnnSu4fXgDyfmy700GWHOS v4S9uTwk8jSrMrGnSv1CZv4S7ZnVgLY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707474496; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=L3G4JdH214dJPsL7l5xBTE5RJKbw/fWjws/YmP6Co0g=; b=ouXhGEZTHPOK52M7Oset1213BLZvMdbKZzkOkYbJq9Ws2tdhnV5l2n1Rrwg3xv8EE/GFeh VauuUK8EXULTpoCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707474494; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=L3G4JdH214dJPsL7l5xBTE5RJKbw/fWjws/YmP6Co0g=; b=QvreIRyU/S7wztic6gPgUWF9+7btAoVtmezJ22QTTRu1RJbWYShxHz35LiReB5Y9WDqP2E 689Tyq2p0xXrtA5vspTB/Gn2z0T6/RPs+yDgoD35nhAbdsB/bF8BK6QarrjpoL12sYRID5 Tll+HRBHZXphL9MOSmX0LV0MCcxfRrw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707474494; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=L3G4JdH214dJPsL7l5xBTE5RJKbw/fWjws/YmP6Co0g=; b=ECQDWpE/jzTFbz/SVRrGsPSA7D11GEqw68Kipjf4hN5/309CRUPyFBRVCBUuODp2Z5cf1q i//Ns+4GWAnKcjAA== Date: Fri, 9 Feb 2024 11:28:13 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: jeffreyalaw@gmail.com Subject: [PATCH 2/3] Remove get_reg_base_value MIME-Version: 1.0 Authentication-Results: smtp-out1.suse.de; none X-Spam-Score: 1.24 X-Spamd-Result: default: False [1.24 / 50.00]; TO_DN_NONE(0.00)[]; NEURAL_HAM_SHORT(-0.16)[-0.802]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-0.00)[12.15%]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; MISSING_MID(2.50)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[sel-sched.cc:url]; FUZZY_BLOCKED(0.00)[rspamd.com]; FREEMAIL_CC(0.00)[gmail.com] X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Message-Id: <20240209102906.9AD293858404@sourceware.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790416830352464926 X-GMAIL-MSGID: 1790416830352464926 This makes recorded reg base values private to alias.cc, its computation should go away but find_base_term can be used to cross-check that we don't regress when only having MEM_BASE eventually. Selective scheduling wouldn't need to avoid renaming regs with a base value anymore, so this removes this only outside use. * alias.cc (get_reg_base_value): Make static. * rtl.h (get_reg_base_value): Remove. * sel-sched.cc (init_regs_for_mode): Do not worry about REG_BASE_VALUE when recording regs for renaming. --- gcc/alias.cc | 2 +- gcc/rtl.h | 1 - gcc/sel-sched.cc | 4 ++++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/gcc/alias.cc b/gcc/alias.cc index 48633aff699..541994c5047 100644 --- a/gcc/alias.cc +++ b/gcc/alias.cc @@ -1656,7 +1656,7 @@ record_set (rtx dest, const_rtx set, void *data ATTRIBUTE_UNUSED) /* Return REG_BASE_VALUE for REGNO. Selective scheduler uses this to avoid using hard registers with non-null REG_BASE_VALUE for renaming. */ -rtx +static rtx get_reg_base_value (unsigned int regno) { return (*reg_base_value)[regno]; diff --git a/gcc/rtl.h b/gcc/rtl.h index c84334cb945..3fcaaec49e4 100644 --- a/gcc/rtl.h +++ b/gcc/rtl.h @@ -4496,7 +4496,6 @@ extern bool may_be_sp_based_p (rtx); extern rtx gen_hard_reg_clobber (machine_mode, unsigned int); extern rtx get_reg_known_value (unsigned int); extern bool get_reg_known_equiv_p (unsigned int); -extern rtx get_reg_base_value (unsigned int); extern rtx extract_mem_from_operand (rtx); #ifdef STACK_REGS diff --git a/gcc/sel-sched.cc b/gcc/sel-sched.cc index 17b71127960..77ba100023d 100644 --- a/gcc/sel-sched.cc +++ b/gcc/sel-sched.cc @@ -1082,9 +1082,13 @@ init_regs_for_mode (machine_mode mode) /* Can't use regs which aren't saved by the prologue. */ || !TEST_HARD_REG_BIT (sel_hrd.regs_ever_used, cur_reg + i) + /* It's fine to elide this since REG_BASE_VALUE will go away + and the info is in the MEMs itself. */ +#if 0 /* Can't use regs with non-null REG_BASE_VALUE, because adjusting it affects aliasing globally and invalidates all AV sets. */ || get_reg_base_value (cur_reg + i) +#endif #ifdef LEAF_REGISTERS /* We can't use a non-leaf register if we're in a leaf function. */ From patchwork Fri Feb 9 10:28:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 198811 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp756640dyd; Fri, 9 Feb 2024 02:30:00 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWeBZr7DQCKZ4faIcpgao8dWPftFgbceZ/WnNQi+VLj20gZpxh2gNoHFxCVSNlQ5NU0E4p7Uyxr7KLF8sxNeBABS2RGaA== X-Google-Smtp-Source: AGHT+IG5Dz6GFdvvB112gIlaBqQTYY39SpN/+8NEa3T+clxY/Papob3TZapI6bBSjy4xNpMrDpyA X-Received: by 2002:a05:620a:5681:b0:785:3887:de18 with SMTP id wg1-20020a05620a568100b007853887de18mr1113669qkn.65.1707474600695; Fri, 09 Feb 2024 02:30:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707474600; cv=pass; d=google.com; s=arc-20160816; b=BIogWmAGCuCc2IKPyOavUnYon7yw4Fbcsqft5VpPan5iqpH6qLWSa4jAXart4u8A/C hSRTB9p/DvzS5Jlw/sf1ctzz60qZabeZxSmpSlls+LlLMMNPMSbu5XgsMCzIj0S9Ha2I SWodtKnDCm7Ata9GJvFAz2rzaPn2VL6VLaSfjSpPJro4AeY93hsR80XclKQ70uyKg9y/ 5d3N6VZHeat9jLHNufqQG0N/TdRVPtyPzxweMzc76IJLRVbGfvT7USEJVDJ7HeVE1Wid 2IM7iVGEdaBvGI7e/X6WV7iqEIVEj1Ms9LvvJy7vJtpbHHrs/TobjcTeEzY70QHD2kOV 5L6g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:errors-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :subject:cc:to:from:date:dkim-signature:dkim-signature :dkim-signature:dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=ZEqoCcxpcR72wj4Eu6zgmDpej9jGH4DlqVWqihg6X2o=; fh=ZGuEvoW8f70Srmu57ROclXZCaoeN6D6cA0dGS0WqzdM=; b=gO4nnr+Rj2ehaX8nZPRTEi5Q5WI+QSnCbaKcZSzdTohmFMrfl4EtLr6swvSPR70JlA M2NWzXjgsmW4vOcGLSTIFt5uGSicFXW2Fcsecjz0s8KNb1AmsWEdYzmFoxP7btDZdr0M e5eUTmB97z4cO67404vneT/qoPXECKQZdge/qd210KBssl9tibG+c0urXwCpX7+f/kfD 9MRy9wO5xXOma1giC9XsKF2bARepTQFq/T0vwwS+cUhjG+eQmrRebw0LuxsvIzQLcKE3 0NoYzde8luVVv9l+qmvx3oWyHkPdfjl0t3jwxymp2EIleYrsK6ox6OCnybdFaLwwEzdA 4Z/A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=GeOfCGNB; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=GeOfCGNB; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de X-Forwarded-Encrypted: i=2; AJvYcCXLSnVgdVbxBcJfJ5HuByTM58GZakCUjf/No2RGEW743HqLjVEWUjD3j9IcFXISDi9byaRRIFg7gFAHAElZVJcwNy2mzA== Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id l4-20020a05620a210400b0078405cec4fcsi1621872qkl.605.2024.02.09.02.30.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 02:30:00 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=GeOfCGNB; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=GeOfCGNB; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 69E0D385829A for ; Fri, 9 Feb 2024 10:30:00 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 54B853858C35 for ; Fri, 9 Feb 2024 10:28:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 54B853858C35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 54B853858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707474517; cv=none; b=YqmHMVAGWtqiYEs/1erUpT+MCD0Le7buudNQFaYSNgwoQIeEO2GKhqfli93unmU8Nj0wVhSAIVXDf8PiextOY/terahdFWj+nfMZshGZBPdJRhb1jpmH6SASoCGreX3D73SOVMr8Hr9q9BB8bog+Uqqm+q6Ibut2fIIjyvfm4q0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707474517; c=relaxed/simple; bh=OqKbkkIddyG9ejXIB2GrKNZsbNd5lQoTXrrKP5J33XQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=E8mnl+0Fp9LCqCG9rfpx7DKqXMy06xkwALTiklZjFDcwr/v6G7147rVLh3HBZXyT74HlKoeKI4DMhQzv/jDk17a8ay1Vi1ApSHEHRdAluJUbmGcHB/VkoQddvK2QEaX8LbOumAgKxeNBNMP3mNEHWzQQtwpV/9m9Nc5a2hU1sA4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 45DF91F7F9; Fri, 9 Feb 2024 10:28:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707474514; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=ZEqoCcxpcR72wj4Eu6zgmDpej9jGH4DlqVWqihg6X2o=; b=GeOfCGNB44Dz3mrVWCmgzNNtJ2vM2DIhGXYcoHrw9g+D5JCd9eh3iuv8dsjxsKpRyEjGaE C/DDbK/w9NojFTEbhWuqZAisXg9MNNcKcWA8QtKsBcF5QnXG1wUFycMBYFr8lOr1t+CVQe dHrPCNalilaxot9Knsm6Fh6qMe6Rkxs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707474514; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=ZEqoCcxpcR72wj4Eu6zgmDpej9jGH4DlqVWqihg6X2o=; b=JFVH+Ot7elzlvmX1HIM2sz0LNXsy5SkWrUBWspmJb5jw0TBz22cts2i3llEqHGJilWpT61 +Xy5XcgZz2+RkhDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707474514; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=ZEqoCcxpcR72wj4Eu6zgmDpej9jGH4DlqVWqihg6X2o=; b=GeOfCGNB44Dz3mrVWCmgzNNtJ2vM2DIhGXYcoHrw9g+D5JCd9eh3iuv8dsjxsKpRyEjGaE C/DDbK/w9NojFTEbhWuqZAisXg9MNNcKcWA8QtKsBcF5QnXG1wUFycMBYFr8lOr1t+CVQe dHrPCNalilaxot9Knsm6Fh6qMe6Rkxs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707474514; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=ZEqoCcxpcR72wj4Eu6zgmDpej9jGH4DlqVWqihg6X2o=; b=JFVH+Ot7elzlvmX1HIM2sz0LNXsy5SkWrUBWspmJb5jw0TBz22cts2i3llEqHGJilWpT61 +Xy5XcgZz2+RkhDA== Date: Fri, 9 Feb 2024 11:28:34 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: jeffreyalaw@gmail.com Subject: [PATCH 3/3][RFC] Initial MEM_BASE population MIME-Version: 1.0 Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [2.40 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; MISSING_MID(2.50)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[gmail.com]; BAYES_HAM(-0.00)[17.63%] X-Spam-Score: 2.40 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Message-Id: <20240209103000.69E0D385829A@sourceware.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790416886704876064 X-GMAIL-MSGID: 1790416886704876064 The following attempts to set a MEM_BASE from set_mem_attributes_minus_bitpos which is often first called on the expanded base of a complicated memory reference. For now simply preserve a SYMBOL_REF (fancy unwrapping to be implemented). The commented code would transfer some points-to info. * emit-rtl.cc (set_mem_attributes_minus_bitpos): If ref is suitable as base, record it. --- gcc/emit-rtl.cc | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/gcc/emit-rtl.cc b/gcc/emit-rtl.cc index 1cf238d9571..3fb52a87e08 100644 --- a/gcc/emit-rtl.cc +++ b/gcc/emit-rtl.cc @@ -2027,6 +2027,12 @@ set_mem_attributes_minus_bitpos (rtx ref, tree t, int objectp, if (objectp || TREE_CODE (t) == INDIRECT_REF) attrs.align = MAX (attrs.align, TYPE_ALIGN (type)); + /* We usually expand the base of a complicated ref first, so record any + base value we can determine. ??? Probably should use a simplified + find_base_value here to unwrap a contained SYMBOL_REF. */ + if (GET_CODE (ref) == SYMBOL_REF) + attrs.base = copy_rtx (ref); + /* If the size is known, we can set that. */ tree new_size = TYPE_SIZE_UNIT (type); @@ -2074,6 +2080,24 @@ set_mem_attributes_minus_bitpos (rtx ref, tree t, int objectp, 0)))); else as = TYPE_ADDR_SPACE (TREE_TYPE (base)); + +#if 0 + /* Set the base RTX based on points-to info. */ + if (!attrs.base + && (TREE_CODE (base) == MEM_REF + || TREE_CODE (base) == TARGET_MEM_REF) + && TREE_CODE (TREE_OPERAND (base, 0)) == SSA_NAME + && SSA_NAME_PTR_INFO (TREE_OPERAND (base, 0))) + { + auto pt = &SSA_NAME_PTR_INFO (TREE_OPERAND (base, 0))->pt; + if (pt->nonlocal + && !pt->anything + && !pt->escaped + && !pt->ipa_escaped + && bitmap_empty_p (pt->vars)) + attrs.base = arg_base_value; + } +#endif } /* If this expression uses it's parent's alias set, mark it such