From patchwork Thu Feb 8 18:42:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 198598 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp472818dyd; Thu, 8 Feb 2024 13:50:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IHw8KIoUxzHPqru0pt937nyeVuLajF7gsb6ABSFqsoHvYmzEB67BYxaRta8CsiLW36p1RCZ X-Received: by 2002:a05:6a20:c890:b0:19e:99ee:8618 with SMTP id hb16-20020a056a20c89000b0019e99ee8618mr971963pzb.15.1707429051990; Thu, 08 Feb 2024 13:50:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707429051; cv=pass; d=google.com; s=arc-20160816; b=e1o0sf0EZ6bOLI4akDmhnFec0YqRLhk4ZV7qX9F72WkBn5AiVrd7l1+1DnUH4et0/g MQ7sZ2uVkUdRc2Yy0mUjGHXsri3BFQlIZfC8s0alPFES/rpGQbicGsbEhPuE67mz9/d8 eZUR79FQprrd8fYPLAPkU78zqb+pAmRkJs2XFKeOIOX7BXiXDy/9/SUU9R6eojkYGDnD Ci1ot0PyHpN8zvcFqowGmBZHXCtwuxlq4epXcIBsaHHCBw+9KaYuGRlVxc5wRZTAYtcZ PBGJZ12p14AKLfI49dhw1TshgKkikvw2xjV7ow5GmHbYcpN9scaR3cB5LSjYnpsb1xJx jmAg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=vZ/hTWNLi2LRCjBuCgOcEfU3Hmto6Go75ndxXnDcoVI=; fh=5cogpUk6BKRN3K31IrAnysGuu2l7NCJG2WJI3d4BcxI=; b=QgNOE0u5O64iy4GET/tXgqFiUcked56XYE5DinVRI0nNPYWCxw7wyCC9EkZhITAOkC GLm8BttIi6bR3DxzinJHgB3oZpdWxipBnWUiPgtI5EXO/a5UC8fCSgVlJYFMLB4ZMW5E eavvLxhBByRTNLQ7ylkc4+tQXLry4bnMDjRgLdeTUZ9L+jlzZxRFedZcl6hppKV+13jO lYASn/Rwg6+Q5EO5U2/0jkuwtlxs+WtFEpRTWSE07OqZNRPlFQnZyqJbpCbE1aV3NVge UoxGfVIpOWZWNVklpfTsr5GDnqsr+igD3BeXeLbH9Xt8zSSD6ijgqoSdFCju1aQefMqm r4yw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ZvyKteZ6; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-58545-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58545-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Forwarded-Encrypted: i=2; AJvYcCV8xJPZ0MHnnUutFBNhTwxdLj0nw+KxgDCF4gzSv4qMgLUc4BJW6NUi9HvGqXiYNn7MTzWtQ3M1fn74r1cs7Q/WP+aOpg== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id gx4-20020a056a001e0400b006e03efbcb3csi355231pfb.179.2024.02.08.13.50.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 13:50:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-58545-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ZvyKteZ6; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-58545-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58545-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1C51F2927F3 for ; Thu, 8 Feb 2024 18:44:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 43258210F2; Thu, 8 Feb 2024 18:43:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZvyKteZ6" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0A5A1DA59; Thu, 8 Feb 2024 18:43:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707417802; cv=none; b=oeMwcI57ltRprTCH71r3A5NzD8h0OIyiEHI24+M+ECJmu7Wm9BWjgpmkDsooU+7QeVyN/nkBqeZ/AQDzdXg59HYL7D4BiBcQVxD4oU7U8xDokhYfHwYbXMlb5FnTyhmYkWjSD/TMQVIfMHR7QnvlrAORb7zUfEcAWmwjWnRx7zI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707417802; c=relaxed/simple; bh=8InsWry7BortGoJkrl/sU2aGiKY8qEehwzBkYvlwt+s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X3g9Y6ZmeY+eX3yBv+HKi1cSH8p2U1KcsCO+JW6pZUdsFXNr5rLC3qOWy9YeE9XpHe2pnz6j73etzG7WJT5V7jWnO8AhY4X7O/fAojTQuNyDYt5BA3qFC+xm/s0WALUQP5TGz50nrOpbVqSuPeqUk56DAFR8K+QuL60ZnIIACYE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZvyKteZ6; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707417801; x=1738953801; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8InsWry7BortGoJkrl/sU2aGiKY8qEehwzBkYvlwt+s=; b=ZvyKteZ627JMqSZCd3nLUhjOrJYrPMfDNpNTDfEtjdc8fC/OpXJpcmz8 M0fGXQLXQerStzf0ZZl7tIzopjZwhJ//OA5clsoO/3H/4+5l6Hzabqi3x BspzGY0dPD7PeQxsqS1TRH9P2+G/vwyxTAXz5jDxkMYnJ0txxVhbD1uQR DCzB82r5uL0bULAtipHLZUNQIcl2CRh4nW5B/X00StS3NoB18oB9ZdpNJ kSKlOVx+zxDADQXea2K13rAGysZXYoMV4OFX7PnvmfTGy3doxB2TUI/HZ GK6LHjjlEDDJuBdt+6C+IjjnOU8jgrDZ+lOf1W+g5aLo3s/crNsWuO/8m w==; X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="1184681" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="1184681" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 10:43:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="934213720" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="934213720" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 08 Feb 2024 10:43:17 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 31CD686; Thu, 8 Feb 2024 20:43:16 +0200 (EET) From: Andy Shevchenko To: Daniel Thompson , Flavio Suligoi , Andy Shevchenko , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Lee Jones , Jingoo Han , Helge Deller Subject: [PATCH v3 1/3] backlight: mp3309c: Make use of device properties Date: Thu, 8 Feb 2024 20:42:26 +0200 Message-ID: <20240208184313.2224579-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240208184313.2224579-1-andriy.shevchenko@linux.intel.com> References: <20240208184313.2224579-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790369125692134750 X-GMAIL-MSGID: 1790369125692134750 Convert the module to be property provider agnostic and allow it to be used on non-OF platforms. Add mod_devicetable.h include. Tested-by: Flavio Suligoi Reviewed-by: Daniel Thompson Signed-off-by: Andy Shevchenko --- drivers/video/backlight/mp3309c.c | 44 +++++++++++++------------------ 1 file changed, 18 insertions(+), 26 deletions(-) diff --git a/drivers/video/backlight/mp3309c.c b/drivers/video/backlight/mp3309c.c index b0d9aef6942b..397f35dafc5e 100644 --- a/drivers/video/backlight/mp3309c.c +++ b/drivers/video/backlight/mp3309c.c @@ -15,6 +15,8 @@ #include #include #include +#include +#include #include #include @@ -199,18 +201,15 @@ static const struct backlight_ops mp3309c_bl_ops = { .update_status = mp3309c_bl_update_status, }; -static int pm3309c_parse_dt_node(struct mp3309c_chip *chip, - struct mp3309c_platform_data *pdata) +static int mp3309c_parse_fwnode(struct mp3309c_chip *chip, + struct mp3309c_platform_data *pdata) { - struct device_node *node = chip->dev->of_node; - struct property *prop_pwms; - struct property *prop_levels = NULL; - int length = 0; int ret, i; unsigned int num_levels, tmp_value; + struct device *dev = chip->dev; - if (!node) { - dev_err(chip->dev, "failed to get DT node\n"); + if (!dev_fwnode(dev)) { + dev_err(dev, "failed to get firmware node\n"); return -ENODEV; } @@ -224,8 +223,7 @@ static int pm3309c_parse_dt_node(struct mp3309c_chip *chip, * found in the backlight node, the mode switches to PWM mode. */ pdata->dimming_mode = DIMMING_ANALOG_I2C; - prop_pwms = of_find_property(node, "pwms", &length); - if (prop_pwms) { + if (device_property_present(dev, "pwms")) { chip->pwmd = devm_pwm_get(chip->dev, NULL); if (IS_ERR(chip->pwmd)) return dev_err_probe(chip->dev, PTR_ERR(chip->pwmd), @@ -257,11 +255,9 @@ static int pm3309c_parse_dt_node(struct mp3309c_chip *chip, /* * PWM control mode: check for brightness level in DT */ - prop_levels = of_find_property(node, "brightness-levels", - &length); - if (prop_levels) { + if (device_property_present(dev, "brightness-levels")) { /* Read brightness levels from DT */ - num_levels = length / sizeof(u32); + num_levels = device_property_count_u32(dev, "brightness-levels"); if (num_levels < 2) return -EINVAL; } else { @@ -275,10 +271,9 @@ static int pm3309c_parse_dt_node(struct mp3309c_chip *chip, sizeof(*pdata->levels), GFP_KERNEL); if (!pdata->levels) return -ENOMEM; - if (prop_levels) { - ret = of_property_read_u32_array(node, "brightness-levels", - pdata->levels, - num_levels); + if (device_property_present(dev, "brightness-levels")) { + ret = device_property_read_u32_array(dev, "brightness-levels", + pdata->levels, num_levels); if (ret < 0) return ret; } else { @@ -288,8 +283,7 @@ static int pm3309c_parse_dt_node(struct mp3309c_chip *chip, pdata->max_brightness = num_levels - 1; - ret = of_property_read_u32(node, "default-brightness", - &pdata->default_brightness); + ret = device_property_read_u32(dev, "default-brightness", &pdata->default_brightness); if (ret) pdata->default_brightness = pdata->max_brightness; if (pdata->default_brightness > pdata->max_brightness) { @@ -310,8 +304,8 @@ static int pm3309c_parse_dt_node(struct mp3309c_chip *chip, * If missing, the default value for OVP is 35.5V */ pdata->over_voltage_protection = REG_I2C_1_OVP1; - if (!of_property_read_u32(node, "mps,overvoltage-protection-microvolt", - &tmp_value)) { + ret = device_property_read_u32(dev, "mps,overvoltage-protection-microvolt", &tmp_value); + if (!ret) { switch (tmp_value) { case 13500000: pdata->over_voltage_protection = 0x00; @@ -328,9 +322,7 @@ static int pm3309c_parse_dt_node(struct mp3309c_chip *chip, } /* Synchronous (default) and non-synchronous mode */ - pdata->sync_mode = true; - if (of_property_read_bool(node, "mps,no-sync-mode")) - pdata->sync_mode = false; + pdata->sync_mode = !device_property_read_bool(dev, "mps,no-sync-mode"); return 0; } @@ -366,7 +358,7 @@ static int mp3309c_probe(struct i2c_client *client) if (!pdata) return -ENOMEM; - ret = pm3309c_parse_dt_node(chip, pdata); + ret = mp3309c_parse_fwnode(chip, pdata); if (ret) return ret; } From patchwork Thu Feb 8 18:42:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 198624 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp494881dyd; Thu, 8 Feb 2024 14:40:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IHnTdOYRY33wd/SseFHpE2BvhucaaIqFrmz7l7rSRBoqnWKE/iOyGXjrmlSk+SKsnOId8mU X-Received: by 2002:a05:6358:338c:b0:178:7986:a586 with SMTP id i12-20020a056358338c00b001787986a586mr644008rwd.5.1707432024580; Thu, 08 Feb 2024 14:40:24 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707432024; cv=pass; d=google.com; s=arc-20160816; b=Q+fTb+bMX0I8X/ZjEkob38X/4mG+EMnpWlSwMYnl7i6rWHo6rR8RFHXI0YVBV538bj +s1qcs7iRYe5GiQbY/a26nDrn5aBoca184rrXI7fZGJkWlB74Y/lU2qk1UU6stpMZ5YK kdbN23uOa8Ztc9qdp0iZbA9vZKWyXaSAu4Ym37PizhV9ZD4byriQo0yBNHHoHiewFm+W OSA2Bu0sH4F7G7pWDlD/U1BLoVHTGQf02QykoOKqOllHIjh0rNQ0EFb8Ku+QPjp7TEVI +SGu+MaIsewVDgC4G02q7CPBrVTDiCxQkEDVM2uAU0UPjfKvoCSGuceEPrv6TltN/eKt YF0A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=t4DkA1pwXwWT70jNpatgxRZ/y7IrW8Vj5gRclU/hKKg=; fh=U9l7osckCvlF9kEZ6aTFHPwqAcwSUcJ7c/j397xPX/s=; b=b0ymanSpHGO8yNx7gro/U2vHLlteCmFOttEZHhY2q1RjXkA8P+C8INzrU+FFRhZF7r r4YmgnD9ZA3Zziku41lZWawg4YHZsUJ+I1mn/vXle36gDPT0u1XdXqJjwaP/tEZ2bsH9 47Oo/m4Lm7/mDeMmQeSE+SZiQKd9tnF9Fs7Je05/5ievNQhCB8nJ+D1xSFSk225dykqb p5/yVgfCZD8rXntcC59JAP2AgYPmTyIpgLYJ48LSkYF9CqXTCEOtUt7mv/hSeZi629Q2 dg2+Mt0DFc38GK0beAZD+cBZh2JQm0qlU8SN+ib2ZjeuZd4XjfQ9n9Akt8YNRKa8xYdM +VCg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=I5aRwLhK; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-58548-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58548-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Forwarded-Encrypted: i=2; AJvYcCWq8GWFTqHE5GbbVFTFMgPVV+Wx+NlQ8WR8nAIKHkhPvqrdUr2Ele9MO73UrMOjafbm0IRKF5x8fVB8KtiV+WQHpJfu+A== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d63-20020a633642000000b005d55aec96b2si588364pga.41.2024.02.08.14.40.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 14:40:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-58548-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=I5aRwLhK; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-58548-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58548-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BF013293351 for ; Thu, 8 Feb 2024 18:44:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AD61B2E3E5; Thu, 8 Feb 2024 18:43:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="I5aRwLhK" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBBBE2377B; Thu, 8 Feb 2024 18:43:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707417806; cv=none; b=sRXE4mwYOthdX8Qrd3yQFHS4zqiMEjIupdcvloRn+pBHWB/MY3Ej40MEPNyjTmH7i144wIQ0NEkqzRmevJ+jq6iRLS0lo25V7cl6UOGO4dnINlekZom6ZAeYsvjJ7eRFtc02yPzgh8EqX1ZCOHbdW5MbH03GaNUVHvPoVqf7qpU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707417806; c=relaxed/simple; bh=R8VW3vdNVBtgOG4uxMk33o384NOmy+Axf/iYx44RjkM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XmCnHO9SajiWAbmKjqX6BEjXUL7SdzBUfTLDFLOuX0+IqcuiFphfCTCSq17H20PyVhek1rCq9iOzdgrKRD7qfRjU3Z8x8xTjVX0dulyZ3c8kVIENB4/qEif8QAu327axsUMku9hsZc9B6vdjeB/TD27cfunAwPPaOU1s1OOxDKo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=I5aRwLhK; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707417805; x=1738953805; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=R8VW3vdNVBtgOG4uxMk33o384NOmy+Axf/iYx44RjkM=; b=I5aRwLhKkYkDtKLnkUJ7d9CFAlZXjXYNuQucneKAlsz9RKWE7C+Wx/qN Qsiqwkm9rYDbUJx5sqSyGDx1+yvy5pYA1b/O96fKTc+6q5aNmXKc5fXP6 WPUuhF0STqTpbfTA/Sq8g3K4pYFyU4NKOVubcG5M6I+fvRJW/Qtr67Sl8 h1nVTeIvHzQw3cjVakB7fbk99C2Z/CCOhw6sT4CwcFe05jSOPhCXHQk+I IGa/KZavGDtonsGq+BIN47+QJ7WZYlwm8e9DTSSnTodvlF+/DGKJIyRhX IOh3ifIoWwDplI43ZkD1NeZ6hreBvDpM4EiBkQBqvUhfppnmPoAVwLZS+ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="1184696" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="1184696" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 10:43:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="934213721" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="934213721" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 08 Feb 2024 10:43:17 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 40C421FF; Thu, 8 Feb 2024 20:43:16 +0200 (EET) From: Andy Shevchenko To: Daniel Thompson , Flavio Suligoi , Andy Shevchenko , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Lee Jones , Jingoo Han , Helge Deller Subject: [PATCH v3 2/3] backlight: mp3309c: use dev_err_probe() instead of dev_err() Date: Thu, 8 Feb 2024 20:42:27 +0200 Message-ID: <20240208184313.2224579-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240208184313.2224579-1-andriy.shevchenko@linux.intel.com> References: <20240208184313.2224579-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790372242321729395 X-GMAIL-MSGID: 1790372242321729395 Replace dev_err() with dev_err_probe(). This helps in simplifing code and standardizing the error output. Tested-by: Flavio Suligoi Reviewed-by: Daniel Thompson Signed-off-by: Andy Shevchenko --- drivers/video/backlight/mp3309c.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/video/backlight/mp3309c.c b/drivers/video/backlight/mp3309c.c index 397f35dafc5e..426e9f2356ad 100644 --- a/drivers/video/backlight/mp3309c.c +++ b/drivers/video/backlight/mp3309c.c @@ -208,10 +208,8 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip, unsigned int num_levels, tmp_value; struct device *dev = chip->dev; - if (!dev_fwnode(dev)) { - dev_err(dev, "failed to get firmware node\n"); - return -ENODEV; - } + if (!dev_fwnode(dev)) + return dev_err_probe(dev, -ENODEV, "failed to get firmware node\n"); /* * Dimming mode: the MP3309C provides two dimming control mode: @@ -287,8 +285,7 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip, if (ret) pdata->default_brightness = pdata->max_brightness; if (pdata->default_brightness > pdata->max_brightness) { - dev_err(chip->dev, - "default brightness exceeds max brightness\n"); + dev_err_probe(dev, -ERANGE, "default brightness exceeds max brightness\n"); pdata->default_brightness = pdata->max_brightness; } @@ -329,16 +326,15 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip, static int mp3309c_probe(struct i2c_client *client) { - struct mp3309c_platform_data *pdata = dev_get_platdata(&client->dev); + struct device *dev = &client->dev; + struct mp3309c_platform_data *pdata = dev_get_platdata(dev); struct mp3309c_chip *chip; struct backlight_properties props; struct pwm_state pwmstate; int ret; - if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) { - dev_err(&client->dev, "failed to check i2c functionality\n"); - return -EOPNOTSUPP; - } + if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) + return dev_err_probe(dev, -EOPNOTSUPP, "failed to check i2c functionality\n"); chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL); if (!chip) From patchwork Thu Feb 8 18:42:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 198628 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp498785dyd; Thu, 8 Feb 2024 14:50:56 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUTFePupbABgSpciE/L3mAYTVWgBxN3qxgtU42TirpQxNz+1VOBgsQ0zYwjnHn7Aj4pReewiFoQmgreLGyuvhrJSofs8g== X-Google-Smtp-Source: AGHT+IHqKvIMZSrbwzi7wmDbwPs09Wo7oMe8DTzkT/iidWD3ypHI7A9qwcHvdM6jYLEFramOYzS5 X-Received: by 2002:a05:6a20:760f:b0:199:7d51:a942 with SMTP id m15-20020a056a20760f00b001997d51a942mr876861pze.50.1707432656091; Thu, 08 Feb 2024 14:50:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707432656; cv=pass; d=google.com; s=arc-20160816; b=YGBG9nfO6cX8dN+QPhrYmuIYSUl+yYA2Xg+W7smHyt8EogCPQwOntu4tuQM2H9rTMF vJBLBxInDCUJ3OZaqTA4ue2rCVMP4bQrAzw3UVohzuccC3tNE0mGuOlTf9Qm23SLLA3B EBNzu0OAyiFQ/gS8qemHFy+6GVhN5C+HzVZ81GnP+vwpBjwRaoE1TgmoRz5JQW2w+ato NEqvQsgitYEkhtcH4DfRGhSkmLOCnNScUtfjNtEIHhU001YIWuLPcKoCPoe8j3lyACSy gXyKDFYsWiWRkQY51PauVuPnSsnbLzcJnBCZWrb8zEIBgFeYarlOHIURao9zVz3tDgD8 MZ6A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=OSOjzIsjnQh8q/JtF8MKjmRAAY5j5GuSqarjX0zVc5g=; fh=EMCV5hlfQaMtvwoe2RNt5ntsqSxRfWfgZIuJSiPfIIE=; b=pniJ9jaaOhL7URx5k3SedAL2hxE3Qgacu7KA7zgaT8EMMOeSEwXUmXiuLNMYUe3aeo egkNnM26oVYQLhe4xeS7ArgmR4FQFNEb5x6fy038wCKyzUP06lhZ9YLKGXAnoQ9K/FS1 rZuNocsvd512iHf9J1L82sL4eETU2fkQWwHjX9Axvz0FJapI4HILvD2vohjUvEcTUUMD OorI2VSK+EWt77Wu1/h2Bg3kNFWdxdVQNL53bTSCvd9maVuM5/8y6hBZ9ZI81H4LK0dq Mqo57awDbND9pjKiYblgRSgtNP69s0oSMctivgejjMS0zKWex6OWWDiT5xw1L6Q75Ifr Pz9Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="g/EzkqIr"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-58547-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58547-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Forwarded-Encrypted: i=2; AJvYcCXlox7vHhhyArUM7+DYK1atnjArWivtzC0mZeUmu9/S7aI3mK1xBYSFavSe9YyZyE2qw60/RZGeZRXd84ejEh8p44qGvA== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id mq4-20020a17090b380400b002962a155f24si519413pjb.29.2024.02.08.14.50.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 14:50:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-58547-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="g/EzkqIr"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-58547-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58547-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 47DA729301E for ; Thu, 8 Feb 2024 18:44:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4DAEC2555F; Thu, 8 Feb 2024 18:43:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="g/EzkqIr" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6613520332; Thu, 8 Feb 2024 18:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707417805; cv=none; b=g9IiI0IacAY2sL1qzEQqS9a00aGiasbvjIEg9ouMisKnIHNUEB2RcnXNUnLVW/Z6AMoQuUPMdgqLyMI8CJzO38oOoeL6pJ7GKiABJRRVpZz3ZXu9KQiXCjBA3vrciTTxQm49YcCHj6jyn0wDkX9jFc/BXgSzV5FEhPzHDOquY+I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707417805; c=relaxed/simple; bh=ksPh+SGOZxTsk3yoazHWC1sh6u7Hvs7YFo8izy4mpuk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QczULrkBKNqn15PPopK5Y2Xkc5To+ruPfxK6ogd5ZCmCg6zTY7sREapjyR59Swn82G+AQCyT81yV9KyHjeW5DaM2XqDEw8m9AjmrsQln3PsoC86x1BBEDHGNz51B4+F1yQrSjGDcOQPm9Z/hNKzEEPU4up0XsT278wPnV7PrhFw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=g/EzkqIr; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707417803; x=1738953803; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ksPh+SGOZxTsk3yoazHWC1sh6u7Hvs7YFo8izy4mpuk=; b=g/EzkqIru9HiymGReqJsyHEr7xmrvtAEtjoZvQiCXOKiLBnN45+9Bosr O1W0ucfF99Uk8OSE6LjPArfsyoQX3Cjy+B/QnL0MC950Y14Mf1yFPQzt2 jJEJKHmZP0RxMAta50bZ9PkGyiFyZZbbIXQ2eepWg9StWPDZBgcnUAUMQ Pam4Dc10fHMqOB75XPt+BbUswrNgSVSTkGMBTFP2pofYBS957jfeyyG/Q AP+vGe8eb0+TQ1O1O5gp4bzgujUU/YR4lVmzgVA7LuzcIPMxUqjqouXU8 qPR/jL314EJsD7iM58/o2SOh7H3eHzfLJZ17CQ7KVnn58Rbn9ekWQPkoZ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="1184689" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="1184689" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 10:43:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="934213722" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="934213722" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 08 Feb 2024 10:43:17 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 46BB213C; Thu, 8 Feb 2024 20:43:16 +0200 (EET) From: Andy Shevchenko To: Daniel Thompson , Flavio Suligoi , Andy Shevchenko , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Lee Jones , Jingoo Han , Helge Deller Subject: [PATCH v3 3/3] backlight: mp3309c: Utilise temporary variable for struct device Date: Thu, 8 Feb 2024 20:42:28 +0200 Message-ID: <20240208184313.2224579-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240208184313.2224579-1-andriy.shevchenko@linux.intel.com> References: <20240208184313.2224579-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790372904841655244 X-GMAIL-MSGID: 1790372904841655244 We have a temporary variable to keep pointer to struct device. Utilise it where it makes sense. Reviewed-by: Daniel Thompson Tested-by: Flavio Suligoi Signed-off-by: Andy Shevchenko --- drivers/video/backlight/mp3309c.c | 30 ++++++++++++------------------ 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/drivers/video/backlight/mp3309c.c b/drivers/video/backlight/mp3309c.c index 426e9f2356ad..708c053d492c 100644 --- a/drivers/video/backlight/mp3309c.c +++ b/drivers/video/backlight/mp3309c.c @@ -222,10 +222,9 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip, */ pdata->dimming_mode = DIMMING_ANALOG_I2C; if (device_property_present(dev, "pwms")) { - chip->pwmd = devm_pwm_get(chip->dev, NULL); + chip->pwmd = devm_pwm_get(dev, NULL); if (IS_ERR(chip->pwmd)) - return dev_err_probe(chip->dev, PTR_ERR(chip->pwmd), - "error getting pwm data\n"); + return dev_err_probe(dev, PTR_ERR(chip->pwmd), "error getting pwm data\n"); pdata->dimming_mode = DIMMING_PWM; pwm_apply_args(chip->pwmd); } @@ -243,11 +242,9 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip, num_levels = ANALOG_I2C_NUM_LEVELS; /* Enable GPIO used in I2C dimming mode only */ - chip->enable_gpio = devm_gpiod_get(chip->dev, "enable", - GPIOD_OUT_HIGH); + chip->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH); if (IS_ERR(chip->enable_gpio)) - return dev_err_probe(chip->dev, - PTR_ERR(chip->enable_gpio), + return dev_err_probe(dev, PTR_ERR(chip->enable_gpio), "error getting enable gpio\n"); } else { /* @@ -265,8 +262,7 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip, } /* Fill brightness levels array */ - pdata->levels = devm_kcalloc(chip->dev, num_levels, - sizeof(*pdata->levels), GFP_KERNEL); + pdata->levels = devm_kcalloc(dev, num_levels, sizeof(*pdata->levels), GFP_KERNEL); if (!pdata->levels) return -ENOMEM; if (device_property_present(dev, "brightness-levels")) { @@ -336,21 +332,21 @@ static int mp3309c_probe(struct i2c_client *client) if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) return dev_err_probe(dev, -EOPNOTSUPP, "failed to check i2c functionality\n"); - chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL); + chip = devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL); if (!chip) return -ENOMEM; - chip->dev = &client->dev; + chip->dev = dev; chip->regmap = devm_regmap_init_i2c(client, &mp3309c_regmap); if (IS_ERR(chip->regmap)) - return dev_err_probe(&client->dev, PTR_ERR(chip->regmap), + return dev_err_probe(dev, PTR_ERR(chip->regmap), "failed to allocate register map\n"); i2c_set_clientdata(client, chip); if (!pdata) { - pdata = devm_kzalloc(chip->dev, sizeof(*pdata), GFP_KERNEL); + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); if (!pdata) return -ENOMEM; @@ -367,11 +363,10 @@ static int mp3309c_probe(struct i2c_client *client) props.type = BACKLIGHT_RAW; props.power = FB_BLANK_UNBLANK; props.fb_blank = FB_BLANK_UNBLANK; - chip->bl = devm_backlight_device_register(chip->dev, "mp3309c", - chip->dev, chip, + chip->bl = devm_backlight_device_register(dev, "mp3309c", dev, chip, &mp3309c_bl_ops, &props); if (IS_ERR(chip->bl)) - return dev_err_probe(chip->dev, PTR_ERR(chip->bl), + return dev_err_probe(dev, PTR_ERR(chip->bl), "error registering backlight device\n"); /* In PWM dimming mode, enable pwm device */ @@ -383,8 +378,7 @@ static int mp3309c_probe(struct i2c_client *client) pwmstate.enabled = true; ret = pwm_apply_might_sleep(chip->pwmd, &pwmstate); if (ret) - return dev_err_probe(chip->dev, ret, - "error setting pwm device\n"); + return dev_err_probe(dev, ret, "error setting pwm device\n"); } chip->pdata->status = FIRST_POWER_ON;