From patchwork Tue Feb 6 18:13:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aren X-Patchwork-Id: 197618 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1758110dyb; Tue, 6 Feb 2024 11:09:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IFiX6udunIjo2rjfWu9kizFsKT/mxN7UnnsFTgOKeOksxzeLJI9pcbeaPaE739sCB1K/apw X-Received: by 2002:a17:903:186:b0:1d9:66de:ea0b with SMTP id z6-20020a170903018600b001d966deea0bmr2872967plg.37.1707246550904; Tue, 06 Feb 2024 11:09:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707246550; cv=pass; d=google.com; s=arc-20160816; b=HlLqP2q0Qe9o/2MdChzVE/HlthSD3OTlP+SC5ggj21TmOFlU0E/R2rY0g3KOWq6lds 25ds1pjfISXyud14Jh3QelKvnX2fUa47uWzkcrXnlpdkOFvPoi7KbARoUzqYtaJoiDjn g2DRU90g9qFdHLW3gVcNR1rUQu9QW0HfFgBWw8oki4e4AKHoFyW0jQjnS38ztTaC7i4K 2doNfsYTtA/v4tC0w43e5yio6H3IyfXs6VYqUyvPBF763Jx9iwUhXBTAjOoyVX+sGWxT +XKlg5tTgimBfe8cAIyJNUYFj6u9fgQ+Z845JzUhmoulkiZNZfUhLUVoSsz92KykK1MW 88Mw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=dkim-signature:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:message-id:date :subject:cc:to:from; bh=NQIirmVOCAxOql2DLF2KDYdkndurgToAOXdUzzfrUao=; fh=tsy7etqp54D+ypd5QzmLH/b4IG+VMgAYmTtd3ASGnkk=; b=NeMXfnsmu/D4uCTUeWiLeeNbpZJpvk3E0y15r1iNkv8uLc+Jv7O2CGEHOcK/mRfTLf eRu35IbS1fQdzDnj57I0FzqGOLaaOKeZqpAQaad7+MBn7nhRsqocVTLzEByaDDr/M2vn MsaLo8lIHh5pxnKTM5ph0vHhHNi2tRGpBycgOQOdzu+V9APz6Bq0Pc22788xXH8XRMW2 iUZlM/icM7cY1LIdj2FmZYH0O6T/JOhJvgdMAZiS0RTzbRiQDIlMwKsoMNOJT8Ln6unq iOt863D03Svt4bggXEYX7MzfqPyAJ6J1J3T4oKYjnJbLrYHKhHMrWESiaSuuA7/Kk54H 54bQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b=AD8RDoDq; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-55531-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55531-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org X-Forwarded-Encrypted: i=1; AJvYcCW/uGG/6kdVa2fLCfh9mxwj6jx2E7xIstG+x6DB+gxBSoo2tKcpa248i3QC8yrB4b2dCGpZJcpx+RLHTbATnZIdNcM5mQ== Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id ji15-20020a170903324f00b001d9620e9ad4si350499plb.26.2024.02.06.11.09.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 11:09:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55531-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b=AD8RDoDq; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-55531-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55531-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 32275B27039 for ; Tue, 6 Feb 2024 19:04:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4848F179AF; Tue, 6 Feb 2024 19:03:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b="AD8RDoDq" Received: from a.peacevolution.org (a.peacevolution.org [206.189.193.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 122B5175BD; Tue, 6 Feb 2024 19:02:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=206.189.193.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707246178; cv=none; b=ddgi0iSNnESpPw5Xb2Gx6bi0HuirQfu6GLkX62mnL51Ie5gEe/dWY2cfT+EN5kO3mP1pVuYVlDL5UJyJpiVy+AL1WXLFwRmWtMUH3i3m+Za5PQmHSGjcgRDx2a1HG2sEjtGHbuGmXXA9/NnJBbDp8obz+wl0tPzJxaLq32UiDdM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707246178; c=relaxed/simple; bh=qXVPXyupoi6y4mfGDfx6l8JDOF1+lMDDn4mbVnSTzr0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=vE5C2+t6LWqlUP4zC3HHwiMEsfo5JSLT/1t4+1rgWo6JchBtRxKkLK+vZ8jqWbet9s8WnN4LV4Cq3Fx12BzrWEndsto1o1iqSFw5u2MnzYMqtjYX9g2/88pB/MGDF8W1LecuBHLxEjTiOIss+yaZmuMxdsK7tN934EmgDWku1qs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org; spf=pass smtp.mailfrom=peacevolution.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b=AD8RDoDq; arc=none smtp.client-ip=206.189.193.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peacevolution.org Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id DD9644583E; Tue, 6 Feb 2024 19:02:48 +0000 (UTC) From: Aren Moynihan To: linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, Jean-Jacques Hiblot , Chen-Yu Tsai , Ondrej Jirman , linux-sunxi@lists.linux.dev, Lee Jones , Pavel Machek , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , linux-leds@vger.kernel.org, Conor Dooley , Miles Alan , Samuel Holland , Aren Moynihan Subject: [PATCH v2 1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend Date: Tue, 6 Feb 2024 13:13:17 -0500 Message-ID: <20240206185400.596979-1-aren@peacevolution.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org X-Spam-Level: **** X-Spamd-Bar: ++++ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1707246170; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding; bh=NQIirmVOCAxOql2DLF2KDYdkndurgToAOXdUzzfrUao=; b=AD8RDoDqSuMzuW8WjS6hsO4Ihd7f8WOWW5QsXpSI7G+B3S/ZAOv9zFcgzVMoPwDLVcGvsZ 3jyUXi4dQD42GwETLjspanbyyc4gtnAGlP9du/NQeqpq3AQNfhm+zqS098d0N0cu3STJr2 Os7WmPNxQ97X0MQofjfo76Zlw56NSU0= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790177759461998475 X-GMAIL-MSGID: 1790177759461998475 If none of the managed leds enable LED_CORE_SUSPENDRESUME, then we shouldn't need to set it here. This makes it possible to use multicolor groups with gpio leds that enable retain-state-suspended in the device tree. Signed-off-by: Aren Moynihan Acked-by: Pavel Machek --- Changes in v2: - make sure count gets initialized - send the patch to (hopefully) all the correct people this time drivers/leds/rgb/leds-group-multicolor.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/leds/rgb/leds-group-multicolor.c b/drivers/leds/rgb/leds-group-multicolor.c index 39f58be32af5..b6c7679015fd 100644 --- a/drivers/leds/rgb/leds-group-multicolor.c +++ b/drivers/leds/rgb/leds-group-multicolor.c @@ -69,7 +69,7 @@ static int leds_gmc_probe(struct platform_device *pdev) struct mc_subled *subled; struct leds_multicolor *priv; unsigned int max_brightness = 0; - int i, ret, count = 0; + int i, ret, count = 0, common_flags = 0; priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) @@ -91,6 +91,7 @@ static int leds_gmc_probe(struct platform_device *pdev) if (!priv->monochromatics) return -ENOMEM; + common_flags |= led_cdev->flags; priv->monochromatics[count] = led_cdev; max_brightness = max(max_brightness, led_cdev->max_brightness); @@ -114,12 +115,15 @@ static int leds_gmc_probe(struct platform_device *pdev) /* Initialise the multicolor's LED class device */ cdev = &priv->mc_cdev.led_cdev; - cdev->flags = LED_CORE_SUSPENDRESUME; cdev->brightness_set_blocking = leds_gmc_set; cdev->max_brightness = max_brightness; cdev->color = LED_COLOR_ID_MULTI; priv->mc_cdev.num_colors = count; + /* we only need suspend/resume if a sub-led requests it */ + if (common_flags & LED_CORE_SUSPENDRESUME) + cdev->flags = LED_CORE_SUSPENDRESUME; + init_data.fwnode = dev_fwnode(dev); ret = devm_led_classdev_multicolor_register_ext(dev, &priv->mc_cdev, &init_data); if (ret) From patchwork Tue Feb 6 18:13:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aren X-Patchwork-Id: 197619 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1758930dyb; Tue, 6 Feb 2024 11:10:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGL1V/NytKUhyV1796NrlW71AKLoECi+n+h0lEJBsJyba0l+GpK0HfwX51gbmRCahlWDBjJ X-Received: by 2002:a05:6a20:be93:b0:19e:986d:c16a with SMTP id gf19-20020a056a20be9300b0019e986dc16amr1904361pzb.9.1707246636693; Tue, 06 Feb 2024 11:10:36 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707246636; cv=pass; d=google.com; s=arc-20160816; b=rld/gzIgV1g/M6iPW/gcyu1diHI0Os+XfGj7KTTdW46Q6U+qqqrNhkdSfsGBZ3XgZB A65XVMg/FdfjWQLESCW70Xi95JUK+Xl5yKFEsTmcMaK+TgyV2FtdBcita0KaJyayjWuz M4Tl8hTFxnV0wSXEBxR+jhlqStWIME94YwWSwpQex6Cc+K0/Xkrq//FKjkfNvXi7Diof vfCfoN9EO1gKi1Sk3ow7qdoBVPz4aYYMQ/Te4764YHOde0PWDLXVfYG7wiU8yzy2O9Dy dNiy8mZA4l2ywmnUxM25N8qLccGoc841h6uKkNmS172ApqztumaqTcnoMuvhiUYqsOuZ RmIg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=dkim-signature:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from; bh=WNZ4KASkiwSJG0vvqKpuM1/sq6GRaWdR1H4ZY5MyEjM=; fh=UTSnUTbKup4N5G0Wfq4gxqHuq/BuUnYUrdEChzdT0h8=; b=taS6unV8Bwfdzq5rxrA5JLU4fgxJ2qchlXBzf0S+TgnJU5H02OcK+zZ9ZaWRpgUgMR afOys9d0wSVjesHeXM+/hDRSrwxdPOEwsGA+MhUBzTJ7sXPCNbCLR8qgz0VQj7Q+Zdds t482bXMkttaqvOUUzfQsbic9hScGJFJ+FFLARKwHQCxmV4a50te5huBnZJa096vmI0EZ J0hIxJBGCEpJ6fQx2o0UJLyZK7rlAZk9iQQYOHGyJhGXcyIg8W4hiGWOjuBQ1UzDDcjn YLc8LzEl+yYkug52I3a5v+f6XoT9NGILtacK4ROY0jv0t4f+CImDIuVeJfr1/gFZD8bN c0Mw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b=Qay1spRg; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-55532-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55532-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org X-Forwarded-Encrypted: i=1; AJvYcCVm3Ytkav/SO4CNRJwoYqDzk6NENWPrETbSrszfVuSSaDwUHXFCQi7jpoDa42bki/K0FDqxcjq6IxoXGJVydbQMsAUYzw== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id p24-20020a63c158000000b005d988899a4dsi2133513pgi.526.2024.02.06.11.10.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 11:10:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55532-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b=Qay1spRg; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-55532-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55532-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C4AF128A1D7 for ; Tue, 6 Feb 2024 19:04:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 40F521804F; Tue, 6 Feb 2024 19:03:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b="Qay1spRg" Received: from a.peacevolution.org (a.peacevolution.org [206.189.193.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 212F517BBB; Tue, 6 Feb 2024 19:03:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=206.189.193.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707246194; cv=none; b=mR+IjiY7D+r+VPC71lMjrOS/HB1u19EpY0pRYTmPIrufzm0FQOOHD1IBwRLxacI8BYCME1aEjNRYijZhJ+0Y9RxVglrKFiiGx795ig/vVR1Mcxc8W8Eq4TQbeO4UDK1pFK8GZpTvXOL8Q53DzZA0/kot//6ZipXPATmVYfJtJG4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707246194; c=relaxed/simple; bh=KSqF8dieENTc/5z9k3ogdmL+5L1K6aVKAxTyRVVL7t8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nX5yZbMvSlpJ2C5y5GRPC/YCpqUdEtItP9fB+yq2BL4sA8pGZ5LssRQledBCzmBQOuY+y6se1sAMuBWQrjCxuQvCpgvtN25v3QB0wrXj30VZgEFssS4Jov3DzORxKr9+SmYKThmCeNquQ4H8BY/DlS0+3WiBUDsTRFHts6WHBrA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org; spf=pass smtp.mailfrom=peacevolution.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b=Qay1spRg; arc=none smtp.client-ip=206.189.193.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peacevolution.org Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id 296BC4583E; Tue, 6 Feb 2024 19:03:11 +0000 (UTC) From: Aren Moynihan To: linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, Jean-Jacques Hiblot , Chen-Yu Tsai , Ondrej Jirman , linux-sunxi@lists.linux.dev, Lee Jones , Pavel Machek , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , linux-leds@vger.kernel.org, Conor Dooley , Miles Alan , Samuel Holland , Aren Moynihan Subject: [PATCH v2 2/4] arm64: dts: sun50i-a64-pinephone: Retain leds state in suspend Date: Tue, 6 Feb 2024 13:13:18 -0500 Message-ID: <20240206185400.596979-2-aren@peacevolution.org> In-Reply-To: <20240206185400.596979-1-aren@peacevolution.org> References: <20240206185400.596979-1-aren@peacevolution.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org X-Spam-Level: ** X-Spamd-Bar: ++ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1707246192; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding:in-reply-to:references; bh=WNZ4KASkiwSJG0vvqKpuM1/sq6GRaWdR1H4ZY5MyEjM=; b=Qay1spRgP5aYmwraoePTBh1gHtxv4woB4OpvvJT/IepoaKK8/tna3jZi6Ndm2hDTISODVp NEU5LCHZhMUB6vFi/zUKgxcw25TjByiWhfS3UdVqelmgxATldyhHfqgPBaAhHbJ3DJn8/7 7AiPnQangsdH4xDHRe6J5tp+zwHNbog= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790177849650344629 X-GMAIL-MSGID: 1790177849650344629 From: Miles Alan Allows user to set a led before entering suspend to know that the phone is still on (or could be used for notifications etc.) Signed-off-by: Miles Alan Signed-off-by: Ondrej Jirman Signed-off-by: Aren Moynihan Reviewed-by: Jernej Skrabec --- (no changes since v1) arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi index 87847116ab6d..ad2476ee01e4 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi @@ -43,18 +43,21 @@ led-0 { function = LED_FUNCTION_INDICATOR; color = ; gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */ + retain-state-suspended; }; led-1 { function = LED_FUNCTION_INDICATOR; color = ; gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */ + retain-state-suspended; }; led-2 { function = LED_FUNCTION_INDICATOR; color = ; gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */ + retain-state-suspended; }; }; From patchwork Tue Feb 6 18:13:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aren X-Patchwork-Id: 197620 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1759160dyb; Tue, 6 Feb 2024 11:11:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IGYqZaXOkxSh5pXoKsf5H6Yt5f/TKNwC+Ugrc/FJTjIj/x210rTT5NtcuBzLGuYkay3o99X X-Received: by 2002:a05:6870:b48b:b0:214:98ae:8c62 with SMTP id y11-20020a056870b48b00b0021498ae8c62mr4097116oap.7.1707246664106; Tue, 06 Feb 2024 11:11:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707246664; cv=pass; d=google.com; s=arc-20160816; b=l4CKE0EgKje7Tx7slinl3YNsWOABE2N7dnnxCMsMmX8v/GESawQIax/v1uo2r3BXuh x7OFBKau3mwPizMZxUSnGf3CXTFSrk1c+goH1u3/3t5lvEcIPjd6LGcTX/TdcLJ2RSye 1RJXh0t1e8i05cLeMK/ipC9nVnUIqSIS36LHL99EmKBJfXBQubaas7GaHw+QeXGEFD3b g44oOl8+q7yK8tQodStYjcf2d7EiXkMbMv9RCMpjKrxFj5DgWfcg0icZ4s/EE3A+xEq/ oAJ4Y+3GaOkWucigMWdrVJJ4Url+Lbjjnr+JKE3ZN6X+yygq3x/XOYcgNA1hUmZN3RNJ LrpA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=dkim-signature:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from; bh=o6DDRcilCg3I7Q6EoW6q5k4FGWr7L3+KOlmCTdxiqwk=; fh=57hOTrfGocEHpxFWcuDMNY6gcF+2VWAMGKjPnFj4Jfk=; b=eG9v0pzrJs+8B4Zrh8O3TqcAdZw0jiVI6bQ7OfSyUKGLhRDfGsY/7CMMujJBktyrTJ JMrIkh2XrcVmGKHrvgIQbFwmnMQhvmewAx1UWpuldBwDbC5uXGeS4kWG05BllNm3PHdD oqe8sCh2LMb/7MmUsawc8qfcoK9UliaWHc2tYEFMwg+ptIxrn/IVbZEZvjtPagM0lfAZ LeojIYYqURFFrnbv1x/K/JDgufv1l1ia446xQl3gHyBLYBbsaPfQcf4q129LmL0UNN7P vicrR1D4lDIrR4KaCLxyDPvfKvbo5F/nNHcg9zNoTlsOA7rOMcAJy/w6qlVgperNGIPk 1BtA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b=VC0TL22s; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-55534-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55534-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org X-Forwarded-Encrypted: i=1; AJvYcCXBQoozSLDjhbvvUnU3Kdq9Ww/JfZVbMQOmSuTwQw/daRykKfVQjIk1JaWFxv+K0rngnED5lOINgatjH6r1QVNBOyE+7Q== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 17-20020a630211000000b005cee03a5355si1998023pgc.518.2024.02.06.11.11.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 11:11:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55534-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b=VC0TL22s; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-55534-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55534-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BCED628B5E0 for ; Tue, 6 Feb 2024 19:05:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D6CAF1B807; Tue, 6 Feb 2024 19:03:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b="VC0TL22s" Received: from a.peacevolution.org (a.peacevolution.org [206.189.193.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D31C21B7F0; Tue, 6 Feb 2024 19:03:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=206.189.193.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707246205; cv=none; b=c+L2ucVjrbnqULDOjaga4Ud1HM0EMmGYhTSS+oa6c/B7u8YbZLu7sjVHESaRNOMSjwZjCSJAtUwKw48EGQ3KS/bjGws6lR29QN+TvkJf4vZsv3VsTrRPwLvNl+miwdvjzhR/0ADBqHbyol1NomehYgJoQO9lxNWY8QzfIOYYzNc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707246205; c=relaxed/simple; bh=XYDsMDVcsP7odk8FeBn6mlA5XGeXcHZ/KkPG93FWgMA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=A89iL5JdTdLV5uCrwwkVZw2SX7CFXd0oGyh3Xy7LP2qNORnY2ZKQv09i5mVAfHyG9bSZxyBGjkOH3ElIRo10X977e1tYcaT32B4jQbBnJtu/jSCiuQ1anQ2INzLZpOrg0hQJl2OKz8ZeA+UyA2K8AQoEsM0MS3hI3GOCxj5d1rw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org; spf=pass smtp.mailfrom=peacevolution.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b=VC0TL22s; arc=none smtp.client-ip=206.189.193.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peacevolution.org Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id 081F84583E; Tue, 6 Feb 2024 19:03:21 +0000 (UTC) From: Aren Moynihan To: linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, Jean-Jacques Hiblot , Chen-Yu Tsai , Ondrej Jirman , linux-sunxi@lists.linux.dev, Lee Jones , Pavel Machek , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , linux-leds@vger.kernel.org, Conor Dooley , Miles Alan , Samuel Holland , Aren Moynihan Subject: [PATCH v2 3/4] arm64: dts: sun50i-a64-pinephone: add multicolor led node Date: Tue, 6 Feb 2024 13:13:19 -0500 Message-ID: <20240206185400.596979-3-aren@peacevolution.org> In-Reply-To: <20240206185400.596979-1-aren@peacevolution.org> References: <20240206185400.596979-1-aren@peacevolution.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org X-Spam-Level: ** X-Spamd-Bar: ++ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1707246203; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding:in-reply-to:references; bh=o6DDRcilCg3I7Q6EoW6q5k4FGWr7L3+KOlmCTdxiqwk=; b=VC0TL22sbbRARJCon5mZiI14jPEcLoImFrDoq4GBZtIijTpRaGeIu7Rb4q8BT7XvDWYV8C 8VDVgnhntAT0O2UK7pTktC9szWoeqIwBuVGvqm5xc6J6Ik+j4WsX+e5a2mKsacITrRDMJF x+LjefqJqs/zDQmDMA6ZIr9Td8dMLzw= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790177877743397272 X-GMAIL-MSGID: 1790177877743397272 The red, green, and blue leds currently in the device tree represent a single rgb led on the front of the PinePhone. Signed-off-by: Aren Moynihan --- Changes in v2: - remove function property from individual led nodes .../boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi index ad2476ee01e4..e53e0d4579a7 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi @@ -39,28 +39,32 @@ chosen { leds { compatible = "gpio-leds"; - led-0 { - function = LED_FUNCTION_INDICATOR; + led0: led-0 { color = ; gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */ retain-state-suspended; }; - led-1 { - function = LED_FUNCTION_INDICATOR; + led1: led-1 { color = ; gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */ retain-state-suspended; }; - led-2 { - function = LED_FUNCTION_INDICATOR; + led2: led-2 { color = ; gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */ retain-state-suspended; }; }; + multi-led { + compatible = "leds-group-multicolor"; + color = ; + function = LED_FUNCTION_INDICATOR; + leds = <&led0>, <&led1>, <&led2>; + }; + reg_ps: ps-regulator { compatible = "regulator-fixed"; regulator-name = "ps"; From patchwork Tue Feb 6 18:13:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aren X-Patchwork-Id: 197621 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1760115dyb; Tue, 6 Feb 2024 11:12:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IF1uhuNRr54lIQ2DCXJHuhh9Cjo05LdPmZaDYM7b2BO4G2J2wFBd3XoVUC8QXeyNl1MInk6 X-Received: by 2002:a17:90b:384e:b0:296:5e20:48bc with SMTP id nl14-20020a17090b384e00b002965e2048bcmr559284pjb.10.1707246771487; Tue, 06 Feb 2024 11:12:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707246771; cv=pass; d=google.com; s=arc-20160816; b=k5fxRecje9bpf7ILbnefJW7e0v2hhzfCZSj6KOYXbWhBcmM8o6ONssp81wqyg61WJO /45m0lJL0FreuTAYCxfpNL9zakV1b7pVPBguf/AwSdFFvT2SRkehBdASQgGVPczGuIpd HpqUzkyeLVkZC9ob1p1lAzNdBkoW7GcBq0eu6kToGfyEigikgx4a2vZnsOrAqo5Goeyv gonP4L9USeJ2aYqb82g3JMBWseVyuBk71Q3+DHyEb0TLWEH+V7yiEbQ4JlOz2ArvqjXI /SFfUlwFtX0KQJjfTIE0MKXsBIc4XD6LnmK9pYeY4sLqNimja+vsx+dBBOwD6mNKawj4 TTkQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=dkim-signature:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from; bh=7Z+f/WZ4DkXoVZnfMaT27NbYFoy33khw5gBrGUb/KKw=; fh=7r+KiVbLb4w/KpejXxb31hm2EOt9Z6HO7pK9bFP9aCw=; b=zW3FfgMq63lDIoT8NUpxUyrPQi77gi36MmogpMPm+BleXJjbwUPCtcO1kH2f0pK3+Z JXlYO6EbU7fWeEOZHobFv9vFKuc38Cx/TXrnEThWqGNFDE/R8WolJzptQRkyp8h0jBP5 JFN+ruGuDeE7iJotNPPZ/zxkaI1G+8sPmMpx1NItFMLE9CvEC/WMW/H5nYgtOPwEuHgE HkI0fV+UpuTzqjzXW55mKrB8H/NsTphixl2cBPpX4hyPxWAuJImnHF0AlwOeMVq03UCh 27pv7tx4sbt0jyfIUW70nmh4BTy203zacXAXwxL0yK+/1ncuWgd2PB2JQQU9wWRlVcYY Niqw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b=E8H30nIC; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-55535-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55535-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org X-Forwarded-Encrypted: i=1; AJvYcCUQUsXIvsWc+YYlZugt+0icWF4FiluOEOt7YhML1JQtLoCPh4Rn14+L1YYSmb/u9e+5q4LtQXWIj8WIYDlUys9xAYVulw== Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id v20-20020a17090a899400b00296a1d0ce70si1517127pjn.18.2024.02.06.11.12.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 11:12:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55535-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b=E8H30nIC; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-55535-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55535-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 0C30DB231AC for ; Tue, 6 Feb 2024 19:05:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9EA5D1B947; Tue, 6 Feb 2024 19:03:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b="E8H30nIC" Received: from a.peacevolution.org (a.peacevolution.org [206.189.193.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFCD71B803; Tue, 6 Feb 2024 19:03:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=206.189.193.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707246209; cv=none; b=MFm86Tu8mpi+uULjsMCYg2oKhewYjTKVzUEfQPmBdechZBWgDD1PLunyKY2VGS4HkXjqWanse1B+XUmQo+yGsZuK/vP/2Bc72EJp7QqzVgN97NhQv5xtC0aLbYnCNka9xKF10KsR9NqK7RuVlqUTJ6RPhD2ZUd74j7d2SgM9IUE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707246209; c=relaxed/simple; bh=7R8s3dS4oPzpvS/xucheAR6yleyBZvEtG5Mu/F0LqNc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hCaXPeV0zVxmKL99j1kjj0xwV1Nmce7IIFBYkkm7rvh7eacBPLiA8AljmuPUIgyLXWTpoLOpkLfnC7ZUCAJgtjdCiU8ef9kp8S1CTt7XQvTbyqCL7fyB+pGx6Y+260m6RoMMq+xixYNFuEDnJ58Th7wrNcKg9ANC7TdbXidNpnM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org; spf=pass smtp.mailfrom=peacevolution.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b=E8H30nIC; arc=none smtp.client-ip=206.189.193.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peacevolution.org Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id B14B8465FF; Tue, 6 Feb 2024 19:03:25 +0000 (UTC) From: Aren Moynihan To: linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, Jean-Jacques Hiblot , Chen-Yu Tsai , Ondrej Jirman , linux-sunxi@lists.linux.dev, Lee Jones , Pavel Machek , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , linux-leds@vger.kernel.org, Conor Dooley , Miles Alan , Samuel Holland , Aren Moynihan Subject: [PATCH v2 4/4] arm64: dts: sun50i-a64-pinephone: change led type to status Date: Tue, 6 Feb 2024 13:13:20 -0500 Message-ID: <20240206185400.596979-4-aren@peacevolution.org> In-Reply-To: <20240206185400.596979-1-aren@peacevolution.org> References: <20240206185400.596979-1-aren@peacevolution.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org X-Spam-Level: **** X-Spamd-Bar: ++++ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1707246206; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding:in-reply-to:references; bh=7Z+f/WZ4DkXoVZnfMaT27NbYFoy33khw5gBrGUb/KKw=; b=E8H30nICUV7C40BRiCbC6jW+dZaE//BwLh94pzcLV7Kc5gR2epg5O/RMLYX7l/sMytqls7 ix5lHv7U5TFFagxV1lB6MT2wn0s2z6rmXHNYaZuSILswCDEp+85E1mo7R8MZeZOrMftTBH AB0U6/So6MjmyopbyRqd/HJHIDjPvNY= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790177990528526379 X-GMAIL-MSGID: 1790177990528526379 The status function is described in the documentation as being a rgb led used for system notifications on phones[1][2]. This is exactly what this led is used for on the PinePhone, so using status is probably more accurate than indicator. 1: Documentation/leds/well-known-leds.txt 2: include/dt-bindings/leds/common.h Signed-off-by: Aren Moynihan --- I can't find any documentation describing the indicator function, so it's definitely less specific than status, but besides that I'm not sure how it compares. Please ignore this patch if it's not useful. (no changes since v1) arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi index e53e0d4579a7..6d327266e6cc 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi @@ -61,7 +61,7 @@ led2: led-2 { multi-led { compatible = "leds-group-multicolor"; color = ; - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; leds = <&led0>, <&led1>, <&led2>; };