From patchwork Tue Feb 6 11:50:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 197366 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1488464dyb; Tue, 6 Feb 2024 04:05:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IGp3blxD40O93KUdmJwqJT32zBmyYyLnpKfIWlxODCioSHrGZ6SwZZZoaY4OeZeEHFr3X50 X-Received: by 2002:a17:906:4558:b0:a38:3db5:a846 with SMTP id s24-20020a170906455800b00a383db5a846mr564332ejq.67.1707221101742; Tue, 06 Feb 2024 04:05:01 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707221101; cv=pass; d=google.com; s=arc-20160816; b=ZzLaBAILlLTA/6rNPkfL+nl4PKLno9ftQAa08TQplE9pdk4yT8SdYEPb0b+l2a8FUO 88i+hyM0iD731UZgLvb/ovqjoeFkaRZGW8sZSns9e90AI46ubx0dddaREgjkpUaawgyB jI3WQwcSIMjuAShhjDuenx20BKGXjLIamb5/dPTSjEG+TtXS8KOrdskfiT4ql6LVLLQw LFrL0dv7HvnYHTOi2g5TR4EWB5BhbNVwpmB8I4tKprP6l/TlG1J1mlT+X77rWJaeIygp KkexmT4gKPeZF+bFkBFYN7YcweDi6LZjTGmbFpe5IwBsXBD2IjWtW2S11Bz63sZhTP0o RvxA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=iYNUifZdSRo+Yp7HFzuhxHtZjGlzamsP7EmAKufyL/M=; fh=wmXC2A6aJfDmsP9WvL3NEXX0VrksVKTqZctQSvpjG+s=; b=sPAFD/kySXL6RcaQc7NwrEcJ9TSwnJJEffX8u+vJogP99liz09AVYp1zcRPW/LNbGc FgXGyWBValV0XDfHanpjvyZHVk9WejyI7lEhR9RURRnCHy6bp5MHD3vmF+qOrZeXLdm6 SIywgF1EalRKtlM1fmHltzSB5RT0lUE1B2gjKG0DQG9T7u0b8jZtuwjLher3MRVjq6uD WmJRiLDPXgmY+rshF/mRKCdOqOjd4j360MQnTvMeoANTgY6QK2oVCcbNzzSMzfG28DWN hg6GbJ81bcF65bU8IPeZMkzLO4L0CT1yLxQH+PkjvoyzE6IuTg6r69x0Bjv6lr5u8vuI fJNw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Gru4W1hU; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-54838-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54838-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com X-Forwarded-Encrypted: i=1; AJvYcCVtrD6TOtiuSFwKCFyGaKlucu8om3jjl/XH1407yENImgTe8iBD8CCCANfX/8jqM9t6EUmt3f1Sq17kerAt0qIpY49rjw== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id d8-20020a170906544800b00a381e72bce0si717110ejp.694.2024.02.06.04.05.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 04:05:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54838-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Gru4W1hU; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-54838-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54838-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4879C1F2540E for ; Tue, 6 Feb 2024 12:05:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 564D9136660; Tue, 6 Feb 2024 11:50:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gru4W1hU" Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2B2D132485; Tue, 6 Feb 2024 11:50:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707220254; cv=none; b=UBsEQIaLPT6CQg49wsrUdKEI5W6PxYBFMI1rRggeLrvxUMUDRJHveiqQ/T7qHxx3fRBDPiHaD8PxL7QHsC2/rSn76Vc9DBTQSJ2zu63ANev6gtfrJgC2S+ujXLEh/lln6Si3PnG3CQxC0G2koGnAoKgLuVxiqyaj9t3INKZB3xw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707220254; c=relaxed/simple; bh=MXy0vLxc2auHj0tkkF/yP1Sf/E3BfLaVPsdnJde3zb4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=qE1XQI9ILadrm//8XzMpyL5RL3H2PRmoOPHHFfQdBIvFrJVwCjMpsuJEpJxomYSR/bwz7WZbYEYOrdsTzN2zUNxr9Nw9kfANFLrJeO2Yh7xtlELCebN5qbiuYQxQ0FdhSeGD96wCw7s4tI+rhxaaF5oE0cARKJIflQR04vuyYeY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gru4W1hU; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-40fe2d3d5cbso4179285e9.2; Tue, 06 Feb 2024 03:50:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707220251; x=1707825051; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iYNUifZdSRo+Yp7HFzuhxHtZjGlzamsP7EmAKufyL/M=; b=Gru4W1hUDolSgdXYp7Huhx8KaacPr//YpUuNEXbUSs0Nv4IHDN3hu8CH0sl6Wkd8Xe xrEHXjnVeNbRHmLSekMS5eycovbpT6lXr9iaY/NVcHK9cCbjgmaqQZfof0VjWaBqPniR jDwvIfxI27uF8pjAMBiOXcIK+ygyTKJ1o4KOI+ZMdvykrH/IbpnSi7FfcHiuJq75bcf7 VRIF/UjFXcH9VwpQAWoLkVEMaRJfupuYsk8lqOqWwuWAawk2gFvPu7pKT1G9dnrupRZ2 9JSI0Kqd6KXd0jfAIdgwsI2qR+XQ2zHJ5K4EOWcdVc3dso6xudXukZvyoBwLjmmDY6DD Skdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707220251; x=1707825051; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iYNUifZdSRo+Yp7HFzuhxHtZjGlzamsP7EmAKufyL/M=; b=E8028nREsVbK3fd/MTkgKfr8M3pGlQVM9gMV9ypn2+YiCEQWQwYtqMmTUmCJwPj/Qu pWsI6hrLGUGZKRvsM5ic4bPLcnnKLyGhqF1gzjFnDgStQR98iYepTjW/5+6LTf9uD+c+ ebo0v8WYJqb0WuNe7zz1iD0QQsgPLv1YmQ9J7XWiJWZG/8x9M9LfVH4YmqGM+VtY7VX+ Cox62CuycVAf/LU8v370dqT1bETnraVKJyG+3UVP/iqKQuGWw6GWYHymJdqyPBTK1e4L eR7b5c7cgr6QuoMEABju9EVeTbnVr1nDUFs7tN3KN3RjPntHN8m2WORiZfTYAaImWRcj PpTQ== X-Gm-Message-State: AOJu0YxB77lk8J3v4uuA4SK1Nu/kw4GJSZfF3UIojEoy8PrtmvUPrM5x d/2WK27Y4w3ZS8nJMEx96jXgy+tUPj2Eq6yo6hfdKwwRtyuEqwZM X-Received: by 2002:a05:600c:1d12:b0:40e:a36e:f0b4 with SMTP id l18-20020a05600c1d1200b0040ea36ef0b4mr1883162wms.6.1707220250869; Tue, 06 Feb 2024 03:50:50 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCU+lQuXEmJWPrGnLh06RNXzlAqm3JldR7mVVhTibhNS0zVit9eFqgcu/gGGuMIDTxX5GPSoi2vRxt+EsFWzjptK1OWcPSAJBe0wgmjP3Yutig4j6+MCqMsp9FpLE5GD4yRi2gJ45H0jKuwq36dsKO4BPmBqjDEgno937X9bsqXCym+48uqDjkqbI+7cPegU9CjlaOQhvrn/H0sOUWRsrWfAYwjhCGWriYrNAEeDOJFCJGoeJOAV3V6p6z4Hxr76CZNmcBffHdqBlGIgm4A/OzQmWAr3lLB5ZfJ88xVMf8LQSncewG3abUXPSXCH0CSmTXTd0MunxaVYUyaPYNg= Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id s9-20020a05600c45c900b0040fb44a9288sm1766218wmo.48.2024.02.06.03.50.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 03:50:50 -0800 (PST) From: Colin Ian King To: Manish Chopra , Rahul Verma , GR-Linux-NIC-Dev@marvell.com, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] netxen_nic: remove redundant assignment to variable capability Date: Tue, 6 Feb 2024 11:50:49 +0000 Message-Id: <20240206115049.1879389-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790151074331387516 X-GMAIL-MSGID: 1790151074331387516 The variable capability is being assigned a value that is never read and is being re-assigned later. The assignment is redundant and can be removed. Also remove empty line before assignment to capability. Cleans up clang scan build warning: drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1189:2: warning: Value stored to 'capability' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King Reviewed-by: Simon Horman --- drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c index 35ec9aab3dc7..51fa880eaf6c 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c @@ -1186,7 +1186,6 @@ static int netxen_p3_has_mn(struct netxen_adapter *adapter) { u32 capability, flashed_ver; - capability = 0; /* NX2031 always had MN */ if (NX_IS_REVISION_P2(adapter->ahw.revision_id)) @@ -1197,7 +1196,6 @@ netxen_p3_has_mn(struct netxen_adapter *adapter) flashed_ver = NETXEN_DECODE_VERSION(flashed_ver); if (flashed_ver >= NETXEN_VERSION_CODE(4, 0, 220)) { - capability = NXRD32(adapter, NX_PEG_TUNE_CAPABILITY); if (capability & NX_PEG_TUNE_MN_PRESENT) return 1;