From patchwork Tue Feb 6 07:51:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: claudiu beznea X-Patchwork-Id: 197235 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1382879dyb; Mon, 5 Feb 2024 23:52:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IE4NOM6xl7Fib6txJ9Sk1ILGhq3lL8aIDWhF4jyJpdhwjnYBCyJ25ufe6nGsWW8Zae4fUkJ X-Received: by 2002:a17:902:6f16:b0:1d9:1b80:8799 with SMTP id w22-20020a1709026f1600b001d91b808799mr770465plk.41.1707205960604; Mon, 05 Feb 2024 23:52:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707205960; cv=pass; d=google.com; s=arc-20160816; b=c/bavWNsL+lBm31NRt2YVba5/c9FAW1U4cmKlAROflHi7qz5EhfTbkXzyzNk1dg3DF +3xw7ZlIdLdFtaFDZ4pyxcSeLZDna1BWFrcSKu3vSkqxEAq4OzECnYQfFTGubjPBjkRO FNU/VinOWEWd1vRqUSj6PvzK+q9BP27zp+5bcMtNV4yW9x0Ht+MXsX572fxFgVpDNCXQ wZbkTHJ4nhqSubCxNqHPX2ty3Jtvz2lNuhq+OG4FAxsV6eknG/bVB76Ck8GMeeoGOT0K BLahCQZhNL7CJlvDOCXVjUQOCD9RkLjrCkfgbWTLYoKe2mjt+0MA8f8I1YwZcSOrR5A5 ilLw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Mzvigf2PQ+mn73kQfz5blaJKcbcBkovCXGS/Q9PyNyg=; fh=mjHmYNFreusIAbJ0O/Vcny7GjJegzRtW2z+XyHr7jt8=; b=E0ZuIRvsPcUqiK6xYg6SGvhuzu/wcilCbY+fgudgdqC6MtN6+FF8KMplCMwMsGCDdc efVzbZApdhkXjny/wPshGYuIbKmnO8JYsOV9+RIQsE7y2K8CVPzL8GD9F/P/Kz8zAsuN aU8pIjPUvrRHZ+LEj6AzB9yjgCVbyNot7D4AKQAsnOtvztXibpOUKVyUicJUEvrbKJQr 36+hkkjeWXAqwehOyXQWb8dmMGTau2Q6zFJczqqZuWHn2QMJemrUe9ERqM63xmqbZ2Lv 6av7RmRNL2gogfCSM1z3FjIMD+1Nq7jEccc5yBpVh0QEV65OOtMwgBUaCeXTBUY5HIRx 4Bjg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=AiidtGBs; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-54439-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54439-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCXHapXjovlZy67CYAqoeQ+flrngzYAc6MG6Sa0VLPskURBJBHOGI2xvmrVqcOnFZ9OBpTrGo+/kq3wY8IyIUH4jQtQluQ== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id l13-20020a170903244d00b001d8f10a6a0asi1269942pls.353.2024.02.05.23.52.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 23:52:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54439-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=AiidtGBs; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-54439-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54439-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 644BF28470F for ; Tue, 6 Feb 2024 07:52:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AA5A312B151; Tue, 6 Feb 2024 07:52:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="AiidtGBs" Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0950412A15B for ; Tue, 6 Feb 2024 07:52:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707205930; cv=none; b=IN9E/n+temv9/xpQEvgnaBFt3cbyYpfaq0AcohjbwwSfDO572FJTjNUzEwMd37uIdjrBOE3p/BqZ5tUdErf89H9mc+TimfLtmbDqextlN/gikNAvURlbyL0klM/YB+0IFYtBRas9uAr+7T3C/4Q8YvIh4xbBZ7iig0v0WK5HH/w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707205930; c=relaxed/simple; bh=akjpDdwtIyoD1uIaPN7w8Pv+xKXWfTjc8macEXk7Atc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JagzhpzKRHddiXfIhoX1AKmfghIt6NYERjd/2vQuvcfuLRJnRNuxPQ83T81d1VRyV2RjCZWk0jKHXSSUnZsEPVu1I/GNWKSRXdNP6dE6ipobtZFYdn4rq/KVRhi/v5oEzeGNApu7wbUhAGOg9KCjoL+SvHC5ABEPSnmi1BvYeek= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=AiidtGBs; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-40efcb37373so4686625e9.2 for ; Mon, 05 Feb 2024 23:52:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1707205927; x=1707810727; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Mzvigf2PQ+mn73kQfz5blaJKcbcBkovCXGS/Q9PyNyg=; b=AiidtGBsq9pEPyQ3ITaghgou7JHIGXJ5RsZCAuMlwS+lrO1KopLMiJhffVYiNOfMD5 s/06swWOkRvbS972h3lM7ebrJTX3dS0jOnu01Gmuw5cyNW2K+F9OT9tVROichgkEbP1/ JyunytLZ+trv+YJ/lNQ9GBv+3hvmFIav+E2mTYV5QGENKQDZnM9IV6zlWeqj9ap6rUID gTrMYePVrKAnmyOfdE88YKjdCxjBTPHtDfphR4JeCmVTKVrXQX2HYPoMtLlqZKOjovCO dmHEDTiQUMmy3pjec8jZXp1EyhX9OTzSZ5wzbzH3Q2grLqwJVQE6ya785Fkg6ZWlcTp3 oLcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707205927; x=1707810727; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mzvigf2PQ+mn73kQfz5blaJKcbcBkovCXGS/Q9PyNyg=; b=uF2MKsyVqUSsO7KH4yhVFOgxOs5BpuTDdiUzCPF5TRii3f9S1PvrDUZcfzGYqt+dt8 A7HX7HCQcan72ZN126bIRHuwRJ3Ew5IVKwbxzWcvAqTXYR8uLOnra6wpD71+PifEa+73 wxhtBalslNv7CvyJDDE9Kt18DflgV1MhFzkhA5loczLkVA73m+ikSbLV80nkflAjxepP ZMQHp8altTExGQksN4a+iKMUs2DVQODxljl0yKVXsrn9N1+zOTPEsOSARBn6evqP7wS3 E7ee8xa/NyJ+HndXqpZQ+da8aJGcHZ/2vJum/4XPJRsTN+3RPLj6oDAFg0oBWkVxcOA6 gZug== X-Gm-Message-State: AOJu0YwXq7ql4ucr1Z5Zlv0g8LNmt0ApQKZQUDt7qe6Ei5xyIi4Q5Wnf s9EUTw2SOYKz3TYFnD0JQkp5adRR3nKFhAJlUalf0P5Zq2C6UbGo6ZUdulg94C/JsdX9ZnhzFpQ Q X-Received: by 2002:a05:600c:1390:b0:40e:a569:3555 with SMTP id u16-20020a05600c139000b0040ea5693555mr1526799wmf.35.1707205927176; Mon, 05 Feb 2024 23:52:07 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXKs75+Ee86KfuDf50VytpfGApvjqYh6WuMhD9JSl5i8ZjQztETsn5A76SExy35z/BC8FjmP2Q3IkLfWHAbf4g/PzjU1iZpeOcOgd0KMglZxPFkLs6xy7iSh/7qcRR1dHoq3lSuJA9EOa9ywotoc4vAPl+VdiFUzs0I1rFNbpeneRKUg/uPAQu4f6kGERTbpnP0HrOhvAWj/0hPDO1Of8J0mcvd6DPy1I730XjD4sn2oKDiO+ha4zx3F2j0jxCWogAqUPUkB63oQnsCdmwnAgDZy28Wgz+k8vnmWPLu2V/keUh4WTVB7UJsk5RQbLx7Tk9JN1lyTnrFzMPen6o7iXVNrgZpNSLjxukXVXgYD4OuT9vm3qL0ld0v/45c03YwG1BrSEHQiy0Sy858+P9IND6a54stNbWp7quwWByK7E25HXkUB/JRdnCbkXvKVe/46pvcdML/rIO01UNF4qEuQKByWuocwQFVwgPjAoGupoSDzDiEJEkvTePY6iRPQTb5P8Ie3d4Mx2Apew== Received: from claudiu-X670E-Pro-RS.. ([82.78.167.154]) by smtp.gmail.com with ESMTPSA id j32-20020a05600c1c2000b0040fbad272f6sm1106843wms.46.2024.02.05.23.52.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 23:52:06 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, magnus.damm@gmail.com, biju.das.jz@bp.renesas.com Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, claudiu.beznea@tuxon.dev, Claudiu Beznea Subject: [PATCH v4 1/9] watchdog: rzg2l_wdt: Restrict the driver to ARCH_RZG2L and ARCH_R9A09G011 Date: Tue, 6 Feb 2024 09:51:41 +0200 Message-Id: <20240206075149.864996-2-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240206075149.864996-1-claudiu.beznea.uj@bp.renesas.com> References: <20240206075149.864996-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790135197274808607 X-GMAIL-MSGID: 1790135197274808607 From: Claudiu Beznea The rzg2l_wdt driver is used only by ARCH_RZG2L and ARCH_R9A09G011 micro-architectures of Renesas. Thus, limit it's usage only to these. Suggested-by: Biju Das Signed-off-by: Claudiu Beznea --- Changes in v4: - none; this patch is introduced in v4 drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index 7d22051b15a2..f6cb63a0d889 100644 --- a/drivers/watchdog/Kconfig +++ b/drivers/watchdog/Kconfig @@ -910,7 +910,7 @@ config RENESAS_RZN1WDT config RENESAS_RZG2LWDT tristate "Renesas RZ/G2L WDT Watchdog" - depends on ARCH_RENESAS || COMPILE_TEST + depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST select WATCHDOG_CORE help This driver adds watchdog support for the integrated watchdogs in the From patchwork Tue Feb 6 07:51:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: claudiu beznea X-Patchwork-Id: 197236 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1382974dyb; Mon, 5 Feb 2024 23:52:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IFVDzPxL4YynlmY/3MZxFgGoZUlGiVAPIlhCb+A0xEGP8AGnpGXtWf4BVlFtK04TRdDFcU3 X-Received: by 2002:a17:902:d2c9:b0:1d7:5c60:f4f5 with SMTP id n9-20020a170902d2c900b001d75c60f4f5mr1425208plc.16.1707205978364; Mon, 05 Feb 2024 23:52:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707205978; cv=pass; d=google.com; s=arc-20160816; b=PkyEdqjf+Yp8j1AOivcLZAJK+uJ1taMCsCS+m0cZUzM4YNFZq6vVP7vcjwbB1cbEWa xvMwYKdWvPOJjIBle1UEkZdr21INdq+22oxFtj9eTToi4JWnKlqDWQMM+RQ46Uc/QnXi 66dYNAZY9om8xu1br7zvs0h9mvrNiMtvt8K1jSYAIbKkwBJY2HCbyrBRpQk+LF8EBAA3 izM5XmDhvSOLH4gw5wJB1M8C5GZ/SiJ97scwdFoxMwp9rreXI7wS+kei/kMl6onx2fVa gPXWVdAE2BzRtm5AwRwRlALQBKaQvzrqyZB2BJE+VjjkxjlPaa7UjJwkqCtAK+QeY+dm ju5g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=ntdF34/qM/GrD9bNmK0Jsu4ivGsCm/w2NOnD9IO/AYo=; fh=Rev8PlU52Ix5o9mb9U9Fl148fxsv3hNGBhlFx7ps/oI=; b=hh9NyxB0YorO1yu9loCVjsGTm2QzkyeiAr3TdlfIvgWKWck1H4cg2NOq6JRfnjs02b wrsghnc7G2EfgleNJPmm6Nv+wWC4lIaAdWJ/dLOSncUxYUJKPZSYYK2RTxDTNCiOcB7U MS6pk/ua//kaUXUyvIqKmbQems3y2u+4Xl/MSX5X2gfQwLXregGAQk1b1Al2Mlu/rLJq TJ6bN7AHOqajDxYayrNtqbTZ5HEPpLeujbT4zbC0/AsZv4TwVrGODjoCL7nZlj8NuLO7 3dbpUm8tFCWDJmkogzux5jJ2fc6KtgCRbA8RPJ8kniDMqyLtEee6K4BO6+qulLQaKoj0 c9Gw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=OvbyAupr; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-54440-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54440-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCVgpm9RkKQbhSWK9SdMOcITfxGrJSJMVJWXaXtcm7ng2nOh518dZ2ClmZCD2fNpmQMa+TQ9VMgRy6tbE+cGDnCXDvOxkw== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id e2-20020a170902b78200b001d9c51367b3si1199100pls.398.2024.02.05.23.52.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 23:52:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54440-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=OvbyAupr; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-54440-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54440-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 285AE28474D for ; Tue, 6 Feb 2024 07:52:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 79E1D12B174; Tue, 6 Feb 2024 07:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="OvbyAupr" Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9788D12AAE4 for ; Tue, 6 Feb 2024 07:52:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707205933; cv=none; b=sj2FK6XjZbqfIZ/tO9D2vt3u9WNzW+oHimkLCZakOoFMVtClxTvy2yLVyG0552+UbzyiWBnF4sbhZayngBEryqlGHZxxjJbXQFZ9bqi8PdqL2LWW+LAOWU0UrCwOZ4MUrs7TG4PHURWuN1Bnei7h+4JModbPTv0LzYuXTTypaOQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707205933; c=relaxed/simple; bh=B7ZI2SD8d3W5zxWFuLoPUdZsUPHlZgyVmcI9/1dywKA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HkHO90h0jzmg5Or5G+fIHNYreoHVtx+6lz7d3+kLo5AYEwuwtfGPrbSYhqXEtD+C+Y4lRowzqXkDuh/sq3fPEiJIyA52PPajpPfDOJ1Y4Q3U9Vli/NlFL/wHRkCzXq9Vf/N+WT8dVNZsUHdgkZwieT5m6gB3QPE4IanJ8WXKTIw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=OvbyAupr; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-40fe2744e5cso1346755e9.1 for ; Mon, 05 Feb 2024 23:52:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1707205929; x=1707810729; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ntdF34/qM/GrD9bNmK0Jsu4ivGsCm/w2NOnD9IO/AYo=; b=OvbyAuprpVJCXudBf5e1lFbgf93J/44o60/LYZtlY0loiAT0GWZeH5gVJw41MPAAJp D81Q2boYZeoGkVBuWSj9X3nqWHJaTubCPZQA4d5W9q7EL/Jdz3UHJhq47iS4fetl2cHW u+LrjxK/Hb/Q7pqltMa5Gzr3Rk2nmKqRM8afDew6rJDlee/PW2LGW+l25Q9UChFUVIP+ Hii5lIkRCvKPNUr6DrtmnUGgv7qoJVkiBYwtt7WrUxW8dmVhm1o0dmtORQCskV2Bz+ec Awag0lp083hqbk0JfgSA4mEsRdMo87wP8sdDO9LobOTY4MIo79FeoXqVBef4F6LVNGaN Wf2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707205929; x=1707810729; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ntdF34/qM/GrD9bNmK0Jsu4ivGsCm/w2NOnD9IO/AYo=; b=Ex/m5FgxtJtTEOCUxQt6x9hfZoQJhkt+9ukSrTTOWEwQlTTRnHwAaM1o3Su7aT0Wgx sdnitwRFDjyrOAnvycZdvzaVWvpGph6RDD/P4NwXPRCbReInzMwkPZj/n90YQR4+SqrQ PS2h3cne3rBjP8JYeuTfvM2nmbKZZ3Bz7BEuryygKGnUU0KgHeQ7Z1OqLwFFAwuSz4IG lmEioPlLe/RLgWNP1S141IPL5Q6UtxdZrzNkHN5SMNCdg5ZLYxlx16Ihpcr+4DmVFuSX Ji05mS3RgODw5+i5oy55lNbPG3aSEVpTP1+0wj4u1+Id1YAHWtobrG0Mx3kUgQi/YjPE fXdg== X-Gm-Message-State: AOJu0Yw+FXlHhz8XFVM+PqjKRwGu+VUa0jIhSbRYE0Z35QbH1CtcSyMl sGH/h4hJMUzTTChtlqLbxjnSKwSZSVYEX4h7OpGfiCHbdfx2ZnVbsbYBhiHFeJI= X-Received: by 2002:a05:600c:5116:b0:40f:dd0f:e7a5 with SMTP id o22-20020a05600c511600b0040fdd0fe7a5mr1451761wms.11.1707205929336; Mon, 05 Feb 2024 23:52:09 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCU3r8ZXyDBDwRKn/0GcTalVwfTDivewtn3VP+NJWfVcPsHXTiHxjkG/cNLNZfYH0yReTKMCS6272CmBry6K/5Hpmq6EW+mcE79JymttnE21NbTIsU250BcsM18j4fPu/xBU8IF/B1mwZ4uB4ep0SRJuGXxGJ0FBBnZGRsR4bYegXcUJqpPx52jVPrq2iSQYv4J25WXfw7OfkdGMiHm+uBC58RCYZkCGwmsOpjIpkNvBHeE0fhEeCXag3fnZ8Fl0vPWu6UkrAv06PIuBg84fH3k+BNahKyeZcEavGJw3d9vblsvJWBMwfTefl4LbcgmBh0U2t/zaP4TBuRbjHdCm53wuxnIs4gYTAhnWGlJcbynB4oXJ+sO40UP/RW91TiFbpQo7O0pjnws/Kin1knNJORSOUeo7VqXgrIN//hBpzlNHuMu1n5VezFSLF3qQNhBecWPBPbsP/R2tiqcUW/ISz2XpZlgGeGGM7dPNnFVnokOHW0jDN9JDp5zaW+RdrmlvgyTVoI+pkvlGOQ== Received: from claudiu-X670E-Pro-RS.. ([82.78.167.154]) by smtp.gmail.com with ESMTPSA id j32-20020a05600c1c2000b0040fbad272f6sm1106843wms.46.2024.02.05.23.52.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 23:52:09 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, magnus.damm@gmail.com, biju.das.jz@bp.renesas.com Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, claudiu.beznea@tuxon.dev, Claudiu Beznea Subject: [PATCH v4 2/9] watchdog: rzg2l_wdt: Make the driver depend on PM Date: Tue, 6 Feb 2024 09:51:42 +0200 Message-Id: <20240206075149.864996-3-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240206075149.864996-1-claudiu.beznea.uj@bp.renesas.com> References: <20240206075149.864996-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790135215752653347 X-GMAIL-MSGID: 1790135215752653347 From: Claudiu Beznea The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the clocks are enabled though pm_runtime_* specific APIs). To avoid building a driver that don't work select CONFIG_PM. Suggested-by: Guenter Roeck Signed-off-by: Claudiu Beznea --- Changes in v4: - s/ARCH_RENESAS/ARCH_RZG2L || ARCH_R9A09G011 due to patch 1/9 Changes in v3: - make driver depend on PM; with that the "unmet direct dependency" Reported-by: kernel test robot was also fixed - adapt commit message Changes in v2: - this patch is new drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index f6cb63a0d889..27e11ea7eeeb 100644 --- a/drivers/watchdog/Kconfig +++ b/drivers/watchdog/Kconfig @@ -910,7 +910,7 @@ config RENESAS_RZN1WDT config RENESAS_RZG2LWDT tristate "Renesas RZ/G2L WDT Watchdog" - depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST + depends on ((ARCH_RZG2L || ARCH_R9A09G011) && PM) || COMPILE_TEST select WATCHDOG_CORE help This driver adds watchdog support for the integrated watchdogs in the From patchwork Tue Feb 6 07:51:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: claudiu beznea X-Patchwork-Id: 197237 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1383042dyb; Mon, 5 Feb 2024 23:53:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IEEChn78xpYkkGwwEUU0pwTi/RFio73lDsIUbiU/LbzxxeWZOZRxZTuhSs3mVZ9ft/wSr+z X-Received: by 2002:a17:902:64c8:b0:1d8:d73b:794f with SMTP id y8-20020a17090264c800b001d8d73b794fmr750572pli.56.1707205999038; Mon, 05 Feb 2024 23:53:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707205999; cv=pass; d=google.com; s=arc-20160816; b=ck0+oDMXEot+ojSvw5JqTxIyu9jxIGbpmwH2KeVvSAOCQsnkg8ZYg5TVym+hWsKXB8 x/xe4cRp/QtTlcRWf7RQIoxivMzv7E9kngvXnBVaTlQDb2sDWIpvlm1BL/gqohbjJNVu iAt9wHL5pBh1yUkK2MYKqotBuOR7MeoYvGQEGE3JB3A2z+Fbty4EbeWjhlTYKuv7zTD4 0sm6obgpQUouQcwuUwOE1Ez3PBtV4F5Ab+CrRwTQFse2nLVMz9dkeRkXrEEQqnD/fM4y OdVRtDDqPtWxFtSeEIhuSY3po8egMDBneoPBw3B+3V7cmaUtymSldtGk6+Pv2QUkGzOS WUCg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Re6g7QbwuG7CNxQRWc79B5kKgna8Uj7zWIgOl3cniuA=; fh=F4Z27nolkXSqst4/a3CqgqufIvIsAl58UXB8zOFFTjc=; b=vdW/UwvcX4fcPnhLMcO1D91wmj/tYkhYv0gVQW7jGWUW6WZlGsyN0acFOg/R5SRIZL tVD7m0+mYs7VbYF0+qa7rN0/f9RBoNwBaP6QaFjskHRqBQnDQybgqlls1x3BjNMX8Htm 0yjSb3s63xfAvdgkgTFp5RpOEILTR0B2zBC6xPG+aPBGyfRM2b4aFtc8OA80oL2uhPEu aDrZctQXpLzcwjWcv8w7jYZPv17qRYcM25jnlPsHklklPGOt+9xKmAQpJaiNnuz/dgTB lWL681YN/McY2IS6dYn7SfhCc5oeIHP4E5K/3pzrhiWZCNFWJ45rfCJXjl/1fBBUL0yt avPA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b="cw0/9nYB"; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-54441-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54441-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCWdk3sd3vweZYOb48uKj6pjpvAGPMtGMNwd7HM6YEwv43iCushUMlZ8rf0LfKCnr6LXvUD9WgsDi232xJzPYqdziEqsdw== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id b10-20020a170902d88a00b001d9e1ab2acbsi159036plz.356.2024.02.05.23.53.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 23:53:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54441-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b="cw0/9nYB"; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-54441-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54441-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A9847284B29 for ; Tue, 6 Feb 2024 07:53:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B08BE12BF01; Tue, 6 Feb 2024 07:52:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="cw0/9nYB" Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 053B612B147 for ; Tue, 6 Feb 2024 07:52:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707205935; cv=none; b=Fmfhi5xCtaLVdAiLEKJwO4W14H2WgngWAhs6WP8n3+wDpUZpkA98M9W3KKiibza4VbeSBKm30v/057txudyPP1c/NRQrOqne8w42CdvSCPbadnOvGmGkavmsOimQ0z4ZNKXRGK+BPbbNqONLGhkRM/FAySmCpouXVs5k9tsMHww= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707205935; c=relaxed/simple; bh=iY4Nq0gmeNoMpaiXAPg8UyiEeagDbHOfI4LQk9pKbUk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=i5aEYWlwvebMi6JD5kjEfLCK8er9J2gPqV/kcUStvV82pkAkE7X6SPuRm+y7BtIodAnUp2VPu0a/MR6FECgiXal9fg1GeG681D5A5K4Bi/daLNY5KKno0LFURaDgmdqPrOL1gwrQQyBCEa6vWlEfsOLHp7s7TuT6Od/PJYGKtRw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=cw0/9nYB; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-40fc22f372cso41241715e9.1 for ; Mon, 05 Feb 2024 23:52:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1707205931; x=1707810731; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Re6g7QbwuG7CNxQRWc79B5kKgna8Uj7zWIgOl3cniuA=; b=cw0/9nYB6Rfto3zX2hu8hJXLdICVs2i/t5e6PmwC7rJJX4kyZMOenC/u3NTw3TXmzd 2Fo9coEi9cQtnsdW7dY13PVyjJ8ldEdkAK+JKVZECBJ4nm4TA8AykNe9nuFnu2JPKzDh KCJgMTAPfM1Bps+fWP5li08CY3EJhlxNYMLMf34254PWo2DqY4NmKkAHGyfNVONLIY/b hblMY6LMwN+smpMuHNySVMpxEUz/PWAZ2j6WU0SsdeqXz+W/bWTVIlMQz9cNRtA1NHOQ fL9MXWZumfzMyz8nx3qyEYPlArgQ/aVt0wUHfXnYOLn3xH6if5uFyM/iTb5G5dK46/+K ExMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707205931; x=1707810731; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Re6g7QbwuG7CNxQRWc79B5kKgna8Uj7zWIgOl3cniuA=; b=dliq5gNYIuSU8IUW+nV3PswznVrW87lv2GdSQLWwEh6Ax6SWkD3nDtXzAF5RVqPV7P n6QunsbKo/DUH2QAa134GtK+fDUN54dCgsC9VfhjYBwdiM0GiIUG0N5wgNj7p1HWgYfr RjmtLOrhLAVQ2N9Bmy98TDYGikH+5i481OQASt0BhW29h6v6wtWanHmuRKJ7EXHQys/x 1OGNVVuF4KO9pFS9KvGBor2EMlen8XwXZsdXGLsNuY4A9GeADVKkttZmGWjHZULdYfpW SF1TPSncJkunvpNbzXXbhhtkzfwjvOvFI/CtOkQwhbq+Lpx/3K8T0CQbxfeKQ1PmrWUD Jl9w== X-Gm-Message-State: AOJu0YwU2f+f3dsV8HseSIj8799hcw0hn2t3rCJFqcOHyAnTg5afvZ79 S6uE2PbAVk2TkPsCNHMfGW6mUGoNDWcewBkVDf6hZth97v4GrRQpkpz4fF4g/b0= X-Received: by 2002:a05:600c:3c97:b0:40f:cb0d:a44e with SMTP id bg23-20020a05600c3c9700b0040fcb0da44emr1034104wmb.9.1707205931238; Mon, 05 Feb 2024 23:52:11 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWoSIcqKjoanSWxwphMlxu7ln46eqk3ZHWmxw5kPc0ytMMrDj+G1cvjlpMW2WUZIONlpZR/K/et1+AFj2qjFc/eQgpImL6b+QnuA5cEKWB3RctoRIxxIOx3UrwqWVuwS26Q727uwOtVH4iYXd7VLVpcBuOp+z+nN00Veb74MnqJr7BybLLxb3vloETJMbb6R/lkqxQnMD6fqFsyCDNGMi0TmIHCAeW7G66sXigDahSIEaDE5zLLA1/LxpQs6s5sQL2+5Vjx+Kb1yLmUCSOgLBBwUldO7EgcCA8/qBXoQtuqlIqTnqpr9VT+yPNkKRhoXZrfMKpSa85WMZ0gx8crtbT4ZazCl91bh+MN3ofHl4xpc4ZCA3ndyHBEsHy9bKHpWgV36hoKI6kRukQmDmZSBCadvVFaI0rG4ZPJq1J6ckY++80T1RSlPC9XT5FDL0mLMOh4O5IKyr6MnvvdWHtvLM/O0d/gkLslCzdMizm8osF9ApW3CYmJ1GpBzGMtIUoZm/zGjpPLLicpYQ== Received: from claudiu-X670E-Pro-RS.. ([82.78.167.154]) by smtp.gmail.com with ESMTPSA id j32-20020a05600c1c2000b0040fbad272f6sm1106843wms.46.2024.02.05.23.52.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 23:52:10 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, magnus.damm@gmail.com, biju.das.jz@bp.renesas.com Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, claudiu.beznea@tuxon.dev, Claudiu Beznea Subject: [PATCH v4 3/9] watchdog: rzg2l_wdt: Use pm_runtime_resume_and_get() Date: Tue, 6 Feb 2024 09:51:43 +0200 Message-Id: <20240206075149.864996-4-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240206075149.864996-1-claudiu.beznea.uj@bp.renesas.com> References: <20240206075149.864996-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790135237509820264 X-GMAIL-MSGID: 1790135237509820264 From: Claudiu Beznea pm_runtime_get_sync() may return with error. In case it returns with error dev->power.usage_count needs to be decremented. pm_runtime_resume_and_get() takes care of this. Thus use it. Along with it the rzg2l_wdt_set_timeout() function was updated to propagate the result of rzg2l_wdt_start() to its caller. Fixes: 2cbc5cd0b55f ("watchdog: Add Watchdog Timer driver for RZ/G2L") Signed-off-by: Claudiu Beznea --- Changes in v4: - none Changes in v3: - none Changes in v2: - propagate the return code of rzg2l_wdt_start() to it's callers drivers/watchdog/rzg2l_wdt.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/watchdog/rzg2l_wdt.c b/drivers/watchdog/rzg2l_wdt.c index 1741f98ca67c..d87d4f50180c 100644 --- a/drivers/watchdog/rzg2l_wdt.c +++ b/drivers/watchdog/rzg2l_wdt.c @@ -123,8 +123,11 @@ static void rzg2l_wdt_init_timeout(struct watchdog_device *wdev) static int rzg2l_wdt_start(struct watchdog_device *wdev) { struct rzg2l_wdt_priv *priv = watchdog_get_drvdata(wdev); + int ret; - pm_runtime_get_sync(wdev->parent); + ret = pm_runtime_resume_and_get(wdev->parent); + if (ret) + return ret; /* Initialize time out */ rzg2l_wdt_init_timeout(wdev); @@ -150,6 +153,8 @@ static int rzg2l_wdt_stop(struct watchdog_device *wdev) static int rzg2l_wdt_set_timeout(struct watchdog_device *wdev, unsigned int timeout) { + int ret = 0; + wdev->timeout = timeout; /* @@ -159,10 +164,10 @@ static int rzg2l_wdt_set_timeout(struct watchdog_device *wdev, unsigned int time */ if (watchdog_active(wdev)) { rzg2l_wdt_stop(wdev); - rzg2l_wdt_start(wdev); + ret = rzg2l_wdt_start(wdev); } - return 0; + return ret; } static int rzg2l_wdt_restart(struct watchdog_device *wdev, From patchwork Tue Feb 6 07:51:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: claudiu beznea X-Patchwork-Id: 197238 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1383086dyb; Mon, 5 Feb 2024 23:53:26 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW3svEvj7R3fkOif0XQX1A5Q3pL4YpQ9EixPTFOfBO4xfAftNAG0SwGbZwx1cdhyvgLxFs9Ofw1LMfmbT/AZXF9vzqe+w== X-Google-Smtp-Source: AGHT+IErLemz+B7TgAG8d/dXg0H66366lKe62+LsktnyaMDEIDqO37vy7U3iWS/Y3LNz1/MlIwZY X-Received: by 2002:a05:622a:2d4:b0:42c:fdc:cd14 with SMTP id a20-20020a05622a02d400b0042c0fdccd14mr2402004qtx.32.1707206006605; Mon, 05 Feb 2024 23:53:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707206006; cv=pass; d=google.com; s=arc-20160816; b=qCHF/NTpdpew3RNAsBHGkmjmqBVWTWY7dWFE4IgJy87N6gWRApdB2RtUovvb6vruy0 XCwRP/95Cn68JhZYQUx6btl5JAuHPQ5aMKE/iQF0iTI58jVOx510YpQUOdpBUxTHuPGB LXqya5CnYU9Nl2sfjbHcJ8mZwQXZBjHoEHGtnSeaDFJN1tAC7MuJMHAV4/irmsZHmw0Y 5/o4LH4hgdRdIiEP/Rqq8QAidh67DLt6GEnNtadE7qunvpWlI1gPIJXOjCanWrTrmfQi y1rHRtQwhujLvjAqU1zBS5Q2wmLZlukREubG3tao+I0hYfgPML76Bj/zAOZXVdth3UCP 5pZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=5TQVsyURVXYWvZQZ0JKh4DsPsNlPoBBRywd6S3RYjkk=; fh=uNZ+2rIuVN044+f4JdnoDaRtT98Hsc6nLI4aOJmVdVA=; b=BQ/gRxigklvUew8rXBcBBY9AvtUdsBtq7KwLWQyf3p6ENc5pe5L9R5Y0nex3IsKuJX KaYkb1UntnrjrM6Rhf9fty3e0fu5+ckJIoFO8X0uMPLVlKoD+WhzfMPuy1Hx4zcMHyMe LOZEg/R6ULWMn6ztlEnAzJFe3aoHG4Kp4Tf93yxR9RV6643AJ/kgYywDIo24SDfPcEkQ ECdbDI/8CU6PbcjV9pSbdlpOIubf0NTcju7YjGL8+136I3qHy91aHAHYenlhxMBQ1fLc bTJvNLAb4w1khpRERuJlrEAilwiVD/p3aAtBfDaV3ues76+kxr484rY731YpEZqospOc cqyg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=V0FnSxEA; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-54442-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54442-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCUXlm/vWLDHwb1djacrzE7sO+a8p7NJTrt3GxaAJpPsMIYEOmtLqazYSWAk55HmmNOdBpSvAQ/AORmknusXwherghXFmQ== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d21-20020a05622a15d500b0042c10bcb12dsi1819434qty.356.2024.02.05.23.53.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 23:53:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54442-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=V0FnSxEA; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-54442-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54442-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2881E1C227B4 for ; Tue, 6 Feb 2024 07:53:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1407912BF30; Tue, 6 Feb 2024 07:52:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="V0FnSxEA" Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1237912B163 for ; Tue, 6 Feb 2024 07:52:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707205936; cv=none; b=ho80cj0Xg+bJrbXGQqqm2EbPe+1D9ER6bLsw8VIo4nzXKzfDvNAXimnd/kbe2h/NCPkiaFQArsAsETSTju+SIgLL1WRX60wNZQuydJPGvK3f/LCeaNRY1mMLKAe0zHFWhoSt+vNDXRovFMFsJ6Ys58S1M8H0wnzQgzZ/y5V+UPI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707205936; c=relaxed/simple; bh=mLelyBkyuyFverkkcIquXrmPZYtG0kwJVVl+lchEO+M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=TipPJ5us1jzbTFK8WT5uAIAn9J2c0S1sW657IIwrZq2S+zkGIbCnYAZlqKdghbNW4T26oCE2RmBG5svfGh8Kr/ZoHeg8ZYO2HAPcCkXL5J2mJI5pnxqobrlcjn0SG9jmJtZbz4VMIHVA/AXikqwhYE/0aEAEc4tHZOPHdncMcsA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=V0FnSxEA; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-40fe282b8e2so2808745e9.2 for ; Mon, 05 Feb 2024 23:52:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1707205933; x=1707810733; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5TQVsyURVXYWvZQZ0JKh4DsPsNlPoBBRywd6S3RYjkk=; b=V0FnSxEAO3Oiad1V6n+WZqKSePRiHD8ed24hj34S/yXhmwCtB8CrumKEWKWP24jN41 xs0EluvA89b+hOTXUw58eToLUfOlJdVbLJTwBohSx1FrlBCPfFZwZzrAHhpy4tPty9Dr JgICnQqlNXIudEgLJJevSoy6PjZtI68YgI3mJCw7CA3W/+vYAvgMQU1AmvROGJe8Jdxy XKUKM9MX1LXZJyZCJJ9dFLarBSFmI1m8Uvl3QWemF6S4G1FLEaCmcplZZ7TRbTxwbVIY IK7FE6NTCZoP7INepmxu2pE0KV3cVBWHoQHbP5Pc1FD6C+BKzctahURngDcPSVn/Yeaa FDKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707205933; x=1707810733; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5TQVsyURVXYWvZQZ0JKh4DsPsNlPoBBRywd6S3RYjkk=; b=ez5xCtOgb1Gqy+Zx0u/IFv/ZC6RKg2O+XNaFkz2lnsXOTqUZmIpgohHiftWmh1h0E4 urV1lSpccj1G5XkBmYIq1l2SqZR5Wcp5vIKuTPYBnSzhjR7csoKKXE1+d0MGt6ZZOoxZ xSgSYvtfYn6Ro9P3ylNutdq670YzAi4ZqOzCJDI+fFY95LOpuuh+nJzqjtMo2r/zCcGT 9cXEv8lEiKT/SI4RgrPpsJVgtslU6zru6BFvP2yD01siBkHNwrE7ukyfa8hHATnKcyHC s0yP+HTVeBOuYWlO3xU4X/XxNmUrHy050ZZkVSoWIxJJaL+10LmvIHHDBp+YiX0qS+CH /NlA== X-Forwarded-Encrypted: i=1; AJvYcCXwto5C9QNa/Wi8oXLaD7gBSgCAZKhcQvEdaIZcyc5Lu4U4sCP+ApeUs831SMoLY3Nv0oh8BdqGtOl0Ag/nJsHo5nhzxNjZisw507Um X-Gm-Message-State: AOJu0YxYe+LeOUEgTZY4Yv3M0yH4Kee4+FxK0hQyx5ROpn43LWEEJJeC Ub/Rrd5vZM0B+aEsOHTmgUoByOamR6pPLoZMshptRCDza1Rgn1UsbcjikvawhQY= X-Received: by 2002:a05:600c:4449:b0:40f:c234:1fd5 with SMTP id v9-20020a05600c444900b0040fc2341fd5mr1076050wmn.11.1707205933334; Mon, 05 Feb 2024 23:52:13 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWTBSd5+O4aUmf4Rowz1MTAnp5CW/gR3BNlTYDsW3bFIEXIIuVfmkNX0BHBYghmOuE5uYwOwTZVJ4ZgqPzimfIf4g+0GgFcPQH1dQBpp27HAsfnwexE+QoDr7sliyZdo+lc3r8dDu+0IALif+/5q2eEHJRQ6LwdENU/MWUQfNx/s8WHXYfvCBhgPc6BNKIbxBkeZfRWZsMAfp9MEvNJH8lcvmrjdxm7LRR2bSTEQUYIctobGDxcY5+R/bLsp6rWO+YUylv3P0/NDP2stnoFdm8D0Jz4c00SiIYJk10aVOvPxVmI7XuBGw60R1Lx0okyheXJQMeiVegwP2T3GOkYnFTqBQgIlBU4hgaAmPmwa4yZuBJm/Y6TgNsRWd5UUbrfnwpKS1WOqS9zIp/Ocy0K0qb+oOYNbOudfbMaVtiIkUXaw4lecAWOXuXC6FaUGvwnEFuBkNjVQaL9Jzq7/yA8uMgXU/DBrlmyfn8fjE6JVOoiDvyqBN8LZGQg0ssXZjgU8cfTh4NclpU1TA== Received: from claudiu-X670E-Pro-RS.. ([82.78.167.154]) by smtp.gmail.com with ESMTPSA id j32-20020a05600c1c2000b0040fbad272f6sm1106843wms.46.2024.02.05.23.52.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 23:52:13 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, magnus.damm@gmail.com, biju.das.jz@bp.renesas.com Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, claudiu.beznea@tuxon.dev, Claudiu Beznea Subject: [PATCH v4 4/9] watchdog: rzg2l_wdt: Check return status of pm_runtime_put() Date: Tue, 6 Feb 2024 09:51:44 +0200 Message-Id: <20240206075149.864996-5-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240206075149.864996-1-claudiu.beznea.uj@bp.renesas.com> References: <20240206075149.864996-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790135245423491240 X-GMAIL-MSGID: 1790135245423491240 From: Claudiu Beznea pm_runtime_put() may return an error code. Check its return status. Along with it the rzg2l_wdt_set_timeout() function was updated to propagate the result of rzg2l_wdt_stop() to its caller. Fixes: 2cbc5cd0b55f ("watchdog: Add Watchdog Timer driver for RZ/G2L") Signed-off-by: Claudiu Beznea --- Changes in v4: - none Changes in v3: - none Changes in v2: - propagate the return code of rzg2l_wdt_stop() to it's callers drivers/watchdog/rzg2l_wdt.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/rzg2l_wdt.c b/drivers/watchdog/rzg2l_wdt.c index d87d4f50180c..7bce093316c4 100644 --- a/drivers/watchdog/rzg2l_wdt.c +++ b/drivers/watchdog/rzg2l_wdt.c @@ -144,9 +144,13 @@ static int rzg2l_wdt_start(struct watchdog_device *wdev) static int rzg2l_wdt_stop(struct watchdog_device *wdev) { struct rzg2l_wdt_priv *priv = watchdog_get_drvdata(wdev); + int ret; rzg2l_wdt_reset(priv); - pm_runtime_put(wdev->parent); + + ret = pm_runtime_put(wdev->parent); + if (ret < 0) + return ret; return 0; } @@ -163,7 +167,10 @@ static int rzg2l_wdt_set_timeout(struct watchdog_device *wdev, unsigned int time * to reset the module) so that it is updated with new timeout values. */ if (watchdog_active(wdev)) { - rzg2l_wdt_stop(wdev); + ret = rzg2l_wdt_stop(wdev); + if (ret) + return ret; + ret = rzg2l_wdt_start(wdev); } From patchwork Tue Feb 6 07:51:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: claudiu beznea X-Patchwork-Id: 197270 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1413282dyb; Tue, 6 Feb 2024 01:10:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IFiptFxJOz7Ap+gu7w8Bh2bLjcS1Dh+DfcCY3jIC37T4tPvDPlzgXBQxsWENh/p+FTCnNwH X-Received: by 2002:a05:620a:45a4:b0:783:f3bd:1909 with SMTP id bp36-20020a05620a45a400b00783f3bd1909mr3773355qkb.37.1707210606597; Tue, 06 Feb 2024 01:10:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707210606; cv=pass; d=google.com; s=arc-20160816; b=cRhYf8zlmGKnuIY0jxJCTnn4Ft5tZvAE3o1EmR4pf9aC+n/016VKql4B2q10WHADNV SPJ84/RIn5fTkWiuvlchT7fSeD9J/XqtmAHl0LvRCG5mmCeBfm7dquhV4skScUC+krmO kN7w4YJC9U+baJcIMsQmIgE8cde2Cx9vNkb1kl9wHYG0d8uy3VMd1vh9g1XSnV67nfXK AGxtnvwLo4DMRqE4TKfTTadFai7mzVUpTv5cWUeIlEwP4ncwJ7rqaOd6QSF7LeGfJU+r vmBYfAn/zl7INGsnmCCY+i+EwCzewa674x9vVBSG4UILatsWU0cvD63EFdtsVe0AF5nj t0QQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=rA4Lt7wlLZrwShaBAqRMXGVkQhmL/x3EvhyelQZjhV8=; fh=GpNd+vzLgzu8O5REo8Ll6zV/Nx/8IpedA4Xhu8AUCW8=; b=rSbNusrDXzeEeIEe1R1On557WiMAk1oUVCOiXiiGUx+6AGQQ06dwejr7fwkK2ie5Ry FTeDYcr2VAFRNybXcRk6t78tohuO+CkKakDC4YcTGNL6CsoUrxq7zIQDhd0iMfrTgaHO 7JdJPbDVbk1+/Lc1jBIA88LAIwFQ9ilKljnWQSQPsaDEFYeVKe38f2azvSmkilA4txP0 IghGkd03cvIB6qEq7COUb0exZWusxv8hSsGN3UFIrRux7h8o6oUAYLTHjurFwca6681I Sm8UXwv/0WRtdoRLCMsJxsVXke/woCtxFDmfuSgCrOeiliLxOhgVEyM52gXppX3AMuQs +s9A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=WGtxKTxy; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-54443-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54443-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCU6ERJ6Zmn2fR/EQS70nULLtJv7LvyDbYN1HGwzUxTJkSGanUjrq4ZLHKRgjsKX783xjZ3VUgKpM0+l9xxUghyWtuLsrA== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id j7-20020a05620a146700b00783cc18b28bsi1778115qkl.565.2024.02.06.01.10.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 01:10:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54443-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=WGtxKTxy; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-54443-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54443-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9033F1C2307A for ; Tue, 6 Feb 2024 07:54:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7ABE812CDBE; Tue, 6 Feb 2024 07:52:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="WGtxKTxy" Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2CDE12BE80 for ; Tue, 6 Feb 2024 07:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707205939; cv=none; b=GxfW9b50gJxQq1VcJaE76COdKp+NLekxQiLusoHfoqigyMgiJMj01C0YsDHNhjLGi8G6Y/pV3ZLbavbCYkOFJVyYZgWE1Js9OdNV+Wgq0Yz32wRR/UqzkpSo3ZOzmpMBIL5kuOIoVim8AiZ4vko9HD0Brh5nqy71JxzIhWa1LTg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707205939; c=relaxed/simple; bh=oGuUsUJTOBwH4PJ/XO1WvReC8UQh5qLEUBVQyGMyDWc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RN/xViv1Uo4hnDK7aQs9+fK7yRXjE6uguSmiHsaluAXMOva6kVKF9zo2IRpg+dn+866U1lauDwh69vl6WdNOEjtKfE2z4FDbbsw/ibWVY45adO2eljyS3QQdtwRndfqPRJ9+j9X0hxk5NzZ3B8QVCeTPUHSBIImJ+1DITtmguNI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=WGtxKTxy; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-40fc549ab9bso34953755e9.0 for ; Mon, 05 Feb 2024 23:52:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1707205935; x=1707810735; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rA4Lt7wlLZrwShaBAqRMXGVkQhmL/x3EvhyelQZjhV8=; b=WGtxKTxy7+PiMMhGjoEtNu56/u9mC4E97fFoHIGtyPC6EDifdfqqDQqaqIKUtsFJff fwGQxmXho8YLjEVgPP5Nlx7Irdhyrb2NjfrRMTRBDXxdOnJexLr0oRNjEYV3DlhAlDoC 0C2YgZqmSgxmI4y+uaknpkzUEwOZ5ieu38T8fz+ZV3xFqRlgWcgISB72gkat3YJ22RsB a6eq27rSKFUrbRp7uDoDTSC2Gq/+o8nhz+RdngI80ENtAJcX/DhUPYucmeQARdWyjS5w vPZU6QR5Qpk1d2Tfw9nb9KAFP6tqTCduosWRuB8a7k9pOysTD+zm9CxY96Vk/L3Wng+C YtOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707205935; x=1707810735; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rA4Lt7wlLZrwShaBAqRMXGVkQhmL/x3EvhyelQZjhV8=; b=O9ZsWhD9ESp3U15lHq2TS00zAwm+h1yROvPqKz1SOfWabB9DkXFlQibxnRwyDq4eTz 5rWu7Kj7y05Y2iGuy0M8CpOTKOH8Bn/hEW2WNTSLMjCii/64u815BVAJv3nFY52hfC2U YsuhTYmvZzSkzczlf+lNewRC/nLijIlia8+CjbltQzEaZgzZU3TCER+tLHHbtlMO3LTL Hu4MVUp5rR9GxQ8jO7bzbYAxcR7u8nz5/CPbRDPkZGoJzs1Hxy5675MkqKMmuX1g+6NG RWVCQIT5jEL29991FqF7W3g4hn/CDI69OKtvFBI0MM/WA2krp1941nvvSoTCMwYnWih+ ePFw== X-Gm-Message-State: AOJu0Ywln9UYpCK+03538/0mDT1+2sZK/pFhQ7BuZs7t0ssA0oP9fety PHDSF1msniZJFY+7SHIxHxRDWEicsClY9sZdmeWvtcjTtRH1eCZoyBCCCwq4Ukk= X-Received: by 2002:a05:600c:190e:b0:40e:4932:3995 with SMTP id j14-20020a05600c190e00b0040e49323995mr1591113wmq.14.1707205935232; Mon, 05 Feb 2024 23:52:15 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWth/RATJ/DZGD2r0NP4gOV7vr/QlwUYiCe3d7g0uTTH5xUB8Lfqu/xpwzSw5uQfI9krndixIDhcHwNi+XGRSj9b0YUtfGSB0HmNMyIQyQZAdvAhZD0BruFjDwfHZFIIrdbgZ8tO22IRd0xjqZXtMtHFVxG41ZJQX8sNthRJ4w3EylXqHcLsGOQ0Ord611Y6er6R3wwX/JfCJsG3ewtnYNlw6FOlclaY9ZCftxAUGAhpNNrZdtAjeABygyTVcOlySVVXk0y/a2jEEs8lTYmd00nTxhpVLYTx5bcBcvx6U1w6WYmBJ09UigihcMgXUFp9i/zW6phP/FpRDCyCNX4BF2L0ibxvKQre9C/0mexuLmbRU8cUtni8wHyw3+l5AUpRT+CpthQuA/B5hyz460tBmX8F/mEfS+c45jVAdyqHFuWW09UR04glqgTNIkJ8TEafdsVLkqPrdhjcVBsEUAQA01d3oAN5WU26GfZYcHtIL+5v6Ybi/Pzdz52yB+aUAJtMpF9H2YgoDLZ7Q== Received: from claudiu-X670E-Pro-RS.. ([82.78.167.154]) by smtp.gmail.com with ESMTPSA id j32-20020a05600c1c2000b0040fbad272f6sm1106843wms.46.2024.02.05.23.52.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 23:52:14 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, magnus.damm@gmail.com, biju.das.jz@bp.renesas.com Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, claudiu.beznea@tuxon.dev, Claudiu Beznea Subject: [PATCH v4 5/9] watchdog: rzg2l_wdt: Remove reset de-assert on probe/stop Date: Tue, 6 Feb 2024 09:51:45 +0200 Message-Id: <20240206075149.864996-6-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240206075149.864996-1-claudiu.beznea.uj@bp.renesas.com> References: <20240206075149.864996-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790140068534301111 X-GMAIL-MSGID: 1790140068534301111 From: Claudiu Beznea There is no need to de-assert the reset signal on probe as the watchdog is not used prior executing start. Also, the clocks are not enabled in probe (pm_runtime_enable() doesn't do that), thus this is another indicator that the watchdog wasn't used previously like this. Instead, keep the watchdog hardware in its previous state at probe (by default it is in reset state), enable it when it is started and move it to reset state when it is stopped. This saves some extra power when the watchdog is unused. Signed-off-by: Claudiu Beznea --- Changes in v4: - none Changes in v3: - none Changes in v2: - none drivers/watchdog/rzg2l_wdt.c | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/watchdog/rzg2l_wdt.c b/drivers/watchdog/rzg2l_wdt.c index 7bce093316c4..93a49fd0c7aa 100644 --- a/drivers/watchdog/rzg2l_wdt.c +++ b/drivers/watchdog/rzg2l_wdt.c @@ -129,6 +129,10 @@ static int rzg2l_wdt_start(struct watchdog_device *wdev) if (ret) return ret; + ret = reset_control_deassert(priv->rstc); + if (ret) + return ret; + /* Initialize time out */ rzg2l_wdt_init_timeout(wdev); @@ -146,7 +150,9 @@ static int rzg2l_wdt_stop(struct watchdog_device *wdev) struct rzg2l_wdt_priv *priv = watchdog_get_drvdata(wdev); int ret; - rzg2l_wdt_reset(priv); + ret = reset_control_assert(priv->rstc); + if (ret) + return ret; ret = pm_runtime_put(wdev->parent); if (ret < 0) @@ -186,6 +192,12 @@ static int rzg2l_wdt_restart(struct watchdog_device *wdev, clk_prepare_enable(priv->osc_clk); if (priv->devtype == WDT_RZG2L) { + int ret; + + ret = reset_control_deassert(priv->rstc); + if (ret) + return ret; + /* Generate Reset (WDTRSTB) Signal on parity error */ rzg2l_wdt_write(priv, 0, PECR); @@ -236,13 +248,11 @@ static const struct watchdog_ops rzg2l_wdt_ops = { .restart = rzg2l_wdt_restart, }; -static void rzg2l_wdt_reset_assert_pm_disable(void *data) +static void rzg2l_wdt_pm_disable(void *data) { struct watchdog_device *wdev = data; - struct rzg2l_wdt_priv *priv = watchdog_get_drvdata(wdev); pm_runtime_disable(wdev->parent); - reset_control_assert(priv->rstc); } static int rzg2l_wdt_probe(struct platform_device *pdev) @@ -285,10 +295,6 @@ static int rzg2l_wdt_probe(struct platform_device *pdev) return dev_err_probe(&pdev->dev, PTR_ERR(priv->rstc), "failed to get cpg reset"); - ret = reset_control_deassert(priv->rstc); - if (ret) - return dev_err_probe(dev, ret, "failed to deassert"); - priv->devtype = (uintptr_t)of_device_get_match_data(dev); if (priv->devtype == WDT_RZV2M) { @@ -309,9 +315,7 @@ static int rzg2l_wdt_probe(struct platform_device *pdev) priv->wdev.timeout = WDT_DEFAULT_TIMEOUT; watchdog_set_drvdata(&priv->wdev, priv); - ret = devm_add_action_or_reset(&pdev->dev, - rzg2l_wdt_reset_assert_pm_disable, - &priv->wdev); + ret = devm_add_action_or_reset(&pdev->dev, rzg2l_wdt_pm_disable, &priv->wdev); if (ret < 0) return ret; From patchwork Tue Feb 6 07:51:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: claudiu beznea X-Patchwork-Id: 197286 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1426290dyb; Tue, 6 Feb 2024 01:44:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IEXgaxxoy9GbiFYsNc2PucdkETx0CLGY2iA5DMvfFhfH9ZIZHh8uh9eggEt1REo8uZz3VPR X-Received: by 2002:a4a:ea03:0:b0:599:ebcb:dd96 with SMTP id x3-20020a4aea03000000b00599ebcbdd96mr2427567ood.2.1707212665501; Tue, 06 Feb 2024 01:44:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707212665; cv=pass; d=google.com; s=arc-20160816; b=JuVrkoJXIVX0l2TXZyboKja+cMPR8Fo1OB9mCOu7fmOJx6uTakU918ywBC2T2zw6e0 dBI5il0//lc8KSPBzSpO8Mz6ZgajeBRhj15fSvPFA3qZAwRijRrG7LJvtrsLu6jMCpYY ijJkmOUGe3aAXb9WhWGJh5AbAuFtwBjJkVsXN1ex4KtKMrC3oMBBMe+ACnY2vnkKzkXL Dcd8If3IhgbgL9rmIQncDo+Ogd0D0ICwhAoD2c8xndhRrUE743evnPkQ+JT8Uea774c7 e2dKVqxvsPsNGGCep1G+zueRQwOORKZyLM+834zel1qXK13jK9kLf/se42EPQJgLqkfz xP2g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Jjkb+6k/ccop6hFf25bQpwkeqZygRT9Wmt/Bq+56nWc=; fh=g/XSxhp3XOiOU/c9+8dmTi2hs2NOY8Q83GE9y/GCmaA=; b=uHjFYeaUl2hlZq2U3026yRprxnlRG9dDnRSG69r6ZqW1iiuKjSKd2NcxQ/F+bkg+wy 0ShvFbxVrP6h0pf7HgM0f/94wh1QAt7+rKvP2IYwu/Evr1p+WylsumGZ6TQo+n4CLuLH ay2bKa0nHVqpkaipFX4GJgK8FxQEx/lnkMRCa5rfjbZ/EWYpPU53mkkNhgWQLFzFLJdt umzMg91oBrcjizvnrzyyMsV6JKUTTSbdthBA6duv48OeFzTOy+i9sO5+muC3zri+S49n G1smj4xi4wWeY1YetEI8PhLkNwGvTQTLyby8BK0dsW180143W+agIwHbgun0BajnNHl4 zORw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=ftrDgpui; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-54444-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54444-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCW/m4N14g+7HtzCjjU/I9DRb0QQWt/SVybhEaJ4UOQnVQ5uOT+xOds7XLOZc7zIhzTS+ZPI+oReKv9GcSTvnbvpW7qqyQ== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id v33-20020a634821000000b005dbd5035dcdsi1347029pga.192.2024.02.06.01.44.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 01:44:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54444-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=ftrDgpui; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-54444-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54444-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id ACFE02856D5 for ; Tue, 6 Feb 2024 07:54:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7554712CDB5; Tue, 6 Feb 2024 07:52:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="ftrDgpui" Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A18AC12BEBC for ; Tue, 6 Feb 2024 07:52:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707205940; cv=none; b=SQfbtxXcW80GuoHacKHaENqXJRXQa0CjbnrDkjKv2xNcl2KxyAO6RDcZjjbKMmZRkuVGt9vtksMFwWzx7wc5ok+6m9JzSqlUNpw4nXYOpr4tDipbGEZFb20OkOaYsNZPWSdb+2d3xAGuAhWJF2HvPvIsBqsNyL2hAj4J+iC0b9E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707205940; c=relaxed/simple; bh=orreljjYFXCp/zt5Wm7smk5iCuPfvW/eAvi8Jm6wHkY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CUfTxVJrlkTEaKNH5f4lMNGlbMYpP94QjSfDyOmd8vh3VdbHuOzLxtTijZ6ea7TRa7+OmAR3VnhfSbzf6ODrTFvpbHlLcvZkI8zKzfDs9cLw/FSKngPzz0ChZcZvCWyrpbcfmTEQt4HfebZUEJmChSr20O8w7rv7yIhWIl1qr7M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=ftrDgpui; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-40fe2d3d5cbso2461825e9.2 for ; Mon, 05 Feb 2024 23:52:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1707205937; x=1707810737; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jjkb+6k/ccop6hFf25bQpwkeqZygRT9Wmt/Bq+56nWc=; b=ftrDgpuihUOHTX5ec3XOeoUqpzH1jLc2Y9ltSX6F1dXXF+Cri5eq6FLgFQW1LKTECf h5dfAHWG+tjsy1fJVy3+ZNE5ZugADC5vbf1nogygIn7sRA0SccA2pQix2GpuJPPX/v1L +BiZue8oJi/bbmtK9pN6KWe/mpGRlCK4ky+pdLQyUSoMEXH7M9zf8C1fd4LsxZLl6HPx s6OMuvFEAF7hmk27730jcRWZGqPAKKwop79bxzyheE6zpHssFCl+TRkht0EuJSogbk+p IRvBBfd/yjWJ4eyqb3K+nrKBijdYDXLW0+Ugw1X5bznTgEGRQ0Ribr24JvPNOYFaGea4 YkQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707205937; x=1707810737; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jjkb+6k/ccop6hFf25bQpwkeqZygRT9Wmt/Bq+56nWc=; b=CIcBh8OD7XSuEpQeQtw3b1iSHnyk4711FhO5D4S/LN8ZBVl9FcttNIGBV/5X1TTH1p UOzU3+309r8BgadMZfzzg0Y5iYK/Zm0fZsZOu2rISWimn1dPfh+2o0X2PzHNbXIyOiRe EPnHWytQWhPBCUngwoHcWN6uonzP0vKyKHBFf34Ur7PoO8GsqP515tIi5Mu9xe3Y/Jgr ynfv1tTmBCnc4KPvZLQZ1EiKz7KX+KPKq5+CZwPf6CuFfcBqMMz3GzdhaCy7IExgzd/0 lMBTo6eo1gSiMr5bEJdbbI/nkrFu20fzWVpwN4zZhf9kR74IS481EsfjwDWgF8to+u4P +1cg== X-Gm-Message-State: AOJu0YwIiAKx9lD/fLGbmNbnRywuvYcLHM54bLwYMVtqnWfmBMbzlxQn 2lbfNua7b0SfWttslECoxLNbQuvKpEn/1pena3zB7T5CrBjtQvXHrKKKD5OYzUgXvrYNSu80BeY m X-Received: by 2002:a05:600c:3d08:b0:40f:e067:d700 with SMTP id bh8-20020a05600c3d0800b0040fe067d700mr1355266wmb.20.1707205937118; Mon, 05 Feb 2024 23:52:17 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXzRbe0Pc0MbbjL3PDwklHaadtArRtSlDpzHmu+hHAHrz8CqFGN25LHeqo+HL3atw17fQTvAWqhg3CqHqPkWkm8noC/TGDaC9RrzCvfbpCWgdrB67GgNws2WncgbNLnyXoCRevbBkNuR07pwrm7N97OIK4CVnh6qrbLn1iL0/68QiXtP9CH5DhYiT6SIJl84YBGIWBSfTwXg/dmthrSJQgilWqIryi6+1rIkFKjuSUHcUy55/1suQt4PX8llGUkfm8wZHhINykJk+hYLH3BQNCqDhms4Qi5Sk+3CT9HIx8PijNUBg0o30wYf9taCbRdP4h5t7qSciSKZsss7ji4tACGHnKt4N59ePjFtfNbVN/Cjj4SHGbrlI9NM8CSc11aryFvhdb0X83WM/fYPGkG4kX4ASPfOv9lKv9I7OL0Zd7dDwXOazzvkoo1E24UEBOYBZbuiuNsIKnuTz2GRGbCqXJL/IelgxQS211rvN+f6U+Frq0OL5hNG/7hF8uSwbtjgu4KTqYkFch7sQ== Received: from claudiu-X670E-Pro-RS.. ([82.78.167.154]) by smtp.gmail.com with ESMTPSA id j32-20020a05600c1c2000b0040fbad272f6sm1106843wms.46.2024.02.05.23.52.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 23:52:16 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, magnus.damm@gmail.com, biju.das.jz@bp.renesas.com Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, claudiu.beznea@tuxon.dev, Claudiu Beznea Subject: [PATCH v4 6/9] watchdog: rzg2l_wdt: Remove comparison with zero Date: Tue, 6 Feb 2024 09:51:46 +0200 Message-Id: <20240206075149.864996-7-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240206075149.864996-1-claudiu.beznea.uj@bp.renesas.com> References: <20240206075149.864996-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790142227912185835 X-GMAIL-MSGID: 1790142227912185835 From: Claudiu Beznea devm_add_action_or_reset() could return -ENOMEM or zero. Thus, remove comparison with zero of the returning value to make code simpler. Signed-off-by: Claudiu Beznea --- Changes in v4: - none Changes in v3: - none Changes in v2: - none drivers/watchdog/rzg2l_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/rzg2l_wdt.c b/drivers/watchdog/rzg2l_wdt.c index 93a49fd0c7aa..29eb47bcf984 100644 --- a/drivers/watchdog/rzg2l_wdt.c +++ b/drivers/watchdog/rzg2l_wdt.c @@ -316,7 +316,7 @@ static int rzg2l_wdt_probe(struct platform_device *pdev) watchdog_set_drvdata(&priv->wdev, priv); ret = devm_add_action_or_reset(&pdev->dev, rzg2l_wdt_pm_disable, &priv->wdev); - if (ret < 0) + if (ret) return ret; watchdog_set_nowayout(&priv->wdev, nowayout); From patchwork Tue Feb 6 07:51:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: claudiu beznea X-Patchwork-Id: 197271 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1413754dyb; Tue, 6 Feb 2024 01:11:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IEfGCKPEMnxIzs0o8c1aDu5TFqcM0T8t+kIgA1jG+yQOX3kRXZhi+iXGg2LzVDzVle7Ht++ X-Received: by 2002:a17:907:9726:b0:a31:1154:89a9 with SMTP id jg38-20020a170907972600b00a31115489a9mr1368517ejc.26.1707210683033; Tue, 06 Feb 2024 01:11:23 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707210683; cv=pass; d=google.com; s=arc-20160816; b=0RhmaZp/f+hBSGHvUrXt9vQpIUsOM8l6t7ZlJQRTar9fpVnVpCfAKpZOFxHQnOVPuW FoyXLScH9Meg7jQyJFlx0RbTZgzb71NxLyRQ8aROReD/OCuoM8F5c4FI4J0N8c7sIVRJ L9PLXSY2/KqNisWRtN/g9gOLNEoX08sn3pDN+/Snc9muVbFO6DkyVrMSzcZuiyyB7vPh erz8T1rRR9pXcAbnnu9MgfXdkEQIfO64irABRYWKYz0xSpkf323l4gdhVIdG0apB2uPm eb9P/6vzqgK1XF1h3nic9/CzBiCRY7V1Id57W1I58+eSQ8OnzeqXZwRWKJqL7GAP/aCA AiJA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=oWojBmpvYKWohEDFYHq6fZ2AU0LO/ivcX8nI4tPnMdo=; fh=kxSVCDDhVh6Sm2ram+O5RUZwLmR7l1rXibS+moXdUzE=; b=Bw+EBA9EuFFy4kk06oMBCnoEGsCE26wKo2uSMFeEW/yUMf9RDI3Y0QE7ItQ9JoXUj1 DSF4S6cj251sPy6MPaX1JskIxUeLI1GczljLoqiE9Ig5hYtrXD59qERnbdQJTxbDpV9f 3KCY7mmvhmT0BBNi7WynUui9Uq0TclPcXQpTCcljTkoTfxjnLoCHSGPfn0nJdVsEaYxK NyektVGicysVeuoR9Yn1+3rm7uCjF4GJnvQ0mp2K+oUwtnqvKWOuqM6b9UK4C82LWoCJ pU8WsTSirvfV/MqDoaE99jKt4dJ00M6oG0O21+AC7aDyVwIe1/WY5tJY3bfpwS5Z6PNH VZ7g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=FeEKYPsG; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-54445-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54445-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCUHdbsEeg6OR1c5rDakooE6oxCKlPV8Y25csaKIWdIM8nC7VIZvmoI7bqf8cdXiEsNPBCaeE5j10nWMT+aNq2+bmfrJbg== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id t5-20020a1709064f0500b00a373f4a8b82si862985eju.188.2024.02.06.01.11.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 01:11:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54445-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=FeEKYPsG; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-54445-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54445-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8346A1F256B0 for ; Tue, 6 Feb 2024 07:54:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4DBF012BEA2; Tue, 6 Feb 2024 07:52:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="FeEKYPsG" Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1EF912C55E for ; Tue, 6 Feb 2024 07:52:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707205942; cv=none; b=Klk2r7VQhKy8a+wobPSgI4FZCTQgTzHmxbCrMNjJ3OyR7vpxeZ+EnZYTesHn0TQABATkj9iGxWO5/hM0RS1uPx92C8qVCdcvVs7pJNOFkDZf8mF8/sxBhf4vt0960PYqAPI1dVGVhvoWKKtl3JOs1JnOVca0+e9hNvHnWz37JLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707205942; c=relaxed/simple; bh=jKTSHJTtTI4N0iJp7IFQIhA+NWord9Ob1XRiUrlNEHo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Rewk6rH1Qe6ZBbENyNFy2JKSVYB6asZhrGM5+iKRrHxJNX6GZ2SsNwdeN+2ZTTdqmuB1N3ekyY77OxpSOMEsNy974ZaXLS8KeJrEIX+t4Bbc9vApq2i2Vv1flPyg/jVHrcxm5q3VnUDOQh2jx2hT3SQtXpSGMx7Ea5HB2d75jsU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=FeEKYPsG; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-40fc6343bd2so34880725e9.1 for ; Mon, 05 Feb 2024 23:52:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1707205939; x=1707810739; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oWojBmpvYKWohEDFYHq6fZ2AU0LO/ivcX8nI4tPnMdo=; b=FeEKYPsGc3D+mxJwJXSTnWM2M/ge7sJu1B5sNA7G8aT/cEFJ9nb62CR2ykebQ1xwUB 9ev4eoNuCK6oc+HC0wSppRcKucALcha2CHcmMJcQJcwDOMm4HEhWqEj4/awsiE8xFuGM Iv3l5p/QyQv+lt5KvaWgSs3tyFFqhy0IkPTcWUpXsHe471CuEwUzVM4FfFFiQ+H7uLz2 P+pMyDnGXSEdj/6mMtL4agjiu4LPBRhxgVFgmGWHbc1EDxKPemI8AYpwnr7ryYZMhc7R NsqnZckCcquhHAijzwvRj+U9hHpBCwbMEKc1ib8DlW4hFC0y4ixsa3oSRDG9gjZQhNlh HTgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707205939; x=1707810739; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oWojBmpvYKWohEDFYHq6fZ2AU0LO/ivcX8nI4tPnMdo=; b=Y0czg8RfSlE8D8JHoLMP6nuvYZF9esUwnzPXOYCrEVAg5+rmiFRsaxKqlh9Kmyr847 eRPAkGessGWsTkrChw29khuteXFawnXHY45DzW5jssTh/oLjVt/7jQsQZBMJbjkTxgb/ AA4NdDLMgGhHTbvLLXAEOsq01U5Nxsph5knc3qz3pVW3ZZG718/5Os1SaLLQn1RActe1 sLQtqLq0cJmLY/PNdvOy0tq0rzvEIHdvdmwDGgGIyppX221gkdhs5XssqTkQ9AEl8Ba0 k0AzFRFKr3qMQ/ECNYG3oxENbFb8m4Se2b3BWCqWgRQgybTrVaHdSToRKGmDUrao7+el 0j9A== X-Gm-Message-State: AOJu0YxILpATZluMlUcma/6CDix8wtnv3mDh6DgUPvdLZ0xZdH2+iyj6 hhWyetDXLDNQqKq6dWDFIgA7lZBOlCqG34I32rRndq6INu5cAiJOMPAWseOIJCQ= X-Received: by 2002:a05:600c:354b:b0:40e:befe:37f3 with SMTP id i11-20020a05600c354b00b0040ebefe37f3mr1095012wmq.4.1707205939244; Mon, 05 Feb 2024 23:52:19 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWpdu9BHv49FzPBvhIJZTLAiH3Ss/cgRJv38/YYSE2DTTeaWqCYw69xKLmLl6adUawypx3Wyuo0EP8bbeRHtMAAC2J8fIJ1oYMGG95oPPIQanvjsaMvpKuvD0n1jVEK8f1SMM5L0FLvFNMkZOrdmAf2MU7ByfqLFN5ze/4z5yeRy7cuwvANvJ0cu52opkeUB+1pLAIC9hU/ra2JA6g4VQVU1iyHo38yAoUMvmxUZAJgxLF0HPj0H7JTt6BDKJJcQiZ3ZVjxsTTd9ieM9ewvKCbC2a3n3F4C709dFeRYAcmYTNIC8zXaQt3cTlL/YGmF6cmU68lJmfijGADNjk80xDjn9bzNqFCvVBrRDUz0A9HiJt3Gb9wBEUQ+5XQ8R9yGjtkXuhElViwPqWwLbRIdgW5G4F9ozhH8THcWzUHUNT23VbZxkS9vww2Zaa16zeSAm299ZgJoj3JOy3pjYC0OtLa4Ajikp5xzsixrI0+Ynd7vUaR2DBn+8fV9utF+4GZ8BJsdJvGDly5/5A== Received: from claudiu-X670E-Pro-RS.. ([82.78.167.154]) by smtp.gmail.com with ESMTPSA id j32-20020a05600c1c2000b0040fbad272f6sm1106843wms.46.2024.02.05.23.52.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 23:52:18 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, magnus.damm@gmail.com, biju.das.jz@bp.renesas.com Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, claudiu.beznea@tuxon.dev, Claudiu Beznea Subject: [PATCH v4 7/9] watchdog: rzg2l_wdt: Rely on the reset driver for doing proper reset Date: Tue, 6 Feb 2024 09:51:47 +0200 Message-Id: <20240206075149.864996-8-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240206075149.864996-1-claudiu.beznea.uj@bp.renesas.com> References: <20240206075149.864996-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790140149030542423 X-GMAIL-MSGID: 1790140149030542423 From: Claudiu Beznea The reset driver has been adapted in commit da235d2fac21 ("clk: renesas: rzg2l: Check reset monitor registers") to check the reset monitor bits before declaring reset asserts/de-asserts as successful/failure operations. With that, there is no need to keep the reset workaround for RZ/V2M in place in the watchdog driver. Signed-off-by: Claudiu Beznea Reviewed-by: Philipp Zabel --- Changes in v4: - collected tag Changes in v3: - none Changes in v2: - none drivers/watchdog/rzg2l_wdt.c | 39 ++++-------------------------------- 1 file changed, 4 insertions(+), 35 deletions(-) diff --git a/drivers/watchdog/rzg2l_wdt.c b/drivers/watchdog/rzg2l_wdt.c index 29eb47bcf984..42f1d5d6f07e 100644 --- a/drivers/watchdog/rzg2l_wdt.c +++ b/drivers/watchdog/rzg2l_wdt.c @@ -8,7 +8,6 @@ #include #include #include -#include #include #include #include @@ -54,35 +53,11 @@ struct rzg2l_wdt_priv { struct reset_control *rstc; unsigned long osc_clk_rate; unsigned long delay; - unsigned long minimum_assertion_period; struct clk *pclk; struct clk *osc_clk; enum rz_wdt_type devtype; }; -static int rzg2l_wdt_reset(struct rzg2l_wdt_priv *priv) -{ - int err, status; - - if (priv->devtype == WDT_RZV2M) { - /* WDT needs TYPE-B reset control */ - err = reset_control_assert(priv->rstc); - if (err) - return err; - ndelay(priv->minimum_assertion_period); - err = reset_control_deassert(priv->rstc); - if (err) - return err; - err = read_poll_timeout(reset_control_status, status, - status != 1, 0, 1000, false, - priv->rstc); - } else { - err = reset_control_reset(priv->rstc); - } - - return err; -} - static void rzg2l_wdt_wait_delay(struct rzg2l_wdt_priv *priv) { /* delay timer when change the setting register */ @@ -187,13 +162,12 @@ static int rzg2l_wdt_restart(struct watchdog_device *wdev, unsigned long action, void *data) { struct rzg2l_wdt_priv *priv = watchdog_get_drvdata(wdev); + int ret; clk_prepare_enable(priv->pclk); clk_prepare_enable(priv->osc_clk); if (priv->devtype == WDT_RZG2L) { - int ret; - ret = reset_control_deassert(priv->rstc); if (ret) return ret; @@ -205,7 +179,9 @@ static int rzg2l_wdt_restart(struct watchdog_device *wdev, rzg2l_wdt_write(priv, PEEN_FORCE, PEEN); } else { /* RZ/V2M doesn't have parity error registers */ - rzg2l_wdt_reset(priv); + ret = reset_control_reset(priv->rstc); + if (ret) + return ret; wdev->timeout = 0; @@ -297,13 +273,6 @@ static int rzg2l_wdt_probe(struct platform_device *pdev) priv->devtype = (uintptr_t)of_device_get_match_data(dev); - if (priv->devtype == WDT_RZV2M) { - priv->minimum_assertion_period = RZV2M_A_NSEC + - 3 * F2CYCLE_NSEC(pclk_rate) + 5 * - max(F2CYCLE_NSEC(priv->osc_clk_rate), - F2CYCLE_NSEC(pclk_rate)); - } - pm_runtime_enable(&pdev->dev); priv->wdev.info = &rzg2l_wdt_ident; From patchwork Tue Feb 6 07:51:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: claudiu beznea X-Patchwork-Id: 197273 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1414780dyb; Tue, 6 Feb 2024 01:13:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IH0hnk0zkSpWjRzh8Y7OWcvzsHXyN91KCPrv8KNBg0ESLtLBSqrmbW1AgKOCCOvX3XO7LMN X-Received: by 2002:a05:6808:1988:b0:3bf:db87:7ec7 with SMTP id bj8-20020a056808198800b003bfdb877ec7mr2729119oib.21.1707210838350; Tue, 06 Feb 2024 01:13:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707210838; cv=pass; d=google.com; s=arc-20160816; b=gUeqs0ZM1adZApU6q5I6RzWVPC1v6l+0fSrRfOyAwcZWDTc/NAw/S5v82yTcbpBzv4 nYRYnZJCjykGa4KbZvHjpBYsBkoLACSj0YgUBG7999PteaxXqyrXHXff6uB4YIxfDlSD BqJ1Fd3D1kjU0a2tBz7Z3dRO6xFbsIsU6JkguXWEvwVSDAy/mB4j3Ld7a9HN4mWqaOmw A6WYXaNBha4la6Az3S/zaVSGr9pbY76nPBB4kO3SMB2l4b0o6HEAby/1gvFSkbDjJxFq hJdtrI0zGC6SJwYe0Iy6iiC6EeePgdrw5xSAftTF0tjJC1xABYUoVFVs2Bp+/I6tduR1 1X4A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=8RwoclSKr0jTPCLza6NnyZdnbSE3Er/n2jlH8URKPyo=; fh=DebDGrXYwPofGl4BE6mvcCJOGIi9xUJYQ7q/di42NLg=; b=ZN57N0TSiqnmVMFAPh6Pt3Z8bb0n3Z7K/kDG6La2itGolz9jqLuewClDsr2wnS8pY6 kdG5cnjo54OkhR7zZxT7P0WU7d1oBmXZxRNH9MIpDewwIk1A/t50hCBvkMJQsr+1WLHe MSq1a1BftAPiScaRxNVVMvlp9Xm0gpJllk4kRZ+2LjoDZ+FTOuHITJaMUnl3WzPHBVPN 9CLjKIM8KMKiF3xyz6bHIT//7fPBgR0HxoXzbuD1fGN8hs65cvmJ7n7k4L9aOhDRQQmv EN4uykM6OBsO4OEDKqjt5sXpe+NOmagfZ3PXXZQpVHSMgczinZuIqwzdR/AY/Z7xJzRl PfGg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=MgiQahuv; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-54446-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54446-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCW9sU7IZa3sBFxTJ0UrgM5oiv5va7lAAVajKDmVz0KcMNSwQ/D2W4d6agVPBj5wGsplq8rmRl8IAucqbMTnr/cEhMJA8Q== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id r9-20020aa79ec9000000b006e054a1fda5si1328055pfq.98.2024.02.06.01.13.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 01:13:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54446-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=MgiQahuv; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-54446-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54446-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 744B3287466 for ; Tue, 6 Feb 2024 07:54:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F366212D176; Tue, 6 Feb 2024 07:52:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="MgiQahuv" Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3A5512AAD0 for ; Tue, 6 Feb 2024 07:52:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707205946; cv=none; b=eTzM1xJ+GK5KjWhYN42b/BVoEclLeH9EvQLDoZUD7FbFZQC34akaniX4WFwvq/p8rYMPz2O57ro2tvml4/LZYxtfxjq8DWVk9PqObjM7NcB4n70QxSkz24+VlMZsjqtisDDhVljzWQheF+PpErX7Y88gIzIC3zLmFI2ALSxOQk4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707205946; c=relaxed/simple; bh=J/XvStBpKipy73l5We0jwaSeE533ZzXJ5uwYDD0Q1C0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=b3q0ChsaRO2WRTzMc0X3K/smWqL3Nz5FayqC5egpPMvPiYrxyzX0yzYx0RTQwG17ZFz+eDl9hTOAn13tR+UvLtW4YwZdOINCH79lUcRNRExCBoo8Es2o2xIgj5vdLf/EpJEgXpaToQwb+fGrD5QqWcww7RWdPFyvEIhkRHxvpwQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=MgiQahuv; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-40ef3f351d2so1259635e9.1 for ; Mon, 05 Feb 2024 23:52:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1707205941; x=1707810741; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8RwoclSKr0jTPCLza6NnyZdnbSE3Er/n2jlH8URKPyo=; b=MgiQahuvDBK3YkvCjYwsAabnAXEtnGxhhRVLP4UisGUyauKfc+hj0h/WhvmK52uGgm pTCl8LkLk9ZQR5f7Ajkio2Xzz8fyr+F6p/WD33/jXOxQQWdwn/xT0/sOrc7rOHNsXovm ujKujXjsCIBDKPXr+SBCg0UDlQa78UR1okcPv7uasPXkge4uFGwpV7loQlSf8uNIYi5g DyvDkiBe9bLmZgyysIVIQO3JlxYh3tT5ZUF4hwL9pZTBjWvW9vTgBVC8kA+ozsTP9gbW Pt7/nw/QSMJ1DhDgvSgpLVSaNxBve0ULexBV5bzc8C8uAhAXJ5p+f0k9hp90OkvPy/h6 wW6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707205941; x=1707810741; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8RwoclSKr0jTPCLza6NnyZdnbSE3Er/n2jlH8URKPyo=; b=gtX5x34xlzn0IoWlZjQlVcGkAiv46B+kGZCvYbFfAwczsZ7MAm0oKl9/szdRU/jUB4 XjQHwbX2DkHFFLOl9shtkBKMcg5+F0Eb4pHL1TzjzH4Ylv1DcPB40cu7L2gdMUaOCa4U FZ0mUaUltknxWlrry7OfxgyHt1/vT42einAVvaTBpBA75K62guw/OxQUOZ7pvwZeFXC9 s2y0kJkUdYSeK1TY7jGVaCJSVMKDKNgw6IbjVhl/5tTzq7ltMFNlBinwFdzXdHCmAFcv 4/MBfrFotB+RtriZbwsmYCF2Xat0Ar4cTx6klAgMcV6mdhJQLhX8MhOWETx+/WVeZfaW GD9A== X-Gm-Message-State: AOJu0YxI24/pdifKMf2pbN42u3x3g4Xv01aal/JzzlZg55hB7kZQxv6D u3pwp8EBOqrfezlnEB1pPNM4RSAKnyXqer1HJ27ivm6VMJTj5cikDZz8XlxIugc= X-Received: by 2002:a05:600c:1c84:b0:40e:8655:d48f with SMTP id k4-20020a05600c1c8400b0040e8655d48fmr6042770wms.11.1707205941216; Mon, 05 Feb 2024 23:52:21 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWTO63sDkRQE+HeVgRxlVJkv+uG1jdMn6W2Lw9uAXSMO/GfIB2xQ+qCBFQ418ecsOz+poyMHK/Svj4wWrtiqdOdJNh0ZLEWyjqwQ2Ic0tbvcmqK3g9ti55kuJrwvWzJYyGTwL29JQzTHYRxba/Qghvc4KlmfE6FEjA9TAysrnoV5rtmlwDLu9PMDXpXPi7Nke8JPOdyYshGN+ODuf3w86vdJbGZ2YxsB9d3zE5afgXAIJhVgJiBpM8xO2l4YHRCHSjXUj4VF5ozPDcUljM+SxIVyYlOpkOEGQPTm/QioDZHgRu97G14pnl/lchhVJtCxiUzeq67718Z6Zbh5hPjUBddQspk1M4JHcRgPIRkkTxZ18EkGYJoXQakkHYOWe5c+3NLmp/sQxar89/1PTcY8e31lJKMsFD+GiPnXr6ZSUcqRQnNkSJgR8NaoLXzjduyBFh8lx8jFyYZhQ/igg1o5GFk4uNLd4nTAZFHeTHpW6v6iF8Km4TW7wvwXLZe9KAcr9peBS7E9+obNA== Received: from claudiu-X670E-Pro-RS.. ([82.78.167.154]) by smtp.gmail.com with ESMTPSA id j32-20020a05600c1c2000b0040fbad272f6sm1106843wms.46.2024.02.05.23.52.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 23:52:20 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, magnus.damm@gmail.com, biju.das.jz@bp.renesas.com Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, claudiu.beznea@tuxon.dev, Claudiu Beznea Subject: [PATCH v4 8/9] watchdog: rzg2l_wdt: Add suspend/resume support Date: Tue, 6 Feb 2024 09:51:48 +0200 Message-Id: <20240206075149.864996-9-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240206075149.864996-1-claudiu.beznea.uj@bp.renesas.com> References: <20240206075149.864996-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790140311800947932 X-GMAIL-MSGID: 1790140311800947932 From: Claudiu Beznea The RZ/G3S supports deep sleep states where power to most of the IP blocks is cut off. To ensure proper working of the watchdog when resuming from such states, the suspend function is stopping the watchdog and the resume function is starting it. There is no need to configure the watchdog in case the watchdog was stopped prior to starting suspend. Signed-off-by: Claudiu Beznea --- Changes in v4: - none Changes in v3: - none Changes in v2: - remove the usage of pm_ptr() drivers/watchdog/rzg2l_wdt.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/watchdog/rzg2l_wdt.c b/drivers/watchdog/rzg2l_wdt.c index 42f1d5d6f07e..c8c20cfb97a3 100644 --- a/drivers/watchdog/rzg2l_wdt.c +++ b/drivers/watchdog/rzg2l_wdt.c @@ -284,6 +284,7 @@ static int rzg2l_wdt_probe(struct platform_device *pdev) priv->wdev.timeout = WDT_DEFAULT_TIMEOUT; watchdog_set_drvdata(&priv->wdev, priv); + dev_set_drvdata(dev, priv); ret = devm_add_action_or_reset(&pdev->dev, rzg2l_wdt_pm_disable, &priv->wdev); if (ret) return ret; @@ -305,10 +306,35 @@ static const struct of_device_id rzg2l_wdt_ids[] = { }; MODULE_DEVICE_TABLE(of, rzg2l_wdt_ids); +static int rzg2l_wdt_suspend_late(struct device *dev) +{ + struct rzg2l_wdt_priv *priv = dev_get_drvdata(dev); + + if (!watchdog_active(&priv->wdev)) + return 0; + + return rzg2l_wdt_stop(&priv->wdev); +} + +static int rzg2l_wdt_resume_early(struct device *dev) +{ + struct rzg2l_wdt_priv *priv = dev_get_drvdata(dev); + + if (!watchdog_active(&priv->wdev)) + return 0; + + return rzg2l_wdt_start(&priv->wdev); +} + +static const struct dev_pm_ops rzg2l_wdt_pm_ops = { + LATE_SYSTEM_SLEEP_PM_OPS(rzg2l_wdt_suspend_late, rzg2l_wdt_resume_early) +}; + static struct platform_driver rzg2l_wdt_driver = { .driver = { .name = "rzg2l_wdt", .of_match_table = rzg2l_wdt_ids, + .pm = &rzg2l_wdt_pm_ops, }, .probe = rzg2l_wdt_probe, }; From patchwork Tue Feb 6 07:51:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: claudiu beznea X-Patchwork-Id: 197272 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1413919dyb; Tue, 6 Feb 2024 01:11:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IGR7hTiP3mSB4EX/dnramPebkPpmESBfMjQdCvox56odMNywgjFHBBKH7sIrk9O803uMR+J X-Received: by 2002:a05:6512:2246:b0:511:60ca:d4e3 with SMTP id i6-20020a056512224600b0051160cad4e3mr311624lfu.4.1707210711216; Tue, 06 Feb 2024 01:11:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707210711; cv=pass; d=google.com; s=arc-20160816; b=VucR4o8IDGAtMFIb2+A3jZK8TgbVYYPIc8NIE0YBFHO8LIoMOOseycZRGVALEWWigq baOzyms0Vf52XgewRJkmovqdkE1x6F3scbjMJRfKl3k4w9RExRF+AngZroma73Nt0edS RDOz4fdROus0YlezFPDScqvrCDR7mw5ZMLqSp7ld3xCI0yemVb4STJSBJ44uhwTUf+VC +NnkAFqwUPqq+Nw1yoKkOAC5yzQFJ9/PJ9vx+GNUBcMbeSIrS6ZMQiYwYYjonR/C1wSj WwefVm67GNJUZrixvZl7nl5hFiPilZw4a+Q2e6Eg36JyW/IsgFSQPBOmJAo/sV0NsCzs BEyg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Nslo2KqQ/crFqeERQmjq+RimgA4EmUsTWWhunmms0IA=; fh=7w2wHMQkKoqxSqKQ+EsUasrnYIpRQi9lYWfj7lqTKno=; b=ZJXchWJWyG33gnOq6KHXb0HP5kdufnqmF5aHuKEC9V1XadTtVywFwFYUCRVRj/r6MG Nij5VTpa06jz4uoq8kugRyau4I8TauVZJG7oZA6pQ5XLKhEdUNoDK9ah0u9Q1wDiTOFa 36u73NheGQTITFTRaqotEBPrT/XuD2bm4ofc8QalaMnhcfs6WLLgTrPYm8E4VqKPzY1E 0cToptxG0YFFISHIzlqJ09gurRIfOGqUAA6M/WV66+38gX8CizOlYzhsVkMIni0bXsd1 c6eKvMbupLdfk75sx+uSKwSqTHJMHuRlprdolHj0OwwIR88LmEqfIbhqQ9D5vIoKM8i+ +nCg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=PCGSyNaK; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-54447-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54447-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCV7vjB03i5R3FThGzN+mM2HxWgAFRSFXD87UfRdPewAUii2jcOIA1popJ9y5NxZ7+Xqja9QExGSJha8y8e+Yh6RyQwzRg== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id jo25-20020a170906f6d900b00a38421c8767si48914ejb.586.2024.02.06.01.11.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 01:11:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54447-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@tuxon.dev header.s=google header.b=PCGSyNaK; arc=pass (i=1 spf=pass spfdomain=tuxon.dev dkim=pass dkdomain=tuxon.dev); spf=pass (google.com: domain of linux-kernel+bounces-54447-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54447-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4B9531F25E44 for ; Tue, 6 Feb 2024 07:55:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E6AD212D77F; Tue, 6 Feb 2024 07:52:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="PCGSyNaK" Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FA7C12D15E for ; Tue, 6 Feb 2024 07:52:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707205946; cv=none; b=Ub0NDa9WsJdAZSaezj0/KWHLiXH/4sMIeUalQ6QTquE6CXK15gvi58qTytp4LstkT8gs8XEXAnmz1vO+TBfaGuZUTbC8qgBecA6BIL6H7vAMxhhsd3u0vBNKYy6YjXIZerpVQvOKw9PnBjpRAUY9nk+TQDZy/+X+zL0biwBdCyI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707205946; c=relaxed/simple; bh=vR/061UDD5TR2oXq7LH1zZoAUat7cIdF/cOUx86FGVA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=iUBpzfarF7fR/LvrJTLrQKBWVsnZytzxjKlDmoUESXWecCK09knshcUtxT+/haatG6c+YODb3GGN3hT6rCfirMrj/sDDzH2lFfta0tlquUoOWhaMzLezlDxarUxwRI7DKNfQ4CjEvcwikQ2x5dK9YssfP+N6TQqg7XhX84Hw9W8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=PCGSyNaK; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-40fe2e746bdso2619285e9.3 for ; Mon, 05 Feb 2024 23:52:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1707205943; x=1707810743; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nslo2KqQ/crFqeERQmjq+RimgA4EmUsTWWhunmms0IA=; b=PCGSyNaKpUdTBV44ZY8r19owFJGHQLPyEeECUal6K3csajvkOmHc1MrAPlCQtKijjH qtcDgNmt4Vr4Je1DEyR9RK3xrosIn5z0eYf2XiIMOMhgyweFresF5XtPSo1y1an0nP3q k0iyrZfQlZsxL7lXQ5ogmh561ukWXn4W+uKVin/QLHyfMOAGYn+I66GOaYI9EU9Zyy4/ HNQS+I9OHCoFbAfAVQImEcIRZidlBSlCm5tAATMXEdn1jt82xTxQ54aih+l27Aklq3cM a9G+K3vqWCrY+Wre+6C5M/rS3U6b/J59ku1aZDdiSP6gTQTSwombUEbBgGqTB4Okx90T 5DFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707205943; x=1707810743; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nslo2KqQ/crFqeERQmjq+RimgA4EmUsTWWhunmms0IA=; b=gDD8E7/01A17e1329eBxeuDbwvHyjxZ60AtS3/mUflVltDHHyIysvxLwmNRsm4YXfK A+Nr/5mPRt3VPH6KYNJ2rePjyqpysumB4NhL/HfqD2kBGCv9XJtcMbm86zJ4wLEfAhVj hiF+g1P+CnBGV7rty1PxHRUdiGaN7rIDtwLwecFCobHSsVSg9fy1M7/PSi6f5IgCMHAi Nc4jTyE8xVeY514JIKSH3fA9Znggu21GOBfgkzPA/v+DeNoLZZbMrcm/XBdhfbCLVFkH Am9hG+n1MPBuGDB9ZPScfLp0fphCqOzJkipYcalj0Ib2IY2HVTbqBWeNrl7UO61eSKew y/Ew== X-Gm-Message-State: AOJu0YzETx/6isfDIuOfzs4QZ3pqqUNXcZ//+wEvCQhSNjBcrOtDOwxO MLLzL5CPqtNfhlCoExTPmPt8PgQ67jHtMvHSg3Gyv7KxoVSI9I+lOd+bnMB/4o0= X-Received: by 2002:a05:600c:a39c:b0:40f:b283:bb00 with SMTP id hn28-20020a05600ca39c00b0040fb283bb00mr905382wmb.18.1707205943227; Mon, 05 Feb 2024 23:52:23 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUByh8gVDOXfKSjUHDj4WM2iwjOaOi+9J3toa0ywjhR3II4dU3o9/xJri/AmIRviLmjV78QUbbf/HvcU649LBSZdQPKGCk64WxZQD16KXO1YSke2CvHYlX8q1WajPTf1CSR9+uyHq8rJXbkCXCNVl5g4JAErCysyVMxGFiORo5GkNF97ejKsuyNeDv41fvIp5RXaQjIR7aG7BDz3gegTI6uGe6hAWpM2ihYg/kmQudwmFVpwpqLZEjuB9e7ncXiS61MKrDvm7vTwwvkulylQX2AgAkpAlTk2+7xyrQJBnH4lP5pxiAp/hf88OF0HyafUY/uFY2RVujXTtukqZqlgkhY4z5H+X7OhkHjoFyp+Jks+ItdvRkf2OJLMGUPmZintxSbTCbUQi77MZfYSVH2SRPSls5a9lbovCxxo+Hq23ipc/yvd30oTCROiomILHQXVqgh3K0iDTl/g51gT5QLNDDCGOKB0mz5Ik44D9P0o6/BvkRxZupdukyY/ipnR+TItJcxCLfcZ4DcAfVaoy58d6XzqhsJG2yttuR1zAOSFA94+5aAdUM= Received: from claudiu-X670E-Pro-RS.. ([82.78.167.154]) by smtp.gmail.com with ESMTPSA id j32-20020a05600c1c2000b0040fbad272f6sm1106843wms.46.2024.02.05.23.52.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 23:52:22 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, magnus.damm@gmail.com, biju.das.jz@bp.renesas.com Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, claudiu.beznea@tuxon.dev, Claudiu Beznea , Conor Dooley Subject: [PATCH v4 9/9] dt-bindings: watchdog: renesas,wdt: Document RZ/G3S support Date: Tue, 6 Feb 2024 09:51:49 +0200 Message-Id: <20240206075149.864996-10-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240206075149.864996-1-claudiu.beznea.uj@bp.renesas.com> References: <20240206075149.864996-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790140178626897595 X-GMAIL-MSGID: 1790140178626897595 From: Claudiu Beznea Document the support for the watchdog IP available on RZ/G3S SoC. The watchdog IP available on RZ/G3S SoC is identical to the one found on RZ/G2L SoC. Signed-off-by: Claudiu Beznea Acked-by: Conor Dooley Reviewed-by: Geert Uytterhoeven --- Changes in v4: - none Changes in v3: - re-arranged the tags as my b4 am/shazam placed previously the Ab, Rb tags before the author's Sob Changes in v2: - collected tags - s/G2UL/G2L in patch description Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml index 951a7d54135a..220763838df0 100644 --- a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml @@ -29,6 +29,7 @@ properties: - renesas,r9a07g043-wdt # RZ/G2UL and RZ/Five - renesas,r9a07g044-wdt # RZ/G2{L,LC} - renesas,r9a07g054-wdt # RZ/V2L + - renesas,r9a08g045-wdt # RZ/G3S - const: renesas,rzg2l-wdt - items: