From patchwork Tue Feb 6 04:39:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Vernet X-Patchwork-Id: 197179 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1318539dyb; Mon, 5 Feb 2024 20:40:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IHtuKwNasBHgLhHiioKn1r/41nzxw3z6BhTYkN7e1uSa2oIH/1sd87eL6MihMPQEPqJ+KWz X-Received: by 2002:aa7:d654:0:b0:560:4f51:fd10 with SMTP id v20-20020aa7d654000000b005604f51fd10mr935256edr.10.1707194403151; Mon, 05 Feb 2024 20:40:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707194403; cv=pass; d=google.com; s=arc-20160816; b=DS3LAKfNwlRHXwhbBNTHn/WUQN7CtfBAClzI3A8E/51BZeuz2vq1RpM4l6xOSmHeDM OmUuayXI7rVIbGeagffTY89ywFFJ+oD3WJl550PGWYBuI/7Jgn7mmetpVHhRnD8dvp/x xrHhGQUAEB/qUQKbz21FBoRyIaHhVdslCF+x3DHSlJzg1MLaD2pupIXzkAmTzr5kwBTc p4kcJcWrOIbKDyxPARD+c9K8qDffXrvzeDNb5umhJEDQ+mHNSF0PTOJV3kG3iivvDoqW ylVydNii/Sr9i9EPMEa/nekywzTeelPcCgbRz94rSOKKrNDy3CyJh1vkKTQCFUDL6E/e DCEA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=fwyA0iOp0hGdi4UEoMdS/esY5ki+GqxLPXq+pqSYOeM=; fh=YHjYUBfREvMG0490jvG4Wxce1Al1FVh6uyUWptAzOTI=; b=gI8HbH7BheuSDAspmnlLbRtKk0qQRWNCDRTxeXZJROxQsqGruLz7wbB7dTDNxrMIvT XoeqByZZjkKN0uExJUqvibFppYeNEhCusXXzzz3mGbsJjc1UZfq9dta5QcJJq4v8GWhl i7IoDAZMbisY4//kLfmB6wIRRfh4UGLxDUISroLV/8CiN7hmGn/8pyU8kf/M+dKn682m NIxgMNM9661M4Y6sEVvZVHA5lueefYOGlFzabTR/Iwb35jj5ztai/OHAr/0KRGJwZD6N /Vr7omuHdjaYWvPQeuGqfndPgs1o7O2A95ZD0tCcwdN7fx4wvBjUEwOUkbQoi7AkBZxz Y7nw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-54318-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54318-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCVSV6XllbC64gUf9zTgAFZgI4znlyw02K15R0eouCDe9fFAmR7ajsRaklR6oaMFqW2hFG9TnEs4Takvp3WvsZopT8X9NA== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id d23-20020a50f697000000b0055a9b4cc9e5si719330edn.213.2024.02.05.20.40.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 20:40:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54318-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-54318-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54318-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8C2751F22885 for ; Tue, 6 Feb 2024 04:40:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 11C907C090; Tue, 6 Feb 2024 04:39:32 +0000 (UTC) Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1F8677F0D for ; Tue, 6 Feb 2024 04:39:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707194370; cv=none; b=MMTGePwhn8qYmTpChAY241ttXOKMd+c9gHoSdkl3/6OSNEoJfrryipvi6XBgKQPSRpi1PopB9pJfZ02otWJA7X965TrkS4rApT0nWKmOY+b5yo1QERleKsxyeh803svAyuMUamZ05DRMkvmQh8C/hyhG8rbaVfXiOkmYeAymtdE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707194370; c=relaxed/simple; bh=6mkJTp+YntfTBR22eAXEk5YJrTS3d/+TlyZSgog8VHw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u+CjIog98GyG+OJAjQZxzFEe3FpaAfc2dfoQSbXm/1pZAM+cVNlQ15fYw6NQCUvZdQpk+625NI1orArIrzlWbvViO44iK5WobT45VF6/kPlIkVMhRLt/PpplZMbxdF6AtQl8HqQP3wj6KSHGz43ED7QCwCfOprDSAPy5jQSyYmQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=manifault.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=manifault.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-42a31b90edcso28518721cf.0 for ; Mon, 05 Feb 2024 20:39:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707194367; x=1707799167; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fwyA0iOp0hGdi4UEoMdS/esY5ki+GqxLPXq+pqSYOeM=; b=eEeDYCzlFvfGcDcmZ/d2lmQuC1im7AiGHSTo+6zrGu4f8Z2HtiKRB8LfAckeafmavM U0siuZRXIOvM9/JZlUii0/8MvLbcWygwxEDhiU4l1pSmQQ0pySZqmfU9PdhaHUg+ByfZ C0UyKyLq5wAeEalSixkeu19yQhR7v8S6qtvtkWj9aOF6tD1WpWmZ442EXx7qCkGxgzs6 P34EU51h0FVEMJtRJcyCWmiW97TsbuNZ08C2ZrxUvat/6t4/JpALMGRt0OvtR+LzRd0G yZkQW0fZng2/9tmf7f9IhrbToTlnU9tYxGboqyly2fd3Xo5DYGLcwVjcnUjqXP2+flaH boyQ== X-Gm-Message-State: AOJu0Yw0zjKcSsTOEQu2f4dQJVRv7FD8ttmmfKAjD311m5aK/Gy/Z1sv j+RaH8/rPzU4KS9qj+5hyDD2Mcktw+Fe3XtJYIYgMfDYPgkWdCeYFWky3Ie5Fn2OGQ== X-Received: by 2002:a05:622a:1a92:b0:42a:a6ed:5440 with SMTP id s18-20020a05622a1a9200b0042aa6ed5440mr1915358qtc.3.1707194367154; Mon, 05 Feb 2024 20:39:27 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUQYkQrg1jQLkKhWe1/10W7B7YSHqfVYXEEYIvRxdpvHy25dCnd14XITuhu+gFuHGAxIsgcC6ZVdscA9v7wNU3xIQ00UQYpkUvi54s4VwYrEohSnnn9HyR0pHp5lVh396m/7yALTspVKEMFVbZewwGSUhhe22ATxjHzOvBbCWhBtVUN3ZeLJ4fL/PCc1H2lwdqg50cWOZHte/fggiX/1IDcGX1dEBYY9ARdKUmCWrKj3pBnOPqH7UaSz4vp5+lBY3MivKqKJ5Ox0eMJPddv3yzfROqvZoV2WfvyO9YTwLsSqbuILXI= Received: from localhost (c-24-1-27-177.hsd1.il.comcast.net. [24.1.27.177]) by smtp.gmail.com with ESMTPSA id j25-20020ac874d9000000b0042994b3c20dsm570517qtr.29.2024.02.05.20.39.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 20:39:26 -0800 (PST) From: David Vernet To: linux-kernel@vger.kernel.org Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, kernel-team@meta.com Subject: [PATCH v3 1/3] sched/fair: Remove unnecessary goto in update_sd_lb_stats() Date: Mon, 5 Feb 2024 22:39:19 -0600 Message-ID: <20240206043921.850302-2-void@manifault.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240206043921.850302-1-void@manifault.com> References: <20240206043921.850302-1-void@manifault.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790123078633273597 X-GMAIL-MSGID: 1790123078633273597 In update_sd_lb_stats(), when we're iterating over the sched groups that comprise a sched domain, we're skipping the call to update_sd_pick_busiest() for the sched group that contains the local / destination CPU. We use a goto to skip the call, but we could just as easily check !local_group, as there's no other logic that we need to skip with the goto. Let's remove the goto, and check for !local_group in the if statement instead. Reviewed-by: Vincent Guittot Reviewed-by: Valentin Schneider Signed-off-by: David Vernet --- kernel/sched/fair.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index b803030c3a03..e7519ea434b1 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10578,16 +10578,11 @@ static inline void update_sd_lb_stats(struct lb_env *env, struct sd_lb_stats *sd update_sg_lb_stats(env, sds, sg, sgs, &sg_status); - if (local_group) - goto next_group; - - - if (update_sd_pick_busiest(env, sds, sg, sgs)) { + if (!local_group && update_sd_pick_busiest(env, sds, sg, sgs)) { sds->busiest = sg; sds->busiest_stat = *sgs; } -next_group: /* Now, start updating sd_lb_stats */ sds->total_load += sgs->group_load; sds->total_capacity += sgs->group_capacity; From patchwork Tue Feb 6 04:39:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Vernet X-Patchwork-Id: 197180 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1318591dyb; Mon, 5 Feb 2024 20:40:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IGERkp2UqnUbuhkDrpnTHL84ga6s+xuifym92Luk2b4PQSnUoWvYFodZC7wSlVNVa82Y9y/ X-Received: by 2002:a19:c215:0:b0:511:5040:f6e4 with SMTP id l21-20020a19c215000000b005115040f6e4mr873096lfc.56.1707194413294; Mon, 05 Feb 2024 20:40:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707194413; cv=pass; d=google.com; s=arc-20160816; b=gsSqnWFVltsJpEx7r5hDkasp9sIXzkc6lt85qgtZwRdiHAnI6u+FXMv3YkLwcwo/Ci JhPQuQmluh4U3uvcjTbNRSk82Y0+LvfGAW2gJTQylVltqwZr/HVxbqIyq/33ipSfF1/a 5NYPIT94joYewfNtwHvgyqGWLef5szREy91HykpSxxKHKNF7jcW4/+POOn2guGgWZgJs uXLLLeRVH2eZGDENmK6eLieE7v4gEkt6IEY3PX6rsoi8ky0eyLG322gnWdM/1N2Txafv qjxeerPtREZJ8UL0RRpY0Z3pawZdy6HY8uvLHjw76ASNOwMd+LGx9+Xpv+rIwsfgWotm WAUQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=TIX6iuoRN440ik6kRv9x9Dd8FfCsaf7euCk0kuQlv08=; fh=BHq3KJie4j+T1G4gFozHLgT7ke5JGsvvScK5B7LEBd8=; b=XUp6ev0DG17eYCUzr3iO22fzxO0vgk7XQpbf0GyvZuMHdjZA9Nm6A5WXO+xaAhZWeE LNc1YpDdnvSi6eYjuV3eZHviwCj0C6ArNQz5kkcLi65DA8VHRCxZEdtbRpUFFOKqFl2z T9wSJzB4uZujcmeF/3RKa77ceYVVNVf6g7JfnwOavNzlO6pw8jghdGTjm1sqj0K5KUzh +1Bisk/gHr3K0Aqb3aUMPEv+uIac1/uGgu0V8ZHtqvUz8KDcb1E83qYXYDd4gJa3OAuV b5E3ksh6wcyKOubGIzYECRI8k9lpogofgrAvNA8PGb8sxLSav2ECYcmzSfN4mHm+ry+O yFJw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-54319-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54319-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCUvt6hxRFJNy7yc0ol1Wp6TdqVRGKSAhFid+tfv/8t1+6QE2lp1HrtLHiITvyVXL99FMXOnlHVb+sN2p8PJio/dC36Sow== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id jx10-20020a170906ca4a00b00a366a6e72b4si622135ejb.715.2024.02.05.20.40.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 20:40:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54319-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-54319-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54319-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id DA1301F225BF for ; Tue, 6 Feb 2024 04:40:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 265B47C6C3; Tue, 6 Feb 2024 04:39:33 +0000 (UTC) Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1A8978B5B for ; Tue, 6 Feb 2024 04:39:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707194371; cv=none; b=JeqMDT9e8G0/zIVVE5cDJrM6Lsf/V5HKsrpbkMyJq/5UHsSx4z4zT0kVeW5f5GiRMenWKIUnmR5UtGXY2F1bj7nsgDce7xLvAu0Mmg/JaDKYeUuMZPXKL7+4rIc/M4BYW+uSIB2jdKxsnOyo6bFGUp3apa2rzREwS8JogVsqluE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707194371; c=relaxed/simple; bh=/yBd5sGe3byMVW8sDxeCS54/0Z37uF3CUIi/XstrLJo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KNFeIEaFF1CGbCmfB+gkcLphhDk7UcYNlrLgKARIG6aNySiIs22VOaZ5o2KZLXpeSrTS+keFPXhzvOEfBx0VrMW8/0XJgnoB336yDS3xzWipxijiHPeiXBRgv7ji7h2HDK2t0XYZs4u1YVrKharmRw87dsuFefyaWIx0ALEdscA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=manifault.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=manifault.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-783d4b3a026so306313485a.1 for ; Mon, 05 Feb 2024 20:39:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707194368; x=1707799168; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TIX6iuoRN440ik6kRv9x9Dd8FfCsaf7euCk0kuQlv08=; b=JjMw7DZ/Zem8tGI1B287dMck9mLtWnBuqznI6w94CdMI5bm2Ve6GsP+ODJYCWRm40h m7UrxRWdc2BRR+dsH2Zxo+s09SJQzZ11zJxS0gPDGWG+ear9koUg2kuqrlI6vNpAwjS0 5Cd7JEts4H1ihCkTVsuGP0PvbQA8iIJPS2GnuIdhhNQsKHbacicCcxgSexlaLMWij0YB miJfbSD3djqTAQrkDj8Xb9rdMaqp6A/fcFfoHI6xSfid7iX+IyXuXuLxdFemr2a4MHjr wdjDXw1wZ0ID+xJjXCXSsmFQ9EdZpfp/nKFo5bcpYxd/6L0bmVlGCCSKanAa2tk2dinb wGhA== X-Gm-Message-State: AOJu0YzZ/kpp17aHjTWPsXF/l6qzTYa9gWm0r8eBTWiWx3FdmCm+M+k6 61FnaiLND3H7Z2csctWg3yJWD6qwnMo5iXRA27X/n1LDScNttdgU6uaE2GOZciqqZQ== X-Received: by 2002:a05:620a:b8d:b0:77f:8a87:ebfd with SMTP id k13-20020a05620a0b8d00b0077f8a87ebfdmr1060218qkh.41.1707194368565; Mon, 05 Feb 2024 20:39:28 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUgawVg/8epGHYSQn5u9fEP0+FbcAkJEsMGMiA1exxndl2m3HCeu+0Oih2o/j9ee/jC741kzplIXOUSpbHhojMejoJN/wdRAPsrBnE0BhRMWwY9WAIbpg/mcuunBJezmBwiiiIdegzHULCnUpVuyDgqD1o3Vya+cd+Pj9EtXhQCTZEtil3/aMUha7uZ+NNpRbUhvB7aMfgpGP5Cjb/0gtNagl7pT1yLl0LrxYNs7V+F+TpQubS0KO91RDnCRHG0z6uoj6v56agPFuwkLBT2CoOJ9I6/rhHagU/k/oRTAXQ4fMM/q04= Received: from localhost (c-24-1-27-177.hsd1.il.comcast.net. [24.1.27.177]) by smtp.gmail.com with ESMTPSA id f6-20020a05620a15a600b00783749b0d2fsm577757qkk.94.2024.02.05.20.39.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 20:39:28 -0800 (PST) From: David Vernet To: linux-kernel@vger.kernel.org Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, kernel-team@meta.com Subject: [PATCH v3 2/3] sched/fair: Do strict inequality check for busiest misfit task group Date: Mon, 5 Feb 2024 22:39:20 -0600 Message-ID: <20240206043921.850302-3-void@manifault.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240206043921.850302-1-void@manifault.com> References: <20240206043921.850302-1-void@manifault.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790123089375250109 X-GMAIL-MSGID: 1790123089375250109 In update_sd_pick_busiest(), when comparing two sched groups that are both of type group_misfit_task, we currently consider the new group as busier than the current busiest group even if the new group has the same misfit task load as the current busiest group. We can avoid some unnecessary writes if we instead only consider the newest group to be the busiest if it has a higher load than the current busiest. This matches the behavior of other group types where we compare load, such as two groups that are both overloaded. Let's update the group_misfit_task type comparison to also only update the busiest group in the event of strict inequality. Reviewed-by: Vincent Guittot Signed-off-by: David Vernet Reviewed-by: Valentin Schneider --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index e7519ea434b1..76d03106040d 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10028,7 +10028,7 @@ static bool update_sd_pick_busiest(struct lb_env *env, * If we have more than one misfit sg go with the biggest * misfit. */ - if (sgs->group_misfit_task_load < busiest->group_misfit_task_load) + if (sgs->group_misfit_task_load <= busiest->group_misfit_task_load) return false; break; From patchwork Tue Feb 6 04:39:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Vernet X-Patchwork-Id: 197181 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1318669dyb; Mon, 5 Feb 2024 20:40:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IEyyX08SEE44aEiKMoER+Ww+HLr5WROwROGJOYDv+XrdS7fPpK6S0MngkUa165td0wxZzBi X-Received: by 2002:adf:ce0f:0:b0:33b:21e4:68d5 with SMTP id p15-20020adfce0f000000b0033b21e468d5mr361589wrn.34.1707194434561; Mon, 05 Feb 2024 20:40:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707194434; cv=pass; d=google.com; s=arc-20160816; b=o7f+5Zwv2csfJetUUxAjcL/WRicOf/AmQC8maPip1H7yYjQR4JaJtDhkQFm8sggd83 b/gWScSMUYGA59Mtt/dEL+rfeHB+nSZguXzOFXxMAzIJXEMHrQrsfloRMshIUkzWXoKn CLJiAjh1nW0N49kIOFXkuMUO+UfEBOd00TBcwzhSwMw3ndK6y2bST6WCK5OGN/WN2r4w htzHpMmShi79u3wfBmxI9COUIOxQ8ANbf4kM8foinilFUk1IG/Y9BUechkZF5sUh5XBX zw+LvfGT8jJk5Q7gw0wANHq43Yidge9EbpTP4yiUjydLoIYMJGmHIzDzwSvTFNSMDuwr WB6g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=OweXHWUMGZlBLk7CQUqL8P+eAADd+iVa1P4u5q9wuCA=; fh=lhoQ/6L4/vx0uBcNBaRnfWpqHTe9CIWMFEWyj0Xsv/Y=; b=G5pdZTvg984DDBxEZVNx72Fv3H2vTcF7sHsrHjC8A2jIvl6XTzqLShTkoeBXG+x0di Nbf2VhimIyx1EhqnP0I76xUK0u3SdhsoQO6fWh0jF+GIuAEzVeg6+2RrqAk8g7yqnlHI 0+IjqUt/3PKqiO5OsGEcvQI+GQldHEvIVXSR9lvgQnmHW4z5yFUlkxNIUshUNl32TZk5 OrJo6UC1puem+4xjRqJSpxxJBPD0S/gTo0mg9lUyTurCDL9Z+BnaD/Jt4i1WSdPb0i0Y CNjH/8UqSwHIvD1FbpdtEeJUUhBx9WAzuS95P9A8m4Ez0jIJc+Op/+oMPb6RAWPtaWPq Eg9A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-54320-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54320-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCUd9P+cLQmMJs8ASaZiLbfW+sp40s4LCS0GehXJ2X0lsOXEjYfZNXUwM/1JCSGYisvvJQ4InEoWL1AwtkZFeoZCjzGDOA== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id j10-20020a170906254a00b00a382bbb3f43si177582ejb.477.2024.02.05.20.40.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 20:40:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54320-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-54320-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54320-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2EBDA1F21182 for ; Tue, 6 Feb 2024 04:40:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 205137CF24; Tue, 6 Feb 2024 04:39:35 +0000 (UTC) Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E66E57C088 for ; Tue, 6 Feb 2024 04:39:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707194373; cv=none; b=mkEjixLMhAbcVFtGPQ2bsia9spPaDbSDSPrt/Qt4VSHp7m2CFHJySM1ArHtFwvsfMJ0VmtrY8UmKLNmQOK42swHM4Kus4T6sdq58aoesZ1wMsLH1N/P1efltEZZ4ctS6zA/0HtbVa/qB9ldEqgkgFOOHtKdd2hpmR3mv86eZWfQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707194373; c=relaxed/simple; bh=D0GWn07QSrQNKcLM0EZX6f62nVaGa9qePJ8JuBS0Phc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C2Xs6zTeFs2mCEuo6OfDCt3S2WH/yaDM5eEA6qzVrJlcdQvBCUkHglXS0nijE4jNvz6gLGrN6u7qHyE0LUB/ho12LJRxkChPqUJ2fkViG4/2Sux8FmKJO1Ub2jJ69KJG0RgMu1CRyXcVbPICfDBu2pkegCkDeV+luz//54wEcl8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=manifault.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.219.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=manifault.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-68c794970d5so1499356d6.0 for ; Mon, 05 Feb 2024 20:39:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707194370; x=1707799170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OweXHWUMGZlBLk7CQUqL8P+eAADd+iVa1P4u5q9wuCA=; b=s+34o9Lo7gaR+7862p3T4u3BguXCwUF/04Wk6Mhou61MyoBvbRRIlx9LuE51diomvv xwxIUyAFKXrwnNdEGcYz2QD7dJKaEoCQYzm6l7ahPIKWL/85D2xH+b9yCiQs8AsDDJLC TntNnbghvPpJIvwPx9yVxJQgd2e6qFSZN9xVKZeddPxa5h4mQElnl+So35l3uBABeLgs d+PPSZ81n8YzVwzU0pb9GONr7u9GcpheJAjVXdcsH33v0w2T7v7a+W2HG+QWL/SsELNp FHmDHNJQc/lv5ZIZ7gd5MXdLIW5r6cM/9iAMRrXq6L8ScDoPLfmK2sBiaAlZBVQRPQ0e eiHg== X-Gm-Message-State: AOJu0YzL/Yu9B+xSyWCZXdpw7VPov+65f/novCyigkSw7BWr12QR4PGY GGjCIalb5shxikLsN/q+aC+7LW/zGaVwYnO833SmkZwRge3QhzQF9YEMegqJbs9cLA== X-Received: by 2002:a05:6214:1d28:b0:68c:8218:30a2 with SMTP id f8-20020a0562141d2800b0068c821830a2mr19466751qvd.0.1707194370393; Mon, 05 Feb 2024 20:39:30 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXB1wpEtOw8AUVfamqVIhtmaNPh6FPGwA2PmblCOucWpKiQRbP+BXxOBdLCHMdyOborem7tLZ57EHPgpRd+APgTYiK1ZS1vyrAusIYSyQIZO4ZFr7lKnovzUyv3r5MQJDSZ5YwZLPGUwKY7i2UQpN16Ki3eYT007ocCN2IXFCJlAxG51hf0RP03NoCPJrHEXBH5r3jSPe1++5ExseB+V141RZ5cYAbc4UZGhVXoMv3CguHKD1XX1FZhUT73xjaMByYlcYzGaoX+rcAkdyyzfIDkLzv1WGRqRiMUPzCi3vbIl74lkVc= Received: from localhost (c-24-1-27-177.hsd1.il.comcast.net. [24.1.27.177]) by smtp.gmail.com with ESMTPSA id f7-20020ad45587000000b0068c81299a2bsm671836qvx.15.2024.02.05.20.39.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 20:39:29 -0800 (PST) From: David Vernet To: linux-kernel@vger.kernel.org Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, kernel-team@meta.com Subject: [PATCH v3 3/3] sched/fair: Simplify some logic in update_sd_pick_busiest() Date: Mon, 5 Feb 2024 22:39:21 -0600 Message-ID: <20240206043921.850302-4-void@manifault.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240206043921.850302-1-void@manifault.com> References: <20240206043921.850302-1-void@manifault.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790123111050466676 X-GMAIL-MSGID: 1790123111050466676 When comparing the current struct sched_group with the yet-busiest domain in update_sd_pick_busiest(), if the two groups have the same group type, we're currently doing a bit of unnecessary work for any group >= group_misfit_task. We're comparing the two groups, and then returning only if false (the group in question is not the busiest). Othewise, we break, do an extra unnecessary conditional check that's vacuously false for any group type > group_fully_busy, and then always return true. Let's just return directly in the switch statement instead. This doesn't change the size of vmlinux with llvm 17 (not surprising given that all of this is inlined in load_balance()), but it does shrink load_balance() by 88 bytes on x86. Given that it also improves readability, this seems worth doing. Reviewed-by: Vincent Guittot Reviewed-by: Valentin Schneider Signed-off-by: David Vernet --- kernel/sched/fair.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 76d03106040d..fa049f866461 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10006,9 +10006,7 @@ static bool update_sd_pick_busiest(struct lb_env *env, switch (sgs->group_type) { case group_overloaded: /* Select the overloaded group with highest avg_load. */ - if (sgs->avg_load <= busiest->avg_load) - return false; - break; + return sgs->avg_load > busiest->avg_load; case group_imbalanced: /* @@ -10019,18 +10017,14 @@ static bool update_sd_pick_busiest(struct lb_env *env, case group_asym_packing: /* Prefer to move from lowest priority CPU's work */ - if (sched_asym_prefer(sg->asym_prefer_cpu, sds->busiest->asym_prefer_cpu)) - return false; - break; + return sched_asym_prefer(sds->busiest->asym_prefer_cpu, sg->asym_prefer_cpu); case group_misfit_task: /* * If we have more than one misfit sg go with the biggest * misfit. */ - if (sgs->group_misfit_task_load <= busiest->group_misfit_task_load) - return false; - break; + return sgs->group_misfit_task_load > busiest->group_misfit_task_load; case group_smt_balance: /*