From patchwork Mon Feb 5 21:55:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 197066 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1178315dyb; Mon, 5 Feb 2024 14:13:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IFulCm7SK68DI04kYzkpQS9dPpysvQjamD8H7ksXyAnTDkKd9U0YpNraFuZ4nTEW1D3t+xI X-Received: by 2002:a17:906:3291:b0:a38:328:1219 with SMTP id 17-20020a170906329100b00a3803281219mr624871ejw.29.1707171239260; Mon, 05 Feb 2024 14:13:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707171239; cv=pass; d=google.com; s=arc-20160816; b=DZjIn+15wH7KfNtGRvHWSdr4ZyK3n89Orn5qt2LDTtEfrWfZsmQYOBZsD8R8IT/DO1 fikOJt27P5GdHwlE17cm3JDYOczu3ipFghotJ3CyHqwcE+YzXwWKXeA0TOZS/8H6ahZK QQT9SQLjH+G7vjQSsY9y+MpPOzNeiD40phP4lMrvQkShm45hIGlMwR6BaY24ulOUPvlb 1Zx1Kjv1V9D3dK5le3tTYSUrnFKz4N0rHe3v/pqouyXjEI46D+tvZ3FfomG1m0CQvnds 2noagn2rOdqm9LRP2Jp/hkIuIK5TWOiVLYnIH8kkj48CFgDXViaLPJFzwxk9lVGVU0mB QsuQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=ANHA4FLKX0KPJT+zhyykPfhWKQ9mfjg93YYvGw4tTjA=; fh=uamswB1Cd1QLHLq4oe03yYiZUR7WNpmJevwMefhY2DE=; b=a/Y67WyXtahJX48UQ4TLmKyglibPpnMaqOor7SHX0l+Y8kXxMvg5rahNEdPuZ2yn6X q4I4y5y5LhVcEPW8Fkc22JbggaABobKd4w+qlhVWXJ5BG642w9wFHAQRfBp7qub1IY1G RWRJpMhmj+KZm2JrG56SLybxAikVOfCk53FOBI7TYzX4B0guUU7LxH0i91vY9sspkedH MJ6hJB5wX40um2m7xCXxzwCN843d8fFzv39BrbEIbq/ADlilWfPuDYPpvFJOzsGnt7p2 vu5nUEMBz1viI9mqEBL/CT3+dNvL1pwJDhWxHGo8NL3yYy921tVFZOb/7ODmbzZJrquj 6vug==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=EDz762u1; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-53988-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-53988-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com X-Forwarded-Encrypted: i=1; AJvYcCUKgue+Y+RIcR3K+il5C2fVsSOMkw1X51oKMmS9NS1lYEMbtC6oE8loT/WDxYOGNqT9ImIpQJ+PLUuCitBA+Dl2eRZl0A== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id uz25-20020a170907119900b00a37cbd2c2e8si271766ejb.669.2024.02.05.14.13.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 14:13:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-53988-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=EDz762u1; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-53988-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-53988-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D908C1F301FB for ; Mon, 5 Feb 2024 22:13:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C7FE15D8E0; Mon, 5 Feb 2024 21:55:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EDz762u1" Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91DC7487AB; Mon, 5 Feb 2024 21:55:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707170135; cv=none; b=jY/PDqMwmqqHwNq2P7ZRO0ZV16LyP7UB2y+AL+n9QGJCcDWNrAdV3ztA7jzhFr6T5ZTDylh3bN6s9ESdV97Xe9X2pIwRoLe8LUiCM4k/PpuNNB/WDeLdE2MYzZnJBRt9JsUr5xe0b2p+f8nCo/OsopQl1FAVlMYDhr7ltkfG3l4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707170135; c=relaxed/simple; bh=H0fLTAzZF9M+Hdp0/173Ijbr/B0GoqE0ZGzVwCP9LRk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=oh9nwuoUh5rzBxwvI9XzkGE7KuZ5n2TT6KocaTrctpgl5a/s7CKDn15ghpk5AFWNhr+EeP0BDAUATH+cpOdYuUN+wT2+t5Q5udWdTssSuy+Fz8qh3cjt6ERC2I0QoOGs+743hQSH1foAIBin2Mf5Efs7Asx0qh/TkK5vJByXC2I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EDz762u1; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-40efcb37373so1622515e9.2; Mon, 05 Feb 2024 13:55:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707170132; x=1707774932; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ANHA4FLKX0KPJT+zhyykPfhWKQ9mfjg93YYvGw4tTjA=; b=EDz762u1hchvT2pYPBQ/lgHzpfXw8SVpmUxdQd1nUn+gkZX0y7HdQVN1PC1SY4K6bc jtaCH19gVx/PnP3x84iSPaz5M6Rf2VN75kWgPn8MUQuWXED8EDWGdQIPNq6nd6CZCQzt QnGakYCAU250N9PnsgeXyphBm6AL2iZtz2rG6L1CvVBGwuBeK/UnzxOzKFvlj8SF/1DZ MDec3zklA6xAjGl2B8+vDtMDaxvc4Z+68hwwynI/O/3P6jd2IWApY7W1j4bH9R1EZd5t gbQvPUCkExRtpy1R2VesKf36Dv4dQt1vRHgETbsLMYfgWvdbY8sEtMdYzdhP7r/h/ATm BcpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707170132; x=1707774932; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ANHA4FLKX0KPJT+zhyykPfhWKQ9mfjg93YYvGw4tTjA=; b=Zk7N5kMsym7o+UPYQOpisX8WMugF/mxPlJToOHeV/LM+CD/IRvywx0oSCim7efU/fb 6+BNIjc0ctmNIJWU9TamJyZPMKIN5bJ2SVH/IOeJa0sOEk5RL3hBqcJkYWzEu92gGDLa bvPt7ErNg2QaGLNGwKLycFRRBGOyRXbpPmlzy1YFE+Dd4j1hHGNbTKXp+u2J9U9pvSyx Zlm8oC6gDTiL+aoRjqLda4jVjSRz2U4E45UoNvr78UQG0rOoMpRixxBm4si/7mjyhHkg zT5OpQ2XB+1D4Pr1IbVTXjR9nqp/PKYG4azOohoctONUPZo2WUF6EfRyKc2z7TCX/V3d mnWg== X-Gm-Message-State: AOJu0YxmxdH73cpvVnoJugdrvGslcd/0414du24od2z7RBvJbELqJfDZ +XK1JbQAaH6MGquXcUwUnGsRG2NP8AteicdAXnKKYK+eeRoW0suw X-Received: by 2002:a5d:4c81:0:b0:33b:3d28:ef22 with SMTP id z1-20020a5d4c81000000b0033b3d28ef22mr703885wrs.49.1707170131584; Mon, 05 Feb 2024 13:55:31 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUCAmPKnQXjGh4euXZrhV4VT8/ijih7Zdk5hW0W3uPscwlWviKbV7lOlGMpF5XW0bCZf1nZIxuM+CEQSThWP169A+8EZJuRBwbGB01txfNOEdVizMMe5jZ8uYoDLqx3wrjYWzYQx4OhZO2EwvqbRCFce7DBBFvZVEcLc+qMM/dVTuri5avHKvGrh+fmvsb8Ksl82b3FgmdyEDikRCCL/LsOq4zr9FXxV7AsfERkbXRBg7enWBcZZTxUAtltfn9ggz2dWfEiJEhnm7ZCEDy2trWrRwjHlwFeeNLbENVTonLs Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id h6-20020a5d5486000000b0033b421e651csm524355wrv.37.2024.02.05.13.55.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 13:55:31 -0800 (PST) From: Colin Ian King To: Ariel Elior , Manish Chopra , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] qed: remove duplicated assignment to variable opaque_fid Date: Mon, 5 Feb 2024 21:55:30 +0000 Message-Id: <20240205215530.1851115-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790098789256122197 X-GMAIL-MSGID: 1790098789256122197 Variable opaque_fid is being assigned twice with the same value in two identical statements. Remove the redundant first assignment. Cleans up clang scan build warnin: drivers/net/ethernet/qlogic/qed/qed_rdma.c:1796:2: warning: Value stored to 'opaque_fid' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King Reviewed-by: Simon Horman --- drivers/net/ethernet/qlogic/qed/qed_rdma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c b/drivers/net/ethernet/qlogic/qed/qed_rdma.c index 5a5dbbb8d8aa..9a1660a12c57 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_rdma.c +++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c @@ -1793,8 +1793,6 @@ qed_rdma_create_srq(void *rdma_cxt, if (rc) goto err; - opaque_fid = p_hwfn->hw_info.opaque_fid; - opaque_fid = p_hwfn->hw_info.opaque_fid; init_data.opaque_fid = opaque_fid; init_data.comp_mode = QED_SPQ_MODE_EBLOCK;