From patchwork Fri Feb 2 19:47:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Unnathi Chalicheemala X-Patchwork-Id: 196012 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:9bc1:b0:106:209c:c626 with SMTP id op1csp662728dyc; Fri, 2 Feb 2024 11:48:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IFhVCEoDs7b6//hc4TF3WIUmiL25Be5m0mQ5CDNvUUtDokLvletCqa/MZG7nzwk6KAt+FoS X-Received: by 2002:a17:906:b2d6:b0:a35:d634:ed71 with SMTP id cf22-20020a170906b2d600b00a35d634ed71mr6270090ejb.23.1706903310147; Fri, 02 Feb 2024 11:48:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706903310; cv=pass; d=google.com; s=arc-20160816; b=IyRpNLoDCyJPG1T16+jXzxS53zcJd1Bn0GmGkvSRXq1m+97CauqSbG6G+9e08McfBR oU7YYKa8HKUo2rneLgjxG+TC4xxCDEv+3YEb0HMWsTu/D8SNzNED9e3LJeG0Q2CRuWM8 ar9p+WYmzE8/F1gAcDIIZKRESFg0ZgKiOH1u1xg+lrdMONL2fqoAEHllPFPlk8Je7ziR RIUg9gC7dXslC1/ri573VZEq//Rm+pKFeqgsWgNIRmv9YPqg2Edi7mCuhN2ZCA5FGPG2 +HdpdejEoIed4syJfBx0SsYBjoQna+8Zs0HndUSic0nFGdwhpHckfKTCfB7hcE2Vj5+Z RIJg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:message-id:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:subject:date :from:dkim-signature; bh=gq4o9jWhaIfaZM/pumBcf3agGL/sUeHK1Fv4y5qvKc0=; fh=G7TYeac4B/7AUg/MAk+yua0uSItXJe5tGmOHCRd3aNY=; b=TFkq+Mh8cTvLDceJDC7U63RfeDbKdwo8WsTw34U24zTHura3KmPQ6ZGmUO+f6UWIRl bbOZ+hUsb+ymW3A8sMC0RFAP8xCXPQ7wcx3BXvfHoHGEcNcysaEpOXcIBnVDTT5KfRba iKwPMOVPpo90YWeoVr4psK5Zn6y8bQy6jaofsvCbR903II1VRTA+vhbArUPw12VYK59/ 3MIk+ByxKZNf3AO04CT08LfZtflcF36f4AXBQjDvPxHklhSfHTDe4Cn3M/53jsRyYWSM q/O1jTqU+K3LxpE+ebgVAJCYgTN9ncdAXFGUUJqBTY2sQRMpDxfScp1Zv3gdTobVjhdN 1BKA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=oJZA58Q4; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-50498-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-50498-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com X-Forwarded-Encrypted: i=1; AJvYcCV0/gCwv9thgB40OZHxlsId9q1RI2Ha6G3AV4asA9biPdXVaGyO8Y8vHOrJg3TlOvwUS0LW7TPbt7nEM3u5Xq839/5wvQ== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id fy23-20020a170906b7d700b00a36f8110415si1036584ejb.935.2024.02.02.11.48.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 11:48:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-50498-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=oJZA58Q4; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-50498-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-50498-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 950F81F2322B for ; Fri, 2 Feb 2024 19:48:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9DACD80633; Fri, 2 Feb 2024 19:48:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="oJZA58Q4" Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E104215E5B0; Fri, 2 Feb 2024 19:48:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706903292; cv=none; b=dVZMDSdthN3AHWYL/aobD5GAVNhumjGolEqm0xSFLT/n9bVzhe2cCsziNti5byt+ZuDYqX1eLj9KR05OzZTh+EXuRwuOk2hCm+1ghIypA2M7mD4OIVawrx5LRdZv04J+xD3gb63vkc2ROWgipeBSwMwlCa87ehGrCH439GU/mMs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706903292; c=relaxed/simple; bh=3oCXU5oLOkCP1EmBxyuE3BXoh2axCVFn3sXB5wmKqx4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:To:CC; b=hJrrhA4evLt6dbfGbNB/0JVwG41WJwRoWQllUtwBwjn0qnyVQkpMgyY8jYhc4dM4OT6AvwBLOl4Cjoom2jnZkf3Ne5ANg+fd1ybVrVHTfONkvrUkQxsqWyiakNJdDEqUQ7cj+8Egk8e98b24Yj3MSKFUkyNAproZHsdm3sz0/bY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=oJZA58Q4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 412DTtNP008603; Fri, 2 Feb 2024 19:48:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:date:subject:mime-version:content-type :content-transfer-encoding:message-id:to:cc; s=qcppdkim1; bh=gq4 o9jWhaIfaZM/pumBcf3agGL/sUeHK1Fv4y5qvKc0=; b=oJZA58Q4aOUmsZy4lxE I3L1+cSgbC3nFYhCJn2zrUUEMlaglUJEFdC+DMEPyw5jr5EiFMvHFb0JALmiMCis wl+mpJ8j/Kmq+mErTU/XgotORenhTFXzBiaQDHs6xFETaG2BMEcHWsosY5IJBHKf 28Lfk0TkJW+0PmZDXXKI3gATMuYnF7OC//wRb42pXGTH+hQKuO7D9OaKwO18uVb8 LLupRh3KOUrslSSnELF1KIhr4xPCrCUwRh05NuurxeYIiPrtcaGhW6Nu+Qp06jtY uKfXX2Ph4ivY3m9oM76qx2XAD5CD1RauISftlYBTj0xznZY/xzDFioenPF49vl/v jSw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3w0ptwacjb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 02 Feb 2024 19:48:06 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 412Jm54q013580 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 2 Feb 2024 19:48:05 GMT Received: from [169.254.0.1] (10.49.16.6) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 2 Feb 2024 11:48:03 -0800 From: Unnathi Chalicheemala Date: Fri, 2 Feb 2024 11:47:43 -0800 Subject: [PATCH] soc: qcom: llcc: Check return value on Broadcast_OR reg read Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <20240202-fix_llcc_update_act_ctrl-v1-1-d36df95c8bd5@quicinc.com> X-B4-Tracking: v=1; b=H4sIAN5GvWUC/x2MUQqAIBAFrxL7nWBhUV0lQmTdakEq1CKI7t7Sz 8DAvPdAosiUYCgeiHRx4n0TqcoCcHXbQoq9ONS6NlqgZr5tCIj2PLzLZB1mizkG1Zped458bxo NMj8iSftfj9P7fhaWvgxqAAAA To: Bjorn Andersson , Konrad Dybcio , Satya Durga Srinivasu Prabhala CC: , , , Dmitry Baryshkov , "Unnathi Chalicheemala" X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1706903282; l=1046; i=quic_uchalich@quicinc.com; s=20240202; h=from:subject:message-id; bh=3oCXU5oLOkCP1EmBxyuE3BXoh2axCVFn3sXB5wmKqx4=; b=Q0AvVESI3f/xUctl+Ynr7fgvkuJfhQ8MToZPQ7gzOo0VS4UIEBVFLwlnAUtLu39v+9kQQREk4 N/v9iRhStxUDvVuEGocC2TsfgObkoaQEEjU+i919GBNDXKCEtWXKjO1 X-Developer-Key: i=quic_uchalich@quicinc.com; a=ed25519; pk=8n+IFmsCDcEIg91sUP/julv9kf7kmyIKT2sR+1yFd4A= X-ClientProxiedBy: nalasex01b.na.qualcomm.com (10.47.209.197) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: o9MiPB8ZHQiKyF16kcAxMiL6-Qth9HWN X-Proofpoint-GUID: o9MiPB8ZHQiKyF16kcAxMiL6-Qth9HWN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-02_12,2024-01-31_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 malwarescore=0 mlxscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 mlxlogscore=811 adultscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402020142 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789817845030289479 X-GMAIL-MSGID: 1789817845030289479 Commit a3134fb09e0b ("drivers: soc: Add LLCC driver") didn't check return value after Broadcast_OR register read in llcc_update_act_ctrl(), add it. Signed-off-by: Unnathi Chalicheemala Reviewed-by: Elliot Berman --- drivers/soc/qcom/llcc-qcom.c | 2 ++ 1 file changed, 2 insertions(+) --- base-commit: 021533194476035883300d60fbb3136426ac8ea5 change-id: 20240202-fix_llcc_update_act_ctrl-64908aed9450 Best regards, diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c index 4ca88eaebf06..cbef0dea1d5d 100644 --- a/drivers/soc/qcom/llcc-qcom.c +++ b/drivers/soc/qcom/llcc-qcom.c @@ -859,6 +859,8 @@ static int llcc_update_act_ctrl(u32 sid, ret = regmap_read_poll_timeout(drv_data->bcast_regmap, status_reg, slice_status, !(slice_status & status), 0, LLCC_STATUS_READ_DELAY); + if (ret) + return ret; if (drv_data->version >= LLCC_VERSION_4_1_0_0) ret = regmap_write(drv_data->bcast_regmap, act_clear_reg,