From patchwork Thu Feb 1 15:13:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Bristot de Oliveira X-Patchwork-Id: 195355 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2719:b0:106:209c:c626 with SMTP id hl25csp221824dyb; Thu, 1 Feb 2024 07:14:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IFDlkG84OZR94UcCE7yz82sGKYtcTYxcXNBKkOEUFpmF/z2GcJDCMRdeeFs2nrKmnETJamj X-Received: by 2002:ac8:4e4d:0:b0:42b:f8ea:7851 with SMTP id e13-20020ac84e4d000000b0042bf8ea7851mr1504619qtw.8.1706800447224; Thu, 01 Feb 2024 07:14:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706800447; cv=pass; d=google.com; s=arc-20160816; b=SAWqP0Ef8kVWsoJun5t5qArfXaICcr6aPFdpQ5Bjh0BzRXOy4456fjkCYdbRGJ4VJi 8oZvabH8tcKZ0w9cabf6/mKXqvlVy/7+pmJ7/Dj8P93nt+L2mJmemURc/VJL0tYY2n1i kqGOBi2UQuPK3MT0Oiriw8QrcQhDz9GSxSkJESeZ5+icYyXQtHOVqIAjowCKY1q8+Ppu fZg4x183cZLKial4VzYw0Hx7Ccb6Ff7n+F8TD6nko7h8yoVaNrPS52zUXtcAbnAma9Tf RPXNNbrAN2HGNE+8E9kP6PlglKEIZRWoat4saz3huUSsog9aKfbdZamEXkPfr0LfNqzJ zhOw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=PW8LtK3eLbT+R6BUiYkc31jj/KAv643Uqyz0nvPLHqs=; fh=zKBw7DDJsd8YMISMEdRGhIgGZei5NitmZsBKURm6Qaw=; b=lkwnvDrxe4UeVYftguH5O40AA/D2ur8MwoI2vo/xsqDeXvuHqtg/Hmdr0LJgW4fQA1 5tfsLTZEBzYNljvTnSi/DFm7VPM/AcG2LRJp8zNLO9GhGfp3iWSc5Ov5ukQOkRf2bwgi jiRflR3DhZqdLnaDxswtr8kG7iqDLe/LTxbnMxsylAiWAG4FT5X5nG85oiAbPFUttpMW f4sqKevmHkeCknY3uu+sJvIypZrVbQP5FlBnbfuUTGS+fI6Yzy7fcOpxE9adlXFh1iAI Ng1RguRZ4UQ0WECWYOQINt9CJOBep4MlPx4O+/hFz/fQmt77uBJB126XSzN4BG/wjo0p NDvg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WwRdsEgn; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-48368-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48368-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCXsY1Evef3kRAnQwNMTFGXjzWGuw05NzyjqisYen9hYq5NC5xCGYv6VZCZss4tS3tSD1SCwF7+yU874UYGDmWYAxTzMPQ== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id h16-20020ac87d50000000b0042ab48ceefesi6356652qtb.442.2024.02.01.07.14.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 07:14:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-48368-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WwRdsEgn; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-48368-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48368-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 073BB1C26083 for ; Thu, 1 Feb 2024 15:14:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E134662161; Thu, 1 Feb 2024 15:13:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WwRdsEgn" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A43E5F49E; Thu, 1 Feb 2024 15:13:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706800430; cv=none; b=fFWik2sO5Ogu1H7jwMJKSNdUQu9p3/NFL68P0WfyREhIk1+tkmQV5G1y0tJwL16+N9z/HOUB8Ci7Ht/YuGTig/bHyqbhZGSWpX86Op0QdkAutWB6sshOkrBNwWCk5c5bIfiygQbXBSMRLVHQk9tot67msBDH+3bdfxKg2P514l4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706800430; c=relaxed/simple; bh=J25LSF02c3Gihi6ywJToP8/0dpuIX20uFfdRTlYxyRg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Giya0wkA4NM5SBmK7pVoD+r/vzGsxxAsMEqCA0OV+241RwzkKQdtEsgwoLPYw9IK5kTdaugCAdatSqjr4odZWRMma9ajh4/t9q+5xHHoKAyM9mrtaHVDTer7UykelmbE2iHNTXPmlYgIe0We8F4nyxaP4Tq5COt1w21bW3yZUfA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WwRdsEgn; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id F423DC433F1; Thu, 1 Feb 2024 15:13:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706800429; bh=J25LSF02c3Gihi6ywJToP8/0dpuIX20uFfdRTlYxyRg=; h=From:To:Cc:Subject:Date:From; b=WwRdsEgnfVREwIGEX7L2Y0qvFc4a+QOfttbXdf6t8ZoZNJqEAF6ntKisAF9lamz/c CKCOXaJCB1NwUOAuFSWq5OWNXl4pXVdZJnYhNcZuW8JGTQ8u0Z4Sosso2c5GgnCgPB 7dR5pfRAW6HrAqvmWuJCBnh6Y5X0kIVJ/KhHUPFuPT9K03GqVRjJtfGP6m6hNgbZP2 X3Sn7bLvYa98cxeGVu0bS+gecxyjnBFLZlorUBZQDP2GS/v+EMk8hjl0Evn3X1dB5N EIKY1bGR+sRwskTDZMEvuuAvwRImAxta9NDT3WI6wbIW8tPUXCNpYlze1Q51t/tRyl 8tmRRAUrucKXg== From: Daniel Bristot de Oliveira To: Steven Rostedt Cc: Daniel Bristot de Oliveira , Masami Hiramatsu , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] tracing/timerlat: Move hrtimer_init to timerlat_fd open() Date: Thu, 1 Feb 2024 16:13:39 +0100 Message-ID: <7324dd3fc0035658c99b825204a66049389c56e3.1706798888.git.bristot@kernel.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789709985994788580 X-GMAIL-MSGID: 1789709985994788580 Currently, the timerlat's hrtimer is initialized at the first read of timerlat_fd, and destroyed at close(). It works, but it causes an error if the user program open() and close() the file without reading. Move hrtimer_init to timerlat_fd open() to avoid this problem. No functional changes. Fixes: e88ed227f639 ("tracing/timerlat: Add user-space interface") Signed-off-by: Daniel Bristot de Oliveira --- kernel/trace/trace_osnoise.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c index bd0d01d00fb9..a8e28f9b9271 100644 --- a/kernel/trace/trace_osnoise.c +++ b/kernel/trace/trace_osnoise.c @@ -2444,6 +2444,9 @@ static int timerlat_fd_open(struct inode *inode, struct file *file) tlat = this_cpu_tmr_var(); tlat->count = 0; + hrtimer_init(&tlat->timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_PINNED_HARD); + tlat->timer.function = timerlat_irq; + migrate_enable(); return 0; }; @@ -2526,9 +2529,6 @@ timerlat_fd_read(struct file *file, char __user *ubuf, size_t count, tlat->tracing_thread = false; tlat->kthread = current; - hrtimer_init(&tlat->timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_PINNED_HARD); - tlat->timer.function = timerlat_irq; - /* Annotate now to drift new period */ tlat->abs_period = hrtimer_cb_get_time(&tlat->timer);