From patchwork Wed Jan 31 17:21:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 194879 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp2040552dyb; Wed, 31 Jan 2024 09:22:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IFoGBczmQmvBZIZubvbXRc070IYhnsgqMZJ7V/jRsfCWInsEZgcc7Ifkm/te693m2U+7J9N X-Received: by 2002:a05:6808:210c:b0:3be:9975:cfb4 with SMTP id r12-20020a056808210c00b003be9975cfb4mr2808187oiw.34.1706721767551; Wed, 31 Jan 2024 09:22:47 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706721767; cv=pass; d=google.com; s=arc-20160816; b=GFaC/wSMwB9ZUc5TOhPaRc/BdDZN1ieKYaUIMevXIPiiUceBYN9RCGfCIbj9X55mYj zxtJlvXBZhhkotjsRHEV6nbaQbn5/5K8bwFvGjRYsyIX6nuBDHdm4Z+KgpAQ7oKthWLN 3eKuy3gOCFYrgupjpsrhPl2kCx5uWl01rPUp8cCeXEhqAKMuzyFhS+k3uzQKcOn0NaB1 SrQdvkyVyZtI0a8v+ikrEMa5CyGTFMZyjQw9dmunB5IaeEufBH2a6Ngo/7GbuOeW3BdG zO2P27tFtIGIprfTzjgFdwo7a0VshsQybRY/OLIAHk01ED6JMUOPZZIm5ThFtz5omz/i 8RMA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:message-id:date :user-agent:references:in-reply-to:subject:to:from:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=H+2cp9O9FsaKNP2b52QDGJm9f16kGOz3pr2NaY88dUg=; fh=CJr6RFnmUD7p8vxgcvAAZNdvOZVgWhD/ckb2sNUbs+0=; b=tjJfPvwyazyRBm1eCPWmWK5vEAQ7FBlLegzjSjsWGo4zG0LVakaTjmdeyC+2AAXGnP 8GSiIyGpTwJOb5pIkbWahgNGbcu8rmg4LqXvk8g7fWduqSHSTUZ6dH95EA01XuEkMula Yoxoz3vScl9rUYHzh0MsV+F3nKQpntXC6x1hvBXqhe3/n1B8GUpJeiAudS3vuL8ss2dN oOSgV5rynYVLPnaIJElvxX1gmaYu+L0Rrcpo5A/KCc83AvTpXGQobNgDoRQahuPTnoyv jrQXVBW0PCNajY2KfIDXeJqncxk7+RVewY7alSsX0aONMFXUs+QmgBQxgX60TY5US7j0 JCow==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=jcMdEJmb; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" X-Forwarded-Encrypted: i=1; AJvYcCUo3dHR7kSR6b4AkNksRtKsaXbmsHhMKUBUOIhyWkfwMIGNP9SDZ0vfykK2Q2rWeRotkWGYxKQ8ldIWJyXezmR6CkIMDQ== Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id pc38-20020a05620a842600b00783b5c83466si12237747qkn.336.2024.01.31.09.22.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 09:22:47 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=jcMdEJmb; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 28EBD385ED4A for ; Wed, 31 Jan 2024 17:22:41 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id 7F3443857830 for ; Wed, 31 Jan 2024 17:21:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F3443857830 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=baylibre.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7F3443857830 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::330 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706721717; cv=none; b=WrJs51iVCxnOn33ZoWNcaFKtUWuKHCep1BYIAxECfghjNu2m1HOWzGeFlhYY3/Tv1yOikLjFTFS8ZQIcvG2ojqhLys8SonkyQKsUQq/0slFLOJi8vB/tUYYNGbyGgxCRbJzYyMvZACuokAtSK+ydtESB+tjbfSP1Et0F1LKwTGE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706721717; c=relaxed/simple; bh=MBlt9g9dY+6i9hJhEzYigAxveGIbdjw0/1pvdazHsFI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=MRLpabmUJpCokHSGNIEd0w64rA9MF8llyP27QOt+CI8HgniKOrLJIpUdWf5f6/AcaN0pvx6+8HzQJ8Xf/cWV7FcwF3pgP5gQWoaisa61nPDxX6eQcp1FQ1bLug18rOzqWVBTj4P6wv7/I1jqakHklBFzfMN5QPdCtyAYRwtoHGw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-40e80046264so656625e9.0 for ; Wed, 31 Jan 2024 09:21:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1706721713; x=1707326513; darn=gcc.gnu.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:to:from:from:to:cc:subject:date:message-id:reply-to; bh=H+2cp9O9FsaKNP2b52QDGJm9f16kGOz3pr2NaY88dUg=; b=jcMdEJmbOu1rYrNLDvMDiMoXRsHq3a7aad7gA3DVoowG8RxJRJcoJgufcB2Z1hydOS wFhqwxzICoTvsPEtTC6NoVykaBkdWOQB5vNUoYRHPRmyx8yb1bptfCexVZIPOYuMIE2Z UNTdggpSrOO5ThtCWUmSU13V2LzrZOyfnPVsbi+29+c7W9YlNRz+PoAHh7Y8DmWqJFPS n9tBuQhbDqen3Y0010zAqMfxEH/8jsaTmp8KlUabpYni9uwt74WBqlsY/K6xLuorNTMb yD+U1ornY6GpzMzwXoPYHdYlLybn1gSjxOIQB5OAYAU/WSDQOc4yjKrecSS26hObXMKb oLtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706721713; x=1707326513; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H+2cp9O9FsaKNP2b52QDGJm9f16kGOz3pr2NaY88dUg=; b=NqRavgCSBdeNvm9lnBKDYporzs2i3hst3hLvAYvK7IPzha1SwFB0w9FoVY2EwmdLdW UnsXsmpkFaSAI5QdfssvBi2qNwYVzc3ZdoeuUTDbuFP8SgB95rm6xBIpflD/T0IdEfsI WPk5uHQNQZD3PFb38THvpda/8M2zjJ8ln4s8RnAMXAhYH+sewflv2496sBoYOcvnlDYr AZ/zKdxchCeFjAeADzAGr7TfbJh+lfwoH5DMDxis9KUNsOygwQLAgKPb3UJ6KQbJLECy drl63JSbw0vseJYTiuDOVDZI6JeUzY35QO2GnheqIaPiSrfw1JkzYnWEC9oqhzhcTiYT joEA== X-Gm-Message-State: AOJu0YzQnqCEoHIMx1BN69xvPMEBMdkfuyMQ6C2RtZW/FAs8RukDZvKb kjBvfABjMcrRDA7TUEvaj9WtH522XziX50iUGqbLswCWIZlEQNb8DjyBS7kRSC8= X-Received: by 2002:a05:600c:601b:b0:40f:b772:24e7 with SMTP id az27-20020a05600c601b00b0040fb77224e7mr402025wmb.36.1706721713149; Wed, 31 Jan 2024 09:21:53 -0800 (PST) Received: from euler.schwinge.homeip.net (p200300c8b7344200b5efa23283b9f09b.dip0.t-ipconnect.de. [2003:c8:b734:4200:b5ef:a232:83b9:f09b]) by smtp.gmail.com with ESMTPSA id ci10-20020a5d5d8a000000b00339281d98c9sm14183139wrb.72.2024.01.31.09.21.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 09:21:52 -0800 (PST) From: Thomas Schwinge To: Andrew Stubbs , gcc-patches@gcc.gnu.org Subject: GCN: Remove 'FIRST_{SGPR,VGPR,AVGPR}_REG', 'LAST_{SGPR,VGPR,AVGPR}_REG' from machine description (was: [PATCH v3 04/10] GCN machine description) In-Reply-To: References: User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/29.1 (x86_64-pc-linux-gnu) Date: Wed, 31 Jan 2024 18:21:50 +0100 Message-ID: <87jznpl8pd.fsf@euler.schwinge.ddns.net> MIME-Version: 1.0 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789627484479135750 X-GMAIL-MSGID: 1789627484479135750 Hi! On 2018-12-12T11:52:23+0000, Andrew Stubbs wrote: > This patch contains the machine description portion of the GCN back-end. [...] > --- /dev/null > +++ b/gcc/config/gcn/gcn.md > +;; {{{ Constants and enums > + > +; Named registers > +(define_constants > + [(FIRST_SGPR_REG 0) > + (LAST_SGPR_REG 101) > + (FLAT_SCRATCH_REG 102) > + (FLAT_SCRATCH_LO_REG 102) > + (FLAT_SCRATCH_HI_REG 103) > + (XNACK_MASK_REG 104) > + (XNACK_MASK_LO_REG 104) > + (XNACK_MASK_HI_REG 105) > + (VCC_REG 106) > + (VCC_LO_REG 106) > + (VCC_HI_REG 107) > + (VCCZ_REG 108) > + (TBA_REG 109) > + (TBA_LO_REG 109) > + (TBA_HI_REG 110) > + (TMA_REG 111) > + (TMA_LO_REG 111) > + (TMA_HI_REG 112) > + (TTMP0_REG 113) > + (TTMP11_REG 124) > + (M0_REG 125) > + (EXEC_REG 126) > + (EXEC_LO_REG 126) > + (EXEC_HI_REG 127) > + (EXECZ_REG 128) > + (SCC_REG 129) > + (FIRST_VGPR_REG 160) > + (LAST_VGPR_REG 415)]) > + > +(define_constants > + [(SP_REGNUM 16) > + (LR_REGNUM 18) > + (AP_REGNUM 416) > + (FP_REGNUM 418)]) Generally, shouldn't there be a better way, that avoids duplication and instead shares such definitions between 'gcn.h' and 'gcn.md'? Until that's settled, OK to push the attached "GCN: Remove 'FIRST_{SGPR,VGPR,AVGPR}_REG', 'LAST_{SGPR,VGPR,AVGPR}_REG' from machine description"? (I assume "still builds" is sufficient validation of this change.) Grüße Thomas From 6af4774b4574086f5d4925333406eab4fed7f9a5 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Wed, 31 Jan 2024 13:27:34 +0100 Subject: [PATCH] GCN: Remove 'FIRST_{SGPR,VGPR,AVGPR}_REG', 'LAST_{SGPR,VGPR,AVGPR}_REG' from machine description They're not used there, and we avoid potentially out-of-sync definitions. gcc/ * config/gcn/gcn.md (FIRST_SGPR_REG, LAST_SGPR_REG) (FIRST_VGPR_REG, LAST_VGPR_REG, FIRST_AVGPR_REG, LAST_AVGPR_REG): Don't 'define_constants'. --- gcc/config/gcn/gcn.md | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/gcc/config/gcn/gcn.md b/gcc/config/gcn/gcn.md index 1f3c692b7a67..b3235eeea1b6 100644 --- a/gcc/config/gcn/gcn.md +++ b/gcc/config/gcn/gcn.md @@ -23,9 +23,7 @@ ; Named registers (define_constants - [(FIRST_SGPR_REG 0) - (CC_SAVE_REG 22) - (LAST_SGPR_REG 101) + [(CC_SAVE_REG 22) (FLAT_SCRATCH_REG 102) (FLAT_SCRATCH_LO_REG 102) (FLAT_SCRATCH_HI_REG 103) @@ -49,11 +47,7 @@ (EXEC_LO_REG 126) (EXEC_HI_REG 127) (EXECZ_REG 128) - (SCC_REG 129) - (FIRST_VGPR_REG 160) - (LAST_VGPR_REG 415) - (FIRST_AVGPR_REG 416) - (LAST_AVGPR_REG 671)]) + (SCC_REG 129)]) (define_constants [(SP_REGNUM 16) -- 2.43.0