From patchwork Tue Nov 15 09:55:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 20275 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2621645wru; Tue, 15 Nov 2022 02:02:32 -0800 (PST) X-Google-Smtp-Source: AA0mqf6ewdeerKhti8Jv2tdCq4Efq1hDS1HHF+ioFr/t2p7peMzURFEi42AhefeDHVad5xt7IDXa X-Received: by 2002:a05:6402:518:b0:467:8813:cab5 with SMTP id m24-20020a056402051800b004678813cab5mr11195957edv.369.1668506552058; Tue, 15 Nov 2022 02:02:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668506552; cv=none; d=google.com; s=arc-20160816; b=ZNjZ9bUwvB2KHWdgJSUC+sjFrgWycN25y6oP+jRNnUqZxiCILLb0/X2idbJ1KPRF5n 1zz97JHQlWN01PjTf/BmrJH5dsQrdAcLcJwvboQOZfrPD6cJ0WotEJZsucpe/sLgyu0Z N8eSF3CDgtVkTXS5QGbc+dsA/lSIvjPeut2yyANq3MgzBwp2nEjuCupu0FjTD8QNP6WY hJHGSlWxZP3bmpWKliy5wI8VsT3CfnZmXZHODSXfTmsDmDn+CFJHY3rH5U0wQY+ir1Xm ZinUhMCLIG2ankb4MIpDSs2X5lzpvM1m4oXOfF5OsMc8nGRyzGJZK8cPCf8DIMlvwaQo eMMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=23t4Te+yw+Hqm+0pjO3fcF8NMLCFiSBxJI+O+j/PQU0=; b=qJI5/RWpLyoImCzuKrcMCTLG828M9lIaixu4hpC47WZaUTvaob2yIpK5dl24s7JUL9 yhzjf8YBKI4lp3WBd7wgIm/D/53iCjOsewDJTN7EbqlhZ0tML3MhI+KQQ4TC+WHI2VBq kf1tUc5MA0PBJd5hShcZLVfs1MWcUs28BX5q4cbRlAEvTiA2IrCbiUun0dkZGTRwFoVr te/J20woCEZKOLr8Y+4LEDXe78kJ4BiUQUKhDBXSADNGcgfu9yBbSZV4Oi8XDnWyP2kZ I5rF4Ak3pAdYuqAqPgzvRMyaWL4Mta0Zc+jxNXIxZx+JvKvnpH+8rgV1rXGzdLMfy8OL /QAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=WGBR5LG3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lx3-20020a170906af0300b007adacdfd08asi8770769ejb.295.2022.11.15.02.02.07; Tue, 15 Nov 2022 02:02:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=WGBR5LG3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229969AbiKOJz2 (ORCPT + 99 others); Tue, 15 Nov 2022 04:55:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229754AbiKOJzY (ORCPT ); Tue, 15 Nov 2022 04:55:24 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F760AE61 for ; Tue, 15 Nov 2022 01:55:23 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id be13so23622743lfb.4 for ; Tue, 15 Nov 2022 01:55:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=23t4Te+yw+Hqm+0pjO3fcF8NMLCFiSBxJI+O+j/PQU0=; b=WGBR5LG3Z/5OspOwwBLwL/f4DQt3EbSb2GSsCAq4/4Rw17LYljrtFT1mtEQ3fRFSJk 2WMtRjfQ0B1/i/6BDPZzrgWNOY6nEpC4+rafytXiULnV9L7/txmaey99VFWBIgLG+6oi JrR1oXpfymU5E6oWJuu/rAeKeulGAP26vpa4k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=23t4Te+yw+Hqm+0pjO3fcF8NMLCFiSBxJI+O+j/PQU0=; b=1hFFc2bfMU6mFAJqU7ZJmLtPuXMeccwazR2dvtlA1/MpcprOYyQ2WOAYUmnIiGi0OO Mdob8DMyX9frzJh53WrKpUBJ6qX7IQmyNuzMlfOiE8vjp3rcSD2T+b+4BMxhcW7Z3w8x OMfle3N6yeZxtnp3DlkyN2Rzwf+1UlZxE8y2ksNEB4GIM2Ajhcb1CcLQ8nPcLcggfccp ejZtnz6lFwO9o4fRnxO0faFQKfEUWXU6QV/2ydUwsvIdzyhpHAGISbqS6AVYFgu88NIq 7Z3lZFCadaI516AKHvuGrqCC9jYFrIzcuek/E8T4WWxaIHEvyE3Q8H27YP/aVvnuCgAh H1tw== X-Gm-Message-State: ANoB5pkffQKeSvKgXCUqQonzpSN4Je3XLfZKY42THhlReuuvdbJwuXp+ f7UFR4aFo47IyvLhM9ggW+DfEg== X-Received: by 2002:a05:6512:a86:b0:4a4:72b0:9a2b with SMTP id m6-20020a0565120a8600b004a472b09a2bmr5104119lfu.469.1668506121475; Tue, 15 Nov 2022 01:55:21 -0800 (PST) Received: from prevas-ravi.prevas.se ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id q3-20020a19f203000000b00493014c3d7csm2148598lfh.309.2022.11.15.01.55.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 01:55:20 -0800 (PST) From: Rasmus Villemoes To: Rob Herring , Lars-Peter Clausen , Michael Hennerich , Cosmin Tanislav , Jonathan Cameron Cc: devicetree@vger.kernel.org, Rasmus Villemoes , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] iio: addac: ad74413r: add spi_device_id table Date: Tue, 15 Nov 2022 10:55:15 +0100 Message-Id: <20221115095517.1008632-2-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20221115095517.1008632-1-linux@rasmusvillemoes.dk> References: <20221111143921.742194-1-linux@rasmusvillemoes.dk> <20221115095517.1008632-1-linux@rasmusvillemoes.dk> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749211689456435612?= X-GMAIL-MSGID: =?utf-8?q?1749555926518217633?= Silence the run-time warning SPI driver ad74413r has no spi_device_id for adi,ad74412r Signed-off-by: Rasmus Villemoes --- drivers/iio/addac/ad74413r.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c index 899bcd83f40b..a157f2247a50 100644 --- a/drivers/iio/addac/ad74413r.c +++ b/drivers/iio/addac/ad74413r.c @@ -1305,6 +1305,15 @@ static int ad74413r_probe(struct spi_device *spi) st->spi = spi; st->dev = &spi->dev; st->chip_info = device_get_match_data(&spi->dev); + if (!st->chip_info) { + const struct spi_device_id *id = spi_get_device_id(spi); + if (id) + st->chip_info = + (struct ad74413r_chip_info *)id->driver_data; + if (!st->chip_info) + return -EINVAL; + } + mutex_init(&st->lock); init_completion(&st->adc_data_completion); @@ -1457,12 +1466,20 @@ static const struct of_device_id ad74413r_dt_id[] = { }; MODULE_DEVICE_TABLE(of, ad74413r_dt_id); +static const struct spi_device_id ad74413r_spi_id[] = { + { .name = "ad74412r", .driver_data = (kernel_ulong_t)&ad74412r_chip_info_data }, + { .name = "ad74413r", .driver_data = (kernel_ulong_t)&ad74413r_chip_info_data }, + {} +}; +MODULE_DEVICE_TABLE(spi, ad74413r_spi_id); + static struct spi_driver ad74413r_driver = { .driver = { .name = "ad74413r", .of_match_table = ad74413r_dt_id, }, .probe = ad74413r_probe, + .id_table = ad74413r_spi_id, }; module_driver(ad74413r_driver, From patchwork Tue Nov 15 09:55:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 20276 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2621678wru; Tue, 15 Nov 2022 02:02:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf4ivVKriv7jwfD5/48pHCORGEKf4oFXMSMn52R7C1Ej1h8B0AKSo6rkpXNfIX4Eb57YGMGe X-Received: by 2002:a63:1f01:0:b0:45d:e9c:2014 with SMTP id f1-20020a631f01000000b0045d0e9c2014mr15604184pgf.371.1668506556543; Tue, 15 Nov 2022 02:02:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668506556; cv=none; d=google.com; s=arc-20160816; b=NtKNxBJA8NFo4s1mQwSqd+SSMI7B71G/JGdVBXQR+x7K4VaekHPfG9AsOJkbzDF1Fc iawoNnlJRVUEyXWiZltG68jOWUSypG82fiQe6EQwibgel00GyapuPKb2SwfrBaUU74g2 jcDn4qfywpRjHRYmeNlfjBeR6ea/N/sMhA5BmScGmBuq71L2EoNZqrimNudvmpDd7S0x bpJCg70n5l/9O/h5OdoXgjKefh12ez++N04XpHYZnnUHdxkIVAXBbIXej5zkzfuXed7l UZGm6GhZSajmFDiaWIDhXLb1aD5+8ZgaDqyO342mUyzNp4S+S9bjDqIYeAhox1W7myKu lQ9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Rh6bYHIsyDNDTnfvzoAbdszZSJH6gLxzazLnOaj70HA=; b=s86HHbcYbvx4Mh/2TWMq77+aBC7oxfYIM5zGuHY/JHU7DeH+mzz1WoMrRndUa2FuVe WZWlexGO085GcGQGcepggW0QcMxuJrCN6fCuV8hqKz0afnw9RMQlavXHVdQ/6+faR6gA F7muNe3aDTGNLUFFnGzLBkYBbZjBzoIftuctBBqAqvytUNV+RTlUuBjEedGaODB0bWdn sBSYkG+Ufn165jHZjA4+i1uiF3HtuwIcJWhIuPW7USrSpz4VgT++0py1de+Zduu1o65+ xVBzbTq0n4d96xUkJ4R5BZssSJ1DyIsTjGKCJWLFAR6tfkRpzQzfrUeSn9ah15auQ7rt lgUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=bSZZJfRO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 23-20020a631857000000b00476c369eaa9si634717pgy.146.2022.11.15.02.02.21; Tue, 15 Nov 2022 02:02:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=bSZZJfRO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229927AbiKOJzd (ORCPT + 99 others); Tue, 15 Nov 2022 04:55:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230108AbiKOJzZ (ORCPT ); Tue, 15 Nov 2022 04:55:25 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A946112A96 for ; Tue, 15 Nov 2022 01:55:24 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id s8so6462302lfc.8 for ; Tue, 15 Nov 2022 01:55:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rh6bYHIsyDNDTnfvzoAbdszZSJH6gLxzazLnOaj70HA=; b=bSZZJfROZutTxt3595+PfI4ZhtPwBIahanBafiFrPMZPMBHP1Cmv8o6Il/aM2Xp+o/ o71uuAgm14aS6XGge20gAPleiOmWMKad0YaGMNaqXiWzT4y/Xf8ixcz9bpPQbdBHjN/D 29DWsynBrQj9W/80laRWbTMtubp/CHC/kaToM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rh6bYHIsyDNDTnfvzoAbdszZSJH6gLxzazLnOaj70HA=; b=noAJ9hulUZy1TEegNzZil1XK2ey0FMbHM8x7SP0hQdVzoPh5mukXi6sbQaJhptmC0D N93KP0O2G0z1tiZ0BNo5JNgHfVYNV2SgCqUx0Q1k5fAgb/+PZDecpvUgR2O4nDlPCSfk dh1Vf6mF59bNrl9FToqvERjaGmD/eXsytKhRZiFLv1EQZVOHGOtg0LmcqSsW6SXd6CCo ztcZG2KVMrlaH3QY5bysowyyOj+CQ8bUzCLCuA2VgxTZ1vkuADCF3J5lLaOCwlC4YJYI PXiiwLvH9GQ9FzfLmesirb40l5nV6N31cmHl5gaSbzqIpe3w40ixNmW8fOdbgitW+3tB xkAg== X-Gm-Message-State: ANoB5pnjIGRQrD7hwD0A0jOjXVf3Ug8C9VXqeDuq5sJh/2nu+pS3jAMG CLAIuheEy9Zz2jcyTjOj795VMw== X-Received: by 2002:ac2:4f0e:0:b0:4b4:9193:1caf with SMTP id k14-20020ac24f0e000000b004b491931cafmr3920173lfr.300.1668506122988; Tue, 15 Nov 2022 01:55:22 -0800 (PST) Received: from prevas-ravi.prevas.se ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id q3-20020a19f203000000b00493014c3d7csm2148598lfh.309.2022.11.15.01.55.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 01:55:22 -0800 (PST) From: Rasmus Villemoes To: Rob Herring , Lars-Peter Clausen , Michael Hennerich , Cosmin Tanislav , Jonathan Cameron , Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, Rasmus Villemoes , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] dt-bindings: iio: ad74413r: add optional reset-gpios Date: Tue, 15 Nov 2022 10:55:16 +0100 Message-Id: <20221115095517.1008632-3-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20221115095517.1008632-1-linux@rasmusvillemoes.dk> References: <20221111143921.742194-1-linux@rasmusvillemoes.dk> <20221115095517.1008632-1-linux@rasmusvillemoes.dk> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749211848931783871?= X-GMAIL-MSGID: =?utf-8?q?1749555931395004449?= The ad74412 and ad74413 devices have an active-low reset pin. Add a binding allowing one to specify a gpio tied to that. Signed-off-by: Rasmus Villemoes Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml index 03bb90a7f4f8..62f446dbc3d8 100644 --- a/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml +++ b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml @@ -51,6 +51,9 @@ properties: Shunt (sense) resistor value in micro-Ohms. default: 100000000 + reset-gpios: + maxItems: 1 + required: - compatible - reg @@ -129,6 +132,7 @@ examples: interrupts = <26 IRQ_TYPE_EDGE_FALLING>; refin-supply = <&ad74413r_refin>; + reset-gpios = <&gpio2 6 GPIO_ACTIVE_LOW>; channel@0 { reg = <0>; From patchwork Tue Nov 15 09:55:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 20278 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2622878wru; Tue, 15 Nov 2022 02:05:22 -0800 (PST) X-Google-Smtp-Source: AA0mqf428h/qNj5fNUNlsdGjynlcXdEsnII08u8XaRIhlWwMCH3ll5Irb4OZA0bL8GvQsTaZzvtX X-Received: by 2002:a17:906:1441:b0:7ad:b97e:283a with SMTP id q1-20020a170906144100b007adb97e283amr12837403ejc.567.1668506721911; Tue, 15 Nov 2022 02:05:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668506721; cv=none; d=google.com; s=arc-20160816; b=Qsyd+YZ3DQ/Khgly5KPub9WZLmRym4+Uwk11eyPNnpP+XKlfs0NE9Jt2paNJMwzw8i h11rplhKMrS6SGiwuEZ0ngnlML9m5mUaituNBnqKXjvv1NTvqI6pDWnhVF/3BUIt5Q8W WQoAc9diWaGTlIhvak66l9hc+I0iWCFB2dVhejLNnLGpxjb3WX6qpA/RCCthko9Eacwy ICp6uKIQAyfHRkK9ujgj6UTNuCfY+fhsEWiZPSwqlH6OpGCWMrQC8R7oVarxh7j3ypqm PGlUeStQADrzPxWS04CVd894KnIm8vmoTPOC3kiAVvHK/hYmrwi6caQGjkYEiFUts9xx xOBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JFlivsWSV6gGZ5OdvJQQ5Tn1kiYEgUjLp6Dm1aK7LCc=; b=jL5Urbm/l+VAj0AzZH6/uLPyIYVpCu156RUdlgsfnKW+pZ2dVnwyt5ZA9rrrdgi621 bfHMBY29LUChUNWHMr5DBsDbvboHmEWZvQ1CSftG1ROktVJk6WoZzsKxhV9S6SdDHgXk GvI2TpQcuTfBRnwMRwjp5HJAwJOWshAUCoee0smC4Oc8JVECkqjzzVV3oJ07vKvgQw+R 35fE62MDOWAxQvTd9fzt6IGRH/FOMyDJd1uvCMV+8eUueAl62aMU4YguREWmgi0lQ19Z 52/wAV2tabyZ9M6Fq39iTB7e85kTb146yit2+BZhMafR4l6CtyGU6/V7M+kDddiusvDo fQfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=eB62TXKb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e7-20020a50fb87000000b0046272b487cesi9789464edq.331.2022.11.15.02.04.56; Tue, 15 Nov 2022 02:05:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=eB62TXKb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231992AbiKOJzh (ORCPT + 99 others); Tue, 15 Nov 2022 04:55:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229716AbiKOJz0 (ORCPT ); Tue, 15 Nov 2022 04:55:26 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCCD413E36 for ; Tue, 15 Nov 2022 01:55:24 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id b3so23606537lfv.2 for ; Tue, 15 Nov 2022 01:55:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JFlivsWSV6gGZ5OdvJQQ5Tn1kiYEgUjLp6Dm1aK7LCc=; b=eB62TXKbmv90jFuho+MH8RtJRleXtoV19wJ7lGofTJHZeRStYtOauYc9z0Yeset8ya Y6D0LaESdNpj4/uAX0bCSzGjpzNCbsoq9SE+agzNE33PM4yRUwBJgLsA6FjL6u38WcGm gW/l9cNOxVi9KzPWqCMhvurVobFyld3FNuY0o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JFlivsWSV6gGZ5OdvJQQ5Tn1kiYEgUjLp6Dm1aK7LCc=; b=Tls84zA5s1eq2bNEaNhgQ30DMBavUzEi2swyjMBlxtQRk8AEVGKi+CqhGodjmN59uV YHYxoFjDqsakKGJiPQ80qOYmcODRHZa9sqxhM2UQiLc4MmwPdG5wNpjG++nBu11fdgpu n7nhJWW4tVbEp5w0OQL29UAqx41HXSkeDdsyuBKiBMqT+RPH2eJi7UXkbRByQRt2RZuW 1zXCeIllg15KR2hzZt0r5yHZy5qvKFGyEn1ISyuYjI/TnqJQfZ/6ajRLn1vibrnTgjYd GhrRWH/KtHpWLj6irFkrUcxBzdtOcLPaXBA5koMuGgelxt363ZbTf4S+BUCSFd+GoQdC tzQg== X-Gm-Message-State: ANoB5pmCsVRZjZ7vTkNrFBo9Tn6ZxEzr+if/1gazcHcNTeEX7hEQ1NL7 Q5or6e6Ur5LQCiH0Efn7rg6ryQ== X-Received: by 2002:ac2:44d9:0:b0:4a6:fa2a:275b with SMTP id d25-20020ac244d9000000b004a6fa2a275bmr5384240lfm.87.1668506124311; Tue, 15 Nov 2022 01:55:24 -0800 (PST) Received: from prevas-ravi.prevas.se ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id q3-20020a19f203000000b00493014c3d7csm2148598lfh.309.2022.11.15.01.55.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 01:55:23 -0800 (PST) From: Rasmus Villemoes To: Rob Herring , Lars-Peter Clausen , Michael Hennerich , Cosmin Tanislav , Jonathan Cameron Cc: devicetree@vger.kernel.org, Rasmus Villemoes , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] iio: addac: ad74413r: add support for reset-gpio Date: Tue, 15 Nov 2022 10:55:17 +0100 Message-Id: <20221115095517.1008632-4-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20221115095517.1008632-1-linux@rasmusvillemoes.dk> References: <20221111143921.742194-1-linux@rasmusvillemoes.dk> <20221115095517.1008632-1-linux@rasmusvillemoes.dk> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749211981022590176?= X-GMAIL-MSGID: =?utf-8?q?1749556104578973470?= We have a board where the reset pin of the ad74412 is connected to a gpio, but also pulled low (i.e., asserted) by default. Hence to get the chip out of reset, the driver needs to know about that gpio and deassert the reset signal before attempting to communicate with the chip. When a reset-gpio is given in device tree, use that instead of the software reset. According to the data sheet, the two methods are functionally equivalent. Signed-off-by: Rasmus Villemoes --- drivers/iio/addac/ad74413r.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c index a157f2247a50..313c279173f2 100644 --- a/drivers/iio/addac/ad74413r.c +++ b/drivers/iio/addac/ad74413r.c @@ -71,6 +71,7 @@ struct ad74413r_state { struct regmap *regmap; struct device *dev; struct iio_trigger *trig; + struct gpio_desc *reset_gpio; size_t adc_active_channels; struct spi_message adc_samples_msg; @@ -393,6 +394,13 @@ static int ad74413r_reset(struct ad74413r_state *st) { int ret; + if (st->reset_gpio) { + gpiod_set_value_cansleep(st->reset_gpio, 1); + fsleep(50); + gpiod_set_value_cansleep(st->reset_gpio, 0); + return 0; + } + ret = regmap_write(st->regmap, AD74413R_REG_CMD_KEY, AD74413R_CMD_KEY_RESET1); if (ret) @@ -1322,6 +1330,10 @@ static int ad74413r_probe(struct spi_device *spi) if (IS_ERR(st->regmap)) return PTR_ERR(st->regmap); + st->reset_gpio = devm_gpiod_get_optional(st->dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(st->reset_gpio)) + return PTR_ERR(st->reset_gpio); + st->refin_reg = devm_regulator_get(st->dev, "refin"); if (IS_ERR(st->refin_reg)) return dev_err_probe(st->dev, PTR_ERR(st->refin_reg),