From patchwork Wed Jan 31 16:33:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 194858 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp2014797dyb; Wed, 31 Jan 2024 08:43:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IGs2C2ZPeyvJ/Mrw1XQXutDv1C2bbo7i8E2QSRdUq88KBOJhQ4s0wPBSFXcDz1/B81o09RH X-Received: by 2002:a05:6402:6d5:b0:55f:3353:e851 with SMTP id n21-20020a05640206d500b0055f3353e851mr1630872edy.34.1706719408282; Wed, 31 Jan 2024 08:43:28 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCW0AUlbpH9H/uzORRwh+UIhLLH1ccNxOv9UKEfhGhIWdNezrmn7b7xSXHmRGpJZg/jduRPTdDT+c1wal5I1zlL9BTiMzA== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id r21-20020a50aad5000000b0055f5b79eb26si1349628edc.438.2024.01.31.08.43.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 08:43:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-46811-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=B5CddxTw; arc=fail (signature failed); spf=pass (google.com: domain of linux-kernel+bounces-46811-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-46811-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 0A5691F2EBDF for ; Wed, 31 Jan 2024 16:34:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8BBBA12BE8F; Wed, 31 Jan 2024 16:33:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="B5CddxTw" Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2066.outbound.protection.outlook.com [40.107.6.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA76F12A145; Wed, 31 Jan 2024 16:33:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.6.66 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706718817; cv=fail; b=aLqY/pasNAb9UD0s9Zmqlto99aKbq7h27qbGPaX/v7PMlAeAc7+wJXjHfYbvb4ow/n1Uzzo8C/980MH6wyp+8Ej+F/eS7PvaHOd7V6xDxiA9TpsaD2AGHMqfZxZuUicv5MnXRuYuBTgAeGd58pJoLUwXWvQRr5pudNburbwiGBY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706718817; c=relaxed/simple; bh=+1urk1vsF5xfCYYWzWQE/lyw6Tovca1mfkINlfV8MN8=; h=From:To:Subject:Date:Message-Id:Content-Type:MIME-Version; b=Mf1gpoKLqBwSTXsxne8FmOsyBwQOSavJf8Zga9MnFz16xKXSTHNZbZ5DibPTRd3ajCSC/Sz6p0G/KWRFL9rzovpe03qyBSUdIoBuhFHRKw+1haD3FCEEsNlDItnf0shYM66f+TywkEm48z4sucKDQz4RmsbyHE81uxM6i7xoe7M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=B5CddxTw; arc=fail smtp.client-ip=40.107.6.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TnbGswE4ciX2qksCdQFt7tJmoeO+Wu6VQySGhuDge8FYx6+n5JpLBpJsX3Rp5xfyumLzZnWLr/ScZdeybXV4UZMnn9Soas0jQ5nrDm9MOhqQxRE0rdAMRz8pBFkBWPGZ+hdl12VDBJV5Eya0IRWn1TuWyuveB3KdahYnLbgMF68cSJKSJbkLH8tB8HzbADTpimb/YVnUpG9mK2OOR72VaVh49PeT9xuC203A3TYEP3HnJd47zFy0ZpWv41XSnP+SEoNoYt1O1ssPEphkhh4xi/RzAD5cWuISENJa4XQ2tPMWk3C0SUPz4Qis0jdFh7/+N4NxdZCxr0/KI8OqDC1ipg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T5oHcMxoP6YTkKo/eiFf5661pgcErMc0NurojzoPGrw=; b=UChyUrZI3jd5ZqtVuAdu2h71KysFEGgYp/VN4HB7s8zA3m182Xm9wFBOr5dW+UvcgDDFJORJiuX46rX8lcPyQmJTEDS33IvMQAaSi6aYBQrFi3VZCh8dgCApeuZlavVrfpkMmuLz0WGsslDljNLtmSbULz/4dy2Hs43PV081tkE0pHC2ritpxhP2hLR9XV0m+N8aCb3f65GvV4mWfRs3zbDaun/hFdvGK7bGn4JRWBlkMAnRep3SClCxszT3tagDGS7OFfTFR/1SpKZkL1a6D0dpzwMv/+Mq4OEudsONVG8mY7cqh4obvw573ZlnXOaz3v2jQM/xd32FPvw4EXXJ/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T5oHcMxoP6YTkKo/eiFf5661pgcErMc0NurojzoPGrw=; b=B5CddxTw3e6nuIEqRl0wuQOlZmHQTE9+N29Aws5MtN8fYKdAt1kCYjxfaBrIF15PKpWnzmsHaCr4Ni4x4VGU/r7nRnWCpxTsDchLEGCip+eOMd+olv6bm19d3VjYedR1rue2rn0kZoNbuo8k4/GF+oijeGjMR5xLj9XRUbtHtvw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AM0PR04MB7108.eurprd04.prod.outlook.com (2603:10a6:208:19e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.23; Wed, 31 Jan 2024 16:33:33 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::c8b4:5648:8948:e85c]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::c8b4:5648:8948:e85c%3]) with mapi id 15.20.7228.029; Wed, 31 Jan 2024 16:33:33 +0000 From: Frank Li To: Vinod Koul , imx@lists.linux.dev (open list:FREESCALE eDMA DRIVER), dmaengine@vger.kernel.org (open list:FREESCALE eDMA DRIVER), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/1] dmaengine: fsl-edma: correct calculation of 'nbytes' in multi-fifo scenario Date: Wed, 31 Jan 2024 11:33:18 -0500 Message-Id: <20240131163318.360315-1-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SJ0PR05CA0119.namprd05.prod.outlook.com (2603:10b6:a03:334::34) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AM0PR04MB7108:EE_ X-MS-Office365-Filtering-Correlation-Id: 704db99e-a2f6-4fd1-4e0a-08dc227a5d5f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bxbWQgfkh1hlz8DZZcTIGjcMLdWhV7DCpCuJV6eL0oXmzF9sRngEwufi6Id7BWjPqOVsPQOKICsIjnEY1lAZnvSxOp8Hb75ODvX3Jb8AIxVOLwI0HdyYCfWd8/MEPJ92i/fkeEAeF8qcXOltPVx3HWMcB/JyA+Z0XN0L65bmGhHjwTJsb+aBTd5WmA8UUtsjzg3LaUUSeFHkaAjaQ3cp9YEUAYrnTWoHWs+CRkPZP+oQ1ECmbrWvvklz/si5mBnCrgNXpTouvC9EFQOYaPeiDH9jB2+NvTBh+MELEHliqKt+NT2eGQ+rou95qglGhs2VEh3HMKItGm/eF35ml57w1E8ZC/EoQQx6NctDFkUjhYk5SoWigldjPO7RZnK9sX3VgQRa6hkBmDJL4rs8wONh7Cn9DUo2SPKg+4toQDHVgctgfLYX6CCK/icEwnBdf9cbXr5m37j7cm6Isl3mcn97VQtuDqHclBbpodpbhFhJzGMO+tm5ramJfbJa3lFeJxmH/dcLy8Mh8a4CFCiZJC9fm2Nq/6iDLccpUmOSpTUlsSrF85kNSpqCLRzIn/pinJCY1HgW0+NbUZTTfv0jDk3q1sbXyo/+hwK7H8fw2/b7OhveU/dfTGMAh0NHWuUewiXG X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(376002)(396003)(136003)(366004)(39860400002)(230922051799003)(186009)(1800799012)(451199024)(64100799003)(38100700002)(83380400001)(36756003)(86362001)(478600001)(8676002)(8936002)(6666004)(66946007)(316002)(66556008)(66476007)(6486002)(1076003)(6506007)(26005)(2906002)(2616005)(52116002)(6512007)(5660300002)(41300700001)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: arrs9/CF+V9hlCPYogNR/imVp9Gzy2rSXW5sqdAr45xrFWKmAP8gHAlM0GOtuOoTYZfqkmYI4YBMC04aTp5B1TiPgczei+QGi3uxSjo8Ex0PgzZxcrTfsyXocVeTrDGailNRXJL3HDYluskLQcQHHNjIM9UukB6/euOsR0m6ZcPj4fNCHkBmCJ0Dw811m2P+ATZdZwb83NGO0wwTpU1OWOCpsMNgaaSjuSzybr2qxMwkiuUSsnQICee/slBshAtA/f7QJCw75QGNgTll7ZgJeeC357Mew9vUwlFlZ2MA8hxQBR/ChlfufTHjPlCqRdgho2BHi5dBT/qFIuQrmGVrIno0yfgXeYrprFFIspCgL05VRssKtu8i/PxDt5p2W88dBfnyz9t0e4Nip2rOoWlm9bYAxS2w6ieoQnoZOHt12Yl1zlExbCqWFMVFCJAAy2+T8OSUvjkNmf9j3cc8OvlXkCAnqpDa/Tk4+OUqPR5UfcJ0MjilCBh6KfrP5TzqvMTg+7PrLV4OddNLpLSmkN1rz9X3cJIdFMnE526BtXxPQQm4SjDOWRoR0YIpYHdVirHqa3SGS63SaaP0FUfl6xhb4FcoaBeHvsPdtrT/MopF65J0RuLh9dy7fpyCKOGlCx2ujr2Z3IVDpVaNPLpFzj8hBQkWxlV1VQUWNc4lcndrQz6hX3ckyunalQDG8g9+uULB/pIlc84W5hnVxy4wkMZZx8rrTnhlYqjgLsEpSlh1IwiQV23cVlehIVWvoxWNrE6PdFB5nNi2EUPkNDE2vPVJdj+GJkOcz9iSp2uNODaC6udEv6/YYMKt22fVsfUegfWESGYUWU62lcpKnx4vejyA72nUwlJEO2KAd9ltc/PciIKbXH7LuzLOEbvzcHQ2cs9WGyT9XD57MoffsyMfXb0egpE0niPtRD31sSnz1HpSdxruY0vlA6Df+9yL0Q0ElhO4OqxVdt6mOAxbwz1Wv1FMTn/MdBtpGgdmmXJxofbhzPc3EhFjixTqsK4UzO/eYvcborRu5uYglqc+YHs5a2rxUTdNUatgWq/NKtqJiCy9p76zu8dOE9Tjb1M7zJtblxggivfJBz20ZHHYrHYvoIVC0Tk2he+jKPYPMpo8wdcCbTpOJZK2D4MMPMTZusQm28K5x8dVekbKYjnEAHI8afslSzOG1RC0k/EiLrQ+QIaAV3L0tPtKkUc2Z3T83EOBglY4RTZIIWMJ7eKDA/3EJA8TO6zJsO+h5SKySFzZDDpNRptXGzfFaUgd/WDF5Py+OccRZYDMZF6P+/b3uA6qUx2u08HMKLa3G1HOheoOWrk8D5/T7PO/MX4NDy5sK7B9/c2A3yc0OHzUupjS5dDHmtBgoX3CSORpJktLNC7B7Z6k7hjqZag/eITXFMixVe0WYZBFUHC1zCEnOOhBVLrhoASi8e08wI54dh0KANLXDbhnq1X/plLo+awJKLKDTcJjWhjJjPhaYY/brrX/RGB+7hTYWOpry9J8Z4hXFn1dWUyjfuaZFGmnFi/SWkVaMdoEdyXRP0uVs/bRmIQThqwgoI3I6mMcvKajUBjpwZmEd4v7PmGCsrVsoYhRHZ1QfkkG8xy0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 704db99e-a2f6-4fd1-4e0a-08dc227a5d5f X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 16:33:33.1313 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +QdPH8TBfuh+4lR5MwaXHPlx7y3vg6rV9Ox8kZgZHWc0LFmf+4lNWq1LYawREN0nVJ2TmhpzxjvWgYGtMJqFdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7108 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789625010534539860 X-GMAIL-MSGID: 1789625010534539860 From: Joy Zou The 'nbytes' should be equivalent to burst * width in audio multi-fifo setups. Given that the FIFO width is fixed at 32 bits, adjusts the burst size for multi-fifo configurations to match the slave maxburst in the configuration. Cc: stable@vger.kernel.org Fixes: 72f5801a4e2b ("dmaengine: fsl-edma: integrate v3 support") Signed-off-by: Joy Zou Signed-off-by: Frank Li --- drivers/dma/fsl-edma-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c index b53f46245c377..793f1a7ad5e34 100644 --- a/drivers/dma/fsl-edma-common.c +++ b/drivers/dma/fsl-edma-common.c @@ -503,7 +503,7 @@ void fsl_edma_fill_tcd(struct fsl_edma_chan *fsl_chan, if (fsl_chan->is_multi_fifo) { /* set mloff to support multiple fifo */ burst = cfg->direction == DMA_DEV_TO_MEM ? - cfg->src_addr_width : cfg->dst_addr_width; + cfg->src_maxburst : cfg->dst_maxburst; nbytes |= EDMA_V3_TCD_NBYTES_MLOFF(-(burst * 4)); /* enable DMLOE/SMLOE */ if (cfg->direction == DMA_MEM_TO_DEV) {