From patchwork Tue Nov 15 09:25:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 20263 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2611065wru; Tue, 15 Nov 2022 01:32:12 -0800 (PST) X-Google-Smtp-Source: AA0mqf41Yjz59WGRA9Bndjck044jaOn3qQZ1YsjiSQzXf+k9TXk8UN4f7Kf+EvEn8mhVjeYu4OQt X-Received: by 2002:aa7:95bb:0:b0:571:3fb3:9b5f with SMTP id a27-20020aa795bb000000b005713fb39b5fmr17232976pfk.86.1668504732172; Tue, 15 Nov 2022 01:32:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668504732; cv=none; d=google.com; s=arc-20160816; b=oYPFJ3GNNGTAQX9di1g5v5G0YZpr6s92WhoTSpBW6x0gNW2T7JiPht8kwcNdcLVMQ+ RGCI5CqToEuYx9/UWAfjT+O0ASJplpDpWFdeqIKiGVxnUUdaSTM/ubyNkpq1x1mid1sI /QfZ7zBEVbvuFzVXrdIX9YYSNl7DrkbzBQlACl7+UIOhX0JHCKwZjUHYa71mDQFJ6lwJ fv2H7q0VU7YiypeyFDfvAk3ttmlVc8CjBlpQXoZ+BIebudAcvyo0Ykpr16Guc22/dCpR emQ6706bSL/GAQQKcrILv8GfN3aEulJ8cdIazKK8YteYtyV7aUfFNe9QaCc55t+int0s qVOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=BqcD5gh+7xNyDjmt29or19PWXtzyI2cQxb0w9uFrzGc=; b=l5dKdEPRwlsyYZ24SvN6WhKRRySO870lTsT4Jhidt9OaI9VDRZuykdLgb3I6k4K0mE hLxCLg5btx9AFXVsCpAkKUvaJd9BeIcPKBftk5Hl3PRAMttokpK7w+2LybW3bsDkQpjR ZJ08bpSDpgFr/8rq/OFf8QhmDsEB8XjWrM5+109TKLn710ikOKk+nDd7jowrBJH38ESR yHgcYbeaXotCCPcoz3ZSXgwEgIv7/hdoTsUxXB4bSMRDxopZBdTqNo39EPbbnWc5HV1Z QynVE38kKy/CxU/Twsayx3324Vq34xQugu9Tkf7pIcufnCvhCXavnlcAS4u3dBKOs47e +K0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l62-20020a638841000000b0046fea9618cdsi11493496pgd.323.2022.11.15.01.31.57; Tue, 15 Nov 2022 01:32:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232856AbiKOJZF (ORCPT + 99 others); Tue, 15 Nov 2022 04:25:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236993AbiKOJZD (ORCPT ); Tue, 15 Nov 2022 04:25:03 -0500 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21726DEA0 for ; Tue, 15 Nov 2022 01:25:02 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4NBLP41y82z4f3l1y for ; Tue, 15 Nov 2022 17:24:56 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.102.38]) by APP4 (Coremail) with SMTP id gCh0CgDXSNbpWnNjIyQ_Ag--.16714S4; Tue, 15 Nov 2022 17:24:59 +0800 (CST) From: Wei Yongjun To: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , Thomas Gleixner , Marc Zyngier Cc: Wei Yongjun , openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] irqchip/wpcm450: fix memory leak in wpcm450_aic_of_init() Date: Tue, 15 Nov 2022 09:25:32 +0000 Message-Id: <20221115092532.1704032-1-weiyongjun@huaweicloud.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CM-TRANSID: gCh0CgDXSNbpWnNjIyQ_Ag--.16714S4 X-Coremail-Antispam: 1UD129KBjvdXoW7Gw4fXw4kAFy5Ar4ftryxXwb_yoWfGFc_ur WUWr9xXFs7CFWrJ347uF43X34qy3WkWrnag3WIyry5ZFW2qws5Grn7ZrZ8tF47WF4ftrn3 CrZ7ZFyxZ347GjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbr8YFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Y z7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zV AF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4l IxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWrJr0_WF yUJwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIY CTnIWIevJa73UjIFyTuYvjxUrR6zUUUUU X-CM-SenderInfo: 5zhl50pqjm3046kxt4xhlfz01xgou0bp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749554018047032285?= X-GMAIL-MSGID: =?utf-8?q?1749554018047032285?= From: Wei Yongjun If of_iomap() failed, 'aic' should be freed before return. Otherwise there is a memory leak. Fixes: fead4dd49663 ("irqchip: Add driver for WPCM450 interrupt controller") Signed-off-by: Wei Yongjun Reviewed-by: Jonathan Neuschäfer --- v1 -> v2: fix function name in subject drivers/irqchip/irq-wpcm450-aic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-wpcm450-aic.c b/drivers/irqchip/irq-wpcm450-aic.c index 0dcbeb1a05a1..91df62a64cd9 100644 --- a/drivers/irqchip/irq-wpcm450-aic.c +++ b/drivers/irqchip/irq-wpcm450-aic.c @@ -146,6 +146,7 @@ static int __init wpcm450_aic_of_init(struct device_node *node, aic->regs = of_iomap(node, 0); if (!aic->regs) { pr_err("Failed to map WPCM450 AIC registers\n"); + kfree(aic); return -ENOMEM; }