From patchwork Tue Jan 30 01:39:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fenghua Yu X-Patchwork-Id: 193773 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp941298dyb; Mon, 29 Jan 2024 17:40:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IEQE9TMgfpi6dKA/F5HFII6vlpalujkLVFlFgmCK34tFcZrLSHyVah18O0ovDYdHsn++1gB X-Received: by 2002:a05:6a21:99a3:b0:19c:7e6f:85f2 with SMTP id ve35-20020a056a2199a300b0019c7e6f85f2mr7274190pzb.1.1706578859106; Mon, 29 Jan 2024 17:40:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706578859; cv=pass; d=google.com; s=arc-20160816; b=zr0HWQSjmIVTqZbxCe90jA5Xbufi/2HBRr3heNQ8lyorSKXrNYJPTe6fQPIecb5yIV 3lIb4fQSfmMFUXmRGss2l0Y6yARM4TE9RhY+RfI8ROx9nKZqX46YxVLBkqUBKGh/odP/ Z9HqK9y7uph+GzMVpAJUdZHflkTfn47r8AS7DP8yRIW3P2UTnmyDOH5U47Pof++9HeZJ 3gx3jNmvXpi+O8y17pZYBlWZlnyoHpvCu+T/fMzbRYRF7WVa/c71C8cJX+x+XgXccu+6 nGrnhbNFJ3FQvybwL4gOiq0djJQ2a3CTyMoL9dGG5mxm2rWodKjEK6pyf5qr0M+YZHDA 1BKQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=sdvxdZuV/r7VMnqDjU17CterkQckaLopX1PT52roaUA=; fh=8OLwMB/yZLElbOS9uu0FPZ5rmBcBhHVgUy99hJD/3LY=; b=ECcdkhGdoegdpYwLq7ldaDZ6czLiuNH87pga0HU4M96VZsg8yHz5X+iuC6qfyHy4WG Q8VE4pWwUOTz1vEV25K+2qMqk5zZLefsakkbXWlkIX6Z8Lg31vX2sfsPDHPELwiT3Ztd Shfk5AuAGbmJwG9XQK9X7F1mKn0jm6cMoXd1LGjD9PdzNJOhQ/M+hQFzKhhieQpsm99X lB9fHCEV/M/BTREwmd6vuuPSRHK7TvdzCsyhV0RnRf4naI9ZvGp96KD7oC1IjP75Z0zA Qoi0EOwO3U46ETVHQ86R1ycwQZYYY4WsxAW2d+QamHnhZSTDTTq5AAKPIpgTr2dnUNIB GkQg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=IdAnebLX; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-43736-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-43736-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id u18-20020a170902e5d200b001d8aeeeb292si5265738plf.279.2024.01.29.17.40.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 17:40:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-43736-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=IdAnebLX; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-43736-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-43736-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DA72A2846A2 for ; Tue, 30 Jan 2024 01:40:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A4C9D364B3; Tue, 30 Jan 2024 01:40:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IdAnebLX" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8728536102; Tue, 30 Jan 2024 01:40:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706578835; cv=none; b=sA90cmOzcIWgOoVHZQOMW6vsnKCd6cQVCAmxHypRTbsaqfDvmilV/x4jVia3sqhoUhzKgLMvmXQwvrCaDx7mZxK6aDg6sQz7tkuXlutOFHWnEhuIQqDxnsIeCQQ0/wMhXT/jkjOaj2P6tG48g6Z1Vx2+uA/ThXlIY89Ne2fXl78= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706578835; c=relaxed/simple; bh=9nLhA8tc2Ea4K4PEhVy6i7mywoj/BoVhDHAl5Sae9OU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=YUAmvB9EBHelf/usMgVTrXBL0aH4RAkqT0WsobH9kr0w6oGFrwUxD/ZAdWHjM/SmVQd11wzuX9Xg8dwiWsR6BL42CfWD6sLE2RQt31I1abB+PlDXm+lJXUQIlRcyvK1ZFbzUSLrDGUTKQQyCu6/iTU4f+Ns4l37u0FR3BM2wtNo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=IdAnebLX; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706578833; x=1738114833; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=9nLhA8tc2Ea4K4PEhVy6i7mywoj/BoVhDHAl5Sae9OU=; b=IdAnebLXcSu1ECGugbZCJxkOnnhN5/jP2EyMYZPMl2cVvXdY055dnVjF rIGPizZLZpZRcNVd5j7J/f7a/EdA8f3opbIQS3buFkzzsKqsK3cRaolGc eqPvLlDbIXZguPZmy0ntcuVGxge/2SwyI8kOMAfBs/MBN3ovmCh9Zw6jk cNyJ4SOsMHhUkIMA4dRmjUNcsNTFfHY5p+mIeClejA+WDpNbIzSPv3Zab ZTmUU9Ii0d2DSGyUV8Pjy01nlsbT8cTu8j2g58Vm+GffoGmI36dg6A5Fk 3IRI0BkEL0Posgx+r36thM1eaRJzzdNeIJbSXMNtnXf5PjVTlhsGQ92Sz A==; X-IronPort-AV: E=McAfee;i="6600,9927,10968"; a="24613155" X-IronPort-AV: E=Sophos;i="6.05,227,1701158400"; d="scan'208";a="24613155" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2024 17:40:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,227,1701158400"; d="scan'208";a="22276867" Received: from fyu1.sc.intel.com ([172.25.103.126]) by fmviesa002.fm.intel.com with ESMTP; 29 Jan 2024 17:40:32 -0800 From: Fenghua Yu To: "Vinod Koul" , "Dave Jiang" Cc: dmaengine@vger.kernel.org, "linux-kernel" , Fenghua Yu , Lijun Pan Subject: [PATCH] dmaengine: idxd: Avoid unnecessary destruction of file_ida Date: Mon, 29 Jan 2024 17:39:54 -0800 Message-Id: <20240130013954.2024231-1-fenghua.yu@intel.com> X-Mailer: git-send-email 2.37.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789477633916536292 X-GMAIL-MSGID: 1789477633916536292 file_ida is allocated during cdev open and is freed accordingly during cdev release. This sequence is guaranteed by driver file operations. Therefore, there is no need to destroy an already empty file_ida when the WQ cdev is removed. Worse, ida_free() in cdev release may happen after destruction of file_ida per WQ cdev. This can lead to accessing an id in file_ida after it has been destroyed, resulting in a kernel panic. Remove ida_destroy(&file_ida) to address these issues. Fixes: e6fd6d7e5f0f ("dmaengine: idxd: add a device to represent the file opened") Signed-off-by: Lijun Pan Signed-off-by: Fenghua Yu Reviewed-by: Dave Jiang --- drivers/dma/idxd/cdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c index baa51927675c..3311c920f47a 100644 --- a/drivers/dma/idxd/cdev.c +++ b/drivers/dma/idxd/cdev.c @@ -1272,7 +1272,6 @@ void idxd_wq_del_cdev(struct idxd_wq *wq) struct idxd_cdev *idxd_cdev; idxd_cdev = wq->idxd_cdev; - ida_destroy(&file_ida); wq->idxd_cdev = NULL; cdev_device_del(&idxd_cdev->cdev, cdev_dev(idxd_cdev)); put_device(cdev_dev(idxd_cdev));