From patchwork Mon Jan 29 10:24:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 193389 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp475144dyb; Mon, 29 Jan 2024 02:31:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IEUw62CAgZDwD6gw+V6p4a7o2upN9hIVkZY7CmE/H8+pxvsPX0LaKhO+FZ8kKtV8E9dGnrr X-Received: by 2002:a05:6122:180f:b0:4bd:6323:fd16 with SMTP id ay15-20020a056122180f00b004bd6323fd16mr1113733vkb.22.1706524281873; Mon, 29 Jan 2024 02:31:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706524281; cv=pass; d=google.com; s=arc-20160816; b=uFkaoJsMB6W5AoMvdBRAB3ifcxqrtcm11S6q6BqF7YUxKK6zijFhUcAxJdSS3wtpES BZY3nelDQDSfFIcaMdWV4+noHYJQDTwA2HY507ckvgEKrs4iLrp6R5hSqfen7qTLizDB 0U84MP6n9Y4Ot0Yccw94gwHrNy+/s6pBdH2vhXXcjk6qoIZvQg+eYBDks+4doOoJnjMi s8eHnP7WEeM6wAswc4A5Jd1E+dITpMzIuKUVkxlzLdIFTuURTl/zwrxO2bLQxzbYZX7+ sVESXvRgVnuS9beGXc8bjymIKGnpKxertJfKLRCyIHH2uNDZTycSaeEPoB4+SHnHq0n6 otFw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:errors-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :subject:cc:to:from:date:dkim-signature:dkim-signature :dkim-signature:dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=HtdBbvYlFUNiDe6eZ7+WvQI5ZuNOxeBt+H3ePJMiYQE=; fh=Hz/QWAL2vMAbrm3W16QrnQrLktFWGNewssxaKtdN1w4=; b=FtjUKNo2U0AA2El1azt+4TzVgyksCO1Ew/IvDtOiE2Ap8a6zQ/EKQY4TnD7r6JeL4c BExJYsROCwWsMJeuorO4T9zmHwT8mtEpadUqgx3YCKCE97cas8TLscMV5hV/5un1hUDA zXoj0xFlCSO5Al64V5GKwaiRJxH8F+xhmQj40rwdPYXGVubgJwrelNsh7q4m8Au1Ia+A O+m61wHYplfdg/1tZRDJs7KLwoFJRqEbDT4lg2sVosJaOSkMoyPlFA9Dh0AzAK0eX9ZB hrxEHfTwBay0rfDx6QRl0cBsB2KyaWGpfo/VKYeJgYdwEllaqrSKXArHdvv6NMMe8XV1 RZMw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="GVU2py/o"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=0RPmQEZB; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="GVU2py/o"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id 7-20020a0562140dc700b00683d27b654fsi7629905qvt.78.2024.01.29.02.31.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 02:31:21 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="GVU2py/o"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=0RPmQEZB; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="GVU2py/o"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9139A385842F for ; Mon, 29 Jan 2024 10:31:21 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id E19A13858426 for ; Mon, 29 Jan 2024 10:30:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E19A13858426 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E19A13858426 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706524234; cv=none; b=YhiKuTXrKplEPQmBPv2mjNLD/f2O/gyCcSoejPkNiHunyprm9pScM7WmRTgiKZ9QjXOdBo4j9srGKOB3f4xh+IMMxC2uXkyFhFXlYXCek+LHfhzSSzbvhDPnDi49sB0SpsCxyh1KBAaEZdNpPJgRH8sVqkkTdquXI8XfmYICXtk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706524234; c=relaxed/simple; bh=wXeKbHiTID2vv9KI7cQQ48RopRcqishjL4QRqV9jOLI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=tJNlc6LrqwlVBzXa7g/4ddO/zdBUhA3BwD3QyRx23sOuAxPAYPXUobby09adQR4bwps3dcToDjozA2w19T6W9mbiXBFqHdbmin2PfAPyMDqTaKOkvfA6O4h6FwZLcPCsUKa2utWcT53ijb2T13ezJTJWuwjoTH2Opv3uc5FeKxQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 96EF222278; Mon, 29 Jan 2024 10:30:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706524231; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=HtdBbvYlFUNiDe6eZ7+WvQI5ZuNOxeBt+H3ePJMiYQE=; b=GVU2py/oLppOgHU/WMHNUamOngVzEhMQUeoGemGN6bH2FPDcQjbrXTU17ykYyAk7B6mdlE jpFQZcU0qacJV56fWMHXJaRApUQOlXXV5GAve0JgQXBK32g2nujMHkLmYRzBjT0i2KLixT lMrW8kQnBXPMuK1yO/NbDd9EQewWT1A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706524231; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=HtdBbvYlFUNiDe6eZ7+WvQI5ZuNOxeBt+H3ePJMiYQE=; b=0RPmQEZBRcFJ7pD/BHRhZLnaNWcARkE8U+jQnbyDNsep8P/0Mb2AvRds5RN4PkO27Z+L/x 4pRVehjSdtIkW4CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706524231; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=HtdBbvYlFUNiDe6eZ7+WvQI5ZuNOxeBt+H3ePJMiYQE=; b=GVU2py/oLppOgHU/WMHNUamOngVzEhMQUeoGemGN6bH2FPDcQjbrXTU17ykYyAk7B6mdlE jpFQZcU0qacJV56fWMHXJaRApUQOlXXV5GAve0JgQXBK32g2nujMHkLmYRzBjT0i2KLixT lMrW8kQnBXPMuK1yO/NbDd9EQewWT1A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706524231; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=HtdBbvYlFUNiDe6eZ7+WvQI5ZuNOxeBt+H3ePJMiYQE=; b=0RPmQEZBRcFJ7pD/BHRhZLnaNWcARkE8U+jQnbyDNsep8P/0Mb2AvRds5RN4PkO27Z+L/x 4pRVehjSdtIkW4CQ== Date: Mon, 29 Jan 2024 11:24:58 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: Jakub Jelinek Subject: [PATCH] middle-end/113622 - allow .VEC_SET and .VEC_EXTRACT for global hard regs MIME-Version: 1.0 Authentication-Results: smtp-out1.suse.de; none X-Spam-Score: 1.22 X-Spamd-Result: default: False [1.22 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MISSING_MID(2.50)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.18)[-0.912]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[gcc.target:url]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-0.00)[39.35%] X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Message-Id: <20240129103121.9139A385842F@sourceware.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789420405046081820 X-GMAIL-MSGID: 1789420405046081820 The following expands .VEC_SET and .VEC_EXTRACT instruction selection to global hard registers, not only automatic variables (possibly) promoted to registers. This can avoid some ICEs later and create better code. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK? Thanks, Richard. PR middle-end/113622 * gimple-isel.cc (gimple_expand_vec_set_extract_expr): Also allow DECL_HARD_REGISTER variables. * gcc.target/i386/pr113622-1.c: New testcase. --- gcc/gimple-isel.cc | 3 ++- gcc/testsuite/gcc.target/i386/pr113622-1.c | 12 ++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.target/i386/pr113622-1.c diff --git a/gcc/gimple-isel.cc b/gcc/gimple-isel.cc index 7e2392ecd38..e94f292dd38 100644 --- a/gcc/gimple-isel.cc +++ b/gcc/gimple-isel.cc @@ -104,7 +104,8 @@ gimple_expand_vec_set_extract_expr (struct function *fun, machine_mode outermode = TYPE_MODE (TREE_TYPE (view_op0)); machine_mode extract_mode = TYPE_MODE (TREE_TYPE (ref)); - if (auto_var_in_fn_p (view_op0, fun->decl) + if ((auto_var_in_fn_p (view_op0, fun->decl) + || DECL_HARD_REGISTER (view_op0)) && !TREE_ADDRESSABLE (view_op0) && ((!is_extract && can_vec_set_var_idx_p (outermode)) || (is_extract diff --git a/gcc/testsuite/gcc.target/i386/pr113622-1.c b/gcc/testsuite/gcc.target/i386/pr113622-1.c new file mode 100644 index 00000000000..2d6cb3c89a8 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr113622-1.c @@ -0,0 +1,12 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -mavx512f -w" } */ + +typedef float __attribute__ ((vector_size (64))) vec; +register vec a asm("zmm2"), b asm("zmm0"), c asm("zmm1"); + +void +test (void) +{ + for (int i = 0; i < 8; i++) + c[i] = a[i] < b[i] ? 0.1 : 0.2; +}