From patchwork Mon Jan 29 07:52:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 193304 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp416772dyb; Sun, 28 Jan 2024 23:53:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IEWhEES43syof550tFmyOdIVguAslOcoopeTgVfcEPzW54/Yt4UqSeqI0CnuzOgyLqUS/dR X-Received: by 2002:a17:902:c404:b0:1d8:debb:4125 with SMTP id k4-20020a170902c40400b001d8debb4125mr1015089plk.38.1706514796877; Sun, 28 Jan 2024 23:53:16 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706514796; cv=pass; d=google.com; s=arc-20160816; b=Y6fw2em0Lylbx/Pk1tft8hKaP0oDQ4nVi3Zc7Uc/S+1MYOFopcHsKDkRZd/x0pHLmd xxnHBtp2TE74hPkLThqX5+WtEkf9t4sU06/sX6+1W3AlLWdhPryZj25RJO/uJceokK9r wrHoFM4JyXi/iET733iJRw/DAPByItIbtrldkgJVQENjZFINxDXcPU0hhAe+ggBEtRkh xP/QgQLJvZzVwvP/GHMSuZzfPrGRqYTz5rV3ro6/cNK1TYK0/sHyMN5gxEd4gRDShApR 4mDgzHyE4yfqzOr3SUjlMo/Tqlc2+18UoxxQ3ZxrzF48Y01vMVtkZIuabWoJEBah6hxW 6ANQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=hKwoviPF9lK3MXodrfrYqIC6rePNJHWY3NWvE/KNFG4=; fh=hjMhmZkqMZNL0ukT+d1R4S+EoOklGq5tQ13rxgwrgsY=; b=vs/eqVbLYu890CFC31GBGr2jNo6rIBthoE5Ysi8O4ZS8ULFK19LJYKRix2QyIXcfji oayljFrxT7P35XoI2izGQeeDslezN3bbsGJO+cB6HRmUZsH8kx6pFUygaQFHGKBYZmaL nW/kOt8i4/iVqW2L49OfBrj3KTX1n1H6eRyNpri03+GQ64utRQu+iBPWtd8ETIuiVNtD cPX61+WmInmtHng3U3MQcFrvBx639ELnGmHHwCLeJfRd63tG/WeBTd/nmVlTPwHhe3wu aUMjFW4lzZp7JKkdS5kUALnmGx4CX76SdxU0O3NMHTSaQr8Pf4cZ1CopPOv7gdB9g1Q6 EU3Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=U7uXVklI; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-42301-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42301-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id ju14-20020a170903428e00b001d8f2354fdfsi321972plb.87.2024.01.28.23.53.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 23:53:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-42301-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=U7uXVklI; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-42301-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42301-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A3692282FD5 for ; Mon, 29 Jan 2024 07:53:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D3E0C52F68; Mon, 29 Jan 2024 07:52:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="U7uXVklI" Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E41351C4B for ; Mon, 29 Jan 2024 07:52:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706514751; cv=none; b=EE4hszcbu1EzWKzjpg1KWlLsHgqLE4oMH6yLjq1J7/cJEnprSMzlbrrLxN01TvvZGp9VBARzdjHrxd59ASqNEqaEic/e0I9ovsObAjWrRwS/ydXYBu6NvRBJyMX+Z6XkkJj5BG/jZ+1kRtK1VfDp51gyLyl2i7Gan9eY5UTa/50= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706514751; c=relaxed/simple; bh=tTQT9Ku7RM1FLsAH3vWmzrAWVFN9wIhJQ1xDZJNKp4M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=a+reR/svefSAclpb2qQA3Aqjy6uBZFvAA0OlBX95CtCUJOzSyMVNGJP4mcJug54DkPjhx1sgpjJhUaShdMgD/scNb5GhqkVeRy+HnDURa+pHXqN1vnKILptlGEaTrgE54ChOm5EkyaSLEtH4tmlAy7udDtGu3Kq9S4WuXGGGCek= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=U7uXVklI; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6dddee3ba13so741002b3a.1 for ; Sun, 28 Jan 2024 23:52:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706514749; x=1707119549; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hKwoviPF9lK3MXodrfrYqIC6rePNJHWY3NWvE/KNFG4=; b=U7uXVklI6V+bqjGhgkCveo05yEQd8svuDNluOwLk9kJWyR87Vq9dza+UeLyCi3Y736 x7mCw6gnmQWuujnQK+ESYbgeg/jDauLzM6sPGoJf884sfSois95itnIJRXW4DeXPL04Z plBzn3DZyLDKlU2MnTMGGWcOjX0zRquAPVCgSzJhrxWAhmEr608id+DS/0kqi+dCKDBB tiPTHqE0uIRLRCVI/s5nk97ijqEec4igZmYsi93Yt4M92BjWXTBBDC4yiiDvB7DtLuBA lRivEjK61IvUSUlYDW0WP9+AHpxMWsWWyiJ81r8sPWTyPssp+4iUADkRateto+HzIHku R3wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706514749; x=1707119549; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hKwoviPF9lK3MXodrfrYqIC6rePNJHWY3NWvE/KNFG4=; b=IM1xypIZFipQ6u69VeG191vhC+c8laE9dbPmxJflWNzz0mFVrUoItqp/uO0yUvh09n apPND8KiHCp0DGqVnEM8NJl6Z/7X+oapmf4gr8Bz8yHOPLHDyl5NeyTqx7dqv2saMICr X7bUPGE0GpAq2mp2fAfsnkZ7dKlI0ZH1eFG5+wbv+5NFRa2O7iJb8c6cW+soqacEoSIt dPRqltgHeHLEGukPHSCFbX5xXn6wiEUzqC/+r79g65BHzVarMDm9UAib86ePlrLCsU5/ axhY1pfec3eNowv46DOD0njqveKC3Bz2fWls3Il//BMdY4+OB1SYIAXSrr5H8wrOvx8t bF0g== X-Gm-Message-State: AOJu0YywFWCbq+aawxG96xJDAoqhBpRdlUkLrAIF2j9Ke+DuCdRG3/BB Hwx0g2xYWHrps7+RzoAX0QQ+Ylegt+1o3m6FF1Vh1+Sj2p4UZhIYKsUDlpJCq6323XiVwgspuE0 = X-Received: by 2002:a62:d159:0:b0:6db:d4f8:bb1d with SMTP id t25-20020a62d159000000b006dbd4f8bb1dmr1559157pfl.2.1706514748782; Sun, 28 Jan 2024 23:52:28 -0800 (PST) Received: from [127.0.1.1] ([117.193.214.109]) by smtp.gmail.com with ESMTPSA id t19-20020a62d153000000b006dddd685bbesm5467329pfl.122.2024.01.28.23.52.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 23:52:28 -0800 (PST) From: Manivannan Sadhasivam Date: Mon, 29 Jan 2024 13:22:04 +0530 Subject: [PATCH 1/3] dt-bindings: ufs: qcom: Make reset properties as required Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240129-ufs-core-reset-fix-v1-1-7ac628aa735f@linaro.org> References: <20240129-ufs-core-reset-fix-v1-0-7ac628aa735f@linaro.org> In-Reply-To: <20240129-ufs-core-reset-fix-v1-0-7ac628aa735f@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Andy Gross , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=902; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=tTQT9Ku7RM1FLsAH3vWmzrAWVFN9wIhJQ1xDZJNKp4M=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlt1ku3SWI50z6DJN+7R7fmRweEhh0xY3/ioY31 p0C1ZBGJuWJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbdZLgAKCRBVnxHm/pHO 9SXMB/4ye39b1v8wXzuxS/o1v4RtjLlLVKqi/NF7kJjRDBql/AeZp2Hf9+s5yn417kUWlbcsLVO Hv3+1bV8Qbw+vY5P9VNH9VLyX1ZbqEbk45/TCxNp9Hf++u25PNjappM18E0ZRSOZ6EIFrmMHdXl eMcLxBY1kDQjvrbiawIdtPEG7SVhafiLkxL/cnOfCj1bWhvr2n/LljnEtLqsu9eyjHnrXmEjSTI FoGhc2e0gJCJADNnkl5dQLibYNJYd+8yNws4LHbb1L3+A0AfU/lTkaSXNsBnqZ86OO+Nsuj2kWn OpJjH2fcgHiXyuNP7M6bKXa44uyTFSawclFl3gxssnvZ1wIO X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789410459416450563 X-GMAIL-MSGID: 1789410459416450563 Apart from the legacy UFS controllers that were not supported in upstream, rest of the controllers do require reset property to reset the UFS host controller. So mark them as required. Even though this is an ABI break, the bindings should reflect the capabilities of the hardware. Signed-off-by: Manivannan Sadhasivam Acked-by: Rob Herring --- Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml index 10c146424baa..03dce5e402d1 100644 --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml @@ -108,6 +108,8 @@ properties: required: - compatible - reg + - resets + - reset-names allOf: - $ref: ufs-common.yaml From patchwork Mon Jan 29 07:52:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 193309 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp417560dyb; Sun, 28 Jan 2024 23:56:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IHkAiB8fUBVUayU65lGoUjF4prPY5TCxISQDneQ/4XNM/8wC+w4I9LXrURlAntp6mFu5ku+ X-Received: by 2002:a05:6a00:4b4f:b0:6da:bed1:c8b with SMTP id kr15-20020a056a004b4f00b006dabed10c8bmr6379759pfb.20.1706514992271; Sun, 28 Jan 2024 23:56:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706514992; cv=pass; d=google.com; s=arc-20160816; b=orHdjNUJzTC51XRMBqEe0jsFb9v1nnbBKFEf+x85ntNdEbcNea4FAI6KTn/WfRB80G R8/iaOdTJtCS/UAE0hK33XSmKTCk2vQghyBjn1HtmYf4esUcAxPq+/vu9duRrMZAV3VR Ah9SS1KQ3JWX0I4YQGVRjfGF5l7QLVDLU6CneBKw1318hrN9iSV+b0OT4itd/upv8gXz Q2J6AyC7ltgaksapHN17nfLOlibpyyk2rigipXzVxpmG2ecG6JTUxi4s+yfsPaq11Hxa V1hfkZyiQ51tOYO6bo03AUymnI0RpBhXqZ7DFR1bHAq3JU5Sj5dk2dktwT+ENZhPSsp9 AYzg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=ye389EYHKjCvOugxyWLCxfbNKt/VTFay9WwnmjxJvTs=; fh=hjMhmZkqMZNL0ukT+d1R4S+EoOklGq5tQ13rxgwrgsY=; b=QddLfwjd1RhF2E0yfoUZ0OGv/u+AJtdCQWWhgfzZxxF85tbnb19XMOMGj20RQOql5I kwK+WbfqCA+1Ig/1st2dhMmnimwGd5LvZ5iJmVCdYI8vn82m1SjnWXvYqjKcAUETFMBt mPibQOFVoIbuUDCVmaHpfTzXJrz3dYojNd9G2kGh+FDkFBmCgotkMjmmakX2RmgX1jZT 4xUL3Q4zCcEMohtjGu2iwI5gimtBvG6gxMeaccviF0Rz+Wsj73Z3Us/V9asQXZteouw7 QF41OI9SUVorQg0tIuktEwZDdi1B71zCKYCGYaBVItxlI6aBXAj7b77o8GnKokA7uGs8 nUhA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W4lsAjBx; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-42304-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42304-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id k82-20020a628455000000b006dbd4f841b5si5337476pfd.340.2024.01.28.23.56.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 23:56:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-42304-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W4lsAjBx; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-42304-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42304-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9D4BAB2236C for ; Mon, 29 Jan 2024 07:54:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 148F054F91; Mon, 29 Jan 2024 07:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="W4lsAjBx" Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64BEB52F72 for ; Mon, 29 Jan 2024 07:52:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706514757; cv=none; b=dPUmKC5xx4dp03gq8rhH3KFn2td6xcEg5DfKfZ5BgGRj/+CN5q6h1Qx2MT8UqMxjJ4QOm5rIEkCTaA8ec2LWkAQuu1ohsu9tfmNsRBYSPQuxTW1A3Yo0dTi/bQXOLX28RnTg1a9Mt0E2s4xioAt5+kAu3FVWAJ6oJVjVWo1YrLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706514757; c=relaxed/simple; bh=b4SvtNNZZGQQZdkuWZ0Rfu0VJ9qiw++F96jBPPIZhZs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TY1Jm6x7QG5VCStTU2oPUEKZTfPAtGybcSCXAJDGl/VwTKY6mb8p35rk4I1Zbx871MWY3coebaX09RYBtZi/6R0BP+jWQt0WEBLyUpxuX3rjIQFNZ30HiU4xGdMAf9RzQFJjDgWJYPXsPO01FncL/MMGTZ6x3HwWov1WloBShbY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=W4lsAjBx; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-5d7005ea1d0so1452904a12.1 for ; Sun, 28 Jan 2024 23:52:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706514755; x=1707119555; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ye389EYHKjCvOugxyWLCxfbNKt/VTFay9WwnmjxJvTs=; b=W4lsAjBxHQm7QXmyNb+3hWsn9nobuZ7MjYsar9oe+qBd9cqKtW6fWp/R5RgQActyoC 4/aAsg2YErI1c3wRU+JwRCZMtOs1r2eZU8JTQ8SgXSF8KpiWvLobsC6CQ3fIw8KeZszn Ll3zls6VBVYGDAwxxZAwtvnz/gfe4CmRIjNe4gu5knhfRs7oAVjCv8ipygo5TidJFKx/ Ai5Ox3Sjnqk35Z3fgvS+r69gUA7KJ4ikxhZ2Hy6zjRwt4hd3o5OTZcpKS+unzZ1S9nQc k4Z9/ySlzcMlYw//QCX/52SlbY/majXBBb1rOiUPtGsf1XfjnWBNsbxXOxV9fPcwQGgb 3Osg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706514755; x=1707119555; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ye389EYHKjCvOugxyWLCxfbNKt/VTFay9WwnmjxJvTs=; b=JLlNCD4o997hE8NbxFEs0+Uhw/Tdgdrl3a+LBdzK89YjMjwKqXJo8ejTeN/MfXzxuZ KwcaIXN8ptpLiOXHGOzBZhbbgOm7X18yUUPvhFzK4Ylt8aNfcBgKoaUYKeUuYwk9XY/M LRnwWNCc0l1KygegQorIkUhE/Tnod+bSchn/ADogyB/S8RSKVXh2goSekFpy1Z29Hbqz BFE0hxNpIfbujKmeuKy3AS2FkYqgiFuNZXlBwtnpwkv3c1OhSIMeJ91MDaRrcaS89hhY SeW5B7wb/8ph8XoVPY1rhSjmsU4qvpB4FuwRQcWQ7s3VzyEUcj0N5O2JGjVDacqSMBOH oQRw== X-Gm-Message-State: AOJu0YxWlESCtJPSiO7ZPephGaaSqGVtTYDn1f9l+wY0CycLhZnotEKN KyaJgnGETYuLy1Lx2qU/JsYbI3ezWqjnr8UZ9G6VBmCXWNh7A4vPTbD6hgihCA+ASz7e6no/p/U = X-Received: by 2002:a05:6a20:9587:b0:19c:8673:77 with SMTP id iu7-20020a056a20958700b0019c86730077mr5208625pzb.2.1706514755444; Sun, 28 Jan 2024 23:52:35 -0800 (PST) Received: from [127.0.1.1] ([117.193.214.109]) by smtp.gmail.com with ESMTPSA id t19-20020a62d153000000b006dddd685bbesm5467329pfl.122.2024.01.28.23.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 23:52:35 -0800 (PST) From: Manivannan Sadhasivam Date: Mon, 29 Jan 2024 13:22:05 +0530 Subject: [PATCH 2/3] scsi: ufs: qcom: Clarify the comment of core_reset property Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240129-ufs-core-reset-fix-v1-2-7ac628aa735f@linaro.org> References: <20240129-ufs-core-reset-fix-v1-0-7ac628aa735f@linaro.org> In-Reply-To: <20240129-ufs-core-reset-fix-v1-0-7ac628aa735f@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Andy Gross , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1271; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=b4SvtNNZZGQQZdkuWZ0Rfu0VJ9qiw++F96jBPPIZhZs=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlt1kv1hrO9+0MMLmC+cLokw5vh0sPSCLyGClUL iO40O5pPy6JATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbdZLwAKCRBVnxHm/pHO 9bh0CACPfxmuj/KcHNlhnpH/G/Dg1ykQ5lhbNfrrhMDXVU0Jb0xfTcfNLuTqFkKYX4PZl95a4c/ CrFfQg8SWnAAu5DVuUOFenyIsOTbRjHVABF0ZeAHR4KlxAkfRHTiVAoI2PoQWy/8q9tepAsPeuo WbNTSDwdyvBRt3pYy9XkVtENiGT7McWlnrEKDF5iffiPSIP6u8xj//GzK8JlcJhUftRsL+INDKw 46d15Qj3cfgBVAHOd4Q2XCxHptMHOUBxEUfCqT3RBvu3ATGSJ5KUzD1QnE1re6PjR2JhRMSqpxE QDgq9N7F57ExO8JINPdbH7NRyrMjvaEyarMjUH3s5Ndgaqup X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789410664484279767 X-GMAIL-MSGID: 1789410664484279767 core_reset is not an optional property for the platforms supported in upstream. Only for the non-upstreamed legacy platforms it is optional. But somehow a few of the upstreamed platforms do not pass this property by mistake. So clarify the comment to make it clear that even though core_reset is required, it is kept as optional to support the DTs that do not pass this property. Signed-off-by: Manivannan Sadhasivam --- drivers/ufs/host/ufs-qcom.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 39eef470f8fa..32760506dfeb 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -1027,7 +1027,11 @@ static int ufs_qcom_init(struct ufs_hba *hba) host->hba = hba; ufshcd_set_variant(hba, host); - /* Setup the optional reset control of HCI */ + /* + * Even though core_reset is required on all platforms, some DTs never + * passed this property. So we have to keep it optional for supporting + * them. + */ host->core_reset = devm_reset_control_get_optional(hba->dev, "rst"); if (IS_ERR(host->core_reset)) { err = dev_err_probe(dev, PTR_ERR(host->core_reset), From patchwork Mon Jan 29 07:52:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 193307 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp417426dyb; Sun, 28 Jan 2024 23:56:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IHfpsmpE7kMKwHrIFq4SD9Ueul0K58zknfUEq8BKHCsDV9erbXtfDnIBKhYJ0ggc0kOjvJY X-Received: by 2002:ac8:7e8d:0:b0:42a:8ad4:f716 with SMTP id w13-20020ac87e8d000000b0042a8ad4f716mr7676076qtj.83.1706514961858; Sun, 28 Jan 2024 23:56:01 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706514961; cv=pass; d=google.com; s=arc-20160816; b=Un64Gv1rea8jprwu2L5yLrHF2JFHmp4mM2M00J/N7u6xoU92cPQMUAXE/vzqOmWCIG B8CHwTS3dtdfQCCRk/olNcFaz0P7DcMhkUI6mtQPVjaEA3Pjey5kPUufCG64vmdzChqn eizZwWByXVaHeuJMYbWUSgt6rwzIy9gO3Q4aHubxOX6ZX+C3DjhO2pUVvD02bYI5d+/c gH03ob17N6CYwm4QyFDTJoV+Fv8g28d0NOmeBVxkcS3gEqnI6NvEvXKC2igK6HNWf7Qh zIQen2DiyXVjVwrnjuoaVJWstMHUivMxy7UJzSPF7fYVVD27E3zM6VcEFdmoTyHS9q+T uE0w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=HGZmbpiHB5LcToFKY964Ba6HaP984WWJZXhD/o2NB2w=; fh=hjMhmZkqMZNL0ukT+d1R4S+EoOklGq5tQ13rxgwrgsY=; b=wkYCrhd57sPLX+B9aMBs1CO/jwu2F18EE+xiXt+JVXRvPTwdVUZ1saG9iKXQXvawjZ 2HLPtyvF51gJYpPvg7oMEoFcGwYrEYZqsR0QYNSNUzEo5c3GEnFrrwA/sfnmvUTEHc0s lS+G6+M0Cg9rtRbmuyexHneoK7OWfTJpdxKI2YGmglX2NSZGPXkffSQCHDeVHl5ehy0W fPPK4UN9TyPZ6k0HAfnulyNpE0+S//9awIn3OUQ4F0XGvM2bkklxcc6UWsmFOBzVhszb IeVCkH4x4AzoPSjzkWPY83qpiSyphju4K1NrycgWefsgNJoocK5PkAFMP/uNyJx7RGpl iYcQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NTriMtlb; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-42308-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42308-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id t14-20020a05622a01ce00b0042a8615f726si6127839qtw.597.2024.01.28.23.56.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 23:56:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-42308-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NTriMtlb; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-42308-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42308-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 97A761C236D7 for ; Mon, 29 Jan 2024 07:56:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6E54056740; Mon, 29 Jan 2024 07:52:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NTriMtlb" Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07C9155C15 for ; Mon, 29 Jan 2024 07:52:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706514764; cv=none; b=T0cr9zSj9jQZzV2l/HpQCwbgUwJ3xUWedp1SDd0Ar00wwp2NCoNI1Fl2aIZKsBw7Lg7K/267BudZihT+BsfUE6f8FvRjNj7lLCdx7e6gBOMyXQy6L2s7QoXZco6y/AW8DgIFUXXXITuhge+5nXxvI+oXAaGEQ8+UCzjWMfnyF2E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706514764; c=relaxed/simple; bh=RDS3ZoaA8gicslZTrtrM9BW7KEYbWoKjgQpkJyCx8uY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iR+wtY5V3pE5fn8cXcfXT+MGJkEqGK4B+GHYTUedD01kxCtgVnu0uhntKTdbuyPFNi3AzUV5QHo8bQddbQ5IGtn+ShYMzVLSaXVqMttQCQG+Y40GV7YNCzuCI67VHY8qkr6/ThCxw0hveYs2GhSOMbZCkpoG+utogUqINDXVkdo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NTriMtlb; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6de24201aa6so296421b3a.2 for ; Sun, 28 Jan 2024 23:52:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706514762; x=1707119562; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HGZmbpiHB5LcToFKY964Ba6HaP984WWJZXhD/o2NB2w=; b=NTriMtlbgQ9gWGdhuTLfp7kOfewZ9dOhrShHIqE04fgyjiv0oLnuMashYpUGSoDKUS Os6JofK2JZN1yMKVBybAinCkyOZvmYo0sBIpMBdT9gN7Q9OzdCfTyOK98shb3pVpeqYs 2Gchyak6cR0mk1LNpNk8vOXqDT2t/tbPaMMlRw5nkpSoFaVXeEes5vljQTsVU8Tr4Hr4 Tiv49PpBDp3RfhZSOoJPlJ8mRisef9YRv3zW8KPq4uMtwkn8XiehEMhghOQd22gaXPI7 /1tHuGBaR6oWD5MfV1luEVaScaMMj5tsz+0N0Xrs1nT+tTrq544HFl0xgiTUtbBgV5c6 roxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706514762; x=1707119562; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HGZmbpiHB5LcToFKY964Ba6HaP984WWJZXhD/o2NB2w=; b=tKj+3jPP4S6VkF9Kde8N+5B5iRAZs+zT32JsvPssOubtUqwRxkrxU1lJhLrcAv1Khz KKugL3PvU0SArZlEcONGAcKX806L6DzH6dw1E8lV5XotxtrmvqRvNlaYscVy1pZUJ0jz Kz53O6LsFHhnek4PGmEhKWCPyC1Vnym0OyrEAcE2eW1jfhJwrsCMywLpPdpF1yfU5ECg RFesw4/tBfIWjbiBi/3+fe5eXV38e3W3tL3K8hZMrr89M++pT/S9i525YmrXRJA+lCro tLjJtMFNtRguPGUXk29DahvYiVZ6FOZRbQJMvnsLiZ9aIFiApwxJd3iWbm1pmnmykPxO LWTw== X-Gm-Message-State: AOJu0YwR+lpPRcuXzv8c2lI7zj+FDStFRQ7ZdTH2ysaHOowiCu2YaBA0 ZTGZN2CZco3Kqotx9BlJ0VaRucVtewmJzsJClVm7gV6nD4dbWMV7YYD8x+eQLVal0DUV3Fw9mY4 = X-Received: by 2002:a05:6a00:138f:b0:6dd:dbb2:8ee9 with SMTP id t15-20020a056a00138f00b006dddbb28ee9mr3441304pfg.6.1706514761954; Sun, 28 Jan 2024 23:52:41 -0800 (PST) Received: from [127.0.1.1] ([117.193.214.109]) by smtp.gmail.com with ESMTPSA id t19-20020a62d153000000b006dddd685bbesm5467329pfl.122.2024.01.28.23.52.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 23:52:41 -0800 (PST) From: Manivannan Sadhasivam Date: Mon, 29 Jan 2024 13:22:06 +0530 Subject: [PATCH 3/3] arm64: dts: qcom: msm8996: Add missing UFS host controller reset Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240129-ufs-core-reset-fix-v1-3-7ac628aa735f@linaro.org> References: <20240129-ufs-core-reset-fix-v1-0-7ac628aa735f@linaro.org> In-Reply-To: <20240129-ufs-core-reset-fix-v1-0-7ac628aa735f@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Andy Gross , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=871; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=RDS3ZoaA8gicslZTrtrM9BW7KEYbWoKjgQpkJyCx8uY=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlt1kv3559B3ZmFp95EfvcA/qs983RKuPwQsFLJ LOoamFISWeJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbdZLwAKCRBVnxHm/pHO 9RiWB/9WYqXIx/kGqIVlP6rmJnnmWoZjyVR89BVi3fUMSh1HRZwHrR2Qbe0sfSxB4Kr5zeeQcrD 3XfbKs+eu2nqNfxqSlUXVurUkB/bFQCGu4oQHvhiWxCYTA4/s3R7XM/7HmfClsFlY1UaYFUujXa AGEHJrzYPPK+XWMEuM4aQ2WEOYUikKu1BzU7755v2OPYwKeDcIH7WlHdDg6+/N4VNUZmjPq375P eFKciTWzxm3x2bSxck9/uOJ8dm3p0BmjFkgrZ4Cmg3J2tiV2zlZBfgXrI1BgPaKG9/wud2jkPUN gH73zWmaXnDESGrKZZOaYYP4+0kApTt1ReGO+UV60bG1TzO4 X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789410632173951817 X-GMAIL-MSGID: 1789410632173951817 UFS host controller reset is required for the drivers to properly reset the controller. Hence, add it. Fixes: 57fc67ef0d35 ("arm64: dts: qcom: msm8996: Add ufs related nodes") Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 8d41ed261adf..a6592b3e2db7 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -2114,6 +2114,8 @@ ufshc: ufshc@624000 { <&bimc MASTER_AMPSS_M0 &cnoc SLAVE_UFS_CFG>; interconnect-names = "ufs-ddr", "cpu-ufs"; + resets = <&gcc GCC_UFS_BCR>; + reset-names = "rst"; lanes-per-direction = <1>; #reset-cells = <1>; status = "disabled";