From patchwork Sun Jan 28 20:45:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aren X-Patchwork-Id: 193171 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp218541dyb; Sun, 28 Jan 2024 12:49:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IFHBP5aYl2kgpTAJJx1Ioqpip37XyBuTr5F8hDp5UmQpula7fwp9OEgShf+DdZguA4alo6r X-Received: by 2002:a05:620a:1198:b0:783:aae7:3ba6 with SMTP id b24-20020a05620a119800b00783aae73ba6mr5100877qkk.59.1706474951191; Sun, 28 Jan 2024 12:49:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706474951; cv=pass; d=google.com; s=arc-20160816; b=UImk1HPlNx4vEk0jh0d3Lv6xaJcjLkM9+ukssPo4Aw8tJfRtPgZOSKqTYvL86075OI mCBPS5XGWY7DFI3z3PFRYvI1VH/gbzXptemZeviEn88fsAJ/ROylOmonbboUiVzWkWA2 G3DEKQZW3ERUp7WLiZjbez1hVTq1vryCfaaVHesjDuwaXOUbEOVM7ZWCTyvBeEORdgBx kKTR2l3UsnHolZisqHrfXSxiZm3ZHH0HWXuT0No6MCH3K+kZYkvFNUlQOjs7e5kX64Rr 0jU7gHEKXfsXwLW15ot3NanABRX/NB8fdos+WV8Ojd1oR0mNFc4X1c2iaricI5JUWxAE yN2g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=dkim-signature:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:message-id:date :subject:cc:to:from; bh=lb0m4VN+fLcRwTMjHhUiN4pOHzBM3BNlNUXpNwfCjmE=; fh=njozN0qru9YNTgJtJOIUDJb6czKSA6JD/2GDjvQI5IY=; b=OsdLuHLOJ5mdSTh2K7AoozXG1XJTdr4g/MfNOZwp08/vBzLeVOKbbZDX5jlbfXQdsr 6g4k3ol59rdYQA0qMu21nk/6bthjeczMUIx6RRglXBnFHrCYUocRhVj1fuisc0my2Gm8 81bmvnmAkjSs+id90F09KQyxxxrnGEd4UFf4MC+P2HqWik/Ev6I+CEvvNGoRIdN3l9fu 6u5d7QdgUDwymshkKF+KOubniymUaJ3EDBOr34q6iEG/r+Ze80Ie+PjrNtEe3aby8Qp4 NCHJEW0jhJHApxrtBusbTu9wIIqGLxEln45ypA3H/rQDqs3QrY0q8Udf0Z8gqGlYsoF6 VLAA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b=Q7uXlMIy; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-41948-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41948-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id vr3-20020a05620a55a300b00783ab755e57si3670749qkn.429.2024.01.28.12.49.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 12:49:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-41948-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b=Q7uXlMIy; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-41948-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41948-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 0218C1C2164D for ; Sun, 28 Jan 2024 20:49:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 984063C48A; Sun, 28 Jan 2024 20:48:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b="Q7uXlMIy" Received: from a.peacevolution.org (a.peacevolution.org [206.189.193.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B3BC2E62B; Sun, 28 Jan 2024 20:48:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=206.189.193.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706474925; cv=none; b=pMpOLPp22r9kW7iidKxC+DSDDMKOq5DyfG72a9srPMStad8E/P+bK3Lk6IAxiCwN0sGLR1BnLXezDdrI/o7fwOYitBp0KMFWnu1zFae7T0jwV6xSbCYYMAZWZZkbEbiwRXPbkF8CA+r7kExGgE6ChplFKhxMsicO9dtGTZu0vmI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706474925; c=relaxed/simple; bh=DKGeUasBS6xTyhYqe+UExGr24G9PuFPZv+fUiAffDj4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oWAqEMi8WW6rfSWVRxKzLSIJuuvb+lm69zj7EVEwla80TdItQHq8Zc0tu1bSs8g4RS45rS5jHauSrVdCK+Ft+WJTZkjmVmzhpbOrykVP97Xn96lbD7ck8TTjdJQ8VafEq2WK/lQWX16dLPH4kpsZZluU7/LM9plaezLMWQChNcM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org; spf=pass smtp.mailfrom=peacevolution.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b=Q7uXlMIy; arc=none smtp.client-ip=206.189.193.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peacevolution.org Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id B11E846366; Sun, 28 Jan 2024 20:48:35 +0000 (UTC) From: Aren Moynihan To: linux-kernel@vger.kernel.org Cc: Miles Alan , Ondrej Jirman , Aren Moynihan , Jean-Jacques Hiblot , Lee Jones , Pavel Machek , linux-leds@vger.kernel.org Subject: [PATCH 1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend Date: Sun, 28 Jan 2024 15:45:07 -0500 Message-ID: <20240128204740.2355092-1-aren@peacevolution.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org X-Spam-Level: **** X-Spamd-Bar: ++++ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1706474916; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding; bh=lb0m4VN+fLcRwTMjHhUiN4pOHzBM3BNlNUXpNwfCjmE=; b=Q7uXlMIygUiuEL02z/PKkAuY3qqvE7csYD6Ap3VSRKMhAcg9XvsTxqUCfzt1iXgwsFM/dA OjBDHPlh47mATnlAVVPe8P9+k/GJS+gEBeeDeytbBimKfDq+phqSniMkY4TWN7GlpCfmcI uWHqkBDSAjOl2f0CL/XYL7DgnPb4WCk= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789368678643639358 X-GMAIL-MSGID: 1789368678643639358 If none of the managed leds enable LED_CORE_SUSPENDRESUME, then we shouldn't need to set it here. This makes it possible to use multicolor groups with gpio leds that enable retain-state-suspended in the device tree. Signed-off-by: Aren Moynihan --- drivers/leds/rgb/leds-group-multicolor.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/leds/rgb/leds-group-multicolor.c b/drivers/leds/rgb/leds-group-multicolor.c index 39f58be32af5..194c6a33640b 100644 --- a/drivers/leds/rgb/leds-group-multicolor.c +++ b/drivers/leds/rgb/leds-group-multicolor.c @@ -69,7 +69,7 @@ static int leds_gmc_probe(struct platform_device *pdev) struct mc_subled *subled; struct leds_multicolor *priv; unsigned int max_brightness = 0; - int i, ret, count = 0; + int i, ret, count, common_flags = 0; priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) @@ -91,6 +91,7 @@ static int leds_gmc_probe(struct platform_device *pdev) if (!priv->monochromatics) return -ENOMEM; + common_flags |= led_cdev->flags; priv->monochromatics[count] = led_cdev; max_brightness = max(max_brightness, led_cdev->max_brightness); @@ -114,12 +115,15 @@ static int leds_gmc_probe(struct platform_device *pdev) /* Initialise the multicolor's LED class device */ cdev = &priv->mc_cdev.led_cdev; - cdev->flags = LED_CORE_SUSPENDRESUME; cdev->brightness_set_blocking = leds_gmc_set; cdev->max_brightness = max_brightness; cdev->color = LED_COLOR_ID_MULTI; priv->mc_cdev.num_colors = count; + /* we only need suspend/resume if a sub-led requests it */ + if (common_flags & LED_CORE_SUSPENDRESUME) + cdev->flags = LED_CORE_SUSPENDRESUME; + init_data.fwnode = dev_fwnode(dev); ret = devm_led_classdev_multicolor_register_ext(dev, &priv->mc_cdev, &init_data); if (ret) From patchwork Sun Jan 28 20:45:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aren X-Patchwork-Id: 193174 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp220465dyb; Sun, 28 Jan 2024 12:56:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IEMBVUwT7gyvHK/9+UJZlDCa2Ro40UJH6ZhsKOtNVSp0FI6X9fUTESuAkGYB0c5R7hthQNs X-Received: by 2002:aa7:d410:0:b0:55e:fa19:9c0c with SMTP id z16-20020aa7d410000000b0055efa199c0cmr710252edq.9.1706475393896; Sun, 28 Jan 2024 12:56:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706475393; cv=pass; d=google.com; s=arc-20160816; b=f2FQAZfSE9bQRY+XVSBwS7I0AiGOBXANqP3UTvZ2CwqHoyLn0nuWo48fV94K1LHBNE b9M14Thgjm7wyPkErKiaDI3sNSNaYmaQCuUk4eHY6GHRIOKTTjYzcF77sbkQlHsGOhuF mGvREy8IZV6dURdcBrFY8CcGknc1hm+A1x+0SrJJoTlq+rC8tPz/4Wm250jFcpwA+ROW bdlW07PrXcZ5eK9z2RUomx64RT8533EtseFHDKkJ86zXufoWFNpV0ZbKX7gThDIIF5Gb bKNww9C2778WlDb6gen5P0ICqgYEqZdDE2Er2Iu6QUKGtt3DkDvhiy++XeOOlfO6D4f/ OsDQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=dkim-signature:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from; bh=7f8Pqy4UhROYbk09gyqrlaBXv9qrJ3dn1Gj623LQxSg=; fh=vogt2Ndq24/cMfcnX2+D+YjJWcEOQng4OQGQG6hZSjo=; b=Xpm/7wOoxEzMABJHcQqLMcbG3XDAnxu99/o6nvRV0IV5Z2sfSrYy8DtPHT39XtxgNm tYkiupmP71pUcK5x1xztSTNxWbiCPO7NvS8PRTHwtuuWgLmyAJThOxU0VmCWWV97U16C mLe9GiVIDWF8I6pa9EAZakSdjkhmwjFdHHMstUu30maYoOHKRg0/u0IVhEuRInz8WFHA tm+aC5dAuWY0fkrnJNT2E1cRXinMkmupOMi0xHVTX4J36iEjllFdTTbPiAMFN0c3M+pZ 1SgldIn26iQKsD01TrfWvEJIhUeTwEe+zhb3Ww0GYfT/E/tWhLr+WZFNS1iq7nYx7c5E spsg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b=EJOMD3Ho; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-41950-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41950-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id h26-20020aa7de1a000000b0055ee91dd347si757643edv.497.2024.01.28.12.56.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 12:56:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-41950-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b=EJOMD3Ho; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-41950-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41950-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2FFC31F22C4A for ; Sun, 28 Jan 2024 20:49:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DC4CA41A91; Sun, 28 Jan 2024 20:48:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b="EJOMD3Ho" Received: from a.peacevolution.org (a.peacevolution.org [206.189.193.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F9812EB1C; Sun, 28 Jan 2024 20:48:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=206.189.193.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706474928; cv=none; b=Vocekce3nilwPd4g0cROpcIBK4rE501ybCrroSe5oTFlB8kVIqLXDxQgHZ4hqMCGFPgJgBAmaqcQffbyfTVjfbViYOyQ4QO5VK0iiR6h32L65eXH8nHw52eIk6Dhbp80F82xs95i0lf3obu1+vV5R9m4HXyRt54btC3XCgVQ/EE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706474928; c=relaxed/simple; bh=sC4x0F7ocxCOiTa61zP6CfELEuBIay9GFpbnCJDfh/Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MZCWfZzua3aHBrIEJxTGXQMg1h0R0S9jba7qbHwP19ClyGpchUmpDStJ5h8Hzw6EdcNro1j6+jnatjPPSUOWVYbMbzqG0K0Sp2qHP+6dOkXoFMbkrKaWO6iFVqny97iRveaOUjydpuXSdOdsvV2Ffa7xfUTXU/EWky7FGumzLc8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org; spf=pass smtp.mailfrom=peacevolution.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b=EJOMD3Ho; arc=none smtp.client-ip=206.189.193.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peacevolution.org Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id C738C4649A; Sun, 28 Jan 2024 20:48:39 +0000 (UTC) From: Aren Moynihan To: linux-kernel@vger.kernel.org Cc: Miles Alan , Ondrej Jirman , Aren Moynihan , Chen-Yu Tsai , Conor Dooley , Jernej Skrabec , Krzysztof Kozlowski , Rob Herring , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH 2/4] arm64: dts: sun50i-a64-pinephone: Retain leds state in suspend Date: Sun, 28 Jan 2024 15:45:08 -0500 Message-ID: <20240128204740.2355092-2-aren@peacevolution.org> In-Reply-To: <20240128204740.2355092-1-aren@peacevolution.org> References: <20240128204740.2355092-1-aren@peacevolution.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org X-Spam-Level: ** X-Spamd-Bar: ++ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1706474920; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding:in-reply-to:references; bh=7f8Pqy4UhROYbk09gyqrlaBXv9qrJ3dn1Gj623LQxSg=; b=EJOMD3HotjeLQcDFlPSxcFnoN3nW4WypH8d+tyrewLLGqsU46t6K1yLdx3qDx2od6hNEj3 BMaTuqsa8o9W0bD3JuUYBTNax2AflA0B+a69MUnW6kIL9uP8fgDXUz/lcW2PKB1ak5I6ie KujAkq7t9VoaDzzJ8fkALkziEg4/9Ss= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789369142252680137 X-GMAIL-MSGID: 1789369142252680137 From: Miles Alan Allows user to set a led before entering suspend to know that the phone is still on (or could be used for notifications etc.) Signed-off-by: Miles Alan Signed-off-by: Ondrej Jirman Signed-off-by: Aren Moynihan Reviewed-by: Jernej Skrabec --- arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi index 87847116ab6d..ad2476ee01e4 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi @@ -43,18 +43,21 @@ led-0 { function = LED_FUNCTION_INDICATOR; color = ; gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */ + retain-state-suspended; }; led-1 { function = LED_FUNCTION_INDICATOR; color = ; gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */ + retain-state-suspended; }; led-2 { function = LED_FUNCTION_INDICATOR; color = ; gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */ + retain-state-suspended; }; }; From patchwork Sun Jan 28 20:45:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aren X-Patchwork-Id: 193172 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp218597dyb; Sun, 28 Jan 2024 12:49:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IFI0/mNMYNvdqY6sS8FNzWNu1Jure06R01JEL5D2CzWvZd6dztibHrSl+e2Z1IjDiP2N1Op X-Received: by 2002:a05:6a20:438d:b0:19c:a398:4a67 with SMTP id i13-20020a056a20438d00b0019ca3984a67mr2345828pzl.55.1706474960732; Sun, 28 Jan 2024 12:49:20 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706474960; cv=pass; d=google.com; s=arc-20160816; b=ttxX9BZiaicVd/DWbQqMyVaXNUFivYdZgr+mylv4UEx+TDJU8ThVp/VJrsQQea8w9Q faCJvCN7+Nu2Cz0UTbtioZhVCuTKYCIPKRlqfvhkCsShYZ77RUrxoMa7rXWZ0l2cj3gD 7NnLNBvve72XR1G5qHLXjHhWxrxGkp93vdUtOD8Ig5oqI2MJa2b/fbzXy/4eOOEW0yE4 C7IlhbtfIfB5yHz8TWSOayuGLx8F7h677lTqTn6jcJJj/hMysGjn84VfKBbLzLMmaAx7 TSs493BQ6sFglksuF37GvKDlrltx2Wzp7nxIfyTrWVkA0LHjtJhf4guIc3HBz/fB1heE 8uyw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=dkim-signature:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from; bh=LF65+XU8LGrrA9Zpn4EYhMkrdltaZDZoBBCOReuYI8w=; fh=vogt2Ndq24/cMfcnX2+D+YjJWcEOQng4OQGQG6hZSjo=; b=QHKNfXxfc2+4ykcReWW0S+e0/g5l760nNVPN8etXjQXXSCmGAG+wTuTadwMG+T0CZf uV4dO7b4ElbJ43AqhMcHB6TyNG7Ybpald0Ix7LcrLkU6pMzFcLzaPzGsHfrupo0jJ8+l /dzPXPGNwdLdcnkuo0CYC4mPudSZM4YkV5XJiDHgwUt4Vc1ykEJLSiV4HIo0IIHzV3aU lXJlZLOKXoGNpDlQt23hwctXJ56x9W73JSN5rcrcrKRYBmiZyZyRPh5diJ/go9oXWP5q BNrnhP/Pu6jxcq3INYA9JfyGWnB0PrjaeyQ1Pm5odGx7TFD+GH2v5e9QSVFzf9a8dNgn CcDw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b="bFmkZPm/"; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-41949-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41949-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id l20-20020a656814000000b005cf8e57c831si4549587pgt.187.2024.01.28.12.49.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 12:49:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-41949-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b="bFmkZPm/"; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-41949-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41949-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B0AF8B21862 for ; Sun, 28 Jan 2024 20:49:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4F8B53C68E; Sun, 28 Jan 2024 20:48:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b="bFmkZPm/" Received: from a.peacevolution.org (a.peacevolution.org [206.189.193.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 473252E832; Sun, 28 Jan 2024 20:48:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=206.189.193.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706474926; cv=none; b=aoyJQ7kZ64KPauof89tLXAZvdXwq8JqvHihMdFG4Wuw1L2dFlLQLL0cmZn3v5YkGRPn3xH+F/tGfX8wLsQTAw3LRCly0msb3FShPhoD8YyKM3nv+4AilkSFpbZcKmNTwo0UpMeA1VI99KrY3p+4Bmuqp+EgiTktSgdl6a4P/8tU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706474926; c=relaxed/simple; bh=ag9tr2tiU3unZXuvPUm4zcESACgalTxlviYKmkloah4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nxIMx0TR3bZVBwcdG5Z/rBrBzHFz1UYForxoh8XoH8fiVZsnzgXPz6ipZ43jrpwvKTjsVT9E7R1MkW/L9uQGo2Frus43hwBTwhvqmCC/55KSLdIbuug8E1JmPiIH6JXyb6/RsqtPsG+TH+kh0JCdloTfGE4e9dQ1LiO9W3mzbSQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org; spf=pass smtp.mailfrom=peacevolution.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b=bFmkZPm/; arc=none smtp.client-ip=206.189.193.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peacevolution.org Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id 414794653B; Sun, 28 Jan 2024 20:48:42 +0000 (UTC) From: Aren Moynihan To: linux-kernel@vger.kernel.org Cc: Miles Alan , Ondrej Jirman , Aren Moynihan , Chen-Yu Tsai , Conor Dooley , Jernej Skrabec , Krzysztof Kozlowski , Rob Herring , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH 3/4] arm64: dts: sun50i-a64-pinephone: add multicolor led node Date: Sun, 28 Jan 2024 15:45:09 -0500 Message-ID: <20240128204740.2355092-3-aren@peacevolution.org> In-Reply-To: <20240128204740.2355092-1-aren@peacevolution.org> References: <20240128204740.2355092-1-aren@peacevolution.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org X-Spam-Level: ** X-Spamd-Bar: ++ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1706474923; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding:in-reply-to:references; bh=LF65+XU8LGrrA9Zpn4EYhMkrdltaZDZoBBCOReuYI8w=; b=bFmkZPm/+Yyttzt/b7BF92FqLnBgnS1PONw3BdS3t253B/ffa43+54TaQ8sg3Rb4Ig/Wzo Paho7iUNgddGj8+9a/Thzyj9W38GTjreOru4TPAdIPqVdQGr8aeSPsNbTA5wIMUqVQiH0F fn/n6G+oE80ZW9yQmoCUfHCDouUFUd8= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789368688246930199 X-GMAIL-MSGID: 1789368688246930199 The red, green, and blue leds currently in the device tree represent a single rgb led on the front of the PinePhone. Signed-off-by: Aren Moynihan --- .../boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi index ad2476ee01e4..6eab61a12cd8 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi @@ -39,21 +39,21 @@ chosen { leds { compatible = "gpio-leds"; - led-0 { + led0: led-0 { function = LED_FUNCTION_INDICATOR; color = ; gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */ retain-state-suspended; }; - led-1 { + led1: led-1 { function = LED_FUNCTION_INDICATOR; color = ; gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */ retain-state-suspended; }; - led-2 { + led2: led-2 { function = LED_FUNCTION_INDICATOR; color = ; gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */ @@ -61,6 +61,13 @@ led-2 { }; }; + multi-led { + compatible = "leds-group-multicolor"; + color = ; + function = LED_FUNCTION_INDICATOR; + leds = <&led0>, <&led1>, <&led2>; + }; + reg_ps: ps-regulator { compatible = "regulator-fixed"; regulator-name = "ps"; From patchwork Sun Jan 28 20:45:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aren X-Patchwork-Id: 193173 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp218696dyb; Sun, 28 Jan 2024 12:49:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IGB+Sqk0lI6d7n4YkgRjJw2v9mci/by3KOHlclLMOQJMhXdkZ4oCAo8dlkB01WYzTXj93UL X-Received: by 2002:a05:6870:a11c:b0:218:4171:f0e1 with SMTP id m28-20020a056870a11c00b002184171f0e1mr4053676oae.59.1706474981666; Sun, 28 Jan 2024 12:49:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706474981; cv=pass; d=google.com; s=arc-20160816; b=uxNQ6XcDbNkPyUwrFnB8+vcVxtRFCsNi3LpW8s7cM5ZbI074NLtr9EEUDvQ8DgHybM 8+oh0g2gB1TlruWf8hUud8K0d1of8wPFGIMDIaWmsWy/1no8SwzLiTtIWh/KL86AfY3/ 94jAiMKYuG1fhcXpaVbr1F6FxQTuRCnOUtjRo/RyX2S5he5ddmy7dTv3Ec9c5xXthU8E 9iEBf+WZ7/r5b+uxq01xrahkiEPw7DUkNiTIfGH4xqi8fL5EYPmcsTLrISqjaM+DKMGZ /ssTDLwRZliIMsyt675XYVxJ1ZtcLFxj0ERYTmFi1fcZZ/+CY5fQAQr7Lz1xGEUnFmhI XK4g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=dkim-signature:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from; bh=d/DBwpJ+je99z0h/gXOCUsLpwa/Zbmn1hRkJbFumB7A=; fh=vogt2Ndq24/cMfcnX2+D+YjJWcEOQng4OQGQG6hZSjo=; b=Yl19tcYNPp7gndHReEgkvZpuJ4/AVePsiFBqhf+i5TMZ53tGlKwY5PHd0KHWy+tL2c HHsadTfExm/ARxBf4HNF/4w2lDzDH0ILaZwPNBYef+bzBGggxG/thVr1rYoyqOJwluTD 173Op/0JlwcvWCN/4kosg82O276c0yM2UQyqCIEcf/b36Xwi21LSugJDIvVRc78J6osh b4hsx2qb/sNVUKKfyk3aUPi4AHeS4vt1CdBWRGwEthYI1fXXl8MqMK10xqsyqS/Gx0iq lWq7KLFz9y6fPe5noWIAUiwAYuShLBW+aDPfnsNpXO7p8zkf1jh4OqW+Hh4JsFcwn8SR oqEQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b=LCKLWsPl; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-41951-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41951-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id cl2-20020a056a02098200b005d23a86b256si4655451pgb.688.2024.01.28.12.49.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jan 2024 12:49:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-41951-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b=LCKLWsPl; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-41951-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41951-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6A1992831AE for ; Sun, 28 Jan 2024 20:49:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BC0C942059; Sun, 28 Jan 2024 20:48:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b="LCKLWsPl" Received: from a.peacevolution.org (a.peacevolution.org [206.189.193.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8CB33D568; Sun, 28 Jan 2024 20:48:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=206.189.193.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706474932; cv=none; b=okGhcue5hG0yueaezKnh0BqhNSMRs2PUEa0GFzhGfQOxPQuzc6KXxc1VXESqT8VaLxiQidz3VSNrJGav2F/Hf4orXc7l7GrwosEakVorVGnM1XPD5ps0FMsQ5wcunksgnqxviaceQHxl7G+Sw3nQYxXN/UKPqudQU7wreEejSyI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706474932; c=relaxed/simple; bh=0llpIrBcrSsgkq+tDt1UudYHAWxp0O8mGXQOF1XSgn0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VOFuyXajjpI9cES4T0zLQasnOgyrkULcFwVe5ivt21yCcPbzRoKzNTbaGUHyeFMsxj3RAuZ/XH0hzh1L3gPHcARMMw+0hFKRQWvK/pSgB+GlBgx9KRuD5y4q1J36Zg7mhCG50AUt0S16Oz9gPGUQWBh6hdIFocvHfLHSLsVRCXo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org; spf=pass smtp.mailfrom=peacevolution.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b=LCKLWsPl; arc=none smtp.client-ip=206.189.193.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peacevolution.org Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id F2CFE46366; Sun, 28 Jan 2024 20:48:48 +0000 (UTC) From: Aren Moynihan To: linux-kernel@vger.kernel.org Cc: Miles Alan , Ondrej Jirman , Aren Moynihan , Chen-Yu Tsai , Conor Dooley , Jernej Skrabec , Krzysztof Kozlowski , Rob Herring , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH 4/4] arm64: dts: sun50i-a64-pinephone: change led type to status Date: Sun, 28 Jan 2024 15:45:10 -0500 Message-ID: <20240128204740.2355092-4-aren@peacevolution.org> In-Reply-To: <20240128204740.2355092-1-aren@peacevolution.org> References: <20240128204740.2355092-1-aren@peacevolution.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org X-Spam-Level: **** X-Spamd-Bar: ++++ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1706474929; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding:in-reply-to:references; bh=d/DBwpJ+je99z0h/gXOCUsLpwa/Zbmn1hRkJbFumB7A=; b=LCKLWsPlqvRQtiFZG1vk9RGo0PpHdusVxfhM+KBizv3IAzHDsEBOKiiqeQm2cRJysOQFlj yPD70phfaq/ONb8DwmyRcEqXprMWwQOEdEHKTscwSMPBAhH8XM4LwjOs+hHD/8GPzG1smq Sh/bcnY8qMKjVHRvgiSCewPgy+j4XG4= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789368710493808064 X-GMAIL-MSGID: 1789368710493808064 The status function is described in the documentation as being a rgb led used for system notifications on phones[1][2]. This is exactly what this led is used for on the PinePhone, so using status is probably more accurate than indicator. 1: Documentation/leds/well-known-leds.txt 2: include/dt-bindings/leds/common.h Signed-off-by: Aren Moynihan --- I can't find any documentation describing the indicator function, so it's definitely less specific than status, but besides that I'm not sure how it compares. Please ignore this patch if it's not useful and/or just causing churn. arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi index 6eab61a12cd8..4f39cfeb13ec 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi @@ -40,21 +40,21 @@ leds { compatible = "gpio-leds"; led0: led-0 { - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; color = ; gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */ retain-state-suspended; }; led1: led-1 { - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; color = ; gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */ retain-state-suspended; }; led2: led-2 { - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; color = ; gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */ retain-state-suspended; @@ -64,7 +64,7 @@ led2: led-2 { multi-led { compatible = "leds-group-multicolor"; color = ; - function = LED_FUNCTION_INDICATOR; + function = LED_FUNCTION_STATUS; leds = <&led0>, <&led1>, <&led2>; };