From patchwork Sat Jan 27 00:35:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 192925 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2395:b0:106:343:edcb with SMTP id gw21csp236697dyb; Fri, 26 Jan 2024 16:38:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IEvbSkCItkugEcddSSqdf/MUQFNuUF++VYjeVbUYi5kUk5i2h+ISQJb8h7J5AFVT6FKt9ky X-Received: by 2002:a05:622a:50f:b0:42a:7254:83ea with SMTP id l15-20020a05622a050f00b0042a725483eamr1289278qtx.41.1706315893031; Fri, 26 Jan 2024 16:38:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706315893; cv=pass; d=google.com; s=arc-20160816; b=PJzlfBySw5+v0aQUhtjUlZ8mKOlDF7w6awGVbRfcK8XLo5dpk56pHk2Xm9CZcTOy2g REIdzIKUsHzhPmYEMVG6dc+j4nMoCNwBxvIB2lkvKBPJ3YfoW+ZDpZpabS+dQPjNKWcz WgGZlcwFbHapg0G6b+ej0xkZ07RpVo18fDuQOyh7U6bg0QeXUPbCeex/hnx4OllTLU8n YHPsMqFzBgOFR/nlGoA9Zq/r9R5YOWbMfj05tmy/Kpmbg/voT74G3pOFug0RoZJEWoGa LrAFByq0JL9SYZryvua2JktxTbf9+7KScEGE/h3q9DJsKkVndLtvkH4ev3RwqxQ90ZR9 lruQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=RTtyOoMvI5/Gh43pPNKlry47E9NXmSJ8tqA/H0tsxRY=; fh=WrhIizNXy+YZmlhXQ3CjStW2Q+f/L9mPBsAa/xOhbRk=; b=j7XMysJVcvO2xj/RFJq+n9G80Gcapc4RD9TyY2u8zSbNzw3+WVsSC5PGgGza4l07ZO GpmKc8OAnWKr495/pepBLTTwHUXDFxW0BiIcHZpaAmmNv1ImD4NSSkAmKdaoJuNCg2yB 3AJthoHPcnqdjT+rDm+symZLvHKctmwRpAyQvJ1rFBw6XqYxXcPXbUYQjlpiWrFAr7Sx 2ber01kv5o+QeELnhbBfIlzXpwjjMB9sxKiYP4/cQgG2e2lgVcFT6Vjaug89ZNNXDhax CfYvQuoFMhoJLYZ55uuI95m9vosGTX0CH/I4IVRSd06ODrvOW00WkGCy/1B68fT4SP0s 9fEA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wmrEkJ7f; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-40940-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40940-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id y3-20020ae9f403000000b0078317b4ef86si2440338qkl.741.2024.01.26.16.38.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 16:38:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-40940-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wmrEkJ7f; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-40940-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40940-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CEEE01C22A11 for ; Sat, 27 Jan 2024 00:38:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 36725B65F; Sat, 27 Jan 2024 00:37:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wmrEkJ7f" Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF1DB7F0 for ; Sat, 27 Jan 2024 00:37:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706315829; cv=none; b=hXyB6f6Ul6xwMYIrpj489O8ou1pIHq9b8pV8NNa1DPdDDnLNjcl8WzxhdcMu9xhqUzxmo/5JdXFeizxg1l5Tc286H7DVXH7Y23yWITMe0ARv9SXEPO2hGCxJ7xtcUJtE6PsxeBHcRJsTEjSWmRqSf/13ZjmjMlczA8Q55pJgjSE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706315829; c=relaxed/simple; bh=rzK2gsXIFXMN1iIdN0KgaFNnktatZIe6QYPzL8EVCkI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=slLooH1EUlshwcH5ILJm75hPZKbe5r05XozTa4BuEZdl5g6Z0ddlWLyiqZWOJFWhHU4UCsTyQ6AaKkPCwSrqud83o5jw0iMVauG7JauNJtadE+bL30UH8JpjMPBR60a7A9ei7K7/h6SaV48tAV9j7PgvNu97Ijv7lgRr2xZsj+0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wmrEkJ7f; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-40e8fec0968so17130305e9.1 for ; Fri, 26 Jan 2024 16:37:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706315825; x=1706920625; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RTtyOoMvI5/Gh43pPNKlry47E9NXmSJ8tqA/H0tsxRY=; b=wmrEkJ7faNowhsrvvP/1ZLLy0JxwSO4c6O0IGy+JE8xG1vMD6y6lMDt2neYy6qrOOx CNUATPSezNk08n7y7V4xdXzcJsTjw1d75rSlJLjamfzqpU2URhX8bKQkmgKu0X6jnnpv pxDF/+OpAmvhDFsRi6XapsOs3DNgCw8aeBLQbTSoMVYBA6whjrEEDwVcMEYb5inSdb9k gsqr54N1kR00svK4USFn6Ghwx5YzXKTbb18Jr5tWVhtiI3ssbUI1c0Mxqw/q4ek58v2m yhDbcpPdzauY8Rk47V+WogdQl2S4OZhPzF5Y8oXrGzLfroog5X7yZq+tcrb2f/J1yly2 N6dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706315825; x=1706920625; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RTtyOoMvI5/Gh43pPNKlry47E9NXmSJ8tqA/H0tsxRY=; b=DKx4mpJKU8EdFRM88TxPgMN+70SkcbdD+Y2H2vhCL3nfRaLd04VJWdC7ubzo3/P56m vrJenLHdH+hxQTF620rAyL5YoIQiV9N8ji8qFwN8Tkv3daGyOWXJXaQTBlfuoYVlvBcT j56y97lScnpGVmMR8hk27Tgcw4UHJfCNZPmiFBu3T0csX7XbQ297jQ/2y7l9KSuCazmF 6Z3lU9F2O+0cifpD8nWxzi7pmqqDzN7D/QiIqq2Xx9/Piq11mUrs7FetHNR+P5LhIx1W O05COChnel4djNWz2pwZ549ym3q+DsI3AN2eWP9/RsRiZG7HBmG47lGDgqDPcivnx9db Qa5A== X-Gm-Message-State: AOJu0Yz+J5UzrE7RQ1vqgkVw4MJ7zJ9yPLwUnM6gpcodDDksMVApcQc8 Cw+2bMl8iAvRSHSLoLaQ0bJYOGeRifh7ku7Z5lFMxApBpeEl4H5F+uUxT1u6Ht0= X-Received: by 2002:a05:600c:a03:b0:40e:b107:9e16 with SMTP id z3-20020a05600c0a0300b0040eb1079e16mr394989wmp.230.1706315825219; Fri, 26 Jan 2024 16:37:05 -0800 (PST) Received: from puffmais.c.googlers.com.com (229.112.91.34.bc.googleusercontent.com. [34.91.112.229]) by smtp.gmail.com with ESMTPSA id vi1-20020a170907d40100b00a2f48a43c3esm1152235ejc.7.2024.01.26.16.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 16:37:04 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 1/5] clk: samsung: gs101: gpio_peric0_pclk needs to be kept on Date: Sat, 27 Jan 2024 00:35:50 +0000 Message-ID: <20240127003607.501086-2-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240127003607.501086-1-andre.draszik@linaro.org> References: <20240127003607.501086-1-andre.draszik@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789201893894795779 X-GMAIL-MSGID: 1789201893894795779 This pclk clock is required any time we access the pinctrl registers of this block. Since pinctrl-samsung doesn't support a clock at the moment, we just keep the kernel from disabling it at boot, until we have an update for pinctrl-samsung to handle this required clock, at which point we'll be able to drop the flag again. Fixes: 893f133a040b ("clk: samsung: gs101: add support for cmu_peric0") Signed-off-by: André Draszik Reviewed-by: Sam Protsenko Reviewed-by: Tudor Ambarus Reviewed-by: Peter Griffin --- drivers/clk/samsung/clk-gs101.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c index 4a0520e825b6..61bb0dcf84ee 100644 --- a/drivers/clk/samsung/clk-gs101.c +++ b/drivers/clk/samsung/clk-gs101.c @@ -2848,7 +2848,7 @@ static const struct samsung_gate_clock peric0_gate_clks[] __initconst = { GATE(CLK_GOUT_PERIC0_GPIO_PERIC0_PCLK, "gout_peric0_gpio_peric0_pclk", "mout_peric0_bus_user", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_GPIO_PERIC0_IPCLKPORT_PCLK, - 21, 0, 0), + 21, CLK_IGNORE_UNUSED, 0), /* Disabling this clock makes the system hang. Mark the clock as critical. */ GATE(CLK_GOUT_PERIC0_LHM_AXI_P_PERIC0_I_CLK, "gout_peric0_lhm_axi_p_peric0_i_clk", "mout_peric0_bus_user", From patchwork Sat Jan 27 00:35:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 192927 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2395:b0:106:343:edcb with SMTP id gw21csp236896dyb; Fri, 26 Jan 2024 16:38:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGbcJ2k7PDF4tLvskbpFZVWcKPEpxEvTuF7/38Wn0oJcfMC9GPOyijqOKyuMYr4Sjdy5sca X-Received: by 2002:a19:5206:0:b0:510:407:60e6 with SMTP id m6-20020a195206000000b00510040760e6mr316345lfb.66.1706315925174; Fri, 26 Jan 2024 16:38:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706315925; cv=pass; d=google.com; s=arc-20160816; b=HN8LUoYuYME3iyh8XnESo1HoJC5F7t+10ZY3FuP8wGiIeHAPf58cNSX0jpPrFkEIfI cVmgsrw/EyI0AJhVKynkXPh61QgTNvBnUjZyTADB1KBoOcBE7RZR5S+HZG+lFV2uT8o2 Uu7f3dB18Gr5Au9CaZEsLQjkqS95iuM5pq2yrXG32HvK1c84FQz24QtSEcmt8Nxt0/kC ZWCG+5XrXHaJqiZ9bUY+7QgnTB007ET0eDG5VYFw2d15ad6RFLfD4lBVqvhaAt7dxf6T H7y/BCU+BtMWSJR1Sfpla/i/Q9gzObyoc2y/mQ9FU0QBdLHvjGMYv6FgEJB8CoAcNK+p vakw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Sm+b1B1zFt2eVB9+ThV9mqMVXPNNXKvJvmEo2SUwft8=; fh=WrhIizNXy+YZmlhXQ3CjStW2Q+f/L9mPBsAa/xOhbRk=; b=c08RR32baLVlDgHZMh9IgDBwcAEJexZMCBDRvXF7IoHprIF4chrLGWAK1CJpLEY+xL 1yDeM1sXsNR1W7ip8MTOIYw7ayAkF7fgdZa5tMozPmRegaZek7i9lKXElGfkpr8jjoNj RLOPtIKncRZJIXKfkf4klKsrZgmBKbnKRS6FZacp1eTScCBOd7j9W/O44+eX4HvHvGLH I3DYplfph+S/cTzQ7/25EGQI1Jax/EEGIgJ6+gm35EKKDyl9zyvGvZ+uHPxyMs4nR9gS BsTj6IcHOSxtmSdBa9ebnc2bI8xxt5/tMpjT+NoUe0n5GkF719l07e1R5NKM8/IqcGje QgSw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=w0XYvZ0L; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-40943-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40943-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id gr7-20020a170906e2c700b00a3117a2142esi1112483ejb.91.2024.01.26.16.38.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 16:38:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-40943-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=w0XYvZ0L; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-40943-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40943-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C37271F262B9 for ; Sat, 27 Jan 2024 00:38:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BF80811715; Sat, 27 Jan 2024 00:37:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="w0XYvZ0L" Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50918A5C for ; Sat, 27 Jan 2024 00:37:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706315830; cv=none; b=uXVb2Yb2pZjAa3YXMxlD3FX0TbDV03uuljP+UccZ9pc3ki7/QNObx7X93u431IlY8W1Z655swqnTcgNqtN/yXqgGHMSU/W65zHDEOCQS/jdXsOM0vd/lAR/FsI01+VtjzU4A1FFZ3q/d3IV+zOuoEM28X//uNs+k/g7s7s4EJUA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706315830; c=relaxed/simple; bh=e67JZ6JR8CeyU6VdIHYyK7Ki6SpejtvxhPnH0TB4kOc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aJsipo5oqHGoAutB3+DHivX5vqrflOu402yi0yQdk+WSV36SApHt8snfcv/nU4A1K8VvK6IYs/wd1pEyHz4D05jIBMFcGqpmrm0NC2Q72AxB7DqgByPNeEkpsotnkWkKznZAIaVDf9Gqj95zIKr+tAXaDSwxRaktwO0gp71Ne2E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=w0XYvZ0L; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-40ee8cea674so10256825e9.1 for ; Fri, 26 Jan 2024 16:37:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706315825; x=1706920625; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Sm+b1B1zFt2eVB9+ThV9mqMVXPNNXKvJvmEo2SUwft8=; b=w0XYvZ0LYRfwScdXDUjTnkBjz94KPFW+5aKpFOffAzqSZeBqTHBY0qnuPT1RB8R3+z HT2O8weHD4scF0NhXsCPLiFUp+YnBFAvZDHuQcFA8xmoHSOy0JCsjn8pYGtT7WUmVDO6 33pj/EDFs6LwfcsrRzXGx4JRJ4SlrMDIAf6b5KAxf2e32LImDo8iNrqkHJxbx0+sL2m6 bJdj1Apqlyofvnt9z33tqZKiDWvOy5PghHcjFEDfJZkhermdGzuz+E7BZnins2ihHzpA L+VDSScT5ycghJpY6weapl6AJhLHrOSWb6NK3sZMnt9dW4cXueqGligUgfLL7DRDqrz9 c79g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706315825; x=1706920625; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Sm+b1B1zFt2eVB9+ThV9mqMVXPNNXKvJvmEo2SUwft8=; b=ExXh+eVhrDgOPEf/2yg7Pyenb+mphzxuT6iQBHWelBV2k8w4Jo0IICSX/2ExA6qgjX AYo8FBUIRDxnF5FgjKQeTnZ4/54tyVFiRIVDWjutfwYzsReTUXomChgIXWQFJIebd8Z3 l610CAj0wbBPf6sYEQOre11wj8uFJLdEbGi4TqqZAaNp16+yNQC+zR9TNKMqQa6glm4O 8eqCwJT2Mh6eKyDCeJWh5g3/S0Uz6CavCJtmHHEQRLzHnZevpnMGUSZAv/F3dyt5Vzt2 n7fUfK27IgydrrVNYGQUK5B5LImaBCLB2p1Lg5Es/wrVFbcN2pjovC0PGcPvCD1qcaC+ Zusg== X-Gm-Message-State: AOJu0YwTeBV51Yc2r1SlKFcQ8FhkBUUdcJE0s39Wiyk6xvK9YLOxTiot mxhebvZdFtVXo+DfftLBpjTqHXbHR5K4p3rg4wq0tX6xk5tKQdxxfOtVo9PbbUY= X-Received: by 2002:a05:600c:5123:b0:40d:484e:935 with SMTP id o35-20020a05600c512300b0040d484e0935mr455010wms.12.1706315825706; Fri, 26 Jan 2024 16:37:05 -0800 (PST) Received: from puffmais.c.googlers.com.com (229.112.91.34.bc.googleusercontent.com. [34.91.112.229]) by smtp.gmail.com with ESMTPSA id vi1-20020a170907d40100b00a2f48a43c3esm1152235ejc.7.2024.01.26.16.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 16:37:05 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 2/5] arm64: dts: exynos: gs101: fix usi8 default mode Date: Sat, 27 Jan 2024 00:35:51 +0000 Message-ID: <20240127003607.501086-3-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240127003607.501086-1-andre.draszik@linaro.org> References: <20240127003607.501086-1-andre.draszik@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789201927638181946 X-GMAIL-MSGID: 1789201927638181946 While commit 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with I2C configuration") states that the USI8 CONFIG is 0 at reset, the boot loader has configured it by the time Linux runs and it has a different value at this stage. Since we want board DTS files to explicitly select the mode, we should set it to none here so as to ensure things don't work by accident and to make it clear that board DTS actually need to set the mode based on the configuration. Fixes: 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with I2C configuration") Signed-off-by: André Draszik Reviewed-by: Sam Protsenko Reviewed-by: Tudor Ambarus Reviewed-by: Peter Griffin --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index aaac04df5e65..bc251e565be6 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -384,6 +384,7 @@ usi8: usi@109700c0 { <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>; clock-names = "pclk", "ipclk"; samsung,sysreg = <&sysreg_peric0 0x101c>; + samsung,mode = ; status = "disabled"; hsi2c_8: i2c@10970000 { From patchwork Sat Jan 27 00:35:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 192926 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2395:b0:106:343:edcb with SMTP id gw21csp236803dyb; Fri, 26 Jan 2024 16:38:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IG3xxzqrAyy8pFAp2iq27Y61dLUUP4XlC9slm+9fzJCd065wK4t3l7mXdegXVy47ccEg13F X-Received: by 2002:a17:906:4719:b0:a31:117b:8b54 with SMTP id y25-20020a170906471900b00a31117b8b54mr597878ejq.15.1706315912353; Fri, 26 Jan 2024 16:38:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706315912; cv=pass; d=google.com; s=arc-20160816; b=tSDazTLlkcJOMzwUPTiC5Z6xjzVw+rKW1ix6IoqcT5QnOwPCJkXdWKPmgP8XcfNXUo uThwLSK2ZPnjupZVnmPdBDi3pEe+SXx7HHUrqCU8FHSMF/12Khvn/PmmQHQ5Cz5EyK44 RaOUVFCUUao4UYNWPjntgZZT1cRW7pdeAhycqynHT+645qKKM7zQX28z/8ClEtWB8ce0 8YvwhXqjpQ4CDDkLXZqTegz/xInh56WjIwUZLf7LP5f3dXYd65yZJAIbDASqY03Q1+A2 /9DKIVCpRy4zDVIh1GW44y4laLz1qh9thd8zfIgBqczpSvPoN0KqNG4iOlq5sG/jGAIp 8phQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=FJ73thBf2vHveKg87OgpLBqSvGw1l2TtG/ztHfLjlvM=; fh=WrhIizNXy+YZmlhXQ3CjStW2Q+f/L9mPBsAa/xOhbRk=; b=v7UIIMLnlnYrv1ipxKr/NM+JTHHA28IZmM48AY+FxAKRnaitke/3E+buee1zZcJIKA qcIb9rTxWafBa42YskCZcL8L1Sp12Pb8vZ2fUWiUJWWrzoFj7AxwcG7BjBC92A18t++F mT8F+i+IWFQfqDUf1iS1t8Pu7J0vKpCpw3OCS7ACsNfV3NAERnSCQ2PhvT3JoZ/MM98e SCYQDeB3hGuQOQC+WZhmelD3sc6aSvfipaue4modtU9B/EMAFDFlxGq7W7caKQidSE2H QBpt60Hq++j2djpph9p86ypzudlRFxekSD1c2V29FJu7yC66TjdUO+frJ7HaNNpP4oJQ iIdg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lefWfPh9; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-40941-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40941-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id q13-20020a170906b28d00b00a34a1cc2a27si1070807ejz.360.2024.01.26.16.38.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 16:38:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-40941-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lefWfPh9; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-40941-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40941-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id EF3C31F2629C for ; Sat, 27 Jan 2024 00:38:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 18FBFC127; Sat, 27 Jan 2024 00:37:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lefWfPh9" Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE00CEB8 for ; Sat, 27 Jan 2024 00:37:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706315830; cv=none; b=jd6l0EE+rEP/IihqzDh5G0V5aS8jYWRpPhGqixRsuOFVGfSkt37gxHF62qNP3QoUQHqbEbNro2cPqpit//DvSPEoJIIFbePsntKS6Dnys2Xu+cQwurou2hk+W0E30AGShgR0OPtYL9kXDELpV7MJpHGlA4DD+vd43xBbXZ8t1/M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706315830; c=relaxed/simple; bh=/GiPFN5+QIgnjdQBA8vewMsdqYN795L0TQdClULeVuM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Iu+aqsusMxl8k0xF3IHhrHPxeycBTpimT7x2qNL3fr8Uu0RIug1xVpWIAiqXqYmx+RtNXRh8iCZN7u55VyAtod9PkVh7Bx/Nu1jxrV2DB8e4EA9PjIvVvjNidMxq/PttqZbjfxyOHuOves4dvl76iYVQmF3E76J+5JWwrx/GFR4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lefWfPh9; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a2f22bfb4e6so177121266b.0 for ; Fri, 26 Jan 2024 16:37:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706315826; x=1706920626; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FJ73thBf2vHveKg87OgpLBqSvGw1l2TtG/ztHfLjlvM=; b=lefWfPh9GJ/MjcuUN9BLLLcXibRBb96oAnzt1TY9nJ1kZ5oH/4K2PR12QnRGcCAdYb W7PvQrENEd0ZgVeDQS1lAbfrPK3EPpLorTp/0uuqjTVj6fJh+aq1OYykrXXoUVDKz0Ye YX3JsMziNduUB9xj5IirWfX4Ek2iTb32e2rkTnxnmOu/60HwuQkvMFa6wCQ0JGSDzHhN yd0GJ4078Bv1vmfkywqrd0sFlPeRl7RjDml3LwOk2PeBXz9TOQjDMaw7eX/5hK9TeDr9 WvTohVDWERztZwTFcH9/flZZ9iWXIAVdTA9YPOY4NwaXU9J0uQZDJKhfr8dhlF0ZqFqJ i5vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706315826; x=1706920626; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FJ73thBf2vHveKg87OgpLBqSvGw1l2TtG/ztHfLjlvM=; b=pGCg4gapkSvNA6evcfAOEQN08vgrCU3YvJ0IHXhebQBV57v25AekDmk4QsyS8TRlhS 5YGjWfPTBIJ6SMGTSwczTAcH4aqEHgmePN+XOUDVuARQtwXjOSV288KlziRSNQT4EqdD XjOwg5SFhL5FGG0DqZWEBgtp9AYuSu9uWAHFg5fuaR1lKyNNEfzio0Be2pihcghitD/6 z4BniIGlnb17aMdaxnwYksMpR/+PxBzl0CxZQMWHD8eds95mFTYBhiij1KhIaOUVEQPa Zd8QKHGENfDUvfhSLK1hWHE6wrQByUS9xtvM1+Sp6V6Mph9LzH1tkh2HvS/6P2H1RCgU /FSw== X-Gm-Message-State: AOJu0YzptITKyTA7fxx/v5XdwMRI99I3A7bCFQ0yuson/7xg3+wtCX46 PWP+M8mksytu3SYa2sEHiwwJjQ9Jhv/Yte5PyNexgM0zoBQigoITx83UvlEKrp4= X-Received: by 2002:a17:906:8308:b0:a31:3745:33fb with SMTP id j8-20020a170906830800b00a31374533fbmr530874ejx.51.1706315826128; Fri, 26 Jan 2024 16:37:06 -0800 (PST) Received: from puffmais.c.googlers.com.com (229.112.91.34.bc.googleusercontent.com. [34.91.112.229]) by smtp.gmail.com with ESMTPSA id vi1-20020a170907d40100b00a2f48a43c3esm1152235ejc.7.2024.01.26.16.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 16:37:05 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 3/5] arm64: dts: exynos: gs101: use correct clocks for usi8 Date: Sat, 27 Jan 2024 00:35:52 +0000 Message-ID: <20240127003607.501086-4-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240127003607.501086-1-andre.draszik@linaro.org> References: <20240127003607.501086-1-andre.draszik@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789201914214876304 X-GMAIL-MSGID: 1789201914214876304 Wrong pclk clocks have been used in this usi8 instance here. For USI and I2C, we need the ipclk and pclk, where pclk is the bus clock. Without it, nothing can work. It is unclear what exactly is using USI8_USI_CLK, but it is not required for the IP to be operational at this stage, while pclk is. This also brings the DT in line with the clock names expected by the usi and i2c drivers. Update the DTSI accordingly. Fixes: 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with I2C configuration") Signed-off-by: André Draszik Reviewed-by: Sam Protsenko Reviewed-by: Tudor Ambarus Tested-by: Tudor Ambarus --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index bc251e565be6..e5b665be2d62 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -380,7 +380,7 @@ usi8: usi@109700c0 { ranges; #address-cells = <1>; #size-cells = <1>; - clocks = <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI8_USI_CLK>, + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_7>, <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>; clock-names = "pclk", "ipclk"; samsung,sysreg = <&sysreg_peric0 0x101c>; @@ -397,7 +397,7 @@ hsi2c_8: i2c@10970000 { pinctrl-names = "default"; pinctrl-0 = <&hsi2c8_bus>; clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>, - <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI8_USI_CLK>; + <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_7>; clock-names = "hsi2c", "hsi2c_pclk"; status = "disabled"; }; From patchwork Sat Jan 27 00:35:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 192929 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2395:b0:106:343:edcb with SMTP id gw21csp236965dyb; Fri, 26 Jan 2024 16:38:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IHBrXcmRyZnuEdX5/Ac9Dk65IVvwLUps7TiyEsGTOwj49XKNGTbqDfMCnzrxZ9ZxJmHin47 X-Received: by 2002:a05:6a20:26a3:b0:19c:6a7a:2df0 with SMTP id h35-20020a056a2026a300b0019c6a7a2df0mr518232pze.66.1706315934970; Fri, 26 Jan 2024 16:38:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706315934; cv=pass; d=google.com; s=arc-20160816; b=NZ97mMGxt7E2N3iCYC1i2x7mcfGQdmUC71WLkfKoCDyPDGTe5VjcMltkR1FGkkS5q7 wga+oyLLSiALQvwmiZY0dSflV1w2OUT+c5mWj+mKvV65+PVP3aVt0O20SgaRZ10U1JGS /z+SKzYtYECa248q1gcFlTX4goohKegxbo9YlWikhJpXZDauLWCxBZyy3tsCMb6GEarh UJEnEXope1oxFRmeA/YyC1qecZHyGKvqPTwQvQYYJl8QUDUc1GmgI1gD1PHwL3f9/rPZ ebXp/riaIqdb79euJw1XBfb4dfSrhXal9UnjTeotlhD9HRdWIBPG8ZYTDLSX3LbUckAW 0Iqg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=SHiTLNqXAy/ffui/0jj45ErOQ8cZX/p93S1sxrZ6DNI=; fh=WrhIizNXy+YZmlhXQ3CjStW2Q+f/L9mPBsAa/xOhbRk=; b=DRE+OrsnIu+LFBFVHmonoQCTFnykexwe7MWozlicpymhQLoVnyWZDtdLHwk9hGM7mU sN3G6fY39XEHWLmDO9aZqdFOwiyUV7keGAru16R0uwqfenfPOAGdf09Z154AiPyJUXtC 1dF6CSVFpnc16R/QWs54/mu7j82qeL1CCAEkJodrAIjToSotBbwQqSCLKir9uiVDEgVe IoY5hE0+ODONTUhwtChV7IIzPzaZxCc+3/P2z+KeZjUwcummPIbvgHrC41XbDLtLGdmZ 7fueXgi/eFDJTg+QU0jeUJWwYOkxGKmp1+gniK2W7GPH4k8UoNGFxQru3cqhoAXxHK2J 4pQw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=C+FtbD1r; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-40942-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40942-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id ks19-20020a056a004b9300b006ddc793542asi1918595pfb.199.2024.01.26.16.38.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 16:38:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-40942-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=C+FtbD1r; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-40942-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40942-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id AF9E62802BA for ; Sat, 27 Jan 2024 00:38:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 83BD21119B; Sat, 27 Jan 2024 00:37:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="C+FtbD1r" Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35D6B17C3 for ; Sat, 27 Jan 2024 00:37:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706315830; cv=none; b=E3AX3r3m+DY4IdtLTjdFASB52SjSFXmcj2K+ylZcel2PBjoGOlNFZO3eLkSz/RpcbwKJL7CIxoGA7V96GyQAYtEhHuWzwEe6Wmhni02huDiJFza8VldjVXlb2N/8KF3xcv4vYsWXqA7KUA9b4DBqrRZWilKF9ODOW24Dj3Xn7NQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706315830; c=relaxed/simple; bh=6vWY/fqEbxu5raMhZbkehuR0JCHTq/UAt99T8/e22jU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QXxJlZ5bin+i3sJ1tiPywZsP5MSX8+jTZjixHrC3OsqUo44i3aOog4hiE3vQV3Uqp0OGOp/MRf8NHwZCJkCEmEH+m3yOyHyoVgBFaMvJye4Qkv64PI7AcNuexiqE6s7a8h5g9VHL9pH5TJExDf93l7YA3xIrERQhDECiYy5ZHMI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=C+FtbD1r; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-33922d2cb92so1354174f8f.1 for ; Fri, 26 Jan 2024 16:37:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706315826; x=1706920626; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SHiTLNqXAy/ffui/0jj45ErOQ8cZX/p93S1sxrZ6DNI=; b=C+FtbD1rR0iJ20cdDwkXKfWW0E03Sdrn+9ZMlDolngQvUnXEZVZJwZZZsQ04UriKx7 8rkyXhuUykCeSWSYqZv/NM5VdS8rv7BY566u1Qq/uOV85pZxmQwILCDetvgvAYArt9Ke VCbsHGFURfGlWC4updUNsvsbdHDcb6MKLh5crST/IAFvPqO3wD1olPx9BAzK0Fu7+5K6 ZdNVYlpJzr5loHp2BrHZGlKn/aatqEFVe/IvKiCcu4uz1sZ0WIPrgBWu07Nxk9ALkCrr kY8FQTe793baqhKPPC899S+yUfll/bau/bAkKBinwfqBdZN3fkTIXtOBOZLmZqUr2mCu BHXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706315826; x=1706920626; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SHiTLNqXAy/ffui/0jj45ErOQ8cZX/p93S1sxrZ6DNI=; b=KNW1yU/EiI0E0R0a91kHCUZXIkjedPUP7ULc03QH99WRYFkfut6zJS9kwaNRsK+58+ qS2kVOZkAPN5jVHQ+H8Gs0ubEEIAEXRfNB4uDdkIVqDZbXSyzFyTd5jAvbvzgttBG9V+ qM2mJs4AbddfLT0DjSvnj4Ae0vLX1iTHYdvEI5Ka13iIgaX4zYCn+HVprcMtnC6Z8VrV tT2iagrlRDNynNjDNAzOvFT8th+fiVKNUn7opNVXcMUn/nJ6OY/MUtRYIic+eVvkmHUg qbiRmu1xhOashLR13n9fHYJ1qz/3EuUyBrJB//v2raUu5yGj1UTYOqyEme4o1/7k6k1I Y9Bg== X-Gm-Message-State: AOJu0YyLXb2WqirnZ9pCdTTHIlJ9PHvOW5Whx1F/dK1lJRHvPahy+AdP ngeeYBuBNJEZkWcpDTBSLGSQYMQ3gFaCtkVn8V6fx3QuErKUUkdV3013Mj+GNoE= X-Received: by 2002:a05:6000:1370:b0:337:bb78:8b3e with SMTP id q16-20020a056000137000b00337bb788b3emr210753wrz.197.1706315826560; Fri, 26 Jan 2024 16:37:06 -0800 (PST) Received: from puffmais.c.googlers.com.com (229.112.91.34.bc.googleusercontent.com. [34.91.112.229]) by smtp.gmail.com with ESMTPSA id vi1-20020a170907d40100b00a2f48a43c3esm1152235ejc.7.2024.01.26.16.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 16:37:06 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 4/5] arm64: dts: exynos: gs101: use correct clocks for usi_uart Date: Sat, 27 Jan 2024 00:35:53 +0000 Message-ID: <20240127003607.501086-5-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240127003607.501086-1-andre.draszik@linaro.org> References: <20240127003607.501086-1-andre.draszik@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789201937711038411 X-GMAIL-MSGID: 1789201937711038411 Wrong pclk clocks have been used in this usi8 instance here. For USI and UART, we need the ipclk and pclk, where pclk is the bus clock. Without it, nothing can work. It is unclear what exactly is using USI0_UART_CLK, but it is not required for the IP to be operational at this stage, while pclk is. This also brings the DT in line with the clock names expected by the usi and uart drivers. Update the DTSI accordingly. Fixes: d97b6c902a40 ("arm64: dts: exynos: gs101: update USI UART to use peric0 clocks") Signed-off-by: André Draszik Reviewed-by: Sam Protsenko Reviewed-by: Tudor Ambarus Tested-by: Tudor Ambarus --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index e5b665be2d62..f93e937d2726 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -410,7 +410,7 @@ usi_uart: usi@10a000c0 { ranges; #address-cells = <1>; #size-cells = <1>; - clocks = <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI0_UART_CLK>, + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_PCLK_0>, <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_0>; clock-names = "pclk", "ipclk"; samsung,sysreg = <&sysreg_peric0 0x1020>; @@ -422,7 +422,7 @@ serial_0: serial@10a00000 { reg = <0x10a00000 0xc0>; interrupts = ; - clocks = <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI0_UART_CLK>, + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_PCLK_0>, <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_0>; clock-names = "uart", "clk_uart_baud0"; samsung,uart-fifosize = <256>; From patchwork Sat Jan 27 00:35:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 192928 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2395:b0:106:343:edcb with SMTP id gw21csp236957dyb; Fri, 26 Jan 2024 16:38:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IHpQ8p0DhBPGwUCqA4IaNPuHlQ9BN1r90qviCrH8oop/9wB+oslc7nB6Vq3U37XYvZi7VQ4 X-Received: by 2002:a05:620a:40d1:b0:783:69a7:3da with SMTP id g17-20020a05620a40d100b0078369a703damr733044qko.51.1706315934510; Fri, 26 Jan 2024 16:38:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706315934; cv=pass; d=google.com; s=arc-20160816; b=VabNhXgr8B2t8swCM1bR6VzLUwpZkwCAG1+FnpPGlFJQMdsCXFHRBYgYyGImNzlx2g fKxfslICs5hWE1dTXrlJZ92fhCX73gkPQC3BXdSxHYUM3+ypNbnWQ0WxiNKf/EEk9wqj /QvBzMCajcjymKtHaKeyL09juC5Wqwc+jhXHu2nKHL+4fGgl1tzzonteKWzG/Y0GFfwY JhrJ+knA1R7n2c0EUZiJS7HpWMorP107XUJRsSBSVU086vAYxFL6zQ1tC4oQ1kvYHxOe V3gadOKE/FFoHAwfwOz6VhatDioARDvyMkXfBlXBfTt7k8xku7AElpzgPP2PIs15gS40 eVfA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=3UWKLkucSe2Xo64gIFBssH+CIGBcy5ZlP0k7ni0x+YY=; fh=WrhIizNXy+YZmlhXQ3CjStW2Q+f/L9mPBsAa/xOhbRk=; b=axIjz0EDlowiRHqL5m34qFwgQGJE9s/PhX/Uug2UkOZy4cpFHYIj7A+R5reoUXFiHW +1n9dgfdIjy0LhHJkmtmy810AGgCi8zuXPVxtts7KXD/zml/vzCBiblCVYkDTxT8J7A6 P6JaKPjv2J9gGu0zm/i9O4Npvr9RdJlgR9SMujMvGqEMjYnMt6iCvE0/3TiUKJUrcLQo kJaNtYapN6JsfRe4k3Dy94HL8v6CRz3RQIEEbANdObpXWNjx5GgmCpe+fPwues0II/JL 9wYVa+mN0Yz/jbAg0SMobDuwRGKAjaa4+KOMm9Lyj2+d7GCjJcw3yuyhWE7XneEN0JvL /Y1g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lTrpy+zU; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-40944-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40944-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id m3-20020a05620a290300b007839273251bsi2805076qkp.322.2024.01.26.16.38.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 16:38:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-40944-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lTrpy+zU; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-40944-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40944-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 40EBD1C22636 for ; Sat, 27 Jan 2024 00:38:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5372A125A2; Sat, 27 Jan 2024 00:37:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lTrpy+zU" Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E433220FB for ; Sat, 27 Jan 2024 00:37:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706315832; cv=none; b=bELHa94VpwO7B21rRM81ZqmQ1PTFdbRWI1njPcvKH0lSDfdOTfx99WK0xJldYWl6ny6wLvZ8BuUBSu7dnpp3+AOtp3bcYn/PmXqyLiIOi6j4+nQnWxbjb6TByPAncZQk9PyOYAX7GlZvVQ3+KC90JJNzmVCBqDZYiDOg7Kk/xKQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706315832; c=relaxed/simple; bh=26vfIBZ6/FeUBNB7UQejl5tGj/Q2g9dqknKuLgD78Lc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NZg2sqVm4MSIAanbID88Mq1WQX7vxd/2In7PIFylF+1T490k1Keh8QXG5f7oNX0ottjvDKxtnqspx5V3Rv3xBWRZQEC0mDiuq4/pmt4HcsSKjOAz5AwGxmpacFD40f5p03qm4vBkktLVSKCk7IRdWIzjFLpaqSbD0F0krqTT2JY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lTrpy+zU; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a2f79e79f0cso81814166b.2 for ; Fri, 26 Jan 2024 16:37:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706315827; x=1706920627; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3UWKLkucSe2Xo64gIFBssH+CIGBcy5ZlP0k7ni0x+YY=; b=lTrpy+zUzBcVmE1uFNFdJ0FqZsBvb2YOwicCRyMyqn7sRxkuTE9NFOWAttOO8sWjcm 8B/w1rFU6rTpPbcfgVKqdMi/jT2BsGzoxJVXrqm6q6xu8SrIknM/CSVSr5Cr8wO7S9ZP laQfLTANWr2sTcIJG1pXZHJOa0d/eYDcTxM5gj7SfYORcevO7jar0VA3tcEipfev5nqG ezJEU0guTgrMycCHo91o5SmKIC3jhMJdhaKjcvD7YwvzwafP0LgjC82BeGSATL+m780I AynL3yUIjBsiTdAMcZbmGlhd8Df+34BOnzTtOmeMlGD4Ku2ILzBPXzmtFw2793B5qrOn Gxqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706315827; x=1706920627; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3UWKLkucSe2Xo64gIFBssH+CIGBcy5ZlP0k7ni0x+YY=; b=kkrpF0MMlZDM7dHqDGD/DlIltY1uTPXCrRiuSDlaAekQvuPuvPIiUKhjs21WAFTw1/ qeFu/DQu1AO0elNIsLrR62RonXAB+p2ILpeYoOfMTW9vmRmYYiMd157bsLEeQXfx7S3Q QZ05aexzHl7tvD4eY+a4YcKZJD0MTk28oz4EhnLZrWGsK3RvGW8XdcvER+Svf549qQM6 H47QnCsF6QHbeyPtLy7xPSGm7s0eynTODW0dx0gCy8nU+8AMbjSEwRyzI9ieWgoQ89lW o5n+L+p1DdbsFBhJXsBvOfE7YMsaT98RY+6ZzEsm95zPWAoWPRkC83ZpwFJcw6+hKP2d p63Q== X-Gm-Message-State: AOJu0YwyOVIBLAIXhSFBmd4CHq0yhQIMlp6mrtIpo8jE1Yj2zAbgBv5W dvdRVi5kHcmrU0Hoi9K+gx2bUnZzbkW4hSBttWotPdzbz+BHNHIFKdVysqSX3Cw= X-Received: by 2002:a17:907:1006:b0:a35:2841:2ab7 with SMTP id ox6-20020a170907100600b00a3528412ab7mr227213ejb.39.1706315827009; Fri, 26 Jan 2024 16:37:07 -0800 (PST) Received: from puffmais.c.googlers.com.com (229.112.91.34.bc.googleusercontent.com. [34.91.112.229]) by smtp.gmail.com with ESMTPSA id vi1-20020a170907d40100b00a2f48a43c3esm1152235ejc.7.2024.01.26.16.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 16:37:06 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 5/5] clk: samsung: gs101: don't mark non-essential clocks as critical Date: Sat, 27 Jan 2024 00:35:54 +0000 Message-ID: <20240127003607.501086-6-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240127003607.501086-1-andre.draszik@linaro.org> References: <20240127003607.501086-1-andre.draszik@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789201937195351272 X-GMAIL-MSGID: 1789201937195351272 The peric0_top1_ipclk_0 and peric0_top1_pclk_0 are the clocks going to peric0/uart_usi, with pclk being the bus clock. Without pclk running, any bus access will hang. Unfortunately, in commit d97b6c902a40 ("arm64: dts: exynos: gs101: update USI UART to use peric0 clocks") the gs101 DT ended up specifying an incorrect pclkk in the respective node and instead the two clocks here were marked as critical. We have fixed the gs101 DT and can therefore drop this incorrect work-around here, the uart driver will claim these clocks as needed. Note that this commit has the side-effect of causing earlycon to stop to work sometime into the boot for two reasons: * peric0_top1_ipclk_0 requires its parent gout_cmu_peric0_ip to be running, but because earlycon doesn't deal with clocks that parent will be disabled when none of the other drivers that actually deal with clocks correctly require it to be running and the real serial driver (which does deal with clocks) hasn't taken over yet * hand-over between earlycon and serial driver appears to be fragile and clocks get enabled and disabled a few times, which also causes register access to hang while earlycon is still active Nonetheless we shouldn't keep these clocks running unconditionally just for earlycon. Clocks should be disabled where possible. If earlycon is required in the future, e.g. for debug, this commit can simply be reverted (locally!). Fixes: 893f133a040b ("clk: samsung: gs101: add support for cmu_peric0") Signed-off-by: André Draszik Reviewed-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/clk/samsung/clk-gs101.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c index 61bb0dcf84ee..5c338ac9231c 100644 --- a/drivers/clk/samsung/clk-gs101.c +++ b/drivers/clk/samsung/clk-gs101.c @@ -2982,20 +2982,18 @@ static const struct samsung_gate_clock peric0_gate_clks[] __initconst = { "gout_peric0_peric0_top0_pclk_9", "mout_peric0_bus_user", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_PERIC0_TOP0_IPCLKPORT_PCLK_9, 21, 0, 0), - /* Disabling this clock makes the system hang. Mark the clock as critical. */ GATE(CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_0, "gout_peric0_peric0_top1_ipclk_0", "dout_peric0_usi0_uart", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_PERIC0_TOP1_IPCLKPORT_IPCLK_0, - 21, CLK_IS_CRITICAL, 0), + 21, 0, 0), GATE(CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_2, "gout_peric0_peric0_top1_ipclk_2", "dout_peric0_usi14_usi", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_PERIC0_TOP1_IPCLKPORT_IPCLK_2, 21, 0, 0), - /* Disabling this clock makes the system hang. Mark the clock as critical. */ GATE(CLK_GOUT_PERIC0_PERIC0_TOP1_PCLK_0, "gout_peric0_peric0_top1_pclk_0", "mout_peric0_bus_user", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_PERIC0_TOP1_IPCLKPORT_PCLK_0, - 21, CLK_IS_CRITICAL, 0), + 21, 0, 0), GATE(CLK_GOUT_PERIC0_PERIC0_TOP1_PCLK_2, "gout_peric0_peric0_top1_pclk_2", "mout_peric0_bus_user", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_PERIC0_TOP1_IPCLKPORT_PCLK_2,