From patchwork Fri Jan 26 17:28:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 192714 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2395:b0:106:343:edcb with SMTP id gw21csp27303dyb; Fri, 26 Jan 2024 09:29:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IEb0tuQ7R4AUQ1pjI5XjEb6Z46cIAbJaEkFUvF97btWQ+HTMMD90/W6i0tK+m9FbmPaq9KG X-Received: by 2002:ad4:5f8c:0:b0:686:34cd:74fa with SMTP id jp12-20020ad45f8c000000b0068634cd74famr252203qvb.29.1706290183621; Fri, 26 Jan 2024 09:29:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706290183; cv=pass; d=google.com; s=arc-20160816; b=e6rJiUzU873UabEY5RDnlXjd49zTvtyDp3dC30wAKtlNagAHtMKfsloN5TTIUe7qmi nzU9yaTO1vdRDC0UlsCZOD/+STPeq12nr6sO3pcppSwZldJxBoZj/ffzttBhzrBknQtv crV1+ej/bnyA4vDkWXxD1zzJ4F+gOnBSxScMuD40Fjg3y/nG6ky5byvpk0y1hQuEHZoK YW5/Qzh4Ua/yuI+BeWkZ6KBckZBXBkFkUe0HV4eBC6Gz+HKKYNttdPIB3Z54mTfZHv8A CPllnEcxsfIUCcPNwtE0+ZSx6gvt+gw2UMEeTKoRYT2ZWXh8UuE5W5jk6ri8LgdEnkm7 28qA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=9sQSkNfelQ0ZrHkqH8A613BOHINXOltGVDpJXPmhio8=; fh=NLxAvL/bDfPg4AGOtxqvQlND8vazkZrNzKLY8+LAbBY=; b=04RbAra+uHW7BCOBQycELYwB5rtmRy7IDjlSRuyLuIvcOZ5K5bvWJOZUq6O42KKMn6 4OTyS638T3CxeGi4GNZ9af4t/Xt05ilXnh+48xOG9qqug4MxJ9ZZDLtrGD7TEc7lk9yx INSZRdNTAhRWZ5ViP45pMpPGRSXqXON0ewRrGzpNik62GbNECyg6pV1Z7mLljk3eZzwc eP9GijjpC/uphb/diLAJSsmid5zQx09IV0ZQE0NAN9WzjBkiAK0rb9aYJFcphzoVfVwn DP2uSz9AFlOZHf6ijD7sqc6TJjsvSLqMkW+WctdSANJQe6UEjsVHcEUKL17261yq919m iAvA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="Vk/2O90M"; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id eq12-20020ad4596c000000b0068063dc1d64si1686624qvb.589.2024.01.26.09.29.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 09:29:43 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="Vk/2O90M"; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 52A923858435 for ; Fri, 26 Jan 2024 17:29:43 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id B112A3858CD1 for ; Fri, 26 Jan 2024 17:28:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B112A3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B112A3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::436 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706290100; cv=none; b=BPoTaFk3/+xgNWk7WbeFjrkQ50DU36ozT0HhB1lyUpgL8mDUiGYTEH2NgdO85tGeCBYlDB13IOwnk/GRDR5WcN3se1kqwZN8aIvXiZ//2lUX8HC6hOHORrooRcaD3Cg0c3MrcUNXik20UGDlpNaNNf3Fs7z2+HtABhzsD8NO4ko= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706290100; c=relaxed/simple; bh=OFtil4gTMiBGo9kFt4WvqFDI6zGP8Q14UvcpFFl26WI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=fqyve0ftteKXCVkRxRw+HqiF/3rn/QmBVxBR+EHjYUNwClUBU1yVAEWXnJQrXEAtJmZt9xOXnh74uWBl9Rya43h7oMFyFUp/WVpnnCLn2wQl083bgcG32caeWF8MKZeN6+izDff7kqfNFG0LogfN1CL5KN81R9Wp/zlS8HBEI14= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-6da9c834646so683471b3a.3 for ; Fri, 26 Jan 2024 09:28:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706290097; x=1706894897; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=9sQSkNfelQ0ZrHkqH8A613BOHINXOltGVDpJXPmhio8=; b=Vk/2O90MxHY/rdMk7p7EZtivU1wi3Op+o6yrzaN3ki4Lwfytysi2KZJYEqmsIl3Zin HYOxc28guBltqFcewH2f2z5h5BHgQNRlKo26OLLrUQvPflxMpemvoYlN8+xFxRRBWIJH KPsi59HH+SxZDkeitIPO9sNs63a5g1Nfxldvv50nbfGRLL0Ym+SMgRF9GOxXBZZHE8j5 vZq27mopVBjz2lnk2GYVKipDuG4/DmTcxT+YdIchg3QmNgPpYbxmy/xmkuFmQCBh2gxB 8zwOsXwUpNNRNiIT5htejs5C4egTSThgUTOG8roxCsPcWL5glCglE0JPld0vb6X1DDDh nl0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706290097; x=1706894897; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9sQSkNfelQ0ZrHkqH8A613BOHINXOltGVDpJXPmhio8=; b=k8G5yI6LyxyQK74ErGrhm4AokM1nEWy6Og5H8Zh1O9YacOT8oI4hNJg8Lku48zsmrQ /GNTnOeZ81CsQWiV7JNYdqMu4aoiAfG4vpyqpkQDnJXPGKo86Y+P+tFor00X1yzbSyKx xEeo16iYvLxabKVUJpJf7uXehp/kDX4usHBKrfhmLeQCsqQmG/CVHhMgZuBvAxXOEYBO 3yeg4FKhRl0igqTESxZPJErPdCvvbWQyTWd43yfjac750O1QJmug4HYDAcf70PEwHoPb GlgfYJUF0vsNSqFhR81789+3T6qyDRSsl8j2fE4Jp8EuQ63hMbenrustt46mfnBga4mB 9nuw== X-Gm-Message-State: AOJu0Yxpydr7rxFapdlmNzF9a1k8dTeSrahroAZxOJL1eF8DERV16WJn ocLhGz1pie/1KxL/ZyaubmRlGt2song8brj9YC2k9e0otZTpqK6TMu9VYSFB X-Received: by 2002:a05:6a00:18a2:b0:6d9:8f4f:5fe0 with SMTP id x34-20020a056a0018a200b006d98f4f5fe0mr163180pfh.12.1706290097194; Fri, 26 Jan 2024 09:28:17 -0800 (PST) Received: from gnu-cfl-3.localdomain ([172.56.169.51]) by smtp.gmail.com with ESMTPSA id h13-20020aa79f4d000000b006d9974a87fcsm1317730pfr.215.2024.01.26.09.28.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 09:28:16 -0800 (PST) Received: from gnu-cfl-3.. (localhost [IPv6:::1]) by gnu-cfl-3.localdomain (Postfix) with ESMTP id 92B2F740298 for ; Fri, 26 Jan 2024 09:28:15 -0800 (PST) From: "H.J. Lu" To: binutils@sourceware.org Subject: [PATCH] ld: Turn on --error-execstack for --warn-execstack --fatal-warnings Date: Fri, 26 Jan 2024 09:28:15 -0800 Message-ID: <20240126172815.3007950-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-3024.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789174935532601249 X-GMAIL-MSGID: 1789174935532601249 Since --fatal-warnings always turns a warning to an error, turn on --error-execstack for --warn-execstack --fatal-warnings and override --no-error-execstack. PR ld/31299 * lexsup.c (parse_args): Override --no-error-execstack and turn on --error-execstack for --warn-execstack --fatal-warnings. * testsuite/ld-elf/elf.exp: Run PR ld/31299 test. * testsuite/ld-elf/pr31299.error: New file. --- ld/lexsup.c | 5 +++++ ld/testsuite/ld-elf/elf.exp | 8 ++++++++ ld/testsuite/ld-elf/pr31299.error | 2 ++ 3 files changed, 15 insertions(+) create mode 100644 ld/testsuite/ld-elf/pr31299.error diff --git a/ld/lexsup.c b/ld/lexsup.c index 099dff8ecde..e81059d53ba 100644 --- a/ld/lexsup.c +++ b/ld/lexsup.c @@ -1947,6 +1947,11 @@ parse_args (unsigned argc, char **argv) && command_line.check_section_addresses < 0) command_line.check_section_addresses = 0; + /* Override --no-error-execstack and turn on --error-execstack for + --warn-execstack --fatal-warnings. */ + if (link_info.warn_execstack && config.fatal_warnings) + link_info.error_execstack = 1; + if (export_list) { struct bfd_elf_version_expr *head = export_list->head.list; diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp index 685b87588e7..511ca569ffd 100644 --- a/ld/testsuite/ld-elf/elf.exp +++ b/ld/testsuite/ld-elf/elf.exp @@ -318,6 +318,14 @@ if { [istarget *-*-*linux*] {pr29072-b.s} \ {{ld pr29072.b.warn}} \ "pr29072-b.exe"] \ + [list "PR ld/31299 (error about absent .note.GNU-stack)" \ + "-e 0 -z stack-size=0x123400 --warn-execstack \ + --fatal-warnings --no-error-execstack" \ + "" \ + "" \ + {pr29072-b.s} \ + {{ld pr31299.error}} \ + "pr31299.exe"] \ ] } else { run_ld_link_tests [list \ diff --git a/ld/testsuite/ld-elf/pr31299.error b/ld/testsuite/ld-elf/pr31299.error new file mode 100644 index 00000000000..d1a9569a374 --- /dev/null +++ b/ld/testsuite/ld-elf/pr31299.error @@ -0,0 +1,2 @@ +.*: error: .*\.o: is triggering the generation of an executable stack because it does not have a \.note\.GNU-stack section +.*: failed to set dynamic section sizes: file format not recognized