From patchwork Fri Jan 26 16:41:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 192684 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:106:343:edcb with SMTP id ju23csp59264dyc; Fri, 26 Jan 2024 08:43:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IH3hnH3uv4TGFUUxRS81NNafezuP6bJlw5+8SkEdrGS8fw2DdgR3POfkmULQrvcjw63tTvt X-Received: by 2002:a05:600c:548b:b0:40e:7d24:cc15 with SMTP id iv11-20020a05600c548b00b0040e7d24cc15mr58564wmb.34.1706287388004; Fri, 26 Jan 2024 08:43:08 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706287387; cv=pass; d=google.com; s=arc-20160816; b=Aa1JjDQGSznWTDpmLElbf2/oIlXOmkKjPNfRCpCHexfaSMIGjEdsV/5j3GG3DclMCg +fgAhKKlr+YB1L+GY+5nY4eBpIgePzS+8KSdjBZxL5XbBJIqVW7AybyRmfkTwQGFVTu1 mLkGm04ZVvTA6lmcD1kXSahwyhwEEyAWkjUUV+z96/JupSKeLn6fY3a4/pLQLQ/M1M15 lVMNFp1UUBP6OcybppfLfL6Nza3irVdy1/L2qncKXBGJNuCTm7+CDOMO4kOB1URs6v45 r+b/lcGPzVItjTz+SVn3M57AcsbnBswmZLYw6vtwH8Esgghw0D46iv7kyEPjtbPotfAw 56Zw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=G1FEGn3O/VBptqGwJi6KCObyTHs9nhdvsW5xpkdLjlc=; fh=JASAEPYKLgS69vVDzsrNlPvFdidWhQf3L3WUeeF5VWc=; b=FQbK5+o0pnmq0VTiSUugRlLCfGLGxLHqtYmlo1gi5eCBKOXaJx0mcqnxHEwS/Bk+Mg rb3dDXH4KrrQwelmFU7VpDZeI58bG5+Xe6U3KfvvBEHXAwM2eStvIu9BbQxJWbxvc+he 84icjVPLqNDZY9YtpIV2OAiidp11ClL2KQdOrx1aYiJSA2mPAAwmKqPFIEfZusZS7XgO th60pwR0J7ZKvFxUBSB8Ui4z7l2Hu3y0hXnUMWx6epzownMa1dxGOQ0VghIqlyQDXsFW qKdWmvlMbLLaXoilzmMTqUbtQitMX6jsd2ufgBLSvSP2buVQF8nIwCmPe41IIjqKH4rx epYQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=OZsNkRYG; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-40362-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40362-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id y20-20020a17090629d400b00a3104d032dfsi778772eje.394.2024.01.26.08.43.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 08:43:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-40362-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=OZsNkRYG; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-40362-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40362-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C16951F21996 for ; Fri, 26 Jan 2024 16:43:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 659F61F61D; Fri, 26 Jan 2024 16:41:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="OZsNkRYG" Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACD781DFD8; Fri, 26 Jan 2024 16:41:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706287313; cv=none; b=SGGAaOwPQ6cDoNntrK2iqRRtPpmeZxoyZ/+lNUVixoc3ISHl1L02v4AD8nvhw0q9UAZbAlDfINsPsXIETM6qjCgOvVYMSL8XxIxSpqFhl3XCADZVOzNysagTEcT4dxDFSChQu6fu14/uLHRd9tnBTQInixjPoqvj8j996BgYCCw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706287313; c=relaxed/simple; bh=TTMMcaKwbtVMWjq2FvU5baWtMNXCodc6+U2gPgL4xKE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=t8jGt4oXlSWU6uKTFxaUbYW+qV1o8bKmKddGfX+RKSfj9LaBEgADzrCqP0H/g2p2yjSpeKsJmmY62WvvOsWkduxEvUFKGygfcdDw82kH5/62wDHUVvORQJtM6vWVX9zzNGjpg8FY1vecbmhaN5pW4kBYbJH3Hk1AIT3mjjZkTzI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=OZsNkRYG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40QGMoia019863; Fri, 26 Jan 2024 16:41:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:date:subject:mime-version:content-type :content-transfer-encoding:message-id:references:in-reply-to:to :cc; s=qcppdkim1; bh=G1FEGn3O/VBptqGwJi6KCObyTHs9nhdvsW5xpkdLjlc =; b=OZsNkRYGex6DscoehRbZbhkJN+pEXAlQ5+61lS3+WNgNKDt1m+xTSGGaPNx dKKRlrGzQV8BCQPtdRqE0d+KQa6+bfoT81WGis+8Wbhf0+s7ALTyx7aJt64luEfX AGKDYkSJWB+rjBZ4LGaTad1zYzFtujFNDDGN1vXm9r9NRKTgwgdhTXlzBeVKCdXn CYzIXSjKIlLawkxy9HIFlWVBwhG9jnKxOMDrzdnknG6lJtgi64SpmGVsocSfXGXX hjNEsa/I5uBKMb/2EVarK7mtGOYsPRCIA0hUAi3Xe4ceToZp9reQIoVdvLmi4xTQ FiXc0EBSwKP63Ec8DhIR3CbI/Gw== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vv4casmf3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jan 2024 16:41:42 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40QGff8U027458 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jan 2024 16:41:41 GMT Received: from [169.254.0.1] (10.49.16.6) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 26 Jan 2024 08:41:40 -0800 From: Bjorn Andersson Date: Fri, 26 Jan 2024 08:41:38 -0800 Subject: [PATCH v2 1/2] dt-bindings: HID: i2c-hid: Document reset-related properties Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <20240126-x13s-touchscreen-v2-1-5374ccc9e10d@quicinc.com> References: <20240126-x13s-touchscreen-v2-0-5374ccc9e10d@quicinc.com> In-Reply-To: <20240126-x13s-touchscreen-v2-0-5374ccc9e10d@quicinc.com> To: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benjamin Tissoires , Jiri Kosina , Bjorn Andersson , Konrad Dybcio , Johan Hovold CC: , , , , Konrad Dybcio , Krzysztof Kozlowski , Bjorn Andersson X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1706287300; l=1255; i=quic_bjorande@quicinc.com; s=20230915; h=from:subject:message-id; bh=TTMMcaKwbtVMWjq2FvU5baWtMNXCodc6+U2gPgL4xKE=; b=XjVsszoTJAZdc5gBdXDriFtFKdcPpJvmABvBQVLmB/Xh5B5tn5Du1mOmRJSqe2qvDHSClnKnH 67Y136a56eLCWyPZJNZvuFAJpXpA01hGG5H/9FDy8PrpRtn3bQZ2gds X-Developer-Key: i=quic_bjorande@quicinc.com; a=ed25519; pk=VkhObtljigy9k0ZUIE1Mvr0Y+E1dgBEH9WoLQnUtbIM= X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 5k1kVPu0KJSDlyv4oHEIQzWfVZWZKgxI X-Proofpoint-GUID: 5k1kVPu0KJSDlyv4oHEIQzWfVZWZKgxI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-25_14,2024-01-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 bulkscore=0 impostorscore=0 priorityscore=1501 spamscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401190000 definitions=main-2401260123 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789172004228428538 X-GMAIL-MSGID: 1789172004228428538 Some I2C HID devices has a reset pin and requires that some specified time elapses after this reset pin is deasserted, before communication with the device is attempted. The Linux implementation is looking for these in the "reset-gpios" and "post-reset-deassert-delay-ms" properties already, so use these property names. Signed-off-by: Bjorn Andersson Reviewed-by: Johan Hovold --- Documentation/devicetree/bindings/input/hid-over-i2c.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/input/hid-over-i2c.yaml b/Documentation/devicetree/bindings/input/hid-over-i2c.yaml index 138caad96a29..f07ff4cb3d26 100644 --- a/Documentation/devicetree/bindings/input/hid-over-i2c.yaml +++ b/Documentation/devicetree/bindings/input/hid-over-i2c.yaml @@ -50,6 +50,12 @@ properties: description: Time required by the device after enabling its regulators or powering it on, before it is ready for communication. + post-reset-deassert-delay-ms: + description: Time required by the device after reset has been deasserted, + before it is ready for communication. + + reset-gpios: true + touchscreen-inverted-x: true touchscreen-inverted-y: true From patchwork Fri Jan 26 16:41:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 192685 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:106:343:edcb with SMTP id ju23csp59551dyc; Fri, 26 Jan 2024 08:43:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IGEfhEJIQSqvcvO4Y0fkJjapUyhcCc5Y7m/MbvNw8L1CopYRWaBGbo5K7trfevE67aHmuRw X-Received: by 2002:a05:6a20:2594:b0:19a:39da:184f with SMTP id k20-20020a056a20259400b0019a39da184fmr2302753pzd.38.1706287418986; Fri, 26 Jan 2024 08:43:38 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706287418; cv=pass; d=google.com; s=arc-20160816; b=ntCV9G9X7Zx1QMMssDMCgTwJH4CbUyK42WfblxVBjgFJFe0OOXaoF1AZU0ZyoVdobb IgCl6Km8ZdSOUkr4IKHD0kgH6z8V+unYjTHbOvkjX8FmKNfWxV8QpVcw5VKdjaJN4OZ8 cGbBFPTS09EbXQHkSQovpllbxXZKX526/0ME59fOsgyFhoVtN7UKW/hpYEpg4HRDq3kH NdBnPXtSu2XVvw9CiHbnMWrWlfaIq3M8aweXm2UYUf4DdoBXZv/UsPdHsIn5b35SKG62 7f/G/UCaPLdBDR5ogSHIlHBMfc9WDZijoicOGkKWxN+mjxBNT1E4D+82u2booiemmLrQ 43xQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=1eXKvAVVPRF6khDnSxpGB2gqMCXAzT0bIxUd6e655Es=; fh=KpHjVh+WU99se18eslt2Jkidrvbr7u+zBKjWp8N5EqQ=; b=dhEMYkLd7DUQAiOcVrvijgWHmbphmDoZvNZzyS8Tk5HP7Ok8V5ehj5iMPVaFj6iv44 oDblcVd5UWKVE6lkTgtVeUFyLZcy4KYAg3YrlbVLV7LWeSF0FP9PRwo68pG+QLyIyKZO MTxAu2pAaCj4N9lCYQ6F/RgjSXkikkwT1Mk/4mz/HP9S3ffLi0+7rASI4hhtjdgfbPO6 gHR47s+1BxHm1goSXJAFnF8Hh5ZF5Qu6zot5+9wqB2BAsbPD9CNznV17qssL7MP1cdsO 0HzLu2ziALNkE4fLeM+tIkKFVS0mV93kLoMqB7geHBiWHqo/cy1Mz8OKmEW8h6i3uMiz Tqrw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=SRKz1RiW; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-40363-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40363-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id h37-20020a631225000000b005cdfb651211si1372939pgl.441.2024.01.26.08.43.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 08:43:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-40363-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=SRKz1RiW; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-40363-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40363-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id F1BBF28465E for ; Fri, 26 Jan 2024 16:43:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 14354200BE; Fri, 26 Jan 2024 16:41:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="SRKz1RiW" Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BCD21DFEC; Fri, 26 Jan 2024 16:41:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706287314; cv=none; b=qj2WHp7zy15Woe/6KVaKloJq9ktF9HjKMfUBg7NR+GfUCIO60kpf3jNCL32b8Tp5bHgmOhX23RkXeRwuUB5yHbYYgNDv+NPKgzHK1kPXixbKQp/HnmqWswptOhrKRwMUfpRA5wwBy8FXLRVQhzEvb7H+jX8xzsRNahWgKykRdPI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706287314; c=relaxed/simple; bh=9wrWS5+nAeBPi2a8R9d2fHJwKwhx8d4m0xQeKrBuHb8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=lP4TjOfPUZgeLCa7Zn82Vxw4NB09ayPkkBO2Hp3zC9/UOddTcvXw8ya/ejiDsfYI/XMf+Am+OCF+7IxJzn3JeFL7vnFwpsJsq8hqiAeEvowgsD4SSsK0vP2G/gswmE32TWqc6S6e6Ktp/jPnelDbY8bt0liZJcqgVRLdJQ3ujAU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=SRKz1RiW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40QE0DQh002236; Fri, 26 Jan 2024 16:41:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:date:subject:mime-version:content-type :content-transfer-encoding:message-id:references:in-reply-to:to :cc; s=qcppdkim1; bh=1eXKvAVVPRF6khDnSxpGB2gqMCXAzT0bIxUd6e655Es =; b=SRKz1RiW5UinIcerHxvTCMUXpEOhh1+dsrW+qtSzPDxWu11xWN2vRQR0ewP xXEEYBoBT1UCELwP52E89OwRbfoqe7IotTtxHkVpn4HGbW3F95GaWGAkmDoX7RST C6yspRKySP6jA6IV2tGtqlq7PSRfC0wYH0B2ewZLmoNfiuRgxr5qzSC5UzSvamX3 AMGyAuysY0kBjrg2X26A10aBW+5o9Di7XXMtClbx3bhsnTRYQCQ2VaDlnfdz2+8c ZgvUgFqfrZtF52ouIJDTQGAOm0qaiJqCGwl2Cnf9IbxywGgOklmj453OAwRIWHWm 8GM3R0vLQXy2lwBh03LHcHIUe/Q== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vv4f9hkyx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jan 2024 16:41:42 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40QGffPq027479 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jan 2024 16:41:41 GMT Received: from [169.254.0.1] (10.49.16.6) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 26 Jan 2024 08:41:41 -0800 From: Bjorn Andersson Date: Fri, 26 Jan 2024 08:41:39 -0800 Subject: [PATCH v2 2/2] arm64: dts: qcom: sc8280xp-x13s: Fix/enable touchscreen Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <20240126-x13s-touchscreen-v2-2-5374ccc9e10d@quicinc.com> References: <20240126-x13s-touchscreen-v2-0-5374ccc9e10d@quicinc.com> In-Reply-To: <20240126-x13s-touchscreen-v2-0-5374ccc9e10d@quicinc.com> To: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benjamin Tissoires , Jiri Kosina , Bjorn Andersson , Konrad Dybcio , Johan Hovold CC: , , , , Konrad Dybcio , Krzysztof Kozlowski , Bjorn Andersson , Daniel Thompson X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1706287300; l=1549; i=quic_bjorande@quicinc.com; s=20230915; h=from:subject:message-id; bh=9wrWS5+nAeBPi2a8R9d2fHJwKwhx8d4m0xQeKrBuHb8=; b=qc1obTJvuXDDoFCNXg7IQoTkuhbVjgSRksqJodnu8XcyVR98XwCHJtxYG7OTXCIsncz+g9u8m tkMXrCQUVbqCHhJo/ySId8SGzGacTVDLdU7pcNgrTFi330fFI7IEXEq X-Developer-Key: i=quic_bjorande@quicinc.com; a=ed25519; pk=VkhObtljigy9k0ZUIE1Mvr0Y+E1dgBEH9WoLQnUtbIM= X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 3OldgpkjdqRsh2iAIu9AYcZerGAf2PpJ X-Proofpoint-GUID: 3OldgpkjdqRsh2iAIu9AYcZerGAf2PpJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-25_14,2024-01-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 priorityscore=1501 impostorscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401190000 definitions=main-2401260123 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789172036740899739 X-GMAIL-MSGID: 1789172036740899739 The failing read-test in __i2c_hid_core_probe() determines that there's nothing connected at the documented address of the touchscreen. Introduce the 5ms after-power and 200ms after-reset delays found in the ACPI tables. Also wire up the reset-gpio, for good measure. Fixes: 32c231385ed4 ("arm64: dts: qcom: sc8280xp: add Lenovo Thinkpad X13s devicetree") Tested-by: Daniel Thompson Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts index def3976bd5bb..33731b95ad51 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts @@ -620,7 +620,6 @@ &i2c4 { status = "okay"; - /* FIXME: verify */ touchscreen@10 { compatible = "hid-over-i2c"; reg = <0x10>; @@ -630,6 +629,11 @@ touchscreen@10 { vdd-supply = <&vreg_misc_3p3>; vddl-supply = <&vreg_s10b>; + reset-gpios = <&tlmm 99 GPIO_ACTIVE_LOW>; + + post-power-on-delay-ms = <5>; + post-reset-deassert-delay-ms = <200>; + pinctrl-names = "default"; pinctrl-0 = <&ts0_default>; }; @@ -1450,7 +1454,6 @@ int-n-pins { reset-n-pins { pins = "gpio99"; function = "gpio"; - output-high; drive-strength = <16>; }; };