From patchwork Fri Jan 26 03:55:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 192369 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:e09d:b0:103:945f:af90 with SMTP id gm29csp430167dyb; Thu, 25 Jan 2024 19:57:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IGE+2NDmAEB0+X1xDX0X4u0d/KD/DqakQNyAQ79f4HCb2RTpVm1phDOuE/s9N3rquJeacyN X-Received: by 2002:a17:907:76fc:b0:a30:9eba:4da7 with SMTP id kg28-20020a17090776fc00b00a309eba4da7mr283764ejc.23.1706241428478; Thu, 25 Jan 2024 19:57:08 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706241428; cv=pass; d=google.com; s=arc-20160816; b=DnKuuYRCq+ZLNTMVFGivsRv152AU2nz2tdJSBX9ow1/oEL4d8s8XV6lQ2W6crRH02a VoG3Txc7h/S43E3PTGy+nFQPPh+UsYFpPXP6ngAeXgN0MCn9G4iS3oxnbhVuRDOOtrot 5Fla8JgCvhXCp7cVTyfXf/pdnEK2dLn2T6ojnL3wArmjGMd5qTiC/vKsXhQBLwiL8flu fs7RsTqmxgoMzHHUcMtb8TcpNtSzvn9wAZTsA+L7CD2lNF5y4/N6t2kl1CB1OhfMiAzi 86YbMwvn6sHw/7TMN/v+3ARGoXm/8o8c6T6y6T5TfhJZB3RMKXtl0boynp5yUcr6xI0F ujlg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=G1FEGn3O/VBptqGwJi6KCObyTHs9nhdvsW5xpkdLjlc=; fh=JASAEPYKLgS69vVDzsrNlPvFdidWhQf3L3WUeeF5VWc=; b=BbvRmgF0NA1IINhSUnzdiNXjldWHmsC0LUD5Bj8dv6iLrrOm30Hia7IhownY5NQl91 87/chxo35ss8vJ1HmMxrkZst/5eTYtR5ud4onMCpCBz5bIH1Mpz2LVC2IFpdHeWQmLU/ uQI21/kox5l/SS7aTAnbzT2k+gYfKysNoTG+L29RGOMSsmOWlmtcxSIObU5eChgP2YKw vynGkPpiAECyl3OUDjYxROo7/NL9bSXHs6nQ1bto6cpJ2odjfE9NUSYMpdUvFDplHIxT JeULJhXlHs4dD/6Zi/EkdKagf5tvcAD9phkJML7wPIh/hrQQKJkSgHFwC4cZXm2BSH6O Nz4Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=LlkNe0eI; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-39578-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39578-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id gy25-20020a170906f25900b00a3165a8ad0csi150495ejb.492.2024.01.25.19.57.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 19:57:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-39578-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=LlkNe0eI; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-39578-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39578-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 024E61F2173B for ; Fri, 26 Jan 2024 03:56:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 388C0BE5B; Fri, 26 Jan 2024 03:56:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="LlkNe0eI" Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAED5AD2C; Fri, 26 Jan 2024 03:56:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706241375; cv=none; b=beKZlz3uoqHLpJufaz/EHR5zNyEOZJgi6fGTqF8Zxq4sJlIO7H8ANikkh30m7G2YWHPngueNScMUG5MFWdIxvS2dy8xzqLc1n4f8DmsPsFnnyyCqlbljJlUOTVe0VY79Nqi2K9GZNhiGaM59XlY8D9TJTcOBk17EJ6jImDRMz1A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706241375; c=relaxed/simple; bh=TTMMcaKwbtVMWjq2FvU5baWtMNXCodc6+U2gPgL4xKE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=PqenFdhKuNsKN2+f8lvRuvePxhV1JY4Uiz2gLgbx5sE/acPolDXcQILfDzlTd06B9mAUuP+nrVq6Hcw5PvfZcADxRFri+pQcxWgcI1tj6dBAbQsQtBdPObNeoqrVv3OEfo7bV1YvUA0cIgcOB/rqLnT0ESG4AokVMt25UO4doFo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=LlkNe0eI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40Q31WOS021579; Fri, 26 Jan 2024 03:55:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:date:subject:mime-version:content-type :content-transfer-encoding:message-id:references:in-reply-to:to :cc; s=qcppdkim1; bh=G1FEGn3O/VBptqGwJi6KCObyTHs9nhdvsW5xpkdLjlc =; b=LlkNe0eIX5Ev2xmOk8tVTdz8v45pi4PMx+zqJ4xNSuqq4xKUrl6FYdcEWS/ XHvZu6FrgrZdIHyT4gXRWYwUNdSMI25Opp+Zh3OZjz2cmxI5ttfJyLMN6cjYtYmu ub2oVjMDOEJWpSAzej01TvYZ4MqxYksa55RThYJuZuMP3UdkqhmLltwZhen22Xq1 yLJs8VSLRSfgBiMdp4fWkK9nPfqyjtA1sbIfsjD1UjAQMojnsZbLaXTfKIvghLP/ A6hMbYi6bN6n1Zaf4cIpTPvEAEC2hpXWd2aP0v4LHOkpG9F+p+LfrO8WmjJpi3z4 3HZNKkbLXSqcLdv7+1I66RE8FMw== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vv4f9g2kb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jan 2024 03:55:18 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40Q3tHbM005315 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jan 2024 03:55:17 GMT Received: from [169.254.0.1] (10.49.16.6) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 25 Jan 2024 19:55:17 -0800 From: Bjorn Andersson Date: Thu, 25 Jan 2024 19:55:13 -0800 Subject: [PATCH 1/2] dt-bindings: HID: i2c-hid: Document reset-related properties Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <20240125-x13s-touchscreen-v1-1-ab8c882def9c@quicinc.com> References: <20240125-x13s-touchscreen-v1-0-ab8c882def9c@quicinc.com> In-Reply-To: <20240125-x13s-touchscreen-v1-0-ab8c882def9c@quicinc.com> To: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benjamin Tissoires , Jiri Kosina , Bjorn Andersson , Konrad Dybcio , Johan Hovold CC: , , , , Konrad Dybcio , Krzysztof Kozlowski , Bjorn Andersson X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1706241316; l=1255; i=quic_bjorande@quicinc.com; s=20230915; h=from:subject:message-id; bh=TTMMcaKwbtVMWjq2FvU5baWtMNXCodc6+U2gPgL4xKE=; b=LNZpsPqbTtp1I8k54ivVB1IxHVgS9ycUtGqd91Hrd/pw4o/pWQF1idhlqk/Ske8JF7RGwhLlr YZVnPnOHQu5BTSAX5vOcVkkfLKlSIrqzBT/Q18UZtVG+G/X+EqGwyVT X-Developer-Key: i=quic_bjorande@quicinc.com; a=ed25519; pk=VkhObtljigy9k0ZUIE1Mvr0Y+E1dgBEH9WoLQnUtbIM= X-ClientProxiedBy: nalasex01b.na.qualcomm.com (10.47.209.197) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: NiPAHmV6-8QIO6bivnjm1JUqKp8iD0v- X-Proofpoint-GUID: NiPAHmV6-8QIO6bivnjm1JUqKp8iD0v- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-25_14,2024-01-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 priorityscore=1501 impostorscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401190000 definitions=main-2401260026 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789123811653529540 X-GMAIL-MSGID: 1789123811653529540 Some I2C HID devices has a reset pin and requires that some specified time elapses after this reset pin is deasserted, before communication with the device is attempted. The Linux implementation is looking for these in the "reset-gpios" and "post-reset-deassert-delay-ms" properties already, so use these property names. Signed-off-by: Bjorn Andersson --- Documentation/devicetree/bindings/input/hid-over-i2c.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/input/hid-over-i2c.yaml b/Documentation/devicetree/bindings/input/hid-over-i2c.yaml index 138caad96a29..f07ff4cb3d26 100644 --- a/Documentation/devicetree/bindings/input/hid-over-i2c.yaml +++ b/Documentation/devicetree/bindings/input/hid-over-i2c.yaml @@ -50,6 +50,12 @@ properties: description: Time required by the device after enabling its regulators or powering it on, before it is ready for communication. + post-reset-deassert-delay-ms: + description: Time required by the device after reset has been deasserted, + before it is ready for communication. + + reset-gpios: true + touchscreen-inverted-x: true touchscreen-inverted-y: true From patchwork Fri Jan 26 03:55:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 192367 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:e09d:b0:103:945f:af90 with SMTP id gm29csp429904dyb; Thu, 25 Jan 2024 19:56:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IEz+lDiP8sEWOcbxHFiW4xpsVr+D3MiD/BBGOJMShpKXeJLb1gmzdpjAukYX+WHlq6gjZMn X-Received: by 2002:a05:6a20:6d0a:b0:199:a2a9:4150 with SMTP id fv10-20020a056a206d0a00b00199a2a94150mr583467pzb.121.1706241374353; Thu, 25 Jan 2024 19:56:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706241374; cv=pass; d=google.com; s=arc-20160816; b=LOhM2nFWe5oZz7OIdz8qOXQQViQrDbWfuF04rQ3O6S2ww+kqlYCGNyC0eAw4xcYmWn 0jJZ3DjAEhBGRyr8pRJf4LgtL/EYW1IYXBxhe1tcDLB3IdXEoIJNmpXZlKt0+oD8r1Rb bvqdrvnXobKD6QawPCmFiybt8lAF2Rk7mRVUyIqexpx5le5g2Mmec4LYC3wzJkD5awVr GiucbQfSuw18fcpBfXwRIjmB4J1Jrs+h1e9y4WFe61htyRK0SV0s9p+9kkizHi3FFMT+ ylfcauO5hRifA3Iz/cuz3UY5ajKAjr4nm3uM0VjJFZNFyZ9opUVpvGiJBICqSFywl785 PMkA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=Cck/GJxSluI5ev4MbkCdy2c7VJsUu3P8mIgrgZQqg0o=; fh=JASAEPYKLgS69vVDzsrNlPvFdidWhQf3L3WUeeF5VWc=; b=ORKgvtHrm2BG2Ficl8UtFgpJa7OYJ1ewn3QRLy3iZnAgt7Crd/kJe/SuNGfvqh38n9 nC3loHA0WOe+wWK83Ye55DgqWkkqh207ZuSPkCsc6GUvETix1IEtQnrNXJ+fERzI7eBL FhJi29kKQvT/kbx7rO41Yg36CcQFS6XUt/vaO5yo5Oz96l4moTLFNv6STKPCof4QlVMI kvg2mm8almR6he9sOZ82+nIPzjEgAeglTX4SwZ8oWPQrnmAovWWlliZnbqAFCY2hTgte D+5ijWeZMGH4p9/d9lXAmODelJAuM/TGW4OULmJ1wL9I0xwXRcRc7Jhr3gNvTnM2gUYR 83/w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=FQZ2jyqn; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-39576-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39576-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id ga5-20020a17090b038500b0029065f05934si2470687pjb.2.2024.01.25.19.56.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 19:56:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-39576-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=FQZ2jyqn; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-39576-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39576-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2468928C164 for ; Fri, 26 Jan 2024 03:56:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5580F1118D; Fri, 26 Jan 2024 03:55:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="FQZ2jyqn" Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AC5EBE49; Fri, 26 Jan 2024 03:55:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706241332; cv=none; b=Gt8i/9ZOozfhIOK6egNH8dBQ9SIFoacf+mje9oWRg6XK8obQ+YddLyidfhJwsrJTTVaML2D5PpUKqUVHJuyKJUI/uEolkVDGVMp0nu1o2cLy/aZMSPdTMNN6mqZw+3ihIi0pNEwczrXaenzacyY789vkQ8Leh5oUEv48sCQzaAg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706241332; c=relaxed/simple; bh=Kk+y5hNnOiQ2qFggH/zRNiKdLX4XwYFzmrAqZbWNdE4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=p6wkreno5qS8JWm4EB9wRi6d3TYWCA0pL6+egyJEACmCHMeppPbxEqR8k0N+K9x1+fuoV7CHPO+CAXzH56jv9PHfhv6IDG8QaUirz5S4HI9U5apEOGf6zV0+uvXm5PVqgOKK80TPwsDK4GBqyaiUt70dnVwpP3gXTtGtaTLXTAI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=FQZ2jyqn; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40Q0uWGk023947; Fri, 26 Jan 2024 03:55:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:date:subject:mime-version:content-type :content-transfer-encoding:message-id:references:in-reply-to:to :cc; s=qcppdkim1; bh=Cck/GJxSluI5ev4MbkCdy2c7VJsUu3P8mIgrgZQqg0o =; b=FQZ2jyqnH6QiChIcx1hgrlX3uZC2Kl4xmM/4TerUXvd4Y4mKDEsM4iSINFv 6CBTRDiHbd/3v3hiOsb/H9/4f+9FDetcunv0zVl0146wxQH9VhjnOquoS08xB8ym jvrnGlI0X4oQC6j7ZY2zEdbQ911qFcdUCFza5oiS2+tWoa2OOby4qwt+0do0fo1v kV9cYGZ/O+6vnbKyVU2su/cDO63LamR4Jx2w7I/aYsUC7akGTiDyMyWrTekjdGs4 sD4imc+zra+q0qFxcIoMRx8rVFZpgNIuTh5//e1whHJryG8tMod6WpITGfOsXBW1 gpPsm2s8qyqOmx+R/uLI8u/wHJw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vuqra1xek-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jan 2024 03:55:18 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40Q3tH9G023435 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jan 2024 03:55:17 GMT Received: from [169.254.0.1] (10.49.16.6) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 25 Jan 2024 19:55:17 -0800 From: Bjorn Andersson Date: Thu, 25 Jan 2024 19:55:14 -0800 Subject: [PATCH 2/2] arm64: dts: qcom: sc8280xp-x13s: Fix/enable touchscreen Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <20240125-x13s-touchscreen-v1-2-ab8c882def9c@quicinc.com> References: <20240125-x13s-touchscreen-v1-0-ab8c882def9c@quicinc.com> In-Reply-To: <20240125-x13s-touchscreen-v1-0-ab8c882def9c@quicinc.com> To: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benjamin Tissoires , Jiri Kosina , Bjorn Andersson , Konrad Dybcio , Johan Hovold CC: , , , , Konrad Dybcio , Krzysztof Kozlowski , Bjorn Andersson X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1706241316; l=1330; i=quic_bjorande@quicinc.com; s=20230915; h=from:subject:message-id; bh=Kk+y5hNnOiQ2qFggH/zRNiKdLX4XwYFzmrAqZbWNdE4=; b=XXT4ELI9bJf5JFfwnJVzWRjPWf/opRDOL12nu58PFDtuwjH3AZI9SKtQvEzhzxzkdqWkA9Fu6 w5PjI8TexGKCCUz/IQmmsi0XRVCrjWOtx8ww5WL8+CISnVfZhjNoyWL X-Developer-Key: i=quic_bjorande@quicinc.com; a=ed25519; pk=VkhObtljigy9k0ZUIE1Mvr0Y+E1dgBEH9WoLQnUtbIM= X-ClientProxiedBy: nalasex01b.na.qualcomm.com (10.47.209.197) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: RgVbnw65RNvrWLmkuNOf9f2ff1_gARDJ X-Proofpoint-ORIG-GUID: RgVbnw65RNvrWLmkuNOf9f2ff1_gARDJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-25_14,2024-01-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 mlxlogscore=999 phishscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0 mlxscore=0 impostorscore=0 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401190000 definitions=main-2401260026 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789123755352132731 X-GMAIL-MSGID: 1789123755352132731 The failing read-test in __i2c_hid_core_probe() determines that there's nothing connected at the documented address of the touchscreen. Introduce the 5ms after-power and 200ms after-reset delays found in the ACPI tables. Also wire up the reset-gpio, for good measure. Fixes: 32c231385ed4 ("arm64: dts: qcom: sc8280xp: add Lenovo Thinkpad X13s devicetree") Signed-off-by: Bjorn Andersson Tested-by: Daniel Thompson --- arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts index def3976bd5bb..d64d0e76c1ea 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts @@ -620,7 +620,6 @@ &i2c4 { status = "okay"; - /* FIXME: verify */ touchscreen@10 { compatible = "hid-over-i2c"; reg = <0x10>; @@ -630,6 +629,11 @@ touchscreen@10 { vdd-supply = <&vreg_misc_3p3>; vddl-supply = <&vreg_s10b>; + reset-gpios = <&tlmm 99 GPIO_ACTIVE_LOW>; + + post-power-on-delay-ms = <5>; + post-reset-deassert-delay-ms = <200>; + pinctrl-names = "default"; pinctrl-0 = <&ts0_default>; };