From patchwork Thu Jan 25 18:08:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 192219 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:e09d:b0:103:945f:af90 with SMTP id gm29csp157291dyb; Thu, 25 Jan 2024 10:08:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IEptwQANrmVsxB00wQshgOt5YvMDQyQNqynN+0gNjXM/OKF/dmA8vtBip+8u3pg9sLn9jQU X-Received: by 2002:a05:6214:226a:b0:686:34cd:74fa with SMTP id gs10-20020a056214226a00b0068634cd74famr57871qvb.29.1706206100792; Thu, 25 Jan 2024 10:08:20 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706206100; cv=pass; d=google.com; s=arc-20160816; b=uyvqsCzvM6I5s518Vg3phhZb7T2uNq0tnu/NUO43gKE6aCSq+N5Bi2WIZCfGw7CjtL q4o+grSbAUk7DWMq1LQeisjj+a2R75TxXU8ZKAMgQrKvxTINDgvraJId13JkNudwa/IY 4C1z/BGiBuExlDnxmdMHlwY7DFGKcMMx1PS1tQPKW2pfl12M9X5ZKuI6JtYUJLd5OdMf ktPYdsztQq6CuYhUQZNPpUo1AomeEphD+tm6fb2O6gSI8FbM8yHh8kZ1LWc1kUsNfb/J gekae+eiER08D2wt/ymaKdJCaAnURmg8jxn0V0W2dJkDTVH8BzZ1XdfcN0OwrhSR//D/ 9AeA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=NCL87gT9eCmdWSOjn5LCRatO67V/Rrnr3LJPZRygEAE=; fh=NLxAvL/bDfPg4AGOtxqvQlND8vazkZrNzKLY8+LAbBY=; b=Xjd644nLFswRm7h1pcnYLkYOo7WHXpJ3ku/vRYI0ARDTnlK9y1a8NPfPwGRy/CdbAK 5RpXjgY/+fCqaRRfWsSCKNi4zm8lu+RdRK/4nhVOz2PhHhxWTp/AZISXflwpw6jtacib V2xMfoyPIB7Ka/NLoMthKmu2DCQZRFMYAaIAw1JMk/vuXnRmLelUlA4j7BbIA4uHZcJl 6IRMYxBF8wPLXkfyNiVVPqYYm29F7o7GeJojdNGx1zHs/TJjJomE2fmZZuo68pX+qlLe NPxY1ROaGWd+XIVkP8e3gJV0176pTrB/OBuA5l+ELwupFujwtDJRfJD5sc642O5QJqyZ E7uw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=WrK8ovhq; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id e3-20020a0cb443000000b00680b1539bdcsi13507111qvf.551.2024.01.25.10.08.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 10:08:20 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=WrK8ovhq; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6D49C385829F for ; Thu, 25 Jan 2024 18:08:20 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 6CB4C3858C53 for ; Thu, 25 Jan 2024 18:08:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6CB4C3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6CB4C3858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::429 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706206090; cv=none; b=hFIyYO/yFlYY/HQA0UPjKalbfTmYOg40XO1Pf3XGflGmcqStq+qxOfBv/WB4a+cl7UERGCKKZZvM6sTFYF8qY2Au9u4YE9NmsZKgAC9rUeECmH27sL7V+UidVcHjsno/hU1rgj2SmJp13R5h1ao8eFmZimkGDDJzvM9jmxNj2Kc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706206090; c=relaxed/simple; bh=8TqzHv0EVx/zJz60Iq6llkSmdAjG/7Aq74xzRkJ/4Q0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=B63ldJ4Z4Txl8UUUltNpjNYm96ORAokh1Pz82XrNl9DE+oTGS95xG5FHppoJGztvf0gDvj/qDn/J+6WcwlHClihFNWh5nJCQFvBlMxt4kKXno8NQHRqh2e3EBDC5UTCHnu+BRasgUprQfb/Td9FdE8w29Z2RJSZCzOCBEdbI0vw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-6da202aa138so5319293b3a.2 for ; Thu, 25 Jan 2024 10:08:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706206087; x=1706810887; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=NCL87gT9eCmdWSOjn5LCRatO67V/Rrnr3LJPZRygEAE=; b=WrK8ovhqOoD35wz7wr0ZfgQUtLXkvvipSlSZ3TKbkNlaXRvbZcoFHCRHKMjcZuJjQZ d/ECLvTutawGeCwkCgBCR6Vng6xaRYOf/rn6lMj5aYsOmglmjQDLXASSurG95gGDWtUc AysoucFHBpl7VomkTB75LFjkeNmz5dGko/b9qomqVkmwMXhZBINq6xZtcTTTTQ94D+Ra cLTbVE5coi0o/LoxUru4vCa0uPX6qOpAgNWLagLlaI3noojEyZPWzA9KjVtT5S5iZi27 QPd74wVlOsZt6y8aeWNFBcD29WwtrEY+pAV27wnNFBAsbL7cgSkStCIa3IrsMiNislx+ a2Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706206087; x=1706810887; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NCL87gT9eCmdWSOjn5LCRatO67V/Rrnr3LJPZRygEAE=; b=su9nIDVtph8nndpl9Maaol/LwkaOc2c2wEcspEy8BRnj89r9jJGZhR1WGwrNf+ClWF 6nDwDEeAh7AVPu069kQBwgy8UaZvJjWLdmEOCdGFpWgpKK3Xzh3dDzsakUgQ8pbxvkyW CDCqxEmO1yvSulaEikN2g/63lRcrHZJzOrnJwKG3wRJLns32HQdrhBiO37BCdCH7nYCF WwZ54nGjFqvKIf+kSUDdAfyD6HuDBvcks2wxHROyjChuchTduyrWTW3qOGO1KErimd+O q6oSJWdgKo8nDn+cj3QAmVb3AX5MaHauFAU9amdjAIez72ZCLwY+qZ67XilvGArSjTkG OOXw== X-Gm-Message-State: AOJu0YwLekajro0PoryM2c3irZWZnrhdqrsAZZfclVagc8ibZpX3kKlr 274vUnv99aqqjT+jdxkz3gVw8SElDGl2mxY8bPBcVh2/JSghDdLL8DjiBWgD X-Received: by 2002:a05:6a00:139b:b0:6dd:c1b7:bc85 with SMTP id t27-20020a056a00139b00b006ddc1b7bc85mr89156pfg.59.1706206086927; Thu, 25 Jan 2024 10:08:06 -0800 (PST) Received: from gnu-cfl-3.localdomain ([172.56.169.51]) by smtp.gmail.com with ESMTPSA id f7-20020a056a0022c700b006ddb0b0ff0dsm3115627pfj.34.2024.01.25.10.08.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 10:08:06 -0800 (PST) Received: from gnu-cfl-3.. (localhost [IPv6:::1]) by gnu-cfl-3.localdomain (Postfix) with ESMTP id C3B45740298 for ; Thu, 25 Jan 2024 10:08:04 -0800 (PST) From: "H.J. Lu" To: binutils@sourceware.org Subject: [PATCH] elf: Add is_standard_elf Date: Thu, 25 Jan 2024 10:08:04 -0800 Message-ID: <20240125180804.1175199-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-3024.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789086768424672235 X-GMAIL-MSGID: 1789086768424672235 PR ld/31289 tests failed for fr30-elf, frv-elf, ft32-elf, iq2000-elf, mn10200-elf, ms1-elf and msp430-elf targets: FAIL: ld-elf/fatal-warnings-2a FAIL: ld-elf/fatal-warnings-2b FAIL: ld-elf/fatal-warnings-3a FAIL: ld-elf/fatal-warnings-3b FAIL: ld-elf/fatal-warnings-4a FAIL: ld-elf/fatal-warnings-4b even though PR ld/31289 targets xfail for [is_generic] targets. These targets not only don't use the generic_link_hash_table linker, but also don't use the standard ELF emulation. Add is_standard_elf for ELF targets which use the standard ELF emulation and replace [is_generic] with ![is_standard_elf] in PR ld/31289 tests. binutils/ PR ld/31289 * testsuite/lib/binutils-common.exp (is_standard_elf): New. ld/ PR ld/31289 * testsuite/lib/binutils-common.exp (is_generic): Return 1 for fr30-*-*, frv-*-elf, ft32-*-*, iq2000-*-*, mn10200-*-*, moxie-*-moxiebox*, msp430-*-* and mt-*-*. * testsuite/ld-elf/fatal-warnings-2a.d: Replace [is_generic] with ![is_standard_elf]. * testsuite/ld-elf/fatal-warnings-2b.d: Likewise. * testsuite/ld-elf/fatal-warnings-3a.d: Likewise. * testsuite/ld-elf/fatal-warnings-3b.d: Likewise. * testsuite/ld-elf/fatal-warnings-4a.d: Likewise. * testsuite/ld-elf/fatal-warnings-4b.d: Likewise. --- binutils/testsuite/lib/binutils-common.exp | 21 +++++++++++++++++++++ ld/testsuite/ld-elf/fatal-warnings-2a.d | 4 ++-- ld/testsuite/ld-elf/fatal-warnings-2b.d | 4 ++-- ld/testsuite/ld-elf/fatal-warnings-3a.d | 4 ++-- ld/testsuite/ld-elf/fatal-warnings-3b.d | 4 ++-- ld/testsuite/ld-elf/fatal-warnings-4a.d | 4 ++-- ld/testsuite/ld-elf/fatal-warnings-4b.d | 4 ++-- 7 files changed, 33 insertions(+), 12 deletions(-) diff --git a/binutils/testsuite/lib/binutils-common.exp b/binutils/testsuite/lib/binutils-common.exp index dc140f8a922..b304801e718 100644 --- a/binutils/testsuite/lib/binutils-common.exp +++ b/binutils/testsuite/lib/binutils-common.exp @@ -275,6 +275,27 @@ proc is_generic { } { return 0 } +# Return true if target uses the standard ELF emulation. +proc is_standard_elf { } { + if { ![is_elf_format] || [is_generic] } { + return 0 + } + + # These targets don't use elf.em. + if { [istarget "fr30-*-*"] + || [istarget "frv-*-elf"] + || [istarget "ft32-*-*"] + || [istarget "iq2000-*-*"] + || [istarget "mn10200-*-*"] + || [istarget "moxie-*-moxiebox*"] + || [istarget "msp430-*-*"] + || [istarget "mt-*-*"] } { + return 0 + } + + return 1 +} + # True if the object format is ELF with unused section symbols. proc is_elf_unused_section_symbols {} { global AS ASFLAGS READELF diff --git a/ld/testsuite/ld-elf/fatal-warnings-2a.d b/ld/testsuite/ld-elf/fatal-warnings-2a.d index 5c46f4300c6..b17abb1b274 100644 --- a/ld/testsuite/ld-elf/fatal-warnings-2a.d +++ b/ld/testsuite/ld-elf/fatal-warnings-2a.d @@ -2,5 +2,5 @@ #source: start.s #ld: -z bad-option1 -z bad-option2 #warning: -z bad-option1 ignored -#xfail: [is_generic] -# generic linker targets don't support -z options. +#xfail: ![is_standard_elf] +# These targets don't support -z options. diff --git a/ld/testsuite/ld-elf/fatal-warnings-2b.d b/ld/testsuite/ld-elf/fatal-warnings-2b.d index 5fa94e467af..7aedb531dd4 100644 --- a/ld/testsuite/ld-elf/fatal-warnings-2b.d +++ b/ld/testsuite/ld-elf/fatal-warnings-2b.d @@ -2,5 +2,5 @@ #source: start.s #ld: -z bad-option1 -z bad-option2 #warning: -z bad-option2 ignored -#xfail: [is_generic] -# generic linker targets don't support -z options. +#xfail: ![is_standard_elf] +# These targets don't support -z options. diff --git a/ld/testsuite/ld-elf/fatal-warnings-3a.d b/ld/testsuite/ld-elf/fatal-warnings-3a.d index a377b738b1d..1b52f8fe0c5 100644 --- a/ld/testsuite/ld-elf/fatal-warnings-3a.d +++ b/ld/testsuite/ld-elf/fatal-warnings-3a.d @@ -2,5 +2,5 @@ #source: start.s #ld: --fatal-warnings -z bad-option1 -z bad-option2 #error: unsupported option: -z bad-option1 -#xfail: [is_generic] -# generic linker targets don't support -z options. +#xfail: ![is_standard_elf] +# These targets don't support -z options. diff --git a/ld/testsuite/ld-elf/fatal-warnings-3b.d b/ld/testsuite/ld-elf/fatal-warnings-3b.d index 87ea286d748..870a1eb2fea 100644 --- a/ld/testsuite/ld-elf/fatal-warnings-3b.d +++ b/ld/testsuite/ld-elf/fatal-warnings-3b.d @@ -2,5 +2,5 @@ #source: start.s #ld: --fatal-warnings -z bad-option1 -z bad-option2 #error: unsupported option: -z bad-option2 -#xfail: [is_generic] -# generic linker targets don't support -z options. +#xfail: ![is_standard_elf] +# These targets don't support -z options. diff --git a/ld/testsuite/ld-elf/fatal-warnings-4a.d b/ld/testsuite/ld-elf/fatal-warnings-4a.d index 4685e3877d6..cf7373b4625 100644 --- a/ld/testsuite/ld-elf/fatal-warnings-4a.d +++ b/ld/testsuite/ld-elf/fatal-warnings-4a.d @@ -2,5 +2,5 @@ #source: start.s #ld: -z bad-option1 -z bad-option2 --fatal-warnings #error: unsupported option: -z bad-option1 -#xfail: [is_generic] -# generic linker targets don't support -z options. +#xfail: ![is_standard_elf] +# These targets don't support -z options. diff --git a/ld/testsuite/ld-elf/fatal-warnings-4b.d b/ld/testsuite/ld-elf/fatal-warnings-4b.d index 6fc2185f126..7cdb2b4db7a 100644 --- a/ld/testsuite/ld-elf/fatal-warnings-4b.d +++ b/ld/testsuite/ld-elf/fatal-warnings-4b.d @@ -2,5 +2,5 @@ #source: start.s #ld: -z bad-option1 -z bad-option2 --fatal-warnings #error: unsupported option: -z bad-option2 -#xfail: [is_generic] -# generic linker targets don't support -z options. +#xfail: ![is_standard_elf] +# These targets don't support -z options.