From patchwork Thu Jan 25 12:44:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tobias Burnus X-Patchwork-Id: 192059 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp1611474dyi; Thu, 25 Jan 2024 04:45:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IGODSnJyJFY3jx34PeMBPmdySBTA0i4e5YqiUx6TwsjuMnSnAZUqqaK8ANnOdasuDz1N/tT X-Received: by 2002:a54:4110:0:b0:3bd:5a62:494a with SMTP id l16-20020a544110000000b003bd5a62494amr774705oic.95.1706186727876; Thu, 25 Jan 2024 04:45:27 -0800 (PST) Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id op30-20020a05620a535e00b007839027ea83si12327211qkn.763.2024.01.25.04.45.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 04:45:27 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=blcT+njb; arc=fail (body hash mismatch); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 94E8E3858409 for ; Thu, 25 Jan 2024 12:45:27 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id C01823858D28 for ; Thu, 25 Jan 2024 12:44:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C01823858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=baylibre.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C01823858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706186690; cv=none; b=XtZAJsOkJbGr/mYlSqEvu66/jnxade+uICHQ1q2GuUH3juglEKKM6zKve91f3FW1cYDQ9nzHm+4WCS9u9H8YFsD9mvWd3s+49C9jWxa+q9duQYmnlgHFL+YuH+Mj3TZeqfxZlRxkwI4VSwIrwL/8PB5xulbkKpNrV43gY71M2/0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706186690; c=relaxed/simple; bh=QBwZlbArrmNkuGW5Ufzl/SeF/tDuWjuYwwlFSLpWOz0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=hjSA440v41HetVKclKuQUvGbkM4cOkcCuixpnqnBfbp5Ib0I7jpUFHm+XGg4jlMpBTVhTXB2FjGxlboKrfd/GS7wKNggud3ncvIrNNqD5lMhuCTpcy0vPVHJee8bizndeu6VgNNUsM+E9tIzPCteEs37DqTxXFBylTfXg9sqJ2o= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40ed3101ce3so3369585e9.2 for ; Thu, 25 Jan 2024 04:44:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1706186686; x=1706791486; darn=gcc.gnu.org; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=vTPrZ587luViPhc7XvTp0xyimcs8C2fEVxECAulcdFY=; b=blcT+njbRGsc4+1rYgVsdoL2vDuKppJI+1Pu5NYpuaRQ58IvLocsqd+gTYLMREQrI0 TMa7aWLGBKoH+seqoshpRldHKGcqVjCwzU9Bfl0ncyOADUvtd1QMpVjWCZbCdjgWn0cp QwfZSkJFcPpg5rVWdlKKsybTHIkfja3QetpPkGJ1Eo+EAoywVWVIZFYjdOq0muVxc8Sf 6QIMrbmYc8ff9PGMGBoqFWyzc63ckBdm9EJQAJQDHSzqInH6TiXFc+8d+LF3RkLWpaGK CjPRUycxyr2V4fhPO6xiSyNJE64MSCr7DzTzFHyeJ9Npzph4qaDcdB+w2k1uFVKbK2Ji SWXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706186686; x=1706791486; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vTPrZ587luViPhc7XvTp0xyimcs8C2fEVxECAulcdFY=; b=dfmCux+YSiYoiNU3oQ/2eMgO0XocnZ68C6RlizJRFH6Vv6BbZ32hE9DKMSynmPVa7N OeWgF8a1kogsWOXS1yiFlSlqBPxLtAwEOzq1NKWFwPI7fGWCaspo5QuskvVduT7lTMJE p5YZD+Q2cWPn9tDypCvTfs8T66U7W+aMx+5BeV9AdOqHNnLdl5O7o1eq1EF1sSU1PDq5 X0DwTJ8FJwRBQ8LlRIDRFnzSXRJ/miQLdi0gG4sE7+DYdOvW3NWe8rtC/f6IMLL1PSiV 2ZzzHPefvGxRacspqxqOebq36ykb/nQbDKcHvnps18Lr0hGSQcWFGwIrqS0h/OY1fjXb Mr2g== X-Gm-Message-State: AOJu0YyYwwxAElI9P9w+i5JZoirmQyyGXgE9yzLBZP5Ds3hxnT4Jmz0k zIgaik7/xszHHvhUDAmtMG8VZq7OcFoK9taIkWwBRe7kIBCL0RlYwJV+GLpQsiywNOoUkqINjZH GSdSqnQ== X-Received: by 2002:a05:600c:55d5:b0:40e:75d3:78d1 with SMTP id jq21-20020a05600c55d500b0040e75d378d1mr232369wmb.320.1706186686286; Thu, 25 Jan 2024 04:44:46 -0800 (PST) Received: from ?IPV6:2001:16b8:2afa:4100:be03:58ff:fe31:f74? (200116b82afa4100be0358fffe310f74.dip.versatel-1u1.de. [2001:16b8:2afa:4100:be03:58ff:fe31:f74]) by smtp.gmail.com with ESMTPSA id p13-20020a05600c358d00b0040ea875a527sm2491877wmq.26.2024.01.25.04.44.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jan 2024 04:44:45 -0800 (PST) Message-ID: Date: Thu, 25 Jan 2024 13:44:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: gcc-patches , Andrew Stubbs From: Tobias Burnus Subject: [patch] gcn: Add missing space to ASM_SPEC in gcn-hsa.h X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789066454219779275 X-GMAIL-MSGID: 1789066454219779275 This patch avoids assembler warnings for gfx908 and gfx90a such as '-xnack-mattr=-sramecc' is not a recognized feature for this target(ignoring feature) as we pass -mattr=-xnack-mattr=-sramecc to the llvm-mc assembler. Solution: Add a space before the second '-mattr='. OK for mainline? Tobias gcn: Add missing space to ASM_SPEC in gcn-hsa.h gcc/ * config/gcn/gcn-hsa.h (ASM_SPEC): Add space after -mxnack= argument. diff --git a/gcc/config/gcn/gcn-hsa.h b/gcc/config/gcn/gcn-hsa.h index bf7079fbbc6..f5de0d2969f 100644 --- a/gcc/config/gcn/gcn-hsa.h +++ b/gcc/config/gcn/gcn-hsa.h @@ -89,7 +89,7 @@ extern unsigned int gcn_local_sym_hash (const char *name); #define ASM_SPEC "-triple=amdgcn--amdhsa " \ "%{march=*:-mcpu=%*} " \ "%{!march=*|march=fiji:--amdhsa-code-object-version=3} " \ - "%{" NO_XNACK XNACKOPT "}" \ + "%{" NO_XNACK XNACKOPT "} " \ "%{" NO_SRAM_ECC SRAMOPT "} " \ "%{march=gfx1030|march=gfx1100:-mattr=+wavefrontsize64} " \ "-filetype=obj"