From patchwork Thu Jan 25 10:25:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charles Keepax X-Patchwork-Id: 191952 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp1543036dyi; Thu, 25 Jan 2024 02:27:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IE2JiLjMyQQGLVSpZVFPhgB7zsy78di6YpoKCwVKhVWsI1GhXKPVE1e5OWUrZ4iczOVvIUO X-Received: by 2002:a17:906:eb14:b0:a2f:bbc2:8f49 with SMTP id mb20-20020a170906eb1400b00a2fbbc28f49mr398628ejb.7.1706178452780; Thu, 25 Jan 2024 02:27:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706178452; cv=pass; d=google.com; s=arc-20160816; b=vZHWq6o7+903LROqxCetA6FBzBnRHPsOwMQq/RBC3b1SX+w0JFNopVokSMXy1fw2f3 HbJYQN4t5SoQJng1YwYv8l6N+vx07z3CHSnxDcZHJ75i7MH8rnlTXohMNvoJSA4rGjkH edY2aGt2nDdG5GYDOTkwEEL4FgHxsBsQen6lgLax6AQ9gmz9vGLOIMbLmWCafavEd6Si r8Dja8lct3p82vDfIo1niY1SXZuqdos34qwoEnS3PCqVEmzUJbzKDKLogJ3/mhrIbbB7 0E8ACoMb57jiTOXJRzBbEceWt0JJ7ibSHy4ewHJ/JGolxMQsRgJCVw8eaDAy7xjABwwM e36g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=QW01UQTD20P8CqBxFTRKQQwM25ERFOAQZUxt044R47k=; fh=EuINIlqHtPbjwdS0CwSSvtI6U08+S5VrA/riIg2DViY=; b=pD651Y4ZnG/u7oO1NhCc6S7CP/FERbyKMj4pBglZd/15uP4NzUG3ayL5SdnZw+Ob8I C/61wHyZxglXY21MZeNkJFjU9HmKQgk2ayOwDDYmlBss0wAwvelMZHvsP3bHWnN4zJEf xNIZaKmJ9csL1n8kopOPi59Y7FONfQ3WzeahyBqQoTR1mS13CbRH61Jf7WRSiapZ3afX /pKj4fa49JYEfqpU0HgZN00eukkShP8nImByKCfGnPmiMMPay4dxvPdQWW46V32RmJMo 06DDYsM3yzZPAeZ03LdxZoCeBBX1/+Mt+Tu+MZzRSGsPTDgWBZnQcP/lFKaG9lMg+GPa gtkQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=MoQKyPCe; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-38384-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38384-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id n1-20020a170906724100b00a31857d7d7csi343035ejk.213.2024.01.25.02.27.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 02:27:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38384-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=MoQKyPCe; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-38384-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38384-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 67FCA1F21351 for ; Thu, 25 Jan 2024 10:27:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 733B51D55C; Thu, 25 Jan 2024 10:26:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="MoQKyPCe" Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AE971CA84; Thu, 25 Jan 2024 10:26:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.152.168 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706178363; cv=none; b=LXfjzTMyiFNFN46neXmr5p8JKzArxAIA6bNO6d7Leent8Wj8HfWvSOAHEH/YblUB8I76V7AFwxAi5r5bDCUbfHMM25I+mPSfRNGufT3MZATDtlZRjmsKWv2ovDqZv2NS/irNkuus4NZVa+EAq6RBilUEufN47PKyZYeqvpouDxc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706178363; c=relaxed/simple; bh=ADL6EEUd16TWoEirfUXHF7UrKKLkYyngvp1UHT/BuGA=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=knbwtZsmUG2xBomgvghAScz7JSs8sGiFA48JP49nDZ478e4oDKA1rEAFf0v0DCyYhjMYHgJZO5bCuvh5fy9QdpyTd00eLDWz0syOLy+McLOfhvD2w1zFfMGCpVrZSulq+oZW9DDdBxJGQle6qXWRYYdt4/mefTUAbKlbZdeX41I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=MoQKyPCe; arc=none smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40P7paSN014010; Thu, 25 Jan 2024 04:25:57 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=PODMain02222019; bh=Q W01UQTD20P8CqBxFTRKQQwM25ERFOAQZUxt044R47k=; b=MoQKyPCeHpoLItGPx eah2szKYE21lONRS1Iu9LPh5Ary0AET+v/NXGjrbrKTYyfsKjrGaNFMrkVA+/qsF FPaydmCfYlqqY9jjKi/v7NPhsJtz0lkg51jdcdpuR0b6aMYvIw6iw4rdkDkmHZyR k++KOEjTs/xWESQ8f3PB7EimEIX3H6MaJeGEyqIWBFGlcSer0YD9hTR0gJzOJguS q/vgWwIMpMYUQwtOecIopRcZ/72SQjf3gFHWbP3taGx/01TFV6MzyrBBHrITtEL8 H1lQVd0ok9qFII+CHtn67M3sqIdMwkCVIvgKg2uoufOQ+I+f7jfq2jZvRJ+IuBAx 25zFw== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3vtmf9t2gh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jan 2024 04:25:57 -0600 (CST) Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 25 Jan 2024 10:25:55 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40 via Frontend Transport; Thu, 25 Jan 2024 10:25:55 +0000 Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTP id 50250820246; Thu, 25 Jan 2024 10:25:55 +0000 (UTC) From: Charles Keepax To: , CC: , , , Subject: [PATCH v3 1/6] spi: cs42l43: Tidy up header includes Date: Thu, 25 Jan 2024 10:25:50 +0000 Message-ID: <20240125102555.2621736-1-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: A1islOW7n7jO12Zs_UFZL2kq9edDRCJK X-Proofpoint-ORIG-GUID: A1islOW7n7jO12Zs_UFZL2kq9edDRCJK X-Proofpoint-Spam-Reason: safe X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789057777500066441 X-GMAIL-MSGID: 1789057777500066441 Including some missing headers. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Acked-by: Mark Brown Signed-off-by: Charles Keepax --- No changes since v2. Thanks, Charles drivers/spi/spi-cs42l43.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-cs42l43.c b/drivers/spi/spi-cs42l43.c index d239fc5a49ccc..fb62807fc991c 100644 --- a/drivers/spi/spi-cs42l43.c +++ b/drivers/spi/spi-cs42l43.c @@ -11,7 +11,9 @@ #include #include #include +#include #include +#include #include #include #include From patchwork Thu Jan 25 10:25:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charles Keepax X-Patchwork-Id: 191954 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp1543140dyi; Thu, 25 Jan 2024 02:27:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFDgbiddwwUMfSCg4XOPmzgITjuW2g322H/Igl58dwZmw0o26hpnZUz2+eN9eb+tGf/r3L+ X-Received: by 2002:aa7:c9d1:0:b0:55a:e98b:18a4 with SMTP id i17-20020aa7c9d1000000b0055ae98b18a4mr394596edt.74.1706178471046; Thu, 25 Jan 2024 02:27:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706178471; cv=pass; d=google.com; s=arc-20160816; b=Bx20yepcjFin2jd8VhNALC7Vyldh8UYjluqzQKUnlFMSKnfUsAwFUtSddQI/rURDhC FohgnRAT1aoQriWiTfRhX2IjEfj2hZrNHmPg1hha1oqkqBJ1HiThspYyIMH/xI3g0itY bo/Dcb6roBI+GuEbtB1WMrI0EFxNBEd90Zcr8j/tVU7TlX4XvOfiW6Uk39PfKgdX3KB6 iRGsuTkc/+w/T6GGSF8Y4yBn+Vz7X474plohJY5ZUqkeb2p+lkJFUd0YiTIjfaavvOYf HucuYoEqRItx8YoQIBhPrx8mt5XYhq1AAULe687Ye2MUC6CVCCaPP1wy65Sm9v9VtZAL dbsg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=tgZbg7s/Xmp8FdDn7TgrjKWKHPIok2Iqw7axQOHNlMM=; fh=EuINIlqHtPbjwdS0CwSSvtI6U08+S5VrA/riIg2DViY=; b=FLtv4Dk3RMHFgbNJ0eJuarsMzJkanU4NDO0vDvjdRLHuiyn7fMx/8pL30ti4Lci5bZ Z51CAFpccKfTN5wAY/hgiRQcUBuQLDGBFQj4e0Sg47mCje4HakJRIC7jPabe4VVboCNa 2HRK2650Kr0UfF1QojBq/2HPDZZ1NiNaOo97CUcPxggZgR28CQCB204Yo3JZXrJxIxds kRKWAOjml2osGbxstS4iFQrNw9z4GOaA2VUNGTzVjHmZFe/u0hca/l23hSrXUUnPbscT FAA3+n7jbjNjcANgSZ8m+qk9K41A8b2ifWeTNyCk7IbOmqI8yJpuou1sNPLMSbMlLbtE 98mw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b="HV/nonW+"; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-38386-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38386-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id j18-20020a05640211d200b0055c36011c83si4389622edw.575.2024.01.25.02.27.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 02:27:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38386-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b="HV/nonW+"; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-38386-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38386-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 740D41F21AED for ; Thu, 25 Jan 2024 10:27:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2860620317; Thu, 25 Jan 2024 10:26:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="HV/nonW+" Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AEB61CA85; Thu, 25 Jan 2024 10:26:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.152.168 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706178364; cv=none; b=B9teKNA/NOycEpHN67I8Dg615veC240Ph9TMda8fFO+uq/BHF0gJYMTMubueNuLYk+ovTOYuAoH3O3IQIqB4k+gt1y9ayW1rR9zveVoUPmy9jziVlyaWqYbNZ7PsgYDFVoHvUl2yHWIe4KbUiL+REqbr/AW4hPATOuKFZ5EB82I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706178364; c=relaxed/simple; bh=h64B4Jysj120NFVqsEz9rAYExohizXd5EBkLaCHZXzA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CdfeXsPvHB3xfZst/eeU3OFz61+bpd2B4CUQoTZ0DE2quJHC8aWd/d/Iy9+46ivWoKbwAHx6HFXM6xtC/Qo4/wvD1SAl05rsU9OFx8TFROZU/6DibJz27oEy98TslLwEzdpiPpYuHlNG36C4goC+X5HI8TbHCBFuCqKWNtLCuHs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=HV/nonW+; arc=none smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40P7paSO014010; Thu, 25 Jan 2024 04:25:58 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PODMain02222019; bh=tgZbg7s/Xmp8FdDn7TgrjKWKHPIok2Iqw7axQOHNlMM=; b= HV/nonW+oGdI8zJSDjn7oq3fQO/T/ZU4xzzQcSrsSeUqLqTAwd7Gb5wHkTOX0n2X x0J2ta02xtBSZRcUZu2xleGX4Ub2GJRpcDvHJo2yJxIjnaWb3N081czQNpChNR4/ jeepnr5dC0LoUS/CNRePZHyPC0cUPfICrtwtkkwEDo6dJEh/l2mqWbHlzLY8YVpH cQPhKExaccJgoCrfeT31dGZWfCt4gyDqPT2uQSpiQP8TukAHviZWJQzftRUsfVZI E/7Dx5d/CLKHqPcwDl31yf50R+VBwOPV8XTlKZgbXKC4nFm9PANayq0e/mmi7nFn G1WcS5pwwmMRgJSuN0/Z6Q== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3vtmf9t2gh-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jan 2024 04:25:57 -0600 (CST) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 25 Jan 2024 10:25:55 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.40 via Frontend Transport; Thu, 25 Jan 2024 10:25:55 +0000 Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTP id 5DAD9820247; Thu, 25 Jan 2024 10:25:55 +0000 (UTC) From: Charles Keepax To: , CC: , , , Subject: [PATCH v3 2/6] mfd: cs42l43: Tidy up header includes Date: Thu, 25 Jan 2024 10:25:51 +0000 Message-ID: <20240125102555.2621736-2-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240125102555.2621736-1-ckeepax@opensource.cirrus.com> References: <20240125102555.2621736-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: tn-o0PeWwAAjmCuXt3tXH5RH0hsorDEi X-Proofpoint-ORIG-GUID: tn-o0PeWwAAjmCuXt3tXH5RH0hsorDEi X-Proofpoint-Spam-Reason: safe X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789057796531920673 X-GMAIL-MSGID: 1789057796531920673 Use more forward declarations, move header guards to cover other includes, and rely less on including headers through other headers. Suggested-by: Andy Shevchenko Signed-off-by: Charles Keepax Reviewed-by: Andy Shevchenko --- Changes since v2: - Added pm.h and regmap.h back into mfd/cs42l43.h Thanks, Charles drivers/mfd/cs42l43-i2c.c | 6 +++++- drivers/mfd/cs42l43-sdw.c | 6 +++++- drivers/mfd/cs42l43.c | 8 +++++++- drivers/mfd/cs42l43.h | 10 ++++++---- include/linux/mfd/cs42l43.h | 13 +++++++------ 5 files changed, 30 insertions(+), 13 deletions(-) diff --git a/drivers/mfd/cs42l43-i2c.c b/drivers/mfd/cs42l43-i2c.c index 4922211680c96..7162274a0b551 100644 --- a/drivers/mfd/cs42l43-i2c.c +++ b/drivers/mfd/cs42l43-i2c.c @@ -6,11 +6,15 @@ * Cirrus Logic International Semiconductor Ltd. */ +#include #include -#include #include +#include #include +#include #include +#include +#include #include "cs42l43.h" diff --git a/drivers/mfd/cs42l43-sdw.c b/drivers/mfd/cs42l43-sdw.c index 1d85bbf8cdd5d..d6962a5a35f65 100644 --- a/drivers/mfd/cs42l43-sdw.c +++ b/drivers/mfd/cs42l43-sdw.c @@ -6,11 +6,15 @@ * Cirrus Logic International Semiconductor Ltd. */ +#include #include #include -#include +#include #include +#include #include +#include +#include #include #include #include diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c index 7b6d07cbe6fc6..4e2bc5ad244a5 100644 --- a/drivers/mfd/cs42l43.c +++ b/drivers/mfd/cs42l43.c @@ -6,18 +6,24 @@ * Cirrus Logic International Semiconductor Ltd. */ +#include #include #include #include +#include #include -#include #include +#include #include #include +#include #include #include +#include #include +#include #include +#include #include "cs42l43.h" diff --git a/drivers/mfd/cs42l43.h b/drivers/mfd/cs42l43.h index eb4caf3938332..aded994b7046b 100644 --- a/drivers/mfd/cs42l43.h +++ b/drivers/mfd/cs42l43.h @@ -6,15 +6,17 @@ * Cirrus Logic International Semiconductor Ltd. */ -#include -#include -#include - #ifndef CS42L43_CORE_INT_H #define CS42L43_CORE_INT_H +#include +#include + #define CS42L43_N_DEFAULTS 176 +struct cs42l43; +struct device; + extern const struct dev_pm_ops cs42l43_pm_ops; extern const struct reg_default cs42l43_reg_default[CS42L43_N_DEFAULTS]; diff --git a/include/linux/mfd/cs42l43.h b/include/linux/mfd/cs42l43.h index cf8263aab41bd..2239d8585e785 100644 --- a/include/linux/mfd/cs42l43.h +++ b/include/linux/mfd/cs42l43.h @@ -6,20 +6,21 @@ * Cirrus Logic International Semiconductor Ltd. */ +#ifndef CS42L43_CORE_EXT_H +#define CS42L43_CORE_EXT_H + #include -#include -#include #include #include #include -#include #include -#ifndef CS42L43_CORE_EXT_H -#define CS42L43_CORE_EXT_H - #define CS42L43_N_SUPPLIES 3 +struct device; +struct gpio_desc; +struct sdw_slave; + enum cs42l43_irq_numbers { CS42L43_PLL_LOST_LOCK, CS42L43_PLL_READY, From patchwork Thu Jan 25 10:25:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charles Keepax X-Patchwork-Id: 191986 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp1557197dyi; Thu, 25 Jan 2024 03:02:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IEs16wH/6yMDUduuAOWZL36uPrdRZ9KLkoPUJAJt7VskfNcRcDa7uRc65cnaDQbUid/fnUN X-Received: by 2002:a05:6a20:938d:b0:19a:f0ef:ffc with SMTP id x13-20020a056a20938d00b0019af0ef0ffcmr1203866pzh.3.1706180525392; Thu, 25 Jan 2024 03:02:05 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706180525; cv=pass; d=google.com; s=arc-20160816; b=PztsMp80uNFB8ryMh9FEP+rHqPz7gEa0WBRa74OIJkGnDeCF8rsGhMU200hRyWdxj8 JGc2Go2k++iBKe7mBcTQ6upJxfF7CUQ8VQ2fmRETfsjnQkxHSvjs3Yl8uNCqNzk72s51 lE/A1P/3XzvlgQNvgaZxbCmBGzyg7KmQ2PQJRiDZhmyKQASBn6wLnt9fItqwaVxwFlgR 2y3Rj9RaJS4ffojpx6jQyg7hBBIB/u+auz2mQluK+VKI9icacSYIQInIRRj5yNYi8fRR GTK6bW8OZ23ZkM5GUcYy7AfmhNq7887iWjsHVjBBQ53Hq9LCL/vIwg4JqgvF09tnAXRm 1Qlg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=BbjFLNhhtTIKjqslX2nvALzEiP9LMfzdDYmUGzUJ0Ik=; fh=EuINIlqHtPbjwdS0CwSSvtI6U08+S5VrA/riIg2DViY=; b=CFlBxQ2/R7zxBgX0j3ppfqiF/Oon2UPfJk/7OIlNvmgzZ9ARj4ETN6jEqERyndBXuD jMD0gQDQkJAJ4gU4rduSvmwkhb4eiazHzfqQVmw0YY1E9adGsJSdc4Y5TX/iPSsbLZ1Y 3vowvTaERJYh2tcA8Hq8uON9B77VDK2xrH1tNqj6SAuTWJJrKHrpGTpUTE0oWxUaATx/ yl1bWd5/ZIf5KSej24tGjxkIIgwIQ47se4nlicFEuKVMpFm7I/2TFhcbSRwhB8wjluZj yHo7i02vOgeHxsvt6nTmKON1VzbobjNN7wv/6ik+ukmLtPWBLLybTUOOrOZ+DmIJg4Ki FsnA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=a2+rNiR2; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-38385-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38385-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id e3-20020a636903000000b005cec9148694si13075915pgc.714.2024.01.25.03.02.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 03:02:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38385-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=a2+rNiR2; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-38385-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38385-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9616FB265C7 for ; Thu, 25 Jan 2024 10:27:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7D5331CFAD; Thu, 25 Jan 2024 10:26:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="a2+rNiR2" Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AF021CA89; Thu, 25 Jan 2024 10:26:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.152.168 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706178363; cv=none; b=Em+S5J60Ro0UdmojqWibZqoWaixQzJLaVLuRDnMxN4mJpqpWnalijrTdC+EKhCToqsqo/mX+9xf+pB98GV2TG9URpQEasE04o95uFTP5C8D6PCjduUrXwJ/b5jRQMHF4T4FK5AnSAF2aB2IUT/ow/15fMo/Tx5NXFZyJV6UrfbE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706178363; c=relaxed/simple; bh=BEttsqLbcUyK3w162SKyOK745deef5Q2OPdj/eMcPrY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=euy1m41AZVSN3lL+FpIxW07RqdL3ywNYIPKUYfo1QmUtZSIcpjDz0z0oCvw+v+kf4YN+dCZS1G82wumLQiOQ5g4oACYUoFnrr7Jv/AjRZxpBCB816hba6p8N5+G6gezTVmsHc1ZfrAvEAKr4dgoZNZou3ZZ7kBi93kzrSGlOhTY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=a2+rNiR2; arc=none smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40P5wLPi008959; Thu, 25 Jan 2024 04:25:57 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PODMain02222019; bh=BbjFLNhhtTIKjqslX2nvALzEiP9LMfzdDYmUGzUJ0Ik=; b= a2+rNiR21VqtwVNavHO7edBek6kMKNtX26c1o55A/L6yBQuJnRNjkYfxgp2ndEeM 4V0KFgMbQE3ip9ueQDuaN4j8ZDQPbMZdxWUMV+M2y1q51Y/lMmO8J8mD9M0ATPxI dhR5oQFtM3gN0z8pPtNV1M0rh2LVBY3t5EtWW4MxwYzRrHmhVbYfgN5xblyCU3D0 7KeNbmqjvforCmvOUZigtS1TSSmXWBvVE9GaTOM04ca5n2TX/I/73Zg7mvSpPgvS pg5fcbuPOy91Q7WC7JJrS1yPKwC4jaWEbNVx7T1Smbyvenavp1rbtaSRPPKNhgKC drgYN5J5W37GrBH2mMkp7g== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3vtmf9t2gj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jan 2024 04:25:57 -0600 (CST) Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 25 Jan 2024 10:25:55 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40 via Frontend Transport; Thu, 25 Jan 2024 10:25:55 +0000 Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTP id 6BC77820248; Thu, 25 Jan 2024 10:25:55 +0000 (UTC) From: Charles Keepax To: , CC: , , , Subject: [PATCH v3 3/6] mfd: cs42l43: Use __u8 type rather than u8 for firmware interface Date: Thu, 25 Jan 2024 10:25:52 +0000 Message-ID: <20240125102555.2621736-3-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240125102555.2621736-1-ckeepax@opensource.cirrus.com> References: <20240125102555.2621736-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: 6X2tCGW-h7n2-mGCHK_b6qsl4yDSojIe X-Proofpoint-ORIG-GUID: 6X2tCGW-h7n2-mGCHK_b6qsl4yDSojIe X-Proofpoint-Spam-Reason: safe X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789059950409219483 X-GMAIL-MSGID: 1789059950409219483 __xxx is the preferred type for firmware interfaces. Suggested-by: Andy Shevchenko Signed-off-by: Charles Keepax --- Changes since v2: - Added commit message Thanks, Charles drivers/mfd/cs42l43.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c index 4e2bc5ad244a5..65a331481d975 100644 --- a/drivers/mfd/cs42l43.c +++ b/drivers/mfd/cs42l43.c @@ -55,8 +55,8 @@ struct cs42l43_patch_header { __le16 version; __le16 size; - u8 reserved; - u8 secure; + __u8 reserved; + __u8 secure; __le16 bss_size; __le32 apply_addr; __le32 checksum; From patchwork Thu Jan 25 10:25:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charles Keepax X-Patchwork-Id: 191956 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp1543542dyi; Thu, 25 Jan 2024 02:28:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IGLr+29Kl7lGnMYL65K5OUuKWog9FCQmDcH6imXvUhqYFkuD94ew4PJXZPJEWtIw6TaXdE7 X-Received: by 2002:a17:902:ce82:b0:1d5:8cbc:863c with SMTP id f2-20020a170902ce8200b001d58cbc863cmr1665002plg.27.1706178533909; Thu, 25 Jan 2024 02:28:53 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706178533; cv=pass; d=google.com; s=arc-20160816; b=pFxJNjyyJvxtSjqQUjXAO9MuhqM5siULWwZkdGchzMec+mZsVwpQWPMvk3CnjailkN UI6L6YS9TZzwBkLOfIKFzwRK/4uU5p5ALiwTx+2vwG12FnfRdc8r2gzzTPeujWBNxgfW w1R8RXcpvwubI2LopY+DD8h5fQKV5w/UqE5vS5wyCjHDXEkqwIdmTOjJj4YPr2YFmBKY v9Adtgo5Af6+cnyaKbeO8ASpJkD3BPi+VjGWKDtY1nW5tVKobLZAh/c3Ct0x5XkSkNEi HzuegR0J/iCsY//P4b0LaWvKusCjSDSW0vA5r1xDwaxO3eCsx7Zk7ulu64ynwwgnRnXu yxSg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=d9674b95+6fyGE2L2nKtZskhha/Bhx67EejM1M1FwsU=; fh=EuINIlqHtPbjwdS0CwSSvtI6U08+S5VrA/riIg2DViY=; b=vwPS+853NtrgSJ+KYux/MZNWkEYy+Y2XNJa3K7D8GMyHPBPxOrQQfBhU8Q/4H94PNt MzDPA9hV1jf35RJKnp6S/RjN1i5IaMIuq5Q37Yl3dr4ACiHiT9fVZDX76eP7WtigAMlO /A6VfdDcRy8y4U/nKSwYIwnlaHgufs2awtS/ATrmSyLiDoCikXBWelpLnGXmic2GhINn R+Dbd+lkZX2ifcBqKCuqO6J9LAhFdglMxVe0cXABHu4j20khNs/WZA6IswgWGv2yyzCH 6KBpiXgaToDSiyRW0Ro+Y0IpZGdGORby7mGMgqx8xANZldpWniGf8lr+fC4fn8rH9r16 zT9w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=Oyo6mKg5; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-38387-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38387-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id n9-20020a1709026a8900b001d5e6ef6e28si12815920plk.625.2024.01.25.02.28.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 02:28:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38387-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=Oyo6mKg5; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-38387-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38387-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E274328C68E for ; Thu, 25 Jan 2024 10:27:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5161F20326; Thu, 25 Jan 2024 10:26:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="Oyo6mKg5" Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AF201CA8B; Thu, 25 Jan 2024 10:26:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.152.168 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706178364; cv=none; b=X8EEK87jY8011MCvgAQNxyFMYohVZVVTs4Dq6rZoB877bPz4Vz2P882Lq0b4Bu0/CFC/iPb9VzzdmlotTVpylSgve0wEkGGIoXocrgew/lKKTJPuhP6g2CgoAFh+B3UK67d93/vwVNdcXcPkeR2NXpEXxnQtLArCgWUHH9cKIUM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706178364; c=relaxed/simple; bh=FhrQu4P7Pyl6ih2qG7uPBbK2EyAGBDkiGEBxb6FF2Rk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=f0WiQ8oq1svikWRv9sINw6R0qRQ6gLK/Ps1u2lxGknzIAMscO3qy0H6vqN9N0RxrAoRuy30DYNliY7Sjbzn3A6igj7Qzv4t7QljIcfe/uOlkKmzyLKt5nYsMDZNOwuIizkTk5RMugmIbZuHHtGB7LwsO39uefjvRjN/2oCSuQ4A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=Oyo6mKg5; arc=none smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40P5wLPj008959; Thu, 25 Jan 2024 04:25:57 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PODMain02222019; bh=d9674b95+6fyGE2L2nKtZskhha/Bhx67EejM1M1FwsU=; b= Oyo6mKg5fP9KoxpCnvB0XPEbBHfJ//GsZ95qpgHLW24nsa47R+gVLKAs00Y6ZhUl GKj5K67TVHLA6qE6k9yL+d80kF+Yz+XGA7g0S3bLXbUYoRi4K9HMB9AFQXuLNB+7 wEni8m9tjEY3Jg63gD4Odv9hlmZ2YYLMY2onlaqWN2m078LQJYjfVOrc/UOqZu/j TOHyNnp+fvPcMaIzU4Kc6foeCdeYPw008d8ZRHQIqzr3+087olzzqC+mXJNgF9q5 0l4PHwdAQ5muXxy7Nh9nggNqUv6SSlCQWWr5mYem9DKwIzaxwprX+Ig4kmxTG5Cd OqTgSjSVnwrNJRvba5k4UA== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3vtmf9t2gj-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jan 2024 04:25:57 -0600 (CST) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 25 Jan 2024 10:25:55 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.40 via Frontend Transport; Thu, 25 Jan 2024 10:25:55 +0000 Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTP id 77EC9820249; Thu, 25 Jan 2024 10:25:55 +0000 (UTC) From: Charles Keepax To: , CC: , , , Subject: [PATCH v3 4/6] mfd: cs42l43: Add time postfixes on defines Date: Thu, 25 Jan 2024 10:25:53 +0000 Message-ID: <20240125102555.2621736-4-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240125102555.2621736-1-ckeepax@opensource.cirrus.com> References: <20240125102555.2621736-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: 0nwn1clTtiwiEjDtc-rDNaR7d7MQtMje X-Proofpoint-ORIG-GUID: 0nwn1clTtiwiEjDtc-rDNaR7d7MQtMje X-Proofpoint-Spam-Reason: safe X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789057862864999897 X-GMAIL-MSGID: 1789057862864999897 Suggested-by: Andy Shevchenko Signed-off-by: Charles Keepax --- No changes since v2. Thanks, Charles drivers/mfd/cs42l43.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c index 65a331481d975..aea0f8f485785 100644 --- a/drivers/mfd/cs42l43.c +++ b/drivers/mfd/cs42l43.c @@ -27,30 +27,30 @@ #include "cs42l43.h" -#define CS42L43_RESET_DELAY 20 +#define CS42L43_RESET_DELAY_MS 20 -#define CS42L43_SDW_ATTACH_TIMEOUT 500 -#define CS42L43_SDW_DETACH_TIMEOUT 100 +#define CS42L43_SDW_ATTACH_TIMEOUT_MS 500 +#define CS42L43_SDW_DETACH_TIMEOUT_MS 100 #define CS42L43_MCU_BOOT_STAGE1 1 #define CS42L43_MCU_BOOT_STAGE2 2 #define CS42L43_MCU_BOOT_STAGE3 3 #define CS42L43_MCU_BOOT_STAGE4 4 -#define CS42L43_MCU_POLL 5000 -#define CS42L43_MCU_CMD_TIMEOUT 20000 +#define CS42L43_MCU_POLL_US 5000 +#define CS42L43_MCU_CMD_TIMEOUT_US 20000 #define CS42L43_MCU_UPDATE_FORMAT 3 #define CS42L43_MCU_UPDATE_OFFSET 0x100000 -#define CS42L43_MCU_UPDATE_TIMEOUT 500000 +#define CS42L43_MCU_UPDATE_TIMEOUT_US 500000 #define CS42L43_MCU_UPDATE_RETRIES 5 #define CS42L43_MCU_SUPPORTED_REV 0x2105 #define CS42L43_MCU_SHADOW_REGS_REQUIRED_REV 0x2200 #define CS42L43_MCU_SUPPORTED_BIOS_REV 0x0001 -#define CS42L43_VDDP_DELAY 50 -#define CS42L43_VDDD_DELAY 1000 +#define CS42L43_VDDP_DELAY_US 50 +#define CS42L43_VDDD_DELAY_US 1000 -#define CS42L43_AUTOSUSPEND_TIME 250 +#define CS42L43_AUTOSUSPEND_TIME_MS 250 struct cs42l43_patch_header { __le16 version; @@ -538,10 +538,10 @@ static int cs42l43_soft_reset(struct cs42l43 *cs42l43) regcache_cache_only(cs42l43->regmap, true); regmap_multi_reg_write_bypassed(cs42l43->regmap, reset, ARRAY_SIZE(reset)); - msleep(CS42L43_RESET_DELAY); + msleep(CS42L43_RESET_DELAY_MS); if (cs42l43->sdw) { - unsigned long timeout = msecs_to_jiffies(CS42L43_SDW_DETACH_TIMEOUT); + unsigned long timeout = msecs_to_jiffies(CS42L43_SDW_DETACH_TIMEOUT_MS); unsigned long time; time = wait_for_completion_timeout(&cs42l43->device_detach, timeout); @@ -561,7 +561,7 @@ static int cs42l43_soft_reset(struct cs42l43 *cs42l43) static int cs42l43_wait_for_attach(struct cs42l43 *cs42l43) { if (!cs42l43->attached) { - unsigned long timeout = msecs_to_jiffies(CS42L43_SDW_ATTACH_TIMEOUT); + unsigned long timeout = msecs_to_jiffies(CS42L43_SDW_ATTACH_TIMEOUT_MS); unsigned long time; time = wait_for_completion_timeout(&cs42l43->device_attach, timeout); @@ -603,7 +603,7 @@ static int cs42l43_mcu_stage_2_3(struct cs42l43 *cs42l43, bool shadow) ret = regmap_read_poll_timeout(cs42l43->regmap, CS42L43_BOOT_STATUS, val, (val == CS42L43_MCU_BOOT_STAGE3), - CS42L43_MCU_POLL, CS42L43_MCU_CMD_TIMEOUT); + CS42L43_MCU_POLL_US, CS42L43_MCU_CMD_TIMEOUT_US); if (ret) { dev_err(cs42l43->dev, "Failed to move to stage 3: %d, 0x%x\n", ret, val); return ret; @@ -652,7 +652,7 @@ static int cs42l43_mcu_disable(struct cs42l43 *cs42l43) ret = regmap_read_poll_timeout(cs42l43->regmap, CS42L43_SOFT_INT_SHADOW, val, (val & CS42L43_CONTROL_APPLIED_INT_MASK), - CS42L43_MCU_POLL, CS42L43_MCU_CMD_TIMEOUT); + CS42L43_MCU_POLL_US, CS42L43_MCU_CMD_TIMEOUT_US); if (ret) { dev_err(cs42l43->dev, "Failed to disable firmware: %d, 0x%x\n", ret, val); return ret; @@ -696,7 +696,7 @@ static void cs42l43_mcu_load_firmware(const struct firmware *firmware, void *con ret = regmap_read_poll_timeout(cs42l43->regmap, CS42L43_SOFT_INT_SHADOW, val, (val & CS42L43_PATCH_APPLIED_INT_MASK), - CS42L43_MCU_POLL, CS42L43_MCU_UPDATE_TIMEOUT); + CS42L43_MCU_POLL_US, CS42L43_MCU_UPDATE_TIMEOUT_US); if (ret) { dev_err(cs42l43->dev, "Failed to update firmware: %d, 0x%x\n", ret, val); cs42l43->firmware_error = ret; @@ -957,7 +957,7 @@ static int cs42l43_power_up(struct cs42l43 *cs42l43) } /* vdd-p must be on for 50uS before any other supply */ - usleep_range(CS42L43_VDDP_DELAY, 2 * CS42L43_VDDP_DELAY); + usleep_range(CS42L43_VDDP_DELAY_US, 2 * CS42L43_VDDP_DELAY_US); gpiod_set_value_cansleep(cs42l43->reset, 1); @@ -973,7 +973,7 @@ static int cs42l43_power_up(struct cs42l43 *cs42l43) goto err_core_supplies; } - usleep_range(CS42L43_VDDD_DELAY, 2 * CS42L43_VDDD_DELAY); + usleep_range(CS42L43_VDDD_DELAY_US, 2 * CS42L43_VDDD_DELAY_US); return 0; @@ -1057,7 +1057,7 @@ int cs42l43_dev_probe(struct cs42l43 *cs42l43) if (ret) return ret; - pm_runtime_set_autosuspend_delay(cs42l43->dev, CS42L43_AUTOSUSPEND_TIME); + pm_runtime_set_autosuspend_delay(cs42l43->dev, CS42L43_AUTOSUSPEND_TIME_MS); pm_runtime_use_autosuspend(cs42l43->dev); pm_runtime_set_active(cs42l43->dev); /* From patchwork Thu Jan 25 10:25:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charles Keepax X-Patchwork-Id: 191953 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp1543131dyi; Thu, 25 Jan 2024 02:27:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IGJwkhx6DLsdolQVP+ZRiUiWfSh2rEhFbvsPXt1vzmqctfA8sIT4M0LUyhAq8nBCWLFHlt1 X-Received: by 2002:a17:906:8db:b0:a2f:d15e:2385 with SMTP id o27-20020a17090608db00b00a2fd15e2385mr266551eje.37.1706178469488; Thu, 25 Jan 2024 02:27:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706178469; cv=pass; d=google.com; s=arc-20160816; b=GqbLiOvOuQs+SnqqCXXejMStT4UmVThtfLxVZRhMgK0QD7MkEO0qNWYOsxIqzPg2Yc HuwKpf7tXJ0QG6YiRT3qL4SGfxRJpPBoVM/zyhdYC0bTF+LfO9Qg6CX1MJLsw1nxclrF DT15//7G1KYYQhjXSSAGG4R5KttJjTnqOgc0R3KIxhQT7XG6HLnvdlhmZ7YTStrtERZ+ 1HG/fYWYTeU5mKgQ5TxTa+M1TQXbRNqHtn/BbLJeL83decz5YkFBrpKFUrUEIoZUBbkk EsJvjYvHDhfKrNyj5M3v4MY5V/rKcrsNuovl2b0QkNXXrAri+UdSIguLFm2aBNJXJjT0 s+Sg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=j90Mf6OkRSzIU7rEhMFiV0AA6YyW5HkH5qDLq7dYUq4=; fh=EuINIlqHtPbjwdS0CwSSvtI6U08+S5VrA/riIg2DViY=; b=GtXZQ+N5sXciL+mL303Lu+9xWwF9TOUvB8Q2e2GTAnR6VqJxl347vYNu2YOepqI7sD 4KJhFUZd8gGL64t8+FYODhJtKrY9pnnq9nEZp0D/nFlSS530Q/ilgNbanVqEoBAy45iJ b/IoOyk+c8owsrIhaXDS4E0rSkwlugYqsGdZt0TOjlbHW13FbY9i0Dzo0uMlhAeg4GrO ALX6pxXRUFM95Tnd6r3HzI0PdXAyWsKx6akktrLPxtvj09tCD8HfHdGfYmTI47l0BpH0 Xy/fP/rpWn5AgV9YcuVtXgwVugK166NJ+d886q4cFaM1zf21LBR2ODFiKN4PEX3WgsFa GlDA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=mxPiAgwQ; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-38388-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38388-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id n1-20020a170906724100b00a31857d7d7csi343035ejk.213.2024.01.25.02.27.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 02:27:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38388-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=mxPiAgwQ; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-38388-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38388-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1F79B1F21C8D for ; Thu, 25 Jan 2024 10:27:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2290620314; Thu, 25 Jan 2024 10:26:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="mxPiAgwQ" Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F7251CA8D; Thu, 25 Jan 2024 10:26:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.152.168 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706178364; cv=none; b=AvYDHaaVLKKGYuW+8rTBMG3JmecNKL1J8v3tKunreMThqRmJ6LxRWkqqsmNn5QC3qMm0hzYWWY7zbupmZgDQlAewqxITXQS8+vZgppQ1yP+Sc2cS9K7+qNtHzStWSq7kkdYD+o5oslVjjeo6KR+72oILxnIIxHL1b+/+JbrKi2s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706178364; c=relaxed/simple; bh=t62XeC0sIkJTMObk34vpixyT5zAm6lF6NKRpesJWxNU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jk96s0rMZQFJhs2+GkYL4IXIc4PLoRzVXfU5KwUH+zMhhbyFnZNP2MPk1fHD4+hNOUqLTWJPKWpJ9eM9gjwTPnH0JxBQF3BLcvZE463uFRXfITfN8hfPTSwsksECZ32Wric2RDpZdR6cgL7zgtylkaPbhMSXiPyBF27HRnGLMDE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=mxPiAgwQ; arc=none smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40P7paSP014010; Thu, 25 Jan 2024 04:25:58 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PODMain02222019; bh=j90Mf6OkRSzIU7rEhMFiV0AA6YyW5HkH5qDLq7dYUq4=; b= mxPiAgwQpqvEyYfZvyQworPmtBDUJOCe8K7VcV6qXNr4WVp8Fv+AWgsRErWGM8s2 sqiLagvUtCH+4biGI+wCNbisbZ0UhfFats4X53HdtlL2ZdWG8DCQXOy/N6ucNgmq m8NfkpaETBAmnzLIR8b9arUS4QQdnJxB4L21tRepPhIEh8MaQ0fdPjgExNrj6Xum 2zILntRMDJOp0cxtNPcibP4++rq79bh5hLA6pf/MtYxj/bN+R2p3wIBeD8OCAZCg Fs0qVCxnPCqhNk6tZh5CMHXCHUFb7YNmcMtPpV5rdvsXqnG49MDBZfDs55Rx+Ep8 QpdSsvj1+JjZoZrTvFqBPg== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3vtmf9t2gh-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jan 2024 04:25:58 -0600 (CST) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 25 Jan 2024 10:25:55 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.40 via Frontend Transport; Thu, 25 Jan 2024 10:25:55 +0000 Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTP id 84DDD82024A; Thu, 25 Jan 2024 10:25:55 +0000 (UTC) From: Charles Keepax To: , CC: , , , Subject: [PATCH v3 5/6] mfd: cs42l43: Add some missing dev_err_probe()s Date: Thu, 25 Jan 2024 10:25:54 +0000 Message-ID: <20240125102555.2621736-5-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240125102555.2621736-1-ckeepax@opensource.cirrus.com> References: <20240125102555.2621736-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: T9mzWiA5OUZ5Nu-OMIbXlIU_Uh41-Fey X-Proofpoint-ORIG-GUID: T9mzWiA5OUZ5Nu-OMIbXlIU_Uh41-Fey X-Proofpoint-Spam-Reason: safe X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789057794756481319 X-GMAIL-MSGID: 1789057794756481319 Use of dev_err_probe() was missed in the i2c and sdw parts of the code, update the missing parts. Suggested-by: Andy Shevchenko Signed-off-by: Charles Keepax --- Changes since v2: - Added brackets in the commit message for functions Thanks, Charles drivers/mfd/cs42l43-i2c.c | 9 +++------ drivers/mfd/cs42l43-sdw.c | 9 +++------ 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/mfd/cs42l43-i2c.c b/drivers/mfd/cs42l43-i2c.c index 7162274a0b551..c9e4ea76149a8 100644 --- a/drivers/mfd/cs42l43-i2c.c +++ b/drivers/mfd/cs42l43-i2c.c @@ -38,7 +38,6 @@ static const struct regmap_config cs42l43_i2c_regmap = { static int cs42l43_i2c_probe(struct i2c_client *i2c) { struct cs42l43 *cs42l43; - int ret; cs42l43 = devm_kzalloc(&i2c->dev, sizeof(*cs42l43), GFP_KERNEL); if (!cs42l43) @@ -50,11 +49,9 @@ static int cs42l43_i2c_probe(struct i2c_client *i2c) cs42l43->attached = true; cs42l43->regmap = devm_regmap_init_i2c(i2c, &cs42l43_i2c_regmap); - if (IS_ERR(cs42l43->regmap)) { - ret = PTR_ERR(cs42l43->regmap); - dev_err(cs42l43->dev, "Failed to allocate regmap: %d\n", ret); - return ret; - } + if (IS_ERR(cs42l43->regmap)) + return dev_err_probe(cs42l43->dev, PTR_ERR(cs42l43->regmap), + "Failed to allocate regmap\n"); return cs42l43_dev_probe(cs42l43); } diff --git a/drivers/mfd/cs42l43-sdw.c b/drivers/mfd/cs42l43-sdw.c index d6962a5a35f65..65f7b1d782486 100644 --- a/drivers/mfd/cs42l43-sdw.c +++ b/drivers/mfd/cs42l43-sdw.c @@ -171,7 +171,6 @@ static int cs42l43_sdw_probe(struct sdw_slave *sdw, const struct sdw_device_id * { struct cs42l43 *cs42l43; struct device *dev = &sdw->dev; - int ret; cs42l43 = devm_kzalloc(dev, sizeof(*cs42l43), GFP_KERNEL); if (!cs42l43) @@ -181,11 +180,9 @@ static int cs42l43_sdw_probe(struct sdw_slave *sdw, const struct sdw_device_id * cs42l43->sdw = sdw; cs42l43->regmap = devm_regmap_init_sdw(sdw, &cs42l43_sdw_regmap); - if (IS_ERR(cs42l43->regmap)) { - ret = PTR_ERR(cs42l43->regmap); - dev_err(cs42l43->dev, "Failed to allocate regmap: %d\n", ret); - return ret; - } + if (IS_ERR(cs42l43->regmap)) + return dev_err_probe(cs42l43->dev, PTR_ERR(cs42l43->regmap), + "Failed to allocate regmap\n"); return cs42l43_dev_probe(cs42l43); } From patchwork Thu Jan 25 10:25:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charles Keepax X-Patchwork-Id: 191955 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp1543326dyi; Thu, 25 Jan 2024 02:28:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IGkWUmAE7kKPf0+lUNpHDSAdgoH+90WzrJ7obtGttwTyS9QD12NKjcplOnKtcAfCNKRZkol X-Received: by 2002:a17:906:194a:b0:a30:1000:3c5a with SMTP id b10-20020a170906194a00b00a3010003c5amr271394eje.49.1706178502195; Thu, 25 Jan 2024 02:28:22 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706178502; cv=pass; d=google.com; s=arc-20160816; b=KKV4rF67axovl3joSBdou+K+zmlgEzqPHLAo8aV+gqXeijfAH1/ZGB+ESvHX7Nu39e mvTpFxR2B8IbEvnplxEOTLWppMuE8eoxxqIEynTPVx5rdqtFgzU6FKC/So3ds1F5ik+l O7zmnSSrJPKqZmfsiep8aLmxAxWO2Ye+pOVNOphM8l4PgYqgzemWHtJOTK8gEFJJnVYU 7KJE3FFbh2oKiW2OHWEULKBN3cs8Qah9tF3HDVPju8LkJ5H1fTWILbdDeIfQHYk+j7Cp WAN4zZ8ll8P1KDXO1frtClGSHwGFz0y5SA27LWNWJGvtNoGsB2AR1r0kEb/fCelefr9g EBEw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=FLv7KEn1hB6G5vu93/SxG16lAdj5fv2FDse9aetjLWg=; fh=EuINIlqHtPbjwdS0CwSSvtI6U08+S5VrA/riIg2DViY=; b=lTA8PXobfuW8RUjp841AMd/VxxuLXf4QL1z4JgObU3/qqxtvNH5Ib+MoqbgP3AJajt 8Lw/sQx0HQ5xpq15esJ8Xup35fSzLhePq39aTvyTSAW7GmorNuFXaFLfGMy5VUlco1Yk iCdkUR/rt56QLcdRYh0P7DcyidJ+vqwPOPxreaXi3zhG7NeLRgN7ZOLeVCh/JAiEEiMv 0YBkZQjlkZFOkELqM5pMkA7f8kg9CqfKEvY/YZC+oYt9/oGMzk3en81ab8GeBhFE2mtk UTMguYBrXVf9riVWCAAyg5We6pM4Z4OlFofC7oOkgPfvr5xJjbxGm8Ppdava8BTw+JBq wXTQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=UaIUHbnr; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-38389-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38389-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id t8-20020a170906268800b00a316274197esi668712ejc.701.2024.01.25.02.28.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 02:28:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38389-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=UaIUHbnr; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-38389-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38389-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C7AFC1F2206D for ; Thu, 25 Jan 2024 10:28:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B1419224CF; Thu, 25 Jan 2024 10:26:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="UaIUHbnr" Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 431FC1CA8E; Thu, 25 Jan 2024 10:26:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.152.168 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706178364; cv=none; b=mJutFWFHIivbCiAueR8iLhl0jmYLr3ELNvUdvZnTot9k/HTNWf4DTt5EJmI7DdGYNlrIdmWsy6QMfF3QELzIz8XN43fLup0XYuzHEgjxxS61CoZLF459tzqOjVnIB8h2PAoIF959vb3sIJf+XnhACYgWV4Ii2LKJZz5RwYcp8Nw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706178364; c=relaxed/simple; bh=w4dg95HncjAo56RiG38BZGd3Pzu7W8glNY+mUdjX5F0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ge/c2T+bOOjDaRpd6QTZv5EWC8VIJrE7G+76SraNZYK+T7pGXi5egpzY2yaEuWZwhszHiGEbbxIWya0+8qBhqhil1yBkB3QZBpl/lvFRnbSw+gl+Xne0lSVfH8cba6AIIlgLWS/EhlrV0leOXCqFphhmtDk48D5RZEhmPCAhxfY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=UaIUHbnr; arc=none smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40P7paSQ014010; Thu, 25 Jan 2024 04:25:59 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PODMain02222019; bh=FLv7KEn1hB6G5vu93/SxG16lAdj5fv2FDse9aetjLWg=; b= UaIUHbnrCAIrFSGmVpG13iFn+U/x+c5KTHL4uklV3VsGuXeGEmk1CwHE8a4wIjDJ 1mg6ufhYYtya5UK/mlSoIuxrJ9HUtXITzaUSGtaG5+BV0c+5swBCF0YKiyYt2jD9 bFTpEu4zymk8uOnH2FkUuaUmFRPrTGhUOoZ225ybXszMDZYjlCe6QE21sGLxo3Nl CDmbCESUa1S+gJi7AELWOvmdkE5BxMQ35VXAUeWyqJIgghv3HCdGpaz2hFnV8kQb IMOHaMkQiwApZOUvtWQcm+YRrNyfd7Ts4aD8H2mgHXiDO1H/rxUjnq/DI3Uyf6Lr 2gKUClBe1vdXEQtmZ+nEXg== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3vtmf9t2gh-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jan 2024 04:25:59 -0600 (CST) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 25 Jan 2024 10:25:55 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.40 via Frontend Transport; Thu, 25 Jan 2024 10:25:55 +0000 Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.14]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTP id 8785882024B; Thu, 25 Jan 2024 10:25:55 +0000 (UTC) From: Charles Keepax To: , CC: , , , Subject: [PATCH v3 6/6] mfd: cs42l43: Handle error from devm_pm_runtime_enable() Date: Thu, 25 Jan 2024 10:25:55 +0000 Message-ID: <20240125102555.2621736-6-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240125102555.2621736-1-ckeepax@opensource.cirrus.com> References: <20240125102555.2621736-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: nE-1YVLqE_zLrdwjYugUTb51CZuhJ-UK X-Proofpoint-ORIG-GUID: nE-1YVLqE_zLrdwjYugUTb51CZuhJ-UK X-Proofpoint-Spam-Reason: safe X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789057829244758120 X-GMAIL-MSGID: 1789057829244758120 As it devm_pm_runtime_enable() can fail due to memory allocations, it is best to handle the error. Suggested-by: Andy Shevchenko Signed-off-by: Charles Keepax --- No changes since v2. Thanks, Charles drivers/mfd/cs42l43.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c index aea0f8f485785..56bd9dbbe10b0 100644 --- a/drivers/mfd/cs42l43.c +++ b/drivers/mfd/cs42l43.c @@ -1065,7 +1065,9 @@ int cs42l43_dev_probe(struct cs42l43 *cs42l43) * the boot work runs. */ pm_runtime_get_noresume(cs42l43->dev); - devm_pm_runtime_enable(cs42l43->dev); + ret = devm_pm_runtime_enable(cs42l43->dev); + if (ret) + return ret; queue_work(system_long_wq, &cs42l43->boot_work);