From patchwork Thu Jul 21 01:41:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Pan2 via Gcc-patches" X-Patchwork-Id: 87 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e252:0:0:0:0:0 with SMTP id bl18csp1224686wrb; Wed, 20 Jul 2022 18:44:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t3BY/G2OpzMO19gj3AQ4ruLOKTdwiUA8p1sx5DRU5Tn2YajLLDgA+mWQNnCpouZl/WvWI2 X-Received: by 2002:aa7:d955:0:b0:43a:7241:4cf9 with SMTP id l21-20020aa7d955000000b0043a72414cf9mr52415274eds.247.1658367886223; Wed, 20 Jul 2022 18:44:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658367886; cv=none; d=google.com; s=arc-20160816; b=Igxaya3A9DqJVqJW5E1a5ynOX3XJud9LbNuQifAWr0JdEAFVPFKkZ8+HZaMqSmdlK/ 9hFkeyEQwREUM7VDMJI4nR6GTR+IF0NaEvlB+xhux5qQBLpFcQDskylDB3In3HitzknC 6QvQkfDic6ozU37xwp0OZo2Rgtq636XdgXLqileteXIan8VqhQmEwAT/vxcye1/EgJ32 ToCQ+5yHkd5N2pR4ma/XIIWqpqHOwecWR3x6G9wzixjaSQKWgvOZMaD6HMPVe2oKYkoX 3ZS4FdGaScIsCTjdoX7tnALrGGP9ZQiNsJrjhQkV1tUqywa1w4rK+FRh5v4LjCtjnJe/ AD9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:to :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=stD6PddxDGVYipXWTL8mJ3HpWKRzfqzKcs76y/kegSk=; b=nW3zqf05YfgG1t7qD0hH+JWgKKlbMOKUrN4Ih6JsyNk9R3wKHFT95ZIETTatCQ1J5x bwkRcTT71oOc3GkeU5Q8m1AviECxtEUIo5HaNzKKrYRpQSJbW5fr8txME1W+ZMDqos6o WmQF2ap7RH7eFmqRBM0OIo+K4y5cGcgilGbmJp1YZb4rtj8x66+6GD5awizi+zS0uD39 n1pzdRkVDloOAA2LOtmeLO5jjTfarrL7Upv9cbrani/rH+tYYtOFiiSE4ZZfJAyRjsx3 xnVfJTLw+Hnry6+rfygMgB5pzXTUshnQFarBsFZ6JSiwVKMQMaVz+K7jkHCPWpMjvStW gGiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=EDwrEczU; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id la2-20020a170907780200b0072b76566462si834723ejc.459.2022.07.20.18.44.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 18:44:46 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=EDwrEczU; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A6C55383583C for ; Thu, 21 Jul 2022 01:42:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A6C55383583C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1658367743; bh=stD6PddxDGVYipXWTL8mJ3HpWKRzfqzKcs76y/kegSk=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=EDwrEczUcsWDG6R2NHP6AmIE6GXJCYnIco5ibJ8DfAaxM1HLxSZsQz9+wGJ5jVfQz ixNHo7Gyt3cC5Voc/BoJQJGVyiLWqENSR/bPySzlEIfbomwFkFQi+QxcgsrdlWeE7f vCn691pUet/mG+F9wTQH6steHUrHWxhB+0f1YIkc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A8534385141D for ; Thu, 21 Jul 2022 01:41:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A8534385141D Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-645-Y9Py6SxNOfiw473IJWxcVg-1; Wed, 20 Jul 2022 21:41:37 -0400 X-MC-Unique: Y9Py6SxNOfiw473IJWxcVg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1689C101A588 for ; Thu, 21 Jul 2022 01:41:37 +0000 (UTC) Received: from t14s.localdomain.com (unknown [10.2.16.236]) by smtp.corp.redhat.com (Postfix) with ESMTP id E7880400DFD7; Thu, 21 Jul 2022 01:41:36 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [committed] analyzer: fix ICE on untracked decl_regions [PR106374] Date: Wed, 20 Jul 2022 21:41:26 -0400 Message-Id: <20220721014126.1506851-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Malcolm via Gcc-patches From: "Li, Pan2 via Gcc-patches" Reply-To: David Malcolm Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1738924764383862774?= X-GMAIL-MSGID: =?utf-8?q?1738924764383862774?= Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r13-1773-ga6c192e80a87ef. gcc/analyzer/ChangeLog: PR analyzer/106374 * region.cc (decl_region::get_svalue_for_initializer): Bail out on untracked regions. gcc/testsuite/ChangeLog: PR analyzer/106374 * gcc.dg/analyzer/untracked-2.c: New test. Signed-off-by: David Malcolm --- gcc/analyzer/region.cc | 5 +++++ gcc/testsuite/gcc.dg/analyzer/untracked-2.c | 7 +++++++ 2 files changed, 12 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/analyzer/untracked-2.c diff --git a/gcc/analyzer/region.cc b/gcc/analyzer/region.cc index a8d1ae92deb..b78bf4ec1b7 100644 --- a/gcc/analyzer/region.cc +++ b/gcc/analyzer/region.cc @@ -1152,6 +1152,11 @@ decl_region::get_svalue_for_initializer (region_model_manager *mgr) const if (binding->symbolic_p ()) return NULL; + /* If we don't care about tracking the content of this region, then + it's unused, and the value doesn't matter. */ + if (!tracked_p ()) + return NULL; + binding_cluster c (this); c.zero_fill_region (mgr->get_store_manager (), this); return mgr->get_or_create_compound_svalue (TREE_TYPE (m_decl), diff --git a/gcc/testsuite/gcc.dg/analyzer/untracked-2.c b/gcc/testsuite/gcc.dg/analyzer/untracked-2.c new file mode 100644 index 00000000000..565a9ccd58e --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/untracked-2.c @@ -0,0 +1,7 @@ +typedef unsigned char u8; +extern int foo(const u8 *key, unsigned int keylen); +int test (void) +{ + static const u8 default_salt[64]; + return foo(default_salt, 64); +}