From patchwork Tue Jan 23 08:04:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xi Ruoyao X-Patchwork-Id: 190765 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp184456dyi; Tue, 23 Jan 2024 00:05:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IFBvafDudUnoFF2NgHQI5thReK8xDcbf/7XJzRjlh+30dNHNl1Aeo4g+3M2JwZhEThG9bfX X-Received: by 2002:a81:4883:0:b0:5ff:9a11:ac01 with SMTP id v125-20020a814883000000b005ff9a11ac01mr4381521ywa.64.1705997142765; Tue, 23 Jan 2024 00:05:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705997142; cv=pass; d=google.com; s=arc-20160816; b=HzqTlQg6u/AfYX9kcrpvctxutaLP/QlYQ/4NxcEbP9MOxM1btlM1E0j7izCUyAzpjA bKxSy8cI8GmF7A9LL4AhV5HJEjfP5HrHvU5QrbwYXuwuq1aY80xhsVtNdWjjkri+DTFg KAywpCDtUDIAO+X43k9btAsQkZ+vZCUMu4Qg804haryy50r3cahmFheRK6Q+h9b4aCAs lTLdbQuHAqrUyG46KTttvres/qKvfmiAZ8gdcT41HHkWwRU0dSdsLLnX6hdjvWYUHWHo m21snxShoZ9xdgosARy+7e4dmdBEgfE1vWdfUeaOxz25Jz2Iycb30SKWyWx86FFnDvEz nmSg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:user-agent :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=1r6o79ZW/fpT0aorT10il5asWQZujzVB5XHMCQ2GRAA=; fh=+9kxGh0CcBWQ+enVdk8/mEVAmiNyjykPtMxFHpxcXV4=; b=rU3MOnJw1A/wK8gakon5/eWh0eTIViZpTG9Z5+WzNeeSwpOjQNuILYXJJUn9krDNv+ mgBBlUD1IosVWf7kn0q9i9Q7cFX+5hWNY9ZWNEoFSLb2vMjfI3MMr4cf/cLg+FhOdGnJ 3cf1nKCtGfgchKy2JWv4tFcdu+boMFeh6A3moa1kK/FKtAz1oDQ3M3M59TlEhKT+T20n T4Z8ZQmGs+HQaurAOAMgK4aolv7lISABW0gVK93wx0drzIb7dlo8f0LDvhWhy1kX5LVO jgUp6uKXSqqV7xDuNKyvXjnXTWn/WysCwEm2zw0eSmjs6n6VnHI3UAkepKcS4AV4julD wHbw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@xry111.site header.s=default header.b=HNaJxrUF; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=xry111.site Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id x1-20020a0ce241000000b0068178184b48si7539336qvl.70.2024.01.23.00.05.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 00:05:42 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@xry111.site header.s=default header.b=HNaJxrUF; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=xry111.site Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 74A503858C50 for ; Tue, 23 Jan 2024 08:05:42 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 73D483858C5E for ; Tue, 23 Jan 2024 08:04:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 73D483858C5E Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 73D483858C5E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705997095; cv=none; b=nYLeejp9EyqRh2NIG5jwW4R9X9GaM4tLi+gaIeiKLMgR4RlHd4aCtbAdMEq6EtIsKG1+W0/3JAfjhW72TJuG0Anljdx7o13pUu76C0KA1JXrIMRMnzQLNSOV3Lttk4Jk4EsSsAui20l8ODAKAhfUxvaTCzityStYGFyyNFwjYA0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705997095; c=relaxed/simple; bh=d8B0+7BO27M6S2rXp4lhn1G4uYqtBDxR87GCvUgeOA0=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=VUAGZFgvL+9w61CDX2miXbodfDueyK5kkd0NhunCHdgO1ieEtKKCcWpTyINWoYvdsEWRRCvuhmlj5IrZx9GVmHl0PPfG3gIItT7XYwTgvTTceKqzH83rANnH/Y/HBemOoPf9OZUxgvd4/RbvWL/167LxAM5K00yRZ6NdeGJrsNM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1705997082; bh=d8B0+7BO27M6S2rXp4lhn1G4uYqtBDxR87GCvUgeOA0=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=HNaJxrUFUtspgAqz16ziFZlYTf88uebQIA5YihXlsePF8+vbv/njVyB01SMtCxUat hJVVKdFkPjA3OlloC+IimMOu1Ya49KNxo4H8bTcTNiaTi+A6xbEEaqu4lOqsVYxsu4 wfHDDFWX6vkSWjVbd+U98F/11P9JOIx7hGPBGNjo= Received: from [IPv6:240e:358:119a:ce00:dc73:854d:832e:2] (unknown [IPv6:240e:358:119a:ce00:dc73:854d:832e:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 24B5B659AD; Tue, 23 Jan 2024 03:04:37 -0500 (EST) Message-ID: <9195928af9ccbb86380fffdc41aefebc25001a04.camel@xry111.site> Subject: Pushed: [PATCH v2] LoongArch: Disable explicit reloc for TLS LD/GD with -mexplicit-relocs=auto From: Xi Ruoyao To: chenglulu , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn, mengqinggang@loongson.cn Date: Tue, 23 Jan 2024 16:04:26 +0800 In-Reply-To: <57ed21bf-3aea-f45e-6181-4de3d7c5e72b@loongson.cn> References: <20240122184259.1153112-1-xry111@xry111.site> <57ed21bf-3aea-f45e-6181-4de3d7c5e72b@loongson.cn> Autocrypt: addr=xry111@xry111.site; prefer-encrypt=mutual; keydata=mDMEYnkdPhYJKwYBBAHaRw8BAQdAsY+HvJs3EVKpwIu2gN89cQT/pnrbQtlvd6Yfq7egugi0HlhpIFJ1b3lhbyA8eHJ5MTExQHhyeTExMS5zaXRlPoiTBBMWCgA7FiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQrKrSDhnnEOPHFgD8D9vUToTd1MF5bng9uPJq5y3DfpcxDp+LD3joA3U2TmwA/jZtN9xLH7CGDHeClKZK/ZYELotWfJsqRcthOIGjsdAPuDgEYnkdPhIKKwYBBAGXVQEFAQEHQG+HnNiPZseiBkzYBHwq/nN638o0NPwgYwH70wlKMZhRAwEIB4h4BBgWCgAgFiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwwACgkQrKrSDhnnEOPjXgD/euD64cxwqDIqckUaisT3VCst11RcnO5iRHm6meNIwj0BALLmWplyi7beKrOlqKfuZtCLbiAPywGfCNg8LOTt4iMD User-Agent: Evolution 3.50.3 MIME-Version: 1.0 X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, KAM_STOCKGEN, LIKELY_SPAM_FROM, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788867659941519506 X-GMAIL-MSGID: 1788867659941519506 On Tue, 2024-01-23 at 10:37 +0800, chenglulu wrote: > LGTM! > > Thanks! Pushed v2 as attached. The only change is in the comment: Qinggang told me TLE LE relaxation actually *requires* explicit relocs. From f12317306ee714aed0ca7ed01cafa520296b4c4c Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Mon, 22 Jan 2024 18:07:42 +0800 Subject: [PATCH v2] LoongArch: Disable explicit reloc for TLS LD/GD with -mexplicit-relocs=auto Binutils 2.42 supports TLS LD/GD relaxation which requires the assembler macro. gcc/ChangeLog: * config/loongarch/loongarch.cc (loongarch_explicit_relocs_p): If la_opt_explicit_relocs is EXPLICIT_RELOCS_AUTO, return false for SYMBOL_TLS_LDM and SYMBOL_TLS_GD. (loongarch_call_tls_get_addr): Do not split symbols of SYMBOL_TLS_LDM or SYMBOL_TLS_GD if la_opt_explicit_relocs is EXPLICIT_RELOCS_AUTO. gcc/testsuite/ChangeLog: * gcc.target/loongarch/explicit-relocs-auto-tls-ld-gd.c: Check for la.tls.ld and la.tls.gd. --- gcc/config/loongarch/loongarch.cc | 10 +++++----- .../loongarch/explicit-relocs-auto-tls-ld-gd.c | 3 ++- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/gcc/config/loongarch/loongarch.cc b/gcc/config/loongarch/loongarch.cc index 82467474288..072c68d97e3 100644 --- a/gcc/config/loongarch/loongarch.cc +++ b/gcc/config/loongarch/loongarch.cc @@ -1970,11 +1970,11 @@ loongarch_explicit_relocs_p (enum loongarch_symbol_type type) { case SYMBOL_TLS_IE: case SYMBOL_TLS_LE: - case SYMBOL_TLSGD: - case SYMBOL_TLSLDM: case SYMBOL_PCREL64: - /* The linker don't know how to relax TLS accesses or 64-bit - pc-relative accesses. */ + /* TLS IE cannot be relaxed. TLS LE relaxation is different from + the normal R_LARCH_RELAX-based relaxation and it **requires** + using the explicit %le_{lo12,hi20,add}_r relocs. The linker + does not relax 64-bit pc-relative accesses as at now. */ return true; case SYMBOL_GOT_DISP: /* The linker don't know how to relax GOT accesses in extreme @@ -2789,7 +2789,7 @@ loongarch_call_tls_get_addr (rtx sym, enum loongarch_symbol_type type, rtx v0) start_sequence (); - if (la_opt_explicit_relocs != EXPLICIT_RELOCS_NONE) + if (la_opt_explicit_relocs == EXPLICIT_RELOCS_ALWAYS) { /* Split tls symbol to high and low. */ rtx high = gen_rtx_HIGH (Pmode, copy_rtx (loc)); diff --git a/gcc/testsuite/gcc.target/loongarch/explicit-relocs-auto-tls-ld-gd.c b/gcc/testsuite/gcc.target/loongarch/explicit-relocs-auto-tls-ld-gd.c index 957ff98df62..ca55fcfc53e 100644 --- a/gcc/testsuite/gcc.target/loongarch/explicit-relocs-auto-tls-ld-gd.c +++ b/gcc/testsuite/gcc.target/loongarch/explicit-relocs-auto-tls-ld-gd.c @@ -6,4 +6,5 @@ extern __thread int b __attribute__((visibility("default"))); int test() { return a + b; } -/* { dg-final { scan-assembler-not "la.tls" { target tls_native } } } */ +/* { dg-final { scan-assembler "la\\.tls\\.ld" { target tls_native } } } */ +/* { dg-final { scan-assembler "la\\.tls\\.gd" { target tls_native } } } */ -- 2.43.0