From patchwork Tue Jan 23 01:12:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 190679 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp77524dyi; Mon, 22 Jan 2024 18:15:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IEKZ8zIglb7eD9dWwxA4Elp6U7Cw6WsuDER44hTdjmTgalwvxH1VFCxgrXDtq/bJ4v/rOEo X-Received: by 2002:a05:6808:150c:b0:3bd:bf17:7b6f with SMTP id u12-20020a056808150c00b003bdbf177b6fmr1494673oiw.103.1705976156155; Mon, 22 Jan 2024 18:15:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705976156; cv=pass; d=google.com; s=arc-20160816; b=0aoRm0w2uxU/PTfqaV04/GKIQAIbnAx1VzYT7dL8PmzeA3N+SkhxPjFH2vcZnZR7hu q/juRKZa0nMQTDebAsi++bD4ydhdHs0jMJgIrh70lr42QxstDMySnTPXah+D0XqgqayT tW5Lm85wLjvE+Owor0/K/CxTDB5RqbRsK40sgnkyz+mkeoMhD0t67NE1YjaHKQs16Doo 7Ff0MrmzxRqbBwCHrao7iToSO1k2nlk0VB7HeUFuH9pAeZBGCmw6f1Y9xeixKQxEDf3g ZZnMoCFVxusN+E0kKR9l5FJhmksvO3Wy4Dr1P2c2wjQZ96OC8x/8eY2TTDKt+q0CuEJH obgA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=4qH9Rf/zd/bFfsFZBAS2bb+VGZ3TWvzsYRdk9oqlfHE=; fh=yF5U1GmJjmIITk3FixChnC1fGe/u2uiGs8ZXY4LRXSE=; b=LifjBjYEw+JboKPGPHd/P9OXFS1fK5REyn/VUAqrJRNojYdxdGg+QX7TjX4YKN9MKg vQ/esOH/gzkO2PwJfsjh0Yw3bm9oFH6d8pTyFpzJVQGgjJJsi4TgM6M7WQUYjRhUbmng R6tqSTkvg74m7QUc5zPyGS1f9C65h2z/edTYtSWPNIX8Trtqe/Q49SjUXta9zzkv8/im QxIQDlTcWQG1372qUGqJi8UVwReQF75cIaETI6AWdvzJOr65g1LsBOpWxPiJSrQiTH8F /Lc8Ec+a6x23QHc9xBPxsDn/HCNehVZ6Mi2t3u3D+RodAHm84SsfyvrY8tM2NgSWyl/w y49A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=azrXpgIF; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-34576-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34576-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d3-20020a634f03000000b005cf94b8d9ddsi9196115pgb.869.2024.01.22.18.15.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 18:15:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-34576-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=azrXpgIF; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-34576-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34576-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 899A928E74A for ; Tue, 23 Jan 2024 02:10:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E672779DB; Tue, 23 Jan 2024 01:12:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="azrXpgIF" Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C87813C2D for ; Tue, 23 Jan 2024 01:12:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705972340; cv=none; b=hcv91yTSXjkDEy2VtqtUiEeyJO6b8ok6MtKJnX0Z3Iu70GYtLzyFoqzMSPFh8vK7FTHLjTxGgQbCYmFX5k9kVMCcRw3uOagksWlO8qJxfpTfYQL4sGJsMfQPteFULlkL0H/AAAFFlCT9nilbVlZkgw3t5n9IFjpKAIffQPFl3zs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705972340; c=relaxed/simple; bh=ZCXYUvRq5QkiujopZKa+oos+1nywJjGYg1IVAwcoHTU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=I5NBWUV4nfIzg+rm24NTh1hGSJituoSHO/TxSHD23lvKY7AKpbqrhYsxsYaqEr+7VCtAe5w5LqpXt/wkvQbfyTCggQpI0x53/GRKG7dI/sDtLVBqyDE0yWs6x/GVYS20E276Z+UZA7cPuVH/Uzg7y8dZU/65jTyIIrMNhnotEDg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=azrXpgIF; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1d71e184695so13662825ad.3 for ; Mon, 22 Jan 2024 17:12:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1705972338; x=1706577138; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4qH9Rf/zd/bFfsFZBAS2bb+VGZ3TWvzsYRdk9oqlfHE=; b=azrXpgIFgYmpAZoHosPXfQs6o5/SdrzwyLtUcLQGxUeLgcsnZZrRdiBvbiwfIvLEQs ++Y53QfJVQxjUAGAfEGaDiMrH7HeIbn/dov+75CX7DGdpRg3WhvWrDEIRx60tU1zK7rT +iJkRZrQK5CKqAPFk68AzoB//EiuzXhLcXRyo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705972338; x=1706577138; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4qH9Rf/zd/bFfsFZBAS2bb+VGZ3TWvzsYRdk9oqlfHE=; b=Lrgoyse8Nc5OtrupdMH8E16i9GTDIsDqs2jUQOTpxUbipVZKJsC3Hw6SOF4vcr/cH/ x58khXrWjkOdwN8YgZdlv9bsjqAm5xFeyXK1wCpQERJwt/Qx1w2jTlrTkv4qItPdM5b+ dR16m94hByj2i6whUjiU83BbU5kZBLXDpZ0JXcM/KN+AqGj2EQioyEVUduBS4sURRbzZ dZH2nEpSkPF59By1OchDIEFBcyHhxHebnjcUuWlfMqvjfFWcKI6uwh2FG3iSVFrPr+P7 U7xAyVwYjjd2IsLouze5sx+Iz4X4Ka/Daa0jl/873j5+jSBY3+Ai4dLBJm7K2BDdOLZ5 J+cw== X-Gm-Message-State: AOJu0YxTa6ZV7dqscKsO6oymmFbNSJIMbNU0hq9hfppz92ZBny203ctt po3qr33SEF8WOjxA8bCkEb1fSJK+hgkSQyA6jUnp0Xiet0kBYWX690jL07IGEw== X-Received: by 2002:a17:902:da91:b0:1d7:4e2:592b with SMTP id j17-20020a170902da9100b001d704e2592bmr3161029plx.103.1705972338231; Mon, 22 Jan 2024 17:12:18 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id w2-20020a170902c78200b001d71f10aa42sm5968938pla.11.2024.01.22.17.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 17:12:16 -0800 (PST) From: Kees Cook To: "Russell King (Oracle)" Cc: Kees Cook , Ard Biesheuvel , Wang Kefeng , Ben Hutchings , linux-arm-kernel@lists.infradead.org, Russell King , Hugh Dickins , Andrew Morton , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH] ARM: fault: Add "cut here" line for prefetch aborts Date: Mon, 22 Jan 2024 17:12:15 -0800 Message-Id: <20240123011211.work.227-kees@kernel.org> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=935; i=keescook@chromium.org; h=from:subject:message-id; bh=ZCXYUvRq5QkiujopZKa+oos+1nywJjGYg1IVAwcoHTU=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBlrxJuxQakNaOdgA1fbKkrd9nBEjS8Bl0aB6r2y 6AtqY38AQuJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCZa8SbgAKCRCJcvTf3G3A JnRTD/91aoq4t5Oh+w4+1avUipu20D+yzeP9E3R7zVZG/KmQyCAFUSLowG/5ggQFVkv7TN8Wit9 ZGNlfOuX8hBK0yLB6hYBGfOoHcsh1Gn7bcwBK6V5HkupzaTohUCDm28WaRM4GPvyx+Lt0sk9A6g 6HAcuu0GvPgX6ZpMW3G+OYfqnrXC+oDXw1JoWSZ6ByS0H3SiQBO1/3sspw9IPDLcxcce8B5/1dz 7lZ+PhKbqJ0ZUh+DmdS4UVbOrtzf9bFsdKAMO5NthlwHeeEDPtwbDYqqqRhyfikfds/k0jrcyYw mj8r4Ckh93ofW3TTufuvqoiLToS0cQ4joPsbbgKTnwBLQnu/Sovm1SV+2qPeG8CSrylxToPn66c VJUZjaLhI+vzE8HHhwfOqOtFIAC4d2uqY0lZu/tXbS0Jf4sWTNDr9R3DVlvsJ035PhLX7Jzfzt6 /yboV6QecaqFRqw2aPFwYL8F4LFLXCgrDrmms6oYk/+ibyVeOxxt0HAcZK1/C9pF1AAn5CBW+sD QZP/hxPvayNBRU2hgWSFhZCrPEm6Aa4GoXsGIqiMVQHMy1peVqURo24q89XsgK4LOQ9+HVURGJk WHNO5Xzhzh6evN0gwT+E+cf/LPul96AgTHVfftpVQLe/5AibJkCWT4fDM8VYAc/kgvx71nzhZEh ZZiuYLDe 2RO/4pw== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788845653412905194 X-GMAIL-MSGID: 1788845653412905194 The common pattern in arm is to emit a "8<--- cut here ---" line for faults, but it was missing for do_PrefetchAbort(). Add it. Cc: "Russell King (Oracle)" Cc: Ard Biesheuvel Cc: Wang Kefeng Cc: Ben Hutchings Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Kees Cook Acked-by: Ard Biesheuvel --- arch/arm/mm/fault.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c index e96fb40b9cc3..e804432e905e 100644 --- a/arch/arm/mm/fault.c +++ b/arch/arm/mm/fault.c @@ -586,6 +586,7 @@ do_PrefetchAbort(unsigned long addr, unsigned int ifsr, struct pt_regs *regs) if (!inf->fn(addr, ifsr | FSR_LNX_PF, regs)) return; + pr_alert("8<--- cut here ---\n"); pr_alert("Unhandled prefetch abort: %s (0x%03x) at 0x%08lx\n", inf->name, ifsr, addr);