From patchwork Mon Nov 14 17:03:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 19933 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2255063wru; Mon, 14 Nov 2022 09:05:40 -0800 (PST) X-Google-Smtp-Source: AA0mqf5xyAUiRD5XSEJWBABfJa4u9YQGs+qy30dwk8T8dVZBWdn15XnuLBesJC2UxX78hoRC47ld X-Received: by 2002:a17:90a:4310:b0:20b:22fb:2ef with SMTP id q16-20020a17090a431000b0020b22fb02efmr14741361pjg.158.1668445540145; Mon, 14 Nov 2022 09:05:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668445540; cv=none; d=google.com; s=arc-20160816; b=o2oeXwMxzylEKEvoyQ0j68ccLEt4jcStzNKqoePgEepv2ugKYBYR5IyvXGrCF3kprX I237V8QXMv8uXP6fPQLwd5osymP5nUQ76Mz2Cb1PAVmKlZlkqIBU1U1MYc4Zm5maPSwR ZWrOPlcFRdOgJaegLZwDHvlllimNumu/9qNb8awg1lk31UN3qlQpjD6R4hg0DYDHipGs bHrMWmT/D1zelV+UxpwkYmBeeCTrnUnTtA7G4mIlJX8G87kEnPXgq8RBvIrnBkdnZuNh cZhnYw/O8QiL/4uwhglilf+ECLuLkvrFVlj3bYWN+gasPYL8aTVUNIrFT+vZwQ1QH091 17FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=pD8Jn9+GurJEYfPsp17CSsQyybI00eab/WVHKrv8CWo=; b=gCoS4kkGyE4Nmk+B31MBcZu1SBvE2NLCyV9lgIJjJ110h2shYcdfndJTHtIMYM3Fhr q4WLrLMZ9xEdOZ5Tah6Ov5T847sUHs89BZtpQ15oak6ilOtWvU/iCdeSPEMqd8bkj+8D XTevJIwHpHrpmxAfvE5tetmQJuIe1/yce4XWevZXkBYxg1dr9jgaRsrS46h+oHkIM/ZF uLoq9TQeZOot3+d2dvK/PWmqa5XnZIHNYXMRWCimVNLXW77XXcdQes4akwCp04saxMSP wlAjWn+C0E+Mq84MiHMGU0Uhmxg2miiOCDw28Mo4UF2Kn7r0ygC4ZT00eK9fUZ1l0OH+ nkBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=MbBwljAg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g69-20020a636b48000000b0042af7555d10si8306055pgc.862.2022.11.14.09.05.23; Mon, 14 Nov 2022 09:05:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=MbBwljAg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237820AbiKNRDX (ORCPT + 99 others); Mon, 14 Nov 2022 12:03:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236399AbiKNRDV (ORCPT ); Mon, 14 Nov 2022 12:03:21 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AAAE216; Mon, 14 Nov 2022 09:03:20 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id p16so7915737wmc.3; Mon, 14 Nov 2022 09:03:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pD8Jn9+GurJEYfPsp17CSsQyybI00eab/WVHKrv8CWo=; b=MbBwljAg07T3h7qjUGqcGJp9iCgCOdI4/eXelF/C8ZVwneKKInAPiHFVNlj5Nd+xub Si8/71mjU8wqlMmbgHzeD+Vya1R2XkH2j9SLIz+tHRyoIrZmpayAxumf3BfrRT5mQOoM BcD3YycGtW58E3SZ81zImd1neXPA12BQCTv0J647EJkNFMaKcRL6pb+8tjWV5RYfVIO8 G6hYThU880TzTTA5RH5i6XkoKTNx9HHEexOqbhsG21SAe1ILNjdV+/TeHCLSidYQENnO NkWSrnTvyf3Lw2c1DGZn3V5W2/fpTMME9jGcHFYZ3XdBFbLMP/POH3uTIAjTNfMxrM4j ov3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pD8Jn9+GurJEYfPsp17CSsQyybI00eab/WVHKrv8CWo=; b=XhAcQ45FV8pBi539oCqkRrXjfkbTDFITnF55/MnD/5qM99Q1itBiybbYUHUkCjTF+h PZ2Zvp9KLZdFi6lb1Lg2tjCQ3dXZ6hADGF62JWMy/t+gC7cbOUbFh3x+WqMfMA7YBp+9 6QogagMI6cgP0MOfKrsjFSYrPCJI4qVGKl0FkCX2R3djUjp2tyFJ8UMFIMVpsdo8y6w/ JryzgbjiuuPoLIaX4yM8NJis3ROAEHlx6235i557VTVv1fMWenWf/BFD+RxT74THR/6Z CPyzDzeqFS7Nmr/jilLExUiAhFbe/E2vk45hvbYspKx3HG72Im3rfFr2zurvdR8mJDvj pqag== X-Gm-Message-State: ANoB5pkdhVH6E3vqeqjaIUqRQhV8hbCSa60j56fThbPJcNtDapG91k0+ hq/5CAzGWuRyLz7pAWaTRO8= X-Received: by 2002:a05:600c:1d11:b0:3cf:a6eb:3290 with SMTP id l17-20020a05600c1d1100b003cfa6eb3290mr8819977wms.116.1668445398637; Mon, 14 Nov 2022 09:03:18 -0800 (PST) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id e12-20020adffd0c000000b00236576c8eddsm10217840wrr.12.2022.11.14.09.03.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Nov 2022 09:03:18 -0800 (PST) From: Colin Ian King To: Denis Kirjanov , "David S . Miller" , Eric Dumazet , Jakub Kicinski , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: sundance: remove unused variable cnt Date: Mon, 14 Nov 2022 17:03:17 +0000 Message-Id: <20221114170317.92817-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749491950394998859?= X-GMAIL-MSGID: =?utf-8?q?1749491950394998859?= Variable cnt is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it. Signed-off-by: Colin Ian King --- drivers/net/ethernet/dlink/sundance.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/dlink/sundance.c b/drivers/net/ethernet/dlink/sundance.c index 43def191f26f..aaf0eda96292 100644 --- a/drivers/net/ethernet/dlink/sundance.c +++ b/drivers/net/ethernet/dlink/sundance.c @@ -1414,7 +1414,6 @@ static void refill_rx (struct net_device *dev) { struct netdev_private *np = netdev_priv(dev); int entry; - int cnt = 0; /* Refill the Rx ring buffers. */ for (;(np->cur_rx - np->dirty_rx + RX_RING_SIZE) % RX_RING_SIZE > 0; @@ -1441,7 +1440,6 @@ static void refill_rx (struct net_device *dev) np->rx_ring[entry].frag.length = cpu_to_le32(np->rx_buf_sz | LastFrag); np->rx_ring[entry].status = 0; - cnt++; } } static void netdev_error(struct net_device *dev, int intr_status)