From patchwork Mon Jan 22 02:29:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: mengqinggang X-Patchwork-Id: 189886 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2bc4:b0:101:a8e8:374 with SMTP id hx4csp2330642dyb; Sun, 21 Jan 2024 18:29:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IHRzxNR6briyvYdYzj5Z9tyO6h2ow7r9TTAOoVhBEAm3YHqApoNcJvuGbDSd6LiIH7wVWdL X-Received: by 2002:a05:620a:4454:b0:783:99ba:5bd5 with SMTP id w20-20020a05620a445400b0078399ba5bd5mr1979917qkp.15.1705890579219; Sun, 21 Jan 2024 18:29:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705890579; cv=pass; d=google.com; s=arc-20160816; b=IyleZFSUKxOe6ixxhW9DiZ+jXbu7fbgBWxED9D7S0XY/qjsq+kqCwI/HUT3mFB0/V6 SHeyhbfhZXDi8K5NeI+ss0i11jEn/uS5XTsMOxKdy89OQMy9CEDvGOvutNX2PG3wo/EU zfcQWKsWyj5i+a6+KHmCUqzYSbw5MpF16yuDj4HZTZ0f9us+vsbF1lP3HQvnoZb78XXL 8KBIBcErhwxalO5r1ZBOXIaMueOdfJZHcS/MfZOJytqXPgw4Pki+tN0qKMF/lPl8oGXM e3fB33Ei76VTecniVdOAM+zujdP9PaFw29XxgWM5J0sUmoNxujXi93T3pzuyJfcvNQMm YeJw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:arc-filter :dmarc-filter:delivered-to; bh=/vHE9Muaf/LCVBoi0T2TbQ5rHPjBsD7ZQFLJVUksSLE=; fh=IjBrBzj0HafC7UFRTZLmdEImc4JDKXFiCrZAu8bdkFw=; b=Kofzyl8HLYuRN5NSODhXQtFljEwxI+P/l/R3uwRMjpvMsHUWZ60ZNehCknzENcTnHM NnecAyxKo+BO0gsRG1Tvc/Ih6exg751sO7uubytp3JfTl0X8kyu+8AasZyxC496XOKGJ k9Nc0ebus8FbZV2ODAeyj2L8+o7XcJqOtrvYLP5/MdcJJHlCQPEDAnactg5/gcFoT38V 9nsTkpadCo/B6EP5boYydDWBTAFnY921ePBPfh1UWLBX0ya+tku4pSOciaL5bfABkM2G fTvNlC29z8nfvhvPoCCtDWf+lkeJHb6VRkqT3wJEIfMIGrJWKOrCip1kNG8VEaLUiYOi Pv/Q== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id pj22-20020a05620a1d9600b007833a6f1f8dsi4407599qkn.240.2024.01.21.18.29.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jan 2024 18:29:39 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D67503858419 for ; Mon, 22 Jan 2024 02:29:38 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 5C6893858D3C for ; Mon, 22 Jan 2024 02:29:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5C6893858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5C6893858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705890570; cv=none; b=yDrSvy+qzCO99Vc6q82F7iOn3Fe1YzHZ90ux6V5I3KMqGZKZiNMZwJKKLwFvAlRjLQrQnckmNkB1aWO8Ktc5Px5VPVGi/bZ/FKaZJSTqObQkLku1vnXYwOJnTxyH2GXYoq2NnifFUknbZ4yNZQlZCzf7QjG0p/+jlyGCKM/I6aA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705890570; c=relaxed/simple; bh=SIDI4rBDAeR/+oyNIYHCrJOIC5Gzg5YzgjKXnMnlud4=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=h4y52PEjAcom9B5o9UkD3lynmgdBbHf5LEitR8833PYgPJvgs1oYUgSuMbVjyJb3TzXMjBMFVXYIpB+yWgSxZParxxDL34KYTJTetEd1A068zSySBCPcsZEyYFcwg9RHFAWeO9bJdkzi/M3I5e27tLudgvzK7B8bpqQerk4VRpg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.2.6.5]) by gateway (Coremail) with SMTP id _____8BxHOsD061lITsDAA--.3264S3; Mon, 22 Jan 2024 10:29:23 +0800 (CST) Received: from 5.5.5 (unknown [10.2.6.5]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Cxf88C061lVV0QAA--.11227S2; Mon, 22 Jan 2024 10:29:22 +0800 (CST) From: mengqinggang To: binutils@sourceware.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, cailulu@loongson.cn, xry111@xry111.site, i.swmail@xen0n.name, maskray@google.com, luweining@loongson.cn, wanglei@loongson.cn, hejinyang@loongson.cn, mengqinggang Subject: [PATCH v2] LoongArch: gas: Start a new frag after instructions that can be relaxed Date: Mon, 22 Jan 2024 10:29:21 +0800 Message-Id: <20240122022921.3008814-1-mengqinggang@loongson.cn> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 X-CM-TRANSID: AQAAf8Cxf88C061lVV0QAA--.11227S2 X-CM-SenderInfo: 5phqw15lqjwttqj6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBj93XoWxtw4DAryDAw18Zw1UAr4xuFX_yoW7Ar45pr 15ur43GF48CFnIgr4ktr45Cr4fXw40kFWIq3y7K3yxCrn7Jry0qas7Jr97uan8K3yUGw1F qrn0qF10gFykA3gCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUkjb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ Gr0_Gr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1l5I 8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv67AK xVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2Ij64 vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8G jcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2I x0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK 8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I 0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07jUsqXUUUUU= X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788755920232326346 X-GMAIL-MSGID: 1788755920232326346 For R_LARCH_TLS_{LE_HI20_R,LE_ADD_R,LD_PC_HI20,GD_PC_HI20, DESC_PC_HI20} relocations, start a new frag to get correct eh_frame Call Frame Information FDE DW_CFA_advance_loc info. --- [v1] -> [v2]: - Delete R_LARCH_TLS_IE_PC_HI20. - Add a test case. gas/config/tc-loongarch.c | 19 ++++++-- .../relax-cfi-fde-DW_CFA_advance_loc.d | 46 +++++++++++++++++++ .../relax-cfi-fde-DW_CFA_advance_loc.s | 33 +++++++++++++ 3 files changed, 93 insertions(+), 5 deletions(-) create mode 100644 gas/testsuite/gas/loongarch/relax-cfi-fde-DW_CFA_advance_loc.d create mode 100644 gas/testsuite/gas/loongarch/relax-cfi-fde-DW_CFA_advance_loc.s diff --git a/gas/config/tc-loongarch.c b/gas/config/tc-loongarch.c index 863ac9cea43..df7c7111ed8 100644 --- a/gas/config/tc-loongarch.c +++ b/gas/config/tc-loongarch.c @@ -1083,13 +1083,22 @@ append_fixp_and_insn (struct loongarch_cl_insn *ip) optimized away or compressed by the linker during relaxation, to prevent the assembler from computing static offsets across such an instruction. - This is necessary to get correct .eh_frame cfa info. If one cfa's two - symbol is not in the same frag, it will generate relocs to calculate - symbol subtraction. (gas/dw2gencfi.c:output_cfi_insn: - if (symbol_get_frag (to) == symbol_get_frag (from))) */ + This is necessary to get correct .eh_frame FDE DW_CFA_advance_loc info. + If one cfi_insn_data's two symbols are not in the same frag, it will + generate ADD and SUB relocations pairs to calculate DW_CFA_advance_loc. + (gas/dw2gencfi.c: output_cfi_insn: + if (symbol_get_frag (to) == symbol_get_frag (from))) + + For macro instructions, only the first instruction expanded from macro + need to start a new frag. */ if (LARCH_opts.relax && (BFD_RELOC_LARCH_PCALA_HI20 == reloc_info[0].type - || BFD_RELOC_LARCH_GOT_PC_HI20 == reloc_info[0].type)) + || BFD_RELOC_LARCH_GOT_PC_HI20 == reloc_info[0].type + || BFD_RELOC_LARCH_TLS_LE_HI20_R == reloc_info[0].type + || BFD_RELOC_LARCH_TLS_LE_ADD_R == reloc_info[0].type + || BFD_RELOC_LARCH_TLS_LD_PC_HI20 == reloc_info[0].type + || BFD_RELOC_LARCH_TLS_GD_PC_HI20 == reloc_info[0].type + || BFD_RELOC_LARCH_TLS_DESC_PC_HI20 == reloc_info[0].type)) { frag_wane (frag_now); frag_new (0); diff --git a/gas/testsuite/gas/loongarch/relax-cfi-fde-DW_CFA_advance_loc.d b/gas/testsuite/gas/loongarch/relax-cfi-fde-DW_CFA_advance_loc.d new file mode 100644 index 00000000000..367039e1efa --- /dev/null +++ b/gas/testsuite/gas/loongarch/relax-cfi-fde-DW_CFA_advance_loc.d @@ -0,0 +1,46 @@ +#as: -mrelax +#objdump: -Dr -j .eh_frame +#skip: loongarch32-*-* + +.*:[ ]+file format .* + + +Disassembly of section .eh_frame: + +[ ]*0000000000000000 <.eh_frame>: +[ ]+0:[ ]+00000014[ ]+.word[ ]+[ ]+0x00000014 +[ ]+4:[ ]+00000000[ ]+.word[ ]+[ ]+0x00000000 +[ ]+8:[ ]+00527a01[ ]+.word[ ]+[ ]+0x00527a01 +[ ]+c:[ ]+01017c01[ ]+fadd.d[ ]+\$fa1, \$fa0, \$fs7 +[ ]+10:[ ]+0c030d1b[ ]+.word[ ]+[ ]+0x0c030d1b +[ ]+14:[ ]+00000016[ ]+.word[ ]+[ ]+0x00000016 +[ ]+18:[ ]+00000034[ ]+.word[ ]+[ ]+0x00000034 +[ ]+1c:[ ]+0000001c[ ]+.word[ ]+[ ]+0x0000001c +[ ]+... +[ ]+20: R_LARCH_32_PCREL[ ]+L0\^A +[ ]+24: R_LARCH_ADD32[ ]+L0\^A +[ ]+24: R_LARCH_SUB32[ ]+L0\^A +[ ]+28:[ ]+0cd64000[ ]+.word[ ]+[ ]+0x0cd64000 +[ ]+29: R_LARCH_ADD6[ ]+L0\^A +[ ]+29: R_LARCH_SUB6[ ]+L0\^A +[ ]+2c:[ ]+d6400016[ ]+.word[ ]+[ ]+0xd6400016 +[ ]+2e: R_LARCH_ADD6[ ]+L0\^A +[ ]+2e: R_LARCH_SUB6[ ]+L0\^A +[ ]+30:[ ]+4000160c[ ]+beqz[ ]+\$t4, 3145748[ ]+# 300044 +[ ]+33: R_LARCH_ADD6[ ]+L0\^A +[ ]+33: R_LARCH_SUB6[ ]+L0\^A +[ ]+34:[ ]+00160cd6[ ]+orn[ ]+\$fp, \$a2, \$sp +[ ]+38:[ ]+160cd640[ ]+lu32i.d[ ]+\$zero, 26290 +[ ]+38: R_LARCH_ADD6[ ]+L0\^A +[ ]+38: R_LARCH_SUB6[ ]+L0\^A +[ ]+3c:[ ]+0cd64000[ ]+.word[ ]+[ ]+0x0cd64000 +[ ]+3d: R_LARCH_ADD6[ ]+L0\^A +[ ]+3d: R_LARCH_SUB6[ ]+L0\^A +[ ]+40:[ ]+d6400016[ ]+.word[ ]+[ ]+0xd6400016 +[ ]+42: R_LARCH_ADD6[ ]+L0\^A +[ ]+42: R_LARCH_SUB6[ ]+L0\^A +[ ]+44:[ ]+4000160c[ ]+beqz[ ]+\$t4, 3145748[ ]+# 300058 +[ ]+47: R_LARCH_ADD6[ ]+L0\^A +[ ]+47: R_LARCH_SUB6[ ]+L0\^A +[ ]+48:[ ]+000000d6[ ]+.word[ ]+[ ]+0x000000d6 +[ ]+4c:[ ]+00000000[ ]+.word[ ]+[ ]+0x00000000 diff --git a/gas/testsuite/gas/loongarch/relax-cfi-fde-DW_CFA_advance_loc.s b/gas/testsuite/gas/loongarch/relax-cfi-fde-DW_CFA_advance_loc.s new file mode 100644 index 00000000000..6e4c9b8bb6e --- /dev/null +++ b/gas/testsuite/gas/loongarch/relax-cfi-fde-DW_CFA_advance_loc.s @@ -0,0 +1,33 @@ +# Emits ADD/SUB relocations for CFA FDE DW_CFA_advance_loc with -mrelax option. +.text +.cfi_startproc + +.cfi_def_cfa 22, 0 +la.local $t0, a +.cfi_restore 22 + +.cfi_def_cfa 22, 0 +la.got $t0, a +.cfi_restore 22 + +.cfi_def_cfa 22, 0 +la.tls.ld $t0, a +.cfi_restore 22 + +.cfi_def_cfa 22, 0 +la.tls.gd $t0, a +.cfi_restore 22 + +.cfi_def_cfa 22, 0 +la.tls.desc $t0, a +.cfi_restore 22 + +.cfi_def_cfa 22, 0 +pcalau12i $t0, %le_hi20_r(a) +.cfi_restore 22 + +.cfi_def_cfa 22, 0 +add.d $t0, $tp, $t0, %le_add_r(a) +.cfi_restore 22 + +.cfi_endproc