From patchwork Sun Jan 21 22:48:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 189854 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2bc4:b0:101:a8e8:374 with SMTP id hx4csp2266753dyb; Sun, 21 Jan 2024 14:49:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IEIiRcJDWefgxZxag4sT2G6hj8CQukxoIuhW/fGrgrVf625frk4ucbAjRPtZHmgLTlF9SjW X-Received: by 2002:a0c:f04c:0:b0:685:6ad9:410d with SMTP id b12-20020a0cf04c000000b006856ad9410dmr3794381qvl.87.1705877366582; Sun, 21 Jan 2024 14:49:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705877366; cv=pass; d=google.com; s=arc-20160816; b=YDHJxTeUrFC5nEJTmNJ8LmYAl/Ol8XxUuzxq7ZmqcyKPDhLQ1gPHOXtIRZ3ko70L3m Bx5TZv+IkGsfFxfQArrQDvVTY9ktpQ8DbblhAwwXFDc6KFFndGTNKDwSTRiF+1B4Lr29 b1jyBFnD2vEHHnwILvf2okCpYWl1sqK3ZSDM7qrB4XuddZIwUf/bhdJwSxfPgs6fOOJF KvEVuZyv/PquC8ZGa8XtLVPH4n2MRorOcbxJ/qilZpX7sJ756rN86tiWQFp27wS6pNDB ga+Gh6ct5H7Ci5zfUKzEChVurLH+FFt6s34Dg5C0NmeOTbd3cHlUPiGqBEEaNJ+S3W1i 4IwA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:from:to :content-language:user-agent:mime-version:date:message-id :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=tiNxVUNoOgezxYnrlQr/siutAj/N1U9fuohg1libTPU=; fh=XNn3asQvIblazGK92GBt13dVv+YmGV3pBS0JC29ZQco=; b=bo6OW+B8yzkLd4wSRdrHuQXQ5GmB2IFmCMOuTJCtkNQRGNQLgjv0kRdpSm4U4JL9UX DAu/xA4ceRw0jIhCNB8LWvtQD3vVUqqRRlh1/TNxbAe6wV0h8bcjVxunVuyY9lLLoRvW MhIfuDJ3Uhna3F5Tp68FUFu1EJazQwJ40CMB0zRAAPh7QZorEA95s8hMC2XWylVWcnYF J9xXauB/BRtX5UbQgtm/Dn5m0OegMWMclaNVBRYMmuRfWSgwRFHmeK7R7wQEyx4TbsYC CyDtFB3d+2u7isasB23W5I5Xhrg4/Fjl+L3+zMSgenMOqK2Tcj9YIcKaA8WePFkGdRSF nX7A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b=IjxQl0MZ; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id w13-20020a0ce10d000000b00683ea1038b1si4467771qvk.311.2024.01.21.14.49.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jan 2024 14:49:26 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b=IjxQl0MZ; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4D863385E449 for ; Sun, 21 Jan 2024 22:49:26 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by sourceware.org (Postfix) with ESMTPS id 444AE3858D3C for ; Sun, 21 Jan 2024 22:48:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 444AE3858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ventanamicro.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 444AE3858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705877323; cv=none; b=ol68XhD4gVXZoJwpIQSR4a68CDbI78qd/HjZWi1had1/aSTOTL4Yldq4Bcb+TVg2fXqLuzVY6Pt0g4fNttya8Z6FHqaetN2arK9JBwM6YqrCceUKdW5e9lm7KHCdtUazcqsQAGKZ3hPIBdunL28z72ShRQsFtwf1A4oVWWKmlh0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705877323; c=relaxed/simple; bh=QXLFNWzN3vSug0tIA03LR6pZ3YYJMafDtaarr0L2l6s=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=LOblIAo14oq/Itmw3LVfRQYwzPHfA1KHU70Mqpy1BlQQutaeQoaI/6rvtwTCAKky21mUpktmJ5sUmSMQTaEEVyg5yxW591mx0bcbIIAJelx1I7nnwnG2Ped8BtENi9joB6KBbSW+xMAdbE+7ChZYwQwxQJZpE4aT/qweO4ZaWzY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-7bf617dcedaso132512939f.0 for ; Sun, 21 Jan 2024 14:48:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1705877314; x=1706482114; darn=gcc.gnu.org; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=tiNxVUNoOgezxYnrlQr/siutAj/N1U9fuohg1libTPU=; b=IjxQl0MZPvYS8Uqoe08Cfj5DklOwuMwC9XtgDpWyCY0PQzZJoCRU5XpIn3V8rGK3SD wxzxOee+Jbn6B5HPZ/NVKxQLsOrKpev3PC9dBmScArUaRAZIvFvAR9c6MG7ISVHZ1PSE SSS2KZKQFLpu88IBj1OksRAH0AWbTdvfIGRnJ/y6SpJNOTtzjAf18ddRXIX5uVsHj/7J SncdPhlR+684XhEddXrb64Ty3DdQiNG/IEiF6cT+apjsc6HoNObj2MFcH4s2VgScv+x9 Jc5hSzQdlpkbtylRqaOJEfUYrF5B9/e61QGUJw4amQx/gm59VA1syIgF20vm0xJGuhU6 SLgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705877314; x=1706482114; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tiNxVUNoOgezxYnrlQr/siutAj/N1U9fuohg1libTPU=; b=Ymq/tQAT00fYKDdLerL8uiPKKhutp9uX/EnqCKxIq81qDs3RpgAyzw/HIYeLVw8WxL oCil7C+987jRYvAjUwt+0Y69BmUQysWqDSwKK/M6sUkoXd/wZ9avBPpMFfSrNd+DkHpA TyJCS2WWG3uf7fGshaZZ0L7QtYZhQ7duVjiDtVLXRmWBbr3tGTOr2A7hhgrEr8aW2vDl uVryBoirchGahQhRUsE4b9YhKJ/7GnuLzE+s7FN7sPo0wD9K+HsEKzVTX10rGFlwz9Y4 QoPaShs791rMsGRaxh9mjuzsdrsSIVQKE1sAdX3XojXNHNLmTPlXzMpu6+vna+HRCuL8 /I1g== X-Gm-Message-State: AOJu0Yw83185pym1i43muHFYXzrYzKC0BjvWC5nt4BscOyKbLGcjLzi0 eKMw5FlfdOSF5M7emlXNy7ZWcQwXO0Ftg9JvoNVcMpibLphoGtUWRdMpqSTOg5LTAfznqCDg2fk d X-Received: by 2002:a6b:e418:0:b0:7bf:7e09:c0bb with SMTP id u24-20020a6be418000000b007bf7e09c0bbmr6267721iog.30.1705877314686; Sun, 21 Jan 2024 14:48:34 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id j20-20020a02cc74000000b0046cd8bac20dsm2762814jaq.12.2024.01.21.14.48.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Jan 2024 14:48:34 -0800 (PST) Message-ID: Date: Sun, 21 Jan 2024 15:48:33 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: "gcc-patches@gcc.gnu.org" From: Jeff Law Subject: [committed] [NFC] Fix riscv_init_cumulative_args for unused arguments X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788742065530290766 X-GMAIL-MSGID: 1788742065530290766 The signature was still using ATTRIBUTE_UNUSED and actually marked one of the used arguments with ATTRIBUTE_UNUSED. This patch drops the decorations and instead remove the name of arguments which are actually unused which is the preferred way to handle this now when we can. Bootstrapped. I didn't have test results on the platform where I bootstrapped, so no results to compare against. Given its NFC, I think we're OK without the regression results. Pushed to the trunk. jeff diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc index 1f9546f4d3e..3ba45ffaa74 100644 --- a/gcc/config/riscv/riscv.cc +++ b/gcc/config/riscv/riscv.cc @@ -4873,11 +4873,7 @@ riscv_pass_fpr_pair (machine_mode mode, unsigned regno1, For a library call, FNTYPE is 0. */ void -riscv_init_cumulative_args (CUMULATIVE_ARGS *cum, - tree fntype ATTRIBUTE_UNUSED, - rtx libname ATTRIBUTE_UNUSED, - tree fndecl ATTRIBUTE_UNUSED, - int caller ATTRIBUTE_UNUSED) +riscv_init_cumulative_args (CUMULATIVE_ARGS *cum, tree fntype, rtx, tree, int) { memset (cum, 0, sizeof (*cum));