From patchwork Tue Jan 16 04:10:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nylon Chen X-Patchwork-Id: 188369 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:42cf:b0:101:a8e8:374 with SMTP id q15csp39893dye; Mon, 15 Jan 2024 20:11:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IEdE2F4H2hm+/c1JfX9TA2KrAdfTIQEi5KyMc76TlCNyH5/pAEIUey6NBgJp8BMVsvQvBaQ X-Received: by 2002:a81:dc06:0:b0:5d4:90a:c3bc with SMTP id h6-20020a81dc06000000b005d4090ac3bcmr4649459ywj.30.1705378300526; Mon, 15 Jan 2024 20:11:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705378300; cv=none; d=google.com; s=arc-20160816; b=YvmhX7v7+kpMOFwEvt7iin+ly8ZdUlhtQEstMWRpVivUV+MUiHWkau0Uo/pEZULK59 3t3AI8Xqed6BpjCn8bFH31K99WStcmD/DAXRL/Ynwb1jtJGoEuR1YmOEkJkX+nppkyjW GU5ZinjdFwSD0Ekm9gMq/Vq46BSb6W4ZzmL8o72g274vomUXn/wErBhjk/Go3UtybpPq fYjGlf9/K2R6IVJFIot6fP6yH37xKSllrglcKMvECULMBfb+rXMfxXIOZludEho6bO6U 1uEd1f+QPPRcOjjjqTTiHEpdvZrGV99An5D2kaIRrlN20zbkh9StggVve4tvg7Dqfdnu +u+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=lNWOGH7VpQY6V8fQKtozhdwdDDbXnjZtAA+yG72Gg0I=; fh=HdLk8u0jhvs7C0KBcYg5FBqcF70cNpKlWL7kFME3264=; b=h+5axxTKc19kH+dyq/oBK8rNbMr/0Km+ZCKRtSbIFZRBvPMLuRfUnJ0ewhfWKlA0+y TS2nj0OPPq8dVdY20Uxvqy94IgBVYXnIL5k0x8UmSsv1xbTRtW3TKN6MKrcwjf4CnLF4 Qq6O9UlMaFqg/fFfBN/ZJXXjQFzjTvXhQQfJYI6STRaAujj7g40ALC9gpc1Qo1Aa+F54 PEzLUrwXKxftM6SwJPBQ1n2fZSeeOYwrDkUzlEZXT7WSS5Zmj3E+K+PS9okNkEzSfG5d gl9nEqqkiiQPAvD2m0Fot3yz3jrwt84Y+4L6+QUNRPcI9A9OF1UEc0r72aAD7M0yYk8Z EZXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=lzTimnaR; spf=pass (google.com: domain of linux-kernel+bounces-26949-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26949-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id z5-20020a170902834500b001d5dac194d0si1604470pln.303.2024.01.15.20.11.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 20:11:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-26949-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=lzTimnaR; spf=pass (google.com: domain of linux-kernel+bounces-26949-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26949-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 44ECD2849CA for ; Tue, 16 Jan 2024 04:11:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4ED12101F7; Tue, 16 Jan 2024 04:11:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="lzTimnaR" Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34BF2882E for ; Tue, 16 Jan 2024 04:11:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-28cf491b197so4757107a91.1 for ; Mon, 15 Jan 2024 20:11:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1705378270; x=1705983070; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lNWOGH7VpQY6V8fQKtozhdwdDDbXnjZtAA+yG72Gg0I=; b=lzTimnaRDqVlnO5uGWtGw0kq3oftjo8S/OaySCU9PYzYg0Bt1DbIbGdcCmyAvaKjeO ggER/jZjF1dXwqkvZe6kK87izhKuYnHUz5Fh86jcJ1a3UCCHhL3BJOHcwbbQ9LDsxllM GuH+Ec2fKc+2uIAi3IPLXHFT1XLGFawqua+6mKBidmIyOpPQyJuCbQ32PPjRmtR+50dz TjtCln60cxCOcXDFs9Hk9O2HkGrg6OtaJXtBUns2IUWvNSwo8lQ9Jx0oVcSqyTsQGIxO gyO+eZRn3TM6V2JSK02GWLI2CBGckNLBiE2EdbamInXuabzCHp81N3owEB7zEu+qLDC3 f4zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705378270; x=1705983070; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lNWOGH7VpQY6V8fQKtozhdwdDDbXnjZtAA+yG72Gg0I=; b=Mwcv356ay4jmCT+FkGKaNmeF5QM5sZ/aQ07mRZSuSv39/Pad5X+CDCASwoSGa7ucQH t1Iorx5H+rPO5cfOA3YhRD3YpphvAQi/LnSXpo0fTKN7HC6jlVrR1njl63baN5Vtea2G Tr9jH/KFNpymBfaU7Hz0voNKNt37kjRw1lqLj9PXSLeM+1ZbVYzsiftQdnUM58XzsWHD SaYLwjPT8jW6LkJVlGtCyC+0cLHQ77t/DX727xjX/wzlNkvrqBmpy3n+Or9E6Mc6/YJU Dq60eTps6ANJgeYFiEbFY2Kf/7pbW3MIqLULBrDdkKVsKlfE6aU+tZgCCj+XKnUIScxQ wCRA== X-Gm-Message-State: AOJu0YycbYzwF/PsjRsO65QtBez/SHpEtqkialFw+nsQIC5cwtdtrRQ7 FPI+qXKkPYLhIuSmKQSiOCaRBYCIfE5/SxiWHG6l06Q8TAiGtw== X-Received: by 2002:a05:6a00:4f8c:b0:6d9:aa4b:3800 with SMTP id ld12-20020a056a004f8c00b006d9aa4b3800mr3973757pfb.19.1705378270417; Mon, 15 Jan 2024 20:11:10 -0800 (PST) Received: from hsinchu15.internal.sifive.com (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id e3-20020a056a0000c300b006da14f68ac1sm8348585pfj.198.2024.01.15.20.11.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 20:11:10 -0800 (PST) From: Nylon Chen To: paul.walmsley@sifive.com, palmer@dabbelt.com, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, u.kleine-koenig@pengutronix.de, thierry.reding@gmail.com, aou@eecs.berkeley.edu Cc: zong.li@sifve.com, vincent.chen@sifive.com, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, nylon7717@gmail.com, Nylon Chen , Conor Dooley Subject: [v6 1/3] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties Date: Tue, 16 Jan 2024 12:10:52 +0800 Message-ID: <20240116041054.11641-2-nylon.chen@sifive.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240116041054.11641-1-nylon.chen@sifive.com> References: <20240116041054.11641-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788218757009865527 X-GMAIL-MSGID: 1788218757009865527 This removes the active-low properties of the PWM-controlled LEDs in the HiFive Unmatched device tree. The reference is hifive-unleashed-a00.pdf[0] and hifive-unmatched-schematics-v3.pdf[1]. Link: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf [0] Link: https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce76f4192_hifive-unmatched-schematics-v3.pdf [1] Acked-by: Conor Dooley Reviewed-by: Conor Dooley Co-developed-by: Zong Li Signed-off-by: Zong Li Co-developed-by: Vincent Chen Signed-off-by: Vincent Chen Signed-off-by: Nylon Chen --- arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 8 ++++---- arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++-------- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts index 900a50526d77..11e7ac1c54bb 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts @@ -49,7 +49,7 @@ led-controller { compatible = "pwm-leds"; led-d1 { - pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; + pwms = <&pwm0 0 7812500 0>; active-low; color = ; max-brightness = <255>; @@ -57,7 +57,7 @@ led-d1 { }; led-d2 { - pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; + pwms = <&pwm0 1 7812500 0>; active-low; color = ; max-brightness = <255>; @@ -65,7 +65,7 @@ led-d2 { }; led-d3 { - pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; + pwms = <&pwm0 2 7812500 0>; active-low; color = ; max-brightness = <255>; @@ -73,7 +73,7 @@ led-d3 { }; led-d4 { - pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; + pwms = <&pwm0 3 7812500 0>; active-low; color = ; max-brightness = <255>; diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts index 07387f9c135c..b328ee80693f 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts @@ -51,8 +51,7 @@ led-controller-1 { compatible = "pwm-leds"; led-d12 { - pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms = <&pwm0 0 7812500 0>; color = ; max-brightness = <255>; label = "d12"; @@ -68,20 +67,17 @@ multi-led { label = "d2"; led-red { - pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms = <&pwm0 2 7812500 0>; color = ; }; led-green { - pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms = <&pwm0 1 7812500 0>; color = ; }; led-blue { - pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; - active-low; + pwms = <&pwm0 3 7812500 0>; color = ; }; }; From patchwork Tue Jan 16 04:10:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nylon Chen X-Patchwork-Id: 188370 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:42cf:b0:101:a8e8:374 with SMTP id q15csp39971dye; Mon, 15 Jan 2024 20:11:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IF+LSy5oCbZGdBS7om8Yn62m5Bsq7+LzIm1tvWbQHcRCR+3FNJBm/vkTFxADvq6hRQtqEYs X-Received: by 2002:a05:620a:14a7:b0:783:577c:f1a2 with SMTP id x7-20020a05620a14a700b00783577cf1a2mr3963234qkj.19.1705378318037; Mon, 15 Jan 2024 20:11:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705378318; cv=none; d=google.com; s=arc-20160816; b=nZFRJr0IRc12ctZ7NnNRhhViBaLWUqM++GSx7S9p7u68rub6iHJCs6USa2Fy5qysvj NRzu6dGzAOnorvqNHgEsshr3axgJlsp7Zet0dcKynU63PooifmmYJnOxZZtiFjUdMnWB omPeEQ69wbf9+qAKgxu0TMY5WJcsExgX5sVik5l1WiYKquEGCvXJ7nKIE6MEluwnccxO y5XJ0gEaD1BxmOt2GiqoMH2xvyXXz1jAFAd9ITJqatOUHdY3TpE5baEgEHodEGnB6rHe gKHGG/CgCqqgDPiM7uSVNxfyZG6BGUxdPyx9MMaqQy580zwuowRkLNEHLrRGFqkykIEC xBuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=cvJrbymRDVqsWiIagFJrDLqKjAGvymGFfMj4nY9d7Jo=; fh=UkKqDtQf/nyeWncZ0OnJZ79jYcbt/5EXA6rFMCrt7Kg=; b=takj5Ma/oFcee4/qdKzdUhhY4WCDD0BkRIVIAHKtviI65baM5xJIMB56UEJb7pq7zD Acl5KWwNEs52rfE1tjQQUFOEtI02D+qJI5TMHzsHcglpbTdbyEUNz3H6QE1irRFflwzu mhOOGup2DSusAU0gtvaAgT4bWkEi8fv5a9asYYuzQIfkl3GNJhkYYE2VEuxPyyjNz4dr gq8IheAMhFJasDIoP8rMzzJ+z+j5covsWwrLbAdGujAKAqtSgU0OkkgbL8vTzDHrBkcm kCf0oo4Lqz75LZ6zEAOm6Rbm14NB14jezSGCAB5UV0oytIaSGs0PIk4sErOCtu9ZpyAv PdcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=JvpOM9LB; spf=pass (google.com: domain of linux-kernel+bounces-26950-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26950-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id bk31-20020a05620a1a1f00b007831565eb19si9754659qkb.250.2024.01.15.20.11.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 20:11:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-26950-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=JvpOM9LB; spf=pass (google.com: domain of linux-kernel+bounces-26950-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26950-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C16D71C228BC for ; Tue, 16 Jan 2024 04:11:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4342410A21; Tue, 16 Jan 2024 04:11:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="JvpOM9LB" Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AE206FA8 for ; Tue, 16 Jan 2024 04:11:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-6da4a923b1bso4676888b3a.2 for ; Mon, 15 Jan 2024 20:11:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1705378277; x=1705983077; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cvJrbymRDVqsWiIagFJrDLqKjAGvymGFfMj4nY9d7Jo=; b=JvpOM9LBmjJH09YokSHo3Ysr1GZHtTLYi5JRk7K8kDxp1bSY3ctof0fRjm64sM/XJa 3G2ksoB2uIxOPfxNHoM6pN6WJofXTeXIk35QMlgQmzW4uWBHqzyP8tSgqWwT1259cMLx R1EUKs8mucFdk9Nm034/fwDL9edifq93Yn0IjQ5E8ewZIxfEKuaKnThjXx5UPH4sjxfL mkAEEOVAR6QhJm4X3jBz47BL2vVzHxRmdtptt38G7+9rllBKStO4ey0zpUB1Rn6oS8q0 ergcwWjkdYRqFV/C+LOYK2ziDqiLeDT6gjbdhce+jjxf7MNmcQNyGdWZDI/iBanUl9E0 er3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705378277; x=1705983077; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cvJrbymRDVqsWiIagFJrDLqKjAGvymGFfMj4nY9d7Jo=; b=fdI7Sbp/NFEP7Li0SqolrJYLisWJH0InWRGka1rTBOHsB33/5QcTx0kkDp/6EgUfnw dOPRBaoKCOqQdQtCQY3zJSb4ywlGK7OIv18wmM14jkW31o+NjeoTKo7iLKlpRN/n3SiJ 5myVViE5UJDFFfqZRWyX/097apvgHOeExq8iJRynM3z5JyYbIAJZ0DIZLqaMX9HehO4O qcKZFaT9gbqFHYUUWtNj7/sSrRkhzGtpCuvCauNYkepIuk0d3BUkozQNI5ZetpRKQPdl cgNj8VogLCezSOrpWcm6wOnkG4yLE93aDidJ7xbgsEp+9/Hv5Qog3xLMKYhj85qdBJwD 1DEQ== X-Gm-Message-State: AOJu0Yyi3XiMixfF6IrTYAfJrX8W5m54hb6PYaR+t3h56KVJ9u3ECuFo c9oehSjm5UEEHJ8CLM0fsJTKkwfjYtTt4g== X-Received: by 2002:a05:6a00:2a04:b0:6da:b010:e863 with SMTP id ce4-20020a056a002a0400b006dab010e863mr3534499pfb.55.1705378276814; Mon, 15 Jan 2024 20:11:16 -0800 (PST) Received: from hsinchu15.internal.sifive.com (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id e3-20020a056a0000c300b006da14f68ac1sm8348585pfj.198.2024.01.15.20.11.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 20:11:16 -0800 (PST) From: Nylon Chen To: paul.walmsley@sifive.com, palmer@dabbelt.com, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, u.kleine-koenig@pengutronix.de, thierry.reding@gmail.com, aou@eecs.berkeley.edu Cc: zong.li@sifve.com, vincent.chen@sifive.com, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, nylon7717@gmail.com, Nylon Chen Subject: [v6 2/3] pwm: sifive: change the PWM controlled LED algorithm Date: Tue, 16 Jan 2024 12:10:53 +0800 Message-ID: <20240116041054.11641-3-nylon.chen@sifive.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240116041054.11641-1-nylon.chen@sifive.com> References: <20240116041054.11641-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788218775444547621 X-GMAIL-MSGID: 1788218775444547621 The `frac` variable represents the pulse inactive time, and the result of this algorithm is the pulse active time. Therefore, we must reverse the result. The reference is SiFive FU740-C000 Manual[0] Link: https://sifive.cdn.prismic.io/sifive/1a82e600-1f93-4f41-b2d8-86ed8b16acba_fu740-c000-manual-v1p6.pdf [0] Co-developed-by: Zong Li Signed-off-by: Zong Li Co-developed-by: Vincent Chen Signed-off-by: Vincent Chen Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index eabddb7c7820..b07c8598bb21 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -113,6 +113,7 @@ static int pwm_sifive_get_state(struct pwm_chip *chip, struct pwm_device *pwm, u32 duty, val; duty = readl(ddata->regs + PWM_SIFIVE_PWMCMP(pwm->hwpwm)); + duty = (1U << PWM_SIFIVE_CMPWIDTH) - 1 - duty; state->enabled = duty > 0; @@ -123,11 +124,10 @@ static int pwm_sifive_get_state(struct pwm_chip *chip, struct pwm_device *pwm, state->period = ddata->real_period; state->duty_cycle = (u64)duty * ddata->real_period >> PWM_SIFIVE_CMPWIDTH; - state->polarity = PWM_POLARITY_INVERSED; + state->polarity = PWM_POLARITY_NORMAL; return 0; } - static int pwm_sifive_apply(struct pwm_chip *chip, struct pwm_device *pwm, const struct pwm_state *state) { @@ -139,7 +139,7 @@ static int pwm_sifive_apply(struct pwm_chip *chip, struct pwm_device *pwm, int ret = 0; u32 frac; - if (state->polarity != PWM_POLARITY_INVERSED) + if (state->polarity != PWM_POLARITY_NORMAL) return -EINVAL; cur_state = pwm->state; @@ -159,6 +159,7 @@ static int pwm_sifive_apply(struct pwm_chip *chip, struct pwm_device *pwm, frac = DIV64_U64_ROUND_CLOSEST(num, state->period); /* The hardware cannot generate a 100% duty cycle */ frac = min(frac, (1U << PWM_SIFIVE_CMPWIDTH) - 1); + frac = (1U << PWM_SIFIVE_CMPWIDTH) - 1 - frac; mutex_lock(&ddata->lock); if (state->period != ddata->approx_period) { From patchwork Tue Jan 16 04:10:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nylon Chen X-Patchwork-Id: 188371 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:42cf:b0:101:a8e8:374 with SMTP id q15csp40057dye; Mon, 15 Jan 2024 20:12:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IGWT5Dxk0TS+R+O1Kp6wg50OtXZhT08UVa3w+w19CdXpB4qKy9l9/RmlxOAvg51YUKRL/cW X-Received: by 2002:a17:903:2808:b0:1d4:75c6:9560 with SMTP id kp8-20020a170903280800b001d475c69560mr2788423plb.59.1705378334945; Mon, 15 Jan 2024 20:12:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705378334; cv=none; d=google.com; s=arc-20160816; b=TDES0CvMIKOuoj3vkjjFZy9cK0NgaDSwgbs+v+oC1xNMi46QV1yGmQGZj1SHK3hWZP 3iVVL3fZTheUoltiezlcnblLwQkDtl302osniKHhUYtXb/GCe19SSnbJwnZ6cWB3UI50 LA5Uc0Kbi3z5kLYG1rilUbtmxv8fkL+2E2Z1UnGpTY/ga2AUWQC1RRBG4lLGY66ciuct w9gOD/CQpfV3L9csLv4pl69NehgO2Osz9puwKY5lsHcy7hIPScHiKgwLnSoHZM5p7ojZ uF5In6hBBHDaG+N6nS3dtk7RAq/xUX9iy8skE3XZ6vGeH6PSu+Jocc9/C/Q161tKBczs mVLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=nYo9wXWOZdh4xBQbuTEOxrcqZQMwofEU/9c/S0MDuwU=; fh=UkKqDtQf/nyeWncZ0OnJZ79jYcbt/5EXA6rFMCrt7Kg=; b=OXjFREsXdNMm8D05f5933tY/28+SWUrYG+xU4GlvEen9UNDur58skhlZr2j6ZHMsP/ XZNLLKzoMLgr7dmFsdrKyfPjEXIP/9OM2EIj+hCSbZgBEj/10U84InCGQzlgwho1l2vg Zlh5i6EUWN6gQAkW8XP5LLoRbCx1pcae5uLN85MQMbvX+yts1PM3hqIQKK4JLJIDxS9x cyCeeKibekMwrcGYn1oHrjZezBgDwIg1d992TpsFHF4UvnW8d7CNxYhBewfghod9rG5T VGOXEfjlRtMt3H2xS/v66SS/cw8bj1defz6QwUaUYrH0BXS0vaZ/fkwybCebpw5WsfQn iqJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=gS8mDw+N; spf=pass (google.com: domain of linux-kernel+bounces-26951-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26951-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id i18-20020a170902eb5200b001d496d21086si9912548pli.500.2024.01.15.20.12.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 20:12:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-26951-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=gS8mDw+N; spf=pass (google.com: domain of linux-kernel+bounces-26951-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26951-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9DDF2284A76 for ; Tue, 16 Jan 2024 04:12:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8301510A25; Tue, 16 Jan 2024 04:11:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="gS8mDw+N" Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEDDE10A2A for ; Tue, 16 Jan 2024 04:11:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-6dddba43d70so4657673a34.1 for ; Mon, 15 Jan 2024 20:11:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1705378283; x=1705983083; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nYo9wXWOZdh4xBQbuTEOxrcqZQMwofEU/9c/S0MDuwU=; b=gS8mDw+N0vl5VxlTMOykZ6FXiQKiZHSNmUcHzeZnM3hFM5Iv0J9/gfdAg6g+Ltlk9n tuMFXI39vsauahLQDcmXYsnzUM0kPp3MoVGMyjO99Yru0eCjkV14Cn3qGWNkwwJVCBbf Vi0ZwU2iH8n1/IhTp/ugdF0WcyoVrWdTf1R3Vk3vvbr1pYVl7FJ7O8Q2KGldkcpOmH9t 6pptrDMM4Z6DUpRTwi9zqWcD3ob0IqktCwNfMSOex1Qwi2KuT9W9U7kIiGAJh9SL5hyG ejulNh3cNfm0qNNnCeyeRWhwL/iDMo5J+wtqicp0EfX3v0C+HTj5/TqjQORv1+8cOwGP 9LhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705378283; x=1705983083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nYo9wXWOZdh4xBQbuTEOxrcqZQMwofEU/9c/S0MDuwU=; b=Poyi1nNzyZ92IQBVo8X5hmQhXzyMk9PXYijfe5gt9HpCv5jXzSA/2/7APTp8I5K4TP TaouCXO86ACxAndCJMOOFZ5E9kJq++oO6WdWG+ZYJMuzLIaQAxq8aNkcmLvk+FtGNdvC g0QqH5CemiGZOCIF+OAoMTgGFbm+Mxj/zE+cgbFDV4bsiwPM1eWDHKbRn334WEKar1HN 2XZf38O7KntoRCa/LzUGNVYK2GUcdrHZBgh7zUM3xfJM/jcCYfM1kC6/jY91Z8lrZ98J Ou1gumCAMoSbuKWqZCxEQITQx7qVx3qfOm4EiInIiS8YseYyKoznkADemedCNKXHr7j7 iiVg== X-Gm-Message-State: AOJu0YzmCzDcCArj9G+//MXVa8rXUzzbqdeIkxNU+vHwIDv/nIe81uCM eX+4l1eDnebiG/c3YtRGArT3KuPa5OHo+g== X-Received: by 2002:a05:6358:924:b0:175:d42f:6c63 with SMTP id r36-20020a056358092400b00175d42f6c63mr4731065rwi.36.1705378282820; Mon, 15 Jan 2024 20:11:22 -0800 (PST) Received: from hsinchu15.internal.sifive.com (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id e3-20020a056a0000c300b006da14f68ac1sm8348585pfj.198.2024.01.15.20.11.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 20:11:22 -0800 (PST) From: Nylon Chen To: paul.walmsley@sifive.com, palmer@dabbelt.com, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, u.kleine-koenig@pengutronix.de, thierry.reding@gmail.com, aou@eecs.berkeley.edu Cc: zong.li@sifve.com, vincent.chen@sifive.com, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, nylon7717@gmail.com, Nylon Chen Subject: [v6 3/3] pwm: sifive: Fix the error in the idempotent test within the pwm_apply_state_debug function Date: Tue, 16 Jan 2024 12:10:54 +0800 Message-ID: <20240116041054.11641-4-nylon.chen@sifive.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240116041054.11641-1-nylon.chen@sifive.com> References: <20240116041054.11641-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788218793103935695 X-GMAIL-MSGID: 1788218793103935695 Round the result to the nearest whole number. This ensures that real_period is always a reasonable integer that is not lower than the actual value. e.g. $ echo 110 > /sys/devices/platform/led-controller-1/leds/d12/brightness $ .apply is not idempotent (ena=1 pol=0 1739692/4032985) -> (ena=1 pol=0 1739630/4032985) Co-developed-by: Zong Li Signed-off-by: Zong Li Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index b07c8598bb21..7cf7a76cdb44 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -101,7 +101,7 @@ static void pwm_sifive_update_clock(struct pwm_sifive_ddata *ddata, /* As scale <= 15 the shift operation cannot overflow. */ num = (unsigned long long)NSEC_PER_SEC << (PWM_SIFIVE_CMPWIDTH + scale); - ddata->real_period = div64_ul(num, rate); + ddata->real_period = DIV_ROUND_UP_ULL(num, rate); dev_dbg(ddata->chip.dev, "New real_period = %u ns\n", ddata->real_period); }