From patchwork Mon Nov 14 08:59:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Dimitrov X-Patchwork-Id: 19603 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2042452wru; Mon, 14 Nov 2022 01:03:24 -0800 (PST) X-Google-Smtp-Source: AA0mqf5dKER4XuZbNQapa6IMILFGWNTarh/0i8fB8lJgFd68vVi4rodOTfeolt0J8jwXvWemJC3o X-Received: by 2002:a17:906:d8d:b0:7af:883:ec72 with SMTP id m13-20020a1709060d8d00b007af0883ec72mr1314069eji.727.1668416603826; Mon, 14 Nov 2022 01:03:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668416603; cv=none; d=google.com; s=arc-20160816; b=Xa7shSIoYqnAZFlk62G6nHmSNPZ36c6BvgF1XacE8AavHaeVHJuSMxg2QFjVeYrERO HAiHzpfkIsiu8iez+3wa77vi8DXDxncv2uhvriCyd1LJUIZm6KkfW9/AiKcoXgsABtpD TdVi3tG8o7wmH2L4H/X31uWWK6DPg+2b61JSlT9BWZqsxAShjSlLV4a2pheHsDtMY6Oj N3hx8iN9luNDKGbjZxKhvymvJ6aAoreo97yFK/Uo6B0AIbjopoI/vhw5EW7NjcSCEOVs xIyVXJ9FOPrUA6pxo5z7CWxP6cP9h2ynrN+9BZJdG3DCkvwMVPYFN0jcc+vpHPoRKaxA CbRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=zivTwRXmaNmxNrJC3hUgTcp8c5Y6QenJRLPxm2W/9wQ=; b=m9XHvsIKbj1nC/OkyGyQq4wzUzXai8GBl8rgL35K7j6opvOrNyZkyMl2HJaeW8hk4u pEwkwDGbW1z7kYWG+ZRixeY8ZLUg8Bb+XN+99+XCYrxOh8HhESEz8Det7Ke/53bTPeNu JSjPjs6mJy+dfJrgrrrZMfcDrYKFebmyJh8Ypx6IdHMDZ2MnrnTgnNdKtzbm3saa+lHE B+0jrRmoF2GfX0owROQ6aOS5sLUBbmVHYwddDKeQD1kPzhNDDAapK9dDbZVqqcxhLJyY TSUOwxzACJnR1t8XX8LLcD9q/QNbUYPqZVwt9aybErPmSzfquMCUgT0w/e/D7/gNfbVQ vjRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=nCh0yDqG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ce11-20020a170906b24b00b007825bd02a6asi6678150ejb.54.2022.11.14.01.03.00; Mon, 14 Nov 2022 01:03:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=nCh0yDqG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236596AbiKNJAb (ORCPT + 99 others); Mon, 14 Nov 2022 04:00:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236248AbiKNJAY (ORCPT ); Mon, 14 Nov 2022 04:00:24 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 776461CB0E; Mon, 14 Nov 2022 01:00:23 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id x2so16289791edd.2; Mon, 14 Nov 2022 01:00:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zivTwRXmaNmxNrJC3hUgTcp8c5Y6QenJRLPxm2W/9wQ=; b=nCh0yDqGbkK6aBLZJlr0PdNha/yc+588+4hyoOT+hnjoZPFu26tvgcEsNgGaYJsMK4 5LITenI6CWkbLGA8a+aj4dTK1xm/PV1PSlsi80Kuzf4OwNI9c9VhXIA8AryYd6uC9xva V9Ntmo1V6NQsUe3YIffd+HTUl0LnEVqmmI8gjD5UjNHMmO5RnRjQ8z6DCLN0ZSFTrdZG HWtYcdxesnr477oOlJ0NJewjDDqaLKuKJNH7l5iO2UwXGbU3WipQN51fTU1SahifNXiS dHx5rj1+C2VmFX4RC7VW7isyPAchAH0uB0AykpcLsguyqfg4eRWUgsgAccW2SijAghqP a4Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zivTwRXmaNmxNrJC3hUgTcp8c5Y6QenJRLPxm2W/9wQ=; b=OHa5j1TcC1O4n994Or4j3fJU6kok4tWXqSacOq4VkuIOye//wKzokXbnmxq8Ud15jX P4+AI1rhiZDNEhuhZd6GeQOIu5IOWZ6ZNccL8vR9vMRLEuL4XltfdExTeLJaE+YfYMT+ HbiIt5t02IcCiO4AADYZB3r3PVkLcMdS18Xyw6Im/xprCRK8VvojHuRJ+6L43KPkEZrN tXAbjILQ4/RCRzJUBh9WIl0ADcnwFa18DazbJ5OMTlhH9UWnh6ZoL+k+mr4fxWjkVCCZ Sz7OpWQdBMxL9yQ4ylLGj2iJgNtrtzyrqLQmUSW7ZWhiFznlGJEulLNgv0e0e/3HkDoj J/sw== X-Gm-Message-State: ANoB5pkmaZYH0fiIzkrghJMjne5OGG7W9m6xIVdlxQ96mvzfdBV4jEn7 VKGGpH1FaVuxoCMAVW549r4= X-Received: by 2002:a05:6402:643:b0:462:5f37:5a22 with SMTP id u3-20020a056402064300b004625f375a22mr10203771edx.226.1668416421902; Mon, 14 Nov 2022 01:00:21 -0800 (PST) Received: from localhost.localdomain ([46.249.74.23]) by smtp.gmail.com with ESMTPSA id t2-20020a170906a10200b0078194737761sm3852490ejy.124.2022.11.14.01.00.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Nov 2022 01:00:21 -0800 (PST) From: Ivaylo Dimitrov To: b-liu@ti.com Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, tony@atomide.com, Ivaylo Dimitrov Subject: [PATCH] usb: musb: remove extra check in musb_gadget_vbus_draw Date: Mon, 14 Nov 2022 10:59:47 +0200 Message-Id: <1668416387-24984-1-git-send-email-ivo.g.dimitrov.75@gmail.com> X-Mailer: git-send-email 1.9.1 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749461609009056788?= X-GMAIL-MSGID: =?utf-8?q?1749461609009056788?= The check for musb->xceiv->set_power duplicates the check done in usb_phy_set_power(). Moreover, not calling usb_phy_set_power() results in current USB config max current not being propagated through usb_charger FW Signed-off-by: Ivaylo Dimitrov --- drivers/usb/musb/musb_gadget.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c index 6704a62..ba20272d 100644 --- a/drivers/usb/musb/musb_gadget.c +++ b/drivers/usb/musb/musb_gadget.c @@ -1628,8 +1628,6 @@ static int musb_gadget_vbus_draw(struct usb_gadget *gadget, unsigned mA) { struct musb *musb = gadget_to_musb(gadget); - if (!musb->xceiv->set_power) - return -EOPNOTSUPP; return usb_phy_set_power(musb->xceiv, mA); }