From patchwork Fri Jan 12 14:30:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 187761 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2614:b0:101:6a76:bbe3 with SMTP id mm20csp210827dyc; Fri, 12 Jan 2024 06:30:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IGcsdFrI3gWFvVd/1m5mQLi0ln151dq3wDalTA7AKrb+DCt4Lk61vn9UE1hhihjMtH3D5YZ X-Received: by 2002:a92:d784:0:b0:360:5cd9:a73e with SMTP id d4-20020a92d784000000b003605cd9a73emr1229589iln.6.1705069828205; Fri, 12 Jan 2024 06:30:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705069828; cv=none; d=google.com; s=arc-20160816; b=ejyUqLAv1EU1O3ULQGGF9ibjl6pJLiCLGo4l5/TVuDlodSOtwZBtjxLgG9wRpn3yyR g2qjNbzTZgBowtu/JbqlLzupERO/tpM0is18sgrSQiteN2BHpuSC0XuLaoKaKxA3P6Xy ClZ0hjCR+m04SWbmXg7/tn0xktLt1zsPE78Rc6qwLkhQPqY3G8DQNKCLrn7bk31XUeQo Hw4CYjnCr+/c7fexZzIeJlbPJh3Oy+mvNKIlAoLP/3quIx7CiyHM5q/rsgpaowqqxHGT 6cQqECqsmNmyU7jGBqYx8DyeXMUqTSSB3Om/NlXQbKG5q/8iPa05gjr0wpvaPsvKZxNb sUrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-disposition:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:message-id:subject:cc:to:from:date :dkim-signature; bh=z+wi6LxV5EZ0n10N9SHFswFNcko0BVzpNz628Oa0p9E=; fh=eAHM0G0ySFHpFF09klzedXDUw9aYLP6yPLh7pS32teg=; b=W+zRiN4y1MXh5tU7Q2mkA/0nn73EEkI4bm6Kqd+ugl53qmsIFQsd6HXN+4FPrwoU+N FQEsC3ZsBJ7fVc8DZUUppmlAPC73LR6Fczb1EzBr7x211zzujr4/ZYypHukf3y56OeXL uknZhBjzgCj+0ILVdEVmooTa9aWThwDcdtri4AKsc1P9LiWVFWRpUZvH2yN3BArzyYY0 /7izO0i8w4LSD7eaqRlLf7RZRsIXhCmhp38Ip4jwuuKlKGMX8Y3ec3WEugvXOmlckTvP t8Q3pj55LlEqxEZtJTi7vckErydst8VTxkaINbEuUYJ+ZnsW+kwHuBI6Lwjw7D7opgQA Zeww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fg78jlqL; spf=pass (google.com: domain of linux-kernel+bounces-24752-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24752-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id y67-20020a636446000000b005c65d0dd99fsi3316645pgb.505.2024.01.12.06.30.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 06:30:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-24752-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fg78jlqL; spf=pass (google.com: domain of linux-kernel+bounces-24752-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24752-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6DBF728530C for ; Fri, 12 Jan 2024 14:30:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 030CD6E2B9; Fri, 12 Jan 2024 14:30:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fg78jlqL" Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2D486DCF6 for ; Fri, 12 Jan 2024 14:30:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-40e60e137aaso17363425e9.0 for ; Fri, 12 Jan 2024 06:30:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705069804; x=1705674604; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=z+wi6LxV5EZ0n10N9SHFswFNcko0BVzpNz628Oa0p9E=; b=fg78jlqLaXCKFa/ziQkns4T/jKeR0o2I/la2AMYIazf1zPwK/LCeaUge6Z3inIcb++ Slx8xYafdHWNOKqWD1+Lcuarh0NJHuXdOrv8xCBI/QIKm1lv7FLtTMWffDnoEnVoMXyu ZNNJWI7p7FxtUA0nAEBCTZ2NUhiDKpWP8SbjjXWG77aTeuLCJ20VMrV30s5A0ZiIBl/Z NIe7I2wxR/XihVmjLVARsLYWTr/ogZ7TGalF7xOa95RaBb66LOqm6ZvhyXCTK6oH45kb 1ZU1ptJPTvVyXJhKtRx08b60nZhPQPeeisZRrIwE81+QV38IS9SlvxEgE+iYl0AA9Fms 7yKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705069804; x=1705674604; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z+wi6LxV5EZ0n10N9SHFswFNcko0BVzpNz628Oa0p9E=; b=o/M2XXPfIPp/ZkevFPZYa1nAUHkPLTN/atuuu1esJAMlvw0uXCk1fhS+Nz3Saq2+/0 DVxoC25tJLazl4a6eKlB8BRqf6AhT1NQttBM1uG2GHFwTPWR9W3ol53m9U6TLsCH91qg Bqv08qCyx1CRXP2PxFx86mXIlHaxJVGO43Ee2TQhchVj4JJbmeuywSdz+k/nvvqCYg/O Fs+WQWkSXZdRa8MxnjWmzkKeoK7ug+b/+01uEPeySGQbvyFcQGR4yQOs7QnrcocuV8Xv pl//a4kywCro0jWvqL+RdebqNAg4z3BNZhkNzXFEtwG8gLTXxNNzsgw9VDjAn50EGnbw btDw== X-Gm-Message-State: AOJu0Yx7g/sE8SeoGLbtQs8YlJHPBhxVOhC8kiPSoXxKGTwQRvnMghTc ZTSCsJqTuwOYNd4DoRSTzUCd+nq+SvzVzw== X-Received: by 2002:a05:600c:4ecc:b0:40e:500c:23d8 with SMTP id g12-20020a05600c4ecc00b0040e500c23d8mr791947wmq.151.1705069804093; Fri, 12 Jan 2024 06:30:04 -0800 (PST) Received: from localhost ([102.140.209.237]) by smtp.gmail.com with ESMTPSA id z10-20020a05600c0a0a00b0040e4bcfd826sm6116088wmp.47.2024.01.12.06.30.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 06:30:03 -0800 (PST) Date: Fri, 12 Jan 2024 17:30:00 +0300 From: Dan Carpenter To: Yang Wang Cc: Alex Deucher , Christian =?iso-8859-1?q?K=F6n?= =?iso-8859-1?q?ig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Hawking Zhang , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drm/amdgpu: fix return value in aca_bank_hwip_is_matched() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787895300166050855 X-GMAIL-MSGID: 1787895300166050855 The aca_bank_hwip_is_matched() function is type bool. This error path return -EINVAL which is cast to true, but it should return false instead. Fixes: 22a4fa4709e3 ("drm/amdgpu: implement RAS ACA driver framework") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c index 6074a529caf7..1d3ae7c241e5 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c @@ -182,7 +182,7 @@ static bool aca_bank_hwip_is_matched(struct aca_bank *bank, enum aca_hwip_type t u64 ipid; if (!bank || type == ACA_HWIP_TYPE_UNKNOW) - return -EINVAL; + return false; hwip = &aca_hwid_mcatypes[type]; if (!hwip->hwid)