From patchwork Thu Jan 11 16:27:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 187445 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2411:b0:101:2151:f287 with SMTP id m17csp1565158dyi; Thu, 11 Jan 2024 08:29:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IHZ1BYsW3AHRPPehxi6MNEuw38sXInxCTkPvmlDZqleL7kfk21wzrtJAmlD7rxVWIInB3rN X-Received: by 2002:a25:b94f:0:b0:dbe:9fe7:ef78 with SMTP id s15-20020a25b94f000000b00dbe9fe7ef78mr1391517ybm.21.1704990540584; Thu, 11 Jan 2024 08:29:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704990540; cv=none; d=google.com; s=arc-20160816; b=PmK4y2qbaSN2YZLpGYgPa/3LF3lGFhn8Fmm0hty/x91lnLhdlDqBzA5E6pD42CnFyu xPKOfgWcxOt9CDK0kQPusxSmHnprHk8J80GHfdHMA/Z2s7qwvL8oNzUHv35Cx5IHLvwV 4kAQz99XlgVHyyK4fKVJPTVwcr0udjfQDVDwATtpJbJ3+ICwUyspO4k+ATrPVURmjDMB LX3EismqQmE238d9vESphyu7K6ZQRoF/RymtfWc3rOq1nyf2OYM452Q8hi274Ad5Td0u biP/a/XI6RsXZmQFVmYdwFSvH3+kqY1YpOsaVS/VQAKhz+J3deHxqF+y8oYHBKJf2L+L 2XSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=O7MhKnY22Jh9eOE7rqL8yCz/y7dxEIceQIJ3x/0nPUc=; fh=OTsbeKk9FxRpayceDjOZ0CrjHuXZepYxhMXWRe+P6mw=; b=GNlsDWtavWJs0eSrq5yWmlKM48GaMyA+wd5FMLUjzKm8RDrUxy2SFgEExvGtAXkquc iwqv16mDwnVVGlPHa1GGAgTg88pDklXoqVvsYJICFjLH4zQtx5lfyrjRVx/ekc3cXmvr nP8EE75SLPA/NyEI+yRteYvKQAWyRYA6KWCVJEw5GT8jLVcNtMAgR/5VWZDsWdr+L9x1 KXPSDtdOwHiPCP/oMW4qjMixFNxBEsnRNTqbwTo/v8vO+ByZhqJX2tCVSYbai2A6Idsi m+6MpGdl6f1991jJ6D5HuuWiISu1icqmSE//3NSSzE2j5TRcp2Kwxqz7JGe8OjiodTwA k2Ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hvYf1RF6; spf=pass (google.com: domain of linux-kernel+bounces-23866-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23866-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 4-20020ac85704000000b00429c64728cesi1037250qtw.181.2024.01.11.08.29.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 08:29:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-23866-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hvYf1RF6; spf=pass (google.com: domain of linux-kernel+bounces-23866-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23866-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6003A1C23A8B for ; Thu, 11 Jan 2024 16:29:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3EC5C50255; Thu, 11 Jan 2024 16:28:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hvYf1RF6" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B5AF4F89C; Thu, 11 Jan 2024 16:28:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24BD9C433F1; Thu, 11 Jan 2024 16:28:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704990519; bh=wOlw6k8oeC5WKfVf/WyGf04YxAUDhKpIuRBaG8SWzXg=; h=From:To:Cc:Subject:Date:From; b=hvYf1RF6DuM/eVkHhjtTnrm4XHlLDo7AH1VNzHShDw1mFxJhgPvSmSoODMm2I3D75 Dxh0yBW7wvX9tr5/wPuDviqS9VfriM8H+JjVDIVsoq4J0ypKM+KgzhSCS4KTfZh972 WeFKbC8kWdlzezOM4M3gAgvP/KtoCKDhUlijhfmientVwgiBHTDKuKtLyBP1LdXKr8 KtGRgGaGIkOrYch0RL7PC3sWIVrdkAIbs/6++VdxZtixlW8G9WIHB5zdSQHVnieGyE iBRNA/w8hR2ZGny1QGQCsF8KYUsisgjyrMqkkO0vdkG1KMOP5857vaZVKGKo0Uv2Ot DcE/6Heg1ZCVg== From: Arnd Bergmann To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Arnd Bergmann , Jiawen Wu , Mengyuan Lou , Russell King , Andrew Lunn , Maciej Fijalkowski , Andy Shevchenko , "Russell King (Oracle)" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [net-next v2] wangxunx: select CONFIG_PHYLINK where needed Date: Thu, 11 Jan 2024 17:27:53 +0100 Message-Id: <20240111162828.68564-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787812161217054780 X-GMAIL-MSGID: 1787812161217054780 From: Arnd Bergmann The ngbe driver needs phylink: arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_nway_reset': wx_ethtool.c:(.text+0x458): undefined reference to `phylink_ethtool_nway_reset' arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_main.o: in function `ngbe_remove': ngbe_main.c:(.text+0x7c): undefined reference to `phylink_destroy' arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_main.o: in function `ngbe_open': ngbe_main.c:(.text+0xf90): undefined reference to `phylink_connect_phy' arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.o: in function `ngbe_mdio_init': ngbe_mdio.c:(.text+0x314): undefined reference to `phylink_create' Add the missing Kconfig description for this. Fixes: bc2426d74aa3 ("net: ngbe: convert phylib to phylink") Signed-off-by: Arnd Bergmann Reviewed-by: Andrew Lunn --- This addresses a build regression in net-next at the moment, it would be good to have the fix merged into net-next before it makes it into mainline. v2: As suggested by rmk, remove the PHYLIB reference in the process, since PHYLINK requires that already --- drivers/net/ethernet/wangxun/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig index 23cd610bd376..85cdbdd44fec 100644 --- a/drivers/net/ethernet/wangxun/Kconfig +++ b/drivers/net/ethernet/wangxun/Kconfig @@ -26,7 +26,7 @@ config NGBE tristate "Wangxun(R) GbE PCI Express adapters support" depends on PCI select LIBWX - select PHYLIB + select PHYLINK help This driver supports Wangxun(R) GbE PCI Express family of adapters.