From patchwork Sun Nov 13 15:49:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 19376 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1732585wru; Sun, 13 Nov 2022 07:53:49 -0800 (PST) X-Google-Smtp-Source: AA0mqf6FO96JOZzFqZf1zqPckNituSF/ztjJrKuJSCYKJSh+aes9YriXHooW+NRPuhofHFcWexPM X-Received: by 2002:a17:902:e40c:b0:186:880c:167a with SMTP id m12-20020a170902e40c00b00186880c167amr10226257ple.165.1668354829548; Sun, 13 Nov 2022 07:53:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668354829; cv=none; d=google.com; s=arc-20160816; b=MDfPkKH/qTjrmexiIVPSGSsXH0CBlJbHXzVWnmB8ceS96d1KYNeWS03oQ9CbK9a94R AU312MEKHnwBZxFjm5azk15AUby65eFakue+Mb+dJMg6d2xry4kCggmRE7E60nqD8AYP cyXFQcgvLlEwUcihjopr8y1AhYqngWgWh/pE4ccr6K1xGWdRy1QSGN1eRCzJERkRgYh6 GNJ/MOLwzyfL0xDLUVTcVUmYPob8CScpDfEcOiJ/F8aOstsbHAX1vqW2N5dSeGZhsnAS iux9CMMv0uXD77m1Jlg0TOAKZgiEL6HmwgamKTc8o9y1xS6gWBLhBU5S9oW0WIdcQvob e+sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=3V2KVznZkr6yAhsXAKAHxuC05v2JFcez2hto47mbuac=; b=Ne1oO8X1V3yo73T7XGu1w/68RgV2XBHhJx0/AQxBo7rxQnMm70A9MIlmMJRqg8dJHQ kDg7LoNNvjuf6uXO5aajUNdMmJ/6AdXVgWbosBSgRccG0w8P3TvHLSzRUBM27r3kAUfS vloXup3B9yrAY2GhwbJIvPSaf4GUJTaAxwmTT2vT2YaTz4tyGUazUS1mGYSCWJIzRfRk 5Ks9qua7fuI3avnWTEdCE7PRe0FPLkDjpZTCeAuWsc4ZKE5kDuGhS+Ro6NtolNja8xWg yVwFhafCQAjyti9NaNf9oOB/hoSJprTff4YlxcTmMC0WOPXUsfPHxyYVKpjYowZJoBwx su/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y35-20020a056a001ca300b0056de69b0c78si7124112pfw.286.2022.11.13.07.53.33; Sun, 13 Nov 2022 07:53:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235318AbiKMPt3 (ORCPT + 99 others); Sun, 13 Nov 2022 10:49:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234264AbiKMPt1 (ORCPT ); Sun, 13 Nov 2022 10:49:27 -0500 Received: from smtp.smtpout.orange.fr (smtp-18.smtpout.orange.fr [80.12.242.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 873B5B481 for ; Sun, 13 Nov 2022 07:49:26 -0800 (PST) Received: from pop-os.home ([86.243.100.34]) by smtp.orange.fr with ESMTPA id uFEXoEoZTXaJmuFEYoHaCh; Sun, 13 Nov 2022 16:49:24 +0100 X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sun, 13 Nov 2022 16:49:24 +0100 X-ME-IP: 86.243.100.34 From: Christophe JAILLET To: Ping-Ke Shih , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] wifi: rtw89: Fix some error handling path in rtw89_core_sta_assoc() Date: Sun, 13 Nov 2022 16:49:18 +0100 Message-Id: <7b1d82594635e4406d3438f33d8da29eaa056c5a.1668354547.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749396833944858512?= X-GMAIL-MSGID: =?utf-8?q?1749396833944858512?= 'ret' is not updated after a function call in rtw89_core_sta_assoc(). This prevent error handling from working. Add the missing assignment. Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver") Signed-off-by: Christophe JAILLET Acked-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw89/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw89/core.c b/drivers/net/wireless/realtek/rtw89/core.c index e716b96d0f56..f30aadc41f2b 100644 --- a/drivers/net/wireless/realtek/rtw89/core.c +++ b/drivers/net/wireless/realtek/rtw89/core.c @@ -2535,7 +2535,7 @@ int rtw89_core_sta_assoc(struct rtw89_dev *rtwdev, } /* update cam aid mac_id net_type */ - rtw89_fw_h2c_cam(rtwdev, rtwvif, rtwsta, NULL); + ret = rtw89_fw_h2c_cam(rtwdev, rtwvif, rtwsta, NULL); if (ret) { rtw89_warn(rtwdev, "failed to send h2c cam\n"); return ret;