From patchwork Mon Jan 8 08:18:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pin-yen Lin X-Patchwork-Id: 185837 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:37c1:b0:101:2151:f287 with SMTP id y1csp890062dyq; Mon, 8 Jan 2024 00:19:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IFXLvH7wrOnKWPOfubf7RjXhrDoL0lS9En7Tr3yAMBKhPnpi1q58HvoZOAEAyJcuEVMTWtL X-Received: by 2002:a05:6e02:3101:b0:35f:aba9:1031 with SMTP id bg1-20020a056e02310100b0035faba91031mr6303768ilb.126.1704701948922; Mon, 08 Jan 2024 00:19:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704701948; cv=none; d=google.com; s=arc-20160816; b=iInLk4KCnRCZFIrscRcAL3J7Lnyi82t4W+mkCj++umJ82YU1e2eEpZjSPinVBENmAo Zjm/glbg6fIL0Nv+NppOK0lP9IvvG1QbpYSXOhlFhWjIPQ6cLKHu3dCZo/ldiYMZmH2f 7NdM1e6kG5k2hHPpYXOA34HF+4sztKFDnc+iZKvgWaIL8COFUuCG+8YxmG6eDbyBNasw U3Esm4zOaJVDCWEaRJ9FAydbGv0q5CTNmi3P/Aj8YXTmJyVP4hGvnXm2tkTp5Aj9fyrD +Rrn5BRRNpUBaPjw4ox9wEw++mOab5exs0GwEIoH5S0IkAJQF94PALvc207eBoa3b5/h 2ijQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=xNB8eseBc6is+G1DowRroY47UdkWdAr6xj971vFYoJE=; fh=fPdquzm+9LuuJ1J/Hwd5PA6zjMSXShuxeZpvBr14aW4=; b=rPcnHMt1NxRr/X4wqyV+CW6wtEAQiFwGnQfIHKA1elMT2M+d6UdawfShvJZZd+CFCs 2rR3UB7Fqs0NAJxTUj7Hl494lpeJWolq+EwxLQmpuaRQszqJNZ2/a8hKsb6OW2DUVo3X zNwV0n0AXfL2uZ4e2hp4RIUyTbDPpHOtasMKV99m3TrbM540k6JR0i1W0XPXaVDOH43j RRJlSAaRXQxl8dvxIT3uf1ipi0nqOqU89Z7UB/el4klBWKwoQOpSSKp4SRPn0Qhczo66 Usorsvv/RuQEcpzwq7cTJ+zb5ZNE9uMz8qTkC7syWPyiHE0rKOQuELZZo6OCyrThfIHv vdyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=FndB4o7Z; spf=pass (google.com: domain of linux-kernel+bounces-19176-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19176-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id b30-20020a63715e000000b005ce02d8ef08si5688324pgn.884.2024.01.08.00.19.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 00:19:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-19176-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=FndB4o7Z; spf=pass (google.com: domain of linux-kernel+bounces-19176-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19176-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id E6460B213B7 for ; Mon, 8 Jan 2024 08:19:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 31E68BE4C; Mon, 8 Jan 2024 08:18:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FndB4o7Z" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ED7BB661 for ; Mon, 8 Jan 2024 08:18:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1d4df66529bso2674505ad.1 for ; Mon, 08 Jan 2024 00:18:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1704701920; x=1705306720; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xNB8eseBc6is+G1DowRroY47UdkWdAr6xj971vFYoJE=; b=FndB4o7ZuxG/C0uqLE3o6CFfYSHJd3myJpCrSCU1PxzFB0CLR7UauvbOsjZ1fKusEw 4lbZXn5nGRjNT5x0/P2sOfOlERYYg7yik6PHV+3W51QUS4nUNOUiX5LiH8rud1noDK61 I4iZZHhcW5UkB7wONwtHUwF+5HJ6hfWTFyMy8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704701920; x=1705306720; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xNB8eseBc6is+G1DowRroY47UdkWdAr6xj971vFYoJE=; b=WFuwKsTqDenafzvI19Za+iPR4tg3wncUZWCYWyyHAfHmt3mnCu8U+zvbA+yyL/VMdb UCNnzJUv/+ZsRRl9AA3fVjNdc24ubwRHmekO3F7vqS/Y3DAq0Af8NCy/CuD5+46r0FK1 SVOVmVwP/68UqDJKZ+9XwYUyZoq/Qv8DVYyzfP4XwCwIDu3Yp3wV3lTWPhohYoWeNzoV xT6byQsquqIqT/ANTgCKcwYP0rYhcGfZg+nTruZjJNBqFrLOZqqTImz03OS7r7Ap61vo 7dGLNoQnHKO9QNn2xO2EiZfoqnV6Lw1U+tvkfK2gtpkjNw6ywi4qbCU+9XdVU2KDnXwu KGdA== X-Gm-Message-State: AOJu0YwejYiNkb9RvElB8CfsjV8rc30WxyebBTmsod2dlIv6KunFKMYr cbecwHUl0T263W5ri18ITOWxUvesVE22 X-Received: by 2002:a17:902:8a88:b0:1d4:be64:263f with SMTP id p8-20020a1709028a8800b001d4be64263fmr1076115plo.120.1704701920600; Mon, 08 Jan 2024 00:18:40 -0800 (PST) Received: from treapking.tpe.corp.google.com ([2401:fa00:1:10:6859:f8da:3370:7a74]) by smtp.gmail.com with ESMTPSA id jj4-20020a170903048400b001d078445059sm5672513plb.143.2024.01.08.00.18.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 00:18:40 -0800 (PST) From: Pin-yen Lin To: Michael Turquette , Stephen Boyd , Matthias Brugger , AngeloGioacchino Del Regno Cc: Pin-yen Lin , Chen-Yu Tsai , Weiyi Lu , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 1/2] clk: mediatek: Introduce need_pm_runtime to mtk_clk_desc Date: Mon, 8 Jan 2024 16:18:15 +0800 Message-ID: <20240108081834.408403-1-treapking@chromium.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787509550588218646 X-GMAIL-MSGID: 1787509550588218646 Introduce a new need_pm_runtime variable to mtk_clk_desc to indicate this clock controller needs runtime PM for its operations. Also do a runtime PM get on the clock controller during the probing stage to workaround a possible deadlock. Signed-off-by: Pin-yen Lin Reviewed-by: Chen-Yu Tsai --- Changes in v3: - Update the commit message and the comments before runtime PM call Changes in v2: - Fix the order of error handling - Update the commit message and add a comment before the runtime PM call drivers/clk/mediatek/clk-mtk.c | 19 +++++++++++++++++++ drivers/clk/mediatek/clk-mtk.h | 2 ++ 2 files changed, 21 insertions(+) diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c index 2e55368dc4d8..ba1d1c495bc2 100644 --- a/drivers/clk/mediatek/clk-mtk.c +++ b/drivers/clk/mediatek/clk-mtk.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include "clk-mtk.h" @@ -494,6 +495,18 @@ static int __mtk_clk_simple_probe(struct platform_device *pdev, return IS_ERR(base) ? PTR_ERR(base) : -ENOMEM; } + + if (mcd->need_runtime_pm) { + devm_pm_runtime_enable(&pdev->dev); + /* + * Do a pm_runtime_resume_and_get() to workaround a possible + * deadlock between clk_register() and the genpd framework. + */ + r = pm_runtime_resume_and_get(&pdev->dev); + if (r) + return r; + } + /* Calculate how many clk_hw_onecell_data entries to allocate */ num_clks = mcd->num_clks + mcd->num_composite_clks; num_clks += mcd->num_fixed_clks + mcd->num_factor_clks; @@ -574,6 +587,9 @@ static int __mtk_clk_simple_probe(struct platform_device *pdev, goto unregister_clks; } + if (mcd->need_runtime_pm) + pm_runtime_put(&pdev->dev); + return r; unregister_clks: @@ -604,6 +620,9 @@ static int __mtk_clk_simple_probe(struct platform_device *pdev, free_base: if (mcd->shared_io && base) iounmap(base); + + if (mcd->need_runtime_pm) + pm_runtime_put(&pdev->dev); return r; } diff --git a/drivers/clk/mediatek/clk-mtk.h b/drivers/clk/mediatek/clk-mtk.h index 22096501a60a..c17fe1c2d732 100644 --- a/drivers/clk/mediatek/clk-mtk.h +++ b/drivers/clk/mediatek/clk-mtk.h @@ -237,6 +237,8 @@ struct mtk_clk_desc { int (*clk_notifier_func)(struct device *dev, struct clk *clk); unsigned int mfg_clk_idx; + + bool need_runtime_pm; }; int mtk_clk_pdev_probe(struct platform_device *pdev); From patchwork Mon Jan 8 08:18:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pin-yen Lin X-Patchwork-Id: 185838 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:37c1:b0:101:2151:f287 with SMTP id y1csp890088dyq; Mon, 8 Jan 2024 00:19:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IFK+XDZxvicfwvXzVG6yYG9l3aldC0vC93Itxo2wuW3roNGRPmCXz9MtKGS8xM2SLdCdhD4 X-Received: by 2002:a05:6a21:a59b:b0:199:fd5:6376 with SMTP id gd27-20020a056a21a59b00b001990fd56376mr4673396pzc.95.1704701955523; Mon, 08 Jan 2024 00:19:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704701955; cv=none; d=google.com; s=arc-20160816; b=oqrUwQZY/Kll+JhErf14r/I6MvBTEFSMtqg6WMkf5y+U/JuuTo/UIDAQHD5x8miVQT Pld/14DwTLD/ZK5xAtXh0LOz5bpq8+W+P8x387hNybEAPGvWtWk9aXizQE2aBdRuJ11V oUUsXcCdtXkeQHocLGDkjuHRCxp3jF1Kt3pK7Jm1u5hjBa8K9bXAvvoSPg6WM2Y0w/et fWqOPUKxmjN8qYaUSdSaZb5eup0Q50VT/G/0tzUfuqmFt9pSFQ6EZFM+lSzHmd9szH7t EXWXQRL8DUXIMPOXBnlT+7mlnzEUzXWeJ74RbiIXoHxvHNMLcWhKLRg0TLvhc/ApfmBZ jfuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=PajgPkTBW3iluxw6UIGchSAnGs+6/xnB8PBfDDEr3ic=; fh=fPdquzm+9LuuJ1J/Hwd5PA6zjMSXShuxeZpvBr14aW4=; b=j1yv5rbGQu2UoL7KpnZdmOb0W7m9Mv3J7PacuiGsstXU8r9aYqgwENqjB6PuWkbreg qeXbETJbzFuW+EKBBdWEUQ/1vF2Gyi/O+KfXAU5QN0Ghje2NcDmqxlB+Ae6IKNz7sg00 T4JZExSrtntmRVmavbdNGySiGqnmDeuucZodTVEBXHa3sPd32ZjgMwLbWyJZJMg3Soej uYaL8eZfKJ9SpkzgwRqWKXXPRrlhWnLQErH7LQFBn2bKgOljUtAHrVuFeAo/ZK9U2dGT C1DmkoKSW7PDqjH8+zTuc3FZk06PV34xhnx9xHOlw3KHy2OjmGggkiala4Qaqxn/eFIw q0Hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=eSIDp8pI; spf=pass (google.com: domain of linux-kernel+bounces-19177-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19177-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id m185-20020a6326c2000000b005cecc2f4132si5858628pgm.69.2024.01.08.00.19.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 00:19:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-19177-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=eSIDp8pI; spf=pass (google.com: domain of linux-kernel+bounces-19177-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19177-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 53116281107 for ; Mon, 8 Jan 2024 08:19:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8B7FFD272; Mon, 8 Jan 2024 08:18:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="eSIDp8pI" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0AA8B665 for ; Mon, 8 Jan 2024 08:18:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1d45f182fa2so13319485ad.3 for ; Mon, 08 Jan 2024 00:18:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1704701923; x=1705306723; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PajgPkTBW3iluxw6UIGchSAnGs+6/xnB8PBfDDEr3ic=; b=eSIDp8pIUHRUnRMpRxvShBcC93mhY4GBatmmS/Et4yMbFzihxilFXskFnVeRsq1UR+ azfv0ojCvJMg5TCEURzdYa1TkJttmljkwoaP0BfNHFSQHyO8jWiCCQoORok67sVUWRwG zgO566agMWhFxA279kj/GOPpZWNG5g4RMgJ60= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704701923; x=1705306723; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PajgPkTBW3iluxw6UIGchSAnGs+6/xnB8PBfDDEr3ic=; b=wOyEqkyycfGhFuJW/LnVwCN5F+ofV+c5IEQ0XFhWYY5lFpW6qft6AqRKrWBab3kLP4 GRED9yDw44iasM15O0DhtfC3m0HMn/L5z0ywRHEaPc/YfsEKXr9y5N+jIX8mrK7MFGdQ 7fWkaqd6vwf08fnUQtOIbvbQDAvycgCILGqYebNRm1eYQc/aAZKFoYekQPFlrGcGaCPp DlrF8JcacfbcgwWZkNahgaFvCcIwWTt9/YxwuumepiQV2hMYmfTnRK1NGJoGXHZUjCYD urb8zCgWbocvW54vcdITYuqUTjxXYvnJ7EugzUQBdyKgPZOpFnVKnzT+RTlMYCHR/FmV TcZA== X-Gm-Message-State: AOJu0YxhgcbBlOj/8NAq9WFt743aP0akTQarn4NFjX1X18Q3EwvxEva5 QAgxxF3rBETtbsPbJkBCM8lzWYIj8s4A X-Received: by 2002:a17:902:dac5:b0:1d0:6ffe:9f5 with SMTP id q5-20020a170902dac500b001d06ffe09f5mr4245569plx.83.1704701923020; Mon, 08 Jan 2024 00:18:43 -0800 (PST) Received: from treapking.tpe.corp.google.com ([2401:fa00:1:10:6859:f8da:3370:7a74]) by smtp.gmail.com with ESMTPSA id jj4-20020a170903048400b001d078445059sm5672513plb.143.2024.01.08.00.18.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 00:18:42 -0800 (PST) From: Pin-yen Lin To: Michael Turquette , Stephen Boyd , Matthias Brugger , AngeloGioacchino Del Regno Cc: Pin-yen Lin , Chen-Yu Tsai , Weiyi Lu , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 2/2] clk: mediatek: mt8183: Enable need_runtime_pm on mt8183-mfgcfg Date: Mon, 8 Jan 2024 16:18:16 +0800 Message-ID: <20240108081834.408403-2-treapking@chromium.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240108081834.408403-1-treapking@chromium.org> References: <20240108081834.408403-1-treapking@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787509557244586479 X-GMAIL-MSGID: 1787509557244586479 mt8183-mfgcfg has a mutual dependency with genpd during the probing stage, so enable need_runtim_pm to prevent a deadlock in the following call stack: CPU0: genpd_lock --> clk_prepare_lock genpd_power_off_work_fn() genpd_lock() generic_pm_domain::power_off() clk_unprepare() clk_prepare_lock() CPU1: clk_prepare_lock --> genpd_lock clk_register() __clk_core_init() clk_prepare_lock() clk_pm_runtime_get() genpd_lock() Do a runtime PM get at the probe function to make sure clk_register() won't acquire the genpd lock. Fixes: acddfc2c261b ("clk: mediatek: Add MT8183 clock support") Signed-off-by: Pin-yen Lin Reviewed-by: Chen-Yu Tsai --- (no changes since v1) drivers/clk/mediatek/clk-mt8183-mfgcfg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/mediatek/clk-mt8183-mfgcfg.c b/drivers/clk/mediatek/clk-mt8183-mfgcfg.c index ba504e19d420..62d876e150e1 100644 --- a/drivers/clk/mediatek/clk-mt8183-mfgcfg.c +++ b/drivers/clk/mediatek/clk-mt8183-mfgcfg.c @@ -29,6 +29,7 @@ static const struct mtk_gate mfg_clks[] = { static const struct mtk_clk_desc mfg_desc = { .clks = mfg_clks, .num_clks = ARRAY_SIZE(mfg_clks), + .need_runtime_pm = true, }; static const struct of_device_id of_match_clk_mt8183_mfg[] = {