From patchwork Sat Jan 6 22:39:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 185693 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:37c1:b0:101:2151:f287 with SMTP id y1csp307526dyq; Sat, 6 Jan 2024 14:40:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IHS6QPUrMu9Awcz4eEBdndBsQqYgsLYhq+Lc4fMnB/9XMZS/GMrc5Pgtq0uDwJOhreq4mub X-Received: by 2002:a05:6a20:4f2a:b0:199:6afd:2dd7 with SMTP id gi42-20020a056a204f2a00b001996afd2dd7mr1646062pzb.31.1704580832568; Sat, 06 Jan 2024 14:40:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704580832; cv=none; d=google.com; s=arc-20160816; b=haXQyzGByT2hSS0076AEIPqLk3ptV5wvvpwoq9FOVR6A2/KHW1QQ/qW1NK0Yl7xozW k0MgmTA2VbvQWDRENGN2JL6ZKmC0E9WMFn3aDnusNEjCrdVr2w5PKnIPtI/QWDkZypbn YHpLbqOwGk5maQiWQqw4g4vAva655cFnW8an8WkVffZ8ul8zCr7gEcrzY+1O5nnyvnrv lhpYy2iMXEr5fFjQReKLLfDgwY7uJgaRNdbflVy2VcAyN5lCREZXt/je6IMexyms8osX DFMCE6Tei2mpDaR2q15pxal15HCA3chKH8Y0l3svSIrqQ4i6v7UDttQG+Jz4O1+l549o M6KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=c8cx4G027Gz6iFuAIfhaAQlzyB7pPX4ipODK9kWLrHg=; fh=TypOn8P2dp2B8fhSBSogPJzm8rAGmHr9lmpeZW/DvuY=; b=gwK0L3qGJAlSh2cMnirVF34Mdq0GRUmZKxuN67p7LqajLH5gKXr1d5RhSy3uvbap2u OERIql/esgVTnd87EO2FqdzvbzfeV+bpex2ShxKx/xuxkf05yo3tsru3aPcDJTzZ7saD Tg6PrJ/18JfvipjjWCRSvQYTXse5hkYnow8rUAP0uTrZRfX+S8VpTwpxgrGjlLqKE2vQ LLgDCX3BPIbzJC5sT/cbjV/K70v+/872SEFeA5fAYeNMzS5XB00B3N6xGNz18KH4P5ar D0QWA+NFvC/j362Y+H5COIpQzoFxxKf86jIOSpRXgqiEsrp2k6K1T7jXg8qSb7KA2Ml5 7lfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=b4uLV6oU; spf=pass (google.com: domain of linux-kernel+bounces-18732-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18732-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id l9-20020a056a00140900b006dab362a565si3617380pfu.117.2024.01.06.14.40.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 14:40:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-18732-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=b4uLV6oU; spf=pass (google.com: domain of linux-kernel+bounces-18732-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18732-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5AE46282243 for ; Sat, 6 Jan 2024 22:40:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5520B10948; Sat, 6 Jan 2024 22:40:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b4uLV6oU" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A294101DB; Sat, 6 Jan 2024 22:40:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-7ba8e33dd0cso40709239f.0; Sat, 06 Jan 2024 14:40:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704580804; x=1705185604; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=c8cx4G027Gz6iFuAIfhaAQlzyB7pPX4ipODK9kWLrHg=; b=b4uLV6oUIW5+bjhHmJXZMwI1o19KJ0VO/PC+GzwryYc0hcBeL4pPRjGFB+lPXA8qGj pAGcXXkRWvR1XhTtCFT033Xu5mo24w571QorytCXimSv6+QqAopjZ6ldIJbpNGg2P6FO rhltdVCBdRL9mHDRf0nH/LUlZ7/gBpKz3BM0z4Bdglfhf0MB8BHJnKK55kQDH7t6uAB8 bYtHURLnU5xTl6SFQua2XH6/D0AvQGjmbpUz+LQE3ZpuoWgoSzz1h+LxThw96Tyl5zcF /KYoch82dDPaZ0xmQ6k8IvLFh5lzGUueUkhqJQQH6P6TarK28ZTzdvhHxAEYVAUu0UFQ T8GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704580804; x=1705185604; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=c8cx4G027Gz6iFuAIfhaAQlzyB7pPX4ipODK9kWLrHg=; b=ZvfBVQUVCmETVQtnzX+ELFDZ875QQjqoIQ7OL4RPVa6jFkYD9Ccel9gRltaaEJn0ZF rGl7WVzXSyPvYjtxETReffdLR2YznKgPNY4Upa94Wzl2LJ2NWvYbs3/lwe8OViZdqvkF 6Wep6YI7BN9b0tuBTLwxKiyITZIriyJU1fe8WmtYUjFJRRhzJGHorfFp6gXeh6juXVw7 MVcGSbivOfjZfHuCRCu5NDA9kcZS8+f+0MfodWtV6KjlPTX2EWgN50GKZJt8wsoU5E6+ hVD8iVPl1SI7S0zyv3JxkNOwZyhJgKlg2JkwLPI+8mxQQeQd+7lEb1do7dVNpSoQYvn4 /vcg== X-Gm-Message-State: AOJu0YyGgBj9UIJwC+lW40yHywuqeuQribgl2eZDCIq/ojs5q030lGrB FgtprvFO0GMBepOYmuG3eP+u2KWQ8nRyHw== X-Received: by 2002:a05:6e02:16c7:b0:35f:f707:46ed with SMTP id 7-20020a056e0216c700b0035ff70746edmr2343459ilx.5.1704580804057; Sat, 06 Jan 2024 14:40:04 -0800 (PST) Received: from aford-System-Version.lan ([2601:447:d002:5be:af2f:17f0:33a3:d6fe]) by smtp.gmail.com with ESMTPSA id l13-20020a056e021c0d00b0035ffe828182sm735346ilh.37.2024.01.06.14.40.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 14:40:03 -0800 (PST) From: Adam Ford To: linux-pm@vger.kernel.org Cc: Adam Ford , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Ulf Hansson , Lucas Stach , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] dt-bindings: soc: imx: add fdcc clock to i.MX8MP hdmi blk ctrl Date: Sat, 6 Jan 2024 16:39:48 -0600 Message-ID: <20240106223951.387067-1-aford173@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787382550982218564 X-GMAIL-MSGID: 1787382550982218564 Per guidance from the NXP downstream kernel, if the clock is disabled before HDMI/LCDIF probe, LCDIF will not get pixel clock from HDMI PHY and throw an error. Fix this by adding the fdcc clock to the hdmi_blk_ctrl. Signed-off-by: Adam Ford diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-hdmi-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-hdmi-blk-ctrl.yaml index 1be4ce2a45e8..741b5d8da4bb 100644 --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-hdmi-blk-ctrl.yaml +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-hdmi-blk-ctrl.yaml @@ -42,8 +42,8 @@ properties: - const: hdmi-tx-phy clocks: - minItems: 4 - maxItems: 4 + minItems: 5 + maxItems: 5 clock-names: items: @@ -51,6 +51,7 @@ properties: - const: axi - const: ref_266m - const: ref_24m + - const: fdcc interconnects: maxItems: 3 @@ -82,8 +83,9 @@ examples: clocks = <&clk IMX8MP_CLK_HDMI_APB>, <&clk IMX8MP_CLK_HDMI_ROOT>, <&clk IMX8MP_CLK_HDMI_REF_266M>, - <&clk IMX8MP_CLK_HDMI_24M>; - clock-names = "apb", "axi", "ref_266m", "ref_24m"; + <&clk IMX8MP_CLK_HDMI_24M>, + <&clk IMX8MP_CLK_HDMI_FDCC_TST>; + clock-names = "apb", "axi", "ref_266m", "ref_24m", "fdcc"; power-domains = <&pgc_hdmimix>, <&pgc_hdmimix>, <&pgc_hdmimix>, <&pgc_hdmimix>, <&pgc_hdmimix>, <&pgc_hdmimix>, <&pgc_hdmimix>, <&pgc_hdmi_phy>; From patchwork Sat Jan 6 22:39:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 185694 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:37c1:b0:101:2151:f287 with SMTP id y1csp307604dyq; Sat, 6 Jan 2024 14:40:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFQ8sSWilz3V3LJzvyQ76oYbRzxLMrv3gjE1m5ULz6eZH5VzqbkLjLSh7LlH9IsxBoXQNyu X-Received: by 2002:a05:600c:5407:b0:40c:2c36:2a23 with SMTP id he7-20020a05600c540700b0040c2c362a23mr791726wmb.180.1704580851087; Sat, 06 Jan 2024 14:40:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704580851; cv=none; d=google.com; s=arc-20160816; b=gDC1ZAWrdtCUe4J5s+eTebkQ1vkec9wFFZvTcc1PapS8NCSUzuBwUrjmoXiFQFPRQ9 l/juaOr3OWAe6Ek2u1rPBSEdsjPjQYq2ySLLrkoNMbp1h9yWWdczv9KfpSXzKcfpUY/6 aqtmcVpgH/g8fya6Fdzx0PtVtoPa4qa9jL2vYcVqPt5H2OouO1vgII/6x09SGnj6FGhq 0Caum7Y1nst4d5Ua//VO71lDiw0crVxwyq4iet9hA6mK6Km7E+INGsOaUZIcJJu+jyyJ Dvr++iFwoL6ihqVieka6iVZlIBjX+0V7qmq/59/JEs7OghrBU3qkmMygJSWJ4BB/p7cq lYYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=pjMgdeRpctwTJ7F3CFnuysHXKhIpRAp8TwJ6AUfLDG4=; fh=wWDtD32YjFo6T5hANCl4Ux6OekDxLZ6AKidCvR5NXPg=; b=qMxSxUlYPfFK+7lnngHO9XfbGQcatKB3Jf1RcmgUl2oUvvOVxv24d7KzayhkuKm55S unVIoM41A4e9lp5czCgK5gobhXwT0MqXcpnRuf/KHedyhuuP6H2ejkA1DjR/tGfuDuG7 OS2q+a7OHl4ZEynWTESODFZ4PXlocKdB199vLr0XaVMdt799EIVVDoBSu4Nz6j0rkPNi K73pyLyYHqDfgv9htKoBFf6xnjYv5xhBVUIt+vIfPjji7uyKBzLLCHOUaPBmtywe4mkS lEGcoKdGkJUERRGs8L68krKei4ffnBsk4oM/tfM6bFljXNXLpL1fdhaMPai1Pg9OMRgS TfqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=cgOP3q4p; spf=pass (google.com: domain of linux-kernel+bounces-18733-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18733-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id e18-20020a1709062c1200b00a2a43358c95si175451ejh.783.2024.01.06.14.40.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 14:40:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-18733-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=cgOP3q4p; spf=pass (google.com: domain of linux-kernel+bounces-18733-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18733-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id AE8441F22054 for ; Sat, 6 Jan 2024 22:40:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E436210A0E; Sat, 6 Jan 2024 22:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cgOP3q4p" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D5B4101E3; Sat, 6 Jan 2024 22:40:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-7ba8e33dd0cso40710339f.0; Sat, 06 Jan 2024 14:40:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704580806; x=1705185606; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pjMgdeRpctwTJ7F3CFnuysHXKhIpRAp8TwJ6AUfLDG4=; b=cgOP3q4p95nx0zj5ZtKQ7kGZqSW23grCuabNMXaiXOFQjzzU97RI4y7zXClkW24kxF j/wCoxYxZZDlCVK8gmrcFWY3iKbzDNP9Gn9WH0BirU/abG/oR8HtClJPWd+Vih7vPbiU Uo331tSs0C+GBZLwznUXtljFebb19eShSXKTCecvy04nffMHpGsO4UQifsVhGP6yyo5z Hj+QL3xf1I6G2szt7gtzudmGutsdVRT2P7dBP/J87Gwe29VweLfhsyI98yO3scYSuyVL +sUSWHPduky0htJjKZQ6kmfsZFDLadcVwNIk7fzJiyDHzdeSRhWEExiFDb06J8fpf9ST dRRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704580806; x=1705185606; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pjMgdeRpctwTJ7F3CFnuysHXKhIpRAp8TwJ6AUfLDG4=; b=hcdEi6Jnx1OHohYuypPDEGkunnDzyM5SwqtaIZK7dCq9bLT3G32evzxZ2k6qO6ok3C uhB5drSr2ZJkb4pvzWUsELXX4jzL9APf7ygebDMjxwCPqj7K5HvWvUoqMUIC5rHlDyWu fonxW+OmW03duUA8UbKnkxpG9RUzSOklp9Ul3+Q3YIjuiS/pUd1HX7twY1W/DrrVqXOl IXZZlsUVY60Gjh8jaVOXXnMDwYqVUkhP0FslGLpPkkrgJR3Xr9sD9n0k6Ye6Xdj0LtrP ux++jLcDTZvo6+4oWhfxFJBG8vdVOHjk45cAjCwQJpf+x5sxNLK4k1eb4LFfYMa++gGf XinQ== X-Gm-Message-State: AOJu0YzKMeGme657fGtRZLwmhQGD4fLr/HtRbl+u1pU5ATvgX+KDql4/ Dzys4DDv+o9EMAODBPQHnS3Z8J5S+2oyeA== X-Received: by 2002:a05:6e02:2402:b0:360:8928:2170 with SMTP id bs2-20020a056e02240200b0036089282170mr507707ilb.26.1704580805888; Sat, 06 Jan 2024 14:40:05 -0800 (PST) Received: from aford-System-Version.lan ([2601:447:d002:5be:af2f:17f0:33a3:d6fe]) by smtp.gmail.com with ESMTPSA id l13-20020a056e021c0d00b0035ffe828182sm735346ilh.37.2024.01.06.14.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 14:40:05 -0800 (PST) From: Adam Ford To: linux-pm@vger.kernel.org Cc: Adam Ford , Sandor Yu , Jacky Bai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Ulf Hansson , Lucas Stach , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] pmdomain: imx8mp-blk-ctrl: imx8mp_blk: Add fdcc clock to hdmimix domain Date: Sat, 6 Jan 2024 16:39:49 -0600 Message-ID: <20240106223951.387067-2-aford173@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240106223951.387067-1-aford173@gmail.com> References: <20240106223951.387067-1-aford173@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787382570293655226 X-GMAIL-MSGID: 1787382570293655226 According to i.MX8MP RM and HDMI ADD, the fdcc clock is part of hdmi rx verification IP that should not enable for HDMI TX. But actually if the clock is disabled before HDMI/LCDIF probe, LCDIF will not get pixel clock from HDMI PHY and print the error logs: [CRTC:39:crtc-2] vblank wait timed out WARNING: CPU: 2 PID: 9 at drivers/gpu/drm/drm_atomic_helper.c:1634 drm_atomic_helper_wait_for_vblanks.part.0+0x23c/0x260 Add fdcc clock to LCDIF and HDMI TX power domains to fix the issue. Signed-off-by: Sandor Yu Reviewed-by: Jacky Bai Signed-off-by: Adam Ford --- The original work was from Sandor on the NXP Down-stream kernel diff --git a/drivers/pmdomain/imx/imx8mp-blk-ctrl.c b/drivers/pmdomain/imx/imx8mp-blk-ctrl.c index e3203eb6a022..a56f7f92d091 100644 --- a/drivers/pmdomain/imx/imx8mp-blk-ctrl.c +++ b/drivers/pmdomain/imx/imx8mp-blk-ctrl.c @@ -55,7 +55,7 @@ struct imx8mp_blk_ctrl_domain_data { const char *gpc_name; }; -#define DOMAIN_MAX_CLKS 2 +#define DOMAIN_MAX_CLKS 3 #define DOMAIN_MAX_PATHS 3 struct imx8mp_blk_ctrl_domain { @@ -457,8 +457,8 @@ static const struct imx8mp_blk_ctrl_domain_data imx8mp_hdmi_domain_data[] = { }, [IMX8MP_HDMIBLK_PD_LCDIF] = { .name = "hdmiblk-lcdif", - .clk_names = (const char *[]){ "axi", "apb" }, - .num_clks = 2, + .clk_names = (const char *[]){ "axi", "apb", "fdcc" }, + .num_clks = 3, .gpc_name = "lcdif", .path_names = (const char *[]){"lcdif-hdmi"}, .num_paths = 1, @@ -483,8 +483,8 @@ static const struct imx8mp_blk_ctrl_domain_data imx8mp_hdmi_domain_data[] = { }, [IMX8MP_HDMIBLK_PD_HDMI_TX] = { .name = "hdmiblk-hdmi-tx", - .clk_names = (const char *[]){ "apb", "ref_266m" }, - .num_clks = 2, + .clk_names = (const char *[]){ "apb", "ref_266m", "fdcc" }, + .num_clks = 3, .gpc_name = "hdmi-tx", }, [IMX8MP_HDMIBLK_PD_HDMI_TX_PHY] = { From patchwork Sat Jan 6 22:39:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 185695 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:37c1:b0:101:2151:f287 with SMTP id y1csp307641dyq; Sat, 6 Jan 2024 14:41:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IFe6y9SRPQ9OdGAte33jLnlDXHoAgXIWOVKOH7Ao/Q8lN1W6yCE8iucOMxMyyAKQV35C6lr X-Received: by 2002:a05:6a21:3397:b0:18b:3c54:e6d8 with SMTP id yy23-20020a056a21339700b0018b3c54e6d8mr497929pzb.39.1704580862961; Sat, 06 Jan 2024 14:41:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704580862; cv=none; d=google.com; s=arc-20160816; b=XitlSxGxOWzfNbgY2qopfFJ+SKHPqrKhoVx2odgKXvwuolPp7l5QK2kmbH+IHrZgEc BkBn0ku6gdmrvbNxznElt9ZZnGBrz20CUl7ZNnO96/PLFxPMLMwKc4A7FcZdYnjZuvTz Z4w/pd1vpFw7s0fLWSnVxnjhqQnaAyRt9/WGeMVbIoF9a1VgJaN3b5wUj0E9fYKubK9n apB/kLNQ8zVy6+GhPiD06gBBXJIuH0Xh5dqbRNorXHI33XjIFAzmN8Hn68QdaPbFXUdn D/lhUTMm30XNE7voK85AWpdSccOKCjX3GAH2bK4UmZlEIjG6CwYblb3LJfi/kV3hvqEC THcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=TFJmQIFj0A0tInfs7hU9PMq1MKbXz8YKwehmuSMd3n8=; fh=ninfSsDtv+hy1GQUsvsBownsbWU02QVew4s1BTCkhz0=; b=Zf+FA3M2KhWD/WL2di7MO1hpZuRKlAKb51tfHB3TlG13WuC/yDGHlm6ANPsd1ZP1cV hcyo1yxm1TUubiJpi/q3Q6iaw5bLTS3xHSrLTQi4Pd0g2yRjRHrilXaxI1p/4vFNEjeP y1mIghULPI7JfIPyjP3WyHSaL0qDnKBItwH8+ZllO/MkAm5bJrIUFVmuaPuO60BWJNl2 aKCPBuPEnjdELsRnzLhw2IH/EDc/8lcpvXm+cL48jdiQxPjctowg9OQorpssBBuWR8cB 3AtqBLUsJkyOSSzlSk84VNAIxDFzk4P3ierSCzT6Mu1yqvPLHNErZT1Mhx1woU9mq2V0 5Sag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=lxlhELK6; spf=pass (google.com: domain of linux-kernel+bounces-18734-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18734-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id t3-20020a170902e84300b001d3974a7261si3637174plg.283.2024.01.06.14.41.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 14:41:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-18734-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=lxlhELK6; spf=pass (google.com: domain of linux-kernel+bounces-18734-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18734-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id DD5BBB21AD3 for ; Sat, 6 Jan 2024 22:41:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 882AC12B7D; Sat, 6 Jan 2024 22:40:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lxlhELK6" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B044F107B4; Sat, 6 Jan 2024 22:40:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-7bade847536so41218139f.0; Sat, 06 Jan 2024 14:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704580807; x=1705185607; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TFJmQIFj0A0tInfs7hU9PMq1MKbXz8YKwehmuSMd3n8=; b=lxlhELK6jKh7qXZC1wNbRPWJW5Dp3EAxSjD9hmrGZBfsZR3cljN1kxR0rs6hygJ9cz qE5cI3TF5kk0Zib0uwUx/R4X0YYNidfEHZvkCgBFoJRtOsI9ezrlqTkmeWvsulgRS43M 8jIeeTFUvXegbN8hzCeEqKvkQvxbvo4KkxhpLN74WeMRuU+GMqFoGnJ8Eyozmz0rRPp4 7SX60BpvabW1lwRuXVSCmXT5ZBdVNWNrL5WNvEb7ArlHIOcc7bPdPIxVjiuamWOURwWM dPqNd8/52BRaVozE7ghycE7ZWtYdxAe5Hn/M6I0XlMBq/q9Lu9MC0xJlnZwPUQItOE4K TD5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704580807; x=1705185607; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TFJmQIFj0A0tInfs7hU9PMq1MKbXz8YKwehmuSMd3n8=; b=mh2ziD1TFjGLG64mCx2DBA95KGUd+ery0RijGpmWgb2eUlp8uXAgEdGBuQ4xCDH9jE EK3hi9NN6Jri9IoeYEv3GV+orjMNadowu0oSiLVSv0JA10wVWt0YjdGyGjs0U/toWBg7 xzpi6GG4NyDDsolDXyprwlJRhcKxfRgfRDx1KF3t6jNdGnVf2/dgUOB+uDpPUPfYsU6z 51SbY4o84WLELwotYbueK/9KZ3SLVtA64D+B8K4dI9EBy5HH1YTqfdvNx6YGmNujGL+r SKHlIGaCK0+7EK4GlWzO/x8BoUv0kjbT+PB1OD/fc2f8Vv0yiJanjNADAExtPtK627A/ jWAg== X-Gm-Message-State: AOJu0YzLeCvz4E6GK0xZZ3krL8gzz7//2s56xjjwJiP5qOXA5k+qh1Q4 ppVI6Vo8wHmjIyN3n+aey4QU+iP/URSdtA== X-Received: by 2002:a05:6e02:1787:b0:360:197:55d1 with SMTP id y7-20020a056e02178700b00360019755d1mr3326542ilu.23.1704580807209; Sat, 06 Jan 2024 14:40:07 -0800 (PST) Received: from aford-System-Version.lan ([2601:447:d002:5be:af2f:17f0:33a3:d6fe]) by smtp.gmail.com with ESMTPSA id l13-20020a056e021c0d00b0035ffe828182sm735346ilh.37.2024.01.06.14.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 14:40:06 -0800 (PST) From: Adam Ford To: linux-pm@vger.kernel.org Cc: Lucas Stach , Adam Ford , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Ulf Hansson , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] arm64: dts: imx8mp: add HDMI power-domains Date: Sat, 6 Jan 2024 16:39:50 -0600 Message-ID: <20240106223951.387067-3-aford173@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240106223951.387067-1-aford173@gmail.com> References: <20240106223951.387067-1-aford173@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787382582514752378 X-GMAIL-MSGID: 1787382582514752378 From: Lucas Stach This adds the PGC and HDMI blk-ctrl nodes providing power control for HDMI subsystem peripherals. Signed-off-by: Lucas Stach Signed-off-by: Adam Ford --- V2: Added the fdcc to hdmi_blk_ctrl per NXP's downstream kernel guidance I (Adam) tried to help move this along, so I took Lucas' patch and attempted to apply fixes based on feedback. I don't have all the history, so apologies for that. diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index 76c73daf546b..d695c80e710c 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -836,6 +836,23 @@ pgc_mediamix: power-domain@10 { <&clk IMX8MP_CLK_MEDIA_APB_ROOT>; }; + pgc_hdmimix: power-domains@14 { + #power-domain-cells = <0>; + reg = ; + clocks = <&clk IMX8MP_CLK_HDMI_ROOT>, + <&clk IMX8MP_CLK_HDMI_APB>; + assigned-clocks = <&clk IMX8MP_CLK_HDMI_AXI>, + <&clk IMX8MP_CLK_HDMI_APB>; + assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_500M>, + <&clk IMX8MP_SYS_PLL1_133M>; + assigned-clock-rates = <500000000>, <133000000>; + }; + + pgc_hdmi_phy: power-domains@15 { + #power-domain-cells = <0>; + reg = ; + }; + pgc_mipi_phy2: power-domain@16 { #power-domain-cells = <0>; reg = ; @@ -1361,6 +1378,25 @@ eqos: ethernet@30bf0000 { intf_mode = <&gpr 0x4>; status = "disabled"; }; + + hdmi_blk_ctrl: blk-ctrl@32fc0000 { + compatible = "fsl,imx8mp-hdmi-blk-ctrl", "syscon"; + reg = <0x32fc0000 0x23c>; + clocks = <&clk IMX8MP_CLK_HDMI_APB>, + <&clk IMX8MP_CLK_HDMI_ROOT>, + <&clk IMX8MP_CLK_HDMI_REF_266M>, + <&clk IMX8MP_CLK_HDMI_24M>, + <&clk IMX8MP_CLK_HDMI_FDCC_TST>; + clock-names = "apb", "axi", "ref_266m", "ref_24m", "fdcc"; + power-domains = <&pgc_hdmimix>, <&pgc_hdmimix>, + <&pgc_hdmimix>, <&pgc_hdmimix>, + <&pgc_hdmimix>, <&pgc_hdmimix>, + <&pgc_hdmimix>, <&pgc_hdmi_phy>; + power-domain-names = "bus", "irqsteer", "lcdif", + "pai", "pvi", "trng", + "hdmi-tx", "hdmi-tx-phy"; + #power-domain-cells = <1>; + }; }; aips5: bus@30c00000 {