From patchwork Sun Nov 13 11:05:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: KaiLong Wang X-Patchwork-Id: 19340 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1637023wru; Sun, 13 Nov 2022 03:12:34 -0800 (PST) X-Google-Smtp-Source: AA0mqf4GCile18m/jYyIUyhkE+p/kctRW6yx7Ksg8guJ1K9DTzJAfr5T9QE0+I3y5ia7HWVXcuzk X-Received: by 2002:a17:90a:8a15:b0:211:b2b0:25d8 with SMTP id w21-20020a17090a8a1500b00211b2b025d8mr9385195pjn.54.1668337954370; Sun, 13 Nov 2022 03:12:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668337954; cv=none; d=google.com; s=arc-20160816; b=YwVeSaKfajjmaLHAVSNHyfLRwRgck1qYSR2CZfI8TS/fFH+/NwSRgQ7NQMTRiAmfF5 GcVfWQ5aVBtbGIEZ8uWuZgQyJi8q18fr2is14w4JFcy6pqNgSBeEwNLkXviUGawXcAWG zBvC/j3jRCZy4IXpvVaw5eA+H33tpxVz2oAE/HfwbkiD3GUdICUTEciAl0sq0O7TM9HV qK0XSe+SJjEsNr7ebHHhViobaeiO40Vd24ZFb+oPWtHz3cbX1cHUi2hqVwFScbdgArlR s3YPZ9Ye/8kxaQ4uwkU1irFdUolDsuAKeXVFPr5cdVTSzhWEAEUpZ6fpt0dehB1pNfoz O41w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:mime-version :content-transfer-encoding:subject:cc:to:from:date; bh=R6J8ojLO20NthJmOFNsGJy9Yxq377HV/YDQspK51HmY=; b=rKAVUNMTycEcYa0GS3/w1bVIZPDI4BiGpsQNiwwZvlRdvtUVAy6Nda1JNqwDuLVhQu KgvJ4D53n/bL2MIFJzh1hgp1zzfVn68xQ/lnXq8/rgsZ7iEHY0PenfCyvROHihufD9Ti 8bN54zf9MVj0d/c3NWL1Ubu363Y1QMPa0Gpo0kadL7/mNd8OqLZ2I9OVCb1leMs5jI18 p4S+s+CPMRXj+JCO5ntyzyXGDtFyJd5Av+Q9/epWDM4jYTQhe3L2TIb4yF0IotJk3kaP bRNaOd2lP0325MT4DBFTIjMeVz0WwdGn0AAW/qrkqt6DfQhmKTakxEwCLtyzdCwZF5TO mOpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x17-20020a170902ec9100b0017f9b980fadsi8236306plg.446.2022.11.13.03.12.21; Sun, 13 Nov 2022 03:12:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235153AbiKMLK4 (ORCPT + 99 others); Sun, 13 Nov 2022 06:10:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232799AbiKMLKy (ORCPT ); Sun, 13 Nov 2022 06:10:54 -0500 Received: from jari.cn (unknown [218.92.28.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E9F83FAEF; Sun, 13 Nov 2022 03:10:46 -0800 (PST) Received: by ajax-webmail-localhost.localdomain (Coremail) ; Sun, 13 Nov 2022 19:05:16 +0800 (GMT+08:00) X-Originating-IP: [182.148.14.167] Date: Sun, 13 Nov 2022 19:05:16 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: wangkailong@jari.cn To: mchehab@kernel.org, matthias.bgg@gmail.com, hverkuil-cisco@xs4all.nl, moudy.ho@mediatek.com, sunke32@huawei.com Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: platform: mtk-mdp3: add missing call to of_node_put() X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT6.0.1 build 20210329(c53f3fee) Copyright (c) 2002-2022 www.mailtech.cn mispb-4e503810-ca60-4ec8-a188-7102c18937cf-zhkzyfz.cn MIME-Version: 1.0 Message-ID: X-Coremail-Locale: zh_CN X-CM-TRANSID: AQAAfwCHj+Btz3BjBiIDAA--.63W X-CM-SenderInfo: 5zdqwypdlo00nj6mt2flof0/1tbiAQAEB2FEYx0DfwAhsE X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= X-Spam-Status: No, score=2.2 required=5.0 tests=BAYES_00,RCVD_IN_PBL,RDNS_NONE, T_SPF_HELO_PERMERROR,T_SPF_PERMERROR,XPRIO autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749379139147065679?= X-GMAIL-MSGID: =?utf-8?q?1749379139147065679?= Fix the following coccicheck warning: drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c:892:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 914. drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c:892:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 920. drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c:951:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 993. Signed-off-by: KaiLong Wang --- drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c index d3eaf8884412..4162fc732f38 100644 --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c @@ -908,6 +908,7 @@ static int mdp_comp_sub_create(struct mdp_dev *mdp) alias_id = mdp_comp_alias_id[type]; id = mdp_comp_get_id(type, alias_id); if (id < 0) { + of_node_put(node); dev_err(dev, "Fail to get sub comp. id: type %d alias %d\n", type, alias_id); @@ -916,8 +917,10 @@ static int mdp_comp_sub_create(struct mdp_dev *mdp) mdp_comp_alias_id[type]++; comp = mdp_comp_create(mdp, node, id); - if (IS_ERR(comp)) + if (IS_ERR(comp)) { + of_node_put(node); return PTR_ERR(comp); + } } return 0; @@ -988,6 +991,7 @@ int mdp_comp_config(struct mdp_dev *mdp) pdev = of_find_device_by_node(node); if (!pdev) { + of_node_put(node); dev_warn(dev, "can't find platform device of node:%s\n", node->name); return -ENODEV;