From patchwork Sat Jan 6 15:04:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 185641 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:37c1:b0:101:2151:f287 with SMTP id y1csp149074dyq; Sat, 6 Jan 2024 07:05:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IGVkiBoiMQE4W0jtmMAc+acRCsFM79JAxBhAkF/TNgB2IgUOaH9OPQ7EvyMv6KSHbaFTtmP X-Received: by 2002:a17:906:394:b0:a29:2ee5:e53d with SMTP id b20-20020a170906039400b00a292ee5e53dmr440010eja.52.1704553525456; Sat, 06 Jan 2024 07:05:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704553525; cv=none; d=google.com; s=arc-20160816; b=zEtclxaAaQ2wQ1mrU8UXt58TuySJsz/ZloNLFSRlZNFCVKErEVAlxAyQBAeFZV7t8L ERsnLg1Z2fGMmCX+1FIDNrkV/5ccwet4OyhmX92Wwk6vxqQdfDjFDaA8Db7r9ozczOSc 6+v9WZNf5jngycSyXzZtUZYhyAynKMl+tadhQVlE0yPsckJY4UjKw4iEfGMm+ahunUwk vvnWUl7udSJUcOmoLR5gVdHVJm2Q2o1DzG4kPmW6vHoWmSMN9eLGBV9TPgSW6YH1UM5n OdcnMLSZsEGtbGMj+43qSeoMYNdfRzyS0GnXJxOUMnCyurnkeQ4pigN7BWUrHJoOYC3d 1z1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=r+jORYiUTO9PmKWOcOQPyN1v50dStgTx0NZ6TsUFmhg=; fh=i3JX9lWeqzfNtXImZ4IYmlE7cDX/iI11DZ44Ll1VU/E=; b=0DxuibNb1LIIUdsI0edjZ+pT45Rzgwefz2N9xRcJBCEeVLG2Gee8Uj/KLW97mkAzKH d7U+5M7fpn+qKcL+dRJK/7ekbZBrPb7WTi+XygJMwwLlBqc2FXtI6nXvTQKxsdUl7d1H oltJ2Xm4iOBnSuvW3Nzy0zdaeSHF0pqD03tqzKlV2nmIK9Pa0Ty/lokJGXewyOakAWaY WsGq+M9yywi6AHJ/7j51hwqH83wnOzR+uZ6ZwWTm6tG/9F0bjXjUjvWnvLB0OXVi2T3u SO27zyzeMfMnKm1weoeAzLuq1iy4Bh7kSHaagntDyeQLl1FLVa1usUUTl+Tpafw59tb8 7qIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RUPPheLz; spf=pass (google.com: domain of linux-kernel+bounces-18614-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18614-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id y9-20020a1709063da900b00a2a13930388si243158ejh.624.2024.01.06.07.05.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 07:05:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-18614-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RUPPheLz; spf=pass (google.com: domain of linux-kernel+bounces-18614-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18614-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 0B6EF1F226A2 for ; Sat, 6 Jan 2024 15:05:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 79B9C8832; Sat, 6 Jan 2024 15:05:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RUPPheLz" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6570679F1; Sat, 6 Jan 2024 15:05:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-40d5ac76667so4301175e9.1; Sat, 06 Jan 2024 07:05:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704553499; x=1705158299; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=r+jORYiUTO9PmKWOcOQPyN1v50dStgTx0NZ6TsUFmhg=; b=RUPPheLzW22N2QQs5S6NQF8/yVYBaJ6A+oK0uEV65wGdWmaeXFtBinll7qDQP2y8PA VhzHejNXI7R0CRQAx05M2v8s4tno0R55yQQlKjAqf5YTtb4KjPmeIlhyWPIGfz+UcQeX Q5c2Jfs1VyK7v/5W5xFjE3UMyfHdp6btz+9Rh+JIcQ0kJv38JoCi3axGdpWOQG8m2Gd2 MbxZcoTrE+X2n3gdUD615pGPe6tMS2bxKBkizOQstHKHwh6tdHrCktSDsJk0OSoat8pX cr3Gwy4QH2OV2tQgLBdZns0F8dqAW4XrnZS068iWbjezdvCzPuXPWVFSpXb7hV1nxF1c yZVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704553499; x=1705158299; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r+jORYiUTO9PmKWOcOQPyN1v50dStgTx0NZ6TsUFmhg=; b=SaWOfD6jvvsKfr65eMzNo5dWV+bzitA1i02j7qyGUACCdzXJ3P/7NUMII8iNEbUjwq 6BYGobtUwOvlbRDCwDewdauK6t7QoQTJZQYOF+qRyjsfi1J6IJu4AXMFCdghFm6Q8AzC tDe5f2Tbn4Td0ZQgzbBV+ES1s4jVYrE6TZOtft3vL9oa2w/+al7RuR7Lo3v3eI4nccx0 h47q6zGU6tmKzxeyXJnL0ndwSZ54TVT/dl9GSCGvfIDVJva0g1WVctP2fLW14mSqEi4J kTYF5V3Ziip0P4uDOQOr6Sw5Mzwb5vBv7dJHNWT28wkfMm35AXzxQaoH24WtfCOnSN+Z OF3Q== X-Gm-Message-State: AOJu0YwJ3CudFtJ4wCwb9BEuKlr1xp7iNmRp4cw5b1Wb7YB3YN3Zi26K ILJochjhrRRFM5n7x/vUH6M= X-Received: by 2002:a05:600c:45c8:b0:40e:3f9f:8f76 with SMTP id s8-20020a05600c45c800b0040e3f9f8f76mr457834wmo.23.1704553499379; Sat, 06 Jan 2024 07:04:59 -0800 (PST) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id i1-20020a05600c354100b0040d8ff79fd8sm4942745wmq.7.2024.01.06.07.04.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 07:04:58 -0800 (PST) From: Colin Ian King To: Greg Kroah-Hartman , =?utf-8?q?Arve_Hj=C3=B8?= =?utf-8?q?nnev=C3=A5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] binder: remove redundant variable page_addr Date: Sat, 6 Jan 2024 15:04:57 +0000 Message-Id: <20240106150457.53423-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787353917512973605 X-GMAIL-MSGID: 1787353917512973605 From: Colin Ian King Variable page_addr is being assigned a value that is never read. The variable is redundant and can be removed. Cleans up clang scan build warning: warning: Value stored to 'page_addr' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King Acked-by: Carlos Llamas --- drivers/android/binder_alloc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c index ea5e1ba2d0d7..ed4ca6689c75 100644 --- a/drivers/android/binder_alloc.c +++ b/drivers/android/binder_alloc.c @@ -925,7 +925,6 @@ void binder_alloc_deferred_release(struct binder_alloc *alloc) int i; for (i = 0; i < alloc->buffer_size / PAGE_SIZE; i++) { - unsigned long page_addr; bool on_lru; if (!alloc->pages[i].page_ptr) @@ -933,7 +932,6 @@ void binder_alloc_deferred_release(struct binder_alloc *alloc) on_lru = list_lru_del_obj(&binder_freelist, &alloc->pages[i].lru); - page_addr = alloc->buffer + i * PAGE_SIZE; binder_alloc_debug(BINDER_DEBUG_BUFFER_ALLOC, "%s: %d: page %d %s\n", __func__, alloc->pid, i,