From patchwork Fri Jan 5 23:50:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 185571 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp6530153dyb; Fri, 5 Jan 2024 15:50:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IGKV9TKJUYDOjdEyDsyAnbTyBazr4xj6BGM/IOpK0X82QKVTOSr1WqJmmJTPVEcYbpbXjEP X-Received: by 2002:a50:9e0f:0:b0:555:bb88:cba3 with SMTP id z15-20020a509e0f000000b00555bb88cba3mr96438ede.27.1704498634935; Fri, 05 Jan 2024 15:50:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704498634; cv=none; d=google.com; s=arc-20160816; b=jAG+7zW2vlUhii9xB3JgnGa7eGC0rjvpxm15zVncSIDFC+f2Z+nJr1Fy+dNdsIdTiq HscQ9VOop4XTvjcDhWEhN7aW3CLtBId0/LDumy1/XjmmTgWI0jaJe4uZEMSG7d/gXx4J jZcfA/BtfJT45ug6fb5ICGh++94wLmGRwdTCx1HJ7m6cvR0Z2kpNsSCFZNXPGJ/6Sn1B gxuEO7Xe3K24WTbwVx7Tuhq9rhRHH7VUwobgDNOxKhPvDlAWjLRd9WTqS94C1s+GKGc+ /y0/IUQhn0DL2/fEkwyyX0xEpapEJHyO5SX2gRv5zXoKarY8wm1ILioFzqwGWeYaNMFZ hsJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:message-id:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:subject:date :from:dkim-signature; bh=zgIr5KjeQ801ktUcvEq9tOSFsZbUarwYEDM+BV8WLFA=; fh=JJtNQ4wzfMFaIbT4jzLu+mnV0xOBqwO6cwcow+dcnmo=; b=x7E4A3WzwrmNkEmYc/+eLg+gRpIHGGV6Pa4pJgYBILq0RH/3H+oexpGJqjPqlke/h6 DTayLft0RR/ZzIf11m3nPJ7Z5S2/VHikMRbIDiOU5JnAu2eHsjSh477ZFrqJJgI7BWUA 8V0ZGvPgJ0bgqlizVtVRd2xEz+8O+FJ9gf3UhDSkH8HKhNJfJtt++WFFKpIyCPwkpHCd um7HU57P05uxOnn7sePQqrq1o0o54KOZNdwm5/OyB8ZQlvT77+FYrpBEnCkPpMg54vPw JbQDLbQT5Ro1tw6nk0G4Mc6U1nUbwGBasz+P6bETMK62QP6DvGoZtrA1MUjB776F2Zn3 h5Zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YT6YAHVI; spf=pass (google.com: domain of linux-kernel+bounces-18423-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18423-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id m11-20020a056402510b00b00553044cd2f7si1096383edd.451.2024.01.05.15.50.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 15:50:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-18423-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YT6YAHVI; spf=pass (google.com: domain of linux-kernel+bounces-18423-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-18423-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8CDAD1F24577 for ; Fri, 5 Jan 2024 23:50:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5BEDC364B7; Fri, 5 Jan 2024 23:50:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YT6YAHVI" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5F35360B7 for ; Fri, 5 Jan 2024 23:50:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2cca5d81826so685091fa.2 for ; Fri, 05 Jan 2024 15:50:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704498613; x=1705103413; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=zgIr5KjeQ801ktUcvEq9tOSFsZbUarwYEDM+BV8WLFA=; b=YT6YAHVInHs/bJP5lG0FPUcvm3FtjDcTXWb4ehVMppo7UNNZ69xiYhXcMVosCmkiXE RrvFcpddWLXKKtrKAlONQNIpTF8jXdyHjnQ76WYNYJxxtoyc+5Ilth8IPFKX48sajmUd lYxbvmg1cJbIWRFZjfS+g4vUqYWmhtOxzFXsR52ABPHUGWnpgzb7z0r+/5gzSOvOgWfs 7U2H70PRyZlxPC3V5zLL15Pp5ARtvhb3KfIppX7K8eq5c7KYSYZWitenYSM6MvMuK0IH mxjwtowBZGwFxdIrjFAFmGbdWMLYzTWsRQisEq8yXdisOWUBJ39WMzso3TBfkMTSMXn7 u4Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704498613; x=1705103413; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zgIr5KjeQ801ktUcvEq9tOSFsZbUarwYEDM+BV8WLFA=; b=hJiRskE5PB1PjZ+diwZ3gXaHsTCwa1r3mnf/bCtLbKhP3It53aRn6cz4etRcO94n9O ncckYk0hCi21PxiLKvlDMMkFHn5Rthl7r2JePwpH1hGdiVozBuq/xHbTfyJ5kuDiYmhk c8w/cujUiu26wG2nnL8asnW0OriExcQs3VC/5rLCpm2s822QqGhpA1wkVQeUJ8075lC1 h2Uod/IydkMTago0AIiq23Ee4H268XpKuUeaD+VACNBWsZFK2Gzuqlfk7iUltSDJFw6+ +nXszrIlf3ry++IPjhxyoevb/mi3y08GZRuNBLwEDzLscbfgAtp7gklP9SDr2qmDwc8Y Nf+w== X-Gm-Message-State: AOJu0YzxAacWuTT0CdsMraUJavHHAZ4VRbdCyd4Xn077oqaRc49o98rf QycBsV/HxY1zjDoqKPk9WSOuFuV0VLgusA== X-Received: by 2002:a2e:9ed4:0:b0:2cc:675a:10ee with SMTP id h20-20020a2e9ed4000000b002cc675a10eemr50853ljk.78.1704498612830; Fri, 05 Jan 2024 15:50:12 -0800 (PST) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id x26-20020a2ea99a000000b002cceac0fdacsm465056ljq.126.2024.01.05.15.50.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 15:50:12 -0800 (PST) From: Dmitry Baryshkov Date: Sat, 06 Jan 2024 01:50:11 +0200 Subject: [PATCH] drm/msm/dpu: make "vblank timeout" more useful Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240106-fd-dpu-debug-timeout-v1-1-6d9762884641@linaro.org> X-B4-Tracking: v=1; b=H4sIALKVmGUC/x3MSQqAMAxA0atI1gZSlTpcRVyoTWsWDrRWBPHuF pdv8f8Dgb1wgC57wPMlQfYtQeUZzMu4OUYxyVBQUZEijdagOSIanqLDU1be44ncqtrSNDekS0j p4dnK/W/74X0/OpMcKGYAAAA= To: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1232; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=YlE6Y0Xns3P31n5Refq7dS9qQ/5BgtlDWj7ZX0gAmHE=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBlmJW0SyaFLLT16qHzBkNy9w9VfQQTtHjumXc8G ehTggFWw26JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZZiVtAAKCRCLPIo+Aiko 1Y/XCACauqkupaBDpfAh57h+imFyIUuQC+PVqXl/Xj6YmYMMfhgQSaWUbh+a7qObFJKzI/rc+Sm Tzqf9gSWXcgGZCbsHKj9K0f0eapMiGVOWCzYncRwOrSvDfZJ34Q5j42eRkpsFdl+iM0uFbOV9Mq 6e2RRnhEhHBxMgge7rkFNXZhjhAjI4PL/wVtAB/3M82FFy125DUo0nmUb3RNfomh+UXLJCPS377 ahwF4ewfR+2orJ0zHbYWIaxd+5d7dqF2sD4fbUdHMmq6P5z0BqGg8Cw4/ptyTstV3Zx9lMoPPCm mAEvZOMyhdjwZwssqGYGHpggNu8Nnn04tznaNUy+aAcQkWCp X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787296360946968858 X-GMAIL-MSGID: 1787296360946968858 We have several reports of vblank timeout messages. However after some debugging it was found that there might be different causes to that. Include the actual CTL_FLUSH value into the timeout message. This allows us to identify the DPU block that gets stuck. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 39676dfe52331dba909c617f213fdb21015c8d10 change-id: 20240106-fd-dpu-debug-timeout-e917f0bc8063 Best regards, diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c index d0f56c5c4cce..fb34067ab6af 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c @@ -489,7 +489,7 @@ static int dpu_encoder_phys_vid_wait_for_commit_done( (hw_ctl->ops.get_flush_register(hw_ctl) == 0), msecs_to_jiffies(50)); if (ret <= 0) { - DPU_ERROR("vblank timeout\n"); + DPU_ERROR("vblank timeout: %x\n", hw_ctl->ops.get_flush_register(hw_ctl)); return -ETIMEDOUT; }