From patchwork Thu Jan 4 14:57:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ding, Shenghao" X-Patchwork-Id: 185033 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp5660630dyb; Thu, 4 Jan 2024 07:00:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGPJpZHQW+NSxblurqvIBixt2R3xTbM2COpm4g+9P/j/SRwPHKUsznLxVNT8AMgO8BVCMc X-Received: by 2002:a05:6a20:be1f:b0:197:33ea:f45 with SMTP id ge31-20020a056a20be1f00b0019733ea0f45mr689446pzb.60.1704380443964; Thu, 04 Jan 2024 07:00:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704380443; cv=none; d=google.com; s=arc-20160816; b=PbpKWpznbgQi7BVJsaVKWzDTROa+Rq66fH58bTFTCbw7zsoa5b3RKf2/uDA0chSxEk pCy0kys1dSHOAVdkmkB5/JvgDowTMWRMai0L5C+SW7h6FeOWMCy4E2Am5LsOvls+2KBj Q8sG/jEa+KxQUeLJnCq2SaKbISaV5DGRtJX60zrX5tuUTWLQbo7q4h4n+ng7Qyzj4lCL ZcZT9v5J0ABWjljy2XKh2bZc7H6i8QiRL0UM78DA6amZ0TsM92DSSAZ1KWKWrXInuKLA QW7OUqLCJzH2WZh74Do5v4B7tRA3R/XV8bPCAWgvo8qq4XkWQ8TtvyB5NIv5J6tqJFx5 zcVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=8hWmAMoSrq6UPFSMfKTuynRM3F7QsEgFBw7C/guNTDQ=; fh=nmpqriIAxzz9z4/piqOabUsFkiEK8VDv7G5j+pvfHas=; b=aRAefASCSvta+jQ3niT7fKh6BBuqjDQYnva2zldyUZx3EGQolnwvns3uPf/hIamQow meiCZYkYMexWTYo+QqM8iDPF1MKEmhGgQyR2uZu6iAQDqSX8GAbxcAB62Em4X/DW1w2i IWaA3SwKwI3SyLZ3HlNKRa3n/h1Kq93gN0zt6eTq5aPrrLRjhxD9SlCS/0P/m4hFRaW+ hvk86ShLWpX8RQYqKo9ZnjKyaFVJSY+8GhUAT5c/Ubiux8SwFV7GMAhbpIEy5lK/uZlF Y21a7WvoPnhU6tiu2E9avSKYqVGOht3YJoCkuRV0NINZyewahY6q7H8XBadTDU+EyZ/M jHTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=tBWnpnvl; spf=pass (google.com: domain of linux-kernel+bounces-16816-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16816-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id w17-20020a056a0014d100b006dac20d935fsi1306983pfu.141.2024.01.04.07.00.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 07:00:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-16816-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=tBWnpnvl; spf=pass (google.com: domain of linux-kernel+bounces-16816-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16816-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2B67C287F84 for ; Thu, 4 Jan 2024 15:00:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 173DA24A0A; Thu, 4 Jan 2024 14:59:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="tBWnpnvl" X-Original-To: linux-kernel@vger.kernel.org Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4D4C241E8; Thu, 4 Jan 2024 14:59:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 404EvYYD047662; Thu, 4 Jan 2024 08:57:34 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1704380254; bh=8hWmAMoSrq6UPFSMfKTuynRM3F7QsEgFBw7C/guNTDQ=; h=From:To:CC:Subject:Date; b=tBWnpnvlhU3m6KuMUBDrZiFi/Yo/VeyrrMNtXONvaC9rQanRfPyPLiFojhWxM8HD1 ihM+4qsW2Aegj/IF2v8Uny8W3cTvup1eG+B+v5llHJmj4lJTly0/5qLz3QlhI7e6kv 6fWL5RGpgOp4TLWV+bAc/+OEW6HNWZ6Mrh/evXZM= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 404EvYuc034161 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 4 Jan 2024 08:57:34 -0600 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 4 Jan 2024 08:57:33 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 4 Jan 2024 08:57:33 -0600 Received: from LT5CG31242FY.dhcp.ti.com ([10.250.161.227]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 404EvPfM105959; Thu, 4 Jan 2024 08:57:26 -0600 From: Shenghao Ding To: , , CC: , , , , , , , , <13916275206@139.com>, , , , , , , , Shenghao Ding Subject: [PATCH v5 1/4] ASoC: dt-bindings: move tas2563 from tas2562.yaml to tas2781.yaml Date: Thu, 4 Jan 2024 22:57:16 +0800 Message-ID: <20240104145721.1398-1-shenghao-ding@ti.com> X-Mailer: git-send-email 2.33.0.windows.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787172428608416638 X-GMAIL-MSGID: 1787172428608416638 Move tas2563 from tas2562.yaml to tas2781.yaml to unbind tas2563 from tas2562 driver code and bind it to tas2781 driver code, because tas2563 only work in bypass-DSP mode with tas2562 driver. In order to enable DSP mode for tas2563, it has been moved to tas2781 driver. As to the hardware part, such as register setting and DSP firmware, all these are stored in the binary firmware. What tas2781 drivder does is to parse the firmware and download it to the chip, then power on the chip. So, tas2781 driver can be resued as tas2563 driver. Only attention will be paid to downloading corresponding firmware. Signed-off-by: Shenghao Ding Reviewed-by: Krzysztof Kozlowski --- Change in v5: - remove tas2563, which will be move to tas2781 driver. - Add more comments on why to move tas2563 to tas2781 driver. - Provide rationale in terms of bindings and hardware, not in terms of driver. Or at least not only. - Reorder chip, tas2563 is first, tas2781 is second. - Add datasheet linkings. - squash both tas2562 and tas2781 binding patches. - Put allOf: to the end of the file, after required: block. - restore the widest constraints of minItems/maxItems at reg. --- .../devicetree/bindings/sound/tas2562.yaml | 2 - .../devicetree/bindings/sound/ti,tas2781.yaml | 78 +++++++++++++++---- 2 files changed, 63 insertions(+), 17 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/tas2562.yaml b/Documentation/devicetree/bindings/sound/tas2562.yaml index f01c0dde0cf7..d28c102c0ce7 100644 --- a/Documentation/devicetree/bindings/sound/tas2562.yaml +++ b/Documentation/devicetree/bindings/sound/tas2562.yaml @@ -18,7 +18,6 @@ description: | Specifications about the audio amplifier can be found at: https://www.ti.com/lit/gpn/tas2562 - https://www.ti.com/lit/gpn/tas2563 https://www.ti.com/lit/gpn/tas2564 https://www.ti.com/lit/gpn/tas2110 @@ -29,7 +28,6 @@ properties: compatible: enum: - ti,tas2562 - - ti,tas2563 - ti,tas2564 - ti,tas2110 diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml index a69e6c223308..976238689249 100644 --- a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml +++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml @@ -5,36 +5,46 @@ $id: http://devicetree.org/schemas/sound/ti,tas2781.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Texas Instruments TAS2781 SmartAMP +title: Texas Instruments TAS2563/TAS2781 SmartAMP maintainers: - Shenghao Ding -description: - The TAS2781 is a mono, digital input Class-D audio amplifier - optimized for efficiently driving high peak power into small - loudspeakers. An integrated on-chip DSP supports Texas Instruments - Smart Amp speaker protection algorithm. The integrated speaker - voltage and current sense provides for real time +description: | + The TAS2563/TAS2781 is a mono, digital input Class-D audio + amplifier optimized for efficiently driving high peak power into + small loudspeakers. An integrated on-chip DSP supports Texas + Instruments Smart Amp speaker protection algorithm. The + integrated speaker voltage and current sense provides for real time monitoring of loudspeaker behavior. -allOf: - - $ref: dai-common.yaml# + Specifications about the audio amplifier can be found at: + https://www.ti.com/lit/gpn/tas2563 + https://www.ti.com/lit/gpn/tas2781 properties: compatible: - enum: - - ti,tas2781 + description: | + ti,tas2563: 6.1-W Boosted Class-D Audio Amplifier With Integrated + DSP and IV Sense, 16/20/24/32bit stereo I2S or multichannel TDM. + + ti,tas2781: 24-V Class-D Amplifier with Real Time Integrated Speaker + Protection and Audio Processing, 16/20/24/32bit stereo I2S or + multichannel TDM. + oneOf: + - items: + - enum: + - ti,tas2563 + - const: ti,tas2781 + - enum: + - ti,tas2781 reg: description: - I2C address, in multiple tas2781s case, all the i2c address + I2C address, in multiple-AMP case, all the i2c address aggregate as one Audio Device to support multiple audio slots. maxItems: 8 minItems: 1 - items: - minimum: 0x38 - maximum: 0x3f reset-gpios: maxItems: 1 @@ -49,6 +59,44 @@ required: - compatible - reg +allOf: + - $ref: dai-common.yaml# + - if: + properties: + compatible: + contains: + enum: + - ti,tas2563 + then: + properties: + reg: + description: + I2C address, in multiple-AMP case, all the i2c address + aggregate as one Audio Device to support multiple audio slots. + maxItems: 4 + minItems: 1 + items: + minimum: 0x4c + maximum: 0x4f + + - if: + properties: + compatible: + contains: + enum: + - ti,tas2781 + then: + properties: + reg: + description: + I2C address, in multiple-AMP case, all the i2c address + aggregate as one Audio Device to support multiple audio slots. + maxItems: 8 + minItems: 1 + items: + minimum: 0x38 + maximum: 0x3f + additionalProperties: false examples: From patchwork Thu Jan 4 14:57:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ding, Shenghao" X-Patchwork-Id: 185032 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp5660613dyb; Thu, 4 Jan 2024 07:00:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IEDkkK4i1kNpNEnSIlFF/r/+yjNkfiDhM8HLdakng+H8XJlx/lus+TIoWRxBLzrkB+KrnQY X-Received: by 2002:a05:6a20:3826:b0:196:7e8d:aef7 with SMTP id p38-20020a056a20382600b001967e8daef7mr578403pzf.19.1704380442911; Thu, 04 Jan 2024 07:00:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704380442; cv=none; d=google.com; s=arc-20160816; b=aNwTkAmbzz9tbcm/bUqi1fHAPxYJxpfl04HGpulPTGuj0LT9kFrN069PX9+yXCM5Ng T1etzOLRjlgAo/4hrY7tfVnjv2UFuYARTlZ/zoikSpeTDRcO6YkdHVL3k9bhD4m+mx48 VCezEHZj63L6XQVYfg86x8axZ80OhgI3jqHlvUYqnOP/Tr1ZqH95OyaR6xTYvj6d3q39 xB2ESfbcDUWoLFUGLPwknQMoLBj1BJ4dk7g1IVbb9nu4wRcr5Bfz02DY93KMq0VIvAvV j8RDtsAhax2AKwXk+ZKYmk0OWawaL9RywhGLsfkzW5kOtPvaIYzdi71C7j6al+l6hq0t bcDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=DsfckQaYzNb7/dN+G/t2Cwkcac/YIBW5lT5+D6M+jvQ=; fh=nmpqriIAxzz9z4/piqOabUsFkiEK8VDv7G5j+pvfHas=; b=Z6qrAqXAOssVnZumrgj+JMOsPF90leK5mlnUVqYZxzsGLbnCHye/27oEJWlTA19VKi kmUXLzqMBHvwApBoe545RlC/LXYVy5gGjaxu1V8bOvE88kCQ+8cFdm8G2ketUcvVXjkJ T4tWEfb9ffgpdyapsN9KxgyTmrPATBebGEe9BEFqgmlqI/PxdPWc81kLNnCrmVVEnccZ qVNJZPYX/zWIsEEz9Oh8f8gZlmGq7RYGL/Pc5PekTCfJXPzEXxLrL190ZdtTLvH36Ecs menun/53z6ZiVQ9AtY6umB8b6eBUiA8DQiXwZnW7bXyBIzRbEoxfXeKaFu4ECALo1TLT Rczw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=uPHA1uhd; spf=pass (google.com: domain of linux-kernel+bounces-16815-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16815-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id b7-20020a655cc7000000b005cdf71d561esi21385324pgt.683.2024.01.04.07.00.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 07:00:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-16815-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=uPHA1uhd; spf=pass (google.com: domain of linux-kernel+bounces-16815-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16815-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1092F286B84 for ; Thu, 4 Jan 2024 15:00:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F001124A08; Thu, 4 Jan 2024 14:59:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="uPHA1uhd" X-Original-To: linux-kernel@vger.kernel.org Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4D21241E7; Thu, 4 Jan 2024 14:59:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 404EvfD1047684; Thu, 4 Jan 2024 08:57:41 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1704380261; bh=DsfckQaYzNb7/dN+G/t2Cwkcac/YIBW5lT5+D6M+jvQ=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=uPHA1uhduQRxxBdh+htc7mzoGcUQLY9alZoM1o6N0vwDuQYcWTX83fRHbHwwIp2H6 c8rQ4aafowNYTy/AMgb+ovnBJOHhIpCNmb9xZK9FrV7njpMjUHsigQXx2bSIDjulr+ YxOBRa+egPTsOQIxr8af2Zz5CfcFYYP/KS/AzpnM= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 404Evfh5034232 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 4 Jan 2024 08:57:41 -0600 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 4 Jan 2024 08:57:41 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 4 Jan 2024 08:57:41 -0600 Received: from LT5CG31242FY.dhcp.ti.com ([10.250.161.227]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 404EvPfN105959; Thu, 4 Jan 2024 08:57:35 -0600 From: Shenghao Ding To: , , CC: , , , , , , , , <13916275206@139.com>, , , , , , , , Shenghao Ding Subject: [PATCH v5 2/4] ASoC: tas2562: move tas2563 from tas2562 driver to tas2781 driver Date: Thu, 4 Jan 2024 22:57:17 +0800 Message-ID: <20240104145721.1398-2-shenghao-ding@ti.com> X-Mailer: git-send-email 2.33.0.windows.2 In-Reply-To: <20240104145721.1398-1-shenghao-ding@ti.com> References: <20240104145721.1398-1-shenghao-ding@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787172427048878295 X-GMAIL-MSGID: 1787172427048878295 Move tas2563 from tas2562 driver to tas2781 driver to unbind tas2563 from tas2562 driver code and bind it to tas2781 driver code, because tas2563 only work in bypass-DSP mode with tas2562 driver. In order to enable DSP mode for tas2563, it has been moved to tas2781 driver. As to the hardware part, such as register setting and DSP firmware, all these are stored in the binary firmware. What tas2781 drivder does is to parse the firmware and download it to the chip, then power on the chip. So, tas2781 driver can be resued as tas2563 driver. Only attention will be paid to downloading corresponding firmware. Signed-off-by: Shenghao Ding --- Change in v5: - Move tas2563 from tas2562 driver to tas2781 driver. - Add more comments on why move tas2563 to tas2781 driver. - Provide rationale in terms of bindings and hardware, not in terms of driver. Or at least not only. --- sound/soc/codecs/tas2562.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c index 962c2cdfa017..54561ae598b8 100644 --- a/sound/soc/codecs/tas2562.c +++ b/sound/soc/codecs/tas2562.c @@ -59,7 +59,6 @@ struct tas2562_data { enum tas256x_model { TAS2562, - TAS2563, TAS2564, TAS2110, }; @@ -721,7 +720,6 @@ static int tas2562_parse_dt(struct tas2562_data *tas2562) static const struct i2c_device_id tas2562_id[] = { { "tas2562", TAS2562 }, - { "tas2563", TAS2563 }, { "tas2564", TAS2564 }, { "tas2110", TAS2110 }, { } @@ -770,7 +768,6 @@ static int tas2562_probe(struct i2c_client *client) #ifdef CONFIG_OF static const struct of_device_id tas2562_of_match[] = { { .compatible = "ti,tas2562", }, - { .compatible = "ti,tas2563", }, { .compatible = "ti,tas2564", }, { .compatible = "ti,tas2110", }, { }, From patchwork Thu Jan 4 14:57:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ding, Shenghao" X-Patchwork-Id: 185031 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp5660216dyb; Thu, 4 Jan 2024 07:00:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IHLqQ9uEokRJHz3Kjlsl8VjFUzPbktKsg6CLuEutzifSJKinD5cLL9yPEAyYw12QkJJgUjl X-Received: by 2002:a17:903:483:b0:1d4:e0e6:6b4 with SMTP id jj3-20020a170903048300b001d4e0e606b4mr384064plb.27.1704380416485; Thu, 04 Jan 2024 07:00:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704380416; cv=none; d=google.com; s=arc-20160816; b=veRU3xZ0jkmwIvQ0/SgD+lNjNfTwl7cC2kwt1Sk+DIeWATxopUMFy8Vu5kwQjG5gi1 TzHn384V5mrxFgfVRAC0+sBovVPNn4wTs0I/2ZJqwT03ZaJrUy7pAiaTycdyKX847mWo wKqM24xnlErP8JZMY1YKGsxAke8s2XdTleg7e9W7/0M9YbjVj2J9bxe8GAfTY9xFpOfy kjiPgQwSE/FTDtjWgFDbLsl0WmAAIcajFbDS+muyETCsQBqey1mYs7hzswxOnFUbeLAa El/R3gY+lV3a0S+OZ7hDkgdMG8fBxB679wtepACr0kkP2A1At2iSQVjHOEEILLSVskBN HVmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=xh3RmFWtFRhsE0WfSJVrIa9/MFg7kvHXYymcnBeoVsg=; fh=nmpqriIAxzz9z4/piqOabUsFkiEK8VDv7G5j+pvfHas=; b=Y3DX/jJoWIwEJEyC3PCjVARrOl6lXaUK1MgtQXepLO+X0CYXb8ZfT5aGZRp1c75R6Q MSpUT9kZnpNCYogYxSL70aJcTJbiliBUz/1lm+Gc+eiheWS1/m7xU99QytyQZq8jvxy3 EekuIad2wxpGb1JirueVTNnSfEIu3CRhCkTuOA6F8OYiCVUxrvVIST4S0Q4aff2AtbIw CNqhJ9/3vPi1sjW3hcObtycvweUgyjnggeSYlhTb7NByx1r8QB5ZHAWXymyLC1Gn8RyR 2m5zu/ZzgbxDr6E2BJqgAldQWWEo2j5q0ZW8YDkLmYxoap6n2KrQ2jcxPYRdS08NtVwv lg0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=uxunJUah; spf=pass (google.com: domain of linux-kernel+bounces-16814-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16814-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id a19-20020a170902ee9300b001cf9e86314dsi23528419pld.637.2024.01.04.07.00.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 07:00:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-16814-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=uxunJUah; spf=pass (google.com: domain of linux-kernel+bounces-16814-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16814-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 76077287DA7 for ; Thu, 4 Jan 2024 15:00:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0184D241FB; Thu, 4 Jan 2024 14:59:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="uxunJUah" X-Original-To: linux-kernel@vger.kernel.org Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D96AF20DFF; Thu, 4 Jan 2024 14:59:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 404EvoKY094833; Thu, 4 Jan 2024 08:57:50 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1704380270; bh=xh3RmFWtFRhsE0WfSJVrIa9/MFg7kvHXYymcnBeoVsg=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=uxunJUahTuhAa/rXdSnZuhs8v6jat9ergWlb86hLALancYy1nTWh0f+GL+2YoOGkD aDc6Wv1cDOGoutIBV10YizpQZgNMUvnoYsrkNgeZ/7PvPS+gBumFQDy90KYOGCRqeQ AF6BwD7op788FYSfoveLMcOKllIPXn3yR4y01pb4= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 404Evow4067796 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 4 Jan 2024 08:57:50 -0600 Received: from DLEE108.ent.ti.com (157.170.170.38) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 4 Jan 2024 08:57:49 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 4 Jan 2024 08:57:49 -0600 Received: from LT5CG31242FY.dhcp.ti.com ([10.250.161.227]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 404EvPfO105959; Thu, 4 Jan 2024 08:57:43 -0600 From: Shenghao Ding To: , , CC: , , , , , , , , <13916275206@139.com>, , , , , , , , Shenghao Ding Subject: [PATCH v5 3/4] ASoC: tas2781: Add tas2563 into header file for DSP mode Date: Thu, 4 Jan 2024 22:57:18 +0800 Message-ID: <20240104145721.1398-3-shenghao-ding@ti.com> X-Mailer: git-send-email 2.33.0.windows.2 In-Reply-To: <20240104145721.1398-1-shenghao-ding@ti.com> References: <20240104145721.1398-1-shenghao-ding@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787172399274268815 X-GMAIL-MSGID: 1787172399274268815 Move tas2563 from tas2562 header file to tas2781 header file to unbind tas2563 from tas2562 driver code and bind it to tas2781 driver code, because tas2563 only work in bypass-DSP mode with tas2562 driver. In order to enable DSP mode for tas2563, it has been moved to tas2781 driver. As to the hardware part, such as register setting and DSP firmware, all these are stored in the binary firmware. What tas2781 drivder does is to parse the firmware and download it to the chip, then power on the chip. So, tas2781 driver can be resued as tas2563 driver. Only attention will be paid to downloading corresponding firmware. Signed-off-by: Shenghao Ding --- Change in v5: - Move tas2563 to tas2781 driver. - Add more comments on why move tas2563 to tas2781 driver. - Provide rationale in terms of bindings and hardware, not in terms of driver. Or at least not only. - leave comma as the last entry is _not_ a terminator. - Make the enum order, tas2563 is first, tas2781 is second. --- include/sound/tas2781.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/include/sound/tas2781.h b/include/sound/tas2781.h index a6c808b22318..813cf9446a58 100644 --- a/include/sound/tas2781.h +++ b/include/sound/tas2781.h @@ -1,13 +1,13 @@ /* SPDX-License-Identifier: GPL-2.0 */ // -// ALSA SoC Texas Instruments TAS2781 Audio Smart Amplifier +// ALSA SoC Texas Instruments TAS2563/TAS2781 Audio Smart Amplifier // // Copyright (C) 2022 - 2023 Texas Instruments Incorporated // https://www.ti.com // -// The TAS2781 driver implements a flexible and configurable +// The TAS2563/TAS2781 driver implements a flexible and configurable // algo coefficient setting for one, two, or even multiple -// TAS2781 chips. +// TAS2563/TAS2781 chips. // // Author: Shenghao Ding // Author: Kevin Lu @@ -59,7 +59,8 @@ #define TASDEVICE_CMD_FIELD_W 0x4 enum audio_device { - TAS2781 = 0, + TAS2563, + TAS2781, }; enum device_catlog_id { From patchwork Thu Jan 4 14:57:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ding, Shenghao" X-Patchwork-Id: 185034 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp5660719dyb; Thu, 4 Jan 2024 07:00:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFJCevMTxquUF6RHdxSJ30ZuzXpTqFxOzaldS4tpe/vsR1JIn1VV6orBtl1uSUi3Ls3UZV6 X-Received: by 2002:a05:6214:c49:b0:67f:935c:3b22 with SMTP id r9-20020a0562140c4900b0067f935c3b22mr615683qvj.108.1704380451112; Thu, 04 Jan 2024 07:00:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704380451; cv=none; d=google.com; s=arc-20160816; b=RKXs4/iXvmGDygXIRCWVOX2ewzOar4RbGJcoOt+ZWniQwGoN4jv5AWBCey44GADaed PnpWIj3N+tqAQIFg2Y+n23B8HseLiWxvX0XMZdCgpR+Gu0gq9uNsGUzYjFkYjCnoOnz5 PtEjwVkKMA7cdPnxAnUAYoKRi1xrg507YcoZ4XiNh+Nw3wlLk5bzJvK8mHiSOc6DOKp7 ZltCx43ECx5PD+4XIGzWoneh5ZQwiZ2bk+p1EpUOE2FujuoiRuBKxTEYwQ9m/ueOX8OU KPW4JxOSzK63geLWrFztO3ZJMwSjadvAqJoho24MVBcEZRPuK9n3OGfNbAW98pQs5ugc b9Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=tpsiP9S7pAPpPw0380V2GtyMNvsYeXNqBBFLduNiK5w=; fh=nmpqriIAxzz9z4/piqOabUsFkiEK8VDv7G5j+pvfHas=; b=oEjg+eVrug/JENW+nmka92PXiMOWNsC7oi01EaTxYABbCLkTl0oIGRiTnXPykA/sx0 nC8UyqvlVq/7gvUGgiVDWA8X4ozLkW9xB1DVdRh646qwT63j1Q5+Uh2mOe24xRgKA39u FnDAZff9SPr3cOqqZ/cWahhNmJTL6BNRAZWY1L7u4g6g7gExkwKK+TaVe7I31feoJBRh jiZsA6GDhyWYJzQwvZ2gas4zn+UEvjkbClG6JHlEc7CGct4QpwxX+5MgaCct6wETuzj5 cqcv5jo+CGX9sI4J7lLD++7SJza3OK8xN6KcDJ0g18Thgw5MEBwWVSVPZ+HdUSamId3d tUww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=PUAC30ca; spf=pass (google.com: domain of linux-kernel+bounces-16817-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16817-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id g1-20020a0cdf01000000b0067f26df4442si28748425qvl.150.2024.01.04.07.00.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 07:00:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-16817-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=PUAC30ca; spf=pass (google.com: domain of linux-kernel+bounces-16817-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16817-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E12611C2168D for ; Thu, 4 Jan 2024 15:00:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EF352241F5; Thu, 4 Jan 2024 14:59:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="PUAC30ca" X-Original-To: linux-kernel@vger.kernel.org Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D84BA249FD; Thu, 4 Jan 2024 14:59:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 404EvwlH014903; Thu, 4 Jan 2024 08:57:58 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1704380278; bh=tpsiP9S7pAPpPw0380V2GtyMNvsYeXNqBBFLduNiK5w=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=PUAC30caudaxVIi74hAcs+gAShKCn6IQbIr8yoJn3fXN+6mbSzeRl541yWj2WxTL6 zA6an5GOenDTdB2p1XwUm3dtbBnSM3xGlH+pz6RM5JLW93QF6bbsjtcAdyWkmyCoDC 9F9bxHejpwEng4zOQaLiogkzwbO4Db7PVQxk3eOg= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 404EvwRx126414 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 4 Jan 2024 08:57:58 -0600 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 4 Jan 2024 08:57:58 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 4 Jan 2024 08:57:58 -0600 Received: from LT5CG31242FY.dhcp.ti.com ([10.250.161.227]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 404EvPfP105959; Thu, 4 Jan 2024 08:57:51 -0600 From: Shenghao Ding To: , , CC: , , , , , , , , <13916275206@139.com>, , , , , , , , Shenghao Ding Subject: [PATCH v5 4/4] ASoC: tas2781: Add tas2563 into driver Date: Thu, 4 Jan 2024 22:57:19 +0800 Message-ID: <20240104145721.1398-4-shenghao-ding@ti.com> X-Mailer: git-send-email 2.33.0.windows.2 In-Reply-To: <20240104145721.1398-1-shenghao-ding@ti.com> References: <20240104145721.1398-1-shenghao-ding@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787172435603630492 X-GMAIL-MSGID: 1787172435603630492 Move tas2563 from tas2562 driver to tas2781 driver to unbind tas2563 from tas2562 driver code and bind it to tas2781 driver code, because tas2563 only work in bypass-DSP mode with tas2562 driver. In order to enable DSP mode for tas2563, it has been moved to tas2781 driver. As to the hardware part, such as register setting and DSP firmware, all these are stored in the binary firmware. What tas2781 drivder does is to parse the firmware and download it to the chip, then power on the chip. So, tas2781 driver can be resued as tas2563 driver. Only attention will be paid to downloading corresponding firmware. Signed-off-by: Shenghao Ding --- Change in v5: - Add tas2563 to tas2781 driver. - Add more comments on why move tas2563 to tas2781 driver. - Provide rationale in terms of bindings and hardware, not in terms of driver. Or at least not only. - In all cases, to make the lists ordered by a chip model, tas2563 is first, tas2781 is second. --- sound/soc/codecs/tas2781-i2c.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c index 55cd5e3c23a5..bd5ef4ff96fe 100644 --- a/sound/soc/codecs/tas2781-i2c.c +++ b/sound/soc/codecs/tas2781-i2c.c @@ -1,13 +1,13 @@ // SPDX-License-Identifier: GPL-2.0 // -// ALSA SoC Texas Instruments TAS2781 Audio Smart Amplifier +// ALSA SoC Texas Instruments TAS2563/TAS2781 Audio Smart Amplifier // // Copyright (C) 2022 - 2023 Texas Instruments Incorporated // https://www.ti.com // -// The TAS2781 driver implements a flexible and configurable +// The TAS2563/TAS2781 driver implements a flexible and configurable // algo coefficient setting for one, two, or even multiple -// TAS2781 chips. +// TAS2563/TAS2781 chips. // // Author: Shenghao Ding // Author: Kevin Lu @@ -32,6 +32,7 @@ #include static const struct i2c_device_id tasdevice_id[] = { + { "tas2563", TAS2563 }, { "tas2781", TAS2781 }, {} }; @@ -39,6 +40,7 @@ MODULE_DEVICE_TABLE(i2c, tasdevice_id); #ifdef CONFIG_OF static const struct of_device_id tasdevice_of_match[] = { + { .compatible = "ti,tas2563" }, { .compatible = "ti,tas2781" }, {}, };